pgAdmin 4 commit: Ignore generated file

2018-04-09 Thread Dave Page 
Ignore generated file

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9464e04cf851264733cda2e377689ec32901814c

Modified Files
--
runtime/.gitignore | 1 +
1 file changed, 1 insertion(+)

Re: Building releases...

2018-04-09 Thread Dave Page 
It works like that for me too. Try running from the runtime.

On Mon, Apr 9, 2018 at 2:39 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> I tried and it is working fine.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Mon, Apr 9, 2018 at 6:57 PM, Neel Patel 
> wrote:
>
>>
>>
>> On Mon, Apr 9, 2018 at 6:51 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Apr 9, 2018 at 2:20 PM, Neel Patel 
>>> wrote:
>>>
 Hi Dave,

 On Mon, Apr 9, 2018 at 6:33 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Apr 9, 2018 at 6:19 PM, Dave Page  wrote:
>
>> Oh yeah - I forgot to mention that running it in PyCharms seems to
>> work. The issue comes when using the runtime from what I can see (even
>> using the exact same venv that works otherwise).
>>
>> Didn't try on windows. Let me try.
>
>> On Mon, Apr 9, 2018 at 1:46 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Did not try running pgAdmin4 on windows from git repo.
>>> Let me get the latest pull and check.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Mon, Apr 9, 2018 at 5:53 PM, Dave Page  wrote:
>>>
 ... is really not going well today.

 After arguing with PIP on Mac for some time, I eventually managed
 to get a build out. That required a manual update of my system to 
 9.0.3 to
 ensure TLS 1.2 worked, and then changing to build such that we only 
 force
 our own build of Psycopg2, and not other Python packages. I *think* 
 these
 issues are related to the whole PyPi TLS 1.2/PIP 9.0.3 brownouts and 
 other
 works they've been doing.

 The Windows build is a whole other ballgame. The build itself runs
 just fine, but we end up with the following error in the log:

 Traceback (most recent call last):
   File "C:/Program Files/pgAdmin 4/v3/web/pgAdmin4.py", line 70, in
 
 app = create_app()
   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\__init__.py",
 line 367, in create_app
 driver.init_app(app)
   File "C:\Program Files\pgAdmin 
 4\v3\web\pgadmin\utils\driver\__init__.py",
 line 40, in init_app
 DriverRegistry.load_drivers()
   File "C:\Program Files\pgAdmin 
 4\v3\web\pgadmin\utils\driver\registry.py",
 line 88, in load_drivers
 module = import_module(module_name)
   File "C:/Program Files/pgAdmin 4/v3/venv\lib\importlib\__init__.py",
 line 37, in import_module
 __import__(name)
   File "C:\Program Files\pgAdmin 
 4\v3\web\pgadmin\utils\driver\psycopg2\__init__.py",
 line 26, in 
 from .connection import Connection
   File "C:\Program Files\pgAdmin 
 4\v3\web\pgadmin\utils\driver\psycopg2\connection.py",
 line 25, in 
 from pgadmin.utils.crypto import decrypt
   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\crypto.py",
 line 16, in 
 from Crypto.Cipher import AES
   File "C:/Program Files/pgAdmin 
 4/v3/venv/Lib/site-packages\Crypto\Cipher\__init__.py",
 line 3, in 
 from Crypto.Cipher._mode_ecb import _create_ecb_cipher
   File "C:/Program Files/pgAdmin 
 4/v3/venv/Lib/site-packages\Crypto\Cipher\_mode_ecb.py",
 line 46, in 
 """
   File "C:/Program Files/pgAdmin 
 4/v3/venv/Lib/site-packages\Crypto\Util\_raw_api.py",
 line 258, in load_pycryptodome_raw_lib
 raise OSError("Cannot load native module '%s': %s" % (name, ",
 ".join(attempts)))
 OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying
 '_raw_ecb.pyd': [Error 126] The specified module could not be found
 Exception KeyError: KeyError(3644,) in >>> 'C:/Program Files/pgAdmin 4/v3/venv\lib\threading.py'> ignored

 The module does exist of course in the Crypto\Cipher directory.

>>>
 Everything works fine on my windows machine with Python 3.5.
 Any specific scenarios ?

>>>
>>> Standard release build using Python 2.7;
>>>
>>> make x86
>>>
>> Let me try with Python 2.7 x86.
>>
>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB

Re: Building releases...

2018-04-09 Thread Neel Patel 
On Mon, Apr 9, 2018 at 6:51 PM, Dave Page  wrote:

>
>
> On Mon, Apr 9, 2018 at 2:20 PM, Neel Patel 
> wrote:
>
>> Hi Dave,
>>
>> On Mon, Apr 9, 2018 at 6:33 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Apr 9, 2018 at 6:19 PM, Dave Page  wrote:
>>>
 Oh yeah - I forgot to mention that running it in PyCharms seems to
 work. The issue comes when using the runtime from what I can see (even
 using the exact same venv that works otherwise).

 Didn't try on windows. Let me try.
>>>
 On Mon, Apr 9, 2018 at 1:46 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Did not try running pgAdmin4 on windows from git repo.
> Let me get the latest pull and check.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Mon, Apr 9, 2018 at 5:53 PM, Dave Page  wrote:
>
>> ... is really not going well today.
>>
>> After arguing with PIP on Mac for some time, I eventually managed to
>> get a build out. That required a manual update of my system to 9.0.3 to
>> ensure TLS 1.2 worked, and then changing to build such that we only force
>> our own build of Psycopg2, and not other Python packages. I *think* these
>> issues are related to the whole PyPi TLS 1.2/PIP 9.0.3 brownouts and 
>> other
>> works they've been doing.
>>
>> The Windows build is a whole other ballgame. The build itself runs
>> just fine, but we end up with the following error in the log:
>>
>> Traceback (most recent call last):
>>   File "C:/Program Files/pgAdmin 4/v3/web/pgAdmin4.py", line 70, in
>> 
>> app = create_app()
>>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\__init__.py", line
>> 367, in create_app
>> driver.init_app(app)
>>   File "C:\Program Files\pgAdmin 
>> 4\v3\web\pgadmin\utils\driver\__init__.py",
>> line 40, in init_app
>> DriverRegistry.load_drivers()
>>   File "C:\Program Files\pgAdmin 
>> 4\v3\web\pgadmin\utils\driver\registry.py",
>> line 88, in load_drivers
>> module = import_module(module_name)
>>   File "C:/Program Files/pgAdmin 4/v3/venv\lib\importlib\__init__.py",
>> line 37, in import_module
>> __import__(name)
>>   File "C:\Program Files\pgAdmin 
>> 4\v3\web\pgadmin\utils\driver\psycopg2\__init__.py",
>> line 26, in 
>> from .connection import Connection
>>   File "C:\Program Files\pgAdmin 
>> 4\v3\web\pgadmin\utils\driver\psycopg2\connection.py",
>> line 25, in 
>> from pgadmin.utils.crypto import decrypt
>>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\crypto.py",
>> line 16, in 
>> from Crypto.Cipher import AES
>>   File "C:/Program Files/pgAdmin 
>> 4/v3/venv/Lib/site-packages\Crypto\Cipher\__init__.py",
>> line 3, in 
>> from Crypto.Cipher._mode_ecb import _create_ecb_cipher
>>   File "C:/Program Files/pgAdmin 
>> 4/v3/venv/Lib/site-packages\Crypto\Cipher\_mode_ecb.py",
>> line 46, in 
>> """
>>   File "C:/Program Files/pgAdmin 
>> 4/v3/venv/Lib/site-packages\Crypto\Util\_raw_api.py",
>> line 258, in load_pycryptodome_raw_lib
>> raise OSError("Cannot load native module '%s': %s" % (name, ",
>> ".join(attempts)))
>> OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying
>> '_raw_ecb.pyd': [Error 126] The specified module could not be found
>> Exception KeyError: KeyError(3644,) in > 'C:/Program Files/pgAdmin 4/v3/venv\lib\threading.py'> ignored
>>
>> The module does exist of course in the Crypto\Cipher directory.
>>
>
>> Everything works fine on my windows machine with Python 3.5.
>> Any specific scenarios ?
>>
>
> Standard release build using Python 2.7;
>
> make x86
>
Let me try with Python 2.7 x86.


>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: Building releases...

2018-04-09 Thread Dave Page 
On Mon, Apr 9, 2018 at 2:20 PM, Neel Patel 
wrote:

> Hi Dave,
>
> On Mon, Apr 9, 2018 at 6:33 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Apr 9, 2018 at 6:19 PM, Dave Page  wrote:
>>
>>> Oh yeah - I forgot to mention that running it in PyCharms seems to work.
>>> The issue comes when using the runtime from what I can see (even using the
>>> exact same venv that works otherwise).
>>>
>>> Didn't try on windows. Let me try.
>>
>>> On Mon, Apr 9, 2018 at 1:46 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Did not try running pgAdmin4 on windows from git repo.
 Let me get the latest pull and check.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 On Mon, Apr 9, 2018 at 5:53 PM, Dave Page  wrote:

> ... is really not going well today.
>
> After arguing with PIP on Mac for some time, I eventually managed to
> get a build out. That required a manual update of my system to 9.0.3 to
> ensure TLS 1.2 worked, and then changing to build such that we only force
> our own build of Psycopg2, and not other Python packages. I *think* these
> issues are related to the whole PyPi TLS 1.2/PIP 9.0.3 brownouts and other
> works they've been doing.
>
> The Windows build is a whole other ballgame. The build itself runs
> just fine, but we end up with the following error in the log:
>
> Traceback (most recent call last):
>   File "C:/Program Files/pgAdmin 4/v3/web/pgAdmin4.py", line 70, in
> 
> app = create_app()
>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\__init__.py", line
> 367, in create_app
> driver.init_app(app)
>   File "C:\Program Files\pgAdmin 
> 4\v3\web\pgadmin\utils\driver\__init__.py",
> line 40, in init_app
> DriverRegistry.load_drivers()
>   File "C:\Program Files\pgAdmin 
> 4\v3\web\pgadmin\utils\driver\registry.py",
> line 88, in load_drivers
> module = import_module(module_name)
>   File "C:/Program Files/pgAdmin 4/v3/venv\lib\importlib\__init__.py",
> line 37, in import_module
> __import__(name)
>   File "C:\Program Files\pgAdmin 
> 4\v3\web\pgadmin\utils\driver\psycopg2\__init__.py",
> line 26, in 
> from .connection import Connection
>   File "C:\Program Files\pgAdmin 
> 4\v3\web\pgadmin\utils\driver\psycopg2\connection.py",
> line 25, in 
> from pgadmin.utils.crypto import decrypt
>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\crypto.py",
> line 16, in 
> from Crypto.Cipher import AES
>   File "C:/Program Files/pgAdmin 
> 4/v3/venv/Lib/site-packages\Crypto\Cipher\__init__.py",
> line 3, in 
> from Crypto.Cipher._mode_ecb import _create_ecb_cipher
>   File "C:/Program Files/pgAdmin 
> 4/v3/venv/Lib/site-packages\Crypto\Cipher\_mode_ecb.py",
> line 46, in 
> """
>   File "C:/Program Files/pgAdmin 
> 4/v3/venv/Lib/site-packages\Crypto\Util\_raw_api.py",
> line 258, in load_pycryptodome_raw_lib
> raise OSError("Cannot load native module '%s': %s" % (name, ",
> ".join(attempts)))
> OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying
> '_raw_ecb.pyd': [Error 126] The specified module could not be found
> Exception KeyError: KeyError(3644,) in  'C:/Program Files/pgAdmin 4/v3/venv\lib\threading.py'> ignored
>
> The module does exist of course in the Crypto\Cipher directory.
>

> Everything works fine on my windows machine with Python 3.5.
> Any specific scenarios ?
>

Standard release build using Python 2.7;

make x86

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Building releases...

2018-04-09 Thread Neel Patel 
Hi Dave,

On Mon, Apr 9, 2018 at 6:33 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Mon, Apr 9, 2018 at 6:19 PM, Dave Page  wrote:
>
>> Oh yeah - I forgot to mention that running it in PyCharms seems to work.
>> The issue comes when using the runtime from what I can see (even using the
>> exact same venv that works otherwise).
>>
>> Didn't try on windows. Let me try.
>
>> On Mon, Apr 9, 2018 at 1:46 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Did not try running pgAdmin4 on windows from git repo.
>>> Let me get the latest pull and check.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Mon, Apr 9, 2018 at 5:53 PM, Dave Page  wrote:
>>>
 ... is really not going well today.

 After arguing with PIP on Mac for some time, I eventually managed to
 get a build out. That required a manual update of my system to 9.0.3 to
 ensure TLS 1.2 worked, and then changing to build such that we only force
 our own build of Psycopg2, and not other Python packages. I *think* these
 issues are related to the whole PyPi TLS 1.2/PIP 9.0.3 brownouts and other
 works they've been doing.

 The Windows build is a whole other ballgame. The build itself runs just
 fine, but we end up with the following error in the log:

 Traceback (most recent call last):
   File "C:/Program Files/pgAdmin 4/v3/web/pgAdmin4.py", line 70, in
 
 app = create_app()
   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\__init__.py", line
 367, in create_app
 driver.init_app(app)
   File "C:\Program Files\pgAdmin 
 4\v3\web\pgadmin\utils\driver\__init__.py",
 line 40, in init_app
 DriverRegistry.load_drivers()
   File "C:\Program Files\pgAdmin 
 4\v3\web\pgadmin\utils\driver\registry.py",
 line 88, in load_drivers
 module = import_module(module_name)
   File "C:/Program Files/pgAdmin 4/v3/venv\lib\importlib\__init__.py",
 line 37, in import_module
 __import__(name)
   File "C:\Program Files\pgAdmin 
 4\v3\web\pgadmin\utils\driver\psycopg2\__init__.py",
 line 26, in 
 from .connection import Connection
   File "C:\Program Files\pgAdmin 
 4\v3\web\pgadmin\utils\driver\psycopg2\connection.py",
 line 25, in 
 from pgadmin.utils.crypto import decrypt
   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\crypto.py",
 line 16, in 
 from Crypto.Cipher import AES
   File "C:/Program Files/pgAdmin 
 4/v3/venv/Lib/site-packages\Crypto\Cipher\__init__.py",
 line 3, in 
 from Crypto.Cipher._mode_ecb import _create_ecb_cipher
   File "C:/Program Files/pgAdmin 
 4/v3/venv/Lib/site-packages\Crypto\Cipher\_mode_ecb.py",
 line 46, in 
 """
   File "C:/Program Files/pgAdmin 
 4/v3/venv/Lib/site-packages\Crypto\Util\_raw_api.py",
 line 258, in load_pycryptodome_raw_lib
 raise OSError("Cannot load native module '%s': %s" % (name, ",
 ".join(attempts)))
 OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying
 '_raw_ecb.pyd': [Error 126] The specified module could not be found
 Exception KeyError: KeyError(3644,) in >>> 'C:/Program Files/pgAdmin 4/v3/venv\lib\threading.py'> ignored

 The module does exist of course in the Crypto\Cipher directory.

>>>
Everything works fine on my windows machine with Python 3.5.
Any specific scenarios ?


>
 Murtuza, Khushboo; have you got it running on pgAdmin recently?


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Re: Building releases...

2018-04-09 Thread Khushboo Vashi 
On Mon, Apr 9, 2018 at 6:19 PM, Dave Page  wrote:

> Oh yeah - I forgot to mention that running it in PyCharms seems to work.
> The issue comes when using the runtime from what I can see (even using the
> exact same venv that works otherwise).
>
> Didn't try on windows. Let me try.

> On Mon, Apr 9, 2018 at 1:46 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Did not try running pgAdmin4 on windows from git repo.
>> Let me get the latest pull and check.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Mon, Apr 9, 2018 at 5:53 PM, Dave Page  wrote:
>>
>>> ... is really not going well today.
>>>
>>> After arguing with PIP on Mac for some time, I eventually managed to get
>>> a build out. That required a manual update of my system to 9.0.3 to ensure
>>> TLS 1.2 worked, and then changing to build such that we only force our own
>>> build of Psycopg2, and not other Python packages. I *think* these issues
>>> are related to the whole PyPi TLS 1.2/PIP 9.0.3 brownouts and other works
>>> they've been doing.
>>>
>>> The Windows build is a whole other ballgame. The build itself runs just
>>> fine, but we end up with the following error in the log:
>>>
>>> Traceback (most recent call last):
>>>   File "C:/Program Files/pgAdmin 4/v3/web/pgAdmin4.py", line 70, in
>>> 
>>> app = create_app()
>>>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\__init__.py", line
>>> 367, in create_app
>>> driver.init_app(app)
>>>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\driver\__init__.py",
>>> line 40, in init_app
>>> DriverRegistry.load_drivers()
>>>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\driver\registry.py",
>>> line 88, in load_drivers
>>> module = import_module(module_name)
>>>   File "C:/Program Files/pgAdmin 4/v3/venv\lib\importlib\__init__.py",
>>> line 37, in import_module
>>> __import__(name)
>>>   File "C:\Program Files\pgAdmin 
>>> 4\v3\web\pgadmin\utils\driver\psycopg2\__init__.py",
>>> line 26, in 
>>> from .connection import Connection
>>>   File "C:\Program Files\pgAdmin 
>>> 4\v3\web\pgadmin\utils\driver\psycopg2\connection.py",
>>> line 25, in 
>>> from pgadmin.utils.crypto import decrypt
>>>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\crypto.py",
>>> line 16, in 
>>> from Crypto.Cipher import AES
>>>   File "C:/Program Files/pgAdmin 
>>> 4/v3/venv/Lib/site-packages\Crypto\Cipher\__init__.py",
>>> line 3, in 
>>> from Crypto.Cipher._mode_ecb import _create_ecb_cipher
>>>   File "C:/Program Files/pgAdmin 
>>> 4/v3/venv/Lib/site-packages\Crypto\Cipher\_mode_ecb.py",
>>> line 46, in 
>>> """
>>>   File "C:/Program Files/pgAdmin 
>>> 4/v3/venv/Lib/site-packages\Crypto\Util\_raw_api.py",
>>> line 258, in load_pycryptodome_raw_lib
>>> raise OSError("Cannot load native module '%s': %s" % (name, ",
>>> ".join(attempts)))
>>> OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying
>>> '_raw_ecb.pyd': [Error 126] The specified module could not be found
>>> Exception KeyError: KeyError(3644,) in >> 'C:/Program Files/pgAdmin 4/v3/venv\lib\threading.py'> ignored
>>>
>>> The module does exist of course in the Crypto\Cipher directory.
>>>
>>> Murtuza, Khushboo; have you got it running on pgAdmin recently?
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: Building releases...

2018-04-09 Thread Murtuza Zabuawala 
Did not try running pgAdmin4 on windows from git repo.
Let me get the latest pull and check.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Mon, Apr 9, 2018 at 5:53 PM, Dave Page  wrote:

> ... is really not going well today.
>
> After arguing with PIP on Mac for some time, I eventually managed to get a
> build out. That required a manual update of my system to 9.0.3 to ensure
> TLS 1.2 worked, and then changing to build such that we only force our own
> build of Psycopg2, and not other Python packages. I *think* these issues
> are related to the whole PyPi TLS 1.2/PIP 9.0.3 brownouts and other works
> they've been doing.
>
> The Windows build is a whole other ballgame. The build itself runs just
> fine, but we end up with the following error in the log:
>
> Traceback (most recent call last):
>   File "C:/Program Files/pgAdmin 4/v3/web/pgAdmin4.py", line 70, in
> 
> app = create_app()
>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\__init__.py", line 367,
> in create_app
> driver.init_app(app)
>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\driver\__init__.py",
> line 40, in init_app
> DriverRegistry.load_drivers()
>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\driver\registry.py",
> line 88, in load_drivers
> module = import_module(module_name)
>   File "C:/Program Files/pgAdmin 4/v3/venv\lib\importlib\__init__.py",
> line 37, in import_module
> __import__(name)
>   File "C:\Program Files\pgAdmin 
> 4\v3\web\pgadmin\utils\driver\psycopg2\__init__.py",
> line 26, in 
> from .connection import Connection
>   File "C:\Program Files\pgAdmin 
> 4\v3\web\pgadmin\utils\driver\psycopg2\connection.py",
> line 25, in 
> from pgadmin.utils.crypto import decrypt
>   File "C:\Program Files\pgAdmin 4\v3\web\pgadmin\utils\crypto.py", line
> 16, in 
> from Crypto.Cipher import AES
>   File "C:/Program Files/pgAdmin 
> 4/v3/venv/Lib/site-packages\Crypto\Cipher\__init__.py",
> line 3, in 
> from Crypto.Cipher._mode_ecb import _create_ecb_cipher
>   File "C:/Program Files/pgAdmin 
> 4/v3/venv/Lib/site-packages\Crypto\Cipher\_mode_ecb.py",
> line 46, in 
> """
>   File "C:/Program Files/pgAdmin 
> 4/v3/venv/Lib/site-packages\Crypto\Util\_raw_api.py",
> line 258, in load_pycryptodome_raw_lib
> raise OSError("Cannot load native module '%s': %s" % (name, ",
> ".join(attempts)))
> OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying
> '_raw_ecb.pyd': [Error 126] The specified module could not be found
> Exception KeyError: KeyError(3644,) in  'C:/Program Files/pgAdmin 4/v3/venv\lib\threading.py'> ignored
>
> The module does exist of course in the Crypto\Cipher directory.
>
> Murtuza, Khushboo; have you got it running on pgAdmin recently?
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Running behind an ssl proxy

2018-04-09 Thread Aron Kramlik 
Hi,

I would like to deploy the Docker image from
https://hub.docker.com/r/dpage/pgadmin4/ and access it when it is deployed
behind an SSL proxy server (in our case it is Traefik).

It would be ideal if PgAdmin could be configured to run behind the SSL
proxy server and have the proxy server terminate the SSL connection.  In
this case, the URLs generated by PgAdmin should be https:// prefixed even
though PgAdmin itself is only listening on the HTTP port.

Could anyone recommend how this could be achieved in PgAdmin or what it
needs to behave this way?

Regards,
Aron

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

2018-04-09 Thread Khushboo Vashi 
Hi Joao,

I have reviewed your patch and have some suggestions.

On Sat, Apr 7, 2018 at 12:43 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Murtuza/Dave,
> Yes now the extracted functions are spread into different files. The
> intent would be to make the files as small as possible, and also to group
> and name them in a way that would be easy to understand what each file is
> doing without the need of opening it.
> As a example:
> static/js/backup will contain all the backup related functionality inside
> of this folder we can see the file:
>
menu_utils.js At this moment in time we decided to group all the functions
> that are related to the menu, but we can split that also if we believe it
> is easier to see.
>
It's really very good to see the separated code for backup module. As we
have done for backup, we would like do it for other PG utilities like
restore, maintenance etc.
Considering this, we should separate the code in a way that some of the
common functionalities can be used for other modules  like menu (as you
have mentioned above), dialogue factory etc.
Also, I think these functionalities should be in their respective static
folder instead of pgadmin/static.


> static/js/datagrid folder contains all the datagrid related functionality
>
Same as backup module,  this should be in it's respective static/js folder.

> Inside of the folder we can see the files:
> get_panel_title.js is responsible for retrieving the name of the panel
> show_data.js is responsible for showing the datagrid
> show_query_tool.js is responsible for showing the query tool
>
> Does this structure make sense?
> Can you give an example of a comment that you think is missing and that
> could help?
>
> As a personal note, unless the algorithm is very obscure or very
> complicated, I believe that if the code needs comments it is a signal that
> something needs to change in terms of naming, structure of the part in
> question. This being said, I am open to add some comments that might help
> people.
>
You are right, with the help of naming convention and structure of the
code, any one can get the idea about the code. But it is very useful to
understand the code
very easily with the proper comments especially when there are multiple
developers working on a single project.

I found some of the places where it would be great to have comments.

- treeMenu: new tree.Tree()  in a browser.js
- tree.js  (especially Tree class)

Thanks
> Joao
> ​
>
> Thanks,
Khushboo

>
> On Fri, Apr 6, 2018 at 4:48 AM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Joao,
>>
>> Patch looks good and working as expected.
>>
>> I also agree with Dave, Can we please add some comments in each file
>> which can help us to understand the flow, I'm saying because now the code
>> is segregated in so many separate files it will be hard to keep track of
>> the flow from one file to another when debugging.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Thu, Apr 5, 2018 at 7:08 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hi Khushboo,
>>> Attached you can find both patches rebased
>>>
>>> Thanks
>>>
>>>
>>> On Thu, Apr 5, 2018 at 6:31 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi Joao,

 Can you please rebase the second patch?

 Thanks,
 Khushboo


 On Tue, Apr 3, 2018 at 12:15 AM, Joao De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> Attached you can find the patch that will start to decouple pgAdmin
> from ACITree library.
> This patch is intended to be merged after 3.0, because we do not want
> to cause any entropy or delay the release, but we want to start the
> discussion and show some code.
>
> This job that we started is a massive tech debt chore that will take
> some time to finalize and we would love the help of the community to do 
> it.
>
> *Summary of the patch:*
> 0001 patch:
>  - Creates a new tree that will allow us to create a separation
> between the application and ACI Tree
>  - Creates a Fake Tree (Test double, for reference on the available
> test doubles: https://martinfowler.com/bliki/TestDouble.html) that
> can be used to inplace to replace the ACITree and also encapsulate the new
> tree behavior on our tests
>  - Adds tests for all the tree functionalities
>
> 0002 patch:
>  - Extracts, refactors, adds tests and remove dependency from ACI Tree
> on:
> - getTreeNodeHierarchy
> - on backup.js: menu_enabled, menu_enabled_server,
> start_backup_global_server, backup_objects
> - on datagrid.js: show_data_grid, get_panel_title, show_query_tool
> - Start using sprintf-js as Underscore.String is deprecating sprintf
> function
>
> This patch represents