Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server

[Anthony Emengo]

Just manually verified that this worked, and the patch successfully went
through our pipelines.

Thanks so much for fixing this issue!

- Joao and Anthony

On Mon, Apr 23, 2018 at 3:40 AM, Ashesh Vashi  wrote:

> Hi Team,
>
> Please find the patch for fixing the RM #3290.
> The 'Close button' was missing in the message box, which shows the error
> in the backend server.
>
> This patch also fixes some of the missing keycode 'ESCAPE' on 'Cancel'
> buttons in different modules.
>
> Please review.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

[Anthony Emengo]

For what it is worth, I manually verified that the feature worked, as well
as looked through the code.

I'd like to see end-to-end testing for regression sake, but it's hard to so
at this moment.

- Anthony and Joao.

On Mon, Apr 23, 2018 at 5:09 AM, Akshay Joshi  wrote:

>
>
> On Mon, Apr 23, 2018 at 1:30 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo 
>> wrote:
>>
>>> Hey Akshay
>>>
>>> This patch passed our test pipelines.
>>>
>>
>> Did you test the feature and//or review the code and tests? Passing the
>> tests is great, *if* the whole feature is covered (and the nature of this
>> patch will make that quite difficult, maybe impossible to do without
>> external infrastructure and config).
>>
>
> Agreed, it's been difficult to write test case to test the complete
> feature.
>
>>
>>
>>>
>>> Anthony and Victoria
>>>
>>> On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Hackers

 I have implemented the SSH Tunnel support using
 https://pypi.org/project/sshtunnel/ python package. Added "SSH Tunnel"
 Tab in server dialog. This implementation supports user name /password and
 private/public key combination with Passphrase to crate SSH Tunnel. I have
 added regression test case to add server using SSH Tunnel options.

 The given python package(https://pypi.org/project/sshtunnel/) support
 Python version *2.7, 3.4+*.
 It uses Paramiko (Python implementation of SSHv2 protocol) which
 actually drops support for Python 2.6. So I have added
 *SUPPORT_SSH_TUNNEL* parameter in config.py which checks the python
 version and set the flag accordingly. In case of Python 2.6, 3.0, 3.1, 3.2
 and 3.3 control on the "SSH Tunnel" tab of server dialog will be disabled.

 Please review it, and if looks good please commit the code.

 --
 *Akshay Joshi*

 *Sr. Software Architect *



 *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

[Dave Page]

Hi

On Mon, Apr 23, 2018 at 2:05 PM, Akshay Joshi  wrote:

> Hi Hackers,
>
> I have added support for running feature tests against FireFox. For that
> user will have to download gecko driver from https://github.com/mozilla/
> geckodriver/releases and follow the below steps:
>
>- Extract the gecko driver.
>- Run chmod +x geckodriver.
>- Either copy the geckodriver to /usr/local/bin or the path of the
>geckodriver must be specified in PATH.
>- Apply the attached patch.
>- Change the parameter "DEFAULT_TEST_BROWSER = 'Firefox' "
>- Start the feature test.
>
> The config option needs to be in test_config.json. We don't really want
test-specific config options in config.py (arguably, TEST_SQLITE_PATH
shoudn't be there either, as it's useless for end users).

I'm surprised to not see any updates to tests. When I tried firefox
manually a few weeks back, it was failing at lot.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

[Akshay Joshi]

Hi Hackers,

I have added support for running feature tests against FireFox. For that
user will have to download gecko driver from https://github.com/mozilla/
geckodriver/releases and follow the below steps:

   - Extract the gecko driver.
   - Run chmod +x geckodriver.
   - Either copy the geckodriver to /usr/local/bin or the path of the
   geckodriver must be specified in PATH.
   - Apply the attached patch.
   - Change the parameter "DEFAULT_TEST_BROWSER = 'Firefox' "
   - Start the feature test.

Please review it.

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


RM_3270.patch
Description: Binary data

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

[Akshay Joshi]

On Mon, Apr 23, 2018 at 1:30 PM, Dave Page  wrote:

> Hi
>
> On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo 
> wrote:
>
>> Hey Akshay
>>
>> This patch passed our test pipelines.
>>
>
> Did you test the feature and//or review the code and tests? Passing the
> tests is great, *if* the whole feature is covered (and the nature of this
> patch will make that quite difficult, maybe impossible to do without
> external infrastructure and config).
>

Agreed, it's been difficult to write test case to test the complete
feature.

>
>
>>
>> Anthony and Victoria
>>
>> On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Hackers
>>>
>>> I have implemented the SSH Tunnel support using https://pypi.org/project
>>> /sshtunnel/ python package. Added "SSH Tunnel" Tab in server dialog.
>>> This implementation supports user name /password and private/public key
>>> combination with Passphrase to crate SSH Tunnel. I have added regression
>>> test case to add server using SSH Tunnel options.
>>>
>>> The given python package(https://pypi.org/project/sshtunnel/) support
>>> Python version *2.7, 3.4+*.
>>> It uses Paramiko (Python implementation of SSHv2 protocol) which
>>> actually drops support for Python 2.6. So I have added
>>> *SUPPORT_SSH_TUNNEL* parameter in config.py which checks the python
>>> version and set the flag accordingly. In case of Python 2.6, 3.0, 3.1, 3.2
>>> and 3.3 control on the "SSH Tunnel" tab of server dialog will be disabled.
>>>
>>> Please review it, and if looks good please commit the code.
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

[Dave Page]

Hi

On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo  wrote:

> Hey Akshay
>
> This patch passed our test pipelines.
>

Did you test the feature and//or review the code and tests? Passing the
tests is great, *if* the whole feature is covered (and the nature of this
patch will make that quite difficult, maybe impossible to do without
external infrastructure and config).


>
> Anthony and Victoria
>
> On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Hackers
>>
>> I have implemented the SSH Tunnel support using https://pypi.org/project
>> /sshtunnel/ python package. Added "SSH Tunnel" Tab in server dialog.
>> This implementation supports user name /password and private/public key
>> combination with Passphrase to crate SSH Tunnel. I have added regression
>> test case to add server using SSH Tunnel options.
>>
>> The given python package(https://pypi.org/project/sshtunnel/) support
>> Python version *2.7, 3.4+*.
>> It uses Paramiko (Python implementation of SSHv2 protocol) which actually
>> drops support for Python 2.6. So I have added *SUPPORT_SSH_TUNNEL* parameter
>> in config.py which checks the python version and set the flag accordingly.
>> In case of Python 2.6, 3.0, 3.1, 3.2 and 3.3 control on the "SSH Tunnel"
>> tab of server dialog will be disabled.
>>
>> Please review it, and if looks good please commit the code.
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[PATCH] [RM# 3290] Close button missing for the message window from the backend server

[Ashesh Vashi]

Hi Team,

Please find the patch for fixing the RM #3290.
The 'Close button' was missing in the message box, which shows the error in
the backend server.

This patch also fixes some of the missing keycode 'ESCAPE' on 'Cancel'
buttons in different modules.

Please review.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*



RM_3290.patch
Description: Binary data