[pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted

[Khushboo Vashi]

Hi,

Please find the fix for #3411 - pgAdmin 4, Mac. The application server
could not be contacted

The issue is with french translation which has been taken care in the
attached patch.

Thanks,
Khushboo
diff --git a/web/pgadmin/translations/fr/LC_MESSAGES/messages.po b/web/pgadmin/translations/fr/LC_MESSAGES/messages.po
index 54c04b9..0363c0f 100644
--- a/web/pgadmin/translations/fr/LC_MESSAGES/messages.po
+++ b/web/pgadmin/translations/fr/LC_MESSAGES/messages.po
@@ -10540,8 +10540,8 @@ msgid ""
 msgstr ""
 "Taille des caractères à utiliser dans les boites de code SQL. La valeur "
 "indiquée utilise l'unité \"em\", pour laquelle 1 est la valeur relative "
-"par défaut. Par exemple, pour augmenter la taille de 20% il faut indiquer"
-" 1.2, pour la réduire de 20% indiquer 0.8. Le minimum est 0.1, le maximum"
+"par défaut. Par exemple, pour augmenter la taille de 20 pour cent il faut indiquer"
+" 1.2, pour la réduire de 20 pour cent indiquer 0.8. Le minimum est 0.1, le maximum"
 " est 10."
 
 #: pgadmin/tools/sqleditor/utils/query_tool_preferences.py:94

Re: [PGAGENT] Upgrade pgAgent from unpackaged version

[Rushabh Lathia]

Thanks Ashesh and Dave.

I verified the changes and it looks good to me.  I found that newly
added unpackaged file still have old file header comment.  Which
require change with new file name.

PFA patch to fix the same.

Thanks,


On Wed, Jun 13, 2018 at 6:10 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Wed, Jun 13, 2018 at 5:11 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> As per my conversation with Rushabh, we need to rename the
>> pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the
>> current version has changed. We also need to update the schema version
>> function for the unpackaged extension.
>>
>> Please find the attached patch for the same.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
--

Rushabh Lathia
Database Architect
EnterpriseDB Corporation
The Enterprise Postgres Company

Phone: +91-20-30589494

Website: http://www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb
diff --git a/sql/pgagent--unpackaged--4.0.sql b/sql/pgagent--unpackaged--4.0.sql
index 302dde4..b0e2cce 100644
--- a/sql/pgagent--unpackaged--4.0.sql
+++ b/sql/pgagent--unpackaged--4.0.sql
@@ -4,7 +4,7 @@
 // Copyright (C) 2002 - 2018 The pgAdmin Development Team
 // This software is released under the PostgreSQL Licence
 //
-// pgagent--unpackaged--3.4.sql - Convert pgAgent existing tables and functions to an extension
+// pgagent--unpackaged--4.0.sql - Convert pgAgent existing tables and functions to an extension
 //
 */
 

Jenkins build is back to normal : pgadmin4-master-python35 #644

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python36 #645

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python33 #653

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python34 #640

[pgAdmin 4 Jenkins]

See 

Jenkins build is back to normal : pgadmin4-master-python26 #785

[pgAdmin 4 Jenkins]

See 

Build failed in Jenkins: pgadmin4-master-python36 #644

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Fix auto-complete. Fixes #3374

--
[...truncated 684.50 KB...]
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
PgAgentAddTestCase (Add pgAgent job)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentGetTestCase (Get pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.6:

297 tests passed
0 tests failed
24 tests skipped:
ProcedureAddTestCase (Fetch Procedure Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
ProcedureGetTestCase (Fetch Procedure Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
PgAgentAddTestCase (Add pgAgent job)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentGetTestCase (Get pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 10:

299 tests passed
0 tests failed
22 tests skipped:
ProcedureAddTestCase (Fetch Procedure Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
ProcedureGetTestCase (Fetch Procedure Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PgAgentAddTestCase (Add pgAgent job)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentGetTestCase (Get pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

EDB Postgres AS 9.2:

298 tests passed
3 

Build failed in Jenkins: pgadmin4-master-python35 #643

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Fix auto-complete. Fixes #3374

--
[...truncated 684.77 KB...]
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
ResourceGroupsAddTestCase (Add resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
PgAgentGetTestCase (Get pgAgent job)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table)
SynonymPutTestCase (Fetch synonym Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)

PostgreSQL 10:

299 tests passed
0 tests failed
22 tests skipped:
PackagePutTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
ProcedureGetTestCase (Fetch Procedure Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
PgAgentAddTestCase (Add pgAgent job)
ProcedureAddTestCase (Fetch Procedure Node URL)
PgAgentStatsTestCase (Check the stats of pgAgent job)
TestSSLConnection (Test for SSL connection)
ResourceGroupsGetTestCase (Get resource groups)
PgAgentPutTestCase (Put pgAgent job)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PgAgentDeleteTestCase (Delete pgAgent job)
ProcedurePutTestCase (Fetch Procedure Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
PgAgentGetTestCase (Get pgAgent job)
ResourceGroupsAddTestCase (Add resource groups)
SynonymPutTestCase (Fetch synonym Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)

EDB Postgres AS 9.5:

313 tests passed
0 tests failed
8 tests skipped:
PgAgentGetTestCase (Get pgAgent job)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table)
TestSSLConnection (Test for SSL connection)
PgAgentAddTestCase (Add pgAgent job)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
PgAgentStatsTestCase (Check the stats of pgAgent job)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)

EDB Postgres AS 9.4:

310 tests passed
3 tests failed:
procedureDeleteTestCase (Fetch Procedure Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
ProcedureGetTestCase (Fetch Procedure Node URL)
8 tests skipped:
PgAgentGetTestCase (Get pgAgent job)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table)
TestSSLConnection (Test for SSL connection)
PgAgentAddTestCase (Add pgAgent job)
 

Re: [pgadmin4][Patch]: RM #3374 Code autocomplete is broken in pgadmin4 V 3.0

[Dave Page]

Thanks, applied.

On Wed, Jun 13, 2018 at 1:50 PM, Akshay Joshi  wrote:

> Hi Hackers,
>
> Attached is the patch to fix RM #3374 Code auto complete is broken in
> pgadmin4 V 3.0.
> I'll create a new RM to merge latest *pgcli
> * code used for SQL Auto complete in
> pgAdmin4.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix auto-complete. Fixes #3374

[Dave Page]

Fix auto-complete. Fixes #3374

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88a2309a2641cd42f9119def2f62f6b9dc869870
Author: Akshay Joshi 

Modified Files
--
docs/en_US/release_notes_3_1.rst| 3 ++-
web/pgadmin/utils/sqlautocomplete/parseutils.py | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python33 #651

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Function and procedure support for PG11. Fixes #3362

--
[...truncated 684.48 KB...]
ResourceGroupsPutTestCase (Put resource groups)
PgAgentAddTestCase (Add pgAgent job)
ProcedureAddTestCase (Fetch Procedure Node URL)
PgAgentPutTestCase (Put pgAgent job)
procedureDeleteTestCase (Fetch Procedure Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
ProcedureGetTestCase (Fetch Procedure Node URL)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
SynonymDeleteTestCase (Fetch synonym Node URL)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
PgAgentGetTestCase (Get pgAgent job)
PackagePutTestCase (Fetch Package Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
TestSSLConnection (Test for SSL connection)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymAddTestCase (Default Node URL)

PostgreSQL 9.4:

297 tests passed
0 tests failed
24 tests skipped:
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageGetTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
PgAgentAddTestCase (Add pgAgent job)
ProcedureAddTestCase (Fetch Procedure Node URL)
PgAgentPutTestCase (Put pgAgent job)
procedureDeleteTestCase (Fetch Procedure Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
ProcedureGetTestCase (Fetch Procedure Node URL)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
SynonymDeleteTestCase (Fetch synonym Node URL)
TableUpdateTestCase (Attach partition to existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
PgAgentGetTestCase (Get pgAgent job)
PackagePutTestCase (Fetch Package Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
TestSSLConnection (Test for SSL connection)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymAddTestCase (Default Node URL)

PostgreSQL 9.3:

297 tests passed
0 tests failed
24 tests skipped:
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageGetTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
ResourceGroupsPutTestCase (Put resource groups)
PgAgentAddTestCase (Add pgAgent job)
ProcedureAddTestCase (Fetch Procedure Node URL)
PgAgentPutTestCase (Put pgAgent job)
procedureDeleteTestCase (Fetch Procedure Node URL)
PackageDeleteTestCase (Fetch Package Node URL)

Build failed in Jenkins: pgadmin4-master-python36 #643

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Function and procedure support for PG11. Fixes #3362

--
[...truncated 684.58 KB...]
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
PgAgentAddTestCase (Add pgAgent job)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentGetTestCase (Get pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.6:

297 tests passed
0 tests failed
24 tests skipped:
ProcedureAddTestCase (Fetch Procedure Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
ProcedureGetTestCase (Fetch Procedure Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
PgAgentAddTestCase (Add pgAgent job)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentGetTestCase (Get pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 10:

299 tests passed
0 tests failed
22 tests skipped:
ProcedureAddTestCase (Fetch Procedure Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
ProcedureGetTestCase (Fetch Procedure Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PgAgentAddTestCase (Add pgAgent job)
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentGetTestCase (Get pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

EDB Postgres AS 9.2:

298 

Build failed in Jenkins: pgadmin4-master-python34 #638

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Function and procedure support for PG11. Fixes #3362

--
[...truncated 684.53 KB...]
Create List partitioned table with 2 
partitions)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
PgAgentGetTestCase (Get pgAgent job)
ViewsDeleteTestCase (Delete materialized view under schema node)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
TestSSLConnection (Test for SSL connection)
ViewsUpdateTestCase (Update materialized view under schema node)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
ViewsGetTestCase (Get materialized view under schema node)
PackagePutTestCase (Fetch Package Node URL)
PgAgentAddTestCase (Add pgAgent job)
PgAgentDeleteTestCase (Delete pgAgent job)
ProcedureAddTestCase (Fetch Procedure Node URL)
SynonymAddTestCase (Default Node URL)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
ViewsAddTestCase (Add materialized view under schema node)
ResourceGroupsPutTestCase (Put resource groups)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
PgAgentStatsTestCase (Check the stats of pgAgent job)
ProcedureGetTestCase (Fetch Procedure Node URL)
ResourceGroupsGetTestCase (Get resource groups)

EDB Postgres AS 9.2:

298 tests passed
3 tests failed:
ProcedureGetTestCase (Fetch Procedure Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
20 tests skipped:
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
ViewsGetTestCase (Get materialized view under schema node)
PgAgentPutTestCase (Put pgAgent job)
PgAgentAddTestCase (Add pgAgent job)
ResourceGroupsDeleteTestCase (Delete resource groups)
ViewsUpdateTestCase (Update materialized view under schema node)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
ResourceGroupsGetTestCase (Get resource groups)
PgAgentGetTestCase (Get pgAgent job)
ViewsDeleteTestCase (Delete materialized view under schema node)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
PgAgentStatsTestCase (Check the stats of pgAgent job)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
PgAgentDeleteTestCase (Delete pgAgent job)
ViewsAddTestCase (Add materialized view under schema node)

PostgreSQL 9.6:

297 tests passed
0 tests failed
24 tests skipped:
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
PackageAddTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym 

Build failed in Jenkins: pgadmin4-master-python35 #642

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Function and procedure support for PG11. Fixes #3362

--
[...truncated 687.60 KB...]
PgAgentDeleteTestCase (Delete pgAgent job)
TestSSLConnection (Test for SSL connection)
PackageGetTestCase (Fetch Package Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
PgAgentAddTestCase (Add pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
ResourceGroupsGetTestCase (Get resource groups)
PgAgentStatsTestCase (Check the stats of pgAgent job)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
ProcedureGetTestCase (Fetch Procedure Node URL)
ProcedureAddTestCase (Fetch Procedure Node URL)

EDB Postgres AS 9.4:

310 tests passed
3 tests failed:
ProcedureGetTestCase (Fetch Procedure Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
8 tests skipped:
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
TestSSLConnection (Test for SSL connection)
PgAgentAddTestCase (Add pgAgent job)
PgAgentGetTestCase (Get pgAgent job)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)

EDB Postgres AS 9.6:

313 tests passed
0 tests failed
8 tests skipped:
PgAgentDeleteTestCase (Delete pgAgent job)
PgAgentPutTestCase (Put pgAgent job)
PgAgentStatsTestCase (Check the stats of pgAgent job)
TestSSLConnection (Test for SSL connection)
PgAgentAddTestCase (Add pgAgent job)
PgAgentGetTestCase (Get pgAgent job)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)

EDB Postgres AS 9.2:

298 tests passed
3 tests failed:
ProcedureGetTestCase (Fetch Procedure Node URL)
procedureDeleteTestCase (Fetch Procedure Node URL)
ProcedurePutTestCase (Fetch Procedure Node URL)
20 tests skipped:
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
PgAgentPutTestCase (Put pgAgent job)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
ViewsGetTestCase (Get materialized view under schema node)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
PgAgentGetTestCase (Get pgAgent job)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 

Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11

[Dave Page]

Thanks, patch applied.

On Wed, Jun 13, 2018 at 12:43 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Please ignore my previous patch. Find the attached updated patch.
>
> On Wed, Jun 13, 2018 at 9:32 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Victoria,
>>
>> The updated patch is attached.
>>
>> On Tue, Jun 12, 2018 at 9:36 PM, Victoria Henry 
>> wrote:
>>
>>> Hi Khushboo,
>>>
>>> The following change is allowing the creation of procedures in
>>> postgresql versions less then 11 and also GreenPlum
>>>
>>> --- 
>>> a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
>>> +++ 
>>> b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
>>> @@ -71,11 +71,7 @@ define('pgadmin.node.procedure', [
>>>  if ('catalog' in node_hierarchy)
>>>return false;
>>>
>>> -// Procedures supported only in PPAS
>>> -return (
>>> -  'server' in node_hierarchy &&
>>> -node_hierarchy['server'].server_type == 'ppas'
>>> -);
>>> +return true;
>>>
>>> Fixed.
>>
>>> Now that the Procedures are a thing in Postgresql maybe they should live
>>> in their own module.
>>>
>> The main functionalities of the functions and procedures are almost same
>> and we have inherited most of the things from function itself.
>> So, as per me they should live in one module.
>>
>>> In the tests for trigger functions we are not consistent on the naming
>>> of the utils , in some places we call it funcs_utils in others
>>> trigger_funcs_utils.
>>>
>> Fixed.
>>
>>> Thanks
>>> ​
>>> Victoria & Joao
>>>
>>> Thanks,
>> Khushboo
>>
>>> On Tue, Jun 12, 2018 at 3:10 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached updated patch.

 On Fri, Jun 8, 2018 at 2:21 PM, Dave Page  wrote:

> Hi
>
> On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please ignore my previous patch, find the attached updated one.
>>
>
> I found a couple of issues with this:
>
> - Clicking the + button on the Parameters tab does nothing in either
> Create or Edit modes
>
> Fixed

> - The debugger fails to start (though, perhaps that's because the
> plugin doesn't have Ashesh's latest patches in it).
>
> FYI, I was trying to test the debugger with:
>
> -- PROCEDURE: public.dummy_proc(integer)
>
> -- DROP PROCEDURE public.dummy_proc(integer);
>
> CREATE OR REPLACE  PROCEDURE public.dummy_proc(
> id integer)
> LANGUAGE 'plpgsql'
>
> AS $BODY$BEGIN
>   raise notice 'id is %', id;
> END;$BODY$;
>
> Fixed. Tested with the latest code of the plugin.

> Thanks!
>
> Thanks,
 Khushboo

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Function and procedure support for PG11. Fixes #3362

[Dave Page]

Function and procedure support for PG11. Fixes #3362

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1ecba56b8d6c70de4e48b344e1d1e56561bbdfe
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/procedure_dialog.rst|  13 ++-
docs/en_US/release_notes_3_1.rst   |   5 +-
.../databases/schemas/functions/__init__.py|  10 +-
.../schemas/functions/static/js/procedure.js   |  19 ++--
.../function/pg/sql/11_plus/coll_stats.sql |  20 
.../templates/function/pg/sql/11_plus/create.sql   |  70 
.../templates/function/pg/sql/11_plus/delete.sql   |  21 
.../function/pg/sql/11_plus/get_definition.sql |  15 +++
.../templates/function/pg/sql/11_plus/get_oid.sql  |  17 +++
.../templates/function/pg/sql/11_plus/node.sql |  22 
.../function/pg/sql/11_plus/properties.sql |  33 ++
.../templates/function/pg/sql/11_plus/update.sql   | 116 
.../function/ppas/sql/9.2_plus/create.sql  |   2 +-
.../templates/procedure/pg/sql/default/acl.sql |  35 ++
.../procedure/pg/sql/default/coll_stats.sql|  20 
.../templates/procedure/pg/sql/default/create.sql  |  50 +
.../templates/procedure/pg/sql/default/delete.sql  |  21 
.../procedure/pg/sql/default/get_definition.sql|  15 +++
.../procedure/pg/sql/default/get_languages.sql |   4 +
.../templates/procedure/pg/sql/default/get_oid.sql |  17 +++
.../procedure/pg/sql/default/get_out_types.sql |   6 ++
.../procedure/pg/sql/default/get_schema.sql|   6 ++
.../procedure/pg/sql/default/get_types.sql |  20 
.../templates/procedure/pg/sql/default/node.sql|  29 +
.../procedure/pg/sql/default/properties.sql|  39 +++
.../templates/procedure/pg/sql/default/stats.sql   |   8 ++
.../templates/procedure/pg/sql/default/update.sql  | 106 ++
.../procedure/pg/sql/default/variables.sql |   6 ++
.../trigger_function/pg/sql/11_plus/coll_stats.sql |  20 
.../trigger_function/pg/sql/11_plus/create.sql |  57 ++
.../trigger_function/pg/sql/11_plus/delete.sql |  21 
.../pg/sql/11_plus/get_definition.sql  |  15 +++
.../trigger_function/pg/sql/11_plus/get_oid.sql|  18 
.../trigger_function/pg/sql/11_plus/node.sql   |  23 
.../trigger_function/pg/sql/11_plus/properties.sql |  33 ++
.../trigger_function/pg/sql/11_plus/update.sql | 109 +++
.../schemas/functions/tests/test_function_add.py   |  80 ++
.../functions/tests/test_function_delete.py|  49 +
.../schemas/functions/tests/test_function_get.py   |  49 +
.../schemas/functions/tests/test_function_put.py   |  57 ++
.../schemas/functions/tests/test_procedure_add.py  |  90 
.../functions/tests/test_procedure_delete.py   |  56 ++
.../schemas/functions/tests/test_procedure_get.py  |  55 ++
.../schemas/functions/tests/test_procedure_put.py  |  62 +++
.../functions/tests/test_trigger_func_add.py   |  43 ++--
.../functions/tests/test_trigger_func_delete.py|  48 ++---
.../functions/tests/test_trigger_func_get.py   |  51 +++--
.../functions/tests/test_trigger_func_put.py   |  58 +++---
.../databases/schemas/functions/tests/utils.py | 120 +
web/pgadmin/browser/utils.py   |   7 +-
web/pgadmin/tools/debugger/__init__.py |  18 +++-
.../templates/debugger/sql/execute_plpgsql.sql |   4 +-
.../debugger/sql/get_function_debug_info.sql   |   8 +-
web/pgadmin/utils/versioned_template_loader.py |   3 +-
54 files changed, 1717 insertions(+), 182 deletions(-)

Re: [PGAGENT] Upgrade pgAgent from unpackaged version

[Dave Page]

Thanks, applied.

On Wed, Jun 13, 2018 at 5:11 AM, Ashesh Vashi  wrote:

> Hi Dave,
>
> As per my conversation with Rushabh, we need to rename the
> pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the
> current version has changed. We also need to update the schema version
> function for the unpackaged extension.
>
> Please find the attached patch for the same.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAgent commit: Rename the "from unpackaged" extension SQL script and b

[Dave Page]

Rename the "from unpackaged" extension SQL script and bump it's schema version.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=dae1a10bfb4368c8510bce5b02d07d1b15934d53
Author: Ashesh Vashi 

Modified Files
--
...agent--unpackaged--3.4.sql => pgagent--unpackaged--4.0.sql} | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)

Re: [pgadmin4][patch] Use pytest test runner for unit tests

[Dave Page]

Hi

On Tue, Jun 12, 2018 at 3:41 PM, Victoria Henry  wrote:

> Hi Dave,
>
> Attached are four different patches that should be applied in order.
> Included is a fix for the failing test above.
>

This is no longer failing :-)

However, I'm still seeing problems that need to be resolved:

- Passwords are still being written to the log file. This is a complete
show-stopper.

- The regression.log file is empty. I'm now only getting the JSON summary.
We really need both - the regression log for diagnostics, and the JSON file
for feeding into monitoring systems.

- There is still no summary list of tests that failed or were skipped
output at the end of the run. This is important because it highlights which
tests failed (obviously!) and need investigation, and knowing which ones
are skipped at a glance is very useful as they can be skipped due to
mis-configuration; e.g. running against a different server than intended,
or failing to specify something like a tablespace path which we can then
easily see to fix.

- I cannot run against servers other than the first one in the config file.
We need to run against all that are enabled, and have the output show which
one was used for each one as we have now. This may seem trivial, but it's
really not - to the point that for some of us it negates the whole point of
the patch by giving us more control over which tests are run but removing
all control over which database servers they will run against. In my case,
this will almost certainly cost even more time; right now I just have to
run more tests than I may need but I can do other things at the same time.
With this patch I'll have to keep re-running the tests, modifying the
config between each run.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin][patch] Electron version 4.X

[Dave Page]

Hi

On Tue, Jun 12, 2018 at 8:04 PM, Victoria Henry  wrote:

> Hi Hackers,
>
> Attached is a revised patch with the following changes:
>
>- updated the README
>- moved the build scripts to the pkg folder
>- storing the out files in dist/arch/
>- fix the mac build so it no longer stalls on loading
>
> ​
>
> Here is a link to the updated mac binary:
> https://storage.googleapis.com/pgadmin-binaries/pgAdmin-
> 4.0.5-dev.darwin.zip
>

Looks good!

I've pushed your most recent patch along with some minor tweaks to a new
"electron" branch. The changes were:

- Use "pgAdmin" on menus
- Update the .gitignore file
- Remove the existing runtime
- add "macos-alias" to the package.json file

I've also created a rough TODO list at
https://redmine.postgresql.org/projects/pgadmin4/wiki/Electron_TODO_list to
keep an eye on outstanding items. Please add anything you have.

I intend to spend time on this as and when I can.

Thanks!


>
>
> Let us know what you think.
>
> Sincerely,
>
> Victoria && Joao
>
> On Mon, Jun 11, 2018 at 11:35 AM Dave Page  wrote:
>
>> Hi
>>
>> On Fri, Jun 8, 2018 at 3:49 PM, Victoria Henry  wrote:
>>
>>>
>>>
>>> On Tue, Jun 5, 2018 at 12:28 PM Dave Page  wrote:
>>>
 Hi

 On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> Attached you can find the patch that introduces electron to our code
> base.
>
 Cool. FYI, I'd like to get this into rough shape and then push it to a
 dev branch for fine-tuning. I think it'll be easier to work that way.

>>> Sure, you can create a dev branch and push this patch to it.
>>>
>>> Great. So here's my initial feedback:

 - The Mac build you provided doesn't work for me. It hangs on the
 loading screen.

>>> Could we get some more information about the machine?  Using the python
>>> from the venv directory, are you able to run the app directly?
>>>
>>> cd /Applications/pgAdmin.app/Contents/Resources/app/
>>> venv/bin/python web/pgAdmin4.py
>>>
>>> ​
>>> Do you get and error?
>>> We are setting PGADMIN_PORT, PGADMIN_KEY and SERVER_MODE environment
>>> variables prior to starting it.
>>>
>>
>> Yes, I get:
>>
>> piranha:app dpage$ venv/bin/python web/pgAdmin4.py
>>
>> Could not find platform independent libraries 
>>
>> Could not find platform dependent libraries 
>>
>> Consider setting $PYTHONHOME to [:]
>>
>> Fatal Python error: Py_Initialize: unable to load the file system codec
>>
>> ModuleNotFoundError: No module named 'encodings'
>>
>>
>> Current thread 0x7fffe86993c0 (most recent call first):
>>
>> Abort trap: 6
>>
>>
>>
>>
>>>
>>>


>>> - A number of the changes are related to the naming of requirejs. I'd be
 inclined to pull that out into a separate patch and get it committed to
 master ASAP.

>>> This change only makes sense in the Electron context. Neverthless fell
>>> free to add it to master if you think it is relevant.
>>>
>>>
 - I think the build instructions need to be more generic (particularly
 on macOS). For example, I do not use HomeBrew (largely due to some nasty
 security issues they had in the past). I was able to mostly port the
 instructions and build script over to work using MacPorts (without PyEnv)
 which actually turned out to be somewhat more simple than what's there now.

>>> Since we don't use MacPorts, we cannot provide installation instructions.
>>>
>>
>> I wasn't asking you to provide MacPort instructions; I can do that. I was
>> saying that the basic outline of the instructions should be agnostic to the
>> package tools the user might choose; e.g.
>>
>> - Install python
>> - Create a virtual environment using the --copies option called venv
>> - Move the virtual environment to ...
>>
>> We can then include examples of how to do that with brew, macports etc.
>>
>>
>>>
>>>
 - I'm not sure what this is intended to do: "git checkout electron".
 Clearly that isn't correct.

>>> That was the name of our development branch.  It can be removed.
>>>
>>
>> OK.
>>
>>
>>>
>>>

 - All new builds should be using Python 3.6. We need to deprecate 2.7
 as there are some Unicode related issues that cannot be fixed in it.

>>> For Windows, we are using 2.7 because of external library compilation
>>> issues.   Let us know if you are able to get around this or how to make
>>> this work.
>>>
>>
>> There are a couple of tricks if you're using Python 3.6. First, to
>> compile Pycrypto you need to do something like:
>>
>>
>>- set VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio
>>14.0\VC
>>- set CL=-FI"%VCINSTALLDIR%\INCLUDE\stdint.h"
>>- (https://stackoverflow.com/questions/41843266/microsoft-
>>windows-python-3-6-pycrypto-installation-error
>>
>> 
>>)
>>
>> Beforehand. Then, edit 

pgAdmin 4 commit: Remove directory added in error.

[Dave Page]

Remove directory added in error.

Branch
--
electron

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48c59f8f5cf9938530836b60b3f04b1e784f7ff9

Modified Files
--
.../.qmake.stash   |42 -
.../ConfigWindow.o |   Bin 874764 -> 0 bytes
.../LogWindow.o|   Bin 971432 -> 0 bytes
.../Makefile   |  2069 ---
.../Server.o   |   Bin 1483800 -> 0 bytes
.../TrayIcon.o |   Bin 1453020 -> 0 bytes
.../moc_ConfigWindow.cpp   |   119 -
.../moc_ConfigWindow.o |   Bin 511952 -> 0 bytes
.../moc_LogWindow.cpp  |   114 -
.../moc_LogWindow.o|   Bin 511064 -> 0 bytes
.../moc_Server.cpp |   114 -
.../moc_Server.o   |   Bin 659864 -> 0 bytes
.../moc_TrayIcon.cpp   |   150 -
.../moc_TrayIcon.o |   Bin 1376208 -> 0 bytes
.../moc_predefs.h  |   359 -
.../pgAdmin4.app/Contents/Info.plist   |35 -
.../pgAdmin4.app/Contents/MacOS/pgAdmin4   |   Bin 465064 -> 0 bytes
.../pgAdmin4.app/Contents/PkgInfo  | 1 -
.../pgAdmin4.app/Contents/Resources/empty.lproj| 0
.../pgAdmin4.app/Contents/Resources/pgAdmin4.icns  |   Bin 326224 -> 0 bytes
.../pgAdmin4.o |   Bin 1586232 -> 0 bytes
.../qrc_pgadmin4.cpp   | 14564 ---
.../qrc_pgadmin4.o |   Bin 237916 -> 0 bytes
.../ui_ConfigWindow.h  |   229 -
.../ui_LogWindow.h |   103 -
25 files changed, 17899 deletions(-)

pgAdmin 4 commit: Initial version of Electron based runtime

[Dave Page]

Initial version of Electron based runtime

Branch
--
electron

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9295c0991834b0b2a653c7e2ca0d4ec62b7701dd
Author: Victoria Henry 

Modified Files
--
.gitignore |16 +-
.../.qmake.stash   |42 +
.../ConfigWindow.o |   Bin 0 -> 874764 bytes
.../LogWindow.o|   Bin 0 -> 971432 bytes
.../Makefile   |  2069 +++
.../Server.o   |   Bin 0 -> 1483800 bytes
.../TrayIcon.o |   Bin 0 -> 1453020 bytes
.../moc_ConfigWindow.cpp   |   119 +
.../moc_ConfigWindow.o |   Bin 0 -> 511952 bytes
.../moc_LogWindow.cpp  |   114 +
.../moc_LogWindow.o|   Bin 0 -> 511064 bytes
.../moc_Server.cpp |   114 +
.../moc_Server.o   |   Bin 0 -> 659864 bytes
.../moc_TrayIcon.cpp   |   150 +
.../moc_TrayIcon.o |   Bin 0 -> 1376208 bytes
.../moc_predefs.h  |   359 +
.../pgAdmin4.app/Contents}/Info.plist  |12 +-
.../pgAdmin4.app/Contents/MacOS/pgAdmin4   |   Bin 0 -> 465064 bytes
.../pgAdmin4.app/Contents/PkgInfo  | 1 +
.../pgAdmin4.app/Contents/Resources/empty.lproj| 0
.../pgAdmin4.app/Contents/Resources}/pgAdmin4.icns |   Bin
.../pgAdmin4.o |   Bin 0 -> 1586232 bytes
.../qrc_pgadmin4.cpp   | 14564 +++
.../qrc_pgadmin4.o |   Bin 0 -> 237916 bytes
.../ui_ConfigWindow.h  |   229 +
.../ui_LogWindow.h |   103 +
electron/.compilerc|42 +
electron/.eslintrc |47 +
electron/.gitignore| 6 +
electron/README.md |72 +
electron/assets/icons/darwin/pgAdmin4.icns |   Bin 0 -> 326224 bytes
.../assets/icons/linux}/pgAdmin4.png   |   Bin
.../assets/icons/windows}/pgAdmin4.ico |   Bin
electron/index.html|19 +
electron/package-lock.json |48 +
electron/package.json  |   105 +
electron/pgadmin.js|60 +
electron/src/check_python_server.js|44 +
electron/src/index.html|10 +
electron/src/index.js  |   281 +
electron/src/logger.js |39 +
electron/test/index.js |40 +
electron/yarn.lock |  8192 +++
pkg/build-darwin.sh|65 +
pkg/build-linux.sh |70 +
pkg/build-windows.ps1  |50 +
runtime/.gitignore |18 -
runtime/ConfigWindow.cpp   |67 -
runtime/ConfigWindow.h |45 -
runtime/ConfigWindow.ui|   262 -
runtime/LogWindow.cpp  |89 -
runtime/LogWindow.h|40 -
runtime/LogWindow.ui   |   106 -
runtime/Server.cpp |   341 -
runtime/Server.h   |58 -
runtime/TrayIcon.cpp   |   256 -
runtime/TrayIcon.h |65 -
runtime/back.png   |   Bin 290 -> 0 bytes
runtime/close.png  |   Bin 346 -> 0 bytes
runtime/forward.png|   Bin 270 -> 0 bytes
runtime/pgAdmin4-mac.png   |   Bin 81551 -> 0 bytes
runtime/pgAdmin4.cpp   |   482 -
runtime/pgAdmin4.h |44 -
runtime/pgAdmin4.pro   |   107 -
runtime/pgAdmin4.qrc   |11 -
runtime/pgAdmin4.rc| 1 -
runtime/splash.png |   Bin 13559 -> 0 bytes
web/package.json   | 2 +
web/pgAdmin4.py| 5 +
web/pgadmin/browser/static/js/browser.js   |14 -
web/pgadmin/browser/templates/browser/index.html   | 8 +-
web/pgadmin/browser/templates/browser/js/utils.js  | 2 +-
web/pgadmin/dashboard/static/js/dashboard.js   | 4 +-

pgAdmin 4 commit: Branch refs/heads/electron was created

[git]

Branch refs/heads/electron was created.

View: 
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=shortlog;h=refs/heads/electron

Re: [pgadmin4][patch] Use pytest test runner for unit tests

[Dave Page]

Hi

On Tue, Jun 12, 2018 at 8:39 PM, Victoria Henry  wrote:

> Hi Dave,
>
>
>>
>> No, because it's firewalled to the nines inside our network. There's no
>> chance I'm making production build machines internet-accessible.
>>
>
> For a Open Source project, if the community cannot see the place where the
> tests are running it looses a huge part of the process. We believe that
> removing this capability will have a negative impact on the development,
> especially because we do not have a CI/CD.  Before the code is merged we
> will never know if master is broken or not.
>

This is one of multiple CI/CD systems; specifically it's the one that will
be producing our official builds. Security always trumps developer
convenience for build machines as far as I'm concerned - have you ever had
to deal with a possibly-compromised build server and the PR fallout etc
that can result from that?

The existing public system will be replaced with one that mirrors a portion
of the build system; specifically, the test jobs, but not the production
build jobs or dependencies. It may be removed completely in the future if I
can find a way to securely allow access to build info from the build system.


>
>
>>
>>
>>> We have some examples from our pipeline that we can share:
>>> Script that we use to run the UT + Feature tests on a docker image that
>>> has python+yarn+selenium+postgres installed on it:
>>> https://github.com/greenplum-db/pgadmin4-ci/blob/master/
>>> tasks/run-postgres-tests/run.sh
>>>
>>> This type of scripts can be added to the Jenkinsfile to create a
>>> pipeline step. A good practice in a reproducible pipeline is to use Docker
>>> to ensure that every test runs in a clean and predictable environment, this
>>> make it easy to reproduce a problem found in testing.
>>>
>>
>> Docker is of little use to us here, as 2 of the 4 build platforms cannot
>> be run in Docker (macOS and the Docker container), and the 3rd would be
>> extremely difficult to run that way (Windows)
>>
>
> The docker files that we are talking about here is to run the tests, and
> we believe that the tests are all running in a Linux environment.
>

No, I'm running tests on all platforms. We've proven numerous times that
just running them on Linux is not enough.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin4][Patch]: Support for create multiple test classes in one test file

[Dave Page]

On Tue, Jun 12, 2018 at 2:42 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Hackers,
> Instead of doing this change and include more test harnessing to the setup
> we have, do you think we can try to push to get pytest into the code base
> and all these features will come by default?
>
Agreed.



> Thanks
> Joao
> ​
>
> On Tue, Jun 12, 2018 at 9:30 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to create multiple test classes in one test file.
>>
>> For example: I have one test file *test_feature.py *where I wrote
>> multiple test classes
>> class TestX(BaseTestGenerator):
>>   class TestY(BaseTestGenerator):
>>   class TestZ(BaseTestGenerator):
>>
>> So with current implementation it will run the test cases for *TestZ*
>> class.
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

[Dave Page]

On Tue, Jun 12, 2018 at 6:34 AM, Ashesh Vashi  wrote:

> On Tue, Jun 12, 2018 at 10:04 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Tue, Jun 12, 2018 at 10:02 AM, Robert Eckhardt 
>> wrote:
>>
>>>
>>>
>>> On Tue, Jun 12, 2018, 12:27 AM Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 Hi Joao,

 On Tue, Jun 12, 2018 at 1:50 AM, Joao De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> Attached you can find the diff file that corrects RM 3415
> 
>
 If I understand correctly, you're disabling the privileges for GPDB.
 Is that correct?

>>>
>>> It should be only for Greenplum.
>>>
>> Yeah - I got that.
>>
>>
>>> There was a performance optimization in Postgres 9.2 that make the
>>> current query in Postgres performant.
>>>
>> Ok.
>>
>> Changes looks good to me.
>>
> Committed!
>

Should this have included an updated to the release notes?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company