[pgadmin4][patch] GreenPlum error while checking roles SQL

[Joao De Almeida Pereira]

Hi Hackers,

Attached you can find a patch that will correct issue #3578

The SQL command used to retrieve the SQL for the Role does not work,
because it as a piece of it that is intended for Postgres > 9.0.

Thanks
Joao
diff --git a/web/pgadmin/browser/server_groups/servers/roles/templates/role/sql/post8_4/sql.sql b/web/pgadmin/browser/server_groups/servers/roles/templates/role/sql/post8_4/sql.sql
index 642009e0..d3cb081b 100644
--- a/web/pgadmin/browser/server_groups/servers/roles/templates/role/sql/post8_4/sql.sql
+++ b/web/pgadmin/browser/server_groups/servers/roles/templates/role/sql/post8_4/sql.sql
@@ -59,35 +59,6 @@ FROM
 		oid=%(rid)s::OID
 	) r
 ) a) b)
--- PostgreSQL >= 9.0
-UNION ALL
-(SELECT
-	array_to_string(array_agg(sql), E'\n') AS sql
-FROM
-	(SELECT
-		'ALTER ROLE ' || pg_catalog.quote_ident(pg_get_userbyid(%(rid)s::OID)) ||
-		' SET ' || param|| ' TO ' ||
-		CASE
-		WHEN param IN ('search_path', 'temp_tablespaces') THEN value
-		ELSE quote_literal(value)
-		END || ';' AS sql
-	FROM
-		(SELECT
-			datname, split_part(rolconfig, '=', 1) AS param, replace(rolconfig, split_part(rolconfig, '=', 1) || '=', '') AS value
-		FROM
-			(SELECT
-d.datname, unnest(c.setconfig) AS rolconfig
-			FROM
-(SELECT *
-FROM
-	pg_catalog.pg_db_role_setting dr
-WHERE
-	dr.setrole=%(rid)s::OID AND dr.setdatabase!=0) c
-LEFT JOIN pg_catalog.pg_database d ON (d.oid = c.setdatabase)
-			) a
-		) b
-	) d
-)
 UNION ALL
 (SELECT
 	'COMMENT ON ROLE ' || pg_catalog.quote_ident(pg_get_userbyid(%(rid)s::OID)) || ' IS ' ||  pg_catalog.quote_literal(description) || ';' AS sql

pgAdmin 4 commit: Fix passing of --globals-only to global backups.

[Dave Page]

Fix passing of --globals-only to global backups.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d68c967423771af7083511c0dc0d48986ce63a44
Author: Akshay Joshi 

Modified Files
--
web/pgadmin/tools/backup/__init__.py   | 4 ++--
web/pgadmin/tools/backup/tests/test_backup_create_job_unit_test.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

Re: [pgAdmin4][Patch]: Fixed issue where "Backup Globals" not working correctly

[Dave Page]

Thanks, applied.

On Thu, Aug 16, 2018 at 11:14 AM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix issue where "Backup Globals" not working
> correctly. pg_dumpall utility runs without "--globals-only" flag even if
> user click on "Backup Globals" menu . Also correct the regression test
> case for it.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM2927] Move all CSS into SCSS files for consistency and ease of colour maintenance etc.

[Dave Page]

Hi

That looks much better... but, did you get the right shades of grey? They
seem to have a slight green hint to them.

On Thu, Aug 16, 2018 at 10:42 AM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Dave/Hackers,
>
> Please find attached the updated patch.
>
> On Thu, Aug 16, 2018 at 1:45 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Aug 16, 2018 at 6:14 AM, Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Wed, Aug 15, 2018 at 9:31 PM, Dave Page  wrote:
>>>
 One more thought - can you please look at updating the style guide on
 the website to be consistent? https://git.postgr
 esql.org/gitweb/?p=pgadmin-www.git;a=summary

>>> Yes. Will start working on this.
>>>

 Thanks.


 On Wed, Aug 15, 2018 at 1:17 PM, Dave Page  wrote:

> Hi
>
> On Tue, Aug 14, 2018 at 6:41 PM, Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch fixing the errors. I missed the linter
>> in webpack.config.js :(
>>
>
> That's better - thanks.
>
> A few thoughts:
>
> - The button bars now have the flat style, however disabled buttons
> are almost indistinguishable from enabled ones. If we're going to have a
> flatter style, then we need to make the foreground colour of the buttons
> much lighter when they're disabled.
>
 I guess they are distinguishable :/ (below screenshots). Plus you will
>>> get a disabled mouse pointer on button hover (after I send the updated
>>> patch). If we need to change the colors of the button then we need to
>>> override bootstrap variables and compile the less files.
>>>
>>>
>>>
>> I mean the button bar on the Query Tool or Debugger (though I only looked
>> at the former).
>>
>> BTW, you should grab the Sim Daltonism app from the app store on your
>> Mac. It shows you what the colours would look like to people with different
>> types of colour-blindness. It's very useful.
>>
> I have over-riden bootstrap class
>
> for such buttons to make foreground more lighter. The app helped, thanks.
>
>>
>>
>>
>>>
>>>

> - I'm not keen on using $color-white/$color-black. That pre-supposes
> what the colours are, in which case we might as well just hard-code the
> values. How about $color-foreground/$color-background?
>
 foreground/background is a good idea. It will be helpful in theming if
>>> we want a dark theme. All need to use these variables in places where no
>>> backgroud/foreground color is set in CSS classes. Will work on this.
>>>
>>>

> - One thing we may want to do in the future is to have the option for
> alternate themes (or at least just a dark one). Do you know (no need to do
> it now - I'm just asking) if we've got enough of the colours in
> _default_variables.scss (and overridden elsewhere) to be able to do that?
>
 I have added few more variables and should be enough. pgAdmin4 has
> limited number of colors
>
> and the current variables should be enough.
>
>> I have covered all the hash codes used in pgAdmin4 defined CSS/SCSS
>>> files. But, if we want the complete theme then we need to override the
>>> external CSS or override the variables and compile the less/sass files
>>> (bootstrap). This is part is still not done.
>>>
>>
>> Ack. Personally, I'd love a dark theme. Or even pluggable themes. That
>> would be awesome - but we have more important work first.
>>
> Moving to Bootstrap 4 will make it more easier :P
>
>
>>
>>
>>>
>
>> I have noticed one more thing, templated CSS. We should remove it.
>> For now I have skipped template css from webpack bundling.
>>
>
> +1
>
 Should this be done as part of this RM, or we need to create a separate
>>> one ?
>>>
>>
>> A separate one I think.
>>
> RM3574  created.
>
>
>>
>> Thanks!
>>
>>
>>>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: 

Re: [pgAdmin 4 - Bug #3556] Slash "/" in server group breaks table contents

[Jan Birk]

Den 16-08-2018 kl. 13:51 skrev Aditya Toshniwal:

Hi Jan,

Could you please upgrade pgAdmin4 to 3.2 and give a try. I tried on 
3.2, works fine for me.

Let us know if you face the problem.


Yes and thanks. It will take a few weeks but I will be back.

Best

/Jan

Re: [pgAdmin 4 - Bug #3556] Slash "/" in server group breaks table contents

[Aditya Toshniwal]

Hi Jan,

Could you please upgrade pgAdmin4 to 3.2 and give a try. I tried on 3.2,
works fine for me.
Let us know if you face the problem.

On Thu, Aug 16, 2018 at 5:13 PM, Jan Birk  wrote:

> Sure and sorry I didn't do it from the beginning:
>
>
> Version
> 3.0
> Copyright
> Copyright 2013 - 2018, The pgAdmin Development Team
> Python Version
> 2.7.5 (default, May 29 2017, 20:42:36) [GCC 4.8.5 20150623 (Red Hat
> 4.8.5-11)]
> Flask Version
> 0.12.2
> Application Mode
> Server
> Current User
> j...@stil.dk
>
> Thanks for a very fine product - we are very happy to use it and have a
> big benefit out of it.
>
> /Jan
>
>
>
> Den 16-08-2018 kl. 13:36 skrev redm...@postgresql.org:
>
> Issue #3556  has
> been updated by Aditya Toshniwal.
>
>- *File* slash-simulate-1.png
>
> 
>added
>
> Jan Birk wrote:
>
> Sure,
>
> I did mean servername and not servergroup name.
>
> The first screenshot is OK and then I rename servername from "Slash-Slash"
> to Slash/Slash" (reset layout) and now it breaks when selecting ex last 100
> rows... and returns " was not found on this server."
>
> A quick fix could bee to disallow use of "/" in servernames :-)
>
> Thanks for at very useful product.
>
> /Jan
>
> Hi Jan,
>
> I tried to simulate the steps and it works fine for me. Attached is the
> screenshot.
> Could you please let us know which version of pgAdmin4 are you using. The
> latest version is 3.2.
>
> Thanks.
> --
> Bug #3556: Slash "/" in server group breaks table contents
> 
>
>- Author: Jan Birk
>- Status: In Progress
>- Priority: Normal
>- Assignee: Aditya Toshniwal
>- Category:
>- Target version:
>- Platform: Web
>- Area: User Interface
>- Difficulty:
>- Sprint: EDB Sprint 21
>
> Hi
>
> If you make a servergroup and name it with slash'es ex "aaa/bbb" you will
> not be able til use sql's.
>
> Best
>
> /Jan
> Files pgadmin4-servername-ok.png
> 
> (82.2 KB)
> pgadmin-servername-not-ok.png
> 
> (49.1 KB)
> slash-simulate-1.png
> 
> (290 KB)
> --
>
> You have received this notification because you have either subscribed to
> it, or are involved in it.
> To change your notification preferences, please click here:
> https://redmine.postgresql.org/my/account
>
>
> --
>
>
> Med venlig hilsen / Best regards
>
> Jan Birk
> Høvedstensvej 13
> 2650 Hvidovre
> Mobile: +45 41741615
>
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

[pgAdmin4][patch] Correct handling of URL param values when striping version number

[Aditya Toshniwal]

Hi Hackers,

Attached is minor patch to correctly handle "values" in web/pgadmin/__init__.py
-> strip_version_number which can be None in some cases and will cause
exception when None .

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


StripVersionHandling.patch
Description: Binary data