pgAdmin4 v4.4 candidate builds

2019-04-01 Thread Akshay Joshi
Hi All,

pgAdmin4 v4.4 candidate builds and source can be found at
https://developer.pgadmin.org/builds/2019-04-01-1/

Fahar, can you please verify it for release on Thursday.

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


franslation update

2019-04-01 Thread fred . escallier

hello 
here's the fr translation for upcoming release Fred 

messages-fr.tar.xz
Description: application/xz-compressed-tar


pgAdmin 4 commit: Add missing files.

2019-04-01 Thread Dave Page
Add missing files.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=614c66940ad1f58598184d4c7f37983b131a4629

Modified Files
--
.../schemas/tables/tests/test_table_parameters.py  | 136 +++
.../schemas/views/tests/test_mviews_parameters.py  | 147 +
2 files changed, 283 insertions(+)



pgAdmin 4 commit: Update version for release.

2019-04-01 Thread Akshay Joshi
Update version for release.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f23f729c611b0130cdb69f3c979c204e48cfb4d

Modified Files
--
runtime/Info.plist   | 4 ++--
runtime/pgAdmin4.pro | 2 +-
web/config.py| 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)



pgAdmin 4 commit: Update message catalogs.

2019-04-01 Thread Akshay Joshi
Update message catalogs.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a019e2de6fb07da8bc58ebb91778df76cd2d5d7f

Modified Files
--
web/pgadmin/messages.pot   |  8655 
.../translations/de/LC_MESSAGES/messages.mo|   Bin 148461 -> 148353 
bytes
.../translations/de/LC_MESSAGES/messages.po|  9144 +
.../translations/es/LC_MESSAGES/messages.mo|   Bin 153345 -> 153165 
bytes
.../translations/es/LC_MESSAGES/messages.po|  9370 +
.../translations/fr/LC_MESSAGES/messages.mo|   Bin 157591 -> 157401 
bytes
.../translations/fr/LC_MESSAGES/messages.po| 10122 ++-
.../translations/ja/LC_MESSAGES/messages.mo|   Bin 164203 -> 163934 
bytes
.../translations/ja/LC_MESSAGES/messages.po|  9324 +
.../translations/ko/LC_MESSAGES/messages.mo|   Bin 150936 -> 150815 
bytes
.../translations/ko/LC_MESSAGES/messages.po|  9288 +
.../translations/pl/LC_MESSAGES/messages.mo|   Bin 148695 -> 148490 
bytes
.../translations/pl/LC_MESSAGES/messages.po|  9313 +
.../translations/ru/LC_MESSAGES/messages.mo|   Bin 186369 -> 185547 
bytes
.../translations/ru/LC_MESSAGES/messages.po|  9318 +
.../translations/zh/LC_MESSAGES/messages.mo|   Bin 127714 -> 127755 
bytes
.../translations/zh/LC_MESSAGES/messages.po|  9092 +
17 files changed, 65469 insertions(+), 18157 deletions(-)



Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."

2019-04-01 Thread Akshay Joshi
On Mon, Apr 1, 2019 at 2:19 PM Dave Page  wrote:

> Thanks, patch applied. The Jenkins jobs should kick in shortly, following
> which the release candidates can be built.
>

   Sure.

>
> On Fri, Mar 29, 2019 at 3:06 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave/Hackers
>>
>> On Fri, Mar 29, 2019 at 7:50 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Fri, Mar 29, 2019 at 7:41 PM Dave Page  wrote:
>>>
 Hi

 On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Hackers,
>
> I have started working on RM #4110 "Updating 'Custom auto-vacuum?'
> property throws error for Materialized View." and while working I have
> figured out following issues:
>
>- Reset some/all the parameter for table and toast table is not
>implemented.
>- Value of "Custom auto-vacuum?" is not retrieved and set properly.
>- When user set the "Custom auto-vacuum?" to "Yes" and none of the
>parameter is set previously then set the value of "Enabled?" control to
>"Yes".
>- Alignment of Table and remove extra margin from "Parameters"
>tab.
>
> Attached is the patch to fix all the above issues. Added API test
> cases.
> Please review it.
>

 I set the autovacuum_enabled=true and autovacuum_analyze_scale_factor=1
 on the test mview, but only the enabled setting is reflected when I re-open
 the properties dialogue. Other settings seems to be fine - it's just
 autovacuum_analyze_scale_factor that's broken.

 It's also not shown in the reverse-engineered SQL - neither is
 autovacuum_enabled.

>>>
>>>This looks like a old issue, not because of this patch. Will check
>>> and work on it.
>>>
>>
>>Fixed both the above issue, its an old issue. Problem is with
>> regular expression to fetch the 'autovacuum_analyze_scale_factor' and other
>> similar parameters too. Attached is the modified patch please review it.
>>
>>>
 Thanks.

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."

2019-04-01 Thread Dave Page
Thanks, patch applied. The Jenkins jobs should kick in shortly, following
which the release candidates can be built.

On Fri, Mar 29, 2019 at 3:06 PM Akshay Joshi 
wrote:

> Hi Dave/Hackers
>
> On Fri, Mar 29, 2019 at 7:50 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Fri, Mar 29, 2019 at 7:41 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 I have started working on RM #4110 "Updating 'Custom auto-vacuum?'
 property throws error for Materialized View." and while working I have
 figured out following issues:

- Reset some/all the parameter for table and toast table is not
implemented.
- Value of "Custom auto-vacuum?" is not retrieved and set properly.
- When user set the "Custom auto-vacuum?" to "Yes" and none of the
parameter is set previously then set the value of "Enabled?" control to
"Yes".
- Alignment of Table and remove extra margin from "Parameters" tab.

 Attached is the patch to fix all the above issues. Added API test cases.
 Please review it.

>>>
>>> I set the autovacuum_enabled=true and autovacuum_analyze_scale_factor=1
>>> on the test mview, but only the enabled setting is reflected when I re-open
>>> the properties dialogue. Other settings seems to be fine - it's just
>>> autovacuum_analyze_scale_factor that's broken.
>>>
>>> It's also not shown in the reverse-engineered SQL - neither is
>>> autovacuum_enabled.
>>>
>>
>>This looks like a old issue, not because of this patch. Will check and
>> work on it.
>>
>
>Fixed both the above issue, its an old issue. Problem is with
> regular expression to fetch the 'autovacuum_analyze_scale_factor' and other
> similar parameters too. Attached is the modified patch please review it.
>
>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgAdmin 4 commit: Fix custom autovacuum configuration for Materialized

2019-04-01 Thread Dave Page
Fix custom autovacuum configuration for Materialized Views. Fixes #4110

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d286bada5cad95d2b42c9190ab3fcb4eccafa65d
Author: Akshay Joshi 

Modified Files
--
docs/en_US/release_notes_4_4.rst   |  1 +
.../servers/databases/schemas/static/js/schema.js  | 52 ++-
.../partition/sql/gpdb/5_plus/properties.sql   | 12 ++--
.../partition/sql/pg/10_plus/properties.sql| 12 ++--
.../partition/sql/ppas/10_plus/properties.sql  | 12 ++--
.../templates/table/sql/10_plus/properties.sql | 12 ++--
.../templates/table/sql/9.1_plus/properties.sql| 12 ++--
.../templates/table/sql/default/properties.sql | 12 ++--
.../tables/templates/table/sql/default/update.sql  | 76 +-
.../table/sql/gpdb_5.0_plus/properties.sql | 12 ++--
.../servers/databases/schemas/tables/utils.py  | 36 ++
.../servers/databases/schemas/views/__init__.py| 15 +
.../templates/mview/pg/9.3_plus/sql/properties.sql | 14 ++--
.../templates/mview/pg/9.3_plus/sql/update.sql | 15 ++---
.../templates/mview/pg/9.4_plus/sql/properties.sql | 14 ++--
.../templates/mview/pg/9.4_plus/sql/update.sql | 15 ++---
.../mview/ppas/9.3_plus/sql/properties.sql | 14 ++--
.../templates/mview/ppas/9.3_plus/sql/update.sql   | 15 ++---
18 files changed, 225 insertions(+), 126 deletions(-)



pgAdmin 4 commit: Correct the feature number in the release note.

2019-04-01 Thread Akshay Joshi
Correct the feature number in the release note.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe6e5e3c45d213a0bf6294415a4a3d2f156dda2a

Modified Files
--
docs/en_US/release_notes_4_4.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)