[pgAdmin4][Patch] - RM 4160 - (Re-)Edit column properties blocked to "Increment value cannot be empty" error.
Hi, Please find the attached patch to fix the RM #4160 - (Re-)Edit column properties blocked to "Increment value cannot be empty" error. Thanks, Khushboo RM_4160.patch Description: Binary data
pgAdmin 4 commit: Fix skip on Windows.
Fix skip on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94e1820ccdd23daa88aaf8782d2013af4d354ef4 Modified Files -- web/pgadmin/setup/tests/test_permissions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin][RM4101] No confirmation before window refresh in query tabs
Thanks patch applied. On Wed, Apr 17, 2019 at 3:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to ask for confirmation before reload if query tool > or debugger is opened in a new tab. > I have also fixed a small issue where debugger is not opening in new tab. > > The datagrid/close URL which is called when query tool is closed was > called with GET method, which is ethically incorrect. Made it to use DELETE > instead. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Ensure that confirmation dialog should be popped up b
Ensure that confirmation dialog should be popped up before reload of query tool or debugger if it is opened in a new browser tab. Fixes #4101 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49b318c39e932b81472f2b186c3d242fedd41f2d Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_6.rst | 1 + web/pgadmin/browser/static/js/browser.js | 9 ++-- web/pgadmin/tools/datagrid/__init__.py | 2 +- web/pgadmin/tools/datagrid/static/js/datagrid.js | 2 +- .../tools/datagrid/templates/datagrid/index.html | 22 +++- web/pgadmin/tools/debugger/static/js/debugger.js | 12 +-- .../tools/debugger/templates/debugger/direct.html | 24 +- 7 files changed, 52 insertions(+), 20 deletions(-)
pgAdmin 4 commit: Urgh. Typo.
Urgh. Typo. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ac064de42e80cc8313900eab51567011c9cb0b0 Modified Files -- web/pgadmin/setup/tests/test_permissions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgAdmin 4 commit: Skip the permissions test on Windows which doesn't su
Skip the permissions test on Windows which doesn't support Unix style file permissions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ef71cf7495c6724bf27ff24bab35aa34678fe3d Modified Files -- web/pgadmin/setup/tests/test_permissions.py | 5 + 1 file changed, 5 insertions(+)
Re: [pgAdmin][RM4134] Tablespace location shows error "Location cannot be empty" in the pgAdmin 4
Thanks patch applied. On Thu, Apr 18, 2019 at 11:10 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix the error "Location cannot be empty" in > Tablespace dialog, which occurs even if Location is disabled in edit mode. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Fixed 'Location cannot be empty' error when open Tabl
Fixed 'Location cannot be empty' error when open Tablespace properties. Fixes #4134 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d96f453e7f708f0254ddf9462b7bd651b4a8a3c1 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_6.rst | 1 + .../server_groups/servers/tablespaces/static/js/tablespace.js| 5 +++-- .../browser/server_groups/servers/templates/macros/variable.macros | 4 +--- 3 files changed, 5 insertions(+), 5 deletions(-)
Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes
Thanks patch applied. On Thu, Apr 18, 2019 at 9:31 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Tue, Apr 16, 2019 at 1:05 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are my review comments: >> >>- Jasmine test case are failing. >> >> This is due to the Slickgrid upgrade. I will send the separate patch for > the same. > >> >>- Create a table with two columns *id bigint (must be primary key) *and >>*name text. *Insert couple of rows, now select any two rows and mark >>it for deletion, add new row and then click on *Save* button. Grid is >>not refreshed. >> >> >> Fixed. > > Thanks, > Khushboo > >> On Tue, Apr 16, 2019 at 11:34 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch with some modification discussed at >>> Redmine for the RM #2392. >>> >>> 1. On deletion, strikeout the selected rows and delete those while >>> clicking on the Save button. >>> 2. If only newly added rows are to be deleted then delete those directly. >>> >>> Also, Slickgrid has been upgraded to the latest v2.3.4. >>> >>> Thanks, >>> Khushboo >>> >>> On Tue, Apr 9, 2019 at 11:46 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Khushboo Found some new issues: 1. Delete button gets enabled if I select any new cell (type text) to enter some value. Fixed >>> 1. Add two new rows, don't click on Save button and delete couple of rows. Colour of newly added rows will changed to green. Not applicable now >>> 1. Create a table with Serial and Text column. Add two new rows, specify the values and don't click on Save button. Delete some rows and then click on Save button, data is saved in the database but grid is showing same serial id for two newly created rows. After re-run the query it shows the correct value. Fixed >>> Can you please fix the above issues. On Mon, Apr 8, 2019 at 2:20 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Apr 5, 2019 at 11:32 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> #3605 is fixed and found below issue in #2392 >> >>- As per steps given in RM, I have perform the same. But when I >>delete the row, delete button is still enabled and save button is >> disabled >>even though newly created row is still there. Apart from that code >> looks >>good to me. Please fix it. >> >> >> Fixed. > >> On Thu, Apr 4, 2019 at 5:27 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix: >>> >>> 1. #3605 - Edit Data: Deleting N number of rows makes first N number >>> of rows disable >>> 2. #2392 - Datagrid: If we delete any row it also saves newly added >>> row >>> >>> Thanks, >>> Khushboo >>> >>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: 1) Fix an issue where Deleting N number of rows makes
1) Fix an issue where Deleting N number of rows makes first N number of rows disable. Fixes #3605 2) Ensure that on clicking Delete button should not delete rows immediately from the database server, it should be deleted when Save button will be clicked. Fixes #2392 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b47d1dbf6d808c8e5d225dc3b8f4806a15e62e3 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_6.rst | 2 + web/pgadmin/static/js/selection/set_staged_rows.js | 2 +- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 64 -- .../tools/sqleditor/static/scss/_sqleditor.scss| 15 + 4 files changed, 52 insertions(+), 31 deletions(-)
