Re: Keyboard shortcuts macOS
Hi Anthony, Is the issue https://github.com/pgadmin-org/pgadmin4/issues/7507 you raised is for the same reason? Or it's a different issue. On Mon, May 27, 2024 at 8:11 PM Anthony DeBarros wrote: > One thing to add. I discovered that the key shortcuts that are displayed > when hovering over the menu bar icons DO work. But then why are those key > combinations different than what is specified under Preferences > Query > Tool > Keyboard shortcuts? > > On Mon, May 27, 2024 at 10:30 AM Anthony DeBarros < > anthonymdebar...@gmail.com> wrote: > >> Hi, I'm trying out the new Query Tool functionality for executing a >> script at the cursor position (very nice). However, I'm having trouble >> getting it (or any commands) to work via keyboard shortcuts. I know I'm >> probably missing something. >> >> I'm on macOS, Sonoma. But same thing on another MAc running Big Sur. >> >> For example, if I want to change the case of text in the Query Tool, the >> default shortcut is Cmd-Option-u. But pressing those keys on my Mac >> keyboard doesn't produce anything. >> >> Please let me know what I'm overlooking. Thanks! >> >> >> -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Regarding feature #6841
Hi Dave, On Fri, Apr 19, 2024 at 7:15 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Apr 19, 2024 at 7:05 PM Dave Page wrote: > >> Hi >> >> On Fri, 19 Apr 2024 at 14:32, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Fri, Apr 19, 2024 at 6:22 PM Dave Page wrote: >>> >>>> Hi >>>> >>>> On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal < >>>> aditya.toshni...@enterprisedb.com> wrote: >>>> >>>>> >>>>>> Even if you put the cursor on the "SELECT"? If so, that would imply >>>>>> the parser understands the string quoting; e.g. in this case, the Python >>>>>> multiline string. Presumably then it would also understand regular single >>>>>> and double quotes - what about (for example) a heredoc in a pl/sh >>>>>> function? >>>>>> >>>>> Yes, the parser understands all the aspects of a SQL query and so it >>>>> understands what type of token the cursor is based on which it does the >>>>> syntax highlighting I believe. >>>>> >>>> >>>> Does it? Even EPAS extensions? >>>> >>> I mean only standard SQL grammar. >>> >> >> Standard SQL grammar doesn't help us much - PostgreSQL is probably the >> most standard compliant dialect there is, but if it deviates from the >> standard in a few cases, and has a ton of syntax that isn't even in the >> standard. However, I suspect you mean PostgreSQL-standard, as we are using >> the PostgreSQL dialect in CodeMirror. But, pgAdmin also supports EPAS >> > We'll have to test different scenarios to know exactly what works and what > doesn't. > >> >> >>> >>>> >>>> >>>>> >>>>>> It sounds like Thom has similar concerns, and I know him well enough >>>>>> to know he wouldn't chime in without good reason. >>>>>> >>>>> There are limitations and it won't work correctly apart from standard >>>>> SQL queries. Like I said, we're adding it as a new button without touching >>>>> the existing working. If a user chooses to use the new button, he knows >>>>> that pgAdmin will try to find the query on its own. This is an optional >>>>> feature. >>>>> Additionally, what we could do is when the user hits the button we >>>>> will show a warning and the user can opt for not showing it again. >>>>> >>>> >>>> Ten minutes later they will have forgotten that warning. >>>> >>>> I'm currently thinking that we should display the current query all the >>>> time somehow (though I'm not sure how, without taking up a lot of space). >>>> >>> Can't we add some kind of tooltip or popover on hover over the execute >>> query button? >>> >> >> Possibly :-). Let's try a PoC. >> > OK. I'll ask Anil to create some samples. > We gave a thought on how a person would know what the query is when using keyboard shortcuts. So we came up with another suggestion. How about a highlighter on what is the query based on cursor position? Example below. We can disable it from preferences. We still need to check how the performance will be, although we'll add debouncing. [image: image.png] > >> >>> >>>> BTW, if we do figure out a way of doing this that we all agree is safe, >>>> I'm going to want to see a bunch of automated tests against valid EPAS and >>>> PG queries, as weird and bizarre as we can think of. >>>> >>> I agree. >>> >>>> >>>> -- >>>> Dave Page >>>> pgAdmin: https://www.pgadmin.org >>>> PostgreSQL: https://www.postgresql.org >>>> EDB: https://www.enterprisedb.com >>>> >>>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >>> <https://www.enterprisedb.com/> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> pgAdmin: https://www.pgadmin.org >> PostgreSQL: https://www.postgresql.org >> EDB: https://www.enterprisedb.com >> >> > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/> > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Regarding feature #6841
Hi Dave, On Fri, Apr 19, 2024 at 7:05 PM Dave Page wrote: > Hi > > On Fri, 19 Apr 2024 at 14:32, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Fri, Apr 19, 2024 at 6:22 PM Dave Page wrote: >> >>> Hi >>> >>> On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> >>>> >>>>> Even if you put the cursor on the "SELECT"? If so, that would imply >>>>> the parser understands the string quoting; e.g. in this case, the Python >>>>> multiline string. Presumably then it would also understand regular single >>>>> and double quotes - what about (for example) a heredoc in a pl/sh >>>>> function? >>>>> >>>> Yes, the parser understands all the aspects of a SQL query and so it >>>> understands what type of token the cursor is based on which it does the >>>> syntax highlighting I believe. >>>> >>> >>> Does it? Even EPAS extensions? >>> >> I mean only standard SQL grammar. >> > > Standard SQL grammar doesn't help us much - PostgreSQL is probably the > most standard compliant dialect there is, but if it deviates from the > standard in a few cases, and has a ton of syntax that isn't even in the > standard. However, I suspect you mean PostgreSQL-standard, as we are using > the PostgreSQL dialect in CodeMirror. But, pgAdmin also supports EPAS > We'll have to test different scenarios to know exactly what works and what doesn't. > > >> >>> >>> >>>> >>>>> It sounds like Thom has similar concerns, and I know him well enough >>>>> to know he wouldn't chime in without good reason. >>>>> >>>> There are limitations and it won't work correctly apart from standard >>>> SQL queries. Like I said, we're adding it as a new button without touching >>>> the existing working. If a user chooses to use the new button, he knows >>>> that pgAdmin will try to find the query on its own. This is an optional >>>> feature. >>>> Additionally, what we could do is when the user hits the button we will >>>> show a warning and the user can opt for not showing it again. >>>> >>> >>> Ten minutes later they will have forgotten that warning. >>> >>> I'm currently thinking that we should display the current query all the >>> time somehow (though I'm not sure how, without taking up a lot of space). >>> >> Can't we add some kind of tooltip or popover on hover over the execute >> query button? >> > > Possibly :-). Let's try a PoC. > OK. I'll ask Anil to create some samples. > > >> >>> BTW, if we do figure out a way of doing this that we all agree is safe, >>> I'm going to want to see a bunch of automated tests against valid EPAS and >>> PG queries, as weird and bizarre as we can think of. >>> >> I agree. >> >>> >>> -- >>> Dave Page >>> pgAdmin: https://www.pgadmin.org >>> PostgreSQL: https://www.postgresql.org >>> EDB: https://www.enterprisedb.com >>> >>> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >> <https://www.enterprisedb.com/> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > EDB: https://www.enterprisedb.com > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Regarding feature #6841
Hi Dave, On Fri, Apr 19, 2024 at 6:22 PM Dave Page wrote: > Hi > > On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >>> Even if you put the cursor on the "SELECT"? If so, that would imply the >>> parser understands the string quoting; e.g. in this case, the Python >>> multiline string. Presumably then it would also understand regular single >>> and double quotes - what about (for example) a heredoc in a pl/sh function? >>> >> Yes, the parser understands all the aspects of a SQL query and so it >> understands what type of token the cursor is based on which it does the >> syntax highlighting I believe. >> > > Does it? Even EPAS extensions? > I mean only standard SQL grammar. > > > >> >>> It sounds like Thom has similar concerns, and I know him well enough to >>> know he wouldn't chime in without good reason. >>> >> There are limitations and it won't work correctly apart from standard SQL >> queries. Like I said, we're adding it as a new button without touching the >> existing working. If a user chooses to use the new button, he knows that >> pgAdmin will try to find the query on its own. This is an optional feature. >> Additionally, what we could do is when the user hits the button we will >> show a warning and the user can opt for not showing it again. >> > > Ten minutes later they will have forgotten that warning. > > I'm currently thinking that we should display the current query all the > time somehow (though I'm not sure how, without taking up a lot of space). > Can't we add some kind of tooltip or popover on hover over the execute query button? > > BTW, if we do figure out a way of doing this that we all agree is safe, > I'm going to want to see a bunch of automated tests against valid EPAS and > PG queries, as weird and bizarre as we can think of. > I agree. > > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > EDB: https://www.enterprisedb.com > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Regarding feature #6841
Hi Dave, On Fri, Apr 19, 2024 at 4:10 PM Dave Page wrote: > > > On Fri, 19 Apr 2024 at 05:15, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Apr 18, 2024 at 8:07 PM Dave Page wrote: >> >>> Hi >>> >>> On Thu, 18 Apr 2024 at 15:26, Anil Sahoo >>> wrote: >>> >>>> Hi Dave, >>>> We took help from Code Mirror, i.e Code Mirror gives the parsed SQL >>>> from the editor through a tree called syntaxTree and by using some logic we >>>> extracted the statements which have semicolon in it and also added some >>>> extra logic to break the whole query on next of next line as empty or if >>>> comments are there. >>>> >>>> Using all this logic we got the individual queries and checked where >>>> our cursor is in editor and checked with the query and through this we got >>>> the actual query at cursor position. >>>> >>>> For example, >>>> >>>>1. if the cursor is at starting or ending position or anywhere in >>>>between a query with semicolon or without semicolon, that can be single >>>>line or multi line then the query gets extracted. >>>>2. if the cursor is at starting or ending position or anywhere in >>>>between a comment that can be single line or multi line then the comment >>>>gets extracted. >>>>3. if the cursor is at a position where the previous line has a >>>>query then that query gets extracted. >>>> >>>> For the anonymous block containing multiple queries, code mirror gives >>>> the statements differently. That is an incomplete query we can say, so the >>>> query tool gives error. We can say some limitations are there with Code >>>> Mirror. >>>> >>>> Please let me know if you have any questions on this. >>>> >>> >>> My main concern is that it doesn't get it wrong. Ever. Consider: >>> >>> DELETE FROM foo; SELECT * FROM foo; >>> >> It will depend where the cursor is and will pick one of the query, not >> both. >> >>> >>> Is that one statement or two? What if it's in the middle of a pl/python3 >>> function: >>> >>> my_sql = 'DELETE FROM foo; SELECT * FROM foo;' >>> >>> or >>> >>> my_sql = """DELETE FROM foo; >>> SELECT * FROM foo; >>> """ >>> >> Since it is a part of the string, it will not run the string part. It >> will execute along with my_sql= >> > > Even if you put the cursor on the "SELECT"? If so, that would imply the > parser understands the string quoting; e.g. in this case, the Python > multiline string. Presumably then it would also understand regular single > and double quotes - what about (for example) a heredoc in a pl/sh function? > Yes, the parser understands all the aspects of a SQL query and so it understands what type of token the cursor is based on which it does the syntax highlighting I believe. > > > >> >>> (those are just simple examples from the top of my head). >>> >>> It could be extremely dangerous if we or CodeMirror mis-parses >>> something, which seems quite possible unless it has access to the actual >>> parser that PostgreSQL uses. Which makes me think... what of EPAS? It has >>> an extended parser to handle some of the Oracle compatible syntax. Will >>> CodeMirror get that right? >>> >> CodeMirror parser only provides parsing for standard SQL grammar. It >> doesn't even understand pl/pgsql. It detects the query based on semicolons >> very effectively. We have added our own logic to take that query >> provided by CM and separate it by new line. >> Instead of making it as the main execute button, I realise we should make >> it as the second execute, and keep the main execute untouched. >> > > Anil's examples mostly didn't have semicolons though - and in many cases, > a user's script might not if they're writing a bunch of scratch queries and > (as I do currently) executing them as needed by highlighting. > > As I'm sure you're starting to understand, I'm extremely concerned that > this automatic parsing could get it wrong in some cases, which could > potentially lead to users inadvertently running a destructive query without > realising it. I'm also concerned that it will lead to less severe > unexpected results; the parser doesn't understand pl/pgsql, so by > ex
Re: Regarding feature #6841
Hi Thom, On Thu, Apr 18, 2024 at 8:26 PM Thom Brown wrote: > On Thu, Apr 18, 2024, 15:26 Anil Sahoo > wrote: > >> Hi Dave, >> We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from >> the editor through a tree called syntaxTree and by using some logic we >> extracted the statements which have semicolon in it and also added some >> extra logic to break the whole query on next of next line as empty or if >> comments are there. >> >> Using all this logic we got the individual queries and checked where our >> cursor is in editor and checked with the query and through this we got the >> actual query at cursor position. >> >> For example, >> >>1. if the cursor is at starting or ending position or anywhere in >>between a query with semicolon or without semicolon, that can be single >>line or multi line then the query gets extracted. >>2. if the cursor is at starting or ending position or anywhere in >>between a comment that can be single line or multi line then the comment >>gets extracted. >>3. if the cursor is at a position where the previous line has a query >>then that query gets extracted. >> >> For the anonymous block containing multiple queries, code mirror gives >> the statements differently. That is an incomplete query we can say, so the >> query tool gives error. We can say some limitations are there with Code >> Mirror. >> >> Please let me know if you have any questions on this. >> > > I guess my first question is, what is the requirement being fulfilled here? > > Also, I have more experience with selecting what to run, and having it run > whatever was selected. I don't see the current proposal as particularly > intuitive. Having the cursor midway through a statement (or even the last > line of a statement) doesn't quite feel right. What would happen in this > example?... > > SELECT contents > FROM |mytable > WHERE id BETWEEN 101 AND 200 > > ORDER BY id ASC; > > Note I placed a pipe to represent the cursor before the table name. And > would it make a difference if the first 3 lines were a single line? > > In any case, given all statements are separated by semicolons in > PostgreSQL, I am resistant to the idea of supporting them without for > specific features. > There is a requirement by many users to execute a query instead of the current execute script which essentially executes all the code in the editor if you don't have selection. The behaviour requested was to detect the SQL query based on position of the query and execute that - just like how DBeaver or many other SQL editors do. > > Regards > > Thom > > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Regarding feature #6841
Hi Dave, On Thu, Apr 18, 2024 at 8:07 PM Dave Page wrote: > Hi > > On Thu, 18 Apr 2024 at 15:26, Anil Sahoo > wrote: > >> Hi Dave, >> We took help from Code Mirror, i.e Code Mirror gives the parsed SQL from >> the editor through a tree called syntaxTree and by using some logic we >> extracted the statements which have semicolon in it and also added some >> extra logic to break the whole query on next of next line as empty or if >> comments are there. >> >> Using all this logic we got the individual queries and checked where our >> cursor is in editor and checked with the query and through this we got the >> actual query at cursor position. >> >> For example, >> >>1. if the cursor is at starting or ending position or anywhere in >>between a query with semicolon or without semicolon, that can be single >>line or multi line then the query gets extracted. >>2. if the cursor is at starting or ending position or anywhere in >>between a comment that can be single line or multi line then the comment >>gets extracted. >>3. if the cursor is at a position where the previous line has a query >>then that query gets extracted. >> >> For the anonymous block containing multiple queries, code mirror gives >> the statements differently. That is an incomplete query we can say, so the >> query tool gives error. We can say some limitations are there with Code >> Mirror. >> >> Please let me know if you have any questions on this. >> > > My main concern is that it doesn't get it wrong. Ever. Consider: > > DELETE FROM foo; SELECT * FROM foo; > It will depend where the cursor is and will pick one of the query, not both. > > Is that one statement or two? What if it's in the middle of a pl/python3 > function: > > my_sql = 'DELETE FROM foo; SELECT * FROM foo;' > > or > > my_sql = """DELETE FROM foo; > SELECT * FROM foo; > """ > Since it is a part of the string, it will not run the string part. It will execute along with my_sql= > > (those are just simple examples from the top of my head). > > It could be extremely dangerous if we or CodeMirror mis-parses something, > which seems quite possible unless it has access to the actual parser that > PostgreSQL uses. Which makes me think... what of EPAS? It has an extended > parser to handle some of the Oracle compatible syntax. Will CodeMirror get > that right? > CodeMirror parser only provides parsing for standard SQL grammar. It doesn't even understand pl/pgsql. It detects the query based on semicolons very effectively. We have added our own logic to take that query provided by CM and separate it by new line. Instead of making it as the main execute button, I realise we should make it as the second execute, and keep the main execute untouched. > > >> >> Regards >> Anil >> -- >> >> <http://www.enterprisedb.com> >> >> *Anil Sahoo* >> >> Software Engineer >> >> www.enterprisedb.com >> >> Power to Postgres >> >> <https://www.linkedin.com/company/edbpostgres> >> <https://twitter.com/edbpostgres?lang=en> >> <https://www.facebook.com/EDBpostgres> >> <https://www.instagram.com/EDBpostgres/> >> >> >> On Thu, Apr 18, 2024 at 2:24 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, 17 Apr 2024 at 15:08, Anil Sahoo >>> wrote: >>> >>>> Hi Hackers, >>>> >>>> This feature is about executing a query at the cursor position. And >>>> that query can be a one line or multiline. I have assigned a play icon >>>> button and F5 as the keyboard shortcut for the Execute Query feature, and >>>> for Execute Script, Playlist icon button and Alt+F5(Others),Option+F5(Mac) >>>> as keyboard shortcut. >>>> >>>> As now the query can run at cursor position, so for user convenience I >>>> am showing the current query just beside the Data Output toolbar. And on >>>> hover of the text, it will show the whole query as a tooltip. This query >>>> text will be available for both Execute Script and Execute Query. >>>> >>>> I have made the UI change for the feature #6841 >>>> <https://github.com/pgadmin-org/pgadmin4/issues/6841>. >>>> >>>> Please provide your suggestions and feedback if these changes look okay >>>> to you. >>>> >>> >>> How is this parsing the query to figure out the correct text to send to >>> the server? For exa
Re: Regarding feature #6841
Hi Anil, I think the toolbar query should look like an input box. And the tooltip with a codemirror is more UI friendly. On Wed, Apr 17, 2024 at 7:38 PM Anil Sahoo wrote: > Hi Hackers, > > This feature is about executing a query at the cursor position. And that > query can be a one line or multiline. I have assigned a play icon button > and F5 as the keyboard shortcut for the Execute Query feature, and for > Execute Script, Playlist icon button and Alt+F5(Others),Option+F5(Mac) as > keyboard shortcut. > > As now the query can run at cursor position, so for user convenience I am > showing the current query just beside the Data Output toolbar. And on hover > of the text, it will show the whole query as a tooltip. This query text > will be available for both Execute Script and Execute Query. > > I have made the UI change for the feature #6841 > <https://github.com/pgadmin-org/pgadmin4/issues/6841>. > > Please provide your suggestions and feedback if these changes look okay to > you. > > Regards, > Anil > -- > > <http://www.enterprisedb.com> > > *Anil Sahoo* > > Software Engineer > > www.enterprisedb.com > > Power to Postgres > > <https://www.linkedin.com/company/edbpostgres> > <https://twitter.com/edbpostgres?lang=en> > <https://www.facebook.com/EDBpostgres> > <https://www.instagram.com/EDBpostgres/> > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Keyboard shortcut challenges
Hi Yogesh, The difference between other editors and pgAdmin is that pgAdmin can run on the web. Which means, a pgAdmin server hosted on linux can be opened on a Mac machine browser. On Wed, Apr 17, 2024 at 10:49 AM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Aditya, > > What is the behaviour of the other editors with respect to Meta Key? If > they do not treat Meta key differently, then we shouldn't. > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Tue, Apr 16, 2024 at 4:44 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> Just came to my mind - We could add one more checkbox - "Is Meta?" for >> Ctrl. That way - users will have more control. >> >> On Tue, Apr 16, 2024 at 4:26 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> I'm working on removing the usage of Access Keys(which varies based on >>> OS and Browser combination) for keyboard shortcuts and instead use >>> shortcuts similar to all other IDEs. >>> The challenge here is OS. MacOS has an extra key - Meta, which pgAdmin >>> doesn't take as part of keyboard shortcut currently. In fact, Mac can take >>> Ctrl separately. >>> pgAdmin can run as a web app so it's even more difficult. It is not >>> possible to have multiple shortcuts based on the OS of the browser. >>> I suggest we consider Ctrl as Meta when running on a Mac. >>> Please let me know what you think. >>> >>> >>> [image: image.png] >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >>> <https://www.enterprisedb.com/> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >> <https://www.enterprisedb.com/> >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Keyboard shortcut challenges
Hi, Just came to my mind - We could add one more checkbox - "Is Meta?" for Ctrl. That way - users will have more control. On Tue, Apr 16, 2024 at 4:26 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I'm working on removing the usage of Access Keys(which varies based on OS > and Browser combination) for keyboard shortcuts and instead use shortcuts > similar to all other IDEs. > The challenge here is OS. MacOS has an extra key - Meta, which pgAdmin > doesn't take as part of keyboard shortcut currently. In fact, Mac can take > Ctrl separately. > pgAdmin can run as a web app so it's even more difficult. It is not > possible to have multiple shortcuts based on the OS of the browser. > I suggest we consider Ctrl as Meta when running on a Mac. > Please let me know what you think. > > > [image: image.png] > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/> > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Keyboard shortcut challenges
Hi Hackers, I'm working on removing the usage of Access Keys(which varies based on OS and Browser combination) for keyboard shortcuts and instead use shortcuts similar to all other IDEs. The challenge here is OS. MacOS has an extra key - Meta, which pgAdmin doesn't take as part of keyboard shortcut currently. In fact, Mac can take Ctrl separately. pgAdmin can run as a web app so it's even more difficult. It is not possible to have multiple shortcuts based on the OS of the browser. I suggest we consider Ctrl as Meta when running on a Mac. Please let me know what you think. [image: image.png] -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Enhancement Request - Query Tool - Run non-contiguous highlighted code
Hi Christopher, Can you please report this here - https://github.com/pgadmin-org/pgadmin4/issues/new? Additionally, please also add some screenshots or screen recording to help us understand the issue better. On Sun, Mar 17, 2024 at 10:12 PM Christopher Maurer wrote: > PGADMIN4's Query Tool will run only the highlighted SQL when a section of > the SQL window is highlighted. In the Windows operating system, this same > window allows the highlighting of non-contiguous areas using > ctrl-click on the mouse, but executing such multi-region highlighted > code fails because only the bottom-most highlighted region is executed. > > Note that this could be VERY useful when you have coded a CTE (common > table expression), as this code is at the top of the SQL and > its utilization may occur significantly below its definition. > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Issue 7193
Hi Florian, You can work on it. On Fri, Feb 23, 2024 at 2:17 PM Florian Sabonchi wrote: > Dear Sir or Madam > > is anyone working on this topic? > > https://github.com/pgadmin-org/pgadmin4/issues/7193 > > can I work on it? > > Yours sincerely, Florian Sabonchi > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 721290: Fix an issue where type column in dependents/depen...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 721290b1e9fbdb36fda66c76dd33ca973b27a47d https://github.com/pgadmin-org/pgadmin4/commit/721290b1e9fbdb36fda66c76dd33ca973b27a47d Author: Aditya Toshniwal Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M docs/en_US/release_notes_8_4.rst M web/pgadmin/misc/dependents/static/js/Dependents.jsx M web/pgadmin/misc/properties/CollectionNodeProperties.jsx Log Message: --- Fix an issue where type column in dependents/dependencies tab is not showing correct label. #7225 To unsubscribe from these emails, change your notification settings at https://github.com/pgadmin-org/pgadmin4/settings/notifications
Re: Json log format #7138
Hi Florian, Thank you for working on this. pgAdmin team will review your code. On Fri, Feb 9, 2024 at 10:42 PM wrote: > Dear Sir or Madam > > I have submitted a pull request on GitHub for the following issue: > https://github.com/pgadmin-org/pgadmin4/issues/7138. > > Kind regards, > > Florian Sabonchi > > > > > > > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 0904ad: Update release notes
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 0904adaed027f161a5d3ee5b7932d380b52fe5e5 https://github.com/pgadmin-org/pgadmin4/commit/0904adaed027f161a5d3ee5b7932d380b52fe5e5 Author: Aditya Toshniwal Date: 2024-02-02 (Fri, 02 Feb 2024) Changed paths: M docs/en_US/release_notes_8_3.rst M tools/requirements.txt Log Message: --- Update release notes
[pgadmin-org/pgadmin4] cdf49d: Fix failing feature tests
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: cdf49d6300f5051768311e5f56b68dd5154f138f https://github.com/pgadmin-org/pgadmin4/commit/cdf49d6300f5051768311e5f56b68dd5154f138f Author: Aditya Toshniwal Date: 2024-01-30 (Tue, 30 Jan 2024) Changed paths: M web/pgadmin/misc/properties/ObjectNodeProperties.jsx M web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/index.jsx Log Message: --- Fix failing feature tests
[pgadmin-org/pgadmin4] 028b70: Fix SonarQube bugs
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 028b70203cd405407c0d8a15740138fea93ce9b0 https://github.com/pgadmin-org/pgadmin4/commit/028b70203cd405407c0d8a15740138fea93ce9b0 Author: Aditya Toshniwal Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M web/pgadmin/misc/file_manager/static/js/components/GridView.jsx M web/pgadmin/static/js/PgTreeView/index.jsx M web/pgadmin/static/js/QuickSearch/index.jsx M web/pgadmin/static/js/components/PgTree/FileTreeItem/index.tsx M web/pgadmin/static/js/tree/tree.js M web/pgadmin/tools/search_objects/static/js/SearchObjects.jsx M web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/index.jsx Log Message: --- Fix SonarQube bugs
[pgadmin-org/pgadmin4] 47aa07: Update release notes
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 47aa070cc34839af841137863f9873b6eac9b8c4 https://github.com/pgadmin-org/pgadmin4/commit/47aa070cc34839af841137863f9873b6eac9b8c4 Author: Aditya Toshniwal Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M docs/en_US/release_notes_8_3.rst Log Message: --- Update release notes
[pgadmin-org/pgadmin4] e80e82: Allow drag-n-drop columns collection tree node as ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: e80e82cd7fef915a0d5530e9f7f8832dfe368212 https://github.com/pgadmin-org/pgadmin4/commit/e80e82cd7fef915a0d5530e9f7f8832dfe368212 Author: Aditya Toshniwal Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M docs/en_US/release_notes_8_3.rst M web/pgadmin/static/js/tree/ObjectExplorer.jsx M web/pgadmin/static/js/tree/tree.js M web/pgadmin/static/scss/_pgadmin.style.scss Log Message: --- Allow drag-n-drop columns collection tree node as comma separated columns. #4419
[pgadmin-org/pgadmin4] 93d25e: Use COOKIE_DEFAULT_PATH or SCRIPT_NAME in session ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 93d25eea0b069a120a7a32105b25a16bb17a3eb9 https://github.com/pgadmin-org/pgadmin4/commit/93d25eea0b069a120a7a32105b25a16bb17a3eb9 Author: Aditya Toshniwal Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M web/pgadmin/__init__.py M web/pgadmin/browser/__init__.py M web/pgadmin/evaluate_config.py M web/pgadmin/preferences/__init__.py M web/pgadmin/utils/session.py Log Message: --- Use COOKIE_DEFAULT_PATH or SCRIPT_NAME in session cookie path. #6557
[pgadmin-org/pgadmin4] d26c16: Improve auto-focus of editable data grid when addi...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: d26c167c767d58ff8d2ce92321f0dee08ad36ebd https://github.com/pgadmin-org/pgadmin4/commit/d26c167c767d58ff8d2ce92321f0dee08ad36ebd Author: Aditya Toshniwal Date: 2024-01-17 (Wed, 17 Jan 2024) Changed paths: M web/pgadmin/static/js/SchemaView/DataGridView.jsx M web/pgadmin/static/js/SchemaView/FormView.jsx M web/pgadmin/static/js/utils.js Log Message: --- Improve auto-focus of editable data grid when adding/editing rows
Re: Regarding codemirror upgrade and query tool autocomplete
Hi, Just to add to my previous email, double quoted table autocomplete works now with the latest minor version. More reasons to use the new approach. On Tue, Jan 2, 2024 at 4:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I am working on upgrading the CodeMirror package (used by SQL input/Query > editor) to the latest version. One major improvement is on the autocomplete > part. CodeMirror provides a very versatile way of using autocomplete now. > One needs to pass the schema, table and columns data and it will show up in > intellisense on typing. > Right now, we send the query to the backend and the backend sends the > suggestions which are shown on the screen. This can be very slow for remote > PostgreSQL servers as it queries everytime to the server for data and > requires an active connection. Also, not a good user experience. > I was playing around with the new autocomplete and I have attached the > screen-recording for the same. The data from the backend is loaded once the > query tool opens. > It has a few issues though. Column suggestions don't work correctly for > double quoted tables aliases. It doesn't suggest "joins" which we do right > now. > I still need to figure out how we can refresh the data when new > tables/columns are added/removed. Overall, I find it more useful to the > users as it is quick and does the job what someone expects from an > autocomplete/intellisense. > > Thoughts/Suggestions on whether we should use it or continue with existing? > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/> > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 524805: Fixed an issue where auto commit/rollback setting ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 5248055a01c07860f2c7b24eaad6a332d5179755 https://github.com/pgadmin-org/pgadmin4/commit/5248055a01c07860f2c7b24eaad6a332d5179755 Author: Aditya Toshniwal Date: 2024-01-01 (Mon, 01 Jan 2024) Changed paths: M docs/en_US/release_notes_8_2.rst M web/pgadmin/tools/sqleditor/__init__.py Log Message: --- Fixed an issue where auto commit/rollback setting not persisting across query tool connection change. #7091
[pgadmin-org/pgadmin4] e837de: Fixed browser autocomplete related issues on pgAdm...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: e837de5e8f228dfd2e448b41d1fdf66ef0a25da9 https://github.com/pgadmin-org/pgadmin4/commit/e837de5e8f228dfd2e448b41d1fdf66ef0a25da9 Author: Aditya Toshniwal Date: 2023-12-28 (Thu, 28 Dec 2023) Changed paths: M web/pgadmin/static/js/SecurityPages/ForgotPasswordPage.jsx M web/pgadmin/static/js/SecurityPages/LoginPage.jsx M web/pgadmin/static/js/SecurityPages/PasswordResetPage.jsx M web/pgadmin/static/js/components/FormComponents.jsx M web/pgadmin/tools/user_management/static/js/UserManagementDialog.jsx Log Message: --- Fixed browser autocomplete related issues on pgAdmin authentication related pages. #7082
[pgadmin-org/pgadmin4] 01a118: Fixed an error-'amname' when generating ERD for da...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 01a118d495b88bc385972ce150449c2df3d88e17 https://github.com/pgadmin-org/pgadmin4/commit/01a118d495b88bc385972ce150449c2df3d88e17 Author: Aditya Toshniwal Date: 2023-12-28 (Thu, 28 Dec 2023) Changed paths: M docs/en_US/release_notes_8_2.rst M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py Log Message: --- Fixed an error-'amname' when generating ERD for database containing parition tables. #7064
Re: pg_file_settings
Hi Rıdvan, This is a pgAdmin mailing list. Please send this to pgsql-ad...@postgresql.org for PostgreSQL related questions. On Mon, Dec 25, 2023 at 5:07 PM Rıdvan Korkmaz < serkan.ridvan.kork...@gmail.com> wrote: > Hi, > When I read the docs for pg_file_settings view on pg_file_settings > <https://www.postgresql.org/docs/current/view-pg-file-settings.html> > > This view is helpful for checking whether planned changes in the > configuration files will work, or for diagnosing a previous failure. Note > that this view reports on the current contents of the files, not on what > was last applied by the server. (The pg_settings view is usually sufficient > to determine that.) > > But the following test shows the opposite. When the parameter value is > "on" for *log_connections, *there is *no error for value*, which is the > expected case. But If I change the value in postgresql.conf to *"dummy"* > then re-run the query, this time *I expected the error column to show > error*,* but again it is null, *which means, I potentially apply this > value to the parameter. > > Is there something I am missing? > > Client and server is 16.1 from the RPM package. > > [image: image.png] > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 6d399f: Explicitly set max_connections to 100 for Python t...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 6d399f4fd75b22afa964ca5dc940a3bdaf6cebff https://github.com/pgadmin-org/pgadmin4/commit/6d399f4fd75b22afa964ca5dc940a3bdaf6cebff Author: Aditya Toshniwal Date: 2023-12-25 (Mon, 25 Dec 2023) Changed paths: M web/regression/python_test_utils/test_utils.py M web/regression/runtests.py Log Message: --- Explicitly set max_connections to 100 for Python test cases to fit Git action MacOS test cases
[pgadmin-org/pgadmin4] 41a62c: Fix JS test cases failing on Windows OS
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 41a62c80823653d2bcc86d539c20b694cfb25ac5 https://github.com/pgadmin-org/pgadmin4/commit/41a62c80823653d2bcc86d539c20b694cfb25ac5 Author: Aditya Toshniwal Date: 2023-12-23 (Sat, 23 Dec 2023) Changed paths: M web/jest.config.js Log Message: --- Fix JS test cases failing on Windows OS
[pgadmin-org/pgadmin4] 09b83e: Fixed an issue where pgAgent job schedule dialog i...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 09b83e54a2f151f845e432f6c087585adea4263c https://github.com/pgadmin-org/pgadmin4/commit/09b83e54a2f151f845e432f6c087585adea4263c Author: Aditya Toshniwal Date: 2023-12-21 (Thu, 21 Dec 2023) Changed paths: M docs/en_US/release_notes_8_2.rst M web/pgadmin/browser/static/js/node.js Log Message: --- Fixed an issue where pgAgent job schedule dialog is not opening for edit. #7070
[pgadmin-org/pgadmin4] c8d6ff: Fixed an issue where query tool title did not chan...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: c8d6ff8a6d7cd03220dd247e43e373204814212e https://github.com/pgadmin-org/pgadmin4/commit/c8d6ff8a6d7cd03220dd247e43e373204814212e Author: Aditya Toshniwal Date: 2023-12-21 (Thu, 21 Dec 2023) Changed paths: M docs/en_US/release_notes_8_2.rst M web/pgadmin/static/js/helpers/Layout/index.jsx M web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx M web/pgadmin/tools/sqleditor/static/js/components/sections/MainToolBar.jsx M web/pgadmin/tools/sqleditor/static/js/components/sections/Query.jsx Log Message: --- Fixed an issue where query tool title did not change after 'Save As' until any new change is made. #6193
Regarding improving layout for ERD
Hi Hackers, In ERD, the link between tables starts and ends on the exact columns. But it is actually creating more problems than helping in terms of viewing the diagram and tracing the links. There is no concrete algo for auto layouting with precise column links. I propose we’ll need to change how links connect to tables in ERD. Almost all tools available for ERD sides of the table for connecting and not precise columns and we should do the same. For comparison - https://github.com/pgadmin-org/pgadmin4/issues/6592#issuecomment-1842844847 Thoughts/Suggestions? -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 51b02a: Fix few accessibility related issues. #6991
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 51b02ae6d4879a4dbf3b2b503f3d439d2168127a https://github.com/pgadmin-org/pgadmin4/commit/51b02ae6d4879a4dbf3b2b503f3d439d2168127a Author: Aditya Toshniwal Date: 2023-12-06 (Wed, 06 Dec 2023) Changed paths: M web/pgadmin/static/js/components/CodeMirror.jsx M web/pgadmin/static/js/components/ContextMenu.jsx M web/pgadmin/static/js/components/FormComponents.jsx M web/pgadmin/static/js/components/PgTable.jsx M web/pgadmin/templates/base.html M web/pgadmin/tools/schema_diff/static/js/components/InputComponent.jsx M web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx Log Message: --- Fix few accessibility related issues. #6991
[pgadmin-org/pgadmin4] 16d1df: Fixed an issue where schema diff tool is not loadi...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 16d1df2a1b3ac0028acd697400dad98b5c2f05e9 https://github.com/pgadmin-org/pgadmin4/commit/16d1df2a1b3ac0028acd697400dad98b5c2f05e9 Author: Aditya Toshniwal Date: 2023-11-30 (Thu, 30 Nov 2023) Changed paths: M docs/en_US/release_notes_8_1.rst M web/pgadmin/static/js/helpers/withStandardTabInfo.jsx M web/pgadmin/tools/schema_diff/static/js/SchemaDiffModule.js M web/pgadmin/tools/schema_diff/static/js/components/InputComponent.jsx M web/pgadmin/tools/schema_diff/static/js/components/SchemaDiffCompare.jsx M web/pgadmin/tools/schema_diff/static/js/components/SchemaDiffComponent.jsx Log Message: --- Fixed an issue where schema diff tool is not loading preferences on start. #7017
[pgadmin-org/pgadmin4] 377216: Add support for generating ERD for a schema. #4580
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 377216caecf384157533dbb6edcc163472f8a394 https://github.com/pgadmin-org/pgadmin4/commit/377216caecf384157533dbb6edcc163472f8a394 Author: Aditya Toshniwal Date: 2023-11-28 (Tue, 28 Nov 2023) Changed paths: M docs/en_US/erd_tool.rst M web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js M web/pgadmin/tools/erd/static/js/ERDModule.js M web/pgadmin/tools/erd/static/js/erd_tool/ERDCore.js M web/pgadmin/tools/erd/utils.py Log Message: --- Add support for generating ERD for a schema. #4580
[pgadmin-org/pgadmin4] c9590b: Remove botocore from requirements as it is install...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: c9590b2d62c9ee0222b510ec1527b806284e8369 https://github.com/pgadmin-org/pgadmin4/commit/c9590b2d62c9ee0222b510ec1527b806284e8369 Author: Aditya Toshniwal Date: 2023-11-28 (Tue, 28 Nov 2023) Changed paths: M docs/en_US/release_notes_8_1.rst M requirements.txt Log Message: --- Remove botocore from requirements as it is installed by boto3
[pgadmin-org/pgadmin4] 115208: Reverse engineer serial columns when generating ER...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 115208c8d80790bbb0911777b087804c5c7644a1 https://github.com/pgadmin-org/pgadmin4/commit/115208c8d80790bbb0911777b087804c5c7644a1 Author: Aditya Toshniwal Date: 2023-11-23 (Thu, 23 Nov 2023) Changed paths: M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/utils.py M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py M web/pgadmin/browser/server_groups/servers/databases/utils.py M web/pgadmin/tools/erd/static/js/erd_tool/nodes/TableNode.jsx M web/pgadmin/tools/erd/utils.py Log Message: --- Reverse engineer serial columns when generating ERD for database/table. #6958
[pgadmin-org/pgadmin4] 19cbe8: More fixes related to rc-dock changes. #6479
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 19cbe8c39fdb0f29394b64d16292c00cf288e903 https://github.com/pgadmin-org/pgadmin4/commit/19cbe8c39fdb0f29394b64d16292c00cf288e903 Author: Aditya Toshniwal Date: 2023-11-20 (Mon, 20 Nov 2023) Changed paths: M web/pgadmin/misc/sql/static/js/SQL.jsx M web/pgadmin/static/js/helpers/Layout/index.jsx M web/pgadmin/static/js/helpers/withStandardTabInfo.jsx Log Message: --- More fixes related to rc-dock changes. #6479
[pgadmin-org/pgadmin4] 0bc044: Fixed an issue where Geometry Viewer renders geome...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 0bc044fa673cc5d396fdd086133c8f7b1839ee09 https://github.com/pgadmin-org/pgadmin4/commit/0bc044fa673cc5d396fdd086133c8f7b1839ee09 Author: Aditya Toshniwal Date: 2023-11-17 (Fri, 17 Nov 2023) Changed paths: M docs/en_US/release_notes_7_9.rst M web/pgadmin/misc/properties/CollectionNodeProperties.jsx M web/pgadmin/static/js/Theme/overrides/rcdock.override.js M web/pgadmin/tools/sqleditor/static/js/components/sections/GeometryViewer.jsx Log Message: --- Fixed an issue where Geometry Viewer renders geometry incorrectly after trying to view 3D or non-4326 SRID geometry. #6017
Re: Require suggestions on UI changes
Hi Pravesh, I suggest we can move the "Custom return type?" switch above with default as false and change "return type" to dropdown or text based on the switch. No need for a "Custom return type" textbox. On Thu, Nov 16, 2023 at 5:58 PM Pravesh Sharma < pravesh.sha...@enterprisedb.com> wrote: > Hi Team, > > I have made some UI changes for issue 6854 > <https://github.com/pgadmin-org/pgadmin4/issues/6854>. I have added a > switch *Custom return type? *if enabled, an input text box will be > visible in which the user can provide their desired return type, and when > this switch is enabled return type select box will be disabled. This custom > return type input and switch will be visible only when creating a new > function. > > Please provide your suggestions and feedback if these changes look okay to > you. > > > Regards, > Pravesh > -- > > <http://www.enterprisedb.com> > > Pravesh Sharma > > Software Engineer > > +91 9406461406 > > www.enterprisedb.com > > Power to Postgres > > <https://www.linkedin.com/company/edbpostgres> > <https://twitter.com/edbpostgres?lang=en> > <https://www.facebook.com/EDBpostgres> > <https://www.instagram.com/EDBpostgres/> > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 035829: Fix failing feature tests
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 0358298090c9b1edc5cd7df173d688b40b1627a5 https://github.com/pgadmin-org/pgadmin4/commit/0358298090c9b1edc5cd7df173d688b40b1627a5 Author: Aditya Toshniwal Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M web/pgadmin/browser/server_groups/servers/static/js/server.js Log Message: --- Fix failing feature tests
[pgadmin-org/pgadmin4] c9db4a: Add DROP SQL for foreign keys in SQL generated by ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: c9db4a0d16f90fb91c383fa097d40f313bc0c7b1 https://github.com/pgadmin-org/pgadmin4/commit/c9db4a0d16f90fb91c383fa097d40f313bc0c7b1 Author: Aditya Toshniwal Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M docs/en_US/release_notes_7_9.rst M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/utils.py M web/pgadmin/browser/server_groups/servers/roles/static/js/role.ui.js M web/pgadmin/browser/server_groups/servers/static/js/server.js M web/pgadmin/browser/static/js/node.js M web/pgadmin/static/js/Theme/overrides/rcdock.override.js M web/pgadmin/static/js/utils.js M web/pgadmin/static/scss/_codemirror.overrides.scss M web/pgadmin/static/scss/_pgadmin.style.scss M web/pgadmin/tools/erd/__init__.py M web/pgadmin/tools/user_management/static/scss/_user_management.scss Log Message: --- Add DROP SQL for foreign keys in SQL generated by ERD when using WITH DROP option. #5770
[pgadmin-org/pgadmin4] c4a5f8: Fix a crash issue occurring when debugging a funct...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: c4a5f8d707abef6a2cc9124517b3f0634822a2a0 https://github.com/pgadmin-org/pgadmin4/commit/c4a5f8d707abef6a2cc9124517b3f0634822a2a0 Author: Aditya Toshniwal Date: 2023-11-15 (Wed, 15 Nov 2023) Changed paths: M web/migrations/versions/9426ad06a63b_.py M web/pgadmin/tools/debugger/__init__.py Log Message: --- Fix a crash issue occurring when debugging a function with arguments when using pgAdmin with external config database. #6904
[pgadmin-org/pgadmin4] 75a2d8: More fixes for UI issues found when testing wcDock...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 75a2d880f6e5dc4144e6fc12260c8f0033525f7e https://github.com/pgadmin-org/pgadmin4/commit/75a2d880f6e5dc4144e6fc12260c8f0033525f7e Author: Aditya Toshniwal Date: 2023-11-14 (Tue, 14 Nov 2023) Changed paths: M web/pgadmin/browser/server_groups/servers/static/js/server.js M web/pgadmin/misc/statistics/static/js/Statistics.jsx M web/pgadmin/static/js/SchemaView/FormView.jsx M web/pgadmin/static/js/components/FormComponents.jsx M web/pgadmin/static/js/components/TabPanel.jsx M web/pgadmin/static/js/helpers/Layout/index.jsx M web/pgadmin/static/js/helpers/withStandardTabInfo.jsx Log Message: --- More fixes for UI issues found when testing wcDocker changes. #6479
Re: PgAdmin - Turkish Translation
Hi Sezer, Please check - https://www.pgadmin.org/development/translations/ Let us know if you have any questions. On Mon, Nov 13, 2023 at 2:33 PM Sezer BOZKIR wrote: > Hi PgAdmin team, > > I want to help you about the translation of the Pgadmin for Turkish > language. What should I do for helping officially? :) > > Regards, > -- > Sezer BOZKIR > Sr.Python Developer > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 85dd1e: Fix issues found when testing Flask upgrade and wc...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 85dd1e92ada90bb8d1c288216ebfc159b6978c4a https://github.com/pgadmin-org/pgadmin4/commit/85dd1e92ada90bb8d1c288216ebfc159b6978c4a Author: Aditya Toshniwal Date: 2023-11-08 (Wed, 08 Nov 2023) Changed paths: M web/config.py M web/pgadmin/__init__.py M web/pgadmin/static/js/Theme/index.jsx M web/pgadmin/static/js/Theme/overrides/rcdock.override.js M web/pgadmin/static/js/Theme/standard.js M web/pgadmin/static/js/components/ExternalIcon.jsx M web/pgadmin/static/js/components/TabPanel.jsx M web/pgadmin/static/js/helpers/ObjectExplorerToolbar.jsx M web/pgadmin/static/js/helpers/withStandardTabInfo.jsx M web/pgadmin/static/scss/resources/_default.variables.scss M web/pgadmin/tools/debugger/static/js/DebuggerModule.js M web/pgadmin/tools/erd/static/js/ERDModule.js M web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx Log Message: --- Fix issues found when testing Flask upgrade and wcDocker changes. #6479
[pgadmin-org/pgadmin4] ef0b30: Continue fixing multiple UI issues found when test...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: ef0b30b1cac8f5b18798bada20cf943c56df14c4 https://github.com/pgadmin-org/pgadmin4/commit/ef0b30b1cac8f5b18798bada20cf943c56df14c4 Author: Aditya Toshniwal Date: 2023-11-06 (Mon, 06 Nov 2023) Changed paths: M docs/en_US/release_notes_7_9.rst M web/pgadmin/dashboard/static/js/SystemStats/Storage.jsx M web/pgadmin/preferences/static/js/components/PreferencesComponent.jsx M web/pgadmin/static/js/QuickSearch/index.jsx M web/pgadmin/static/js/SchemaView/FormView.jsx M web/pgadmin/static/js/helpers/Notifier.jsx M web/pgadmin/static/js/helpers/withStandardTabInfo.jsx M web/pgadmin/tools/debugger/static/js/components/DebuggerArgumentComponent.jsx M web/pgadmin/tools/schema_diff/static/js/SchemaDiffModule.js M web/pgadmin/tools/schema_diff/static/js/components/SchemaDiffCompare.jsx M web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx Log Message: --- Continue fixing multiple UI issues found when testing wcDocker changes. #6479
[pgadmin-org/pgadmin4] 96fccd: Upgrade Flask, Flask-SQLAlchemy, Flask-WTF, Flask-...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 96fccd28a968ba41555bfa7fea68fb0a0334351e https://github.com/pgadmin-org/pgadmin4/commit/96fccd28a968ba41555bfa7fea68fb0a0334351e Author: Aditya Toshniwal Date: 2023-11-03 (Fri, 03 Nov 2023) Changed paths: M requirements.txt M web/config.py M web/pgAdmin4.py M web/pgacloud/providers/_abstract.py M web/pgadmin/__init__.py M web/pgadmin/browser/collection.py M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/type.py M web/pgadmin/dashboard/__init__.py M web/pgadmin/misc/__init__.py M web/pgadmin/misc/bgprocess/__init__.py M web/pgadmin/misc/cloud/__init__.py M web/pgadmin/misc/cloud/azure/__init__.py M web/pgadmin/misc/cloud/biganimal/__init__.py M web/pgadmin/misc/cloud/google/__init__.py M web/pgadmin/misc/cloud/rds/__init__.py M web/pgadmin/preferences/__init__.py M web/pgadmin/setup/db_upgrade.py M web/pgadmin/tools/grant_wizard/__init__.py M web/pgadmin/tools/maintenance/__init__.py M web/pgadmin/utils/__init__.py M web/pgadmin/utils/validation_utils.py M web/regression/python_test_utils/csrf_test_client.py M web/regression/runtests.py Log Message: --- Upgrade Flask, Flask-SQLAlchemy, Flask-WTF, Flask-Babel, Flask-Security-Too, WTForms, Werkzeug and keep backward compatibility with Python 3.7
[pgadmin-org/pgadmin4] 17acce: Continue fixing multiple UI issues found when test...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 17acce3e7bbb0290f0824b4e043a0937e0927923 https://github.com/pgadmin-org/pgadmin4/commit/17acce3e7bbb0290f0824b4e043a0937e0927923 Author: Aditya Toshniwal Date: 2023-11-01 (Wed, 01 Nov 2023) Changed paths: M .github/dependabot.yml M web/pgadmin/browser/static/js/node.js M web/pgadmin/misc/properties/ObjectNodeProperties.jsx M web/pgadmin/preferences/static/js/store.js M web/pgadmin/static/js/BrowserComponent.jsx M web/pgadmin/static/js/PgTreeView/index.jsx M web/pgadmin/static/js/Theme/index.jsx M web/pgadmin/static/js/Theme/overrides/rcdock.override.js M web/pgadmin/static/js/components/CodeMirror.jsx M web/pgadmin/static/js/helpers/Layout/index.jsx M web/pgadmin/static/js/helpers/Notifier.jsx M web/pgadmin/static/js/helpers/withStandardTabInfo.jsx M web/pgadmin/tools/erd/static/js/ERDModule.js M web/pgadmin/tools/sqleditor/static/js/SQLEditorModule.js M web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx Log Message: --- Continue fixing multiple UI issues found when testing wcDocker changes. #6479
[pgadmin-org/pgadmin4] e30d2e: Continue fixing multiple UI and SonarQube issues f...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: e30d2eca901e5ab16d572b40651890ed99b7c882 https://github.com/pgadmin-org/pgadmin4/commit/e30d2eca901e5ab16d572b40651890ed99b7c882 Author: Aditya Toshniwal Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: M docs/en_US/images/main_left_pane.png M docs/en_US/images/toolbar.png M docs/en_US/release_notes_7_9.rst M docs/en_US/toolbar.rst M docs/en_US/tree_control.rst M web/pgadmin/misc/statistics/static/js/Statistics.jsx M web/pgadmin/static/js/components/Buttons.jsx M web/pgadmin/static/js/helpers/Layout/index.jsx M web/pgadmin/static/js/helpers/ObjectExplorerToolbar.jsx M web/pgadmin/tools/sqleditor/static/js/components/sections/Query.jsx Log Message: --- Continue fixing multiple UI and SonarQube issues found when testing wcDocker changes. #6479
[pgadmin-org/pgadmin4] 4bc6dc: Fix the sorting of size on the statistics panel. #...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 4bc6dcca678dadee1502135485f7344786ea53d6 https://github.com/pgadmin-org/pgadmin4/commit/4bc6dcca678dadee1502135485f7344786ea53d6 Author: Aditya Toshniwal Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: M web/pgadmin/misc/statistics/static/js/Statistics.jsx Log Message: --- Fix the sorting of size on the statistics panel. #6459
[pgadmin-org/pgadmin4] 3e575e: Fix an annoying yarn version yml change
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 3e575e2f438e157c8fc3f26f249766415eda349f https://github.com/pgadmin-org/pgadmin4/commit/3e575e2f438e157c8fc3f26f249766415eda349f Author: Aditya Toshniwal Date: 2023-10-27 (Fri, 27 Oct 2023) Changed paths: M web/.yarnrc.yml Log Message: --- Fix an annoying yarn version yml change
[pgadmin-org/pgadmin4] b11b2a: Continue fixing multiple UI and SonarQube issues f...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: b11b2a2f50aa6f069d5cb21a6f0b7e8d2393e6ec https://github.com/pgadmin-org/pgadmin4/commit/b11b2a2f50aa6f069d5cb21a6f0b7e8d2393e6ec Author: Aditya Toshniwal Date: 2023-10-27 (Fri, 27 Oct 2023) Changed paths: M docs/en_US/code_overview.rst M docs/en_US/coding_standards.rst M web/.yarnrc.yml M web/config.py M web/pgadmin/browser/static/js/browser.js M web/pgadmin/misc/bgprocess/static/js/Processes.jsx M web/pgadmin/misc/dependencies/static/js/Dependencies.jsx M web/pgadmin/misc/dependents/static/js/Dependents.jsx M web/pgadmin/misc/properties/CollectionNodeProperties.jsx M web/pgadmin/misc/sql/static/js/SQL.jsx M web/pgadmin/misc/statistics/static/js/Statistics.jsx M web/pgadmin/static/js/BrowserComponent.jsx M web/pgadmin/static/js/SchemaView/index.jsx M web/pgadmin/static/js/Theme/index.jsx M web/pgadmin/static/js/Theme/overrides/rcdock.override.js M web/pgadmin/static/js/ToolView.jsx M web/pgadmin/static/js/components/Buttons.jsx M web/pgadmin/static/js/components/PgTable.jsx M web/pgadmin/static/js/components/PgTree/FileTreeX/index.tsx M web/pgadmin/static/js/helpers/Layout/index.jsx M web/pgadmin/static/js/helpers/Notifier.jsx M web/pgadmin/static/scss/_pgadmin.style.scss M web/pgadmin/templates/base.html M web/pgadmin/tools/debugger/static/js/components/DebuggerArgumentComponent.jsx M web/pgadmin/tools/sqleditor/static/js/components/sections/MainToolBar.jsx M web/webpack.config.js Log Message: --- Continue fixing multiple UI and SonarQube issues found when testing wcDocker changes. #6479
[pgadmin-org/pgadmin4] 5a7583: Move yarn to berry first before moving to 3.x
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 5a7583654f971e83fc47ddcf67652def31b63ad4 https://github.com/pgadmin-org/pgadmin4/commit/5a7583654f971e83fc47ddcf67652def31b63ad4 Author: Aditya Toshniwal Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M .github/workflows/run-javascript-tests.yml M Dockerfile Log Message: --- Move yarn to berry first before moving to 3.x
[pgadmin-org/pgadmin4] cfa7be: Fix the builds failing because of previous commit
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: cfa7bef407ff16fc9eca197a3f56ca43260cbeea https://github.com/pgadmin-org/pgadmin4/commit/cfa7bef407ff16fc9eca197a3f56ca43260cbeea Author: Aditya Toshniwal Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M web/.yarnrc.yml Log Message: --- Fix the builds failing because of previous commit
[pgadmin-org/pgadmin4] 8997f6: Do not use minor version x when setting yarn version
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 8997f616a2ff5acf85f38e59ff603a6f40a63c5e https://github.com/pgadmin-org/pgadmin4/commit/8997f616a2ff5acf85f38e59ff603a6f40a63c5e Author: Aditya Toshniwal Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M .github/workflows/run-javascript-tests.yml M Dockerfile M web/.yarnrc.yml M web/package.json Log Message: --- Do not use minor version x when setting yarn version
[pgadmin-org/pgadmin4] f50f79: Use yarn version 3.x as berry is taking version 4....
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: f50f799b88cf3056632729630a334e323936c669 https://github.com/pgadmin-org/pgadmin4/commit/f50f799b88cf3056632729630a334e323936c669 Author: Aditya Toshniwal Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M .github/workflows/run-javascript-tests.yml M Dockerfile Log Message: --- Use yarn version 3.x as berry is taking version 4.x now
[pgadmin-org/pgadmin4] 3bcac2: Fix multiple UI and SonarQube issues found when te...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 3bcac26ff925cd0c2d87975c1efcb0f58242db71 https://github.com/pgadmin-org/pgadmin4/commit/3bcac26ff925cd0c2d87975c1efcb0f58242db71 Author: Aditya Toshniwal Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M web/pgadmin/misc/bgprocess/static/js/Processes.jsx M web/pgadmin/misc/statistics/static/js/Statistics.jsx M web/pgadmin/preferences/static/js/components/PreferencesComponent.jsx M web/pgadmin/static/bundle/app.js M web/pgadmin/static/js/BrowserComponent.jsx M web/pgadmin/static/js/Dialogs/ConnectServerContent.jsx M web/pgadmin/static/js/Dialogs/MasterPasswordContent.jsx M web/pgadmin/static/js/Dialogs/NamedRestoreContent.jsx M web/pgadmin/static/js/Dialogs/RenameTabContent.jsx M web/pgadmin/static/js/SchemaView/MappedControl.jsx M web/pgadmin/static/js/Theme/index.jsx M web/pgadmin/static/js/UtilityView.jsx M web/pgadmin/static/js/components/ContextMenu.jsx M web/pgadmin/static/js/components/ObjectBreadcrumbs.jsx M web/pgadmin/static/js/helpers/Layout/LayoutIframeTab.jsx M web/pgadmin/static/js/helpers/Layout/index.jsx M web/pgadmin/static/js/helpers/ObjectExplorerToolbar.jsx M web/pgadmin/static/js/to_px.js M web/pgadmin/static/js/tree/tree.js M web/pgadmin/static/js/url_for.js M web/pgadmin/tools/debugger/static/js/components/DebuggerArgumentComponent.jsx M web/pgadmin/tools/schema_diff/static/js/components/ResultGridComponent.jsx M web/pgadmin/tools/sqleditor/static/js/components/QueryToolComponent.jsx M web/pgadmin/tools/sqleditor/static/js/sqleditor_title.js M web/regression/javascript/SchemaView/SchemaDialogViewEdit.spec.js M web/regression/javascript/__mocks__/@material-ui/core.jsx M web/regression/javascript/__mocks__/popper.js.js M web/regression/javascript/__mocks__/react-data-grid.jsx M web/regression/javascript/components/Privilege.spec.js R web/regression/javascript/erd/ui_components/ERDTool.spec.js M web/regression/javascript/setup-jest.js M web/regression/javascript/tree/pgadmin_tree_state_save_spec.js Log Message: --- Fix multiple UI and SonarQube issues found when testing wcDocker changes. #6479
[pgadmin-org/pgadmin4] ed51fe: Upgrade python package cryptography to latest version
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: ed51fe475edf214ba14e0b7b6e80a5e2f8738567 https://github.com/pgadmin-org/pgadmin4/commit/ed51fe475edf214ba14e0b7b6e80a5e2f8738567 Author: Aditya Toshniwal Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M requirements.txt Log Message: --- Upgrade python package cryptography to latest version
[pgadmin-org/pgadmin4] 862f10: Significant changes to use ReactJS extensively.
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 862f101772c0b33ce76fd968ed04c478cf1d0dc3 https://github.com/pgadmin-org/pgadmin4/commit/862f101772c0b33ce76fd968ed04c478cf1d0dc3 Author: Aditya Toshniwal Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M .github/workflows/run-javascript-tests.yml M Dockerfile M Makefile M README.md M docs/en_US/code_overview.rst M docs/en_US/coding_standards.rst M docs/en_US/menu_bar.rst M docs/en_US/preferences.rst M docs/en_US/theme/pgadmin4/static/style.css M pkg/linux/build-functions.sh M pkg/mac/build-functions.sh M runtime/.eslintrc.js M web/.eslintrc.js A web/babel.config.json A web/jest.config.js R web/karma.conf.js M web/package.json M web/pgadmin/__init__.py M web/pgadmin/about/static/js/AboutComponent.jsx M web/pgadmin/about/static/js/about.js M web/pgadmin/authenticate/static/js/kerberos.js M web/pgadmin/browser/__init__.py M web/pgadmin/browser/register_browser_preferences.py M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/utils.py M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/compound_triggers/static/js/compound_trigger.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/check_constraint/static/js/check_constraint.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/static/js/exclusion_constraint.ui.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.ui.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/rules/static/js/rule.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/enable_disable_triggers.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.ui.js M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/static/js/trigger.js M web/pgadmin/browser/server_groups/servers/databases/schemas/views/static/js/mview.js M web/pgadmin/browser/server_groups/servers/databases/static/js/database.js M web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.js M web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js M web/pgadmin/browser/server_groups/servers/roles/static/js/roleReassign.js M web/pgadmin/browser/server_groups/servers/static/js/binary_path.ui.js M web/pgadmin/browser/server_groups/servers/static/js/server.js M web/pgadmin/browser/static/js/MainMenuFactory.js M web/pgadmin/browser/static/js/activity.js M web/pgadmin/browser/static/js/browser.js M web/pgadmin/browser/static/js/collection.js M web/pgadmin/browser/static/js/constants.js R web/pgadmin/browser/static/js/frame.js M web/pgadmin/browser/static/js/heartbeat.js M web/pgadmin/browser/static/js/keyboard.js R web/pgadmin/browser/static/js/layout.js M web/pgadmin/browser/static/js/node.js R web/pgadmin/browser/static/js/node_view.jsx R web/pgadmin/browser/static/js/panel.js R web/pgadmin/browser/static/js/panel_view.jsx R web/pgadmin/browser/static/js/preferences.js R web/pgadmin/browser/static/js/quick_search/iframe_component.js R web/pgadmin/browser/static/js/quick_search/menuitems_help.js R web/pgadmin/browser/static/js/quick_search/online_help.js R web/pgadmin/browser/static/js/quick_search/trigger_search.js R web/pgadmin/browser/static/js/toolbar.js R web/pgadmin/browser/static/js/utility_view.jsx R web/pgadmin/browser/static/scss/_quick_search.scss M web/pgadmin/browser/templates/browser/index.html R web/pgadmin/browser/templates/browser/js/constants.js M web/pgadmin/browser/templates/browser/js/utils.js M web/pgadmin/dashboard/__init__.py A web/pgadmin/dashboard/static/js/ChartContainer.jsx M web/pgadmin/dashboard/static/js/ChartsDOM.jsx M web/pgadmin/dashboard/static/js/Dashboard.jsx M web/pgadmin/dashboard/static/js/Graphs.jsx M web/pgadmin/dashboard/static/js/SystemStats/CPU.jsx M web/pgadmin/dashboard/static/js/SystemStats/Memory.jsx M web/pgadmin/dashboard/static/js/SystemStats/Storage.jsx M web/pgadmin/dashboard/static/js/SystemStats/Summary.jsx M web/pgadmin/dashboard/static/js/WelcomeDashboard.jsx M web/pgadmin/messages.pot M web/pgadmin/misc/__init__.py A web/pgadmin/misc/bgprocess/static/js/BgProcessConstants.js M web/pgadmin/misc/bgprocess/static/js
[pgadmin-org/pgadmin4] fe753b: Fix doc build failure
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: fe753bd2728c94906014843488ea97a0e88a2109 https://github.com/pgadmin-org/pgadmin4/commit/fe753bd2728c94906014843488ea97a0e88a2109 Author: Aditya Toshniwal Date: 2023-10-21 (Sat, 21 Oct 2023) Changed paths: M docs/en_US/release_notes.rst Log Message: --- Fix doc build failure
[pgadmin-org/pgadmin4] 341618: Fix more UI issues related to System statistics da...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 3416184236c75131cd9e2d67cd1414a70d841502 https://github.com/pgadmin-org/pgadmin4/commit/3416184236c75131cd9e2d67cd1414a70d841502 Author: Aditya Toshniwal Date: 2023-10-18 (Wed, 18 Oct 2023) Changed paths: M web/pgadmin/dashboard/static/js/SystemStats/CPU.jsx M web/pgadmin/dashboard/static/js/SystemStats/Memory.jsx M web/pgadmin/static/js/Theme/overrides/uplot.override.js M web/pgadmin/static/js/components/PgChart/StreamingChart.jsx Log Message: --- Fix more UI issues related to System statistics dashboard
[pgadmin-org/pgadmin4] 6e3ee1: Fix an issue where servers are not listed in add n...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 6e3ee1c60728e2debdda9a0a114c0991f4ce3b39 https://github.com/pgadmin-org/pgadmin4/commit/6e3ee1c60728e2debdda9a0a114c0991f4ce3b39 Author: Aditya Toshniwal Date: 2023-10-18 (Wed, 18 Oct 2023) Changed paths: M web/pgadmin/tools/sqleditor/__init__.py Log Message: --- Fix an issue where servers are not listed in add new connection dialog.
[pgadmin-org/pgadmin4] b51240: Update release notes
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: b512404c851eb054d946f857eb5d11bf23ef528e https://github.com/pgadmin-org/pgadmin4/commit/b512404c851eb054d946f857eb5d11bf23ef528e Author: Aditya Toshniwal Date: 2023-10-17 (Tue, 17 Oct 2023) Changed paths: M docs/en_US/release_notes_7_8.rst Log Message: --- Update release notes
[pgadmin-org/pgadmin4] 344c23: Fix following issues in system stats:
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 344c236d726eab5daa0a0e5d91f575927f932403 https://github.com/pgadmin-org/pgadmin4/commit/344c236d726eab5daa0a0e5d91f575927f932403 Author: Aditya Toshniwal Date: 2023-10-17 (Tue, 17 Oct 2023) Changed paths: M web/pgadmin/dashboard/__init__.py M web/pgadmin/dashboard/static/js/SystemStats/CPU.jsx M web/pgadmin/dashboard/static/js/SystemStats/Memory.jsx M web/pgadmin/dashboard/static/js/SystemStats/Storage.jsx M web/pgadmin/dashboard/static/js/SystemStats/utility.js M web/pgadmin/static/js/components/PgChart/StreamingChart.jsx M web/pgadmin/static/js/utils.js Log Message: --- Fix following issues in system stats: 1. Graphs rendering in opposite directions on tab change. 2. Y-axis label width should be dynamic. 3. Tooltip values should be formatted.
[pgadmin-org/pgadmin4] 47e734: Fix an issue in graphical explain plan where query...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 47e734dbf2ca4c2ee5864300f883ceb630735bf9 https://github.com/pgadmin-org/pgadmin4/commit/47e734dbf2ca4c2ee5864300f883ceb630735bf9 Author: Aditya Toshniwal Date: 2023-10-16 (Mon, 16 Oct 2023) Changed paths: M docs/en_US/release_notes_7_8.rst M web/pgadmin/static/js/Explain/Graphical.jsx Log Message: --- Fix an issue in graphical explain plan where query tool crashes when the plan has parallel workers details and sort node is clicked for details. #6858
[pgadmin-org/pgadmin4] 3a62fc: Fix issues found during testing. #6229, #6836
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 3a62fc5a2a1d4f79a9a957fe96f3ae887408f03e https://github.com/pgadmin-org/pgadmin4/commit/3a62fc5a2a1d4f79a9a957fe96f3ae887408f03e Author: Aditya Toshniwal Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M docs/en_US/release_notes_7_8.rst M web/pgadmin/browser/server_groups/servers/__init__.py M web/pgadmin/browser/server_groups/servers/static/js/server.ui.js M web/pgadmin/dashboard/static/js/Dashboard.jsx Log Message: --- Fix issues found during testing. #6229, #6836
[pgadmin-org/pgadmin4] 10adb6: Add support for setting prepare threshold in serve...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 10adb6a11b0bd11c54ab5565e06d56a5786de7e2 https://github.com/pgadmin-org/pgadmin4/commit/10adb6a11b0bd11c54ab5565e06d56a5786de7e2 Author: Aditya Toshniwal Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M docs/en_US/images/server_advanced.png M docs/en_US/server_dialog.rst A web/migrations/versions/44b9ce549393_.py M web/migrations/versions/9426ad06a63b_.py M web/pgadmin/browser/server_groups/servers/__init__.py M web/pgadmin/browser/server_groups/servers/static/js/server.ui.js M web/pgadmin/model/__init__.py M web/pgadmin/utils/driver/psycopg3/connection.py M web/pgadmin/utils/driver/psycopg3/server_manager.py Log Message: --- Add support for setting prepare threshold in server connection. #6285
[pgadmin-org/pgadmin4] 6ba9c1: Fix failing JS test cases after scale related comm...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 6ba9c192ce1001e01103579a2e7cf819f93418af https://github.com/pgadmin-org/pgadmin4/commit/6ba9c192ce1001e01103579a2e7cf819f93418af Author: Aditya Toshniwal Date: 2023-10-11 (Wed, 11 Oct 2023) Changed paths: M web/regression/javascript/schema_ui_files/column.ui.spec.js Log Message: --- Fix failing JS test cases after scale related commit. #6851
[pgadmin-org/pgadmin4] 221af6: Fix an issue where scale in columns is not allowed...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 221af6caa6e0e4b3b8c1fe1b8457cbbed6d493ac https://github.com/pgadmin-org/pgadmin4/commit/221af6caa6e0e4b3b8c1fe1b8457cbbed6d493ac Author: Aditya Toshniwal Date: 2023-10-11 (Wed, 11 Oct 2023) Changed paths: M docs/en_US/release_notes_7_8.rst M web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/static/js/column.ui.js Log Message: --- Fix an issue where scale in columns is not allowed to have value as 0 or below. #6851
[pgadmin-org/pgadmin4] e22492: Fixed an issue where non-super PostgreSQL users ar...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: e22492ad5147127eaa35b7d04cd628d33ae54320 https://github.com/pgadmin-org/pgadmin4/commit/e22492ad5147127eaa35b7d04cd628d33ae54320 Author: Aditya Toshniwal Date: 2023-10-11 (Wed, 11 Oct 2023) Changed paths: M docs/en_US/release_notes_7_8.rst M web/pgadmin/dashboard/static/js/Dashboard.jsx M web/pgadmin/static/js/SchemaView/FormView.jsx Log Message: --- Fixed an issue where non-super PostgreSQL users are not able to terminate their own connections from dashboard. #6836
[pgadmin-org/pgadmin4] fc411b: Allow setting custom username for shared servers, ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: fc411bfc49ebfa723490a3bf94c8d9ead1fe0743 https://github.com/pgadmin-org/pgadmin4/commit/fc411bfc49ebfa723490a3bf94c8d9ead1fe0743 Author: Aditya Toshniwal Date: 2023-10-11 (Wed, 11 Oct 2023) Changed paths: M docs/en_US/images/server_general.png M docs/en_US/server_dialog.rst A web/migrations/versions/9426ad06a63b_.py M web/pgadmin/browser/server_groups/servers/__init__.py M web/pgadmin/browser/server_groups/servers/static/js/server.ui.js M web/pgadmin/model/__init__.py M web/pgadmin/static/js/SchemaView/DepListener.js M web/pgadmin/tools/import_export_servers/__init__.py M web/pgadmin/utils/__init__.py Log Message: --- Allow setting custom username for shared servers, with default as username of server being shared. #6229
[pgadmin-org/pgadmin4] 5981f4: In GUI tests, do not try to set the binary path in...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 5981f4bd13ac1849e513299500548b52c97ed409 https://github.com/pgadmin-org/pgadmin4/commit/5981f4bd13ac1849e513299500548b52c97ed409 Author: Aditya Toshniwal Date: 2023-10-09 (Mon, 09 Oct 2023) Changed paths: M web/regression/feature_tests/pg_utilities_backup_restore_test.py Log Message: --- In GUI tests, do not try to set the binary path in preferences if it is blank
[pgadmin-org/pgadmin4] 078a95: Remove the Pillow dependency completely.
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 078a959e3d132a2e7bc63c5c8d630d6cf0a259c9 https://github.com/pgadmin-org/pgadmin4/commit/078a959e3d132a2e7bc63c5c8d630d6cf0a259c9 Author: Aditya Toshniwal Date: 2023-10-05 (Thu, 05 Oct 2023) Changed paths: M requirements.txt M web/pgadmin/authenticate/mfa/authenticator.py Log Message: --- Remove the Pillow dependency completely.
[pgadmin-org/pgadmin4] 858c85: Upgrade Pillow to latest based on Python v3.7 comp...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 858c85adbeda1da2bb2c8ef8391ceb6a1619501a https://github.com/pgadmin-org/pgadmin4/commit/858c85adbeda1da2bb2c8ef8391ceb6a1619501a Author: Aditya Toshniwal Date: 2023-10-05 (Thu, 05 Oct 2023) Changed paths: M requirements.txt Log Message: --- Upgrade Pillow to latest based on Python v3.7 compatibility.
[pgadmin-org/pgadmin4] 5d2ce1: Fixed an issue in ERD tool where the downloaded im...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 5d2ce142ddab6e8a554a75bcce1017f0729d3fda https://github.com/pgadmin-org/pgadmin4/commit/5d2ce142ddab6e8a554a75bcce1017f0729d3fda Author: Aditya Toshniwal Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M docs/en_US/release_notes_7_8.rst M web/package.json M web/pgadmin/tools/erd/static/js/erd_tool/ERDCore.js M web/pgadmin/tools/erd/static/js/erd_tool/components/ERDTool.jsx M web/yarn.lock Log Message: --- Fixed an issue in ERD tool where the downloaded images have a few links cut. #4995
[pgadmin-org/pgadmin4] b9d300: Fix failing RE-SQL test cases for foreign tables o...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: b9d30069152b91c3c87af018604ce784cf096f67 https://github.com/pgadmin-org/pgadmin4/commit/b9d30069152b91c3c87af018604ce784cf096f67 Author: Aditya Toshniwal Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/alter_column_timestamp_with_default_value_using_function.msql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/alter_column_timestamp_with_default_value_using_function.sql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/alter_column_with_integer_generated_always_column_option_variables.msql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/alter_column_with_integer_generated_always_column_option_variables.sql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/create_column_timestamp_with_default_value_using_function.msql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/create_column_timestamp_with_default_value_using_function.sql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/create_column_with_integer_generated_always_column_option_variables.msql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/create_column_with_integer_generated_always_column_option_variables.sql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/12_plus/test.json R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/alter_column_numeric.msql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/alter_column_numeric.sql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/alter_column_text_with_default_value.msql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/alter_column_text_with_default_value.sql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/create_column_numeric.msql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/create_column_numeric.sql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/create_column_text_with_default_value.msql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/create_column_text_with_default_value.sql R web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/default/test.json A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/alter_column_timestamp_with_default_value_using_function.msql A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/alter_column_timestamp_with_default_value_using_function.sql A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/alter_column_with_integer_generated_always_column_option_variables.msql A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/alter_column_with_integer_generated_always_column_option_variables.sql A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/create_column_timestamp_with_default_value_using_function.msql A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/create_column_timestamp_with_default_value_using_function.sql A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/create_column_with_integer_generated_always_column_option_variables.msql A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/create_column_with_integer_generated_always_column_option_variables.sql A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/foreign_table_columns/tests/pg/12_plus/test.json A web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables
[pgadmin-org/pgadmin4] 3b616b: Handle a missing case in previous commit where a P...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 3b616b2fb1cf0dc31933aec751aea8ec266e5bcc https://github.com/pgadmin-org/pgadmin4/commit/3b616b2fb1cf0dc31933aec751aea8ec266e5bcc Author: Aditya Toshniwal Date: 2023-09-20 (Wed, 20 Sep 2023) Changed paths: M web/pgadmin/utils/__init__.py Log Message: --- Handle a missing case in previous commit where a PG binary may not be present on some systems. #6763
[pgadmin-org/pgadmin4] 35f05e: Fix the security issue of validate bin path to con...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 35f05e49b3632a0a674b9b36535a7fe2d93dd0c2 https://github.com/pgadmin-org/pgadmin4/commit/35f05e49b3632a0a674b9b36535a7fe2d93dd0c2 Author: Aditya Toshniwal Date: 2023-09-20 (Wed, 20 Sep 2023) Changed paths: M web/pgadmin/misc/__init__.py M web/pgadmin/utils/__init__.py Log Message: --- Fix the security issue of validate bin path to consider and fix more scenarios. #6763
[pgadmin-org/pgadmin4] 07f18a: Fix an issue where user get logged out if password...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 07f18a1b05092e88720feace8fc1191cb27b6c43 https://github.com/pgadmin-org/pgadmin4/commit/07f18a1b05092e88720feace8fc1191cb27b6c43 Author: Aditya Toshniwal Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M web/pgadmin/browser/__init__.py Log Message: --- Fix an issue where user get logged out if password in changed. #6274
[pgadmin-org/pgadmin4] 02ecc8: Fix a security related issue where an authenticate...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 02ecc82e73f12e84e54c3947ada943d80f746c87 https://github.com/pgadmin-org/pgadmin4/commit/02ecc82e73f12e84e54c3947ada943d80f746c87 Author: Aditya Toshniwal Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M docs/en_US/release_notes_7_7.rst M web/pgadmin/misc/__init__.py M web/pgadmin/misc/file_manager/__init__.py Log Message: --- Fix a security related issue where an authenticated user can run remote command using validate binary path API (CVE-2023-5002). #6763 (#6764)
[pgadmin-org/pgadmin4] 2f5fb6: Fix an issue where user is not able to change the ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 2f5fb6a9969a1b05104e45db60944586853614af https://github.com/pgadmin-org/pgadmin4/commit/2f5fb6a9969a1b05104e45db60944586853614af Author: Aditya Toshniwal Date: 2023-09-12 (Tue, 12 Sep 2023) Changed paths: M web/pgadmin/browser/__init__.py Log Message: --- Fix an issue where user is not able to change the password when SMTP is not configured. #6274. Fix an issue where changing the password shows success but the new password is not working. #6730.
Re: Replace jasmine+karma with jest
Adding to this - https://2022.stateofjs.com/en-US/libraries/testing/ here is what the usage says. On Tue, Sep 5, 2023 at 12:53 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I suggest we should replace jasmine+karma combination with jest for the > following reasons: > 1. Jest is a zero dependency, less config testing framework. > 2. Has built in support for React. Easy to write React test cases. Jasmine > is more for Angular than React. > 3. Jasmine requires enzyme to be installed separately, which is not always > up to date with latest React versions. > https://github.com/enzymejs/enzyme/issues/2524 it still doesn't support > React 18. > 3. Used by Facebook for React testing. > 4. In built code coverage. > 5. Allows React component mocking which is not possible with jasmine yet. > 6. It is jasmine compatible, so easy to migrate. > 7. Future proof. > > What do you think? > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/> > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Replace jasmine+karma with jest
Hi Hackers, I suggest we should replace jasmine+karma combination with jest for the following reasons: 1. Jest is a zero dependency, less config testing framework. 2. Has built in support for React. Easy to write React test cases. Jasmine is more for Angular than React. 3. Jasmine requires enzyme to be installed separately, which is not always up to date with latest React versions. https://github.com/enzymejs/enzyme/issues/2524 it still doesn't support React 18. 3. Used by Facebook for React testing. 4. In built code coverage. 5. Allows React component mocking which is not possible with jasmine yet. 6. It is jasmine compatible, so easy to migrate. 7. Future proof. What do you think? -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Pgadmin4 System Stats Extension Design
On Fri, Aug 25, 2023 at 12:15 PM Sahil Harpal wrote: > Hi Aditya, > > On Fri, 25 Aug 2023 at 12:06, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Sahil, >> >> On Fri, Aug 25, 2023 at 12:02 PM Sahil Harpal >> wrote: >> >>> Hi Aditya, >>> On Fri, 25 Aug 2023 at 11:29, Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> >>>> Hi Sahil, >>>> On Thu, Aug 24, 2023 at 8:07 PM Sahil Harpal >>>> wrote: >>>> >>>>> Hi, >>>>> Can we include total space stats (left pie chart) in the same bar >>>>> chart? or would it be better if we keep it separate? >>>>> [image: image.png] >>>>> >>>> How do you propose to merge both? I would also suggest using a stacked >>>> bar chart on the right. And format from bytes to MBs. >>>> >>>>> >>> Currently, I have implemented like this: >>> [image: image.png] >>> So, I was thinking of adding one more column for total space for each >>> disk. >>> Regarding the stacked bar chart, we will need to increase the height of >>> the default chart container; otherwise, the proportion of different >>> categories won't be clearly visible in some cases. >>> And I believe that if we use a stacked bar chart, there won't be a need >>> to provide total space details, as the height of that stacked bar will be >>> nothing but the total space, right? >>> >> I don't think we'll need to increase the height though. Even if you use >> stacks, they will show total for each drive and not total available space. >> > > Ahh yes, users won't be able to see the absolute total value. So should I > change it to a stacked bar with 3 categories then? > I would suggest keeping the pie chart and making the stacks of used and unused. If possible please keep the pie chart colors different from bar chart. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Pgadmin4 System Stats Extension Design
Hi Sahil, On Fri, Aug 25, 2023 at 12:02 PM Sahil Harpal wrote: > Hi Aditya, > On Fri, 25 Aug 2023 at 11:29, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Sahil, >> On Thu, Aug 24, 2023 at 8:07 PM Sahil Harpal >> wrote: >> >>> Hi, >>> Can we include total space stats (left pie chart) in the same bar chart? >>> or would it be better if we keep it separate? >>> [image: image.png] >>> >> How do you propose to merge both? I would also suggest using a stacked >> bar chart on the right. And format from bytes to MBs. >> >>> > Currently, I have implemented like this: > [image: image.png] > So, I was thinking of adding one more column for total space for each disk. > Regarding the stacked bar chart, we will need to increase the height of > the default chart container; otherwise, the proportion of different > categories won't be clearly visible in some cases. > And I believe that if we use a stacked bar chart, there won't be a need to > provide total space details, as the height of that stacked bar will be > nothing but the total space, right? > I don't think we'll need to increase the height though. Even if you use stacks, they will show total for each drive and not total available space. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Pgadmin4 System Stats Extension Design
Hi Sahil, On Fri, Aug 25, 2023 at 11:30 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Sahil, > > On Thu, Aug 24, 2023 at 8:28 PM Sahil Harpal > wrote: > >> On Sat, 19 Aug 2023 at 16:20, Sahil Harpal >> wrote: >> >>> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> >>>> >>>>- Sometimes graphs start from left and then shift to right. This >>>>issue I have reported in my initial review too. >>>> >>>> For StreamingChart should I ignore it for now? >>> On Mon, 7 Aug 2023 at 17:12, Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> >>>> OK I thought you wanted the graph to go from left to right. Yeah, I >>>> have seen that glitch a few times (but rare). I think you can ignore it for >>>> now, we can look into it once we get time. It is not a priority. >>>> >>> >>> Or try the solution below? >>> On Sun, 6 Aug 2023 at 13:21, Sahil Harpal >>> wrote: >>> >>>> I've tried one more approach here. If our data array is full, this >>>> graph shifting won't happen. So, if we initialize our data list with null >>>> values, there won't be any visible shift. What do you think about this >>>> solution? >>>> >>> Can you please help me with this? >> > Let me apply your patch and try once. > Can you please share the rebased patch? > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/> > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Pgadmin4 System Stats Extension Design
Hi Sahil, On Thu, Aug 24, 2023 at 8:28 PM Sahil Harpal wrote: > On Sat, 19 Aug 2023 at 16:20, Sahil Harpal > wrote: > >> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>>- Sometimes graphs start from left and then shift to right. This >>>issue I have reported in my initial review too. >>> >>> For StreamingChart should I ignore it for now? >> On Mon, 7 Aug 2023 at 17:12, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> OK I thought you wanted the graph to go from left to right. Yeah, I >>> have seen that glitch a few times (but rare). I think you can ignore it for >>> now, we can look into it once we get time. It is not a priority. >>> >> >> Or try the solution below? >> On Sun, 6 Aug 2023 at 13:21, Sahil Harpal >> wrote: >> >>> I've tried one more approach here. If our data array is full, this graph >>> shifting won't happen. So, if we initialize our data list with null values, >>> there won't be any visible shift. What do you think about this solution? >>> >> Can you please help me with this? > Let me apply your patch and try once. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Pgadmin4 System Stats Extension Design
Hi Sahil, On Thu, Aug 24, 2023 at 8:07 PM Sahil Harpal wrote: > Hi, > Can we include total space stats (left pie chart) in the same bar chart? > or would it be better if we keep it separate? > [image: image.png] > How do you propose to merge both? I would also suggest using a stacked bar chart on the right. And format from bytes to MBs. > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] e82831: Remove imagemin-pngquant as we already have a PNG ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: e8283173ba178ceaed646cd3a3ed9fc9d580d255 https://github.com/pgadmin-org/pgadmin4/commit/e8283173ba178ceaed646cd3a3ed9fc9d580d255 Author: Aditya Toshniwal Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M web/package.json M web/webpack.config.js M web/yarn.lock Log Message: --- Remove imagemin-pngquant as we already have a PNG optimizer imagemin-optipng
[pgadmin-org/pgadmin4] 779749: Fix an 'str expected' error in import/export when ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 779749a5156648a1456eb09496a6825eb53d8869 https://github.com/pgadmin-org/pgadmin4/commit/779749a5156648a1456eb09496a6825eb53d8869 Author: Aditya Toshniwal Date: 2023-08-21 (Mon, 21 Aug 2023) Changed paths: M web/pgadmin/utils/driver/psycopg3/server_manager.py Log Message: --- Fix an 'str expected' error in import/export when setting server password in env
[pgadmin-org/pgadmin4] 1adde6: Update release notes
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 1adde6084f368c8fb728c54105f2692bf18121f6 https://github.com/pgadmin-org/pgadmin4/commit/1adde6084f368c8fb728c54105f2692bf18121f6 Author: Aditya Toshniwal Date: 2023-08-16 (Wed, 16 Aug 2023) Changed paths: M docs/en_US/release_notes_7_6.rst Log Message: --- Update release notes
Re: Regarding removal for wcDocker and replace it with rc-dock #6479
For direct viewing https://drive.google.com/file/d/1yvpA7fCtiHkKPbShnYJ1BQMnStKs9fKZ/view?usp=sharing On Thu, Aug 10, 2023 at 4:55 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I am working on removing the jQuery based wcDocker with ReactJS based > rc-dock. > The new lib allows us to reset layout without reloading pgAdmin. The one > thing it doesn't provide is adding a panel using tab bar context menu. I > was able to add a custom context menu but only on the tabs and not on the > complete tab bar. > So my question is, do we need something to add a panel back or reset > layout should be enough as we'll not reload pgAdmin? > If yes, please suggest on how we can do it without using the context menu. > One way is to have a menu with check menu items for each default panel. > Attached is a screen recording to show the current behavior. > > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/> > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
Re: Pgadmin4 System Stats Extension Design
Hi Sahil,
On Sun, Aug 6, 2023 at 1:21 PM Sahil Harpal
wrote:
> Hi Aditya,
> On Thu, 3 Aug 2023 at 09:32, Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote
>
>> Because it is the default behaviour of streaming. You can add a prop
>> reverse=true to StreamingChart and change the code ret.reverse(); based
>> on condition.
>>
> So basically, you are suggesting to add one additional property to the
> streaming chart, right? Based on its value, apply ret.reverse(). This means
> if reverse is true, apply ret.reverse(), otherwise don't. But it is
> required to reverse our data every time, otherwise, I believe the most
> recent data point will be at the beginning of our plot.
> I've tried one more approach here. If our data array is full, this graph
> shifting won't happen. So, if we initialize our data list with null values,
> there won't be any visible shift. What do you think about this solution?
>
I would suggest changing the behaviour in StreamingChart so that it can be
used at other places. If you want to reverse it then you can still do it. I
had achieved reverse direction with the following piece of code. Basically,
creating an array of 75 points, filling it with available points and
reverse. You can change it based on reverse=true flag. In your case, simply
reverse, not need of 75 points.
Array.from(new Array(xRange).keys()),
...(data.datasets?.map((d)=>{
let ret = [...d.data];
ret.reverse();
return ret;
})??{}),
>
> Unrelated to this, I think instead of showing disk sizes in bytes you can
>> show them in a human readable format like below used in Statistics tab of
>> Tables collection node.
>>
> Sure I'll do this!
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/>
"Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 59c4a0: Fix an issue where query tool on shared server is ...
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 59c4a00134b56694b7b7d37b5a2a3430df122e98 https://github.com/pgadmin-org/pgadmin4/commit/59c4a00134b56694b7b7d37b5a2a3430df122e98 Author: Aditya Toshniwal Date: 2023-08-03 (Thu, 03 Aug 2023) Changed paths: M docs/en_US/release_notes_7_6.rst M web/pgadmin/browser/server_groups/servers/__init__.py Log Message: --- Fix an issue where query tool on shared server is throwing error if the pgAdmin config DB is external. #6252
[pgadmin-org/pgadmin4] c87321: Update release notes
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: c873217cf14429a33d62dc4130e4c05596ca585c https://github.com/pgadmin-org/pgadmin4/commit/c873217cf14429a33d62dc4130e4c05596ca585c Author: Aditya Toshniwal Date: 2023-08-03 (Thu, 03 Aug 2023) Changed paths: M docs/en_US/release_notes_7_6.rst Log Message: --- Update release notes
Re: Pgadmin4 System Stats Extension Design
Hi Sahil, On Wed, Aug 2, 2023 at 6:14 PM Sahil Harpal wrote: > Hi Khushboo, > > On Thu, 27 Jul 2023 at 16:26, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> You have made different files tab-wise; it would be more manageable if >> you could put them under a subfolder OR start a name with system_state or >> something like that. >> On Thu, Jul 27, 2023 at 1:59 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Some initial review comments. >>> - While applying the patch, I got warnings; please fix those. >>> - Fix PEP-8 errors (yarn run pep8) >>> - Fix the linter errors. Run *yarn run bundle:dev* instead of *yarn run >>> webpacker so* you will get the linter errors on every run. >>> - If the System Stat extension does not exist, display the appropriate >>> message instead of blank graphs. >>> - For the first time, graphs start from the opposite side, and after the >>> following API call, those get adjusted; please fix that. >>> - Please consider the refresh rate for the API calls (preferences >>> settings > Dashboards > Refresh rates) >>> >>>> > Thank you for the feedback. I have made all the changes as you have > suggested, except for the issue where graphs are starting from opposite > sides. I am using the same StreamingChart component that is already there. > I just made a few changes to handle multiple Y-axes. I tried debugging it, > but haven't found a solution yet. However, I also checked the pgAdmin4 > desktop application, and I observed a similar behavior there. The initial > graphs start from the opposite side and then get adjusted automatically, > but the transition is a little faster there. Could you please help identify > what might be causing this issue? > Because it is the default behaviour of streaming. You can add a prop reverse=true to StreamingChart and change the code ret.reverse(); based on condition. Unrelated to this, I think instead of showing disk sizes in bytes you can show them in a human readable format like below used in Statistics tab of Tables collection node. [image: image.png] > > Thank you, > Sahil > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/> "Don't Complain about Heat, Plant a TREE"
[pgadmin-org/pgadmin4] 3ba73a: Update axios to the current latest version(1.4.0)
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 3ba73ab1d95da5e1f74c8261b0b9085b0f839db2 https://github.com/pgadmin-org/pgadmin4/commit/3ba73ab1d95da5e1f74c8261b0b9085b0f839db2 Author: Aditya Toshniwal Date: 2023-08-01 (Tue, 01 Aug 2023) Changed paths: M web/package.json M web/regression/javascript/debugger/debugger_input_args_spec.js M web/regression/javascript/debugger/debugger_spec.js M web/regression/javascript/debugger/debugger_stack_spec.js M web/regression/javascript/debugger/debugger_tool_bar_spec.js M web/regression/javascript/erd/ui_components/ERDTool.spec.js M web/regression/javascript/file_manager/FileManager.spec.js M web/regression/javascript/processes/BgProcessManager.spec.js M web/regression/javascript/processes/ProcessDetails.spec.js M web/regression/javascript/schema_diff/schema_diff_spec.js M web/regression/javascript/search_objects/SearchObject.spec.js M web/regression/javascript/table/enable_disable_triggers_spec.js M web/yarn.lock Log Message: --- Update axios to the current latest version(1.4.0)
[pgadmin-org/pgadmin4] a1c726: Fix PEP8 issues with latest pycodestyle (#6636)
Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: a1c7265c41baba3a74d1812ae0c9d86f4860eed8 https://github.com/pgadmin-org/pgadmin4/commit/a1c7265c41baba3a74d1812ae0c9d86f4860eed8 Author: Aditya Toshniwal Date: 2023-07-31 (Mon, 31 Jul 2023) Changed paths: M .pycodestyle M web/pgacloud/utils/misc.py M web/pgadmin/authenticate/mfa/tests/test_mfa_view.py M web/pgadmin/authenticate/mfa/utils.py M web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py M web/pgadmin/browser/server_groups/servers/pgagent/__init__.py M web/pgadmin/misc/cloud/utils/__init__.py M web/pgadmin/misc/file_manager/__init__.py M web/pgadmin/tools/erd/__init__.py M web/pgadmin/tools/schema_diff/__init__.py M web/pgadmin/tools/user_management/__init__.py M web/pgadmin/utils/driver/psycopg3/__init__.py Log Message: --- Fix PEP8 issues with latest pycodestyle (#6636)
[pgadmin-org/pgadmin4]
Branch: refs/heads/pep8-new-pycodestyle Home: https://github.com/pgadmin-org/pgadmin4
