Re: pgAdmin v3.1 candidate builds and source...

[Robert Eckhardt]

On Tue, Jun 26, 2018 at 8:12 PM, Anthony DeBarros 
wrote:

> Sounds good! Must just be my environment. Thanks for checking it out!
>
> On Tue, Jun 26, 2018 at 2:11 PM Fahar Abbas 
> wrote:
>
>> Hi Anthony!
>>
>> I am not able to reproducible this issue using Browser[Chrome Version
>> 67.0.3396.99 (Official Build) (64-bit)] MAC OS X High Sierra Version
>> 10.13.3; PostgreSQL 9.6
>>
>
Working on my mac as well.

--Rob



>
>> On Tue, Jun 26, 2018 at 10:45 PM, Anthony DeBarros 
>> wrote:
>>
>>> Just fyi, I pulled a copy of the macOS version of this build, and for
>>> some reason I cannot expand the Tables node in the tree on any of my
>>> databases even though there are tables present. Could just be me, but
>>> wanted to note.
>>>
>>> Using Chrome beta 68; macOS High Sierra; Postgres 9.6
>>>
>>> On Tue, Jun 26, 2018 at 7:09 AM Dave Page  wrote:
>>>
 ... can be found at https://developer.pgadmin.
 org/builds/2018-06-26-3.1/ and dpage/pgadmin4:2018-06-26-3.1 on Docker
 Hub.

 Fahar; please verify for release on Thursday.

 Note that these are the first builds from the new fully automated build
 system, and both the Windows and Mac versions now use Python 3, so please
 be sure to test with extra care!

 Thanks!

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>
>>
>> --
>> Fahar Abbas
>> QMG
>> EnterpriseDB Corporation
>> Phone Office: +92-51-835-8874
>> Phone Direct: +92-51-8466803
>> Mobile: +92-333-5409707
>> Skype ID: syed.fahar.abbas
>> Website: www.enterprisedb.com
>>
>

Re: Release this week?

[Robert Eckhardt]

Shipit

On Mon, Jun 25, 2018, 10:37 AM Dave Page  wrote:

> Anyone have any reasons why we shouldn't push a release this week using
> the new automated build system (assuming they work as planned and no issues
> are found in QA)?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin4][patch][GreenPlum] Display SQL for tables takes 15 minutes to execute

[Robert Eckhardt]

On Tue, Jun 12, 2018, 12:27 AM Ashesh Vashi 
wrote:

> Hi Joao,
>
> On Tue, Jun 12, 2018 at 1:50 AM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Hackers,
>>
>> Attached you can find the diff file that corrects RM 3415
>> 
>>
> If I understand correctly, you're disabling the privileges for GPDB.
> Is that correct?
>

It should be only for Greenplum. There was a performance optimization in
Postgres 9.2 that make the current query in Postgres performant.

Rob


> -- Thanks, Ashesh
>
> ​
>> Thanks
>> Joao
>>
>
>

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

[Robert Eckhardt]

All,

These patches were first proposed on April 2 and the meaningful changes
have yet to be committed. ~8 weeks is long enough that my assumption now is
that these aren't going to be committed.

The goal of these patches is to begin to separate out the ACI tree in order
to allow us to do feature work on that chunk of the code. Are there any
alternate suggestions for this work?

Are there any ideas as to how we can meaningfully move forward with the
goal of allowing the tree view to support a very large number of tables?

-- Rob

On Thu, May 24, 2018 at 10:43 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hey, Thanks so much for the reply.
>
> We've noticed that you've made several modifications on top of our
> original patch. Unfortunately, we've found it very hard to follow. Could we
> please get a brief synopsis of the changes you have made - just so we can
> better understand the rationale behind them? Just like we've done for you
> previously.
>
> Let's keep in mind that the original intent was simply to introduce this
> abstraction into the code base, which is a big enough task. I'd hate for
> the scope of the changes we're making to expand beyond that.
>
> Thanks
> Joao && Anthony
>
>
> On Thu, May 24, 2018 at 2:59 AM Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Sorry for the late reply.
>> On Wed, May 16, 2018 at 8:55 PM, Anthony Emengo 
>> wrote:
>>
>>> export function canCreate(pgBrowser, childOfCatalogType) {
>>>   return canCreateObject.bind({
>>> browser: pgBrowser,
>>> childOfCatalogType: childOfCatalogType,
>>>   });
>>> }
>>>
>>> With respect to the above code: this bind pattern looks good and seems
>>> like the idiomatic way to handle this in JavaScript. On a lighter node, I
>>> don’t even see the need for an additional method to wrap it. The invocation
>>> could have easily been like canCreate: canCreateObject.bind({ browser:
>>> pgBrowser, childOfCatalogType: childOfCatalogType }), I don’t feel too
>>> strongly here.
>>>
>> I do agree - we can handle the same problem many ways.
>> I prefer object oriented pardigm more in general.
>> Any way - I have modified the code with some other changes.
>>
>>> I renamed it as isValidTreeNodeData, because - we were using it in for
>>> testing the tree data. Please suggest me the right place, and name.
>>>
>>> We’re not sure; maybe after continued refactoring, we will come across
>>> more generic functions. At that point we can revisit this and create a
>>> utils.js file.
>>>
>> Sure.
>>
>>> The original patch was separating them in different places, but - still
>>> uses some of the functionalities directly from the tree, which was
>>> happening because we have contextual menu.
>>> To give a better solution, I can think of putting the menus related code
>>> understand ‘sources/tree/menu’ directory.
>>>
>>> We’re particularly worried because we’re trying to avoid the coupling
>>> that we see in the code base today. We want to decouple *application
>>> state* from *business domain* logic as much as we can - because this
>>> makes the code much easier to understand. We achieve lower coupling by have
>>> more suitable interfaces to retrieve *application state* like: anyParent
>>> (the menu doesn’t care how this happens). This is the direction that we’re
>>> trying to move towards, we just don’t want the package structure to
>>> undermine that developer intent.
>>>
>> I realized after revisiting the code, menu/can_create.js was only
>> applicable to the children of the schema/catalog nodes, same as
>> 'can_drop_child'.
>> We should have put both scripts in the same directory.
>>
>> Please find the updated patch for the same.
>>
>> Please review it, and let me know your concerns.
>>
>> -- Thanks, Ashesh
>>
>>> How about nodeMenu.isSupportedNode(…)?
>>>
>>> Naming is one of the hardest problems in programming. I don’t feel too
>>> strongly about this one. For now, let’s keep it as is
>>>
>>> Thanks
>>> Anthony && Victoria
>>> ​
>>>
>>>
>>>
>>>
>>

Re: Possibility to increase release frequency

[Robert Eckhardt]

On Mon, Apr 30, 2018 at 10:51 AM, Dave Page <dp...@pgadmin.org> wrote:
> Hi
>
> On Mon, Apr 30, 2018 at 3:33 PM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>>
>> All,
>>
>> Currently we are starting to get a fair number of users leveraging
>> pgAdmin 4. Because of this we are finding new issues with Greenplum we
>> didn't previously know about and we would like to get the fixes for
>> those issues out as soon as possible.
>>
>> The current release process is shrouded in a bit of darkness for us so
>> I'm not sure what this ask even entails.
>
>
> I'm actively working on a buildfarm for doing automated official releases
> that folks other than I will have access to. Current status:
>
> - Jenkins host up and running
> - Automated dependency builds of zlib, OpenSSL and PostgreSQL running on
> Windows (just pgAdmin to go)
> - Automated dependency builds of OpenSSL and PostgreSQL running on macOS
> (just pgAdmin to go)
> - Automated dependency builds of PostgreSQL running on Linux
> - All test suites (JS linter and tests, Python PEP-8, unit/API and feature
> tests), components (message catalogs, docs, Qt4 & Qt5 runtime builds) and
> builds of pgAdmin (source, Python wheel) running on Linux and being tested
> against PG 9.3 - 10 and EPAS 9.4 - 10. I have had a (singular) successful
> feature test run, but most of the time they just time out at the moment.
>
> Once I have all the builds working as required for each platform, I intend
> to have them run regularly, and then setup smaller, targeted builds that
> will just produce the distribution packages on demand.
>
>>
>> Ask: what can we do to accelerate the release process? Can we help
>> automate builds or reduce the QA load or anything like that?
>>
>> Ideally we'd like to be releasing weekly, how can we move in that
>> direction?
>
>
> Right now we're still relying far too much on Fahar's manual testing for
> that to be a reality. He covers a lot of platform-specific tests on
> different distros with every release that often pickup showstoppers.

Makes perfect sense.

>
> I think the best way forward would be to continue with the Electron work so
> we can get away from using the browser in Desktop mode, and then once we
> have a stable and consistent desktop mode, continue to work on improving
> test coverage to minimise reliance on Fahar.

Electron is the next thing to get picked up by us.

Can you provide any insight into what Fahar does, one of the things
I've discussed is actually testing the installers after they have been
built. We didn't really have a plan for that so much so looking at
what was currently done could help generate some ideas.

-- Rob

>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM#3155] Allow user to lock the Layout

[Robert Eckhardt]

On Wed, Apr 4, 2018 at 11:31 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Wed, Apr 4, 2018 at 8:09 PM, Dave Page  wrote:
>
>>
>>
>> On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page  wrote:
>>>


 On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> On Wed, Apr 4, 2018 at 2:47 PM, Dave Page  wrote:
>
>>
>>
>> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Tue, Apr 3, 2018 at 9:03 PM, Dave Page  wrote:
>>>
 Hi

 On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Thanks Joao for reviewing.
>
> PFA updated patch.
>
> On Tue, Apr 3, 2018 at 1:11 AM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello,
>>
>> On Mon, Apr 2, 2018 at 10:07 AM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>>
>>> ​Hello,
>>>
>>> Please find updated patch,
>>>
>>> Now layout will be locked after user updates its preferences, w
>>> e have used ​
>>> templated variable in the javascript file
>>> ​ because we do not have preference module or preference cache
>>> available when the page loads and panels gets rendered,
>>> ​I
>>> ​ also
>>> made changes in JS tests as per Joao's review comments.
>>>
>> Looks like everything is working when we change the lock.
>> As a personal preferences I would prefer to see this in at least
>> 2 commits, one that is related to the preference issue and another 
>> one that
>> is related to this story.
>>
>>
>> All the tests are working, but he linter is failing:
>>
>> /tmp/build/4a5630c2/pivotal-rm-3155/web /tmp/build/4a5630c2
>>  
>> 
>> ./pgadmin/misc/__init__.py:78: [E303] too many blank lines (2)
>>  
>> 
>> 1   E303 too many blank lines (2)
>>  
>> 
>>
>> 1
>>
> ​Fixed​
>
>
>>
>>
>>> @Dave/Pivotal team,
>>> The given patch is working fine for all the Tabs/Panels (all the
>>> panels from main window as well as from Query tool and Debugger) 
>>> but I'm
>>> facing an issue while handling the Browser tree section, It is a 
>>> wcDocer
>>> frame  and
>>> not a wcDocker panel
>>> . Like
>>> wcDocker panel, wcDocker frame do not provide any API so that a 
>>> developer
>>> can prevent drag-drop functionality on it.
>>>
>>
 It's not working fine for me. For example, if I put the SQL Panel
 on it's own below the properties/stats panels (so it looks like 
 pgAdmin 3
 used to by default), and then lock the layout, I can un-dock the SQL 
 panel
 into a dialogue, but then cannot re-dock it. I can do weird things 
 with the
 browser tree as well, probably because it's a frame as you say.

>>>
>>> ​That is expected behaviour ​because once you drag the panel out of
>>> the group of Panels then it becomes individual Frame, That is what the
>>> author of the wcDocker replied on my question,
>>> *"A panel must either be initialized as movable or non-movable from
>>> the beginning and never changed because it generates a different
>>> arrangement of elements depending. This feature should only ever be used
>>> within the onCreate method of the panel. I should probably have been 
>>> more
>>> clear about this limitation in the documentation."*
>>>
>>>
>> So does it become a panel again if a second panel is added to the new
>> tab group?
>>
> ​No, it stays Frame.​
>
> As far as I understand Panel needs a Frame to render itself if it is
> not attached to the main docker instance.​
>
>>

Re: v3.0 release on hold

[Robert Eckhardt]

On Tue, Apr 3, 2018 at 11:04 AM, Dave Page <dp...@pgadmin.org> wrote:

> I'm thinking build Monday, release Thursday.
>
> Objections?
>

It we can make it happen faster I'd be all for it. If not that will work.
Thanks

-- Rob


>
>
> On Tue, Apr 3, 2018 at 2:43 PM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>
>> All,
>>
>> Where are we with respect to cutting this release?
>>
>> -- Rob
>>
>> On Mon, Mar 26, 2018 at 9:59 AM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hi Hackers,
>>>
>>> Did we had any progress on the things that are holding the release back?
>>>
>>> Thanks
>>> Joao
>>>
>>> On Fri, Mar 23, 2018 at 9:26 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
>>>> Hi Dave
>>>>
>>>> On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi <
>>>> akshay.jo...@enterprisedb.com> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, Mar 22, 2018 at 10:24 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Thu, Mar 22, 2018 at 1:13 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>>>
>>>>>>>
>>>>>>>>>>> 2) Starting a second instance of the app bundle on Mac doesn't
>>>>>>>>>>> always open a new pgAdmin window as it should. It works fine in the
>>>>>>>>>>> debugger, or if you start the app with a command like:
>>>>>>>>>>> "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It
>>>>>>>>>>> doesn't work if you double-click the appbundle or use a command 
>>>>>>>>>>> like "open
>>>>>>>>>>> /Applications/pgAdmin\ 4.app"
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>   Still working on this, not found any solution yet.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>  Not able to figure out the solution yet. I have tried to
>>>>>>>> debug the code, but every time it will create a new instance(tray 
>>>>>>>> icon). Do
>>>>>>>> I need to look into the code or something related to app bundle may be 
>>>>>>>> some
>>>>>>>> settings in info.plist or any other pointer?
>>>>>>>>
>>>>>>>
>>>>>>> Have a look at the code around line 85 an onwards of pgAdmin4.cpp.
>>>>>>> It creates the shared memory interlock (and log/address files) based on 
>>>>>>> the
>>>>>>> current username and a hash of the executable name/path. My suspicion is
>>>>>>> that the path hash (which is calculated from argv[0] on line 72) is for
>>>>>>> some reason getting a different value each time when launched via the
>>>>>>> Finder or "open", thus the interlock is failing.
>>>>>>>
>>>>>>
>>>>>> So I took a look at this, and it seems the code is just fine. What is
>>>>>> happening is that macOS only allows a single instance of an app to run at
>>>>>> once. Whilst that is what we want of course, macOS is causing the new
>>>>>> instance to exit before it has a change to open a new pgAdmin window. 
>>>>>> Using
>>>>>> "open -n ..." or calling the embedded executable directly resolves that
>>>>>> issue.
>>>>>>
>>>>>> So, there's another challenge to figure out... :-(
>>>>>>
>>>>>
>>>>> OK. Will try to figure that out.
>>>>>
>>>>
>>>> After googled I have tried following solution:
>>>>
>>>>1. Create a shell script "launch.sh" and kept it in  
>>>> "/Applications/pgAdmin\
>>>>4.app/Contents/MacOS" folder. That shell script will contain the command
>>>>"open -n /Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4".
>>>>Change the "CFBundleExecutable" parameter of Info.plist from "pgAdmin4" 
>>>> to
>>>>"launch.sh".  It didn't work, shall script didn't launch.
>>>>2. Create one apple script with command like "do shell execute 
>>>> "/Applications/pgAdmin\
>>>>4.app", compile it and save it as Application. It create the app bundle,
>>>>copy contents of pgAdmin4 app to this newly created application. But the
>>>>problem is it opens and having icon in the dock and no response on 
>>>> double
>>>>click (second time).
>>>>
>>>>Will continue to figure out some other solutions tomorrow.
>>>>
>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect *
>>>>>
>>>>>
>>>>>
>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect *
>>>>
>>>>
>>>>
>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: v3.0 release on hold

[Robert Eckhardt]

All,

Where are we with respect to cutting this release?

-- Rob

On Mon, Mar 26, 2018 at 9:59 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> Did we had any progress on the things that are holding the release back?
>
> Thanks
> Joao
>
> On Fri, Mar 23, 2018 at 9:26 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Mar 22, 2018 at 10:24 PM, Dave Page  wrote:
>>>
 Hi

 On Thu, Mar 22, 2018 at 1:13 PM, Dave Page  wrote:

>
> 2) Starting a second instance of the app bundle on Mac doesn't
> always open a new pgAdmin window as it should. It works fine in the
> debugger, or if you start the app with a command like:
> "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It
> doesn't work if you double-click the appbundle or use a command like 
> "open
> /Applications/pgAdmin\ 4.app"
>

   Still working on this, not found any solution yet.

>>>
>>  Not able to figure out the solution yet. I have tried to
>> debug the code, but every time it will create a new instance(tray icon). 
>> Do
>> I need to look into the code or something related to app bundle may be 
>> some
>> settings in info.plist or any other pointer?
>>
>
> Have a look at the code around line 85 an onwards of pgAdmin4.cpp. It
> creates the shared memory interlock (and log/address files) based on the
> current username and a hash of the executable name/path. My suspicion is
> that the path hash (which is calculated from argv[0] on line 72) is for
> some reason getting a different value each time when launched via the
> Finder or "open", thus the interlock is failing.
>

 So I took a look at this, and it seems the code is just fine. What is
 happening is that macOS only allows a single instance of an app to run at
 once. Whilst that is what we want of course, macOS is causing the new
 instance to exit before it has a change to open a new pgAdmin window. Using
 "open -n ..." or calling the embedded executable directly resolves that
 issue.

 So, there's another challenge to figure out... :-(

>>>
>>> OK. Will try to figure that out.
>>>
>>
>> After googled I have tried following solution:
>>
>>1. Create a shell script "launch.sh" and kept it in  
>> "/Applications/pgAdmin\
>>4.app/Contents/MacOS" folder. That shell script will contain the command
>>"open -n /Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4".
>>Change the "CFBundleExecutable" parameter of Info.plist from "pgAdmin4" to
>>"launch.sh".  It didn't work, shall script didn't launch.
>>2. Create one apple script with command like "do shell execute 
>> "/Applications/pgAdmin\
>>4.app", compile it and save it as Application. It create the app bundle,
>>copy contents of pgAdmin4 app to this newly created application. But the
>>problem is it opens and having icon in the dock and no response on double
>>click (second time).
>>
>>Will continue to figure out some other solutions tomorrow.
>>
>>>
 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>

Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

[Robert Eckhardt]

On Thu, Mar 29, 2018 at 12:45 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Thanks Akshay & Joao, got it.
>
> My bad sorry for the noise.
>

The question helped me, nothing wrong with questions.

-- Rob


>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Mar 29, 2018 at 9:06 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Murtuza,
>> Lets imagine you have
>>
>> CREATE TABLE cities (
>> city_id bigserial not null,
>> name text not null,
>> population   int
>> ) PARTITION BY LIST (initcap(name));
>>
>> CREATE TABLE cities_west
>> PARTITION OF cities (
>> CONSTRAINT city_id_nonzero CHECK (city_id != 0)
>> ) FOR VALUES IN ('Los Angeles', 'San Francisco') PARTITION BY RANGE 
>> (population);
>>
>> CREATE TABLE cities_west_1_to_10
>> PARTITION OF cities_west FOR VALUES FROM (1) TO (10);
>>
>> ​
>>
>> You can only create an index in *cities_west_1_to_10* because
>> postgresql assumes that *cities_west* is also a partitioned table. So
>> the implementation looks correct, despite the fact that there are no tests
>> around it.
>>
>> Thanks
>> Joao
>>
>> On Thu, Mar 29, 2018 at 9:26 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Murtuza
>>>
>>> On Thu, Mar 29, 2018 at 6:36 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 I have concerns regarding the fix, As you negate the condition, Before
 the fix it was not displaying Index node for Tables but after the fix it
 will not display it for Partition tables.
 But when I read the Postgres docs it say,
 *Partitions may themselves be defined as partitioned tables, using what
 is called sub-partitioning. Partitions may have their own indexes,
 constraints and default values, distinct from those of other partitions.
 Indexes must be created separately for each partition. See CREATE TABLE
  for more
 details on creating partitioned tables and partitions.*
 Ref: https://www.postgresql.org/docs/10/static/ddl-partitioning.html
 (Sec: 5.10.2)

>>>
>>> Yes that is correct, but it's about Partitions(child tables), not
>>> the *Partitioned* table. We are showing indexes on Partitions. Please refer
>>> "Index_on_Partitioned_table.png"
>>>



 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 On Thu, Mar 29, 2018 at 6:05 PM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch to fix RM #3180 Index node is missing
> from the tree view of the table node. This is a regression of one of the
> older commit.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
> 976-788-8246 <+91%2097678%2088246>*
>


>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

[Robert Eckhardt]

On Wed, Mar 28, 2018 at 11:20 AM, Dave Page <dp...@pgadmin.org> wrote:

>
>
> On Wed, Mar 28, 2018 at 2:54 PM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>
>>
>>
>> On Wed, Mar 28, 2018 at 4:12 AM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>>
>>>
>>> On Wed, Mar 28, 2018 at 1:37 AM, Robert Eckhardt <reckha...@pivotal.io>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala <
>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt <reckha...@pivotal.io
>>>>> > wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala <
>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>>
>>>>>>> On Tue, Mar 27, 2018 at 3:13 PM, Dave Page <dp...@pgadmin.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt <
>>>>>>>> reckha...@pivotal.io> wrote:
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
>>>>>>>>> jdealmeidapere...@pivotal.io> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Hackers,
>>>>>>>>>>
>>>>>>>>>> @Murtuza: The patch codewise looks good. Nice to see that we are
>>>>>>>>>> using axios instead of jquery ajax calls and that there is some 
>>>>>>>>>> coverage
>>>>>>>>>> for the change.
>>>>>>>>>> Nevertheless the Javascript testing looks a bit slim and could be
>>>>>>>>>> improved. Also the DataSorting class could have some other member 
>>>>>>>>>> functions
>>>>>>>>>> like the model validation could be extracted out so that it is easily
>>>>>>>>>> tested.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> @Hackers: This was how we tried to test this feature:
>>>>>>>>>> 1 - Started pgAdmin
>>>>>>>>>> 2 - Opened the query tool for a specific server
>>>>>>>>>> 3 - Executed a SQL statment
>>>>>>>>>> 4 - Pressed the column header to try to order, nothing happened
>>>>>>>>>> 5 - Right clicked the column header to see if it was there the
>>>>>>>>>> option, nothing
>>>>>>>>>>
>>>>>>>>>> This is the behavior that we were expecting, not to have to open
>>>>>>>>>> Data View and then press the icon that is not even near the grid in 
>>>>>>>>>> order
>>>>>>>>>> to sort the column. Is this really the way we want people to use the 
>>>>>>>>>> grid
>>>>>>>>>> in pgAdmin? Should it be more intuitive?
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Have we considered making the grid behave more like excel or other
>>>>>>>>> grids? I think that having the ascending and descending inside the 
>>>>>>>>> column
>>>>>>>>> header, we could similarly provide filtering. Something that would 
>>>>>>>>> give
>>>>>>>>> users a more intuitive place to look.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Doing the sorting via header clicks is convenient but very
>>>>>>>> restrictive. How do you specify multiple columns to sort by for 
>>>>>>>> example?
>>>>>>>> The current design allows you to select columns and the sort order as 
>>>>>>>> you
>>>>>>>> see fit.
>>>>>>>>
>>>>>>>
>>>>>> Honestly I'm not sold on my idea, I was just proposing an alternat

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

[Robert Eckhardt]

On Wed, Mar 28, 2018 at 4:12 AM, Dave Page <dp...@pgadmin.org> wrote:

>
>
> On Wed, Mar 28, 2018 at 1:37 AM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>
>>
>>
>> On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt <reckha...@pivotal.io>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala <
>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>
>>>>> On Tue, Mar 27, 2018 at 3:13 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt <
>>>>>> reckha...@pivotal.io> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
>>>>>>> jdealmeidapere...@pivotal.io> wrote:
>>>>>>>
>>>>>>>> Hi Hackers,
>>>>>>>>
>>>>>>>> @Murtuza: The patch codewise looks good. Nice to see that we are
>>>>>>>> using axios instead of jquery ajax calls and that there is some 
>>>>>>>> coverage
>>>>>>>> for the change.
>>>>>>>> Nevertheless the Javascript testing looks a bit slim and could be
>>>>>>>> improved. Also the DataSorting class could have some other member 
>>>>>>>> functions
>>>>>>>> like the model validation could be extracted out so that it is easily
>>>>>>>> tested.
>>>>>>>>
>>>>>>>>
>>>>>>>> @Hackers: This was how we tried to test this feature:
>>>>>>>> 1 - Started pgAdmin
>>>>>>>> 2 - Opened the query tool for a specific server
>>>>>>>> 3 - Executed a SQL statment
>>>>>>>> 4 - Pressed the column header to try to order, nothing happened
>>>>>>>> 5 - Right clicked the column header to see if it was there the
>>>>>>>> option, nothing
>>>>>>>>
>>>>>>>> This is the behavior that we were expecting, not to have to open
>>>>>>>> Data View and then press the icon that is not even near the grid in 
>>>>>>>> order
>>>>>>>> to sort the column. Is this really the way we want people to use the 
>>>>>>>> grid
>>>>>>>> in pgAdmin? Should it be more intuitive?
>>>>>>>>
>>>>>>>
>>>>>>> Have we considered making the grid behave more like excel or other
>>>>>>> grids? I think that having the ascending and descending inside the 
>>>>>>> column
>>>>>>> header, we could similarly provide filtering. Something that would give
>>>>>>> users a more intuitive place to look.
>>>>>>>
>>>>>>
>>>>>> Doing the sorting via header clicks is convenient but very
>>>>>> restrictive. How do you specify multiple columns to sort by for example?
>>>>>> The current design allows you to select columns and the sort order as you
>>>>>> see fit.
>>>>>>
>>>>>
>>>> Honestly I'm not sold on my idea, I was just proposing an alternative
>>>> in an effort to start a discussion about the user experience. Ideally what
>>>> I'd like to see, maybe this happened, is some user research. When we
>>>> initial worked on refactoring the results grid we made a bunch of changes.
>>>> One of the things we intended to do was to follow up to see how people were
>>>> using the grid now so that we could better understand how it was now being
>>>> used in order to design and implement features just like this. Clearly we
>>>> haven't gotten there yet.
>>>>
>>>>
>>>>>
>>>>> Another reason we can't use that because w
>>>>> e have already occupied that behaviour for selecting entire column
>>>>> ​ when user clicks on header.
>>>>> As Dave suggested, I will be merging it with filter dialog meaning it
>>>>> wil

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

[Robert Eckhardt]

On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala <murtuza.zabuawala@
enterprisedb.com> wrote:

>
>
> On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>
>>
>>
>> On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> On Tue, Mar 27, 2018 at 3:13 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt <reckha...@pivotal.io>
>>>> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
>>>>> jdealmeidapere...@pivotal.io> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> @Murtuza: The patch codewise looks good. Nice to see that we are
>>>>>> using axios instead of jquery ajax calls and that there is some coverage
>>>>>> for the change.
>>>>>> Nevertheless the Javascript testing looks a bit slim and could be
>>>>>> improved. Also the DataSorting class could have some other member 
>>>>>> functions
>>>>>> like the model validation could be extracted out so that it is easily
>>>>>> tested.
>>>>>>
>>>>>>
>>>>>> @Hackers: This was how we tried to test this feature:
>>>>>> 1 - Started pgAdmin
>>>>>> 2 - Opened the query tool for a specific server
>>>>>> 3 - Executed a SQL statment
>>>>>> 4 - Pressed the column header to try to order, nothing happened
>>>>>> 5 - Right clicked the column header to see if it was there the
>>>>>> option, nothing
>>>>>>
>>>>>> This is the behavior that we were expecting, not to have to open Data
>>>>>> View and then press the icon that is not even near the grid in order to
>>>>>> sort the column. Is this really the way we want people to use the grid in
>>>>>> pgAdmin? Should it be more intuitive?
>>>>>>
>>>>>
>>>>> Have we considered making the grid behave more like excel or other
>>>>> grids? I think that having the ascending and descending inside the column
>>>>> header, we could similarly provide filtering. Something that would give
>>>>> users a more intuitive place to look.
>>>>>
>>>>
>>>> Doing the sorting via header clicks is convenient but very restrictive.
>>>> How do you specify multiple columns to sort by for example? The current
>>>> design allows you to select columns and the sort order as you see fit.
>>>>
>>>
>> Honestly I'm not sold on my idea, I was just proposing an alternative in
>> an effort to start a discussion about the user experience. Ideally what I'd
>> like to see, maybe this happened, is some user research. When we initial
>> worked on refactoring the results grid we made a bunch of changes. One of
>> the things we intended to do was to follow up to see how people were using
>> the grid now so that we could better understand how it was now being used
>> in order to design and implement features just like this. Clearly we
>> haven't gotten there yet.
>>
>>
>>>
>>> Another reason we can't use that because w
>>> e have already occupied that behaviour for selecting entire column
>>> ​ when user clicks on header.
>>> As Dave suggested, I will be merging it with filter dialog meaning it
>>> will be accessible via direct button on toolbar & keyboard shortcut.​
>>> ​
>>>
>>
>> How are users currently interacting with that filter dialog?
>>
>
> ​By clicking on the toolbar button as well as keyboard shortcut.
> ​
>
>
>
>

Sorry I wasn't clear. My question was more along the lines of, do we know
if people are using the filter functionality?  What kind of filters are
people using?  What do they like about it? What do they wish they could do
above and beyond sorting, etc.

-- Rob


>
>> What I'm suggesting is that we understand how users want to interact with
>> their results, be those the results of a query or a table view, then we can
>> design something that meets those needs. I agree that changing the column
>> selection behavior isn't desirable, however, I also feel like providing the
>> best user experience is better than holding onto a particular feature
>> implementation.
>> ​
>>
>>
>
>> -- Rob
>>
>>
>>>
>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

[Robert Eckhardt]

On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> On Tue, Mar 27, 2018 at 3:13 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>>
>>
>> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt <reckha...@pivotal.io>
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> @Murtuza: The patch codewise looks good. Nice to see that we are using
>>>> axios instead of jquery ajax calls and that there is some coverage for the
>>>> change.
>>>> Nevertheless the Javascript testing looks a bit slim and could be
>>>> improved. Also the DataSorting class could have some other member functions
>>>> like the model validation could be extracted out so that it is easily
>>>> tested.
>>>>
>>>>
>>>> @Hackers: This was how we tried to test this feature:
>>>> 1 - Started pgAdmin
>>>> 2 - Opened the query tool for a specific server
>>>> 3 - Executed a SQL statment
>>>> 4 - Pressed the column header to try to order, nothing happened
>>>> 5 - Right clicked the column header to see if it was there the option,
>>>> nothing
>>>>
>>>> This is the behavior that we were expecting, not to have to open Data
>>>> View and then press the icon that is not even near the grid in order to
>>>> sort the column. Is this really the way we want people to use the grid in
>>>> pgAdmin? Should it be more intuitive?
>>>>
>>>
>>> Have we considered making the grid behave more like excel or other
>>> grids? I think that having the ascending and descending inside the column
>>> header, we could similarly provide filtering. Something that would give
>>> users a more intuitive place to look.
>>>
>>
>> Doing the sorting via header clicks is convenient but very restrictive.
>> How do you specify multiple columns to sort by for example? The current
>> design allows you to select columns and the sort order as you see fit.
>>
>
Honestly I'm not sold on my idea, I was just proposing an alternative in an
effort to start a discussion about the user experience. Ideally what I'd
like to see, maybe this happened, is some user research. When we initial
worked on refactoring the results grid we made a bunch of changes. One of
the things we intended to do was to follow up to see how people were using
the grid now so that we could better understand how it was now being used
in order to design and implement features just like this. Clearly we
haven't gotten there yet.


>
> Another reason we can't use that because w
> e have already occupied that behaviour for selecting entire column
> ​ when user clicks on header.
> As Dave suggested, I will be merging it with filter dialog meaning it will
> be accessible via direct button on toolbar & keyboard shortcut.​
> ​
>

How are users currently interacting with that filter dialog?

What I'm suggesting is that we understand how users want to interact with
their results, be those the results of a query or a table view, then we can
design something that meets those needs. I agree that changing the column
selection behavior isn't desirable, however, I also feel like providing the
best user experience is better than holding onto a particular feature
implementation.

-- Rob


>
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode

[Robert Eckhardt]

On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> @Murtuza: The patch codewise looks good. Nice to see that we are using
> axios instead of jquery ajax calls and that there is some coverage for the
> change.
> Nevertheless the Javascript testing looks a bit slim and could be
> improved. Also the DataSorting class could have some other member functions
> like the model validation could be extracted out so that it is easily
> tested.
>
>
> @Hackers: This was how we tried to test this feature:
> 1 - Started pgAdmin
> 2 - Opened the query tool for a specific server
> 3 - Executed a SQL statment
> 4 - Pressed the column header to try to order, nothing happened
> 5 - Right clicked the column header to see if it was there the option,
> nothing
>
> This is the behavior that we were expecting, not to have to open Data View
> and then press the icon that is not even near the grid in order to sort the
> column. Is this really the way we want people to use the grid in pgAdmin?
> Should it be more intuitive?
>

Have we considered making the grid behave more like excel or other grids? I
think that having the ascending and descending inside the column header, we
could similarly provide filtering. Something that would give users a more
intuitive place to look.

-- Rob


>
>
> PS: Also that Orange after the selection is like a push in the eyes and
> not in a good way. Maybe we should think about changing the color of the
> icon to blue to match the rest of the website or something.
>
> Thanks
> Victoria & Joao
>
> On Mon, Mar 26, 2018 at 12:13 PM Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> On Mon, Mar 26, 2018 at 5:52 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala >> enterprisedb.com> wrote:
>>>
 Hi,

 PFA patch which allow user to sort the data in View data mode.

>>>
>>> The patch looks good in general, however I'm not sure about the UI, in
>>> particular that the closely-linked dialogue for filtering is a completely
>>> different design. I think it would be better to combine the Sort/Filter
>>> options and use a single dialogue for both, as pgAdmin 3 did (though, maybe
>>> not using separate tabs for each part, but the top and bottom of the same
>>> dialogue.
>>>
>>> That would certainly fix the consistency of the dialogues (obviously, as
>>> there would only be one!), and I think would perhaps be a more simple
>>> overall UI, particularly for those that want to sort and filter.
>>>
>> ​Sure, I'll send updated it accordingly.​
>>
>>
>>>
>>> Thoughts?
>>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>

Re: Showstopper desktop runtime issue

[Robert Eckhardt]

On Thu, Mar 22, 2018 at 12:28 PM, Dave Page  wrote:

> Hi
>
> On Thu, Mar 22, 2018 at 4:17 PM, Magnus Hagander 
> wrote:
>
>>
>>
>> On Thu, Mar 22, 2018 at 3:57 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello Hackers,
>>> Here is our take on the 3 options present:
>>>
>>
>> This looks like a good summary, so I'm going to pick this one to comment
>> on :)
>>
>
> :-)
>
>
>>
>>
>>
>>
>>> 1) QtWebkit and QtWebEngine
>>>
>>
>>> Pros:
>>> - Webkit is a mature technology that as been around for some time
>>> - Apparently the Fork of Webkit we were using as been catching up
>>> Cons:
>>> - We are using a Fork
>>> - It is to far behind of the today browsers and the competition keep
>>> evolving making it even harder for them to catch up
>>> - Problems with the environment from the past, lagginess, lack of support
>>>
>>>
>> Yeah, this one hasn't exactly caused a "little" set of complaints so far.
>> It might be workable for absolute stop-gap, but not beyond that.
>>
>
> Right.
>
>
>>
>>
>>
>>> 2) Rework runtime to find a running PGAdmin and attach to it
>>>
>>> Pros:
>>> - We already made the big move from Webkit to this version
>>> - Add smarts to the application to do not run itself if it is already
>>> running, or kill the currently running application
>>>
>>> Cons:
>>> - More C++ code thrown around
>>> - Add more dependency on our QT application
>>> - Have specific code for Gnome, not even a OS version but a window
>>> manager
>>>
>>
>>
>> Annoying as it is, I think this is the least bad option at this point.
>>
>>
>> 3) Electron
>>>
>>> Pros:
>>> - Full Javascript runtime, no more C++ code to handle
>>> - Self packaging for all the environments
>>> Cons:
>>> - No fully supported on Linux based OS with old libstdc++, (This might
>>> solve the problem: https://github.com/mattermost/desktop/issues/312)
>>>
>>
>>
>> Losing support for things like RHEL6 would make it completely unworkable
>> for several of my largest customers. Particularly in large enterprise
>> organisations, this would be a very substantial issue.
>>
>
> That's good to know. There are clunky workarounds (shipping different
> libcs for example, but that potentially adds licensing issues).
>
> Sidenote: It would only be an issue for desktop mode. Web mode should not
> be affected.
>
>
>>
>>
>>
>>> - CPU/RAM high utilization (Found a issues around and the majority of
>>> them have solutions like CSS animations running or settings on the created
>>> windows)
>>>
>>
>> This does sound bad. But do we actually know if this is worse in Electron
>> than it is in the option #2? I mean sure, we point to things like Slack,
>> but that may not be because of electron, it may be because the app running
>> inside it?
>>
>
> We don't know for sure, but we do know that Chrome in general is a bit of
> a hog. It's certainly not a stretch to think a combination of those things
> are why people (correctly) see browser based apps as being more resource
> hungry.
>

I honestly think this is a fair criticism. I like electron and wish it
weren't.


>
>
>>
>>
>>
>>> - Electron does not support tabs by default, only HTML tabs
>>>
>>
>> I think that also makes it a showstopper. This was another one of the
>> main complaints I have personally heard from people going from pgadmin3 ->
>> pgadmin4, and enough to make people not want to use it at all. It would be
>> really bad to go back to that.
>>
>
> To clarify; it would mean no tabs, but not single window. That was already
> working in the PoC. In other words, helpfiles, the debugger and query tools
> could all be opened in new windows, just not tabs on the same window that
> could be docked and un-docked.
>
> I suspect for most people that would be enough.
>

Agreed, I also think that adding tabs is a doable feature it just isn't an
'out of the box' thing.


>
>
>>
>>
>>
>> After combing through these options with some pros and cons  here are my
>>> thoughts:
>>> 1) This options was always cluncky from the beginning, the fact that we
>>> are working with a browser that is currently 26k commits behind
>>> Webkit:master is concerning. So I do not believe this is a viable option.
>>> As a personal opinion is we need to release fast, then we should go with
>>> what we have now and not go back to this option.
>>>
>>
>> Yeah, that option definitely has no future long-term.
>>
>>
>>
>>> 2) This option is not very appealing to me, because we would be pilling
>>> code into the QT portion of the application, that I hope we remove in the
>>> future, that currently is untested to solve a problem caused by a Window
>>> Manager..
>>> I would be more in favor of creating a Application Indicator that would
>>> support 2 actions, Kill running pgAdmins and launch the browser to access
>>> them. There is a lot of interesting websites that talk about this, and how
>>> to develop. I had to download one to have a docker indicator. But as I
>>> said in a previous 

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

[Robert Eckhardt]

Thanks for doing this, sorry about the breakage.

We're taking a look at this to make sure it is still working with
Greenplum.

-- Rob

On Tue, Mar 20, 2018 at 9:12 AM, Akshay Joshi  wrote:

> Hi Hackers
>
> Attached is the patch file to fix the RM #2815.
>
> On Tue, Mar 20, 2018 at 3:24 PM, Dave Page 
> wrote:
>
>>
>>
>> On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Tue, Mar 20, 2018 at 3:06 PM, Dave Page 
>>> wrote:
>>>
 I'm a little concerned that noone mentioned this earlier; I'm supposed
 to be building the release this afternoon, and I expect this change to at
 the very least be complex to fully test and verify. What's the ETA on the
 patch? What steps are being taken to ensure it's correct and doesn't cause
 regressions?

>>>
>>> Harshal has already mentioned in the RM. Currently I am changing
>>> the logic, but it may take time to complete, fully test and verify. I'll
>>> try my best to do it asap.
>>>
>>
>> Sure, but how many of us are watching every comment on every RM? I know
>> I'm not (I currently average ~400 emails/day).
>>
>>
>>>
 On Tue, Mar 20, 2018 at 7:51 AM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Joao
>
> It seems that this fix broke the functionality of RM #2815. It is
> mentioned in the RM what needs to be fixed now and I am currently working
> on it.
> While fixing the issue following problem that I found
>
>- In "start_running_query.py" file, we need to remove check "if
>conn.connected()" from "__execute_query" function as we required
>exception to be thrown while executing the query to identify the
>ConnectionLost.
>- In "execute_query.js" we have used *axios* to execute the query
>and in case of exception, object is different then normal javascript
>response object.
>- We call following functions when exception or error comes and
>send the "*.response.data*" as parameter
>   - wasConnectionLostToServer(): Check for the readyState
>   parameter, which is not the part of ".response.data".
>   - extractErrorMessage(): Check for the "responseJSON" and "
>   responseJSON.info", which is not the part of
>   ".response.data".
>   - is_pga_login_required(): Check for the "responseJSON" and "
>   responseJSON.info", which is not the part of
>   ".response.data".
>   - is_new_transaction_required(): Check for the "responseJSON"
>   and "responseJSON.info", which is not the part of
>   ".response.data".
>
> From the above list, some of the function calls are generic where they
> need "responseJSON" and "responseJSON.info", so we can't change that.
> Possible solution could be pass one extra flag as parameter to identify 
> the
> object is a axios response or javascript response to above functions
> and change the logic accordingly.
>
> Please let me know your thoughts or any other suggestion.
>
>
> On Fri, Feb 9, 2018 at 8:17 PM, Dave Page  wrote:
>
>> Thanks, applied.
>>
>> On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hello,
>>> Attached you can find the fix for the current pronlem
>>>
>>>
>>> On Fri, Feb 9, 2018 at 7:29 AM Dave Page  wrote:
>>>
 Hi Joao,

 It looks like Jenkins has taken umbrage to this change, at least
 with Python 3.x. Can you take a look please?

 https://jenkins.pgadmin.org/

 Thanks.

 On Fri, Feb 9, 2018 at 11:54 AM, Dave Page 
 wrote:

> Thanks, patches applied.
>
> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Hackers,
>> This is quite a big patch in order to solve the problem with the
>> Explain Plan.
>>
>> We sent 2 patches that have the following:
>> *- update-javascript-packages.diff *
>> Add package:
>>  is-docker to select a specific setting when running the
>> Chrome tests in
>>  Docker
>>
>> Upgrade the version of:
>> - babel-loader
>> - extract-text-webpack-plugin
>> - jasmine-core
>> - jasmine-enzyme
>> - moment
>> *- explain-plan-greenplum.diff*
>>   Extract SQLEditor.execute and SQLEditor._poll into their own
>> files and add test around them
>>   Extract SQLEditor backend functions that start executing query
>> to their own files and add tests around 

ACI Tree

[Robert Eckhardt]

Hackers,

We have multiple end users who have in excess of 10 thousand of tables in a
single schema. Currently this causes pgAdmin to choke.

The major issue we are seeing is that the ACI tree is unsupported and it
seems to be the backbone of pgAdmin 4.

Is anyone else having this issue?  Is there a solution better that (for
some definition of better than) replacing the ACI Tree with something more
performant?

-- Rob

Next release

[Robert Eckhardt]

Apologies if this has been discussed and I missed it.

When is the 3.0 release planned?

-- Rob

Re: Revamped runtime vs. Version number

[Robert Eckhardt]

On Thu, Feb 1, 2018 at 9:45 AM, Dave Page  wrote:

> So there's been nothing but positive feedback about the PoC revamped
> runtime I asked folks on the lists to test. Thank you to everyone that did
> so.
>
> With that in mind, I think we should use that in the next version and
> moving forwards, and bump the version number to 3.0 for the next release.
> Does anyone object to that plan?
>

+1

Is there anything that needs to be done to move this from PoC code we can
help with?

-- Rob


>
> FYI, since the original PoC, I've made the following additional changes:
>
> - Move to using a shared memory interlock to ensure only a single instance
> (per user, per copy of the executable) is run. This means if you have
> multiple copies of pgAdmin installed, they won't interact with each other,
> but a single copy is limited to a single instance per user.
>
> - Add a log viewer. If startup fails (or other errors occur), the Python
> logs can now easily be viewed in the runtime.
>
> - Tidied up the configuration dialogue.
>
> - Added a config option to allow an alternate command to be run rather
> than executing the default browser. This allows any browser to be
> configured, using different profiles etc, as possible when launching on the
> command line.
>
> - Made startup more robust so config options can be corrected without
> restarts if needed, and failures can be detected much more quickly.
>
> - Cleaned up a bunch of redundant code.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Robert Eckhardt]

Given that Greenplum is going to GA next month can we get that stable OSS
version included in the CI?

Rob

On Aug 25, 2017 8:27 AM, "Akshay Joshi" 
wrote:

> Thanks patch applied. I haven't tested it on GPDB.
>
> On Fri, Aug 25, 2017 at 4:55 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Fri, Aug 25, 2017 at 4:53 PM, Dave Cramer 
>> wrote:
>>
>>> I'm suggesting that it be pushed
>>>
>> Akshay is already on to it, and currently reviewing it.
>> Will push it once get the confirmation.
>>
>> -- Thanks, Ashesh
>>
>>>
>>> Dave Cramer
>>>
>>> On 24 August 2017 at 23:00, Teng Zhang  wrote:
>>>
 Sure, you can get as much as you like.
 Thanks

 -- Forwarded message --
 From: Dave Cramer 
 Date: Thu, Aug 24, 2017 at 8:34 PM
 Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard
 display
 To: Teng Zhang 
 Cc: Ashesh Vashi , pgadmin-hackers <
 pgadmin-hack...@postgresql.org>, Dave Page , Jing
 Li 


 Can we get some movement on this patch? This seems like a more sane way
 to go to support different "products"

 Dave Cramer

 On 22 August 2017 at 16:56, Dave Cramer  wrote:

>
> On 22 August 2017 at 16:41, Dave Cramer  wrote:
>
>> Ok,
>>
>> Surely this :
>>
>> self.table_template_path = 'table/sql/' + (
>> +'#{0}#{1}#'.format(server_type, ver)
>> +if server_type == 'gpdb' else
>> +'#{0}#'.format(ver)
>> +)
>>
>> could be written in a more readable manner ??
>>
>>
>>
> Apologies, after reading a bit, this is apparently idiomatic python.
>
> Please ignore
>
>
>> Dave Cramer
>>
>> On 22 August 2017 at 14:25, Dave Cramer  wrote:
>>
>>> Hi,
>>>
>>> I've been able to get back to this and test it. So far so good. It
>>> applies more or less cleanly against 1.6 and everything I've tried so 
>>> far
>>> works
>>>
>>> I'll update more as I test it.
>>>
>>> Thanks
>>>
>>> Dave Cramer
>>>
>>> On 21 August 2017 at 05:29, Teng Zhang  wrote:
>>>
 Hi,

 Thanks for the review, here is a fixed patch working for GBDP which
 shows the appropriate graphs.
 In this fix, we toke out the changes to diver/psycopg2 and
 implemented the greenplum version checking process in the ppas way
 mentioned by Dave Cramer.

 Regards,
 Teng Zhang & Hao Wang

 On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page 
> wrote:
>
>> Ashesh, do you have a recommended way to do this?
>>
>> I haven't looked at the patch, but I assume it adds a database
>> driver module for GPDB?
>>
> I have not looked at the patch yet.
> I will take a look at it.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li 
>> wrote:
>>
>>> Hi Dave,
>>>
>>> Since we're hoping to get this change working for GPDB we've
>>> currently using this method to detect if it's gpdb and show the 
>>> appropriate
>>> graphs. Right now it displays errors on the dashboard if it's 
>>> connected to
>>> a gpdb server.
>>> For this patch specifically, the goal is to improve the
>>> experience for greenplum users so they can get the same information 
>>> as
>>> someone connected to a postgres server.
>>>
>>> I do agree that this is a bigger discussion about how we handle
>>> behavior change overall if it's regular postgres or something else. 
>>> Let's
>>> talk about how we can restructure this behavior in a wider context. 
>>> Are you
>>> open to meeting about it?
>>>
>>> Thanks,
>>> ~Jing
>>>
>>>
>>>
>>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com
>>> wrote:
>>>
 Hi Violet.

 I don't really like the way this has been implemented. It adds
 a variable which 

Re: Selecting tables from Browser

[Robert Eckhardt]

On Mon, Aug 21, 2017 at 7:17 PM, Shirley Wang <sw...@pivotal.io> wrote:

> Hi Rob
> On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>
>> Shirley,
>>
>> I have a few questions.
>>
>>1. Why 20. It is a dunbar number and seems smallish but is there
>>another reason?
>>
>> The browser fits about 30 ish items right now on my smallish laptop
> screen. The question we asked ourselves is 'what is the most content we can
> show before the browser gets unwieldy?'
>
> You have thoughts on this?
>

No thought better than 20. I was thinking a few hand full or a large enough
number to cause performance issues.


>
>
>>
>>1. Since this is referred to as an Object Manager I assume the same
>>thing will eventually be available for databases, schema, partitions, etc.
>>How do permissions work currently to limit m view of these objects? (or do
>>they)
>>
>>
> Good point about the name implying further reach than just tables. We're
> going to change the dialog header to show 'Select tables for display', at
> least until we decide we want to include databases, schema, partitions.
>
> I'm not sure how permissions works to limit the view, our assumption is
> that permissions does though.
>
> Dave P do you have more insight on what permissions can limit?
>
>>
>>1. Do you think that this would look differently if you assumptions
>>were based on a user who writes BI reports or some other non-DBA user?
>>
>> Potentially, as you mentioned off the email thread, a DBA would be
> interested in a larger list of tables than someone who writes BI reports.
>
> That said, since this is a problem we hear from DBAs, and they feel the
> most pain around this, I think it's fine to focus on solving the problem
> for them. Solving their pains will also address the pains of people who
> write BI reports since they also feel the same issues at a lesser intensity
>
> We will be testing with non-DBA users though too.
>

I'm mostly curious about this because I only really know how I interacted
with a DB in both roles.

-- Rob


>
>
>>
>>

Re: pgAdmin 4 commit: Fix test assertion.

[Robert Eckhardt]

There has been local passing and failing on our CI.

Rob

On Jul 31, 2017 8:47 PM, "Harshal Dhumal" <harshal.dhu...@enterprisedb.com>
wrote:

Well I'm able run all feature test cases on python 2.7 with latest pull.


-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 31, 2017 at 5:43 PM, Robert Eckhardt <reckha...@pivotal.io>
wrote:

> It fails because the test was broken and has never been fixed.
>
> Rob
>
> On Jul 31, 2017 8:03 PM, "Murtuza Zabuawala" <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Robert,
>>
>> I have the latest pull and still this test is fails every time on my
>> machine, not sure if it is because of Python3.6.
>>
>> On Mon, Jul 31, 2017 at 5:27 PM, Robert Eckhardt <reckha...@pivotal.io>
>> wrote:
>>
>>> This was broken when the clear button and the edit button were changed
>>> to drop downs.  Happened a few weeks ago.
>>>
>>> Rob
>>>
>>> On Jul 31, 2017 6:51 PM, "Murtuza Zabuawala" <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
>>> Hi All,
>>>
>>> When I run the feature tests, the gives test always fails (
>>> 'query_tool_journey_test.py'),
>>>
>>> Python: 3.6 (64-bit)
>>> Platform: OS X (10.10.5)
>>>
>>> Am I the only one who gets this error?
>>>
>>>
>>> ==
>>> ERROR: runTest (pgadmin.feature_tests.query_t
>>> ool_journey_test.QueryToolJourneyTest)
>>> Tests the path through the query tool
>>> --
>>> Traceback (most recent call last):
>>>   File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_
>>> tests/query_tool_journey_test.py", line 46, in runTest
>>> self._test_history_tab()
>>>   File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_
>>> tests/query_tool_journey_test.py", line 104, in _test_history_tab
>>> query_we_need_to_scroll_to
>>>   File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_
>>> tests/query_tool_journey_test.py", line 141, in
>>> _assert_not_clickable_because_out_of_view
>>> self.assertRaises(self.page.click_element(element))
>>>   File 
>>> "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py",
>>> line 728, in assertRaises
>>> return context.handle('assertRaises', args, kwargs)
>>>   File 
>>> "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py",
>>> line 158, in handle
>>> (name, self._base_type_str))
>>> TypeError: assertRaises() arg 1 must be an exception type or tuple of
>>> exception types
>>>
>>> --
>>> Ran 10 tests in 359.301s
>>>
>>> FAILED (errors=1, skipped=1)
>>>
>>> ==
>>> Test Result Summary
>>> ==
>>>
>>> PG_95:
>>>
>>> 8 tests passed
>>> 1 test failed:
>>> QueryToolJourneyTest (Tests the path through the query tool)
>>> 1 test skipped:
>>> CheckDebuggerForXssFeatureTest (Tests to check if Debugger is vulnerable
>>> to XSS)
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, Jul 21, 2017 at 8:46 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>
>>>> Fix test assertion.
>>>>
>>>> Branch
>>>> --
>>>> master
>>>>
>>>> Details
>>>> ---
>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>>> f;h=2ebb40819534d79376a577a149a8a5db124b
>>>> Author: Sarah McAlear <smcal...@pivotal.io>
>>>>
>>>> Modified Files
>>>> --
>>>> web/pgadmin/feature_tests/query_tool_journey_test.py | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>>
>>>
>>>
>>

Re: pgAdmin 4 commit: Fix test assertion.

[Robert Eckhardt]

It fails because the test was broken and has never been fixed.

Rob

On Jul 31, 2017 8:03 PM, "Murtuza Zabuawala" <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Robert,
>
> I have the latest pull and still this test is fails every time on my
> machine, not sure if it is because of Python3.6.
>
> On Mon, Jul 31, 2017 at 5:27 PM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>
>> This was broken when the clear button and the edit button were changed to
>> drop downs.  Happened a few weeks ago.
>>
>> Rob
>>
>> On Jul 31, 2017 6:51 PM, "Murtuza Zabuawala" <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>> Hi All,
>>
>> When I run the feature tests, the gives test always fails (
>> 'query_tool_journey_test.py'),
>>
>> Python: 3.6 (64-bit)
>> Platform: OS X (10.10.5)
>>
>> Am I the only one who gets this error?
>>
>>
>> ==
>> ERROR: runTest (pgadmin.feature_tests.query_t
>> ool_journey_test.QueryToolJourneyTest)
>> Tests the path through the query tool
>> --
>> Traceback (most recent call last):
>>   File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_
>> tests/query_tool_journey_test.py", line 46, in runTest
>> self._test_history_tab()
>>   File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_
>> tests/query_tool_journey_test.py", line 104, in _test_history_tab
>> query_we_need_to_scroll_to
>>   File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/feature_
>> tests/query_tool_journey_test.py", line 141, in
>> _assert_not_clickable_because_out_of_view
>> self.assertRaises(self.page.click_element(element))
>>   File 
>> "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py",
>> line 728, in assertRaises
>> return context.handle('assertRaises', args, kwargs)
>>   File 
>> "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py",
>> line 158, in handle
>> (name, self._base_type_str))
>> TypeError: assertRaises() arg 1 must be an exception type or tuple of
>> exception types
>>
>> --
>> Ran 10 tests in 359.301s
>>
>> FAILED (errors=1, skipped=1)
>>
>> ==
>> Test Result Summary
>> ==
>>
>> PG_95:
>>
>> 8 tests passed
>> 1 test failed:
>> QueryToolJourneyTest (Tests the path through the query tool)
>> 1 test skipped:
>> CheckDebuggerForXssFeatureTest (Tests to check if Debugger is vulnerable
>> to XSS)
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Jul 21, 2017 at 8:46 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>> Fix test assertion.
>>>
>>> Branch
>>> --
>>> master
>>>
>>> Details
>>> ---
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=2ebb40819534d79376a577a149a8a5db124b
>>> Author: Sarah McAlear <smcal...@pivotal.io>
>>>
>>> Modified Files
>>> --
>>> web/pgadmin/feature_tests/query_tool_journey_test.py | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>
>>
>>
>

Re: pgAdmin 4 commit: Fix test assertion.

[Robert Eckhardt]

This was broken when the clear button and the edit button were changed to
drop downs.  Happened a few weeks ago.

Rob

On Jul 31, 2017 6:51 PM, "Murtuza Zabuawala" <
murtuza.zabuaw...@enterprisedb.com> wrote:

Hi All,

When I run the feature tests, the gives test always fails (
'query_tool_journey_test.py'),

Python: 3.6 (64-bit)
Platform: OS X (10.10.5)

Am I the only one who gets this error?


==
ERROR: runTest (pgadmin.feature_tests.query_tool_journey_test.
QueryToolJourneyTest)
Tests the path through the query tool
--
Traceback (most recent call last):
  File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/
feature_tests/query_tool_journey_test.py", line 46, in runTest
self._test_history_tab()
  File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/
feature_tests/query_tool_journey_test.py", line 104, in _test_history_tab
query_we_need_to_scroll_to
  File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/
feature_tests/query_tool_journey_test.py", line 141, in
_assert_not_clickable_because_out_of_view
self.assertRaises(self.page.click_element(element))
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py",
line 728, in assertRaises
return context.handle('assertRaises', args, kwargs)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/unittest/case.py",
line 158, in handle
(name, self._base_type_str))
TypeError: assertRaises() arg 1 must be an exception type or tuple of
exception types

--
Ran 10 tests in 359.301s

FAILED (errors=1, skipped=1)

==
Test Result Summary
==

PG_95:

8 tests passed
1 test failed:
QueryToolJourneyTest (Tests the path through the query tool)
1 test skipped:
CheckDebuggerForXssFeatureTest (Tests to check if Debugger is vulnerable to
XSS)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 21, 2017 at 8:46 PM, Dave Page  wrote:

> Fix test assertion.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
> f;h=2ebb40819534d79376a577a149a8a5db124b
> Author: Sarah McAlear 
>
> Modified Files
> --
> web/pgadmin/feature_tests/query_tool_journey_test.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Robert Eckhardt]

I'd say we should go with Cmd+/ and Cmd+Shift+/ as that seems the most
common by a small margin - however, I'm still not convinced that we don't
need two keys for optimal behaviour of line commenting.


To be clear, I'm not 100% convinced either. I am, however, convinced that
it is the right first step and then we can get user feedback.

-- Rob

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Robert Eckhardt]

I wouldn't say wrong, it just wasn't what I was expecting.

I guess I'd like to hear what others are expecting. If I had my way we
would use

Ctrl+/   single line comment and uncomment (prepend with --)
Ctrl+Shift+/ block comment and uncomment (bracket with /* and */)


where Ctrl == command on Mac.

-- Rob

On Fri, Jul 21, 2017 at 7:09 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Robert,
>
> I mean rather than using cmd key for Mac and CTRL key for Windows/Linux, I
> used "CTRL" key for all the platforms.
> And regarding choosing comma & period keys, they all are near each to each
> other so user can remember them easily.
>
> Let me know If my thinking was wrong for shortcut keys, I'll change them
> accordingly and send new patch.
>
> On Fri, Jul 21, 2017 at 4:25 PM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>
>> I'm not sure what you mean by across platforms.  Do you mean that those
>> are the keyboard shortcuts in pgAdmin 3?
>>
>> Rob
>>
>> On Jul 21, 2017 4:42 AM, "Murtuza Zabuawala" <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>> Hi Robert,
>>
>> Just to make shortcut keys uniform across all the platforms.
>>
>> On Fri, Jul 21, 2017 at 1:25 AM, Robert Eckhardt <reckha...@pivotal.io>
>> wrote:
>>
>>> Murtuza,
>>>
>>> Is there a particular reason you choose the keyboard shortcuts that you
>>> choose. When we were looking at this earlier to see what was being used
>>> elsewhere we discovered:
>>>
>>> jetbrains  cmd+/
>>> pycharmcmd+/
>>> SublimeCtrl+/ Toggle line comment
>>>Ctrl+Shift+/ Toggle block comment
>>> EclipseCTRL + /
>>> Notepad++  CTRL+Q   Toggle line comment
>>>CTRL+SHIFT+Q Toggle block comment
>>> TextWrangler   Ctrl+/
>>>
>>> -- Rob
>>>
>>>
>>> On Thu, Jul 20, 2017 at 1:05 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
>>>>
>>>> On Thu, Jul 20, 2017 at 10:29 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala <
>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> Please find patch attached, There were two issues,
>>>>>> 1) We removed the default button to clear the editor window, it
>>>>>> broke _clear_query_tool() functionality.
>>>>>> 2) The buttons arrangements, we added new Edit button in between
>>>>>> Delete and Filter button causing the "Explain" -> "Explain Options" sub
>>>>>> menu to go out of browser visibility in feature test, so it was failing.
>>>>>>
>>>>>> I have put Edit button near Clear button for now, until we come up
>>>>>> with new design for our editor for displaying these options.
>>>>>>
>>>>>
>>>>> Hmm, I moved it there intentionally as it's a more traditional
>>>>> position and thus more discoverable.
>>>>>
>>>>> Can we just launch the browser with a wider size, say, 1280? It's on
>>>>> line 43 of app_starter.py...
>>>>>
>>>>>
>>>> Yes, that will work too.
>>>>
>>>>>
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Murtuza Zabuawala
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>> On Thu, Jul 20, 2017 at 6:04 PM, Murtuza Zabuawala <
>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> I am working on this, will send you patch soon.
>>>>>>>
>>>>>>> On Thu, Jul 20, 2017 at 5:53 PM, Dave Page <dp...@pgadmin.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Did you get a chance to look at this yet Murtuza?
>>>>>>>>
>>>>>>>> On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala <
>>>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Robert Eckhardt]

I'm not sure what you mean by across platforms.  Do you mean that those are
the keyboard shortcuts in pgAdmin 3?

Rob

On Jul 21, 2017 4:42 AM, "Murtuza Zabuawala" <
murtuza.zabuaw...@enterprisedb.com> wrote:

Hi Robert,

Just to make shortcut keys uniform across all the platforms.

On Fri, Jul 21, 2017 at 1:25 AM, Robert Eckhardt <reckha...@pivotal.io>
wrote:

> Murtuza,
>
> Is there a particular reason you choose the keyboard shortcuts that you
> choose. When we were looking at this earlier to see what was being used
> elsewhere we discovered:
>
> jetbrains  cmd+/
> pycharmcmd+/
> SublimeCtrl+/ Toggle line comment
>Ctrl+Shift+/ Toggle block comment
> EclipseCTRL + /
> Notepad++  CTRL+Q   Toggle line comment
>CTRL+SHIFT+Q Toggle block comment
> TextWrangler   Ctrl+/
>
> -- Rob
>
>
> On Thu, Jul 20, 2017 at 1:05 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>>
>> On Thu, Jul 20, 2017 at 10:29 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>> Hi
>>>
>>> On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Please find patch attached, There were two issues,
>>>> 1) We removed the default button to clear the editor window, it
>>>> broke _clear_query_tool() functionality.
>>>> 2) The buttons arrangements, we added new Edit button in between Delete
>>>> and Filter button causing the "Explain" -> "Explain Options" sub menu to go
>>>> out of browser visibility in feature test, so it was failing.
>>>>
>>>> I have put Edit button near Clear button for now, until we come up with
>>>> new design for our editor for displaying these options.
>>>>
>>>
>>> Hmm, I moved it there intentionally as it's a more traditional position
>>> and thus more discoverable.
>>>
>>> Can we just launch the browser with a wider size, say, 1280? It's on
>>> line 43 of app_starter.py...
>>>
>>>
>> Yes, that will work too.
>>
>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>> On Thu, Jul 20, 2017 at 6:04 PM, Murtuza Zabuawala <
>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> I am working on this, will send you patch soon.
>>>>>
>>>>> On Thu, Jul 20, 2017 at 5:53 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>>
>>>>>> Did you get a chance to look at this yet Murtuza?
>>>>>>
>>>>>> On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala <
>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>>
>>>>>>> Sure, Will take a look.
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Murtuza Zabuawala
>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>> On Wed, Jul 19, 2017 at 8:00 PM, Dave Page <dp...@pgadmin.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Except I managed to break a couple of tests :-(. Can you take a
>>>>>>>> look please? I've had some other work come up that I need to deal with.
>>>>>>>>
>>>>>>>> 
>>>>>>>> ==
>>>>>>>> ERROR: runTest (pgadmin.feature_tests.query_t
>>>>>>>> ool_journey_test.QueryToolJourneyTest)
>>>>>>>> Tests the path through the query tool
>>>>>>>> 
>>>>>>>> --
>>>>>>>> Traceback (most recent call last):
>>>>>>>>   File 
>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
>>>>>>>> line 45, in runTest
>>>>>>>> self._test_history_tab()
>>&g

Re: Request a feature

[Robert Eckhardt]

Nick,

We were looking at adding this feature but ran into the same problem you
are describing, e.g. when to include and when to not include headers.

Honestly we were waiting for people to start using the new UX for the
differing copy and paste functionality and waiting to see what people said.

The current design (pgAdmin 4 1.5 +) the existing behavior is a hybrid of
excel like functionality and a non-excel table like behavior. One option
would be to go full Excel and treat the headers like a row.

I think my concern with adding a new keyboard shortcut for copy or copy
with headers would be a discoverability issue.

-- Rob

On Wed, Jul 19, 2017 at 3:34 AM, Nick Dro  wrote:

> Hi,
> When copying data from query resut the user can choose whether it would be
> copied with column names or without but choosing the correct setting.
> This is nice but extermly annoying. Sometimes I want it the first way and
> sometimes the other way.
> Would it be possible that Ctrl + C would continue to work with the chosen
> setting and you'll define new key like : Ctrl + B that will be the other?
> Please define some way to have keys for both options. It would help
> considerbly.
> Another solution is simply allow the user to define the shout cut himself
> in the menu.
>
> Thanks,
>

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Robert Eckhardt]

Murtuza,

Is there a particular reason you choose the keyboard shortcuts that you
choose. When we were looking at this earlier to see what was being used
elsewhere we discovered:

jetbrains  cmd+/
pycharmcmd+/
SublimeCtrl+/ Toggle line comment
   Ctrl+Shift+/ Toggle block comment
EclipseCTRL + /
Notepad++  CTRL+Q   Toggle line comment
   CTRL+SHIFT+Q Toggle block comment
TextWrangler   Ctrl+/

-- Rob


On Thu, Jul 20, 2017 at 1:05 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

>
> On Thu, Jul 20, 2017 at 10:29 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find patch attached, There were two issues,
>>> 1) We removed the default button to clear the editor window, it
>>> broke _clear_query_tool() functionality.
>>> 2) The buttons arrangements, we added new Edit button in between Delete
>>> and Filter button causing the "Explain" -> "Explain Options" sub menu to go
>>> out of browser visibility in feature test, so it was failing.
>>>
>>> I have put Edit button near Clear button for now, until we come up with
>>> new design for our editor for displaying these options.
>>>
>>
>> Hmm, I moved it there intentionally as it's a more traditional position
>> and thus more discoverable.
>>
>> Can we just launch the browser with a wider size, say, 1280? It's on line
>> 43 of app_starter.py...
>>
>>
> Yes, that will work too.
>
>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Thu, Jul 20, 2017 at 6:04 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 I am working on this, will send you patch soon.

 On Thu, Jul 20, 2017 at 5:53 PM, Dave Page  wrote:

> Did you get a chance to look at this yet Murtuza?
>
> On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Sure, Will take a look.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, Jul 19, 2017 at 8:00 PM, Dave Page  wrote:
>>
>>> Except I managed to break a couple of tests :-(. Can you take a look
>>> please? I've had some other work come up that I need to deal with.
>>>
>>> 
>>> ==
>>> ERROR: runTest (pgadmin.feature_tests.query_t
>>> ool_journey_test.QueryToolJourneyTest)
>>> Tests the path through the query tool
>>> 
>>> --
>>> Traceback (most recent call last):
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
>>> line 45, in runTest
>>> self._test_history_tab()
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
>>> line 71, in _test_history_tab
>>> self.__clear_query_tool()
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
>>> line 91, in __clear_query_tool
>>> self.page.click_element(self.page.find_by_xpath("//*[@id='bt
>>> n-edit']"))
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>>> line 148, in find_by_xpath
>>> return self.wait_for_element(lambda driver:
>>> driver.find_element_by_xpath(xpath))
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>>> line 232, in wait_for_element
>>> return self._wait_for("element to exist", element_if_it_exists)
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>>> line 282, in _wait_for
>>> "Timed out waiting for " + waiting_for_message)
>>>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa
>>> ges/selenium/webdriver/support/wait.py", line 80, in until
>>> raise TimeoutException(message, screen, stacktrace)
>>> TimeoutException: Message: Timed out waiting for element to exist
>>>
>>>
>>> 
>>> ==
>>> ERROR: runTest (pgadmin.feature_tests.query_t
>>> ool_tests.QueryToolFeatureTest)
>>> Query tool feature test
>>> 
>>> --
>>> Traceback (most recent call last):
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>>> line 52, in runTest
>>> self._clear_query_tool()
>>>   File 
>>> 

Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

[Robert Eckhardt]

Looks good.

I assumed American spelling, should we use proper English spelling? Our
prodigious use of the 'z' (pronounced zee) definitely improves our scrabble
scores.

-- Rob

On Tue, Jul 18, 2017 at 7:54 AM, Dave Page  wrote:

>
>
> On Mon, Jul 17, 2017 at 7:51 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Hackers,
>>
>> With this patch we added the style guide to the current pgAdmin website.
>> It is not 100% migrated yet, but we already have the Alerts and colors.
>>
>>
> Thanks - applied with some minor styling and layout changes. Please check
> I didn't break anything.
>
> You obviously miss-spelt "colour", but I let that slide :-p
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: pgadmin-for-web is going nowhere

[Robert Eckhardt]

Josh,

I'd be interested in knowing what specific things could be done to make you
think that the Web version is no longer the 'ugly stepchild'.

If I consider our (Pivotal's) current development process then the most
honest thing we could say is that the desktop application is our
afterthought. All of our development is done in the browser, our acceptance
environment is an application pushed into a garden container hosted in the
cloud.

Admittedly, we haven't focused on the installation experience so if you
could explain why it is so painful we could look at merging some of the
things we are doing for acceptance into the application itself for
distribution.

-- Rob

On Thu, Jul 13, 2017 at 1:23 PM, Josh Berkus  wrote:

> Folks,
>
> Installing pgadmin-for-web is painful, poorly documented, and broken.
> As a result, it's not considered a real UI by anyone not on this team.
>
> Six months ago, I jumped on this with the goal of solving it, partly
> through use of linux containers.  However, I'm full stop because of the
> emphasis on (a) having only one package which is both desktop and web,
> and (b) treating the web version as the ugly stepchild.
>
> See: https://redmine.postgresql.org/issues/2495#change-7635
>
> If you read the conversation on pgsql-advocacy, for example, you'll see
> that even people in our own community regard pgAdmin4 as not production
> quality software.
>
> As such, I'm done.  When y'all decide to get real with caring about
> users' ability to install pgadmin for web, ping me.
>
> --Josh Berkus
>
>

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Robert Eckhardt]

Yay.

-- Rob

On Wed, Jul 12, 2017 at 8:16 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch which will add functionality to allow user to comment/uncomment
> code in query editor.
> RM#2456
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4]: Webpacking of static JS/CSS

[Robert Eckhardt]

The last email on this chain from Surinder says that it isn't working on IE
and he will submit another patch. Are we missing that patch? Would you like
us to look at the previous patch?

-- Rob


On Jul 11, 2017 11:37 AM, "Dave Page"  wrote:

> Pivotal team; you guys are far more familiar with webpack etc. than we
> are; could you review please?
>
> Thanks!
>
> On Tue, Jul 11, 2017 at 4:24 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> 1) Created a separated patch for Un-vendored libraries and another one
>> related to webpack bundle files so it is easy to review.
>>
>> 2) Removed commented out code and dead code.
>>
>> 3) Feature test cases are fixed. All are running.
>> I have to add `time.sleep` of 1 second in method
>> 'fill_codemirror_area_with' as sometimes it work and sometimes don't.
>>
>> 4. Removed unused libraries from package.json
>>
>> Please find updated patch and review.
>>
>> Thanks,
>> Surinder
>>
>>
>>
>> On Tue, Jul 11, 2017 at 3:11 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>>
>>> This patch doesn't work in windows IE 11 due to error `'Promise' is
>>> undefined
>>> ​`​.
>>>
>>> The dependency package 'babel-polyfill' is required to run ES6 code with
>>> webpack and has to load before at entry point of app.
>>> related thread 
>>>
>>> Please find updated patch.
>>>
>>> Thanks
>>> Surinder
>>>
>>> On Tue, Jul 11, 2017 at 2:13 PM, Dave Page 
>>> wrote:
>>>
 Nice!

 On Tue, Jul 11, 2017 at 9:42 AM, Neel Patel <
 neel.pa...@enterprisedb.com> wrote:

> Hi Dave,
>
> I have tested Surinder's patch in my local machine with Qt 5.9.1
> Webkit on Windows and we are getting improvements with this patch. :)
>
> Below performance tested with Qt 5.9.1 with annulen webkit v 5.212.0
> Alpha2.
>
> *Before Webpack patch:-*
>
> It took ~20 seconds. This 20 seconds includes when user double click
> on application ( timing of python server start + page load )
>
> *After Webpack patch:-*
>
> It took ~13 seconds ( timing of python server start + page load ).
>
> We got ~7 seconds improvement with webpack on same machine & same Qt
> configuration and this will be useful in windows performance issue as well
> :)
>
> Thanks,
> Neel  Patel
>
> On Tue, Jul 11, 2017 at 1:27 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> I found this patch won't work on IE, so i have fixed it and will send
>> updated patch.
>>
>> On Tue, Jul 11, 2017 at 1:25 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>>
>>> On Tue, Jul 11, 2017 at 1:22 PM, Dave Page 
>>> wrote:
>>>
 When you say "un-vendorising", do you mean removing them from the
 vendor directory and adding them to packages.json so they're pulled in 
 via
 npm/yarn? (if so, good :-) )

>>> ​Yes.​
>>>

 On Tue, Jul 11, 2017 at 7:34 AM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> *Detailed changes:*
>
> ​1) Created a file bundle/app.js which loads `browser.js`  and
> then 'tools.datagrid' and its other dependents are configured to load 
> in
> '`imports-loader`
>
> 2) bundle/codemirror.js - it generates a bundled JS which is used
> wherever required in various modules.
>
> 3) file_utils.js - It bundles the file manager's utility JS file
> and loaded from `file manager/index.html`
>
> 4) lib_css - It contains list of vendor CSS to be bundled.
>
> 5) pgadmin_css - It contains list of overrides CSS which are
> bundled and which has to load after vendors CSS is loaded.
>
> *Various Webpack configuration parameters:*
>
> 1) externals: List of template files to be loaded dynamically when
> a call is made by dependent modules. These files are excluded from the
> bundled JS.
>
> 2) resolve > alias - This resolves the path of module JS which is
> referred in other modules; For example:
> 'backbone': path.join(__dirname, './node_modules/backbone/backb
> one')
>
> 3) `backbone` is used in 'define(['backbone'])' calls and its path
> is resolved to above absolute path.
>
> 4) 'pgLibs': List of files to bundle into `pgadmin_commons.js`.
> The purpose is to separate files other than browser node modules JS in
> `pgadmin_commons.js` and browser node modules JS in `app.bundle.js`. 
> It
> will help in debugging the code during development.
>
> *Un-vendor modules:*

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

[Robert Eckhardt]

On Mon, Jul 3, 2017 at 5:36 AM, Dave Page  wrote:

>
>
> On Fri, Jun 30, 2017 at 12:19 PM, Shirley Wang  wrote:
>
>> Hello!
>>
>> Currently the app uses 'monospace' to define the font family for SQL
>> queries and messages, which looks a little squished when in uppercase. PT
>> mono is another monospaced font (available on Google fonts) that looks
>> similar to 'monospace' but is more legible for uppercase.
>>
>> *PT Mono:*
>> [image: Screen Shot 2017-06-30 at 12.09.15 PM.png]
>>
>> *Monospace*
>> *[image: Screen Shot 2017-06-30 at 12.09.20 PM.png]*
>> Thoughts?
>>
>
> I'm not sure I like it. It looks a little like the old-school "digital"
> font; the sort of thing they used in the movie War Games.
>

As an aside, font used in the movie War Games actually kinda seels it to me
in my book.

Looking at the two the other day, it seemed like the lower case fonts are
pretty much the same but the Capital letters of PT Mono are spaced out a
bit more making it easier to read.

-- Rob


>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: Refactor of the History Tab

[Robert Eckhardt]

Surinder,

It would be great if you could take a look at this an see if the style
changes are more inline with what you were thinking when you commented on
the first patch.

-- Rob

On Fri, Jun 30, 2017 at 11:55 AM, Shruti Iyer  wrote:

> Hi Hackers,
>
> Attached is the patch that refactors the react components that supports
> the history detail pane. We moved inline styling. whenever possible, to
> scss.
>
> Thanks,
> Joao and Shruti
>

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

[Robert Eckhardt]

On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hello Hackers,
>
> When we started the app we noticed some change in the front end.
>
> The line numbers in the Editor:
> - We noticed a bug with the numbers where at 1 rows, the numbers would
> be cut off.
> - When the row is selected the color of the text should be white
> - Centering the number column would differentiate it from the rest of the
> table and prevent any confusion
>
>
Do we want line numbers? I'm of mixed opinion. On the one hand it implies
and ordered set of results when Postgres inherently doesn't order results.
On the other hand it nicely tells you where you are in the results set if
you are scrolling around.

-- Rob