pgAdmin user types survey

[Shirley Wang]

Hello!

Below is a link to a survey to help us learn more about the types of
pgAdmin users at your company.

We (Pivotal team) will compile the results of the survey and share them
with the community. The results will help us further understand the types
of users of pgAdmin and create better experiences for everyone.

*Here's the link to the survey:*
https://www.surveymonkey.com/r/pgAdmin4users

This should take about 10 minutes to complete. Please feel free to share
this link with others if you think they are able to fill out the survey.

Please contact me or Rob (cc'd) if you have any questions.

Thanks,
Shirley

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

[Shirley Wang]

What are thoughts on switching the colors between currently running and
idle? I think if the session is currently running, and its still open
during the session time limit, it should be green. Perhaps idle sessions
should be yellow or grey to indicate that the window should be (and can be)
closed without terminating any current transactions.

As far as it pulsating, most users only need to know session status when
they look for it, and it's not top of mind when they open the window. I
agree with Dave that it shouldn't attract people's attention unless there
is a problem.

On Tue, Dec 19, 2017 at 7:15 AM Dave Page  wrote:

> Hi
>
> On Tue, Dec 19, 2017 at 2:17 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, Dec 19, 2017 at 7:24 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> Interesting. A few thoughts:
>>>
>>> - The pulsating icon is very off-putting. I think we need to make it
>>> only flash a couple of times when we actually need to attract the attention
>>> of the user.
>>>
>> ​As per my discussion with Chethana, In his opinion user tends to notice
>> things that way more quickly.
>> Are you sure you wish to flash only couple of times on error?
>>
>
> We already show and alert and switch to the messages tab if there's an
> error right? Either way, it's very off-putting.
>
>
>>
>>> - We shouldn't really use tooltips like this, as it may confuse folks
>>> with screen readers. Should we make the icon clickable (which should have a
>>> visual hint)? Maybe a drop-down status panel.
>>> ​
>>>
>>>
>> ​Sure let me check.
>> ​
>>
>>>
>>> - Do we need to poll separately for the status? Instead, why not update
>>> it whenever polling for results, or executing something?
>>>
>> ​Then user won't be able to know the current connection status prior to
>> query execution, the purpose of the feature is to make user aware of
>> current connection status even if there is no query running, As most user
>> tends to leave open their query tool window after their work it will be
>> useful when flask session gets expired and connection to server gets closed
>> after that.
>>
>
> Ah, OK. I see. Where is the polling frequency? I can't find it in the
> Preferences.
>
> I'm really not too sure about polling this often. If i've got 5 query tool
> windows open, that's 10 queries a second, with the dashboard as well.
> That's why I was suggesting piggy-backing the status updates on other
> queries.
>
> Sidenote: I've seen the status indicator go from green to orange and back
> again numerous times, for no obvious reason when connected to a local
> server.
>
>
>>
>>> Thanks!
>>>
>>> On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA patch to add the connection status
 
 in query tool, this feature will allow user to check the database
 connection status in query tool itself, it will also provide the detailed
 status as a tooltip when user hovers on it, the most benefit of the feature
 will be when user open query tool in new Browser Tab where Browser tree is
 not visible to user, user can also configure the status polling time using
 preference dialog.
 RM#2475

 Apart from that I have also removed the
 ..sqleditor/static/css/sqleditor.css reference from
 ../datagrid/templates/datagrid/index.html file because we are already
 bundling the "sqleditor.css" file in main "style.css" file.


 Thanks to Chethana for his UI related inputs and to Surinder for
 helping me on html alignment issues.


 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

[Shirley Wang]

Hi Harshal and Akshay,

I'm noticing that the screenshots you attached have fonts that look
different (ex. no font weights for table headers). Is that a result of the
font bundling and needs to be updated?

On Fri, Sep 15, 2017 at 12:18 AM Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Thanks, I'll look into it.
>
> On Sep 14, 2017 5:31 PM, "Akshay Joshi" 
> wrote:
>
>> Hi Harshal
>>
>> I have reviewed your patch it looks good to me. Only one issue I have
>> found with char[], when I store {'a','b','c'} it gets stored and when I
>> refreshed it shows {',','}. Please look into this issue.
>>
>> On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> It works, sorry for the noise.
>>>
>>> On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Harshal,

 Can you please rebase the patch, it's not applied with the latest code.

 On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

>
>
> On Tue, Sep 12, 2017 at 2:34 PM, Dave Page  wrote:
>
>> Adding Akshay...
>>
>
> Sure.
>
>>
>> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page 
>> wrote:
>>
>>> Akshay, can you review/commit this please?
>>>
>>> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find attached patch to represent array data in datagrid with
 curly braces and
 also allow user to save array with values like  , >>> string>, '*""*' and "*''*"

 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
> 976-788-8246 <+91%2097678%2088246>*
>



 --
 *Akshay Joshi*
 *Principal Software Engineer *



 *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
 976-788-8246 <+91%2097678%2088246>*

>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>

Re: Fonts for pgAdmin

[Shirley Wang]

They're from the Google fonts directory :
https://fonts.google.com/selection?category=Monospace=Open+Sans:400,400i,600,700|Source+Code+Pro:400,700

On Tue, Sep 12, 2017 at 4:28 PM Dave Page <dp...@pgadmin.org> wrote:

> Hi
>
> On Tue, Sep 12, 2017 at 4:13 AM, Shirley Wang <sw...@pivotal.io> wrote:
>
>> Hi
>>
>> Following up on Anthony's comment in another thread, here are the open
>> source fonts that I used in the test builds.
>>
>> I don't have the CSS skills to create a patch for submission, could
>> someone take the lead and help create these?
>>
>> Attached is a font file that includes Open Sans (regular, italic,
>> semibold, and bold) and Source Code Pro (regular and bold). Open Sans is
>> used for body text in place of Helvetica/Arial and Source Code Pro is a
>> monospace to be used in place of Monospace.
>>
>
> What is the canonical source of these fonts?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

[Shirley Wang]

+1 to Rob. By the time a user drills into seeing column properties, she'll
have gone through 5 layers of navigation. Is there another way to display
this information so that it's not nested?

If this is a visual design revamp that's a different conversation. What
kind of feedback are you looking for?

Shirley

On Tue, Aug 29, 2017 at 10:57 AM Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:

> Hi Team,
>
> I am sharing a improvised mockup in response to the below request that I
> received for '*Table properties*' where we have multiple subgrid controls
> with tabs.
>
> Please feel free to share your views on the same.
>
> Thanks and regards,
> Chethana kumar
>
>
>
> On Tue, Aug 8, 2017 at 10:22 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, Aug 7, 2017 at 9:06 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>>
>>>
>>> On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar <
>>> chethana.ku...@enterprisedb.com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Could you comment on the new design update for subnode control ?
>>>>
>>>> Attached designs -
>>>>
>>>> 1. subnode_current.png -  The existing view
>>>> 2. subnode_new.png - The updated view
>>>> 3. current_new.png - Existing and new design placed together for
>>>> comparison purpose
>>>>
>>>> Below changes done -
>>>>
>>>> 1. Reduced number of gray color variations
>>>> 2. Made more simplified by removing unwanted borders
>>>> 3. Merged "Arrow Down" background and the body background for more
>>>> clarity
>>>>
>>>> Please feel free to provide your input on the same.
>>>>
>>>
>>> Much nicer in my opinion! Good work.
>>>
>>> Anyone else have any comments?
>>>
>> It looks much nicer.
>> I would like to see the effect on another dialogs like 'Table
>> properties', where we have multiple level of subgrid controls with tabs.
>>
>> -- Thanks, Ashesh
>>
>>>
>>>
>>>>
>>>> Regards,
>>>> Chethana kumar
>>>>
>>>>
>>>>
>>>> On Fri, Jul 28, 2017 at 4:11 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> I took a quick look at this and have a couple of thoughts:
>>>>>
>>>>> - Instead of the "edit" icon to open the subnode, we should use
>>>>> something more appropriate - a "properties" icon perhaps.
>>>>>
>>>>> - There seems to be a lot of different shades of grey on there (maybe
>>>>> a subnode design in general that just shows up with the disabled 
>>>>> controls),
>>>>> and the subnode control looks a bit messy as a result.
>>>>>
>>>>> Can you work with Chethana to improve the look and feel please?
>>>>>
>>>>> Input from others welcome of course - screenshot attached.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <
>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>
>>>>>> ++ Attaching the patch
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Murtuza Zabuawala
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>> On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <
>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> PFA patch to display additional information from pg_stat_activity
>>>>>>> table using subnode control.
>>>>>>> RM#2597
>>>>>>>
>>>>>>> Please review.
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Murtuza Zabuawala
>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>> On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <sw...@pivotal.io>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>

Re: Selecting tables from Browser

[Shirley Wang]

On Tue, Aug 22, 2017 at 8:27 AM Dave Page <dp...@pgadmin.org> wrote:

> On Tue, Aug 22, 2017 at 12:17 AM, Shirley Wang <sw...@pivotal.io> wrote:
>
>> Hi Rob
>> On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt <reckha...@pivotal.io>
>> wrote:
>>
>>> Shirley,
>>>
>>> I have a few questions.
>>>
>>>1. Why 20. It is a dunbar number and seems smallish but is there
>>>another reason?
>>>
>>> The browser fits about 30 ish items right now on my smallish laptop
>> screen. The question we asked ourselves is 'what is the most content we can
>> show before the browser gets unwieldy?'
>>
>
> A lot more than the proposed 20. I regularly work with ~100 tables in a
> single schema, and having to go through an additional dialogue to find what
> I need would be hugely inconvenient.
>
> I will often learn about a new database by browsing through it as well,
> jumping from table to table as I discover relationships etc. I couldn't
> imagine doing that with a filtering dialogue getting in the way.
>

Would you be able to describe more about your use case? What role are you
taking on as you are browsing through the database, what are you trying to
accomplish and why?


>
>
>>
>> You have thoughts on this?
>>
>>
>>>
>>>1. Since this is referred to as an Object Manager I assume the same
>>>thing will eventually be available for databases, schema, partitions, 
>>> etc.
>>>How do permissions work currently to limit m view of these objects? (or 
>>> do
>>>they)
>>>
>>>
>> Good point about the name implying further reach than just tables. We're
>> going to change the dialog header to show 'Select tables for display', at
>> least until we decide we want to include databases, schema, partitions.
>>
>> I'm not sure how permissions works to limit the view, our assumption is
>> that permissions does though.
>>
>> Dave P do you have more insight on what permissions can limit?
>>
>
> Permissions don't limit what you would see here. They limit a roles
> ability to insert/update/delete data in tables, but not to examine the
> schema.
>

So as a Platform Administrator (which we're defining as someone in a very
large company who works with many DBAs across multiple databases), I am not
able to restrict what schemas different user groups can see?

More specifically, if there are 500 schemas for an org, every user will be
able to see them all in the browser and changing permissions will not
impact what a DBA will see?


>
>
>>
>>>1. Do you think that this would look differently if you assumptions
>>>were based on a user who writes BI reports or some other non-DBA user?
>>>
>>> Potentially, as you mentioned off the email thread, a DBA would be
>> interested in a larger list of tables than someone who writes BI reports.
>>
>> That said, since this is a problem we hear from DBAs, and they feel the
>> most pain around this, I think it's fine to focus on solving the problem
>> for them. Solving their pains will also address the pains of people who
>> write BI reports since they also feel the same issues at a lesser intensity
>>
>> We will be testing with non-DBA users though too.
>>
>
> I think this is the wrong way to approach this problem. At the very least,
> the limit of 20 objects needs to have a much higher value, and be
> configurable.
>
> I think it would be far better to implement searching of the tree as we
> had in pgAdmin 3 (and a number of users have requested we re-implement),
>

Implementing search will definitely add value for users, we've also heard
the same requests from people during our interviews as well. However it
doesn't solve for navigating the browser when there are enough tables to
crash or significantly slow down the application.

20 objects is where we're starting from, it's definitely a risky assumption
we're making and I'm not convinced it's the right number. But for user
interviews its good to have a clear point of view on a design decision so
we can test it and get feedback on it.



> and do partial branch loading on the tree, where we display maybe 30
> items, then add a "Load more..." node at the end, that when click would be
> replaced with the next 30 items.
>

I think that would make it difficult to get to zebra table. A partial load
could be a solution, followed by some way to navigate to the tables towards
the end of the alphabet.

Re: Selecting tables from Browser

[Shirley Wang]

Hi Rob
On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt 
wrote:

> Shirley,
>
> I have a few questions.
>
>1. Why 20. It is a dunbar number and seems smallish but is there
>another reason?
>
> The browser fits about 30 ish items right now on my smallish laptop
screen. The question we asked ourselves is 'what is the most content we can
show before the browser gets unwieldy?'

You have thoughts on this?


>
>1. Since this is referred to as an Object Manager I assume the same
>thing will eventually be available for databases, schema, partitions, etc.
>How do permissions work currently to limit m view of these objects? (or do
>they)
>
>
Good point about the name implying further reach than just tables. We're
going to change the dialog header to show 'Select tables for display', at
least until we decide we want to include databases, schema, partitions.

I'm not sure how permissions works to limit the view, our assumption is
that permissions does though.

Dave P do you have more insight on what permissions can limit?

>
>1. Do you think that this would look differently if you assumptions
>were based on a user who writes BI reports or some other non-DBA user?
>
> Potentially, as you mentioned off the email thread, a DBA would be
interested in a larger list of tables than someone who writes BI reports.

That said, since this is a problem we hear from DBAs, and they feel the
most pain around this, I think it's fine to focus on solving the problem
for them. Solving their pains will also address the pains of people who
write BI reports since they also feel the same issues at a lesser intensity

We will be testing with non-DBA users though too.


>
>

Re: pgAdmin4 - Tree view icons for final reveiw

[Shirley Wang]

Hi Chethana,

I just thought of something with these icons. What happens with the ones
that appear in dialog headers? In the blue bar?

On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:

> Hello Team,
>
> I have applied labels for each icon for identification purpose.  So please
> consider this copy for your feedback.
>
> *Note*: The "icon_demo.png" is attached to show case the view on webpage.
>
> Regards,
> Chethana kumar
>
> On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Hello Team,
>>
>> Here are the revised and final icons for tree view control.
>> I have attached in .svg file format as well so that you can do zoom in
>> view at any level.
>>
>> Please share your feedback on the same.
>>
>>
>> Thanks and regards,
>>
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146 <+91%2086981%2057146>
>> www.enterprisedb.com
>>
>
>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146 <+91%2086981%2057146>
> www.enterprisedb.com
>

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

[Shirley Wang]

Ok, I understand that this is a feature that should exist. We should
decouple the need for a feature existing from the way the feature is
designed and used. I think we need a broader discussion on how to do this.

On Tue, Jul 25, 2017 at 3:59 PM Dave Page <dp...@pgadmin.org> wrote:

> On Tue, Jul 25, 2017 at 6:26 AM, Shirley Wang <sw...@pivotal.io> wrote:
>
>>
>>> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <sw...@pivotal.io> wrote:
>>>>
>>>>> 2-3 days is a lot of valuable engineering time. Is this a 'drop
>>>>> everything now' kind of feature or can this wait for some user validation
>>>>> on a mock up first?
>>>>>
>>>>
>>>> Most of the time will likely be on the infrastructure to change the
>>>> display to a subnode control. If you have some cycles to mockup potential
>>>> layouts for the subnode view and have them validated, please feel free,
>>>> however, that seems like an awful lot of work to me to display some missing
>>>> SQL using a standard control.
>>>>
>>> Regarding SQL display: Developing simple control to show codemirror in
>>> disabled state (for now) wont take that much time.
>>>
>>>
>> Part of a product designer's job is to make sure there is a definitive
>> need for a feature and that the interface for the feature is designed in
>> such a way that the user gets all intended value from it. Time spent
>> validating now will decrease the time spent later on redesigning /
>> reimplementing.
>>
>> If everyone is aware of what that value is and confident that how it'll
>> be displayed is right, there's little risk in starting to develop it. If
>> we're wrong, it'll add to feature bloat and detract from the experience.
>>
>
> There are also features that we know are required from nearly 20 years of
> experience building pgAdmin. This is one of those "D'oh, how on earth did
> we not think of that" features that should have been in the original
> release but wasn't. It's painfully obvious that we need this, as a number
> of users have pointed out since we first released pgAdmin 4. It's the
> equivalent of a tool for deleting files that doesn't tell you the name of
> each file.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

[Shirley Wang]

>
>
> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>>
>>
>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <sw...@pivotal.io> wrote:
>>
>>> 2-3 days is a lot of valuable engineering time. Is this a 'drop
>>> everything now' kind of feature or can this wait for some user validation
>>> on a mock up first?
>>>
>>
>> Most of the time will likely be on the infrastructure to change the
>> display to a subnode control. If you have some cycles to mockup potential
>> layouts for the subnode view and have them validated, please feel free,
>> however, that seems like an awful lot of work to me to display some missing
>> SQL using a standard control.
>>
> Regarding SQL display: Developing simple control to show codemirror in
> disabled state (for now) wont take that much time.
>
>
Part of a product designer's job is to make sure there is a definitive need
for a feature and that the interface for the feature is designed in such a
way that the user gets all intended value from it. Time spent validating
now will decrease the time spent later on redesigning / reimplementing.

If everyone is aware of what that value is and confident that how it'll be
displayed is right, there's little risk in starting to develop it. If we're
wrong, it'll add to feature bloat and detract from the experience.

Would Chethana be able to take on some of the design work? It would be
valuable for the dev team to also be part of design process.

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

[Shirley Wang]

2-3 days is a lot of valuable engineering time. Is this a 'drop everything now' 
kind of feature or can this wait for some user validation on a mock up first? 

> On Jul 24, 2017, at 20:41, Murtuza Zabuawala 
> <murtuza.zabuaw...@enterprisedb.com> wrote:
> 
> Sure.
> 
> RM created: https://redmine.postgresql.org/issues/2597.
> 
>> On Mon, Jul 24, 2017 at 6:04 PM, Dave Page <dp...@pgadmin.org> wrote:
>> 
>> 
>>> On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala 
>>> <murtuza.zabuaw...@enterprisedb.com> wrote:
>>> Hi Dave,
>>> 
>>>> On Mon, Jul 24, 2017 at 4:44 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>> Thanks, applied.
>>>> 
>>>> How much effort do you think it would take to turn the table into a 
>>>> subnode control so we can show the SQL query and other missing fields from 
>>>> pg_stat_activity on that tab?
>>> 
>>> I think around 2-3 days would be needed. 
>> 
>> OK - can you add a Redmine and work on that please? It's been a known 
>> deficiency for quite a while, and whilst working on this patch I realised 
>> just how badly we really need to see the SQL there.
>> 
>> Thanks.
>>  
>>>>  
>>>>> On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala 
>>>>> <murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>> Hi Dave,
>>>>> 
>>>>> Please find updated patch.
>>>>> 
>>>>>> On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala 
>>>>>> <murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>> Hi Shirley,
>>>>>> 
>>>>>>> On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <sw...@pivotal.io> wrote:
>>>>>>> Hi!
>>>>>>> 
>>>>>>> I can't seem to get the patch to completely work on my computer, only 
>>>>>>> the close icon shows up plus the dialog and success/error messages, but 
>>>>>>> here are some comments:
>>>>>>> 
>>>>>> Because  we are just cancelling the active running query, so if the 
>>>>>> start of the session is 'Active' when you cancel it will simply goto 
>>>>>> 'Idle' stat. 
>>>>>>> +1 to Dave's comment about refreshing after the cancel operation
>>>>>>> 
>>>>>> I'll fix this. 
>>>>>>> - We're working on a patch for updating alerts in the Dashboard tab 
>>>>>>> which updates the grays in the Database activities panel and changes 
>>>>>>> the border around the refresh button and search bar to 1px. This hasn't 
>>>>>>> been submitted yet but just a heads up as you work on the alignment.
>>>>>>> 
>>>>>>> - Something to consider is how a super user will identify which session 
>>>>>>> should be closed. Is that information there?
>>>>>>> 
>>>>>> I think super user can cancel everything except main connection session 
>>>>>> & as Dave mentioned in previous email that background workers in PG10. 
>>>>>>> - Are there sessions that should never be closed? If so, do they also 
>>>>>>> need close buttons? (Probably not, because that will lead the user to 
>>>>>>> an error message, which is not fun)
>>>>>>> 
>>>>>> In Backgrid, we can not exclude specific column from certain rows if it 
>>>>>> renders in one row then it will render for every row in the grid, What 
>>>>>> we can do is, it will throw an error when user is not eligible to cancel 
>>>>>> the active running query. 
>>>>>>> - Perhaps this is a good feature to review with Chethana! :)
>>>>>>> 
>>>>>>>> On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala 
>>>>>>>> <murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>>>>> On Mon, Jul 17, 2017 at 3:01 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>>>>>> Hi
>>>>>>>>> 
>>>>>>>>>> On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala 
>>>>>>>>>> <murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>>>>>> hiHi,
>>>>>>>>>> 
>>>>>>>>>> PFA patch to add functionality which will al

Re: [pgAdmin4][Patch]: Improvise the treeview element selection

[Shirley Wang]

Hi Surinder,

This change seems to be different from the other patterns for selected /
highlighted options. Is there a reason why this needs to be more visible
than it already is? In terms of feedback on the tree, we have not heard any
pains from users that this is not visible enough.

Shirley

On Mon, Jul 24, 2017 at 12:47 PM Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi All,
>
> Changes:
>
> 1. Highlight the full selected tree item instead of highlighting only
> label.
> 2. Set selected item background color to dark blue that is more visible to
> eyes.[same as in pgAdmin3]
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
>

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Shirley Wang]

Until we learn definitively from users that the current implementation of
commenting/uncommenting in other tools is not working, we should use what
is common practice. We can use that as a baseline and then if we learn that
there needs to be another shortcut, we can add additional functionality.
It's much easier to add something for users than to take away.

On Fri, Jul 21, 2017 at 12:08 PM Robert Eckhardt 
wrote:

> Right - we lose the ability to uncomment multiple levels though, which may
>> also be useful.
>>
>
> Well yes.
>
> I would argue that simplicity trumps potential use. I'd also argue that
> attempting to maintain consistency across environments (IDEs, etc. ) is
> advantageous. This was the philosophy we were going with when enabling
> excel like behavior (also why I'm not fully happy with how it is today).
>
> -- Rob
>

Re: [pgAdmin4][Patch] Font sizes to 13 px and not bolded

[Shirley Wang]

Oh whoa I didn't realize they became all wonky. It also looks like headers
in the statistics table is still bold, so perhaps there's something missing
in our patch. We'll take a look.

On Thu, Jul 20, 2017 at 4:01 PM Dave Page <dp...@pgadmin.org> wrote:

> Hi
>
> On Thu, Jul 20, 2017 at 7:55 PM, Shirley Wang <sw...@pivotal.io> wrote:
>
>> Hi
>>
>> Attached is a patch for changing the font sizes of dialog, table, and
>> graph headers to 13 px and unbold them.
>>
>> Let us know your thoughts.
>>
>>
> I think this is heading in the right direction, but it's not quite there
> yet. As you can see in the attached screenshot the table headers for
> Statistics, Dependencies and Dependents, and the subnode headers and column
> headers still need work. I think this patch makes that even more obvious
> than it is now, so I'm not going to apply it until the other items can be
> addressed as well.
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

[Shirley Wang]

>
>
> Iirc, we did some back and forth over that about 18 months ago, as
> dialogues didn't look quite right without the bold - and I do think that it
> looks a little light on your mockup. I don't think there's a hard
> requirement they match table headers; they are distinct types of header.
>
> Happy to try out change though if you can workup one or more suggested
> patches.
>
>
Two more things we're going to add to the style guide are the dialog labels
and buttons within the dialog.

*Dialog text fields:*
These will have 14px bold labels, and the text field box will be 36px in
height

[image: label.png]

Larger text fields should be set to 360px in height and have a draggable
corner to adjust height if needed
[image: Comments.png]


*Buttons in dialog:*
The should be one solid color to help them stay consistent with the
aesthetic of the rest of the application (ex. alerts styling).

enabled and disabled versions of buttons:
[image: Screen Shot 2017-07-20 at 11.30.24 AM.png]

In terms of usability, having the most common action in the corner makes it
easier to find and click. Rearranging the buttons so that 'save' is at the
end would accomplish this.

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

[Shirley Wang]

Hi!

I can't seem to get the patch to completely work on my computer, only the
close icon shows up plus the dialog and success/error messages, but here
are some comments:

+1 to Dave's comment about refreshing after the cancel operation

- We're working on a patch for updating alerts in the Dashboard tab which
updates the grays in the Database activities panel and changes the border
around the refresh button and search bar to 1px. This hasn't been submitted
yet but just a heads up as you work on the alignment.

- Something to consider is how a super user will identify which session
should be closed. Is that information there?

- Are there sessions that should never be closed? If so, do they also need
close buttons? (Probably not, because that will lead the user to an error
message, which is not fun)

- Perhaps this is a good feature to review with Chethana! :)

On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> On Mon, Jul 17, 2017 at 3:01 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> hiHi,
>>>
>>> PFA patch to add functionality which will allow super user to cancel
>>> long running queries from dashboard.
>>> RM#1812
>>>
>>> *Steps used to test:*
>>> 1) Open psql session, Connect to 'test' database on respective server
>>> 2) Execute "select pg_sleep(1000);"
>>> 3) Open pgAdmin4
>>> 4) Connect to respective server
>>> 5) Click on Dashboard
>>> 6) Check "Sessions" tab under "Server activity" section then look for
>>> active sessions for test database.
>>> 7) Click on cancel button and cancel the active session
>>> 8) Check psql session now, you will see "ERROR:  canceling statement due
>>> to user request"
>>>
>>> Some comments:
>>
>> - The action here is to cancel the active query in the backend, not the
>> session - so messages etc. should say things like "Cancel Active Query?"
>>
>> - The grid should refresh following the cancel operation.
>>
>> - Can you fix the vertical alignment while you're working on this? The
>> new button really makes the poor alignment stand out.
>>
>> - This should not be superuser only - regular users should be able to
>> cancel their own queries.
>>
>> - On PG10, background workers are also shown in the dashboard. Should we
>> prevent attempts to cancel their work (they'll fail anyway I believe).
>>
>> Thanks!
>>
>>
> Sure, I'll work on these comments & send updated patch.
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

Re: Testing out font changes in query editor tool

[Shirley Wang]

Thank you! We also realized it would be easier on people to have both Mac
and Windows test builds from the same url above. If it's not too difficult,
would you also be able to add that as well?

On Mon, Jul 17, 2017 at 5:55 AM Dave Page  wrote:

> On Fri, Jul 14, 2017 at 5:06 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Shirley,
>>
>> It's easy on the eyes :)
>>
>
> Agreed.
>
> As requested, there's a test build for Windows at
> https://developer.pgadmin.org/~dpage/query_tool_font_test/
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Design sync up meeting notes

[Shirley Wang]

Hi all,

Below are notes from our sync up today. Please reach out to me or Chethana
Kumar if you have any questions!

Shirley


*7.12 Meeting Notes*

We discussed:
- Migrating styleguide from WIP  to
pgadmin.org: working on migrating colors over first.
- Icons in pgAdmin4 menus: Inconsistent in style, some have color some
don't. Also unclear if adding value by having so many
- Process for design: documentation on the agreed upon process to help with
measuring progress and making improvements when necessary
- Inconsistencies between styleguide and application: styles are agreed
upon, but changes within the app require time to locate inconsistencies and
implement. Changes are tracked in the Trello

- Dev & Design: Different working processes, having all developers work on
styles vs one person dedicated to styles


Next steps and actions
- Continue moving styleguide over to pgadmin.org [Shirley]
- Begin working on iconography for menus [Chethana]
- Share out meeting notes from design sync ups [Chethana + Shirley]
- Continue updating styles in application [Shirley]

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

[Shirley Wang]

I noticed that the default font, Menlo, was disabled in favor of Monospace.
Was there a specific reason why Monospace was used in favor of Menlo?

I find that Menlo is an easier font to read, especially for uppercase
letters. For web apps, sans-serif fonts are used (fonts without the little
notch, or serifs, at the end of each stroke of a letter) so it's easier to
read on a display. Serif fonts are better for print.


*Menlo:*
[image: Screen Shot 2017-07-10 at 4.38.11 PM.png]

Re: Tree view icon samples

[Shirley Wang]

I recommend using Sim Daltonism to test colors!

https://itunes.apple.com/us/app/sim-daltonism/id693112260?mt=12

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

[Shirley Wang]

Hi all,

We've updated the borders around alerts so that they are more prominent.

[image: error alert (1).png]
[image: success alert (2).png]
[image: Neutral alert.png]
Everything else stays the same. Let me know your thoughts if any.

Shirley & Shruti

On Wed, May 31, 2017 at 3:02 PM Shirley Wang <sw...@pivotal.io> wrote:

> On Wed, May 31, 2017 at 11:55 AM Dave Page <dp...@pgadmin.org> wrote:
>
>> On Wed, May 31, 2017 at 2:27 PM, Shirley Wang <sw...@pivotal.io> wrote:
>>
>>>
>>>> When you say "icon" here, are you talking about the combo box arrow, or
>>>> icons on the items themselves? The latter are often useful if you have
>>>> items of different types in the same list.
>>>>
>>>> I think we should have the combo box arrow, to show the user they don't
>>>> have to type if they don't want to.
>>>>
>>>
>>> I'm talking about the combo box arrow. I think that's fine, but in that
>>> case users shouldn't be able type, they should only be able to select from
>>> a group of options, like this:
>>>
>>> [image: options.png]
>>> From what I understand, the text field where a user can type in is for
>>> searching through options available to them. If we know that people tend to
>>> search by typing more than scrolling, we should use the precedent for type
>>> ahead dropdowns <https://twitter.github.io/typeahead.js/examples/>.
>>>
>>
>> We are using a much older precedent - one used in Windows for 20+ years
>> (possibly other OSs too).
>>
>> Remember that some of these combo boxes contain values that are specific
>> to the database object - the user may not know what to start typing, so the
>> arrow gives them a hint that they can get a list by clicking - or they can
>> type.
>>
>> The real difference here is that we also include the x to allow the box
>> to be cleared, where Windows would add a blank option as the first thing in
>> the list typically.
>>
>>
> I see. It feels like we're at a standstill as to which precedent to use
> and neither of us is wrong. This might be a good candidate for user
> testing. We can see how people are using the x as well as learn more about
> typing / selecting an option behavior.
>
> I believe there are some dropdowns in the partition design we can use to
> test. If it doesn't make sense there, I'm fine putting this in the back
> burner until there is a good workflow to test it.
>