Re: pgAgent 4.0 patch

2018-06-07 Thread Fahar Abbas 
Hi Paresh,

Thanks for sharing pgagent linux64 installers.

On Thu, Jun 7, 2018 at 11:39 AM, Paresh More 
wrote:

> Hello Fahar,
>
> File, pgagent-4.0.0-1-linux-x64.run is uploaded @  https://uploads.
> enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6
>
> On Tue, Jun 5, 2018 at 3:10 PM, Dave Page  wrote:
>
>> Thanks, committed with those changes.
>>
>> Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS
>> Bitrock installers) from git head for Fahar to test?
>>
>> Once he's happy with them, I'll tag and build the community packages.
>>
>> Thanks!
>>
>> On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Mon, Jun 4, 2018 at 10:04 PM, Dave Page  wrote:
>>>
 Hi

 Can you review the attached please Ashesh?

>>> Hi Dave,
>>>
>>> Due to the wrong pattern in '.gitignore', it was ignoring the new file
>>> 'sql/pgagent--3.4--4.0.sql'.
>>> We should ignore only the '*.sql' in the root directory.
>>> Something like this.
>>>
>>> *$ git diff .gitignore*
>>> *diff --git a/.gitignore b/.gitignore*
>>> *index 9883354..40fe7a9 100644*
>>> *--- a/.gitignore*
>>> *+++ b/.gitignore*
>>> *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake*
>>> * Makefile*
>>> * cmake_install.cmake*
>>> * install_manifest.txt*
>>> *-pgagent*
>>> *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.*
>>> *+/pgagent*
>>> *+!/*/pgagent*
>>> * pgagent.control*
>>> *+!/*/pgagent.control*
>>> * *.log*
>>> *-*.sql*
>>> *+# Ignore '*.sql' files in root directory only.*
>>> *+/*.sql*
>>> *+!/*/*.sql*
>>>
>>>
>>> And, I am getting the following warning applying the patch.
>>>
>>> *$ git apply ~/Downloads/pgagent-4.0-update.diff*
>>> */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing
>>> whitespace.*
>>> *//*
>>> *warning: 1 line adds whitespace errors.*
>>>
>>>
>>> Otherwise - it looks good to me.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi
>>> *
>>>

 Thanks.

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> Cell :  +919922000564 |  www.enterprisedb.com
>



-- 
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com

Re: pgAgent 4.0 patch

2018-06-07 Thread Paresh More 
Hello Fahar,

File, pgagent-4.0.0-1-linux-x64.run is uploaded @
https://uploads.enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6

On Tue, Jun 5, 2018 at 3:10 PM, Dave Page  wrote:

> Thanks, committed with those changes.
>
> Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS
> Bitrock installers) from git head for Fahar to test?
>
> Once he's happy with them, I'll tag and build the community packages.
>
> Thanks!
>
> On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, Jun 4, 2018 at 10:04 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> Can you review the attached please Ashesh?
>>>
>> Hi Dave,
>>
>> Due to the wrong pattern in '.gitignore', it was ignoring the new file
>> 'sql/pgagent--3.4--4.0.sql'.
>> We should ignore only the '*.sql' in the root directory.
>> Something like this.
>>
>> *$ git diff .gitignore*
>> *diff --git a/.gitignore b/.gitignore*
>> *index 9883354..40fe7a9 100644*
>> *--- a/.gitignore*
>> *+++ b/.gitignore*
>> *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake*
>> * Makefile*
>> * cmake_install.cmake*
>> * install_manifest.txt*
>> *-pgagent*
>> *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.*
>> *+/pgagent*
>> *+!/*/pgagent*
>> * pgagent.control*
>> *+!/*/pgagent.control*
>> * *.log*
>> *-*.sql*
>> *+# Ignore '*.sql' files in root directory only.*
>> *+/*.sql*
>> *+!/*/*.sql*
>>
>>
>> And, I am getting the following warning applying the patch.
>>
>> *$ git apply ~/Downloads/pgagent-4.0-update.diff*
>> */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing
>> whitespace.*
>> *//*
>> *warning: 1 line adds whitespace errors.*
>>
>>
>> Otherwise - it looks good to me.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi
>> *
>>
>>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 

Thanks & Regards

*Paresh More*

[image: NEW-EDB-logo-4c]

Pune, India.
Cell :  +919922000564 |  www.enterprisedb.com

Re: pgAgent 4.0 patch

2018-06-05 Thread Dave Page 
Thanks, committed with those changes.

Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS
Bitrock installers) from git head for Fahar to test?

Once he's happy with them, I'll tag and build the community packages.

Thanks!

On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi 
wrote:

> On Mon, Jun 4, 2018 at 10:04 PM, Dave Page  wrote:
>
>> Hi
>>
>> Can you review the attached please Ashesh?
>>
> Hi Dave,
>
> Due to the wrong pattern in '.gitignore', it was ignoring the new file
> 'sql/pgagent--3.4--4.0.sql'.
> We should ignore only the '*.sql' in the root directory.
> Something like this.
>
> *$ git diff .gitignore*
> *diff --git a/.gitignore b/.gitignore*
> *index 9883354..40fe7a9 100644*
> *--- a/.gitignore*
> *+++ b/.gitignore*
> *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake*
> * Makefile*
> * cmake_install.cmake*
> * install_manifest.txt*
> *-pgagent*
> *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.*
> *+/pgagent*
> *+!/*/pgagent*
> * pgagent.control*
> *+!/*/pgagent.control*
> * *.log*
> *-*.sql*
> *+# Ignore '*.sql' files in root directory only.*
> *+/*.sql*
> *+!/*/*.sql*
>
>
> And, I am getting the following warning applying the patch.
>
> *$ git apply ~/Downloads/pgagent-4.0-update.diff*
> */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing
> whitespace.*
> *//*
> *warning: 1 line adds whitespace errors.*
>
>
> Otherwise - it looks good to me.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi
> *
>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: pgAgent 4.0 patch

2018-06-04 Thread Ashesh Vashi 
On Mon, Jun 4, 2018 at 10:04 PM, Dave Page  wrote:

> Hi
>
> Can you review the attached please Ashesh?
>
Hi Dave,

Due to the wrong pattern in '.gitignore', it was ignoring the new file
'sql/pgagent--3.4--4.0.sql'.
We should ignore only the '*.sql' in the root directory.
Something like this.

*$ git diff .gitignore*
*diff --git a/.gitignore b/.gitignore*
*index 9883354..40fe7a9 100644*
*--- a/.gitignore*
*+++ b/.gitignore*
*@@ -6,7 +6,12 @@ CPackSourceConfig.cmake*
* Makefile*
* cmake_install.cmake*
* install_manifest.txt*
*-pgagent*
*+# Ignore 'pgagent' & 'pgagent.control' in root directory only.*
*+/pgagent*
*+!/*/pgagent*
* pgagent.control*
*+!/*/pgagent.control*
* *.log*
*-*.sql*
*+# Ignore '*.sql' files in root directory only.*
*+/*.sql*
*+!/*/*.sql*


And, I am getting the following warning applying the patch.

*$ git apply ~/Downloads/pgagent-4.0-update.diff*
*/Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing
whitespace.*
*//*
*warning: 1 line adds whitespace errors.*


Otherwise - it looks good to me.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi
*

>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

pgAgent 4.0 patch

2018-06-04 Thread Dave Page 
Hi

Can you review the attached please Ashesh?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgagent-4.0-update.diff
Description: Binary data