Re: pgAdmin4 - Tree view icons for final reveiw
Hi Murtuza, Please see my reply inline along with the updated .svg file for tree view icons. On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Chethana, > > - The icons for Server node is missing, we will need given set of icons > for server. > 1) Basic Server icon (Disconnect state) > 2) PG (Connected state) > 3) EPAS (Connected state) > 4) GreenPlum (Connected state) > [Attaching current icons for PG & EPAS, I'm not sure about GreenPlum > server icon.] > > - I'm not sure where we will use serverbad icon from 'tree_view_Icons.svg' > file as it looks like server-group icon and not individual server. > The icon is there in the pgAdmin's icon folder and it is needed for the application > > - Icon set for Schema & Catalog (both collection and individual) looks > very similar to each other with minor colour difference, we have to look > very carefully to identify them each. > Agree with this point and come up with some updations on it. This time I have made it pretty differentiable between Schema and Catalog. > > - Why do we require two different set of icons for Tables & Columns, I > mean one for Schema and one for Catalog? > Agreed, I have kept single icon for tables and columns. > > - Icons for Partition node is same for collection and individual. > Working on it > > - Icons for Event trigger node and Trigger node are very different from > each other despite both are triggers. > Agreed, done the changes accordingly. I know this is out of context but in my own opinion these icons have > resemblance with Flat design where as rest of our application is in 2d > design, for example buttons, dialogs etc. > Yes, the icons look and feel are more towards flat and stylish now as it represents the current trend. You treat this as a first step towards making the whole application flat design from the current design. But this will happen in a long run, not on a quick basis. > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Tue, Aug 22, 2017 at 9:37 AM, Chethana Kumar < > chethana.ku...@enterprisedb.com> wrote: > >> Yes Shirley, I have already thought through on it. >> Basically, we need to have one more set of icons in white color mode so >> that we can use it on dialog headers as well. >> As the blue theme icons won't fit there. >> >> Please share your thoughts. >> >> Regards, >> Chethana kumar >> >> On Tue, Aug 22, 2017 at 4:32 AM, Shirley Wang wrote: >> >>> Hi Chethana, >>> >>> I just thought of something with these icons. What happens with the ones >>> that appear in dialog headers? In the blue bar? >>> >>> On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar < >>> chethana.ku...@enterprisedb.com> wrote: >>> Hello Team, I have applied labels for each icon for identification purpose. So please consider this copy for your feedback. *Note*: The "icon_demo.png" is attached to show case the view on webpage. Regards, Chethana kumar On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hello Team, > > Here are the revised and final icons for tree view control. > I have attached in .svg file format as well so that you can do zoom in > view at any level. > > Please share your feedback on the same. > > > Thanks and regards, > > Chethana Kumar > Principal UI/UX Designer > EnterpriseDB Corporation > > > The Postgres Database Company > > P: +91 86981 57146 <+91%2086981%2057146> > www.enterprisedb.com > -- Chethana Kumar Principal UI/UX Designer EnterpriseDB Corporation The Postgres Database Company P: +91 86981 57146 <+91%2086981%2057146> www.enterprisedb.com >>> >> >> >> -- >> Chethana Kumar >> Principal UI/UX Designer >> EnterpriseDB Corporation >> >> >> The Postgres Database Company >> >> P: +91 86981 57146 >> www.enterprisedb.com >> > > -- Chethana Kumar Principal UI/UX Designer EnterpriseDB Corporation The Postgres Database Company P: +91 86981 57146 www.enterprisedb.com
Re: pgAdmin4 - Tree view icons for final reveiw
Hi Chethana, On Wed, Aug 23, 2017 at 12:51 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Murtuza, > > Please see my reply inline along with the updated .svg file for tree view > icons. > > > On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Chethana, >> >> - The icons for Server node is missing, we will need given set of icons >> for server. >> 1) Basic Server icon (Disconnect state) >> 2) PG (Connected state) >> 3) EPAS (Connected state) >> 4) GreenPlum (Connected state) >> [Attaching current icons for PG & EPAS, I'm not sure about GreenPlum >> server icon.] >> >> - I'm not sure where we will use serverbad icon from >> 'tree_view_Icons.svg' file as it looks like server-group icon and not >> individual server. >> > The icon is there in the pgAdmin's icon folder and it is needed for the > application > Yes, we need serverbad icon which indicates the server in disconnect state but what we have on svg is same icon as server-group icon, we need icon for individual server. [image: Inline image 1] Something like this below which will differentiate individual server icon from server-group icon, [image: Inline image 6] >> - Icon set for Schema & Catalog (both collection and individual) looks >> very similar to each other with minor colour difference, we have to look >> very carefully to identify them each. >> > Agree with this point and come up with some updations on it. This time I > have made it pretty differentiable between Schema and Catalog. > >> >> - Why do we require two different set of icons for Tables & Columns, I >> mean one for Schema and one for Catalog? >> > Agreed, I have kept single icon for tables and columns. > >> >> - Icons for Partition node is same for collection and individual. >> > Working on it > >> >> - Icons for Event trigger node and Trigger node are very different from >> each other despite both are triggers. >> > Agreed, done the changes accordingly. > This is still different. *Current Event trigger icon:* [image: Inline image 4] *New **Event trigger* * Icon:* [image: Inline image 2] *Current Trigger icon:* *[image: Inline image 5]* *New Trigger Icon:* [image: Inline image 3] If you see both icons are same. *[Suggestion: Can we do similar to what we have done with View & Materialized view icons, we have added M in the icon for materialized view, Same way we can have Trigger icon and for Event trigger we can add E in the icon]* > I know this is out of context but in my own opinion these icons have >> resemblance with Flat design where as rest of our application is in 2d >> design, for example buttons, dialogs etc. >> > Yes, the icons look and feel are more towards flat and stylish now as it > represents the current trend. You treat this as a first step towards > making the whole application flat design from the current design. But > this will happen in a long run, not on a quick basis. > > >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> >> On Tue, Aug 22, 2017 at 9:37 AM, Chethana Kumar < >> chethana.ku...@enterprisedb.com> wrote: >> >>> Yes Shirley, I have already thought through on it. >>> Basically, we need to have one more set of icons in white color mode so >>> that we can use it on dialog headers as well. >>> As the blue theme icons won't fit there. >>> >>> Please share your thoughts. >>> >>> Regards, >>> Chethana kumar >>> >>> On Tue, Aug 22, 2017 at 4:32 AM, Shirley Wang wrote: >>> Hi Chethana, I just thought of something with these icons. What happens with the ones that appear in dialog headers? In the blue bar? On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hello Team, > > I have applied labels for each icon for identification purpose. So > please consider this copy for your feedback. > > *Note*: The "icon_demo.png" is attached to show case the view on > webpage. > > Regards, > Chethana kumar > > On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar < > chethana.ku...@enterprisedb.com> wrote: > >> Hello Team, >> >> Here are the revised and final icons for tree view control. >> I have attached in .svg file format as well so that you can do zoom >> in view at any level. >> >> Please share your feedback on the same. >> >> >> Thanks and regards, >> >> Chethana Kumar >> Principal UI/UX Designer >> EnterpriseDB Corporation >> >> >> The Postgres Database Company >> >> P: +91 86981 57146 <+91%2086981%2057146> >> www.enterprisedb.com >> > > > > -- > Chethana Kumar > Principal UI/UX Designer > EnterpriseDB Corporation > > > The Postgres Database Company > > P: +91 86981 57146 <+91%2086981%2057146> > www.enterprisedb.com > >>>
pgAdmin 4 commit: Syntax error while saving changes for start/end time,
Syntax error while saving changes for start/end time, weekdays, monthdays, month, hours, minutes while updating the pgAgent Job. Fixes #2657. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee20a10e9410f2ce5024a7b8e4fa758706dc52d0 Author: Surinder Kumar Modified Files -- .../servers/pgagent/schedules/static/js/pga_schedule.js | 10 +- .../servers/pgagent/templates/macros/pga_schedule.macros| 13 +++-- 2 files changed, 12 insertions(+), 11 deletions(-)
Re: Selecting tables from Browser
On Tue, Aug 22, 2017 at 5:04 PM, Shirley Wang wrote: > > > On Tue, Aug 22, 2017 at 8:27 AM Dave Page wrote: > >> On Tue, Aug 22, 2017 at 12:17 AM, Shirley Wang wrote: >> >>> Hi Rob >>> On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt >>> wrote: >>> Shirley, I have a few questions. 1. Why 20. It is a dunbar number and seems smallish but is there another reason? The browser fits about 30 ish items right now on my smallish laptop >>> screen. The question we asked ourselves is 'what is the most content we can >>> show before the browser gets unwieldy?' >>> >> >> A lot more than the proposed 20. I regularly work with ~100 tables in a >> single schema, and having to go through an additional dialogue to find what >> I need would be hugely inconvenient. >> >> I will often learn about a new database by browsing through it as well, >> jumping from table to table as I discover relationships etc. I couldn't >> imagine doing that with a filtering dialogue getting in the way. >> > > Would you be able to describe more about your use case? What role are you > taking on as you are browsing through the database, what are you trying to > accomplish and why? > Typically a support type role I guess - think 3rd line DBA support, someone coming in to troubleshoot a specific issue and starting by familiarising themselves with the database in question. > > >> >> >>> >>> You have thoughts on this? >>> >>> 1. Since this is referred to as an Object Manager I assume the same thing will eventually be available for databases, schema, partitions, etc. How do permissions work currently to limit m view of these objects? (or do they) >>> Good point about the name implying further reach than just tables. We're >>> going to change the dialog header to show 'Select tables for display', at >>> least until we decide we want to include databases, schema, partitions. >>> >>> I'm not sure how permissions works to limit the view, our assumption is >>> that permissions does though. >>> >>> Dave P do you have more insight on what permissions can limit? >>> >> >> Permissions don't limit what you would see here. They limit a roles >> ability to insert/update/delete data in tables, but not to examine the >> schema. >> > > So as a Platform Administrator (which we're defining as someone in a very > large company who works with many DBAs across multiple databases), I am not > able to restrict what schemas different user groups can see? > Nope. PostgreSQL would need row level security features on the system catalogs to do that, which it doesn't have. Whilst you can restrict users from using objects (executing functions, IUD on tables etc), you cannot stop them seeing the schema as the catalogs all allow read access. > > More specifically, if there are 500 schemas for an org, every user will be > able to see them all in the browser and changing permissions will not > impact what a DBA will see? > Correct - that's why pgAdmin 3 had the database and schema restriction options, the former of which was added to pgAdmin 4 a release or two back. We offer them for convenience though, NOT as security measures. > > >> >> >>> 1. Do you think that this would look differently if you assumptions were based on a user who writes BI reports or some other non-DBA user? Potentially, as you mentioned off the email thread, a DBA would be >>> interested in a larger list of tables than someone who writes BI reports. >>> >>> That said, since this is a problem we hear from DBAs, and they feel the >>> most pain around this, I think it's fine to focus on solving the problem >>> for them. Solving their pains will also address the pains of people who >>> write BI reports since they also feel the same issues at a lesser intensity >>> >>> We will be testing with non-DBA users though too. >>> >> >> I think this is the wrong way to approach this problem. At the very >> least, the limit of 20 objects needs to have a much higher value, and be >> configurable. >> >> I think it would be far better to implement searching of the tree as we >> had in pgAdmin 3 (and a number of users have requested we re-implement), >> > > Implementing search will definitely add value for users, we've also heard > the same requests from people during our interviews as well. However it > doesn't solve for navigating the browser when there are enough tables to > crash or significantly slow down the application. > True. If that is something users actually see, have you investigated the root cause to ensure it's not a side effect of some bad code (e.g. something that is unnecessarily O(2N))? > > 20 objects is where we're starting from, it's definitely a risky > assumption we're making and I'm not convinced it's the right number. But > for user interviews its good to have a clear point of view on a design > decision so we can test it and get feedback on it. > I will object t
Re: [pgAdmin4] [pgAgent] [Patch]: RM_ 2657 - Syntax error while saving changes when start/end time is changed from scheduler
Thanks patch applied. While reviewing the patch I have found one more issue where user won't be able to update Week Days, Month Days, Months, Hours and Minutes as well, so I have fixed it as well. On Tue, Aug 22, 2017 at 1:12 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issues fixed:* > > - Syntax error while saving changes when start/end time is updating in > Edit mode. > - The data type of `jscstart` should be `timestamptz` not `text`. > > Please find attached patch and review. > > Thanks, > Surinder > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
pgAdmin 4 commit: Unable to add/update variables for columns of a table
Unable to add/update variables for columns of a table. Fixes #2659 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe6e4686a2bf5d9d7db438d209d4d4d6783543ce Modified Files -- .../schemas/tables/column/static/js/column.js | 1 + .../servers/databases/schemas/tables/utils.py | 18 +- 2 files changed, 10 insertions(+), 9 deletions(-)
Re: [pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences
Hi Dave, On Tue, Aug 22, 2017 at 7:22 PM, Murtuza Zabuawala wrote: > > https://redmine.postgresql.org/issues/2008 > > > On Tue, Aug 22, 2017 at 7:14 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Tue, Aug 22, 2017 at 6:07 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Aug 22, 2017 at 1:30 PM, Surinder Kumar < >>> surinder.ku...@enterprisedb.com> wrote: >>> Hi *Issue:* The user seems to enter sometimes paths with quotes and sometimes add spaces which lead to failure of Backup, Restore or Maintenance utility. *Changes:* - Added a note in help string `Note: Don't add quote(s) or space(s) before or after the path.` - Remove whitespace before/after the value before it gets saved. Please find attached patch and review. >>> >>> I wonder if the more appropriate fix here would be to add a new setting >>> type (perhaps two, one for directory and one for file), which is rendered >>> with a browse button in the prefs panel, and includes real validation. >>> >> I thought of using Folder selection dialog (or Backform.FileControl) for browsing the directory path. But FileControl won't work because We do not allow the user to access file system outside his root dir (~/.pgadmin/surinder/) in server mode so this will not allow user to select bin dir path from folder select dialog as it is outside his root dir. > >>> >> Yes, the suggested way is a better way. >> I will check what changes we have to made in preferences code to add >> support for new setting type and validations. >> >>> >>> Stripping spaces and warning about quotes seems like it's just kicking >>> the basic problem down the road a few feet. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >
