Re: Fix for RM2811
Hi Dave, -- On Mon, Nov 27, 2017 at 9:20 PM, Harshal Dhumal wrote: > > > On Mon, Nov 27, 2017 at 6:32 PM, Dave Page wrote: > >> Hi >> >> On Mon, Nov 27, 2017 at 12:29 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find updated patch. >>> >>> -- >>> *Harshal Dhumal* >>> *Sr. Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Mon, Nov 27, 2017 at 5:28 PM, Dave Page wrote: >>> Hi On Mon, Nov 27, 2017 at 11:23 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix RM2811 > > Issue was caused due to assumption made when current position in log > file while reading it reaches to last line then > we were assuming process is finished. However this is not the case. > Background process may be busy performing > some other task and logs might not be logged to file immediately. So > we should also check process exit code along > with above condition. > > Apart from above this patch also includes minor fix related to status > text colour. > Seems to work nicely, except that the text scrolls out of view almost immediately. Can you fix it to jump to the end of the text when more is appended please? Fixed. >>> >> >> Looks good - though when I tested with a large database, it got to a >> point and then just stopped adding more data to the logs (in fact, even the >> err file in the process_log directory stopped receiving updates). However, >> the database carried on being dumped, and it had definitely moved past the >> point it was up to in the logs. I've attached all the output received - it >> literally stops at the 'c'. >> >> I've committed the patch, but can you see if you can reproduce this >> please? >> > Sure Dave. I'll have a look at this once. > I tried backing up server with size ~1.3 GB multiple times and was able see log till the end. Thanks! >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > >
Re: Fix for RM2811
On Tue, Nov 28, 2017 at 9:10 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > -- > On Mon, Nov 27, 2017 at 9:20 PM, Harshal Dhumal > wrote: > >> >> >> On Mon, Nov 27, 2017 at 6:32 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Nov 27, 2017 at 12:29 PM, Harshal Dhumal < >>> harshal.dhu...@enterprisedb.com> wrote: >>> Hi Dave, Please find updated patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Nov 27, 2017 at 5:28 PM, Dave Page wrote: > Hi > > On Mon, Nov 27, 2017 at 11:23 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch to fix RM2811 >> >> Issue was caused due to assumption made when current position in log >> file while reading it reaches to last line then >> we were assuming process is finished. However this is not the case. >> Background process may be busy performing >> some other task and logs might not be logged to file immediately. So >> we should also check process exit code along >> with above condition. >> >> Apart from above this patch also includes minor fix related to status >> text colour. >> > > Seems to work nicely, except that the text scrolls out of view almost > immediately. Can you fix it to jump to the end of the text when more is > appended please? > > Fixed. >>> >>> Looks good - though when I tested with a large database, it got to a >>> point and then just stopped adding more data to the logs (in fact, even the >>> err file in the process_log directory stopped receiving updates). However, >>> the database carried on being dumped, and it had definitely moved past the >>> point it was up to in the logs. I've attached all the output received - it >>> literally stops at the 'c'. >>> >>> I've committed the patch, but can you see if you can reproduce this >>> please? >>> >> Sure Dave. I'll have a look at this once. >> > > I tried backing up server with size ~1.3 GB multiple times and was able > see log till the end. > Hmm, weird. I was running on Mac, not sure if that makes a difference. I'll test again when I get a minute. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Illustrate how to set the default mail sender name.
Illustrate how to set the default mail sender name. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10c8befb7133e9c237fc9aab96419aca1cc3262d Modified Files -- web/config.py | 4 1 file changed, 4 insertions(+)
pgAdmin 4 commit: Cleanup properly after running the Foreign Table test
Cleanup properly after running the Foreign Table test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=035c134fede1bf5df4dda84fd3a08b084f5b7dc7 Author: Navnath Gadakh Modified Files -- .../foreign_tables/tests/test_foreign_table_add.py | 10 +++-- .../foreign_tables/tests/test_foreign_table_get.py | 6 +- .../foreign_tables/tests/test_foreign_table_put.py | 6 +- .../schemas/foreign_tables/tests/utils.py | 25 ++ 4 files changed, 43 insertions(+), 4 deletions(-)
Re: [pgAdmin4][Patch]: RM-2859: Can't create new user
On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 4:58 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page >> wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi Dave, On Fri, Nov 24, 2017 at 3:21 PM, Dave Page wrote: > > > On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page > > wrote: >> >>> Hi >>> >>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi, Please find the attached patch to fix RM #2859: Can't create new user. The "User Management" dialogue footer was overlapping the back-grid table which has been fixed. >>> >>> If my screen is too small, it now looks like the attached >>> screenshot, which is really quite ugly. >>> >>> If we don't leave the bottom blank space then in case of >> error the error-message will shown on the grid itself and user >> can't >> perform any task. >> Please refer the attached screen-shot for the same. >> > > Right, but we also can't have that space left blank like that. > Can't we extend the scroll range of the grid? In other words, > always > include space for an extra row or so, so it can scroll above the > error > message, when, and only when a message is shown? > > Please find the attached screen-shot, If we always include an extra row. Suggestion please. >>> >>> I think that's much better, though still not ideal. What if we >>> made the error messages closable like other notifications? >>> >>> The error-messages in pgAdmin 4 are not closable, so it will not >> go with the flow. >> > > I meant to do it globally. > > Should I create the separate case for this? >>> >>> No, I don't think there's any need for that. >>> >>> Does it seem like it would solve the problem appropriately? >>> >>> >> It would lead us to more complexity >> 1. How can we keep track of the closed error messages for multiple >> fields? >> > > Do we need to? > > >> 2. We have validated backbone model on focus out/change, so we need >> to change the basic error model. >> > > I'm not sure why. Can't we just have an X button on the error panel > that will hide it? If another error occurs (e.g. because the user changes > focus), just re-display it. > > This means, if the error message is displayed for the field 1 and after closing if we go ahead without filling up the valid data, on the focus out; the same error message will be shown. >>> >>> Yes. >>> >>> I was thinking; if we have closed the error message for the field 1, then it will not display any kind of message for that particular field. So, I have mentioned about the complexity. >>> >>> I'm not convinced we need that level of complexity. >>> >>> Can you whip up a PoC so we can see how it behaves? >>> >>> Please find the attached patch. > > This patch includes: > - The fix for this RM > - Close button for the error message for the User management module > - Close button for other node modules like server , schema etc > I like that - it see
Re: [pgAdmin4][Patch]: RM-2859: Can't create new user
On Tue, Nov 28, 2017 at 3:40 PM, Dave Page wrote: > > > On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 4:58 PM, Dave Page wrote: >>> On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 4:47 PM, Dave Page wrote: > >> >> >> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page >>> wrote: >>> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 2:59 PM, Dave Page > wrote: > >> >> >> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page >>> wrote: >>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Nov 24, 2017 at 3:21 PM, Dave Page > wrote: > >> >> >> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page < >>> dp...@pgadmin.org> wrote: >>> Hi On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #2859: Can't > create new user. > > The "User Management" dialogue footer was overlapping the > back-grid table which has been fixed. > If my screen is too small, it now looks like the attached screenshot, which is really quite ugly. If we don't leave the bottom blank space then in case of >>> error the error-message will shown on the grid itself and user >>> can't >>> perform any task. >>> Please refer the attached screen-shot for the same. >>> >> >> Right, but we also can't have that space left blank like >> that. Can't we extend the scroll range of the grid? In other >> words, always >> include space for an extra row or so, so it can scroll above the >> error >> message, when, and only when a message is shown? >> >> > Please find the attached screen-shot, If we always include an > extra row. > Suggestion please. > I think that's much better, though still not ideal. What if we made the error messages closable like other notifications? The error-messages in pgAdmin 4 are not closable, so it will >>> not go with the flow. >>> >> >> I meant to do it globally. >> >> Should I create the separate case for this? > No, I don't think there's any need for that. Does it seem like it would solve the problem appropriately? >>> It would lead us to more complexity >>> 1. How can we keep track of the closed error messages for multiple >>> fields? >>> >> >> Do we need to? >> >> >>> 2. We have validated backbone model on focus out/change, so we need >>> to change the basic error model. >>> >> >> I'm not sure why. Can't we just have an X button on the error panel >> that will hide it? If another error occurs (e.g. because the user changes >> focus), just re-display it. >> >> > This means, if the error message is displayed for the field 1 and > after closing if we go ahead without filling up the valid data, on the > focus out; the same error message will be shown. > Yes. > > I was thinking; if we have closed the error message for the field 1, > then it will not display any kind of message for that particular field. > So, > I have mentioned about the complexity. > I'm not convinced we need that level of complexity. Can you whip up a PoC so we can see how it behaves?
Re: [pgAdmin4][Patch]: Allow user to change their password without leaving application
Thanks, applied. On Tue, Nov 28, 2017 at 10:00 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which will allow users to change their pgAdmin4 password without > leaving the application. > RM#2891 > > Also updated docs accordingly. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: Allow changing of the users password without leaving
Allow changing of the users password without leaving the app. Fixes #2891 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ae4a03784fa73e886be34d6aca553dbfc8a42a7 Author: Murtuza Zabuawala Modified Files -- docs/en_US/change_user_password.rst| 25 ++ docs/en_US/getting_started.rst | 19 ++--- docs/en_US/images/change_user_password.png | Bin 0 -> 352671 bytes web/pgadmin/__init__.py| 6 ++ web/pgadmin/browser/templates/browser/index.html | 8 +- web/pgadmin/templates/security/fields.html | 2 +- .../user_management/static/js/user_management.js | 85 + 7 files changed, 134 insertions(+), 11 deletions(-)
Re: [pgAdmin4][Patch]: RM-2859: Can't create new user
Hi Dave, Please find the attached updated patch, which includes: - The fix for this RM - Close button for the error message, which is applicable globally Thanks, Khushboo On Tue, Nov 28, 2017 at 4:18 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Nov 28, 2017 at 3:40 PM, Dave Page wrote: > >> >> >> On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> On Mon, Nov 27, 2017 at 4:58 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> On Mon, Nov 27, 2017 at 4:13 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page >> wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page wrote: > > > On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page > > wrote: >> >>> >>> >>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page < dp...@pgadmin.org> wrote: > Hi > > On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM #2859: Can't >> create new user. >> >> The "User Management" dialogue footer was overlapping the >> back-grid table which has been fixed. >> > > If my screen is too small, it now looks like the attached > screenshot, which is really quite ugly. > > If we don't leave the bottom blank space then in case of error the error-message will shown on the grid itself and user can't perform any task. Please refer the attached screen-shot for the same. >>> >>> Right, but we also can't have that space left blank like >>> that. Can't we extend the scroll range of the grid? In other >>> words, always >>> include space for an extra row or so, so it can scroll above >>> the error >>> message, when, and only when a message is shown? >>> >>> >> Please find the attached screen-shot, If we always include an >> extra row. >> Suggestion please. >> > > I think that's much better, though still not ideal. What if we > made the error messages closable like other notifications? > > The error-messages in pgAdmin 4 are not closable, so it will not go with the flow. >>> >>> I meant to do it globally. >>> >>> Should I create the separate case for this? >> > > No, I don't think there's any need for that. > > Does it seem like it would solve the problem appropriately? > > It would lead us to more complexity 1. How can we keep track of the closed error messages for multiple fields? >>> >>> Do we need to? >>> >>> 2. We have validated backbone model on focus out/change, so we need to change the basic error model. >>> >>> I'm not sure why. Can't we just have an X button on the error panel >>> that will hide it? If another error occurs (e.g. because the user >>> changes >>> focus), just re-display it. >>> >>> >> This means, if the error message is displayed for the field 1 and >> after closing if we go ahead without filling up the valid data, on the >>>
[pgAdmin4][Patch]: Add basic JSON formatting - Query tool
Hi,
PFA minor patch which will add basic formatting in our custom SlickGrid
JSON editor.
RM#2748
I have updated RM with sample sql for testing.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/static/js/slickgrid/editors.js
b/web/pgadmin/static/js/slickgrid/editors.js
index ab0bff0..0b38da5 100644
--- a/web/pgadmin/static/js/slickgrid/editors.js
+++ b/web/pgadmin/static/js/slickgrid/editors.js
@@ -387,12 +387,12 @@
this.loadValue = function (item) {
var data = defaultValue = item[args.column.field];
if (data && typeof data === "object" && !Array.isArray(data)) {
-data = JSON.stringify(data);
+data = JSON.stringify(data, null, 4);
} else if (Array.isArray(data)) {
var temp = [];
$.each(data, function(i, val) {
if (typeof val === "object") {
-temp.push(JSON.stringify(val));
+temp.push(JSON.stringify(val, null, 4));
} else {
temp.push(val)
}
@@ -722,12 +722,12 @@
this.loadValue = function (item) {
var data = defaultValue = item[args.column.field];
if (typeof data === "object" && !Array.isArray(data)) {
-data = JSON.stringify(data);
+data = JSON.stringify(data, null, 4);
} else if (Array.isArray(data)) {
var temp = [];
$.each(data, function(i, val) {
if (typeof val === "object") {
-temp.push(JSON.stringify(val));
+temp.push(JSON.stringify(val, null, 4));
} else {
temp.push(val)
}
pgAdmin 4 commit: Allow form validation messages to be close in case th
Allow form validation messages to be close in case the eclipse anything on the form. Fixes #2859 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5bfa450a5fd261b2cd8c74f464d0b4a6acbeadac Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/static/js/node.js | 6 ++ web/pgadmin/browser/static/js/wizard.js | 8 web/pgadmin/static/css/bootstrap.overrides.css| 10 ++ web/pgadmin/static/scss/_alert.scss | 2 -- .../tools/user_management/static/js/user_management.js| 15 ++- 5 files changed, 34 insertions(+), 7 deletions(-)
Re: [pgAdmin4][Patch]: RM-2859: Can't create new user
Thanks, patch applied! On Tue, Nov 28, 2017 at 11:22 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached updated patch, which includes: > > - The fix for this RM > - Close button for the error message, which is applicable globally > > Thanks, > Khushboo > > On Tue, Nov 28, 2017 at 4:18 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Nov 28, 2017 at 3:40 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 4:58 PM, Dave Page wrote: > >> >> >> On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 4:47 PM, Dave Page >>> wrote: >>> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 4:13 PM, Dave Page > wrote: > >> >> >> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page >>> wrote: >>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 2:20 PM, Dave Page > wrote: > >> >> >> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page < >>> dp...@pgadmin.org> wrote: >>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Nov 23, 2017 at 2:58 PM, Dave Page < > dp...@pgadmin.org> wrote: > >> Hi >> >> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix RM #2859: Can't >>> create new user. >>> >>> The "User Management" dialogue footer was overlapping >>> the back-grid table which has been fixed. >>> >> >> If my screen is too small, it now looks like the attached >> screenshot, which is really quite ugly. >> >> If we don't leave the bottom blank space then in case of > error the error-message will shown on the grid itself and > user can't > perform any task. > Please refer the attached screen-shot for the same. > Right, but we also can't have that space left blank like that. Can't we extend the scroll range of the grid? In other words, always include space for an extra row or so, so it can scroll above the error message, when, and only when a message is shown? >>> Please find the attached screen-shot, If we always include >>> an extra row. >>> Suggestion please. >>> >> >> I think that's much better, though still not ideal. What if >> we made the error messages closable like other notifications? >> >> The error-messages in pgAdmin 4 are not closable, so it will > not go with the flow. > I meant to do it globally. Should I create the separate case for this? >>> >> >> No, I don't think there's any need for that. >> >> Does it seem like it would solve the problem appropriately? >> >> > It would lead us to more complexity > 1. How can we keep track of the closed error messages for multiple > fields? > Do we need to? > 2. We have validated backbone model on focus out/change, so we > need to change the basic error model. > I'm not sure why. Can't we just have an X button on the
pgAdmin 4 commit: Format JSON/JSONB nicely when displaying it in the gr
Format JSON/JSONB nicely when displaying it in the grid editor pop-up. Fixes #2748 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=362bd15c8ef3815e0ebc5f699be09c6afc5057f3 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/js/slickgrid/editors.js | 8 1 file changed, 4 insertions(+), 4 deletions(-)
Re: [pgAdmin4][Patch]: Add basic JSON formatting - Query tool
Thanks, applied. On Tue, Nov 28, 2017 at 1:14 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch which will add basic formatting in our custom SlickGrid > JSON editor. > RM#2748 > > I have updated RM with sample sql for testing. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
