[pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features

2018-09-06 Thread Akshay Joshi
Hi Hackers,

I have implemented the Feature #3564 pgAdmin4 should have shortcut tools
bar for frequently used features. As per discussion I have added buttons on
the "Browser" Panel.

Thanks to *Ashesh* as he has modified the wcDocker code and added following:

   - Added support to specify parent class which will be added to the
   parent node of the wcFrameButton. This is required for the
   identification of the button and enable/disable it.
   - Added support to enable/disable the wcFrameButton using label.

Attached is the patch file which contains implementation and feature test.
There is a change in package.json file, so need to run yarn install after
applying the patch.

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


RM_3564.patch
Description: Binary data


Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features

2018-09-06 Thread Ashesh Vashi
On Thu, Sep 6, 2018 at 5:49 PM Akshay Joshi 
wrote:

> Hi Hackers,
>
> I have implemented the Feature #3564 pgAdmin4 should have shortcut tools
> bar for frequently used features. As per discussion I have added buttons on
> the "Browser" Panel.
>
Reviewer/Developers need to run the following command to get the latest
wcdocker.
*yarn install --update*

-- Thanks, Ashesh

>
> Thanks to *Ashesh* as he has modified the wcDocker code and added
> following:
>
>- Added support to specify parent class which will be added to the
>parent node of the wcFrameButton. This is required for the
>identification of the button and enable/disable it.
>- Added support to enable/disable the wcFrameButton using label.
>
> Attached is the patch file which contains implementation and feature test.
> There is a change in package.json file, so need to run yarn install after
> applying the patch.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


pgAdmin 4 commit: Tag REL-3_3 has been created.

2018-09-06 Thread Dave Page
Tag REL-3_3 has been created.
View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-3_3

Log Message
---
Tag 3.3

pgAdmin 4 v3.3 released

2018-09-06 Thread Akshay Joshi
The pgAdmin Development Team are pleased to announce pgAdmin 4 version 3.3.
This release of pgAdmin 4 includes over 21 bug fixes and new features. For
more details please see the release notes at:

https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_3_3.html.

pgAdmin is the leading Open Source graphical management tool for
PostgreSQL. For more information, please see:

https://www.pgadmin.org/

Notable changes in this release include:

* Add a geometry viewer that can render PostGIS data on a blank canvas or
various map sources.


Builds for Windows and macOS are available now, along with a Python Wheel,
Docker Container and source code tarball from:

https://www.pgadmin.org/download/

RPM and DEB packages are expected to be available on the postgresql.org
repositories within the next few days.

-- 
Akshay Joshi
pgAdmin Project


pgAdmin 4 commit: Doc updates for optional data point markers and mouse

2018-09-06 Thread Dave Page
Doc updates for optional data point markers and mouse-over tooltips to display 
values on graphs. Fixes #3514

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8f88443e153974b0640635712a120ce3d0427428
Author: Aditya Toshniwal 

Modified Files
--
.../en_US/images/preferences_dashboard_display.png | Bin 84310 -> 133118 bytes
docs/en_US/images/preferences_dashboard_graphs.png | Bin 90077 -> 161718 bytes
docs/en_US/preferences.rst |   6 +-
3 files changed, 5 insertions(+), 1 deletion(-)



Re: [pgAdmin4][RM3514] Bullets and tooltips for charts

2018-09-06 Thread Dave Page
Thanks!

On Thu, Sep 6, 2018 at 9:50 AM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch for doc and screenshot updates.
> Kindly review.
>
> On Wed, Sep 5, 2018 at 9:56 PM Dave Page  wrote:
>
>> Thanks - patch applied.
>>
>> However, I realised as I hit push that there was no doc update for the
>> Preferences panel. Can you send that and any updated screenshots please?
>>
>> Thanks!
>>
>> On Wed, Sep 5, 2018 at 2:42 PM, Aditya Toshniwal > enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to:
>>> 1) Add bullets and tooltips to dashboard graphs. Can be enabled/disabled
>>> from Preferences -> Dashboards -> Display.
>>> 2) Fixes RM3516 - Closing the Dashboard tab no longer stops the queries
>>> being executed.
>>> 3) Separated charting library Flotr2 from dashboard. Possible test cases
>>> added.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgAdmin 4 commit: Remove package-lock.json to stop Yarn bleating.

2018-09-06 Thread Dave Page
Remove package-lock.json to stop Yarn bleating.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f1b588c69beba7a34fc414df78efefcb342dd92

Modified Files
--
web/package-lock.json | 3 ---
1 file changed, 3 deletions(-)



Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features

2018-09-06 Thread Dave Page
Hi

On Thu, Sep 6, 2018 at 1:19 PM, Akshay Joshi 
wrote:

> Hi Hackers,
>
> I have implemented the Feature #3564 pgAdmin4 should have shortcut tools
> bar for frequently used features. As per discussion I have added buttons on
> the "Browser" Panel.
>
> Thanks to *Ashesh* as he has modified the wcDocker code and added
> following:
>
>- Added support to specify parent class which will be added to the
>parent node of the wcFrameButton. This is required for the
>identification of the button and enable/disable it.
>- Added support to enable/disable the wcFrameButton using label.
>
> Attached is the patch file which contains implementation and feature test.
> There is a change in package.json file, so need to run yarn install after
> applying the patch.
>

Very nice!

Couple of pieces of feedback:

- Are there any relevant docs that need updating?

- Can we make the buttons look like regular toolbar buttons (only smaller)?
They look quite different from the toolbar buttons on the query tool and
debugger, and I think should have the same stying (not that of the tabset
control buttons which I'd argue are semantically different in purpose).

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company