[pgAdmin4][RM3866] No way to add row to a table in v4.0

2019-01-11 Thread Aditya Toshniwal
Hi Hackers,

Attached is the patch to fix the issue where last row of data grid is not
visible.
Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


RM3866.patch
Description: Binary data


Re: pgAdmin4 v4.0 candidate builds

2019-01-11 Thread Dave Page
Thanks Anthony!

On Mon, Jan 7, 2019 at 8:17 PM Anthony DeBarros  wrote:

> The redesign is nice and clean. Great job, hackers!
>
>
>
> On Mon, Jan 7, 2019 at 7:27 AM Akshay Joshi 
> wrote:
>
>> Hi All,
>>
>> pgAdmin4 v4.0 candidate builds and source can be found at
>> https://developer.pgadmin.org/builds/2019-01-07-1
>>
>> Fahar, can you please verify it for release on Thursday.
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgAdmin 4 commit: Fix SQL generated for tables with inherited columns.

2019-01-11 Thread Dave Page
Fix SQL generated for tables with inherited columns. Fixes #3505

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=252e05ef29d1490d0ac1085c4f3d135b37b0f341
Author: Akshay Joshi 

Modified Files
--
docs/en_US/release_notes_4_1.rst| 1 +
.../databases/schemas/tables/templates/table/sql/default/create.sql | 6 +++---
.../databases/schemas/tables/templates/table/sql/default/sql.sql| 1 -
.../schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql | 6 +++---
4 files changed, 7 insertions(+), 7 deletions(-)



Re: [pgAdmin4][Patch] - RM 3505 Incorrect SQL generated for tables created using inherited columns

2019-01-11 Thread Dave Page
Thanks, patch applied.

On Thu, Jan 10, 2019 at 2:56 PM Akshay Joshi
 wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM #3505 Incorrect SQL generated for tables 
> created using inherited columns.
>
> Please review it.
>
> --
> Akshay Joshi
> Sr. Software Architect
>
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgAdmin 4 commit: Make the browser more robust in the face of multibyte

2019-01-11 Thread Dave Page
Make the browser more robust in the face of multibyte characters in SQL_ASCII 
databases. Fixes #3877

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d641b47adbc3dfd3203e857e75dfeed5d478ac84
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_1.rst|  1 +
web/pgadmin/utils/driver/psycopg2/connection.py | 20 ---
web/pgadmin/utils/driver/psycopg2/cursor.py |  5 ++-
web/pgadmin/utils/driver/psycopg2/encoding.py   | 44 +++--
web/pgadmin/utils/driver/psycopg2/typecast.py   |  9 +++--
5 files changed, 45 insertions(+), 34 deletions(-)



Re: [pgAdmin4][patch] SQL_ASCII database related codec fix

2019-01-11 Thread Dave Page
Thanks, applied.

On Thu, Jan 10, 2019 at 6:01 PM Aditya Toshniwal
 wrote:
>
> Hi Hackers,
>
> Attached is the patch to make SQL_ASCII database handling on pgAdmin more 
> robust.
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Build failed in Jenkins: pgadmin4-master-python36 #856

2019-01-11 Thread pgAdmin 4 Jenkins
See 


Changes:

[Dave Page] Fix SQL generated for tables with inherited columns. Fixes #3505

[Dave Page] Make the browser more robust in the face of multibyte characters in

--
[...truncated 447 B...]
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision d641b47adbc3dfd3203e857e75dfeed5d478ac84 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d641b47adbc3dfd3203e857e75dfeed5d478ac84
Commit message: "Make the browser more robust in the face of multibyte 
characters in SQL_ASCII databases. Fixes #3877"
 > git rev-list --no-walk 8fb340d23b00646e8bd5cdcbab11442b03bfa701 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.6

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python36] $ /bin/sh -xe /tmp/jenkins9168760766804898171.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.6 virtual environment...

Using base prefix '/usr/local/python-3.6'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.6/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring psycopg2: markers 'python_version < "2.7"' don't match your environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring python-dateutil: markers 'python_version < "2.7"' don't match your 
environment
Ignoring SQLAlchemy: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-Security: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-BabelEx: markers 'python_version < "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting extras==1.0.0 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/03/e9/e915af1f97914cd0bc021e125fd1bfd4106de614a275e4b6866dd9a209ac/extras-1.0.0-py2.py3-none-any.whl
Collecting fixtures==3.0.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/a8/28/7eed6bf76792f418029a18d5b2ace87ce7562927cdd00f1cefe481cd148f/fixtures-3.0.0-py2.py3-none-any.whl
Collecting Flask==0.12.4 (from -r requirements.txt (line 9))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 10))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 11))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 12))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 14))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting html5lib==1.0.1 (from -r requirements.txt (line 17))
  Using cached 
https://files.pythonhosted.org/packages/a5/62/bbd2be0e7943ec8504b517e62bab011b4946e1258842bc159e5dfde15b96/html5lib-1.0.1-py2.py3-none-any.whl
Collecting linecache2==1.0.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/c7/a3/c5da2a44c85bfbb6eebcfc1dde24933f8704441b98fdde6528f4831757a6/linecache2-1.0.0-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 19))
  Using cached 
https:

Build failed in Jenkins: pgadmin4-master-python27 #865

2019-01-11 Thread pgAdmin 4 Jenkins
See 


Changes:

[Dave Page] Fix SQL generated for tables with inherited columns. Fixes #3505

[Dave Page] Make the browser more robust in the face of multibyte characters in

--
[...truncated 1.24 KB...]
PYTHON_VERSION=2.7

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python27] $ /bin/sh -xe /tmp/jenkins2144224876797090348.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 2.7 virtual environment...

New python executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-2.7/bin/python
Ignoring psycopg2: markers 'python_version < "2.7"' don't match your environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring python-dateutil: markers 'python_version < "2.7"' don't match your 
environment
Ignoring SQLAlchemy: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-Security: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-BabelEx: markers 'python_version < "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting extras==1.0.0 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/03/e9/e915af1f97914cd0bc021e125fd1bfd4106de614a275e4b6866dd9a209ac/extras-1.0.0-py2.py3-none-any.whl
Collecting fixtures==3.0.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/a8/28/7eed6bf76792f418029a18d5b2ace87ce7562927cdd00f1cefe481cd148f/fixtures-3.0.0-py2.py3-none-any.whl
Collecting Flask==0.12.4 (from -r requirements.txt (line 9))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 10))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 11))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 12))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 14))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting html5lib==1.0.1 (from -r requirements.txt (line 17))
  Using cached 
https://files.pythonhosted.org/packages/a5/62/bbd2be0e7943ec8504b517e62bab011b4946e1258842bc159e5dfde15b96/html5lib-1.0.1-py2.py3-none-any.whl
Collecting linecache2==1.0.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/c7/a3/c5da2a44c85bfbb6eebcfc1dde24933f8704441b98fdde6528f4831757a6/linecache2-1.0.0-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 19))
  Using cached 
https://files.pythonhosted.org/packages/ee/a7/d6d238d927df355d4e4e000670342ca4705a72f0bf694027cf67d9bcf5af/passlib-1.7.1-py2.py3-none-any.whl
Collecting pbr==3.1.1 (from -r requirements.txt (line 20))
  Using cached 
https://files.pythonhosted.org/packages/0c/5d/b077dbf309993d52c1d71e6bf6fe443a8029ea215135ebbe0b1b10e7aefc/pbr-3.1.1-py2.py3-none-any.whl
Collecting pycrypto>=2.6.1 (from -r requirements.txt (line 21))
Collecting pyrsistent==0.14.2 (from -r requirements.txt (line 22))
Collecting python-mimeparse==1.6.0 (from -r requirements.txt (line 23))
  Using cached 
https://files.pythonhosted.org/packages/26/2e/03bce213a9bf02a2750dcb04e761785e9c763fc11071edc4b447eacbb842/python_mimeparse-1.6.0-py2.py3-none-any.whl
Collecting pytz==2018.3 (from -r requirements.txt (line 24))
  Using cached 
https://files.pythonhosted.org/packages/3c/80/32e98784a8647880dedf1f6bf8e2c91b195fe18fdecc6767dcf5104598d6/pytz-2018.3-py2.py3-none-any.whl
Collecting simplejson==3.13.2 (from -r requirements.txt (line 25))
Collecting six>=1.11.0 (from -r requirements.txt (line 26))
  Using cached 
https://files.pythonhosted.org/packages/73/

pgAdmin 4 commit: Fix PEP-8 issues.

2019-01-11 Thread Dave Page
Fix PEP-8 issues.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14f462e9dc0ed360a4247d9dd7a4b57e8c479803

Modified Files
--
web/pgadmin/utils/driver/psycopg2/connection.py | 2 +-
web/pgadmin/utils/driver/psycopg2/encoding.py   | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)



Build failed in Jenkins: pgadmin4-master-python35 #852

2019-01-11 Thread pgAdmin 4 Jenkins
See 


Changes:

[Dave Page] Fix SQL generated for tables with inherited columns. Fixes #3505

[Dave Page] Make the browser more robust in the face of multibyte characters in

--
[...truncated 447 B...]
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision d641b47adbc3dfd3203e857e75dfeed5d478ac84 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d641b47adbc3dfd3203e857e75dfeed5d478ac84
Commit message: "Make the browser more robust in the face of multibyte 
characters in SQL_ASCII databases. Fixes #3877"
 > git rev-list --no-walk 8fb340d23b00646e8bd5cdcbab11442b03bfa701 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.5

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python35] $ /bin/sh -xe /tmp/jenkins7848451419167600537.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.5 virtual environment...

Using base prefix '/usr/local/python-3.5'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.5/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring psycopg2: markers 'python_version < "2.7"' don't match your environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring python-dateutil: markers 'python_version < "2.7"' don't match your 
environment
Ignoring SQLAlchemy: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-Security: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-BabelEx: markers 'python_version < "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting extras==1.0.0 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/03/e9/e915af1f97914cd0bc021e125fd1bfd4106de614a275e4b6866dd9a209ac/extras-1.0.0-py2.py3-none-any.whl
Collecting fixtures==3.0.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/a8/28/7eed6bf76792f418029a18d5b2ace87ce7562927cdd00f1cefe481cd148f/fixtures-3.0.0-py2.py3-none-any.whl
Collecting Flask==0.12.4 (from -r requirements.txt (line 9))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 10))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 11))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 12))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 14))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting html5lib==1.0.1 (from -r requirements.txt (line 17))
  Using cached 
https://files.pythonhosted.org/packages/a5/62/bbd2be0e7943ec8504b517e62bab011b4946e1258842bc159e5dfde15b96/html5lib-1.0.1-py2.py3-none-any.whl
Collecting linecache2==1.0.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/c7/a3/c5da2a44c85bfbb6eebcfc1dde24933f8704441b98fdde6528f4831757a6/linecache2-1.0.0-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 19))
  Using cached 
https:

Build failed in Jenkins: pgadmin4-master-python34 #855

2019-01-11 Thread pgAdmin 4 Jenkins
See 


Changes:

[Dave Page] Make the browser more robust in the face of multibyte characters in

--
[...truncated 123 B...]
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.postgresql.org/git/pgadmin4.git # 
 > timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.postgresql.org/git/pgadmin4.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision d641b47adbc3dfd3203e857e75dfeed5d478ac84 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d641b47adbc3dfd3203e857e75dfeed5d478ac84
Commit message: "Make the browser more robust in the face of multibyte 
characters in SQL_ASCII databases. Fixes #3877"
 > git rev-list --no-walk 252e05ef29d1490d0ac1085c4f3d135b37b0f341 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.4

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python34] $ /bin/sh -xe /tmp/jenkins4972624615913782070.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.4 virtual environment...

Using base prefix '/usr/local/python-3.4'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/local/python-3.4/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring psycopg2: markers 'python_version < "2.7"' don't match your environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring python-dateutil: markers 'python_version < "2.7"' don't match your 
environment
Ignoring SQLAlchemy: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-Security: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-BabelEx: markers 'python_version < "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting extras==1.0.0 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/03/e9/e915af1f97914cd0bc021e125fd1bfd4106de614a275e4b6866dd9a209ac/extras-1.0.0-py2.py3-none-any.whl
Collecting fixtures==3.0.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/a8/28/7eed6bf76792f418029a18d5b2ace87ce7562927cdd00f1cefe481cd148f/fixtures-3.0.0-py2.py3-none-any.whl
Collecting Flask==0.12.4 (from -r requirements.txt (line 9))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 10))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 11))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 12))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 14))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting html5lib==1.0.1 (from -r requirements.txt (line 17))
  Using cached 
https://files.pythonhosted.org/packages/a5/62/bbd2be0e7943ec8504b517e62bab011b4946e1258842bc159e5dfde15b96/html5lib-1.0.1-py2.py3-none-any.whl
Collecting linecache2==1.0.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/

Build failed in Jenkins: pgadmin4-master-python37 #98

2019-01-11 Thread pgAdmin 4 Jenkins
See 


Changes:

[Dave Page] Fix SQL generated for tables with inherited columns. Fixes #3505

[Dave Page] Make the browser more robust in the face of multibyte characters in

--
[...truncated 607 B...]
 > git fetch --tags --progress git://git.postgresql.org/git/pgadmin4.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision d641b47adbc3dfd3203e857e75dfeed5d478ac84 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d641b47adbc3dfd3203e857e75dfeed5d478ac84
Commit message: "Make the browser more robust in the face of multibyte 
characters in SQL_ASCII databases. Fixes #3877"
 > git rev-list --no-walk 8fb340d23b00646e8bd5cdcbab11442b03bfa701 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the 
SCM step.
[EnvInject] - Injecting as environment variables the properties content 
PYTHON_VERSION=3.7

[EnvInject] - Variables injected successfully.
[pgadmin4-master-python37] $ /bin/sh -xe /tmp/jenkins3078294608689626201.sh
+ 
EXECUTING: Create pgAdmin config

EXECUTING: Python tests

Creating Python 3.7 virtual environment...

Using base prefix '/usr/local/python-3.7'
New python executable in 

Also creating executable in 

Installing setuptools, pip, wheel...done.
/usr/lib/python2.7/site-packages/virtualenv.py:1039: DeprecationWarning: the 
imp module is deprecated in favour of importlib; see the module's documentation 
for alternative uses
  import imp
Running virtualenv with interpreter /usr/local/python-3.7/bin/python3
Ignoring importlib: markers 'python_version <= "2.7"' don't match your 
environment
Ignoring psycopg2: markers 'python_version < "2.7"' don't match your environment
Ignoring Flask-Script: markers 'python_version < "2.7"' don't match your 
environment
Ignoring ordereddict: markers 'python_version < "2.7"' don't match your 
environment
Ignoring python-dateutil: markers 'python_version < "2.7"' don't match your 
environment
Ignoring SQLAlchemy: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-Security: markers 'python_version < "2.7"' don't match your 
environment
Ignoring Flask-BabelEx: markers 'python_version < "2.7"' don't match your 
environment
Collecting blinker==1.4 (from -r requirements.txt (line 6))
Collecting extras==1.0.0 (from -r requirements.txt (line 7))
  Using cached 
https://files.pythonhosted.org/packages/03/e9/e915af1f97914cd0bc021e125fd1bfd4106de614a275e4b6866dd9a209ac/extras-1.0.0-py2.py3-none-any.whl
Collecting fixtures==3.0.0 (from -r requirements.txt (line 8))
  Using cached 
https://files.pythonhosted.org/packages/a8/28/7eed6bf76792f418029a18d5b2ace87ce7562927cdd00f1cefe481cd148f/fixtures-3.0.0-py2.py3-none-any.whl
Collecting Flask==0.12.4 (from -r requirements.txt (line 9))
  Using cached 
https://files.pythonhosted.org/packages/2e/48/f1936dadac2326b3d73f2fe0a964a87d16be16eb9d7fc56f09c1bea3d17c/Flask-0.12.4-py2.py3-none-any.whl
Collecting Flask-Gravatar==0.5.0 (from -r requirements.txt (line 10))
  Using cached 
https://files.pythonhosted.org/packages/58/4a/b20260e8d383d0037f2791dd8a3f3ea729ca9f02d7638677a34a236a8702/Flask_Gravatar-0.5.0-py2.py3-none-any.whl
Collecting Flask-Login==0.3.2 (from -r requirements.txt (line 11))
Collecting Flask-Mail==0.9.1 (from -r requirements.txt (line 12))
Collecting Flask-Migrate==2.1.1 (from -r requirements.txt (line 13))
  Using cached 
https://files.pythonhosted.org/packages/c6/06/053630cb5fe3974c7d60c2d3f3907bae6ff86beb8720bd4fcf53c45c6702/Flask_Migrate-2.1.1-py2.py3-none-any.whl
Collecting Flask-Principal==0.4.0 (from -r requirements.txt (line 14))
Collecting Flask-SQLAlchemy==2.3.2 (from -r requirements.txt (line 15))
  Using cached 
https://files.pythonhosted.org/packages/a1/44/294fb7f6bf49cc7224417cd0637018db9fee0729b4fe166e43e2bbb1f1c8/Flask_SQLAlchemy-2.3.2-py2.py3-none-any.whl
Collecting Flask-WTF==0.14.2 (from -r requirements.txt (line 16))
  Using cached 
https://files.pythonhosted.org/packages/60/3a/58c629472d10539ae5167dc7c1fecfa95dd7d0b7864623931e3776438a24/Flask_WTF-0.14.2-py2.py3-none-any.whl
Collecting html5lib==1.0.1 (from -r requirements.txt (line 17))
  Using cached 
https://files.pythonhosted.org/packages/a5/62/bbd2be0e7943ec8504b517e62bab011b4946e1258842bc159e5dfde15b96/html5lib-1.0.1-py2.py3-none-any.whl
Collecting linecache2==1.0.0 (from -r requirements.txt (line 18))
  Using cached 
https://files.pythonhosted.org/packages/c7/a3/c5da2a44c85bfbb6eebcfc1dde24933f8704441b98fdde6528f4831757a6/linecache2-1.0.0-py2.py3-none-any.whl
Collecting passlib==1.7.1 (from -r requirements.txt (line 19

Jenkins build is back to normal : pgadmin4-master-python35 #853

2019-01-11 Thread pgAdmin 4 Jenkins
See 





Jenkins build is back to normal : pgadmin4-master-python27 #866

2019-01-11 Thread pgAdmin 4 Jenkins
See 





Jenkins build is back to normal : pgadmin4-master-python37 #99

2019-01-11 Thread pgAdmin 4 Jenkins
See 





Jenkins build is back to normal : pgadmin4-master-python34 #856

2019-01-11 Thread pgAdmin 4 Jenkins
See 





Jenkins build is back to normal : pgadmin4-master-python36 #857

2019-01-11 Thread pgAdmin 4 Jenkins
See 





pgAdmin 4 commit: Ensure that last row of table data should be visible

2019-01-11 Thread Akshay Joshi
Ensure that last row of table data should be visible and user will be able to 
add new row. Fixes #3866

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4a2f1b8cd8d880f3b365445211b448f217085dc
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_1.rst  | 3 ++-
web/pgadmin/static/scss/resources/_default.variables.scss | 3 +++
web/pgadmin/tools/sqleditor/static/scss/_sqleditor.scss   | 9 +
3 files changed, 14 insertions(+), 1 deletion(-)



Re: [pgAdmin4][RM3866] No way to add row to a table in v4.0

2019-01-11 Thread Akshay Joshi
Thanks patch applied.

On Fri, Jan 11, 2019 at 9:15 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the issue where last row of data grid is not
> visible.
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


pgAdmin 4 commit: Update message catalog and version for release.

2019-01-11 Thread Akshay Joshi
Update message catalog and version for release.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b135f2932357d189de1479811c2385dc11bb2c5

Modified Files
--
runtime/Info.plist |   4 +-
runtime/pgAdmin4.pro   |   2 +-
web/config.py  |   4 +-
web/pgadmin/messages.pot   |  72 +-
.../translations/de/LC_MESSAGES/messages.mo| Bin 146741 -> 146739 bytes
.../translations/de/LC_MESSAGES/messages.po|  75 +-
.../translations/es/LC_MESSAGES/messages.mo| Bin 151656 -> 151654 bytes
.../translations/es/LC_MESSAGES/messages.po|  75 +-
.../translations/fr/LC_MESSAGES/messages.mo| Bin 155457 -> 155446 bytes
.../translations/fr/LC_MESSAGES/messages.po| 940 +++--
.../translations/ja/LC_MESSAGES/messages.mo| Bin 161761 -> 161741 bytes
.../translations/ja/LC_MESSAGES/messages.po|  77 +-
.../translations/ko/LC_MESSAGES/messages.mo| Bin 149226 -> 149224 bytes
.../translations/ko/LC_MESSAGES/messages.po|  75 +-
.../translations/pl/LC_MESSAGES/messages.mo| Bin 146997 -> 146995 bytes
.../translations/pl/LC_MESSAGES/messages.po|  75 +-
.../translations/ru/LC_MESSAGES/messages.mo| Bin 184966 -> 184964 bytes
.../translations/ru/LC_MESSAGES/messages.po|  75 +-
.../translations/zh/LC_MESSAGES/messages.mo| Bin 125595 -> 125593 bytes
.../translations/zh/LC_MESSAGES/messages.po|  75 +-
20 files changed, 797 insertions(+), 752 deletions(-)



pgAdmin4 v4.1 candidate builds

2019-01-11 Thread Akshay Joshi
Hi All,

pgAdmin4 v4.1 candidate builds and source can be found at
https://developer.pgadmin.org/builds/2019-01-12-1

Fahar, can you please verify it ASAP for release on Tuesday.

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


Docs on the website

2019-01-11 Thread Dave Page
I've updated the docs build on the pgAdmin website. Previously we had
a link the the 'dev' docs (on the master GIT branch), as well as one
on each of the branches. The latest branch of course was master, so
the latest version link was really always the same as the dev link.

Now the numbered doc versions are based on the release tags in the repo, so:

1.6 points to REL-1_6
2.1 points to REL-2_1
3.6 points to REL-3_6

dev continues to point to the head of the master branch.

The latest major version link (4.x) is a special case. I've setup a
script that runs every 30 minutes that grabs the versions.json file we
use for the update notification. It extracts the major and minor
version number, and then attempts to checkout that branch in the
appropriate place.

This means we should only need to manually update that part of the
site when we increase the major version (and the script will email me
if that seems to be the case, and we forgot).

The upshot of this, is that the docs on the website now properly match
the released versions.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company