pgAdmin 4 commit: Ensure sequence with negative value should be created

2019-09-12 Thread Akshay Joshi 
Ensure sequence with negative value should be created. Fixes #4726

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7944e75695960c5696bc83e06c80a8c01eae8727

Modified Files
--
docs/en_US/release_notes_4_13.rst  |  3 +-
.../schemas/sequences/static/js/sequence.js|  1 -
.../templates/sequences/sql/default/create.sql | 10 +++---
.../tests/pg/default/alter_neg_seq_props.sql   | 13 +++
.../tests/pg/default/alter_neg_seq_props_msql.sql  |  4 +++
.../tests/pg/default/create_negative_sequence.sql  | 13 +++
.../pg/default/create_negative_sequence_msql.sql   |  9 +
.../tests/pg/default/test_sequences_pg.json| 41 +-
.../tests/ppas/default/alter_neg_seq_props.sql | 13 +++
.../ppas/default/alter_neg_seq_props_msql.sql  |  4 +++
.../ppas/default/create_negative_sequence.sql  | 13 +++
.../ppas/default/create_negative_sequence_msql.sql |  9 +
.../tests/ppas/default/test_sequences_ppas.json| 41 +-
.../schemas/sequences/tests/test_sequence_add.py   | 19 +-
.../schemas/sequences/tests/test_sequence_put.py   | 37 +++
.../databases/schemas/sequences/tests/utils.py | 13 +--
16 files changed, 223 insertions(+), 20 deletions(-)

Re: Italian translation

2019-09-12 Thread Akshay Joshi 
Hi Domenico/Dave

There is some problem with the translation file. RM #4736
 has been created.
I have analyzed the issue and found the problem in the translation of the
string "*%s.*" is translated to "*% s.*". Space between % and s is the
problem.
For example, I have entered the string in google translation "*user %s.*"
and it returns "*utente% s.*". I have found 24 such occurrences in the
"messages.po" file.

I have fixed the issue, attached is the modified patch. Please review it,
hope I haven't broken any translation string.

On Mon, Sep 9, 2019 at 11:34 AM Akshay Joshi 
wrote:

> Thanks patch applied.
>
> On Sun, Sep 8, 2019 at 8:50 PM Domenico Sgarbossa 
> wrote:
>
>> I made some improvements! ;-)
>>
>> Il lunedì 2 settembre 2019, 14:43:50 CEST, Dave Page 
>> ha scritto:
>>
>>
>> Thank you - translation committed!
>>
>> On Sun, Sep 1, 2019 at 11:50 AM Domenico Sgarbossa 
>> wrote:
>>
>> Hi, here the files ;-)
>>
>> Il domenica 25 agosto 2019, 16:24:38 CEST, Fred 
>> ha scritto:
>>
>>
>> Hello
>> Attach your .po and .mo files in a main sent to the mailing list. They
>> will be merged by a member of the team
>> Bye
>>
>>
>> Le 25 août 2019 12:15:51 GMT+02:00, Domenico Sgarbossa 
>> a écrit :
>>
>> Hi, recently I switched from pgadmin 3 to 4 version.
>> I haven't found translation for italian language so I made it by myself,
>> how can I send it to be merged in the project?
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


RM_4736.patch
Description: Binary data

Re: Italian translation

2019-09-12 Thread Domenico Sgarbossa 
 Thank you Akshay!It seems all ok!
Sorry... it was my mistake :-(Typically PoEdit reports these errors but it 
seems that this time something went wrong I'll I pay more attention in the 
future, I'll promise.

Il giovedì 12 settembre 2019, 13:19:05 CEST, Akshay Joshi 
 ha scritto:  
 
 Hi Domenico/Dave
There is some problem with the translation file. RM #4736 has been created.I 
have analyzed the issue and found the problem in the translation of the string 
"%s." is translated to "% s.". Space between % and s is the problem. For 
example, I have entered the string in google translation "user %s." and it 
returns "utente% s.". I have found 24 such occurrences in the "messages.po" 
file.
I have fixed the issue, attached is the modified patch. Please review it, hope 
I haven't broken any translation string.
On Mon, Sep 9, 2019 at 11:34 AM Akshay Joshi  
wrote:

Thanks patch applied.
On Sun, Sep 8, 2019 at 8:50 PM Domenico Sgarbossa  wrote:

 I made some improvements! ;-) 
Il lunedì 2 settembre 2019, 14:43:50 CEST, Dave Page  ha 
scritto:  
 
 Thank you - translation committed!
On Sun, Sep 1, 2019 at 11:50 AM Domenico Sgarbossa  wrote:

 Hi, here the files ;-)
Il domenica 25 agosto 2019, 16:24:38 CEST, Fred  ha 
scritto:  
 
 Hello
Attach your .po and .mo files in a main sent to the mailing list. They will be 
merged by a member of the team
Bye


Le 25 août 2019 12:15:51 GMT+02:00, Domenico Sgarbossa  a 
écrit :
Hi, recently I switched from pgadmin 3 to 4 version.I haven't found translation 
for italian language so I made it by myself, how can I send it to be merged in 
the project?

  


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
  


-- 
Thanks & RegardsAkshay JoshiSr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246



-- 
Thanks & RegardsAkshay JoshiSr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgAdmin 4 commit: Fix query tool and view data issue with the Italian l

2019-09-12 Thread Akshay Joshi 
Fix query tool and view data issue with the Italian language. Fixes #4736

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d8c53bffd8ffccd7377bf6cc39ee07992fcc255

Modified Files
--
docs/en_US/release_notes_4_13.rst  |  5 +--
.../translations/it/LC_MESSAGES/messages.po| 40 +++---
2 files changed, 23 insertions(+), 22 deletions(-)

Re: Italian translation

2019-09-12 Thread Akshay Joshi 
Thanks, Domenico

I have committed the file.

On Thu, Sep 12, 2019 at 5:07 PM Domenico Sgarbossa  wrote:

> Thank you Akshay!
> It seems all ok!
>
> Sorry... it was my mistake :-(
> Typically PoEdit reports these errors but it seems that this time
> something went wrong I'll I pay more attention in the future, I'll
> promise.
>
> Il giovedì 12 settembre 2019, 13:19:05 CEST, Akshay Joshi <
> akshay.jo...@enterprisedb.com> ha scritto:
>
>
> Hi Domenico/Dave
>
> There is some problem with the translation file. RM #4736
>  has been created.
> I have analyzed the issue and found the problem in the translation of the
> string "*%s.*" is translated to "*% s.*". Space between % and s is the
> problem.
> For example, I have entered the string in google translation "*user %s.*"
> and it returns "*utente% s.*". I have found 24 such occurrences in the
> "messages.po" file.
>
> I have fixed the issue, attached is the modified patch. Please review it,
> hope I haven't broken any translation string.
>
> On Mon, Sep 9, 2019 at 11:34 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
> Thanks patch applied.
>
> On Sun, Sep 8, 2019 at 8:50 PM Domenico Sgarbossa 
> wrote:
>
> I made some improvements! ;-)
>
> Il lunedì 2 settembre 2019, 14:43:50 CEST, Dave Page 
> ha scritto:
>
>
> Thank you - translation committed!
>
> On Sun, Sep 1, 2019 at 11:50 AM Domenico Sgarbossa 
> wrote:
>
> Hi, here the files ;-)
>
> Il domenica 25 agosto 2019, 16:24:38 CEST, Fred 
> ha scritto:
>
>
> Hello
> Attach your .po and .mo files in a main sent to the mailing list. They
> will be merged by a member of the team
> Bye
>
>
> Le 25 août 2019 12:15:51 GMT+02:00, Domenico Sgarbossa 
> a écrit :
>
> Hi, recently I switched from pgadmin 3 to 4 version.
> I haven't found translation for italian language so I made it by myself,
> how can I send it to be merged in the project?
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fix display of validation error message in SlickGrid

2019-09-12 Thread Dave Page 
Fix display of validation error message in SlickGrid cells. Fixes #4408

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83170a0e94935544d6dd8d9617f306e791d702b6
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_13.rst  | 1 +
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 4 
2 files changed, 5 insertions(+)

Re: [pgAdmin][RM4408] Show validation errors for slickgrid cells

2019-09-12 Thread Dave Page 
Thanks, patch applied.

On Tue, Sep 10, 2019 at 7:52 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is a tiny patch to show the validation error message in case a
> user enters syntactically incorrect data in cell editors.
> Note that, the validation is already been done but the message was not
> displayed. Attached patch will display the message.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-12 Thread Akshay Joshi 
Can someone please review this.

On Mon, 9 Sep, 2019, 18:06 Akshay Joshi, 
wrote:

> Hi Hackers,
>
> Attached is the patch to fix the RM #4642 "port should not be mandatory
> when a service is provided". *Cyril Jouve* has sent the initial patch,
> but that only removes the validation on GUI, when we save the server
> properties without port and username backend throws an error because port
> and username is *NOT NULL* columns in the server table in SQLite.
>
> I have removed the *NOT NULL *constraint from the port and username. The
> maintenance database is required as our whole connection logic is based on
> that, so I have added the NOT NULL constraint for that column.
>
> Please review it.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

pgAdmin 4 commit: Fix webpack issue where multiple assets emit to the s

2019-09-12 Thread Akshay Joshi 
Fix webpack issue where multiple assets emit to the same file.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a69d27009967a10fc89419d8ce664f7c5339e56
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/misc/file_manager/static/js/utility.js | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

pgAdmin 4 commit: Ensure port and username should not be mandatory when

2019-09-12 Thread Akshay Joshi 
Ensure port and username should not be mandatory when a service is provided. 
Fixes #4642

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da553eec9b2324dde5259457bd654683e2133190

Modified Files
--
docs/en_US/release_notes_4_13.rst  |  1 +
web/migrations/versions/a77a0932a568_.py   | 91 ++
.../browser/server_groups/servers/__init__.py  |  6 +-
.../server_groups/servers/model_validation.js  |  8 +-
.../server_groups/servers/model_validation_spec.js | 13 ++--
5 files changed, 105 insertions(+), 14 deletions(-)

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-12 Thread Aditya Toshniwal 
Looks good to me.

On Fri, Sep 13, 2019 at 8:05 AM Akshay Joshi 
wrote:

> Can someone please review this.
>
> On Mon, 9 Sep, 2019, 18:06 Akshay Joshi, 
> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the RM #4642 "port should not be mandatory
>> when a service is provided". *Cyril Jouve* has sent the initial patch,
>> but that only removes the validation on GUI, when we save the server
>> properties without port and username backend throws an error because port
>> and username is *NOT NULL* columns in the server table in SQLite.
>>
>> I have removed the *NOT NULL *constraint from the port and username. The
>> maintenance database is required as our whole connection logic is based on
>> that, so I have added the NOT NULL constraint for that column.
>>
>> Please review it.
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"