pgAdmin 4 commit: Fix vulnerability issues reported by 'yarn audit'. Re

2019-12-11 Thread Akshay Joshi
Fix vulnerability issues reported by 'yarn audit'. Replace the deprecated 
uglifyjs-webpack-plugin with a terser-webpack-plugin. Fixes #5004.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43d37e3b4c737ca8e1500b2b59514e21036013c2
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes.rst  |1 +
docs/en_US/release_notes_4_17.rst |   20 +
web/package.json  |6 +-
web/webpack.config.js |7 +-
web/yarn.lock | 1026 +
5 files changed, 616 insertions(+), 444 deletions(-)



Re: [pgAdmin][RM5004] Fix yarn audit issues and remove deprecated uglifyjs-webpack-plugin

2019-12-11 Thread Akshay Joshi
Thanks, patch applied.

On Wed, Dec 11, 2019 at 12:53 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the issues reported by "yarn audit", which
> required few package updates.
> Also, replace the deprecated uglifyjs-webpack-plugin
> with terser-webpack-plugin.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Fix an issue where clicking on an empty textbox like

2019-12-11 Thread Akshay Joshi
Fix an issue where clicking on an empty textbox like fill factor or comments, 
considers it as change and enabled the save button. Fixes #4506.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=11bf5fc679471f64ae32d47c44f22bfaff9e1b62
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_17.rst  | 1 +
.../schemas/tables/templates/tables/sql/12_plus/update.sql | 3 +++
.../schemas/tables/templates/tables/sql/default/update.sql | 3 +++
.../servers/databases/schemas/views/static/js/mview.js | 2 +-
web/pgadmin/browser/static/js/datamodel.js | 7 +++
web/pgadmin/browser/templates/browser/js/messages.js   | 4 ++--
6 files changed, 13 insertions(+), 7 deletions(-)



pgAdmin 4 commit: Added aria-label to the buttons in the debugger.

2019-12-11 Thread Akshay Joshi
Added aria-label to the buttons in the debugger.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bda583d5bc69675802f8e442a999265bb911fd0
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/tools/debugger/static/js/direct.js | 6 ++
1 file changed, 6 insertions(+)



Re: [pgAdmin][RM4762] [Accessibility] Allow screenreader to read label & description of non-textable elements

2019-12-11 Thread Akshay Joshi
Thanks, patch applied.

On Tue, Dec 10, 2019 at 5:27 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to add aria-label to the buttons in debugger. All
> others were taken care in #4772.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table

2019-12-11 Thread Akshay Joshi
Thanks, patch applied.

On Tue, Dec 10, 2019 at 12:57 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the updated patch. The modified SQL missed the reset clause
> for FILLFACTOR. That's added now.
> I've changed the int/numeric field validation to disallow spaces in the
> form field. Currently,  fill factor allows spaces and fails while saving as
> "invalid value".
> Also, added min and max for fill factor in Mview dialog.
>
> All the test cases are passing. Kindly review.
>
>
> On Mon, Dec 9, 2019 at 4:30 PM Akshay Joshi 
> wrote:
>
>> Hi Aditya
>>
>> The issue has not been resolved. Remove fill factor it won't generate
>> MSQL. Please verify and fix it.
>>
>> On Mon, Dec 9, 2019 at 3:33 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix an issue where just clicking on an
>>> empty textbox like fill factor in tables dialog considers it a change and
>>> so the save button is enabled.
>>> The fix is common will apply at other places also.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: Re : [BUG #4943]

2019-12-11 Thread Aditya Toshniwal
Hi Karan,

I've updated your patch a bit. Kindly test and share the logs if test cases
fail.
Test cases seems to be working fine for me. Kindly also change disconnected
messages.

On Tue, Dec 10, 2019 at 6:51 PM Karan Takalkar 
wrote:

> Hi,
>
> "add more variables to the response along with info and use those in the
> front end"
> i have already implemented that , but am still failing (7)  test cases
> particularly in the databases/extensions tests(5).
> i had run regression tests for browser node.(and all it's sub directories).
> Please check the patch attached.
>
> On Tue, Dec 10, 2019 at 6:34 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> [please use reply all to reply]
>>
>> You can add more variables to the response along with info and use those
>> in the front end.
>>
>> On Tue, Dec 10, 2019, 18:24 Karan Takalkar  wrote:
>>
>>> Hi
>>>
>>> I had been naively modifying jason response of connect function in
>>> databases __init__.py, later realized there are a lot of dependencies on it
>>> and most of regression tests use:
>>> if db_con["info"] == "Database connected.": .
>>>
>>> I am now modifying the Alertify.success script* directly responsible for
>>> the popup, i could append the database name in the message but am having
>>> trouble finding the *variable to supply server name.*
>>> The file and location of function is :
>>> *
>>> (web/pgadmin/browser/server_groups/servers/databases/static/js/database.js
>>> line 523)
>>>
>>> the message should be:
>>> Alertify.success("(?server_name_variable?}+'/'+data.label+' - '+res.info
>>> ")
>>>
>>> data.label contains database name
>>> res.info is the jason response coming from databases __init__.py
>>> connect function ; which is "Database connected."
>>>
>>> On Mon, Dec 9, 2019 at 8:35 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Karan,

 Kindly add a hyphen between the message and names, create a patch to
 pgAdmin hackers(check cc).
 Kindly also run the test cases and pep8 before sending.

 On Mon, Dec 9, 2019, 20:17 Karan Takalkar 
 wrote:

> I have updated the success message.
> Please check the screenshots attached.
> Should i make a patch?
>
> Regards,
> Karan
>
> On Mon, 9 Dec, 2019, 3:25 PM Aditya Toshniwal, <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> ++pgadmin-hackers
>>
>> Hi Karan,
>>
>> It is good to know that you're contributing.
>> I would suggest {server name}/{db name} as name instead of did is
>> better for UX. You can get the db name from conn object and server name
>> using the sid (refer
>> - web/pgadmin/browser/server_groups/servers/__init__.py)
>>
>>
>> On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar 
>> wrote:
>>
>>> Hi,
>>>
>>> I have been working on #4943 ("Database connected" success message
>>> itself is not enough) added by you on pgAdmin4 issues.
>>> I want to know what details of database should be included in
>>> success message.(i have added 'did')
>>>
>>> The success message can be modified by altering json response in the
>>> connect method in file
>>> PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.
>>> please have a look at the screenshots attached.
>>>
>>> original:
>>> info=_( "Database connected.")
>>> new:
>>> info=_("Postgres version/{0} Database connected.".format(did))
>>>
>>> Regards,
>>> Karan
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


BUG_4943_updated.patch
Description: Binary data


Re: Re : [BUG #4943]

2019-12-11 Thread Karan Takalkar
Hi,

I have updated the disconnect messages.
Databases/extension tests are failing , i have attached the log below.
They are also failing if i undo the modifications.
i do not know if this a  problem with my setup or i maybe not following a
convention.
Please check the updated patch.

Regards,
Karan

On Wed, Dec 11, 2019 at 3:03 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Karan,
>
> I've updated your patch a bit. Kindly test and share the logs if test
> cases fail.
> Test cases seems to be working fine for me. Kindly also change
> disconnected messages.
>
> On Tue, Dec 10, 2019 at 6:51 PM Karan Takalkar 
> wrote:
>
>> Hi,
>>
>> "add more variables to the response along with info and use those in the
>> front end"
>> i have already implemented that , but am still failing (7)  test cases
>> particularly in the databases/extensions tests(5).
>> i had run regression tests for browser node.(and all it's sub
>> directories).
>> Please check the patch attached.
>>
>> On Tue, Dec 10, 2019 at 6:34 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> [please use reply all to reply]
>>>
>>> You can add more variables to the response along with info and use those
>>> in the front end.
>>>
>>> On Tue, Dec 10, 2019, 18:24 Karan Takalkar 
>>> wrote:
>>>
 Hi

 I had been naively modifying jason response of connect function in
 databases __init__.py, later realized there are a lot of dependencies on it
 and most of regression tests use:
 if db_con["info"] == "Database connected.": .

 I am now modifying the Alertify.success script* directly responsible
 for the popup, i could append the database name in the message but am
 having trouble finding the *variable to supply server name.*
 The file and location of function is :
 *
 (web/pgadmin/browser/server_groups/servers/databases/static/js/database.js
 line 523)

 the message should be:
 Alertify.success("(?server_name_variable?}+'/'+data.label+' - '+
 res.info")

 data.label contains database name
 res.info is the jason response coming from databases __init__.py
 connect function ; which is "Database connected."

 On Mon, Dec 9, 2019 at 8:35 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi Karan,
>
> Kindly add a hyphen between the message and names, create a patch to
> pgAdmin hackers(check cc).
> Kindly also run the test cases and pep8 before sending.
>
> On Mon, Dec 9, 2019, 20:17 Karan Takalkar 
> wrote:
>
>> I have updated the success message.
>> Please check the screenshots attached.
>> Should i make a patch?
>>
>> Regards,
>> Karan
>>
>> On Mon, 9 Dec, 2019, 3:25 PM Aditya Toshniwal, <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> ++pgadmin-hackers
>>>
>>> Hi Karan,
>>>
>>> It is good to know that you're contributing.
>>> I would suggest {server name}/{db name} as name instead of did is
>>> better for UX. You can get the db name from conn object and server name
>>> using the sid (refer
>>> - web/pgadmin/browser/server_groups/servers/__init__.py)
>>>
>>>
>>> On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar 
>>> wrote:
>>>
 Hi,

 I have been working on #4943 ("Database connected" success message
 itself is not enough) added by you on pgAdmin4 issues.
 I want to know what details of database should be included in
 success message.(i have added 'did')

 The success message can be modified by altering json response in
 the connect method in file
 PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.
 please have a look at the screenshots attached.

 original:
 info=_( "Database connected.")
 new:
 info=_("Postgres version/{0} Database connected.".format(did))

 Regards,
 Karan

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/__init__.py
index 26fd5ccac..905401fa7 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/__init__.py
@@ -30,7 +30,7 @@ from pgadmin.utils.ajax import make_json_response, \
 make_response as ajax_response, internal_server_error, unauthorized
 from pgadmin.utils.driver import get_driver
 from pgadmin.tools.sqleditor.utils.query_history import QueryHistory
-
+fr

Re: Re : [BUG #4943]

2019-12-11 Thread Aditya Toshniwal
Hi,

I've updated your patch further to escape the info prefix so that it
doesn't break if db name is something like - "alert(1)".
Fixed a pep8 issue.
Otherwise, the patch looks good to me and test cases works fine.


On Wed, Dec 11, 2019 at 5:19 PM Karan Takalkar 
wrote:

> Hi,
>
> I have updated the disconnect messages.
> Databases/extension tests are failing , i have attached the log below.
> They are also failing if i undo the modifications.
> i do not know if this a  problem with my setup or i maybe not following a
> convention.
> Please check the updated patch.
>
> Regards,
> Karan
>
> On Wed, Dec 11, 2019 at 3:03 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Karan,
>>
>> I've updated your patch a bit. Kindly test and share the logs if test
>> cases fail.
>> Test cases seems to be working fine for me. Kindly also change
>> disconnected messages.
>>
>> On Tue, Dec 10, 2019 at 6:51 PM Karan Takalkar 
>> wrote:
>>
>>> Hi,
>>>
>>> "add more variables to the response along with info and use those in the
>>> front end"
>>> i have already implemented that , but am still failing (7)  test cases
>>> particularly in the databases/extensions tests(5).
>>> i had run regression tests for browser node.(and all it's sub
>>> directories).
>>> Please check the patch attached.
>>>
>>> On Tue, Dec 10, 2019 at 6:34 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 [please use reply all to reply]

 You can add more variables to the response along with info and use
 those in the front end.

 On Tue, Dec 10, 2019, 18:24 Karan Takalkar 
 wrote:

> Hi
>
> I had been naively modifying jason response of connect function in
> databases __init__.py, later realized there are a lot of dependencies on 
> it
> and most of regression tests use:
> if db_con["info"] == "Database connected.": .
>
> I am now modifying the Alertify.success script* directly responsible
> for the popup, i could append the database name in the message but am
> having trouble finding the *variable to supply server name.*
> The file and location of function is :
> *
> (web/pgadmin/browser/server_groups/servers/databases/static/js/database.js
> line 523)
>
> the message should be:
> Alertify.success("(?server_name_variable?}+'/'+data.label+' - '+
> res.info")
>
> data.label contains database name
> res.info is the jason response coming from databases __init__.py
> connect function ; which is "Database connected."
>
> On Mon, Dec 9, 2019 at 8:35 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Karan,
>>
>> Kindly add a hyphen between the message and names, create a patch to
>> pgAdmin hackers(check cc).
>> Kindly also run the test cases and pep8 before sending.
>>
>> On Mon, Dec 9, 2019, 20:17 Karan Takalkar 
>> wrote:
>>
>>> I have updated the success message.
>>> Please check the screenshots attached.
>>> Should i make a patch?
>>>
>>> Regards,
>>> Karan
>>>
>>> On Mon, 9 Dec, 2019, 3:25 PM Aditya Toshniwal, <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 ++pgadmin-hackers

 Hi Karan,

 It is good to know that you're contributing.
 I would suggest {server name}/{db name} as name instead of did is
 better for UX. You can get the db name from conn object and server name
 using the sid (refer
 - web/pgadmin/browser/server_groups/servers/__init__.py)


 On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar <
 karan153...@gmail.com> wrote:

> Hi,
>
> I have been working on #4943 ("Database connected" success
> message itself is not enough) added by you on pgAdmin4 issues.
> I want to know what details of database should be included in
> success message.(i have added 'did')
>
> The success message can be modified by altering json response in
> the connect method in file
> PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.
> please have a look at the screenshots attached.
>
> original:
> info=_( "Database connected.")
> new:
> info=_("Postgres version/{0} Database connected.".format(did))
>
> Regards,
> Karan
>


 --
 Thanks and Regards,
 Aditya Toshniwal
 Sr. Software Engineer | EnterpriseDB India | Pune
 "Don't Complain about Heat, Plant a TREE"

>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Pl

pgAdmin 4 commit: Added more information to the 'Database connected/dis

2019-12-11 Thread Akshay Joshi
Added more information to the 'Database connected/disconnected' message. Fixes 
#4943.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53f418b9a2701abc2a6300382734b72dcd6d3ecc
Author: Karan Takalkar 

Modified Files
--
docs/en_US/release_notes_4_17.rst |  1 +
.../browser/server_groups/servers/databases/__init__.py   | 11 ---
.../server_groups/servers/databases/static/js/database.js |  6 ++
3 files changed, 15 insertions(+), 3 deletions(-)



Re: Re : [BUG #4943]

2019-12-11 Thread Akshay Joshi
Thanks, patch applied.

On Wed, Dec 11, 2019 at 5:41 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> I've updated your patch further to escape the info prefix so that it
> doesn't break if db name is something like - "alert(1)".
> Fixed a pep8 issue.
> Otherwise, the patch looks good to me and test cases works fine.
>
>
> On Wed, Dec 11, 2019 at 5:19 PM Karan Takalkar 
> wrote:
>
>> Hi,
>>
>> I have updated the disconnect messages.
>> Databases/extension tests are failing , i have attached the log below.
>> They are also failing if i undo the modifications.
>> i do not know if this a  problem with my setup or i maybe not following a
>> convention.
>> Please check the updated patch.
>>
>> Regards,
>> Karan
>>
>> On Wed, Dec 11, 2019 at 3:03 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Karan,
>>>
>>> I've updated your patch a bit. Kindly test and share the logs if test
>>> cases fail.
>>> Test cases seems to be working fine for me. Kindly also change
>>> disconnected messages.
>>>
>>> On Tue, Dec 10, 2019 at 6:51 PM Karan Takalkar 
>>> wrote:
>>>
 Hi,

 "add more variables to the response along with info and use those in
 the front end"
 i have already implemented that , but am still failing (7)  test cases
 particularly in the databases/extensions tests(5).
 i had run regression tests for browser node.(and all it's sub
 directories).
 Please check the patch attached.

 On Tue, Dec 10, 2019 at 6:34 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> [please use reply all to reply]
>
> You can add more variables to the response along with info and use
> those in the front end.
>
> On Tue, Dec 10, 2019, 18:24 Karan Takalkar 
> wrote:
>
>> Hi
>>
>> I had been naively modifying jason response of connect function in
>> databases __init__.py, later realized there are a lot of dependencies on 
>> it
>> and most of regression tests use:
>> if db_con["info"] == "Database connected.": .
>>
>> I am now modifying the Alertify.success script* directly responsible
>> for the popup, i could append the database name in the message but am
>> having trouble finding the *variable to supply server name.*
>> The file and location of function is :
>> *
>> (web/pgadmin/browser/server_groups/servers/databases/static/js/database.js
>> line 523)
>>
>> the message should be:
>> Alertify.success("(?server_name_variable?}+'/'+data.label+' - '+
>> res.info")
>>
>> data.label contains database name
>> res.info is the jason response coming from databases __init__.py
>> connect function ; which is "Database connected."
>>
>> On Mon, Dec 9, 2019 at 8:35 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Karan,
>>>
>>> Kindly add a hyphen between the message and names, create a patch to
>>> pgAdmin hackers(check cc).
>>> Kindly also run the test cases and pep8 before sending.
>>>
>>> On Mon, Dec 9, 2019, 20:17 Karan Takalkar 
>>> wrote:
>>>
 I have updated the success message.
 Please check the screenshots attached.
 Should i make a patch?

 Regards,
 Karan

 On Mon, 9 Dec, 2019, 3:25 PM Aditya Toshniwal, <
 aditya.toshni...@enterprisedb.com> wrote:

> ++pgadmin-hackers
>
> Hi Karan,
>
> It is good to know that you're contributing.
> I would suggest {server name}/{db name} as name instead of did is
> better for UX. You can get the db name from conn object and server 
> name
> using the sid (refer
> - web/pgadmin/browser/server_groups/servers/__init__.py)
>
>
> On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar <
> karan153...@gmail.com> wrote:
>
>> Hi,
>>
>> I have been working on #4943 ("Database connected" success
>> message itself is not enough) added by you on pgAdmin4 issues.
>> I want to know what details of database should be included in
>> success message.(i have added 'did')
>>
>> The success message can be modified by altering json response in
>> the connect method in file
>> PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.
>> please have a look at the screenshots attached.
>>
>> original:
>> info=_( "Database connected.")
>> new:
>> info=_("Postgres version/{0} Database connected.".format(did))
>>
>> Regards,
>> Karan
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

Re: pgAdmin4 v4.16 candidate builds

2019-12-11 Thread Fahar Abbas
@Akshay Joshi 

1 Round of testing has been completed for v4.16 and it's ready for the
release.

Kind Regards,



On Mon, Dec 9, 2019 at 10:02 PM Akshay Joshi 
wrote:

> Hi All,
>
> pgAdmin4 v4.16 candidate builds and source can be found at
> https://developer.pgadmin.org/builds/2019-12-09-1/
>
> Fahar, can you please verify it for release on Thursday.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: *live:fahar.abbas*
Website: www.enterprisedb.com