[pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode
Hi Hackers, Attached is the patch to: 1) Fix an issue when dumping servers from a desktop pgAdmin app by providing an option --sqlite-path. This will allow the user to dump a specific config db file. 2) While there is an option for --sqlite-path now, the other paths for session, storage, etc. were failing with permission errors. Code is changed to not to bother those directories when dumping or loading servers. 3) Improved --help for setup.py. 4) Docs updated. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM5521.patch Description: Binary data
Re: pgAdmin4 v4.22 candidate builds
@Akshay Joshi One Round of testing has been completed. Can you please release pgadmin4 4.22? On Mon, May 25, 2020 at 6:53 PM Akshay Joshi wrote: > > > On Mon, May 25, 2020 at 6:54 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All, >> >> pgAdmin4 v4.21 candidate builds and source can be found at >> https://developer.pgadmin.org/builds/2020-05-25-1/ >> > >pgAdmin4 v4.22 candidate builds. Sorry for the typo > >> >> >> Fahar, can you please verify it for release on Thursday. >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Fahar Abbas QMG EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: *live:fahar.abbas* Website: www.enterprisedb.com
pgAdmin 4 v4.22 released
The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.22. This release of pgAdmin 4 includes over 36 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_22.html. pgAdmin is the leading Open Source graphical management tool for PostgreSQL. For more information, please see: https://www.pgadmin.org/ Notable changes in this release include: - Show the startup log as well as the server log in the runtime's log viewer. - Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. - Remove support for Python 2. - Ensure that maintenance jobs should be worked properly for indexes under a materialized view. - Ensure that file browse "home" button should point to $HOME rather than /. - Fixed data truncation issue when updating the data of type character with length - Fixed generated SQL issue for auto vacuum options. - Fixed internal server error when clicking on Triggers -> 'Enable All' for partitions - Fixed the SQL help issue for EDB Postgres Advanced Server. - Fixed an issue where if LDAP_SEARCH_BASE_DN is not set then, the value for LDAP_BASE_DN will be considered. - Improve code coverage and API test cases for Indexes, Rules, Triggers, and Compound Triggers. Builds for Windows and macOS are available now, along with a Python Wheel, Docker Container and source code tarball from: https://www.pgadmin.org/download/ RPM and DEB packages are expected to be available on the postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project
pgAdmin 4 commit: Tag REL-4_22 has been created.
Tag REL-4_22 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_22 Log Message --- Tag v4.22
[pgAdmin4][Patch] - RM 5539 - /usr/share/pgadmin4/web/pgadmin/utils/preferences.py contains 7 references to current_app.logger.exeception(e) and 1 to current_app.logger.exception(e)
Hi Hackers, Please find attached patch fixing exception errors. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM5539_v1.patch Description: Binary data
Re: [pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode
Hi Aditya When I run setup.py and specify the *--sqlite-path* parameter like below: python setup.py --sqlite-path "/Users/akshayjoshi/Downloads/pgadmin4-dev-env.db" --dump-servers output.json I got the following error: PermissionError: [Errno 13] Permission denied: '/var/lib/pgadmin' Please fix it and resend the patch. On Thu, May 28, 2020 at 2:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to: > 1) Fix an issue when dumping servers from a desktop pgAdmin app by > providing an option --sqlite-path. This will allow the user to dump a > specific config db file. > 2) While there is an option for --sqlite-path now, the other paths for > session, storage, etc. were failing with permission errors. Code is changed > to not to bother those directories when dumping or loading servers. > 3) Improved --help for setup.py. > 4) Docs updated. > > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Ensure that the query tool panel gets closed when cli
Ensure that the query tool panel gets closed when clicking on the 'Don't Save' button. Fixes #5416 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e10f1274dc01780b09663575fd5c20872391d12e Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes.rst | 1 + docs/en_US/release_notes_4_23.rst | 20 web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 4 +++- 3 files changed, 24 insertions(+), 1 deletion(-)
pgAdmin 4 commit: Fixed typo in exception keyword. Fixes #5539
Fixed typo in exception keyword. Fixes #5539 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=09b76b306c64e7ec81236974454087bd1a387b02 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes_4_23.rst | 3 ++- web/pgadmin/utils/preferences.py | 14 +++--- 2 files changed, 9 insertions(+), 8 deletions(-)
Re: [pgAdmin4][Patch] - RM 5539 - /usr/share/pgadmin4/web/pgadmin/utils/preferences.py contains 7 references to current_app.logger.exeception(e) and 1 to current_app.logger.exception(e)
Thanks, patch applied. On Thu, May 28, 2020 at 5:16 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached patch fixing exception errors. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - RM 5416 Cannot close/remove a tab/panel without saving
Thanks, patch applied. On Wed, May 27, 2020 at 12:08 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached patch fixing 'Cannot close/remove a tab/panel without > saving' issue. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode
Hi Hackers, Attached is the updated patch. Please review. On Thu, May 28, 2020 at 5:38 PM Akshay Joshi wrote: > Hi Aditya > > When I run setup.py and specify the *--sqlite-path* parameter like below: > python setup.py --sqlite-path > "/Users/akshayjoshi/Downloads/pgadmin4-dev-env.db" --dump-servers > output.json > > I got the following error: > > PermissionError: [Errno 13] Permission denied: '/var/lib/pgadmin' > > Please fix it and resend the patch. > > On Thu, May 28, 2020 at 2:39 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to: >> 1) Fix an issue when dumping servers from a desktop pgAdmin app by >> providing an option --sqlite-path. This will allow the user to dump a >> specific config db file. >> 2) While there is an option for --sqlite-path now, the other paths for >> session, storage, etc. were failing with permission errors. Code is changed >> to not to bother those directories when dumping or loading servers. >> 3) Improved --help for setup.py. >> 4) Docs updated. >> >> Please review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM5521_v2.patch Description: Binary data
pgAdmin 4 commit: Don't try to import the signing key. YUM/RPM will do
Don't try to import the signing key. YUM/RPM will do that for us, per Devrim. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bda62cb1f1f6c57fc3b651f986439e61dc1f9832 Modified Files -- pkg/redhat/repo-rpm.sh | 3 --- 1 file changed, 3 deletions(-)
pgAdmin 4 commit: Require postgresql >= 9.5, and don't bother with Reco
Require postgresql >= 9.5, and don't bother with Recommends. Per discussion with Devrim. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ccb39bea1ad19ed7da0e3b5278e8fd557770962f Modified Files -- pkg/redhat/build.sh | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-)
Windows build system cleanup
Here's a patch to cleanup the windows build system and make sure 64 bit builds work with modern tools. It also updates the README with a new from-scratch setup process that makes it much easier to setup a Windows build/dev machine. Please review, but don't apply as I'll need to do that in conjunction with some Jenkins changes. Note that I haven't tested a 32 bit build as I don't have a working environment for that to hand and don't really want to spend time setting one up before we deprecate it. I'll fix any issues that show up in Jenkins. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company Re-work_Windows_build_system.patch Description: Binary data
[pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida
Hi Hackers, Please find the attached patch which shows the actual Edge browser version when pgAdmin is launched Edge Version <43. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM5465_v1.patch Description: Binary data
Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida
Hi Yogesh, Your patch will fail if the edge version is older than 39. I would suggest comparing version > 18 directly. On Fri, May 29, 2020 at 10:57 AM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which shows the actual Edge browser version > when pgAdmin is launched Edge Version <43. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode
Hi Aditya When I provide the wrong path of the SQLite DB file then it should not ask me an email address and password. python setup.py --sqlite-path "/Users/akshayjoshi/Downloads/pgadmin4-de.db" --dump-servers output.json Dumping servers with: User: pgadm...@pgadmin.org SQLite pgAdmin config: /Users/akshayjoshi/Downloads/pgadmin4-de.db NOTE: Configuring authentication for SERVER mode. Enter the email address and password to use for the initial pgAdmin user account: Email address: a...@edb.com Password: Retype password: The specified user ID (pgadm...@pgadmin.org) could not be found. Please fix it and resend the patch. Test all the negative/positive scenarios. On Thu, May 28, 2020 at 6:17 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. Please review. > > On Thu, May 28, 2020 at 5:38 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> When I run setup.py and specify the *--sqlite-path* parameter like below: >> python setup.py --sqlite-path >> "/Users/akshayjoshi/Downloads/pgadmin4-dev-env.db" --dump-servers >> output.json >> >> I got the following error: >> >> PermissionError: [Errno 13] Permission denied: '/var/lib/pgadmin' >> >> Please fix it and resend the patch. >> >> On Thu, May 28, 2020 at 2:39 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to: >>> 1) Fix an issue when dumping servers from a desktop pgAdmin app by >>> providing an option --sqlite-path. This will allow the user to dump a >>> specific config db file. >>> 2) While there is an option for --sqlite-path now, the other paths for >>> session, storage, etc. were failing with permission errors. Code is changed >>> to not to bother those directories when dumping or loading servers. >>> 3) Improved --help for setup.py. >>> 4) Docs updated. >>> >>> Please review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: Windows build system cleanup
Hi Dave Unable to apply the patch. Can you please rebase and send it again. On Thu, May 28, 2020 at 9:04 PM Dave Page wrote: > Here's a patch to cleanup the windows build system and make sure 64 bit > builds work with modern tools. It also updates the README with a new > from-scratch setup process that makes it much easier to setup a Windows > build/dev machine. > > Please review, but don't apply as I'll need to do that in conjunction with > some Jenkins changes. > > Note that I haven't tested a 32 bit build as I don't have a working > environment for that to hand and don't really want to spend time setting > one up before we deprecate it. I'll fix any issues that show up in Jenkins. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida
Hi Hackers, Comparing with 18 also will create the same issue as there are multiple Edge browser versions mapped to single EdgeHTML engine versions. Please find modified patch which will show exact detected browser version till Edge Version 40. For Edge version < 40, error message will show version '<44'. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Fri, May 29, 2020 at 11:19 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yogesh, > > Your patch will fail if the edge version is older than 39. I would suggest > comparing version > 18 directly. > > On Fri, May 29, 2020 at 10:57 AM Yogesh Mahajan < > yogesh.maha...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which shows the actual Edge browser >> version when pgAdmin is launched Edge Version <43. >> >> Thanks, >> Yogesh Mahajan >> QA - Team >> EnterpriseDB Corporation >> >> Phone: +91-9741705709 >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > RM5465_v2.patch Description: Binary data
