[pgAdmin][RM5686]: Unable to update RLS policy if the policy name contains space in it

2020-07-21 Thread Pradip Parkale
Hi Hackers,

Please find the attached patch. I have fixed issue where the user was not
able to update policy if the policy is created with space in policy name.

-- 
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation


RM5686.patch
Description: Binary data


pgAdmin 4 commit: Fixed AttributeError while creating the server group.

2020-07-21 Thread Akshay Joshi
Fixed AttributeError while creating the server group. Fixes #5688

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f177d54f213c4f41d61b1deb8c323d92d9f0c3af

Modified Files
--
web/pgadmin/browser/server_groups/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Fixed issue where the user was not able to update pol

2020-07-21 Thread Akshay Joshi
Fixed issue where the user was not able to update policy if the policy is 
created with space. Fixes #5686

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28a43590202075570c622f15eee2090d6251beeb
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_4_24.rst | 3 ++-
.../templates/row_security_policies/sql/9.5_plus/update.sql   | 8 
.../tables/templates/row_security_policies/sql/default/update.sql | 8 
3 files changed, 10 insertions(+), 9 deletions(-)



pgAdmin 4 commit: Ensure that data output color is readable on row sele

2020-07-21 Thread Akshay Joshi
Ensure that data output color is readable on row selection. Fixes #5687

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5f619ae40ac377beec964f4398cc4f5dad58e7d4
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/static/scss/_bootstrap.overrides.scss  | 18 ++
.../static/scss/resources/_default.variables.scss  |  2 +-
.../static/scss/resources/dark/_theme.variables.scss   |  2 ++
.../tools/sqleditor/static/scss/_sqleditor.scss|  1 -
4 files changed, 17 insertions(+), 6 deletions(-)



pgAdmin 4 commit: Update Czech translation.

2020-07-21 Thread Akshay Joshi
Update Czech translation.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=851c15b2d641824a69eb32974699cbc182a92e4b
Author: Libor M 

Modified Files
--
.../translations/cs/LC_MESSAGES/messages.mo| Bin 175102 -> 194048 bytes
.../translations/cs/LC_MESSAGES/messages.po| 977 +++--
2 files changed, 490 insertions(+), 487 deletions(-)



Re: [pgAdmin][RM5686]: Unable to update RLS policy if the policy name contains space in it

2020-07-21 Thread Akshay Joshi
Thanks, patch applied.

On Tue, Jul 21, 2020 at 5:37 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

>
> Hi Hackers,
>
> Please find the attached patch. I have fixed issue where the user was not
> able to update policy if the policy is created with space in policy name.
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: pgAdmin 4 - Czech translation update for 4.24

2020-07-21 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Jul 20, 2020 at 6:00 PM Libor M.  wrote:

> Hi,
> updated Czech translation is in attachment.
>
> Best regards,
>
> Libor M.
>
> E-mail: libor...@gmail.com
> GitHub: https://github.com/liborm85
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: pgAdmin4 v4.24 candidate builds

2020-07-21 Thread Akshay Joshi
Hi All,

Due to one high priority issue, we have to regenerate the candidate build.
pgAdmin4 v4.24 candidate builds and source can be found at
https://developer.pgadmin.org/builds/2020-07-21-1/

Fahar, can you please verify it for release on Thursday.

On Mon, Jul 20, 2020 at 5:32 PM Akshay Joshi 
wrote:

> Hi All,
>
> pgAdmin4 v4.24 candidate builds and source can be found at
> https://developer.pgadmin.org/builds/2020-07-20-1/
>
> Fahar, can you please verify it for release on Thursday.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


[pgAdmin][RM5646] User can not see RLS policies in the search object

2020-07-21 Thread Rahul Shirsat
Hi Hackers,

Please find the patch below which fixes the issue of searching RLS policies
in search objects.

It also fixes the additional issue of search objects for RLS policies
navigating to appropriate nodes by double clicking the found object.

-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.


RM5646.patch
Description: Binary data


Patch for SonarQube code scan fixes.

2020-07-21 Thread Nikhil Mohite
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Database utils:

   - Refactor this function to reduce its Cognitive Complexity from 27 to
   the 15 allowed.

2. Schema views:

   - Refactor this function to reduce its Cognitive Complexity from 23 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 72 to
   the 15 allowed.

3. Foreign key utils:

   - Refactor this function to reduce its Cognitive Complexity from 39 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 18 to
   the 15 allowed.

4. Rules init:

   - Refactor this function to reduce its Cognitive Complexity from 20 to
   the 15 allowed.

5. Trigger init and utils:

   - Refactor this function to reduce its Cognitive Complexity from 16 to
   the 15 allowed.
   - Refactor this function to reduce its Cognitive Complexity from 34 to
   the 15 allowed.


Regards,
Nikhil Mohite.


SOnarQubeCodeSmellFixes.patch
Description: Binary data


[pgAdmin][RM5687]: Standard Theme Data output color is not readable on row selection.

2020-07-21 Thread Nikhil Mohite
Hi Team,

I have resolved the issue in standard theme UI fixes for the RM-5687
,
also fixed hover issue for toggle buttons(Switch control) in standard theme.

PFA patch.


Regards,
Nikhil Mohite.


RM_5687_v1.patch
Description: Binary data


Re: [pgAdmin][RM5687]: Standard Theme Data output color is not readable on row selection.

2020-07-21 Thread Akshay Joshi
Thanks, patch applied.

On Tue, 21 Jul, 2020, 22:46 Nikhil Mohite, 
wrote:

> Hi Team,
>
> I have resolved the issue in standard theme UI fixes for the RM-5687
> ,
> also fixed hover issue for toggle buttons(Switch control) in standard theme.
>
> PFA patch.
>
>
> Regards,
> Nikhil Mohite.
>


Re: [pgAdmin][RM5646] User can not see RLS policies in the search object

2020-07-21 Thread Rahul Shirsat
Hi Hackers,

Just for the information, the additional issue was the *incorrect node path
set in RLS policy*, and not the search objects itself.

On Tue, Jul 21, 2020 at 9:23 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the patch below which fixes the issue of searching RLS
> policies in search objects.
>
> It also fixes the additional issue of search objects for RLS policies
> navigating to appropriate nodes by double clicking the found object.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.