pgAdmin 4 commit: Fixed accessibility issues for main panels.

[Akshay Joshi]

Fixed accessibility issues for main panels.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd0ed81f7f4550361471f783b1494a0178b7325e
Author: Ganesh Jaybhay 

Modified Files
--
web/pgadmin/browser/templates/browser/index.html| 6 +++---
web/pgadmin/misc/dependencies/static/js/dependencies.js | 2 +-
web/pgadmin/misc/dependents/static/js/dependents.js | 2 +-
web/pgadmin/templates/base.html | 8 
4 files changed, 9 insertions(+), 9 deletions(-)

Re: [pgAdmin] Accessibility fixes for main panels

[Akshay Joshi]

Thanks, patch applied.

On Tue, Sep 1, 2020 at 12:04 PM Ganesh Jaybhay <
ganesh.jayb...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch to fix the accessibility errors found with
> WAVE tool on
>
>- Dashboard
>- Dependencies / Dependents panel with no object selected in tree view.
>
> Regards,
> Ganesh Jaybhay
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fix typo

[Dave Page]

Fix typo

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b85831fb5f6afee60903d5c0fa057a6e6f1fe6e5

Modified Files
--
pkg/linux/setup-web.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Re: More idiomatic python3 + fix some tests

[Cyril Jouve]

thanks :)

and sure, I'll run the linter next time!

have you thought of automatic code formatters instead like yapf or black?



Le lun. 31 août 2020 à 13:18, Akshay Joshi 
a écrit :

> Hi Cyril
>
> Thanks, patch applied. Please make sure to run "yarn run pep8" before
> sending the patch.
>
> On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve  wrote:
>
>> Hello,
>>
>> patch 1 to 6 generated mostly using 2to3:
>> 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts
>> 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter
>> 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms
>> 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass
>> 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange
>> 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode
>>
>> patch 7 fixes change_password tests:
>> Less that min length : min is 8 instead of 6
>> Valid password : use an user different than admin user / mock mail module
>>
>> patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using
>> simplejson like in all other modules).
>>
>> Regards,
>> Cyril
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

Re: More idiomatic python3 + fix some tests

[Murtuza Zabuawala]

Hi,

On Tue, Sep 1, 2020 at 2:36 PM Cyril Jouve  wrote:

> thanks :)
>
> and sure, I'll run the linter next time!
>
> have you thought of automatic code formatters instead like yapf or black?
>

AFAIK, yapf is not consistent with formatting & black is non-configurable.
I tried both sometime back and not found useful at that time but we can
give it a shot with the new release.

-- Murtuza

>
>
>
> Le lun. 31 août 2020 à 13:18, Akshay Joshi 
> a écrit :
>
>> Hi Cyril
>>
>> Thanks, patch applied. Please make sure to run "yarn run pep8" before
>> sending the patch.
>>
>> On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve  wrote:
>>
>>> Hello,
>>>
>>> patch 1 to 6 generated mostly using 2to3:
>>> 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts
>>> 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter
>>> 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms
>>> 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass
>>> 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange
>>> 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode
>>>
>>> patch 7 fixes change_password tests:
>>> Less that min length : min is 8 instead of 6
>>> Valid password : use an user different than admin user / mock mail module
>>>
>>> patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using
>>> simplejson like in all other modules).
>>>
>>> Regards,
>>> Cyril
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

[pgAdmin][SonarQube] Reduce cognitive complexity

[Aditya Toshniwal]

Hi Hackers,

Attached patch reduces cognitive complexity as below:

web/.../server_groups/servers/pgagent/__init__.py - 23 to 15
web/pgadmin/utils/driver/psycopg2/__init__.py - 23 to 15, 17 to 15
web/setup.py 77 to 15

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


sonarqube.pgagent.patch
Description: Binary data

pgAdmin 4 commit: Modified 'cryptography' version to less than or equal

[Akshay Joshi]

Modified 'cryptography' version to less than or equal to 3.0 to fix the
pgAdmin4 launch issue on Windows.

Cryptography's new version may be creating a problem. This is a temporary
fix and will have to investigate the proper fix.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b9e8e47eccca50a63f640ff95a7fd32e6be8307

Modified Files
--
requirements.txt | 1 +
1 file changed, 1 insertion(+)

pgAdmin4 - help adding new node to Browser Tree

[Warren Chan]

Hi, 

I'm trying to learn about the pgAdmin4 project and am hoping to make some 
contributions sometime in the future.
I'm new to Flask and python but am keen to learn.
While trying to familiarize myself with the application and the way it works, 
I've tried to create a 'test' node under the schema node, I want to list test 
items under this node - not listing anything particular at the moment but 
wanted to get an understanding of how the application ties together). In order 
to just get a new node added under schema, I've copied the sequence folder 
under \web\pgadmin\browser\server_groups\servers\databases\schemas and renamed 
the applicable folders to tests (I want a test node to appear under schema).
I've updated the \tests\_init_.py file so that the SequenceModule has been 
changed to TestModule (updated the NODE_TYPE etc). I've also updated the 
SequenceView to become TestView and other parts of the view like the template 
path etc. 

In addition to this I've changed the name in the \tests\static\js\sequence.js 
file to \tests\static\js\test.js and have also updated the test.js file so that 
any references to sequence has been changed to test and have added 
'pgadmin.node.tests' to the webpack.config.js and 'pgadmin.node.test': 
path.join(__dirname, 
'./pgadmin/browser/server_groups/servers/databases/schemas/tests/static/js/test')
 to the webpack.shim.js file
Doing this I was hoping that a new 'Test' node would appear under the schema 
directory and opening this node, would render all the sequences (as I haven't 
changed any of the sql). However I only get the new 'Test' node being rendered, 
and when I open this, I get a Server Node with the server I'm connected to 
being added, not the list of sequences I was hoping for. 

Is there an additional setting / steps I need to add somewhere in order to get 
the TestView to render under the TestModule node?

I'd appreciate any pointers to get this working as the next thing I'd like, 
would be to start modifying the sql and getting different database objects 
being listed.
Best regards,Warren Chan