pgAdmin 4 commit: Fixed API test cases introduce in the commit for #586

[Akshay Joshi]

Fixed API test cases introduce in the commit for #5867.

refs #5867

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=656e239e55d8a6963a1f85b5a19a56f367c99d0b
Author: Pradip Parkale 

Modified Files
--
.../servers/tests/test_all_server_get.py   | 23 ++
.../browser/server_groups/servers/tests/utils.py   | 22 +
2 files changed, 41 insertions(+), 4 deletions(-)

pgAdmin 4 commit: Allow user to change the database connection from an

[Akshay Joshi]

Allow user to change the database connection from an open query tool tab. Fixes 
#3794

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be7bb81a194aef84b3c685f41290659ef1d85af6
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/images/new_connection_dialog.png| Bin 0 -> 49691 bytes
docs/en_US/images/new_connection_options.png   | Bin 0 -> 45739 bytes
docs/en_US/query_tool.rst  |  21 ++
docs/en_US/release_notes_4_27.rst  |   1 +
.../browser/server_groups/servers/__init__.py  |  10 +-
.../server_groups/servers/roles/tests/utils.py |  35 +++
web/pgadmin/model/__init__.py  |  47 +++
.../static/js/sqleditor/new_connection_dialog.js   | 262 
.../js/sqleditor/new_connection_dialog_model.js| 339 +
web/pgadmin/static/scss/_alert.scss|   1 +
web/pgadmin/tools/datagrid/__init__.py | 146 -
.../tools/datagrid/templates/datagrid/index.html   |  14 +-
web/pgadmin/tools/datagrid/tests/__init__.py   |   0
.../tools/datagrid/tests/datagrid_test_data.json   | 134 
.../tests/test_data_grid_init_query_tool.py|  73 +
.../tools/datagrid/tests/test_data_grid_panel.py   |  90 ++
.../tests/test_data_grid_query_tool_close.py   |  78 +
.../tests/test_data_grid_update_connection.py  | 121 
.../tests/test_data_grid_validate_filter.py|  92 ++
.../datagrid/tests/test_initialize_data_grid.py| 109 +++
web/pgadmin/tools/datagrid/tests/utils.py  |  33 ++
web/pgadmin/tools/sqleditor/__init__.py| 334 ++--
.../tools/sqleditor/static/css/sqleditor.css   |   9 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 154 +-
.../tools/sqleditor/static/scss/_sqleditor.scss|  13 +
.../tests/test_new_connection_database.py  | 100 ++
.../sqleditor/tests/test_new_connection_dialog.py  |  50 +++
.../sqleditor/tests/test_new_connection_user.py| 100 ++
web/pgadmin/utils/constants.py |   2 +
web/pgadmin/utils/driver/psycopg2/connection.py| 113 ---
30 files changed, 2393 insertions(+), 88 deletions(-)

pgAdmin 4 commit: Merged the latest code of 'pgcli' used for the autoco

[Akshay Joshi]

Merged the latest code of 'pgcli' used for the autocomplete feature. Fixes #5497

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=300de05a204e955d2af5568d948c9f7eb34697a7

Modified Files
--
docs/en_US/release_notes_4_27.rst  |   1 +
.../sqlautocomplete/sql/11_plus/functions.sql  |   2 +
.../sqlautocomplete/sql/default/functions.sql  |   2 +
web/pgadmin/utils/sqlautocomplete/autocomplete.py  | 503 ++---
web/pgadmin/utils/sqlautocomplete/completion.py|   5 +-
web/pgadmin/utils/sqlautocomplete/parseutils.py| 295 
.../utils/sqlautocomplete/parseutils/__init__.py   |   4 +-
.../utils/sqlautocomplete/parseutils/ctes.py   |  35 +-
.../utils/sqlautocomplete/parseutils/meta.py   | 110 +++--
.../utils/sqlautocomplete/parseutils/tables.py | 103 +++--
.../utils/sqlautocomplete/parseutils/utils.py  |  39 +-
.../utils/sqlautocomplete/prioritization.py|   4 +-
web/pgadmin/utils/sqlautocomplete/sqlcompletion.py | 283 +++-
13 files changed, 571 insertions(+), 815 deletions(-)

pgAdmin 4 commit: Fixed SQLAlchemy operation error with the boolean val

[Akshay Joshi]

Fixed SQLAlchemy operation error with the boolean value as true/false for 
Python version < 3.7

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=228d4bb3213189e2e613fb8cb49e6ce62178a1c5
Author: Khushboo Vashi 

Modified Files
--
web/migrations/versions/398697dc9550_.py| 16 
web/pgadmin/tools/sqleditor/utils/macros.py |  8 
2 files changed, 12 insertions(+), 12 deletions(-)

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

[Akshay Joshi]

Thanks, patch applied.

On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> I have resolved the sonarQube issues, PFA updated patch for the same.
>
>
> Regards,
> Nikhil Mohite.
>
>
> On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Nikhil
>>
>> Your patch introduces 1 new Bug and 13 new code smells, please fix those
>> and resend the patch.
>>
>> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Akshay,
>>>
>>> I have resolved code conflict issues and sonarqube issues.
>>> PFA updated patch.
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>> On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Nikhil

 The patch is not applying, rebase, and send it again. Please check your
 code should not create any new SonarQube issues.

 On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> I have resolved all the review comments and also updated the test
> cases as per the new implementation.
>
> PFA updated patch.
>
>
>
> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Nikhil
>>
>> Following are the initial review comments:
>>
>>- Open View/Edit data on any table and click on the same database
>>connection and then click on the Execute button. Got 
>> "get_primary_keys()
>>takes 1 positional argument but 2 were given" error.
>>- In my opinion, we should hide the option to change the database
>>connection for View/Edit Data.
>>- If the user clicks on the same database connection multiple
>>times then no need to change the backend connection and transaction 
>> id. Add
>>validation at the backend, no action required in this case.
>>- The role option is missing from the "connect to server" dialog.
>>- The Password field should not be there on the "connect to
>>server" dialog. Sometimes we saved the password so asking a password 
>> every
>>time is not correct. Check the pgAdmin 3 behavior.
>>
>> Code review still remains.
>>
>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> Regarding RM-3794 
>>> allow the user to change the database connection from an open query 
>>> tool:
>>> I have implemented the feature and also added documentation for it.
>>>
>>> PFA patch.
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* 
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Sr. Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - Fix for Sqlalchemy Operational error

[Akshay Joshi]

Thanks, patch applied.

On Wed, Sep 30, 2020 at 3:38 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Sqlalchemy gives an operational error with the SQL query with boolean
> true/false for Python versions < 3.7. Please find the attached patch to fix
> it.
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5867]:Some properties are not getting updated correctly if the server is shared server.

[Akshay Joshi]

Thanks, patch applied.

On Wed, Sep 30, 2020 at 10:56 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Akshay,
> Please find the attached patch for the API failure issue.
>
> On Wed, Sep 30, 2020 at 12:34 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Sep 30, 2020 at 11:00 AM Pradip Parkale <
>> pradip.park...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for the below issues.
>>>
>>>1. Shared with all? changed to 'Shared?'.
>>>2. Hide shared server? changed to 'Hide shared servers?'.
>>>3. Some properties of the base server were getting updated if the
>>>user updated the shared server properties so I fixed this issue.
>>>4. Fixed an issue where 'Later' and 'Refresh' button labels were
>>>getting override on disconnect server confirmation dialogue.
>>>5. If the user shares an auto-detected server and other user log-in
>>>then the auto-detected server of the second user will not be visible, the
>>>second user will see a shared auto-detected server.
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

[Pradip Parkale]

Hi Akshay,

Please find the attached patch to allow the user to modify the option
settings of the procedure. This issue was only for PPAS 11 and PPAS 12.

On Wed, Sep 23, 2020 at 11:30 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the small patch for the ' Parallel Unsafe' option is missing
> in SQL. It was missing in first patch for PG96 and PG10.
>
>
> On Wed, Sep 23, 2020 at 1:25 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied. It's a small fix so I have fixed it.
>>
>> On Wed, Sep 23, 2020 at 12:14 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Pradip
>>>
>>> RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and resend
>>> the patch.
>>>
>>> On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale <
>>> pradip.park...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 The 'Unsafe' parallel option was not visible in the SQL for function
 and procedure. Attached is the patch to fix this issue.

 --
 Thanks & Regards,
 Pradip Parkale
 Software Engineer | EnterpriseDB Corporation

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


RM5843_v3.patch
Description: Binary data

pgAdmin 4 commit: Updated 'sqlparse' and 'pytz' module to the latest ve

[Akshay Joshi]

Updated 'sqlparse' and 'pytz' module to the latest version.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=558d25fabc0c174edf6136625b91224bd105b74e

Modified Files
--
requirements.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)