[pgAdmin][RM5835]: "can't execute an empty query" message displayed if user change the option of Auto FK index ? with No

2020-10-06 Thread Pradip Parkale 
Hi Hackers,
Attached is small patch to disable the Auto FK index? option to avoid
'can't execute an empty query' message.

-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


RM5835.patch
Description: Binary data

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-06 Thread Nikhil Mohite 
Hi Akshay,

I have updated the following points as per suggestions:
1. Updated connection success message. (Added database name in the success
message.)
2. Resolve issue of the mouse pointer and dropdown will show below the
connection string only.
3. Added loader for both new connections and load existing connections.
4. Removed async: false for update connection.


Regards,
Nikhil Mohite.


On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> I have resolved the sonarQube issues, PFA updated patch for the same.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>>
>> On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil
>>>
>>> Your patch introduces 1 new Bug and 13 new code smells, please fix those
>>> and resend the patch.
>>>
>>> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 I have resolved code conflict issues and sonarqube issues.
 PFA updated patch.

 Regards,
 Nikhil Mohite.

 On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Nikhil
>
> The patch is not applying, rebase, and send it again. Please check
> your code should not create any new SonarQube issues.
>
> On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> I have resolved all the review comments and also updated the test
>> cases as per the new implementation.
>>
>> PFA updated patch.
>>
>>
>>
>> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil
>>>
>>> Following are the initial review comments:
>>>
>>>- Open View/Edit data on any table and click on the same
>>>database connection and then click on the Execute button. Got
>>>"get_primary_keys() takes 1 positional argument but 2 were given" 
>>> error.
>>>- In my opinion, we should hide the option to change the
>>>database connection for View/Edit Data.
>>>- If the user clicks on the same database connection multiple
>>>times then no need to change the backend connection and transaction 
>>> id. Add
>>>validation at the backend, no action required in this case.
>>>- The role option is missing from the "connect to server" dialog.
>>>- The Password field should not be there on the "connect to
>>>server" dialog. Sometimes we saved the password so asking a password 
>>> every
>>>time is not correct. Check the pgAdmin 3 behavior.
>>>
>>> Code review still remains.
>>>
>>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Team,

 Regarding RM-3794 
 allow the user to change the database connection from an open query 
 tool:
 I have implemented the feature and also added documentation for it.

 PFA patch.

 --
 *Thanks & Regards,*
 *Nikhil Mohite*
 *Software Engineer.*
 *EDB Postgres* 
 *Mob.No: +91-7798364578.*

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


RM_3794_V6.patch
Description: Binary data

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-06 Thread Murtuza Zabuawala 
Hi Akshay,

We have used aysnc=False in most ajax calls with this feature, It is
causing UI hang in case of slow server response.
You can try adding a time.sleep() call at the python side response and
check the UI hang, I think we should avoid sync calls as much as possible.


--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com


On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> I have resolved the sonarQube issues, PFA updated patch for the same.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>>
>> On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil
>>>
>>> Your patch introduces 1 new Bug and 13 new code smells, please fix those
>>> and resend the patch.
>>>
>>> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 I have resolved code conflict issues and sonarqube issues.
 PFA updated patch.

 Regards,
 Nikhil Mohite.

 On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Nikhil
>
> The patch is not applying, rebase, and send it again. Please check
> your code should not create any new SonarQube issues.
>
> On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> I have resolved all the review comments and also updated the test
>> cases as per the new implementation.
>>
>> PFA updated patch.
>>
>>
>>
>> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil
>>>
>>> Following are the initial review comments:
>>>
>>>- Open View/Edit data on any table and click on the same
>>>database connection and then click on the Execute button. Got
>>>"get_primary_keys() takes 1 positional argument but 2 were given" 
>>> error.
>>>- In my opinion, we should hide the option to change the
>>>database connection for View/Edit Data.
>>>- If the user clicks on the same database connection multiple
>>>times then no need to change the backend connection and transaction 
>>> id. Add
>>>validation at the backend, no action required in this case.
>>>- The role option is missing from the "connect to server" dialog.
>>>- The Password field should not be there on the "connect to
>>>server" dialog. Sometimes we saved the password so asking a password 
>>> every
>>>time is not correct. Check the pgAdmin 3 behavior.
>>>
>>> Code review still remains.
>>>
>>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Team,

 Regarding RM-3794 
 allow the user to change the database connection from an open query 
 tool:
 I have implemented the feature and also added documentation for it.

 PFA patch.

 --
 *Thanks & Regards,*
 *Nikhil Mohite*
 *Software Engineer.*
 *EDB Postgres* 
 *Mob.No: +91-7798364578.*

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

pgAdmin 4 commit: Added documentation for Macro support. Fixes #5857

2020-10-06 Thread Akshay Joshi 
Added documentation for Macro support. Fixes #5857

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=609904cfb324ff75f0207f9f3c5d27c830cd2030
Author: Nidhi Bhammar 

Modified Files
--
docs/en_US/images/query_autocomplete.png   | Bin 55221 -> 64852 bytes
docs/en_US/images/query_execute_section.png| Bin 60549 -> 106471 bytes
.../images/query_explain_analyze_statistics.png| Bin 231623 -> 243889 bytes
docs/en_US/images/query_explain_analyze_table.png  | Bin 199362 -> 230047 bytes
docs/en_US/images/query_output_data.png| Bin 63560 -> 106471 bytes
docs/en_US/images/query_output_error.png   | Bin 45774 -> 86974 bytes
docs/en_US/images/query_output_explain_details.png | Bin 145632 -> 179156 bytes
docs/en_US/images/query_output_history.png | Bin 122797 -> 168568 bytes
docs/en_US/images/query_output_messages.png| Bin 50662 -> 77489 bytes
docs/en_US/images/query_sql_editor.png | Bin 31654 -> 56223 bytes
docs/en_US/images/query_tool.png   | Bin 61412 -> 161291 bytes
docs/en_US/images/query_tool_editable_columns.png  | Bin 50504 -> 166937 bytes
.../query_tool_macros_clear_confirmation.png   | Bin 0 -> 129827 bytes
docs/en_US/images/query_tool_macros_clear_row.png  | Bin 0 -> 98301 bytes
docs/en_US/images/query_tool_macros_execution.png  | Bin 0 -> 97558 bytes
.../images/query_tool_manage_macros_dialog.png | Bin 0 -> 108198 bytes
docs/en_US/images/query_tool_message.png   | Bin 57788 -> 75236 bytes
docs/en_US/images/query_toolbar.png| Bin 27317 -> 27844 bytes
docs/en_US/images/query_toolbar_explain.png| Bin 75873 -> 173583 bytes
docs/en_US/query_tool.rst  |  31 -
docs/en_US/query_tool_toolbar.rst  |   3 ++
docs/en_US/release_notes_4_27.rst  |   3 +-
22 files changed, 35 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Added RESQL/MSQL test cases for Functions. Fixes #539

2020-10-06 Thread Akshay Joshi 
Added RESQL/MSQL test cases for Functions. Fixes #5395

Initial patch sent by Nikhil Mohite.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c4049f29a36e2193aca786c5f7db5c2fe997939

Modified Files
--
docs/en_US/release_notes_4_27.rst  |   1 +
.../templates/functions/pg/sql/11_plus/create.sql  |  69 --
.../templates/functions/pg/sql/12_plus/create.sql  |  11 +-
.../templates/functions/pg/sql/9.6_plus/create.sql |   7 +-
.../functions/ppas/sql/12_plus/create.sql  |  23 +-
.../functions/ppas/sql/9.6_plus/create.sql |  19 +-
.../functions/ppas/sql/9.6_plus/properties.sql |  35 +++
.../templates/functions/ppas/sql/default/acl.sql   |   3 +-
.../tests/pg/11_plus/alter_function_add_acl.msql   |   1 +
.../tests/pg/11_plus/alter_function_add_acl.sql|  24 ++
.../pg/11_plus/alter_function_add_parameter.msql   |  13 +
.../pg/11_plus/alter_function_add_parameter.sql|  20 ++
.../tests/pg/11_plus/alter_function_comment.msql   |   2 +
.../tests/pg/11_plus/alter_function_comment.sql|  22 ++
.../pg/11_plus/alter_function_delete_acl.msql  |   3 +
.../tests/pg/11_plus/alter_function_delete_acl.sql |  19 ++
.../11_plus/alter_function_delete_parameter.msql   |   2 +
.../pg/11_plus/alter_function_delete_parameter.sql |  19 ++
.../tests/pg/11_plus/alter_function_rename.msql|   2 +
.../tests/pg/11_plus/alter_function_rename.sql |  19 ++
.../tests/pg/11_plus/create_function.msql  |  14 ++
.../functions/tests/pg/11_plus/create_function.sql |  20 ++
.../pg/11_plus/create_function_for_alter.msql  |  14 ++
.../tests/pg/11_plus/create_function_for_alter.sql |  19 ++
.../functions/tests/pg/11_plus/test_function.json  | 260 
.../tests/pg/12_plus/alter_function_add_acl.msql   |   1 +
.../tests/pg/12_plus/alter_function_add_acl.sql|  24 ++
.../pg/12_plus/alter_function_add_parameter.msql   |  14 ++
.../pg/12_plus/alter_function_add_parameter.sql|  20 ++
.../tests/pg/12_plus/alter_function_comment.msql   |   2 +
.../tests/pg/12_plus/alter_function_comment.sql|  22 ++
.../pg/12_plus/alter_function_delete_acl.msql  |   3 +
.../tests/pg/12_plus/alter_function_delete_acl.sql |  19 ++
.../12_plus/alter_function_delete_parameter.msql   |   2 +
.../pg/12_plus/alter_function_delete_parameter.sql |  19 ++
.../tests/pg/12_plus/alter_function_rename.msql|   2 +
.../tests/pg/12_plus/alter_function_rename.sql |  19 ++
.../tests/pg/12_plus/alter_proc_comment.sql|  15 ++
.../tests/pg/12_plus/alter_proc_comment_msql.sql   |   2 +
.../tests/pg/12_plus/alter_proc_param.sql  |  16 ++
.../tests/pg/12_plus/alter_proc_param_msql.sql |   2 +
.../tests/pg/12_plus/alter_ptrig_comment.sql   |  20 ++
.../tests/pg/12_plus/alter_ptrig_set_1.sql |  20 ++
.../tests/pg/12_plus/alter_ptrig_set_2.sql |  22 ++
.../tests/pg/12_plus/alter_ptrig_set_3.sql |  23 ++
.../tests/pg/12_plus/create_event_trigger_full.sql |  26 ++
.../tests/pg/12_plus/create_function.msql  |  14 ++
.../functions/tests/pg/12_plus/create_function.sql |  20 ++
.../pg/12_plus/create_function_for_alter.msql  |  14 ++
.../tests/pg/12_plus/create_function_for_alter.sql |  19 ++
.../tests/pg/12_plus/create_plain_trigger.sql  |  17 ++
.../tests/pg/12_plus/create_plain_trigger_full.sql |  27 ++
.../tests/pg/12_plus/create_procedure.sql  |  12 +
.../functions/tests/pg/12_plus/test_function.json  | 260 
.../tests/pg/12_plus/test_procedures.json  |  58 +
.../tests/pg/12_plus/test_trigger_functions.json   | 191 +++
.../tests/pg/9.5_plus/alter_function_add_acl.msql  |   1 +
.../tests/pg/9.5_plus/alter_function_add_acl.sql   |  26 ++
.../pg/9.5_plus/alter_function_add_parameter.msql  |  12 +
.../pg/9.5_plus/alter_function_add_parameter.sql   |  20 ++
.../tests/pg/9.5_plus/alter_function_comment.msql  |   2 +
.../tests/pg/9.5_plus/alter_function_comment.sql   |  22 ++
.../pg/9.5_plus/alter_function_delete_acl.msql |   3 +
.../pg/9.5_plus/alter_function_delete_acl.sql  |  19 ++
.../9.5_plus/alter_function_delete_parameter.msql  |   2 +
.../9.5_plus/alter_function_delete_parameter.sql   |  19 ++
.../tests/pg/9.5_plus/alter_function_rename.msql   |   2 +
.../tests/pg/9.5_plus/alter_function_rename.sql|  19 ++
.../tests/pg/9.5_plus/alter_ptrig_comment.sql  |  20 ++
.../tests/pg/9.5_plus/alter_ptrig_set_1.sql|  20 ++
.../tests/pg/9.5_plus/alter_ptrig_set_2.sql|  22 ++
.../tests/pg/9.5_plus/alter_ptrig_set_3.sql|  23 ++
.../pg/9.5_plus/create_event_trigger_full.sql  |  26 ++
.../tests/pg/9.5_plus/create_function.msql |  14 ++
.../tests/pg/9.5_plus/create_function.sql  |  20 ++
.../pg/9.5_plus/create_function_for_alter.msql |  14 ++
.../pg/9.5_plus/create_function_for_alter.sql  |  19 ++
.../tests/pg/9.5_plus/create_plain_trigger.sql |  17 ++
.../pg/9.5_plus

pgAdmin 4 commit: Fixed 'can't execute an empty query' message if the u

2020-10-06 Thread Akshay Joshi 
Fixed 'can't execute an empty query' message if the user change the option of 
Auto FK Index. Fixes #5835

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82e912ffad8e3fab2dbe4c953055de704f966c97
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_4_27.rst  | 3 ++-
.../schemas/tables/constraints/foreign_key/static/js/foreign_key.js| 3 +++
2 files changed, 5 insertions(+), 1 deletion(-)

Re: [pgAdmin][RM5835]: "can't execute an empty query" message displayed if user change the option of Auto FK index ? with No

2020-10-06 Thread Akshay Joshi 
Thanks, patch applied.

On Tue, Oct 6, 2020 at 1:51 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
> Attached is small patch to disable the Auto FK index? option to avoid
> 'can't execute an empty query' message.
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5822]: Unable to change Start value for existing sequence

2020-10-06 Thread Akshay Joshi 
Thanks, patch applied.

On Mon, Oct 5, 2020 at 3:48 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch to allow the user to change the start value
> of the existing sequence.
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: RM_5857 patch - Macros Documentation

2020-10-06 Thread Akshay Joshi 
Thanks, patch applied.

On Tue, Oct 6, 2020 at 4:10 PM Nidhi Bhammar 
wrote:

> Hi,
>
> I have drafted the documentation for the Macros and attached the patch for
> the same. Also, I have replaced all the query tool screenshots so that the
> Macros icon is visible.
>
> Let me know your review comments.
>
> Thanks,
>
> Best Regards,
> Nidhi Bhammar
>
>
> www.enterprisedb.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5395]: [Housekeeping]-Add RE-SQL/MSQL test cases for Functions

2020-10-06 Thread Akshay Joshi 
Thanks, patch applied. Modified the behavior and also updated test cases
accordingly.

On Mon, Oct 5, 2020 at 6:24 PM Nikhil Mohite 
wrote:

> Hi Team,
>
> I have added a few more RE-SQL/MSQL test cases as per RM-5395
> .
> PFA patch.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-06 Thread Akshay Joshi 
Hi Nikhil

Please verify and remove async = false wherever possible.

On Tue, Oct 6, 2020 at 5:24 PM Dave Page  wrote:

>
>
> On Tue, Oct 6, 2020 at 12:51 PM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> We have used aysnc=False in most ajax calls with this feature, It is
>> causing UI hang in case of slow server response.
>> You can try adding a time.sleep() call at the python side response and
>> check the UI hang, I think we should avoid sync calls as much as possible.
>>
>
> I consider a sync ajax call to be a bug.
>
>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>>
>> On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 I have resolved the sonarQube issues, PFA updated patch for the same.


 Regards,
 Nikhil Mohite.


 On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Nikhil
>
> Your patch introduces 1 new Bug and 13 new code smells, please fix
> those and resend the patch.
>
> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> I have resolved code conflict issues and sonarqube issues.
>> PFA updated patch.
>>
>> Regards,
>> Nikhil Mohite.
>>
>> On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil
>>>
>>> The patch is not applying, rebase, and send it again. Please check
>>> your code should not create any new SonarQube issues.
>>>
>>> On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 I have resolved all the review comments and also updated the test
 cases as per the new implementation.

 PFA updated patch.



 On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Nikhil
>
> Following are the initial review comments:
>
>- Open View/Edit data on any table and click on the same
>database connection and then click on the Execute button. Got
>"get_primary_keys() takes 1 positional argument but 2 were given" 
> error.
>- In my opinion, we should hide the option to change the
>database connection for View/Edit Data.
>- If the user clicks on the same database connection multiple
>times then no need to change the backend connection and 
> transaction id. Add
>validation at the backend, no action required in this case.
>- The role option is missing from the "connect to server"
>dialog.
>- The Password field should not be there on the "connect to
>server" dialog. Sometimes we saved the password so asking a 
> password every
>time is not correct. Check the pgAdmin 3 behavior.
>
> Code review still remains.
>
> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> Regarding RM-3794 
>> allow the user to change the database connection from an open query 
>> tool:
>> I have implemented the feature and also added documentation for
>> it.
>>
>> PFA patch.
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> Dave Page
> VP & Chief Architect, Database Infrastructure
> EDB: http://www.enterpri

pgAdmin 4 commit: Fixed API test cases failed for PG 9.5 due to change

2020-10-06 Thread Akshay Joshi 
Fixed API test cases failed for PG 9.5 due to change in the order of ACL.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f27527a614fa7acb278afe1ac5bc304423d5f651

Modified Files
--
.../schemas/functions/templates/functions/pg/sql/default/acl.sql  | 3 ++-
.../schemas/functions/tests/pg/11_plus/alter_function_add_acl.sql | 4 ++--
.../schemas/functions/tests/pg/12_plus/alter_function_add_acl.sql | 4 ++--
.../schemas/functions/tests/pg/9.6_plus/alter_function_add_acl.sql| 4 ++--
4 files changed, 8 insertions(+), 7 deletions(-)

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-06 Thread Nikhil Mohite 
Hi Akshay,

I checked the implementation and found 2 locations which I missed in the
last patch to remove async: False.
I have removed all occurrences of async: False now also added missing
loader in required places.

PFA updated the patch for the same.

Regards,
Nikhil Mohite.

On Tue, Oct 6, 2020 at 6:19 PM Akshay Joshi 
wrote:

> Hi Nikhil
>
> Please verify and remove async = false wherever possible.
>
> On Tue, Oct 6, 2020 at 5:24 PM Dave Page 
> wrote:
>
>>
>>
>> On Tue, Oct 6, 2020 at 12:51 PM Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Akshay,
>>>
>>> We have used aysnc=False in most ajax calls with this feature, It is
>>> causing UI hang in case of slow server response.
>>> You can try adding a time.sleep() call at the python side response and
>>> check the UI hang, I think we should avoid sync calls as much as possible.
>>>
>>
>> I consider a sync ajax call to be a bug.
>>
>>
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> *EDB*
>>> *POWER TO POSTGRES*
>>> https://www.edbpostgres.com
>>>
>>>
>>> On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, patch applied.

 On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> I have resolved the sonarQube issues, PFA updated patch for the same.
>
>
> Regards,
> Nikhil Mohite.
>
>
> On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Nikhil
>>
>> Your patch introduces 1 new Bug and 13 new code smells, please fix
>> those and resend the patch.
>>
>> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Akshay,
>>>
>>> I have resolved code conflict issues and sonarqube issues.
>>> PFA updated patch.
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>> On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Nikhil

 The patch is not applying, rebase, and send it again. Please check
 your code should not create any new SonarQube issues.

 On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> I have resolved all the review comments and also updated the test
> cases as per the new implementation.
>
> PFA updated patch.
>
>
>
> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Nikhil
>>
>> Following are the initial review comments:
>>
>>- Open View/Edit data on any table and click on the same
>>database connection and then click on the Execute button. Got
>>"get_primary_keys() takes 1 positional argument but 2 were given" 
>> error.
>>- In my opinion, we should hide the option to change the
>>database connection for View/Edit Data.
>>- If the user clicks on the same database connection multiple
>>times then no need to change the backend connection and 
>> transaction id. Add
>>validation at the backend, no action required in this case.
>>- The role option is missing from the "connect to server"
>>dialog.
>>- The Password field should not be there on the "connect to
>>server" dialog. Sometimes we saved the password so asking a 
>> password every
>>time is not correct. Check the pgAdmin 3 behavior.
>>
>> Code review still remains.
>>
>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> Regarding RM-3794 
>>> allow the user to change the database connection from an open query 
>>> tool:
>>> I have implemented the feature and also added documentation for
>>> it.
>>>
>>> PFA patch.
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* 
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Sr. Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*
>>>