Re: [pgAdmin][RM4855] Renaming a file removes the file extension

2020-10-08 Thread Akshay Joshi 
Thanks, patch applied.

On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix a bug where extension file extension is
> stripped on renaming a file.
> Pleasure review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5131] ctrl + a shortcut does not move cursor in sql editor with macOS

2020-10-08 Thread Akshay Joshi 
Thanks, patch applied.

On Mon, Sep 28, 2020 at 6:12 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> Please find the updated patch.
>
> On Mon, Sep 28, 2020 at 5:59 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Aditya
>>
>> The patch is not applying, rebase, and send it again.
>>
>> On Mon, Sep 28, 2020 at 3:23 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached patch removes the incorrect overriding of default CodeMirror
>>> shortcuts.
>>> Please review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM4855] Renaming a file removes the file extension

2020-10-08 Thread Aditya Toshniwal 
Hi,

Attached patch will add the .sql when saving a file and and format -> sql
selected, no matter what the file name is.
Please review.

On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix a bug where extension file extension is
>> stripped on renaming a file.
>> Pleasure review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM4855.part2.patch
Description: Binary data

pgAdmin 4 commit: Ensure that '.sql' extension is added when saving a f

2020-10-08 Thread Akshay Joshi 
Ensure that '.sql' extension is added when saving a file with SQL format.

refs #4855

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4e746c5a46bb42937cc4e54c1ba921d66838f10
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/misc/file_manager/static/js/create_dialogue.js | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

pgAdmin 4 commit: Updated the packages and yarn.lock file.

2020-10-08 Thread Akshay Joshi 
Updated the packages and yarn.lock file.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca8dc42d147ddf31ec766c3fe93fd024df5fdc26
Author: Aditya Toshniwal 

Modified Files
--
tools/requirements.txt |2 +-
web/yarn.lock  | 1941 
2 files changed, 815 insertions(+), 1128 deletions(-)

pgAdmin 4 commit: Update the macro help link.

2020-10-08 Thread Akshay Joshi 
Update the macro help link.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4d6290b507a44b0344455d78a14911177e4ad9e
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/static/js/sqleditor/macro.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin][RM4855] Renaming a file removes the file extension

2020-10-08 Thread Akshay Joshi 
Thanks, patch applied.

On Thu, Oct 8, 2020 at 6:34 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> Attached patch will add the .sql when saving a file and and format -> sql
> selected, no matter what the file name is.
> Please review.
>
> On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi 
> wrote:
>
>> Thanks, patch applied.
>>
>> On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix a bug where extension file extension is
>>> stripped on renaming a file.
>>> Pleasure review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> 
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][patch] Packages security fixes

2020-10-08 Thread Akshay Joshi 
Thanks, patch applied.

On Thu, Oct 8, 2020 at 1:31 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> Attached patch updates the yarn.lock and tools/requirements.txt to fix the
> security issues of packages.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed linter error.

2020-10-08 Thread Akshay Joshi 
Fixed linter error.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bf6e81faa99db0966d04dfde50f0ca7278e84ae

Modified Files
--
web/pgadmin/misc/file_manager/static/js/create_dialogue.js | 6 --
1 file changed, 6 deletions(-)