date:20201130

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-11-30 Thread Dave Page

Hi

On Mon, Nov 30, 2020 at 7:12 AM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Dave,
>
> There are issues discussed on Apple forums, check this out:
>
> https://developer.apple.com/forums/thread/129064 - The latest comment by
> the user here is one month ago, meaning the issue is still not fixed yet.
> https://developer.apple.com/forums/thread/658688 - Users facing this
> issue in v13.x
>
> Even webkit has confirmed about this issue :
> https://bugs.webkit.org/show_bug.cgi?id=198181 - Users facing this issue
> in v12.x
>

In that case, I think the answer (for now at least) is an FAQ, referencing
those issues and explaining how to resolve the issue using config_system.py
or by using a different browser.

Have we actually seen this issue in wild?



>
> On Thu, Nov 26, 2020 at 6:57 PM Dave Page  wrote:
>
>> Hi
>>
>> On Wed, Nov 25, 2020 at 10:37 AM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Due to SameSite security issues in Safari Browser, some of the pgadmin4
>>> functionality isn't working (mostly the new tab functionality).
>>>
>>> The affected Safari Browser versions (marked in red) currently tested
>>> upon are:
>>>
>>>1. v11.1.2
>>>2. v12.1
>>>3. v12.1.1
>>>4. 13.1
>>>5. 14.0.1
>>>
>>> Since v12, Safari have done some security fixes, due to which this issue
>>> has occurred. Strangely, the issue is not reproducible on v13, but
>>> reproducible on its successor i.e. v14
>>>
>>> Possible solutions could be:
>>>
>>>1. Reporting this to Safari & raising an RM for tracking purposes.
>>>2. Suggesting Safari users to make below changes in config.py or
>>>config_distro for the work around:
>>>
>>> *SESSION_COOKIE_SAMESITE = None*
>>>
>>> *SESSION_COOKIE_SECURE = True*
>>> (As we aren't going through any cross-site cookie transfer, this can be
>>> a handy option - but still risky..)
>>>
>>> I would suggest going with the 1st option or combination of both, but
>>> with caution.
>>>
>>
>> Others must have come across this issue already. Is it a known bug,
>> documented somewhere (ideally on apple.com)?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-11-30 Thread Rahul Shirsat

This was the part of our internal quality testing, where it got
encountered. Currently, none of the users have complained about this on
their specific browser versions.

On Mon, Nov 30, 2020 at 5:12 PM Dave Page  wrote:

> Hi
>
> On Mon, Nov 30, 2020 at 7:12 AM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Dave,
>>
>> There are issues discussed on Apple forums, check this out:
>>
>> https://developer.apple.com/forums/thread/129064 - The latest comment by
>> the user here is one month ago, meaning the issue is still not fixed yet.
>> https://developer.apple.com/forums/thread/658688 - Users facing this
>> issue in v13.x
>>
>> Even webkit has confirmed about this issue :
>> https://bugs.webkit.org/show_bug.cgi?id=198181 - Users facing this issue
>> in v12.x
>>
>
> In that case, I think the answer (for now at least) is an FAQ, referencing
> those issues and explaining how to resolve the issue using config_system.py
> or by using a different browser.
>
> Have we actually seen this issue in wild?
>
>
>
>>
>> On Thu, Nov 26, 2020 at 6:57 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Wed, Nov 25, 2020 at 10:37 AM Rahul Shirsat <
>>> rahul.shir...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Due to SameSite security issues in Safari Browser, some of the pgadmin4
 functionality isn't working (mostly the new tab functionality).

 The affected Safari Browser versions (marked in red) currently tested
 upon are:

1. v11.1.2
2. v12.1
3. v12.1.1
4. 13.1
5. 14.0.1

 Since v12, Safari have done some security fixes, due to which this
 issue has occurred. Strangely, the issue is not reproducible on v13, but
 reproducible on its successor i.e. v14

 Possible solutions could be:

1. Reporting this to Safari & raising an RM for tracking purposes.
2. Suggesting Safari users to make below changes in config.py or
config_distro for the work around:

 *SESSION_COOKIE_SAMESITE = None*

 *SESSION_COOKIE_SECURE = True*
 (As we aren't going through any cross-site cookie transfer, this can be
 a handy option - but still risky..)

 I would suggest going with the 1st option or combination of both, but
 with caution.

>>>
>>> Others must have come across this issue already. Is it a known bug,
>>> documented somewhere (ideally on apple.com)?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: http://www.enterprisedb.com
>>>
>>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.

[pgAdmin][RM-5991]: Renaming tabs doesn't account for the dirty editor indicator.

2020-11-30 Thread Nikhil Mohite

Hi Team,

Please refer patch for RM-5991
:
Renaming
tabs doesn't account for the dirty editor indicator.
also added changes for not allow a user to add empty spaces while renaming
the panel title.

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM_5991.patch
Description: Binary data

[pgAdmin][Patch] Bug #5886 - New foreign key creation on exist table

2020-11-30 Thread Yogesh Mahajan

Hi,

Please find the attached patch which fixes the false error shown while
adding a new foreign key from table dialogue in case of an already existing
foreign key with Auto FK Index=True to table.

Thanks,
Yogesh Mahajan
EnterpriseDB
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js
index 302728bad..a36d385ae 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/foreign_key/static/js/foreign_key.js
@@ -1097,11 +1097,13 @@ define('pgadmin.node.foreign_key', [
 
   var coveringindex = this.get('coveringindex'),
 autoindex = this.get('autoindex');
-  if (autoindex && (_.isUndefined(coveringindex) || _.isNull(coveringindex) ||
-  String(coveringindex).replace(/^\s+|\s+$/g, '') == '')) {
-msg = gettext('Please specify covering index name.');
-this.errorModel.set('coveringindex', msg);
-return msg;
+  if (this.isNew()){
+if (autoindex && (_.isUndefined(coveringindex) || _.isNull(coveringindex) ||
+String(coveringindex).replace(/^\s+|\s+$/g, '') == '')) {
+  msg = gettext('Please specify covering index name.');
+  this.errorModel.set('coveringindex', msg);
+  return msg;
+}
   }
 
   return null;

pgAdmin 4 commit: Ensure that dirty indicator (*) should not be visible

2020-11-30 Thread Akshay Joshi

Ensure that dirty indicator (*) should not be visible when renaming the tabs. 
Fixes #5991

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=abd0748a770146672d7592f9a3232c72bb725559
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_29.rst  |  1 +
web/pgadmin/tools/datagrid/static/js/datagrid.js   | 11 +--
web/pgadmin/tools/debugger/static/js/debugger.js   |  4 
web/pgadmin/tools/debugger/static/js/debugger_ui.js|  2 ++
web/pgadmin/tools/schema_diff/static/js/schema_diff.js |  2 ++
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  9 +++--
6 files changed, 25 insertions(+), 4 deletions(-)

pgAdmin 4 commit: Fixed false error is shown while adding a new foreign

2020-11-30 Thread Akshay Joshi

Fixed false error is shown while adding a new foreign key from the table dialog 
when a foreign key already exists with Auto FK Index set to true. Fixes #5886

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=783b7516a74b2d4f1d4a377adb2b00294f7ec702
Author: Yogesh Mahajan 

Modified Files
--
docs/en_US/release_notes_4_29.rst|  1 +
.../tables/constraints/foreign_key/static/js/foreign_key.js  | 12 +++-
2 files changed, 8 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Fixed an issue where escape character is shown when t

2020-11-30 Thread Akshay Joshi

Fixed an issue where escape character is shown when the server/database name 
has some special characters. Fixes #5992

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb51ef569e0efe2fa73d16719097dc18375109b3
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_29.rst  |  1 +
.../datagrid/static/js/datagrid_panel_title.js | 24 +++---
2 files changed, 13 insertions(+), 12 deletions(-)

Re: [pgAdmin][Patch] Bug #5886 - New foreign key creation on exist table

2020-11-30 Thread Akshay Joshi

Thanks, patch applied.

On Tue, Dec 1, 2020 at 11:04 AM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch which fixes the false error shown while
> adding a new foreign key from table dialogue in case of an already existing
> foreign key with Auto FK Index=True to table.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-5991]: Renaming tabs doesn't account for the dirty editor indicator.

2020-11-30 Thread Akshay Joshi

Thanks, patch applied.

On Tue, Dec 1, 2020 at 10:04 AM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> Please refer patch for RM-5991
> :
>  Renaming
> tabs doesn't account for the dirty editor indicator.
> also added changes for not allow a user to add empty spaces while renaming
> the panel title.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-5992]: Escape character shown when server/database name has some special characters.

2020-11-30 Thread Akshay Joshi

Thanks, patch applied.

On Thu, Nov 26, 2020 at 1:43 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> Please find the patch for RM-5992
> : Escape character shown when
> server/database name has some special characters.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: SameSite issues in Safari Browser (reference #RM5975)

Re: SameSite issues in Safari Browser (reference #RM5975)

[pgAdmin][RM-5991]: Renaming tabs doesn't account for the dirty editor indicator.

[pgAdmin][Patch] Bug #5886 - New foreign key creation on exist table

pgAdmin 4 commit: Ensure that dirty indicator (*) should not be visible

pgAdmin 4 commit: Fixed false error is shown while adding a new foreign

pgAdmin 4 commit: Fixed an issue where escape character is shown when t

Re: [pgAdmin][Patch] Bug #5886 - New foreign key creation on exist table

Re: [pgAdmin][RM-5991]: Renaming tabs doesn't account for the dirty editor indicator.

Re: [pgAdmin][RM-5992]: Escape character shown when server/database name has some special characters.

10 matches

Site Navigation

Mail list logo

Footer information