[pgAdmin] RM5875 template1 is shown after you use pg_upgrade

[Rahul Shirsat]

Hi Hackers,

Please find the attached patch below which resolves the issue of showing
template1 after pg_upgrade.

Testing of the patch has been done on :

   1. Windows Server 2016 (PostgreSQL 12.5, compiled by Visual C++ build
   1914, 64-bit & PostgreSQL 13.1, compiled by Visual C++ build 1914, 64-bit)
   2. MacOSX


-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM5875.patch
Description: Binary data

Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger

[Nikhil Mohite]

Hi Team,

Please find the updated patch for debugger test cases.
1. Added check to skip debugger test case if the plugin is not installed.
2. Added code to delete the existing "pldbgapi" extension and create a new
extension.
3. Updated a few test cases that are falling on specific servers.


Regards,
Nikhil Mohite.

On Wed, Dec 9, 2020 at 1:37 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Wed, Dec 9, 2020 at 1:24 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay/Team,
>>
>> Please find the small patch for debugger test cases.
>> Added random function name generation for the debugger.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>>
>> On Mon, Dec 7, 2020 at 3:32 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Akshay/Team,
>>>
>>> Please find the updated patch for debugger test cases.
>>> 1. Resolved the issues related to the database connection.
>>> 2. Updated the create "pldbgapi" extension for the debugger.
>>>
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>> On Thu, Dec 3, 2020 at 10:47 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, patch applied.

 On Wed, Dec 2, 2020 at 11:25 AM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay,
>
> please find the updated patch, sorry for the inconvenience.
>
>
> Regards,
> Nikhil Mohite.
>
> On Wed, Dec 2, 2020 at 11:03 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Nikhil
>>
>> The patch is not applied, please rebase and send the patch again.
>>
>> On Tue, Dec 1, 2020 at 2:48 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> Please find the attached patch for RM-5343
>>> : [Code Coverage]
>>> Improve API test cases for Debugger.
>>> also updated implementation to remove dead code and unhandled
>>> exceptions.
>>>
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* 
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


RM_5343_v5.patch
Description: Binary data

[pgAdmin][RM-6046]: [Query Tool] state of Save File icon does not match dirty editor indicator.

[Nikhil Mohite]

Hi Team,

Please find the attached patch for RM-6046:
 [Query Tool] state of Save
File icon does not match the dirty editor indicator.



-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM_6046.patch
Description: Binary data

pgAdmin 4 commit: Ensure that the 'template1' database should not be vi

[Akshay Joshi]

Ensure that the 'template1' database should not be visible after pg_upgrade. 
Fixes #5875

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb0a914099a6abd72b9a69d07f59d32a6a3f9104
Author: Rahul Shirsat 

Modified Files
--
docs/en_US/release_notes_4_30.rst  |  1 +
.../server_groups/servers/databases/__init__.py| 36 --
.../servers/databases/event_triggers/__init__.py   |  9 +-
.../servers/databases/extensions/__init__.py   |  7 -
.../databases/foreign_data_wrappers/__init__.py|  7 -
.../foreign_servers/__init__.py|  7 -
.../foreign_servers/user_mappings/__init__.py  |  7 -
.../servers/databases/languages/__init__.py|  6 +++-
.../servers/databases/schemas/__init__.py  |  8 -
.../databases/schemas/catalog_objects/__init__.py  |  8 -
.../schemas/catalog_objects/columns/__init__.py|  9 +-
.../databases/schemas/collations/__init__.py   |  7 -
.../schemas/domains/domain_constraints/__init__.py |  8 -
.../databases/schemas/foreign_tables/__init__.py   |  7 -
.../schemas/fts_configurations/__init__.py |  8 -
.../databases/schemas/fts_dictionaries/__init__.py |  6 +++-
.../databases/schemas/fts_parsers/__init__.py  |  6 +++-
.../databases/schemas/fts_templates/__init__.py|  6 +++-
.../databases/schemas/sequences/__init__.py|  6 +++-
.../servers/databases/schemas/synonyms/__init__.py |  7 -
.../databases/sql/9.1_plus/properties.sql  |  2 ++
.../databases/sql/9.2_plus/properties.sql  |  2 ++
.../templates/databases/sql/default/nodes.sql  |  2 ++
.../templates/databases/sql/default/properties.sql |  2 ++
web/pgadmin/utils/driver/psycopg2/connection.py|  3 +-
25 files changed, 148 insertions(+), 29 deletions(-)

pgAdmin 4 commit: 1. Added check to skip debugger test case if the plug

[Akshay Joshi]

1. Added check to skip debugger test case if the plugin is not installed.
2. Added code to delete the existing "pldbgapi" extension and create a new 
extension.
3. Updated a few test cases that are falling on specific servers.
4. Fixed test cases for pgAgent.

Fixed by: Nikhil & Yogesh

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=21333490efdf188d29c5c86c43e8a381f5369d81

Modified Files
--
.../server_groups/servers/pgagent/__init__.py  |   2 +-
.../servers/pgagent/schedules/__init__.py  |   2 +-
.../servers/pgagent/steps/__init__.py  |   2 +-
.../tools/debugger/tests/debugger_test_data.json   | 112 +++--
.../tools/debugger/tests/test_close_debugger.py|   2 +-
.../tests/test_debugger_clear_all_breakpoint.py|   4 +-
.../tests/test_debugger_clear_arguments.py |   2 +-
.../tools/debugger/tests/test_debugger_direct.py   |   2 +-
.../debugger/tests/test_debugger_execute_query.py  |   4 +-
.../tests/test_debugger_poll_execution_result.py   |   4 +-
.../debugger/tests/test_debugger_poll_result.py|   2 +-
.../debugger/tests/test_debugger_set_arguments.py  |   2 +-
.../debugger/tests/test_debugger_set_breakpoint.py |   4 +-
.../debugger/tests/test_init_debugger_function.py  |   2 +-
.../debugger/tests/test_init_debugger_trigger.py   |   2 +-
.../tools/debugger/tests/test_init_target.py   |   3 +-
.../tools/debugger/tests/test_messages_debugger.py |   2 +-
.../tools/debugger/tests/test_restart_debugger.py  |   2 +-
.../tests/test_start_execution_debugger.py |   4 +-
.../debugger/tests/test_start_listener_debugger.py |   2 +-
web/pgadmin/tools/debugger/tests/utils.py  |  31 +-
21 files changed, 110 insertions(+), 82 deletions(-)

pgAdmin 4 commit: 1) Dirty indicator and save button issues.

[Akshay Joshi]

1) Dirty indicator and save button issues.
2) Text replacements as suggested by Dave.
3) Replace outlined icons with solid ones.
4) Add correct pgAdmin version in .pgerd files.
5) Do not show the download image option till it is completed.

Branch
--
ERDTool

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38a4555b30ac99bd0a2c004ab150dcf59af02f5c
Author: Aditya Toshniwal 

Modified Files
--
web/pgadmin/browser/__init__.py|1 +
web/pgadmin/browser/templates/browser/js/utils.js  |1 +
.../tools/erd/static/js/erd_tool/ERDCore.js|   30 +-
.../erd/static/js/erd_tool/links/OneToManyLink.jsx |  481 
.../erd/static/js/erd_tool/nodes/TableNode.jsx |  341 +++---
.../js/erd_tool/ui_components/BodyWidget.jsx   | 1165 ++--
.../js/erd_tool/ui_components/ConnectionBar.jsx|   12 +-
.../js/erd_tool/ui_components/FloatingNote.jsx |5 +-
.../static/js/erd_tool/ui_components/ToolBar.jsx   |7 +-
web/pgadmin/tools/erd/static/scss/_erd.scss|4 +
.../erd/ui_components/body_widget_spec.js  |   42 +-
.../javascript/erd/ui_components/toolbar_spec.js   |2 +-
12 files changed, 1070 insertions(+), 1021 deletions(-)

Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger

[Akshay Joshi]

Thanks, patch applied.

On Tue, Dec 15, 2020 at 4:20 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> Please find the updated patch for debugger test cases.
> 1. Added check to skip debugger test case if the plugin is not installed.
> 2. Added code to delete the existing "pldbgapi" extension and create a new
> extension.
> 3. Updated a few test cases that are falling on specific servers.
>
>
> Regards,
> Nikhil Mohite.
>
> On Wed, Dec 9, 2020 at 1:37 PM Akshay Joshi 
> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Dec 9, 2020 at 1:24 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Akshay/Team,
>>>
>>> Please find the small patch for debugger test cases.
>>> Added random function name generation for the debugger.
>>>
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>>
>>> On Mon, Dec 7, 2020 at 3:32 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay/Team,

 Please find the updated patch for debugger test cases.
 1. Resolved the issues related to the database connection.
 2. Updated the create "pldbgapi" extension for the debugger.


 Regards,
 Nikhil Mohite.

 On Thu, Dec 3, 2020 at 10:47 AM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks, patch applied.
>
> On Wed, Dec 2, 2020 at 11:25 AM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay,
>>
>> please find the updated patch, sorry for the inconvenience.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>> On Wed, Dec 2, 2020 at 11:03 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Nikhil
>>>
>>> The patch is not applied, please rebase and send the patch again.
>>>
>>> On Tue, Dec 1, 2020 at 2:48 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Team,

 Please find the attached patch for RM-5343
 : [Code Coverage]
 Improve API test cases for Debugger.
 also updated implementation to remove dead code and unhandled
 exceptions.


 --
 *Thanks & Regards,*
 *Nikhil Mohite*
 *Software Engineer.*
 *EDB Postgres* 
 *Mob.No: +91-7798364578.*

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin] RM5875 template1 is shown after you use pg_upgrade

[Akshay Joshi]

Thanks, patch applied.

On Tue, Dec 15, 2020 at 2:46 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch below which resolves the issue of showing
> template1 after pg_upgrade.
>
> Testing of the patch has been done on :
>
>1. Windows Server 2016 (PostgreSQL 12.5, compiled by Visual C++ build
>1914, 64-bit & PostgreSQL 13.1, compiled by Visual C++ build 1914, 64-bit)
>2. MacOSX
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*