pgAdmin 4 commit: 1) The many to many links of the new table going to s

2020-12-17 Thread Akshay Joshi
1) The many to many links of the new table going to same column.
2) Save icon not enabled if note changed.

Branch
--
ERDTool

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93793cf0a829e53d595ca72fafe8a3e05036992a
Author: Aditya Toshniwal 

Modified Files
--
.../erd/static/js/erd_tool/ui_components/BodyWidget.jsx | 13 +++--
.../erd/static/js/erd_tool/ui_components/FloatingNote.jsx   |  5 +++--
2 files changed, 14 insertions(+), 4 deletions(-)



Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger

2020-12-17 Thread Nikhil Mohite
Hi Akshay/ Team,

Please find attached an updated patch for debugger test cases.

Regards,
Nikhil Mohite.

On Wed, Dec 16, 2020 at 12:12 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Tue, Dec 15, 2020 at 4:20 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> Please find the updated patch for debugger test cases.
>> 1. Added check to skip debugger test case if the plugin is not installed.
>> 2. Added code to delete the existing "pldbgapi" extension and create a
>> new extension.
>> 3. Updated a few test cases that are falling on specific servers.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>> On Wed, Dec 9, 2020 at 1:37 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Wed, Dec 9, 2020 at 1:24 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay/Team,

 Please find the small patch for debugger test cases.
 Added random function name generation for the debugger.


 Regards,
 Nikhil Mohite.


 On Mon, Dec 7, 2020 at 3:32 PM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay/Team,
>
> Please find the updated patch for debugger test cases.
> 1. Resolved the issues related to the database connection.
> 2. Updated the create "pldbgapi" extension for the debugger.
>
>
> Regards,
> Nikhil Mohite.
>
> On Thu, Dec 3, 2020 at 10:47 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Dec 2, 2020 at 11:25 AM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Akshay,
>>>
>>> please find the updated patch, sorry for the inconvenience.
>>>
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>> On Wed, Dec 2, 2020 at 11:03 AM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Nikhil

 The patch is not applied, please rebase and send the patch again.

 On Tue, Dec 1, 2020 at 2:48 PM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> Please find the attached patch for RM-5343
> : [Code Coverage]
> Improve API test cases for Debugger.
> also updated implementation to remove dead code and unhandled
> exceptions.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


RM_5343_v6.patch
Description: Binary data


pgAdmin 4 commit: Fixed Debugger API test cases.

2020-12-17 Thread Akshay Joshi
Fixed Debugger API test cases.

refs #5343

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0ff0e30fbb8bc23f5f1a80dd2ea4238062ebc82
Author: Nikhil Mohite 

Modified Files
--
.../tests/test_debugger_clear_all_breakpoint.py|  4 ++--
.../debugger/tests/test_debugger_execute_query.py  |  4 ++--
.../tests/test_debugger_poll_execution_result.py   |  4 ++--
.../tools/debugger/tests/test_debugger_poll_result.py  |  2 +-
.../debugger/tests/test_debugger_set_breakpoint.py |  4 ++--
.../debugger/tests/test_start_execution_debugger.py|  2 +-
web/pgadmin/tools/debugger/tests/utils.py  | 18 +++---
7 files changed, 25 insertions(+), 13 deletions(-)



Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger

2020-12-17 Thread Akshay Joshi
Thanks, patch applied.

On Thu, Dec 17, 2020 at 5:40 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay/ Team,
>
> Please find attached an updated patch for debugger test cases.
>
> Regards,
> Nikhil Mohite.
>
> On Wed, Dec 16, 2020 at 12:12 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Dec 15, 2020 at 4:20 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> Please find the updated patch for debugger test cases.
>>> 1. Added check to skip debugger test case if the plugin is not installed.
>>> 2. Added code to delete the existing "pldbgapi" extension and create a
>>> new extension.
>>> 3. Updated a few test cases that are falling on specific servers.
>>>
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>> On Wed, Dec 9, 2020 at 1:37 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, patch applied.

 On Wed, Dec 9, 2020 at 1:24 PM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Akshay/Team,
>
> Please find the small patch for debugger test cases.
> Added random function name generation for the debugger.
>
>
> Regards,
> Nikhil Mohite.
>
>
> On Mon, Dec 7, 2020 at 3:32 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Akshay/Team,
>>
>> Please find the updated patch for debugger test cases.
>> 1. Resolved the issues related to the database connection.
>> 2. Updated the create "pldbgapi" extension for the debugger.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>> On Thu, Dec 3, 2020 at 10:47 AM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Wed, Dec 2, 2020 at 11:25 AM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 please find the updated patch, sorry for the inconvenience.


 Regards,
 Nikhil Mohite.

 On Wed, Dec 2, 2020 at 11:03 AM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Nikhil
>
> The patch is not applied, please rebase and send the patch again.
>
> On Tue, Dec 1, 2020 at 2:48 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> Please find the attached patch for RM-5343
>> : [Code Coverage]
>> Improve API test cases for Debugger.
>> also updated implementation to remove dead code and unhandled
>> exceptions.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>

 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option

2020-12-17 Thread Rahul Shirsat
Hi Hackers,

Please find the attached patch which resolves 2 issues:

   1. When the user applies the "Identical" filter before hitting the
   Compare button. (All Browsers)
   2. When comparing data is loaded, and when the user selects identical
   table comparison, infinite loader "Comparing objects..." shows up in
   Firefox.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM6084.patch
Description: Binary data