pgAdmin 4 commit: Fixed extra parentheses issue around joins for Views.

2020-12-23 Thread Akshay Joshi 
Fixed extra parentheses issue around joins for Views. Fixes #6061

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a92595012fac881905eeca275488d1ec1fee8137
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_30.rst | 1 +
.../schemas/views/templates/mviews/pg/9.3_plus/sql/properties.sql | 2 +-
.../schemas/views/templates/mviews/pg/9.4_plus/sql/properties.sql | 2 +-
.../schemas/views/templates/views/pg/9.1_plus/sql/properties.sql  | 2 +-
.../schemas/views/templates/views/pg/9.2_plus/sql/properties.sql  | 2 +-
.../schemas/views/templates/views/pg/9.3_plus/sql/properties.sql  | 2 +-
.../schemas/views/templates/views/pg/9.4_plus/sql/properties.sql  | 2 +-
.../servers/databases/schemas/views/tests/test_views_get.py   | 8 ++--
.../servers/databases/schemas/views/tests/view_test_data.json | 6 --
9 files changed, 17 insertions(+), 10 deletions(-)

pgAdmin 4 commit: Fixed accessibility issues in schema diff module. Fix

2020-12-23 Thread Akshay Joshi 
Fixed accessibility issues in schema diff module. Fixes #6065

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c93377101692130da019cc283d287d06947c9a8d
Author: Nikhil Mohite 

Modified Files
--
docs/en_US/release_notes_4_30.rst|  1 +
web/pgadmin/static/js/backform.pgadmin.js| 10 +-
.../static/scss/resources/_default.variables.scss|  3 ++-
.../static/scss/resources/dark/_theme.variables.scss |  2 ++
.../scss/resources/high_contrast/_theme.variables.scss   |  1 +
.../tools/schema_diff/static/js/schema_diff.backform.js  | 10 --
.../tools/schema_diff/static/js/schema_diff_ui.js| 16 
.../tools/schema_diff/static/scss/_schema_diff.scss  |  4 
8 files changed, 35 insertions(+), 12 deletions(-)

Re: [pgAdmin][RM-6065]: Accessibility issues in Schema diff module

2020-12-23 Thread Akshay Joshi 
Thanks, patch applied.

On Tue, Dec 22, 2020 at 4:02 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> Please find the attached patch for RM-6065
> : Accessibility issues in the
> Schema diff module.
> 1. Resolved accessibility issues with a schema diff tool.
> 2. Resolved contrast issue in codemirror. (updated new color code in
> standard theme).
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-6061]: [Sql] - Extra Parens around joins are added to views

2020-12-23 Thread Akshay Joshi 
Thanks, patch applied.

On Tue, Dec 22, 2020 at 5:27 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> Please find the attached patch for RM-6062
> : [Sql] - Extra Parens around
> joins are added to views.
> 1. Added "pretty_bool" flag again while fetching view definition for PG
> only.
> 2. Updated test cases as per new changes.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin] RM4892 pgAdmin "Inception"

2020-12-23 Thread Rahul Shirsat 
Hi Hackers,

Please find the attached patch which resolves the issue of pgadmin
Inception in Firefox browser.

The fix is tested on:

   1. MacOS 10.13.6 Firefox Browser 84.0 (64-bit)
   2. Windows 2016 Firefox Browser 84.0.1 (64-bit)

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM4892.patch
Description: Binary data

Re: [pgAdmin] RM4892 pgAdmin "Inception"

2020-12-23 Thread Rahul Shirsat 
Just forgot to mention, patch consists of one more fix of a schema not
loading on several refresh of browser or startup of application - *FIXED*

[image: image.png]

On Wed, Dec 23, 2020 at 8:16 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the issue of pgadmin
> Inception in Firefox browser.
>
> The fix is tested on:
>
>1. MacOS 10.13.6 Firefox Browser 84.0 (64-bit)
>2. Windows 2016 Firefox Browser 84.0.1 (64-bit)
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.

pgAdmin 4 commit: Fixed an issue where pressing the back button will sh

2020-12-23 Thread Akshay Joshi 
Fixed an issue where pressing the back button will show another instance of the 
main page inside of the Query Tool tab. Fixes #4892

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c9853f10dbe1cfa2a117ce993165bc988726319
Author: Rahul Shirsat 

Modified Files
--
docs/en_US/release_notes_4_30.rst |  1 +
.../server_groups/servers/databases/schemas/__init__.py   |  3 ++-
web/pgadmin/tools/datagrid/static/js/datagrid.js  | 15 +--
3 files changed, 16 insertions(+), 3 deletions(-)

pgAdmin 4 commit: Added support for expression in exclusion constraints

2020-12-23 Thread Akshay Joshi 
Added support for expression in exclusion constraints. Fixes #5571

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5448de2d3ff3ef486f21ed1be92b4b54a795ca45
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/exclusion_constraint_dialog.rst |  16 +--
docs/en_US/images/exclusion_constraint_columns.png | Bin 52476 -> 95416 bytes
docs/en_US/images/exclusion_constraint_sql.png | Bin 48863 -> 75488 bytes
docs/en_US/release_notes_4_30.rst  |   1 +
.../servers/databases/schemas/tables/__init__.py   |  17 ++-
.../constraints/exclusion_constraint/__init__.py   |  52 +
.../static/js/exclusion_constraint.js  | 123 ++---
.../11_plus/create_exclusion_constraint_exp.sql|  14 +++
.../exclusion_constraint/tests/11_plus/test.json   |  40 +++
.../default/create_exclusion_constraint_exp.sql|  14 +++
.../exclusion_constraint/tests/default/test.json   |  46 +++-
.../constraints/exclusion_constraint/utils.py  |   6 +-
.../exclusion_constraint/sql/11_plus/create.sql|   2 +-
.../sql/9.2_plus/get_constraint_cols.sql   |   5 +-
.../sql/9.2_plus/get_operator.sql  |   8 +-
.../exclusion_constraint/sql/default/create.sql|   2 +-
.../sql/default/get_constraint_cols.sql|   3 +-
.../sql/default/get_operator.sql   |   8 +-
web/pgadmin/static/js/backform.pgadmin.js  |   8 +-
19 files changed, 248 insertions(+), 117 deletions(-)

Re: [pgAdmin][RM5571] Expression in exclusion constraint is misinterpreted and quoted as column name by mistake

2020-12-23 Thread Akshay Joshi 
Thanks, patch applied.

On Wed, Dec 23, 2020 at 6:10 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch to add support for expressions in exclusion
> constraints. This also fixes the SQL generated for existing expression
> based constraints also.
> Docs updated and test cases enhanced.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin] RM4892 pgAdmin "Inception"

2020-12-23 Thread Akshay Joshi 
Thanks, patch applied.

On Wed, Dec 23, 2020 at 8:23 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Just forgot to mention, patch consists of one more fix of a schema not
> loading on several refresh of browser or startup of application - *FIXED*
>
> [image: image.png]
>
> On Wed, Dec 23, 2020 at 8:16 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which resolves the issue of pgadmin
>> Inception in Firefox browser.
>>
>> The fix is tested on:
>>
>>1. MacOS 10.13.6 Firefox Browser 84.0 (64-bit)
>>2. Windows 2016 Firefox Browser 84.0.1 (64-bit)
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin][RM-6077]: Accessibility issues in various dialogs

2020-12-23 Thread Nikhil Mohite 
Hi Team,

Please find the attached patch for RM-6077:
 Accessibility issues in
various dialogs.
Accessibility issues:
1. Server dialog.
2. Database dialog.
3. Import/Export dialog.
4. Process watcher.

Low contrast issue:
1. Updated text-muted color to "#646B82".


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM_6077.patch
Description: Binary data