Re: [pgAdmin][RM-6592]: [React] Port Materialized View node to react

2021-07-30 Thread Akshay Joshi
Hi Nikhil

Jasmine test cases are failing please fix and resend the patch. Also,
remove commented code from the "mview.ui.js" file.

On Thu, Jul 29, 2021 at 5:15 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6592
> : [React] Port Materialized
> View node to react
> Also fixed issues in view node related to validation and code field is
> editable for views under catalogs node.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

2021-07-30 Thread Akshay Joshi
Thanks, the patch applied to the React_Porting branch as it is a big
change.
With the testing of each node after porting this patch also gets tested.

On Thu, Jul 29, 2021 at 8:34 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-5741
> : [Schema Diff] Revisit all
> the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and
> 'CREATE OR REPLACE'
>
> Tested RESQL and API test cases on PG-9.6 to 13 and EPAS-9.6 to 13.3.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Fixed potential bug in the table node.

2021-07-30 Thread Akshay Joshi
Fixed potential bug in the table node.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9d985d3d8ffa1438f292b66d7f98ec90c69e12c1
Author: Aditya Toshniwal 

Modified Files
--
.../server_groups/servers/databases/schemas/tables/__init__.py  | 6 +++---
.../browser/server_groups/servers/databases/schemas/tables/utils.py | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)



Re: [pgAdmin][patch] Incorrect indentation in table python code

2021-07-30 Thread Akshay Joshi
Thanks, the patch applied.

On Thu, Jul 29, 2021 at 1:22 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please ignore the previous patch. Attached is the updated one.
> The patch aims - Fix potential buggy code in table python code.
>
> On Thu, Jul 29, 2021 at 12:32 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached patch fixes the indentation of a python code which can be a
>> potential bug.
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM-6592]: [React] Port Materialized View node to react

2021-07-30 Thread Akshay Joshi
Thanks, the patch applied.

On Fri, Jul 30, 2021 at 1:18 PM Akshay Joshi 
wrote:

> Hi Nikhil
>
> Jasmine test cases are failing please fix and resend the patch. Also,
> remove commented code from the "mview.ui.js" file.
>
> On Thu, Jul 29, 2021 at 5:15 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for RM-6592
>> : [React] Port Materialized
>> View node to react
>> Also fixed issues in view node related to validation and code field is
>> editable for views under catalogs node.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* 
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Fixed an issue where an empty SQLite database file is

2021-07-30 Thread Akshay Joshi
Fixed an issue where an empty SQLite database file is created when try to get 
the version.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23265061b21ec0b256c17a5299199e19d9c10fd2

Modified Files
--
web/pgadmin/__init__.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



PFA: Patch to generate universal(arm64, x86_64) binaries for macOS

2021-07-30 Thread Semab Tariq
Hi Team

Can someone please push this patch to the *master* branch of *pgAgent* repo?
For more details Please refer to JIRA PPS-310


-- 
Thanks & Regards,
Semab


PPS-310-master-1.patch
Description: Binary data