pgAdmin 4 commit: Updated screenshots for server group and server dialo

[Akshay Joshi]

Updated screenshots for server group and server dialog.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31339737a65c0e2ad2f1a7f5239198bf37c00a23

Modified Files
--
docs/en_US/images/server_advanced.png   | Bin 56042 -> 60989 bytes
docs/en_US/images/server_connection.png | Bin 81570 -> 80032 bytes
docs/en_US/images/server_general.png| Bin 60984 -> 64603 bytes
docs/en_US/images/server_group.png  | Bin 16867 -> 31415 bytes
docs/en_US/images/server_ssh_tunnel.png | Bin 50837 -> 75805 bytes
docs/en_US/images/server_ssl.png| Bin 51261 -> 73622 bytes
docs/en_US/server_dialog.rst|   2 +-
docs/en_US/server_group_dialog.rst  |   2 +-
8 files changed, 2 insertions(+), 2 deletions(-)

[patch][pgAdmin] RM6806 [Type Node] Schema icon is not visible in the drop-down of General tab

[Rahul Shirsat]

Hi Hackers,

Please find the attached patch which resolves the issue of schema icon not
visible in drop down of Type Node in General Tab.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM6806.patch
Description: Binary data

pgAdmin 4 commit: Fixed an issue where Schema icon is not visible in th

[Akshay Joshi]

Fixed an issue where Schema icon is not visible in the drop-down of General 
tab. Fixes #6806

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d8d88b948a0cfccb7847b66a59a136d03980a88c
Author: Rahul Shirsat 

Modified Files
--
.../server_groups/servers/databases/schemas/types/static/js/type.ui.js  | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Re: [patch][pgAdmin] RM6806 [Type Node] Schema icon is not visible in the drop-down of General tab

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Sep 27, 2021 at 1:23 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the issue of schema icon not
> visible in drop down of Type Node in General Tab.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

[pgAdmin4][patch] error message is incorrect in domains

[zhangj...@fujitsu.com]

Hi, all

In domains's create function, res is used for all error messages.
I don't think this is correct.
On line 13, doid should be used as the error message.Because the execution 
result of line 11 is doid.
On line 21, scid should be used as the error message.Because the execution 
result of line 19 is scid.
There are similar problems in other functions.
Here is a patch for domains.
Please review.

file: 
pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\domains\__init__.py

   def create(self, gid, sid, did, scid):
..
 1   status, res = self.conn.execute_scalar(SQL)   
 2   if not status:
 3   return internal_server_error(errormsg=res) ※1   res is OK
 4
 5   # We need oid to add object in tree at browser, below sql will
 6   # gives the same
 7   SQL = render_template("/".join([self.template_path,
 8   self._OID_SQL]),
 9 basensp=data['basensp'],
 10 name=data['name'])
 11   status, doid = self.conn.execute_scalar(SQL)
 12   if not status:
 13   return internal_server_error(errormsg=res)   ※2  res => doid
 14
 15   # Get updated schema oid
 16   SQL = render_template("/".join([self.template_path,
 17   self._OID_SQL]),
 18 doid=doid)
 19   status, scid = self.conn.execute_scalar(SQL)
 20   if not status:
 21   return internal_server_error(errormsg=res)   ※3  res => scid 
--


domains.patch
Description: domains.patch

pgAdmin 4 commit: Correct the variable names in the error messages for

[Akshay Joshi]

Correct the variable names in the error messages for the Domain node.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9832256839c8410663a4a237acb672e6f7f34c3
Author: zhangj...@fujitsu.com 

Modified Files
--
.../servers/databases/schemas/domains/__init__.py  | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)

Re: [pgAdmin4][patch] error message is incorrect in domains

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Sep 27, 2021 at 2:27 PM zhangj...@fujitsu.com 
wrote:

> Hi, all
>
> In domains's create function, res is used for all error messages.
> I don't think this is correct.
> On line 13, doid should be used as the error message.Because the execution
> result of line 11 is doid.
> On line 21, scid should be used as the error message.Because the execution
> result of line 19 is scid.
> There are similar problems in other functions.
> Here is a patch for domains.
> Please review.
>
> file:
> pgadmin4\web\pgadmin\browser\server_groups\servers\databases\schemas\domains\__init__.py
>
> 
>def create(self, gid, sid, did, scid):
> ..
>  1   status, res = self.conn.execute_scalar(SQL)
>  2   if not status:
>  3   return internal_server_error(errormsg=res) ※1   res is OK
>  4
>  5   # We need oid to add object in tree at browser, below sql will
>  6   # gives the same
>  7   SQL = render_template("/".join([self.template_path,
>  8   self._OID_SQL]),
>  9 basensp=data['basensp'],
>  10 name=data['name'])
>  11   status, doid = self.conn.execute_scalar(SQL)
>  12   if not status:
>  13   return internal_server_error(errormsg=res)   ※2  res => doid
>  14
>  15   # Get updated schema oid
>  16   SQL = render_template("/".join([self.template_path,
>  17   self._OID_SQL]),
>  18 doid=doid)
>  19   status, scid = self.conn.execute_scalar(SQL)
>  20   if not status:
>  21   return internal_server_error(errormsg=res)   ※3  res => scid
>
> --
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Port browser tree to React. Fixes #6129

[Akshay Joshi]

Port browser tree to React. Fixes #6129

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=483e2ca8d0aa96fa0cf7cd77a41e198b3be7d3bf
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/release_notes_6_0.rst   |   1 +
web/package.json   |  23 +-
web/pgadmin/browser/__init__.py|   2 +-
web/pgadmin/browser/collection.py  |   4 +-
.../publications/static/js/publication.js  |   2 +-
.../schemas/collations/static/js/collation.ui.js   |   4 +-
.../schemas/functions/static/js/procedure.js   |   2 +-
.../functions/static/js/trigger_function.js|   2 +-
.../schemas/packages/static/js/package.js  |   2 +-
.../servers/databases/schemas/static/js/schema.js  |   2 +-
.../schemas/static/js/schema_child_tree_node.js|   8 +-
.../schemas/synonyms/static/js/synonym.js  |   2 +-
.../schemas/tables/columns/static/js/column.js |   2 +-
.../static/js/compound_trigger.js  |  10 +-
.../check_constraint/static/js/check_constraint.js |   2 +-
.../foreign_key/static/js/foreign_key.js   |   4 +-
.../index_constraint/static/js/primary_key.js  |   4 +-
.../static/js/unique_constraint.js |   2 +-
.../schemas/tables/indexes/static/js/index.js  |   2 +-
.../tables/partitions/static/js/partition.js   |  17 +-
.../static/js/row_security_policy.js   |   2 +-
.../databases/schemas/tables/static/js/table.js|  10 +-
.../schemas/tables/triggers/static/js/trigger.js   |   8 +-
.../databases/schemas/views/static/js/mview.js |   8 +-
.../servers/databases/static/js/database.js|  11 +-
.../subscriptions/static/js/subscription.js|   2 +-
.../servers/pgagent/static/js/pga_job.js   |   2 +-
.../resource_groups/static/js/resource_group.js|   2 +-
.../server_groups/servers/roles/static/js/role.js  |   8 +-
.../server_groups/servers/static/js/server.js  |  24 +-
.../servers/tablespaces/static/js/tablespace.js|   8 +-
web/pgadmin/browser/static/js/browser.js   | 427 ++
web/pgadmin/browser/static/js/collection.js|   6 +-
web/pgadmin/browser/static/js/keyboard.js  |   6 +-
web/pgadmin/browser/static/js/layout.js|   2 +-
web/pgadmin/browser/static/js/node.js  |  96 +--
web/pgadmin/browser/static/js/preferences.js   |  10 +-
web/pgadmin/browser/static/js/toolbar.js   |   2 +-
web/pgadmin/dashboard/static/js/dashboard.js   |  11 +-
.../misc/dependencies/static/js/dependencies.js| 124 +++-
.../misc/dependents/static/js/dependents.js|   4 +-
web/pgadmin/misc/sql/static/js/sql.js  |   7 +-
.../misc/statistics/static/js/statistics.js|   4 +-
web/pgadmin/preferences/static/js/preferences.js   |   2 +-
web/pgadmin/static/bundle/app.js   |  19 +-
web/pgadmin/static/js/alertify/dialog.js   |   7 +-
.../static/js/misc/statistics/statistics.js|   4 +-
web/pgadmin/static/js/nodes/dashboard.js   |   2 +-
.../static/js/nodes/supported_database_node.js |   4 +-
web/pgadmin/static/js/tree/pgadmin_tree_node.js|  75 ---
.../static/js/tree/pgadmin_tree_save_state.js  |  20 +-
web/pgadmin/static/js/tree/tree.js | 645 -
web/pgadmin/static/js/tree/tree_init.tsx   |  87 +++
web/pgadmin/static/js/tree/tree_nodes.ts   | 298 ++
web/pgadmin/static/js/tree/tree_utils.js   |   9 +-
web/pgadmin/static/js/utils.js |   3 +-
web/pgadmin/static/scss/_pgadmin.style.scss|   4 +
.../static/scss/_pgadmin4-tree.overrides.scss  | 123 
web/pgadmin/static/scss/pgadmin.scss   |   2 +
web/pgadmin/tools/backup/static/js/backup.js   |  15 +-
.../tools/backup/static/js/backup_dialog.js|   3 -
.../backup/static/js/backup_dialog_wrapper.js  |  15 +-
web/pgadmin/tools/datagrid/static/js/datagrid.js   |   4 +-
.../datagrid/static/js/datagrid_panel_title.js |   6 +-
web/pgadmin/tools/datagrid/static/js/show_data.js  |  12 +-
.../tools/datagrid/static/js/show_query_tool.js|   6 +-
web/pgadmin/tools/debugger/static/js/debugger.js   |  31 +-
.../tools/debugger/static/js/debugger_ui.js|  13 +-
web/pgadmin/tools/erd/static/js/erd_module.js  |  11 +-
.../tools/grant_wizard/static/js/grant_wizard.js   |   8 +-
.../tools/import_export/static/js/import_export.js |  16 +-
.../tools/maintenance/static/js/maintenance.js |  19 +-
web/pgadmin/tools/psql/static/js/psql_module.js|  14 +-
web/pgadmin/tools/restore/static/js/restore.js |   8 +-
.../tools/restore/static/js/restore_dialog.js  |   4 +-
.../restore/static/js/restore_dialog_wrapper.js|  16 +-
.../static/js/search_objects_dialog_wrapper.js |  28 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  24 +-
.../javascript/backup/backup_dialog_sp

Re: [pgAdmin4][Patch] - RM #6129 - Port browser tree to React

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Sep 27, 2021 at 1:51 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Akshay,
>
> All the review comments are fixed, please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Sep 24, 2021 at 4:25 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Khushboo
>>
>> Following are the review comments with the new patch:
>>
>>- Select any collection node and make sure that the collection node
>>should not have a single child. For example Cast, FDW, etc... Create a new
>>Cast/FDW node it will not immediately be visible under the collection 
>> node.
>>Once you collapse/expand then it is visible.
>>- '*Failed to append .*' warning comes whenever you create any
>>new node.
>>- 'Backup Server', 'Backup' menu not working.
>>- The maintenance dialog is showing a blank white screen.
>>- PSQL Tool always gives a 'Please select a server/database object.'
>>message.
>>- *item.getMetadata('data') *is not a function tree.js 740. When
>>select Constraints collection node or right-click on it. Make sure the
>>Constraints collection node has at least one constraint.
>>- Import/Export dialog not opening. *Cannot read properties of
>>undefined (reading 'apply') *
>>- *Cannot read properties of null (reading 'selected') *dependent.js
>>line no 76.  Open pgAdmin in the browser, without selecting any node do 
>> the
>>reset layout, you will get the same error.
>>
>>
>> On Fri, Sep 24, 2021 at 11:22 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached updated patch.
>>> All the review comments are fixed except one as below.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Fri, Sep 17, 2021 at 8:35 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Khushboo

 Following are the GUI review comments:

- Arrow ( > ) is not center-aligned with the node labels.
- Sorting of tree items is not correct when you have servers like
(PostgreSQL 9.5, PostgreSQL 9.6, PostgreSQL 10...)

 The sorting of the tree is alphabetically,  so, PG 10 will come first
>>> than PG 9.5.
>>>

- Servers collection node not showing count while expanding it.
- The last child should not have a collapse/expand arrow ( >).
- Properties panel should not be rendered again and again when the
same tree object is collapsed/expanded. I have tried on Schema node.
- The labels should be properly quoted. Create a Cast
*"money->bigint", *in properties dialog it is showing correctly,
but in browser tree, it is showing "*money->bigint*".
- Mouse hover any node, we will see the URL as a tooltip.
- Open query tool "*tree_data.slice is not a function" *error
showing in the developer tools. File: sqleditor.js:2392
- *node.getTreeNodeHierarchy is not a function* error visible.
File: dependents.js and dependencies.js:167. Please check the same 
 function
in the whole source code.
- Select "*Postgres*" database or server node and refresh the node
using the context menu, after the refresh, it will show the number of
children which should not. The same behavior observes for each node.
- Lable "Group Roles" should be "Login/Group Roles".
- When scrolling at the bottom, the scroll bar automatically moves
up. Steps to reproduce Connect to one server and expand till table node,
then scroll down and connect to another server, when we try to scroll 
 down
completely, the scroll bar automatically moves up.
- The following menu options are not working on the respective node:
   - *Server: *Reload Configuration, Clear Saved Password, and Add
   Named Restore Point
   - *Database*: Maintenence (*item.getMetadata is not a function
   tree.js line 710*), Grant Wizard, PSQL Tool (Please select a
   server or database object)
   - *Table*: Count Rows, Reset Statistics, Import/Export,
   Maintenence, Truncate
   - *Partitions*: Detach Partition,
   - *Check Constraint*:  Validate check constraint
   - *Constraints*:  Context menu not opening
   - *MView*: Context menu not opening:- Cannot read properties of
   undefined (reading 'apply') mview.js line no 395

 *Please check all the other Menu items if I missed them. *

 Code Review:

- Remove commented code. Remove "console.warn" if used for testing
purposes.
- Remove if (m.name == 'create_table') console.warn(m); }
browser.js line no 797

 Code review still remains.

 On Wed, Sep 15, 2021 at 12:10 PM Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for the RM #6129 - Port br

[pgAdmin][patch] UI Improvements

[Aditya Toshniwal]

Hi Hackers,

Attached patch incorporates:
1. Switch control and CodeMirror control UI improvements for readonly and
disabled state.
2. If a form input value changes to null, pass it as an empty string in URL
params.

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


reactui.fixes.patch
Description: Binary data

[pgAdmin][RM-6813]: SQL is not getting generated for Foreign table >> option

[Nikhil Mohite]

Hi Hackers,

Please find the attached patch for
RM-6813:
[React] SQL is not getting
generated for Foreign table >> option


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* 
*Mob.No: +91-7798364578.*


RM-6813.patch
Description: Binary data

Re: [pgAdmin][patch] UI Improvements

[Aditya Toshniwal]

Hi Hackers,

Please find the updated patch with one more improvement - Use server_type
instead of type from the server info.

On Mon, Sep 27, 2021 at 4:57 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch incorporates:
> 1. Switch control and CodeMirror control UI improvements for readonly and
> disabled state.
> 2. If a form input value changes to null, pass it as an empty string in
> URL params.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


reactui.improvements_v2.patch
Description: Binary data

[patch][pgAdmin] RM6791 Index Node - [Create]> Controls for Sort & Nulls should be changed, [Edit]> Definition>Columns sections are editable

[Rahul Shirsat]

Hi Hackers,

Please find the attached patch which resolves the issues of sort & nulls in
index.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM6791.patch
Description: Binary data

[pgAdmin][RM6799]: [React] User can not Add parameter for PG procedures and Functions

[Pradip Parkale]

Hi Hackers,

Please find the attached patch for following issue:

   1. Not able to add Parameters for Functions and Procedures
   2. For procedure, Volatility option should be disabled in some cases.

This patch also includes the fix for RM6793:  [React] Syntax error
displayed If table is not available and user try to use blank option

-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


RM6799.patch
Description: Binary data

pgAdmin 4 commit: Hardcoded the version of NWjs to 0.55.0 in the build

[Akshay Joshi]

Hardcoded the version of NWjs to 0.55.0 in the build scripts, as the latest 
version cause some problems.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f6a9af0aa476019b3cf9ae84f53c4b6a7bcfd798

Modified Files
--
Make.bat | 14 ++
pkg/linux/build-functions.sh |  5 -
pkg/mac/build-functions.sh   |  7 +--
3 files changed, 19 insertions(+), 7 deletions(-)

pgAdmin 4 commit: 1. Switch control and CodeMirror control UI improveme

[Akshay Joshi]

1. Switch control and CodeMirror control UI improvements for read-only and 
disabled states.
2. If a form input value changes to null, pass it as an empty string in URL 
params.
3. Use server_type instead of type from the server info.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc8ab7cd2ac9c7b0b2ed90d7482e42d4278ecf80
Author: Aditya Toshniwal 

Modified Files
--
.../tables/triggers/static/js/trigger.ui.js|  2 +-
web/pgadmin/browser/static/js/node_view.jsx|  2 +-
web/pgadmin/static/js/SchemaView/index.jsx |  4 
web/pgadmin/static/js/Theme/index.jsx  | 28 ++
web/pgadmin/static/js/components/CodeMirror.jsx| 22 -
.../static/js/components/FormComponents.jsx| 17 +++--
.../javascript/components/CodeMirror.spec.js   | 11 -
7 files changed, 75 insertions(+), 11 deletions(-)

pgAdmin 4 commit: 1. Syntax error displayed If the table is not availab

[Akshay Joshi]

1. Syntax error displayed If the table is not available and the user tries to 
use the blank option. Fixes #6793
2. Not able to add Parameters for Functions and Procedures.
3. For the procedure, the Volatility option should be disabled in some cases. 
Fixes #6799

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d616cb88aa8a883e78666916a386c1255a10e7e6
Author: Pradip Parkale 

Modified Files
--
.../server_groups/servers/databases/publications/__init__.py| 2 +-
.../server_groups/servers/databases/publications/tests/utils.py | 2 +-
.../servers/databases/schemas/functions/static/js/function.ui.js| 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Fixed an issue where SQL is not getting generated for

[Akshay Joshi]

Fixed an issue where SQL is not getting generated for Foreign table options. 
Fixes #6813

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48a5143485d396c395e178221691f0e43681bc1f
Author: Nikhil Mohite 

Modified Files
--
.../databases/schemas/foreign_tables/static/js/foreign_table.ui.js  | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

pgAdmin 4 commit: Fixed an issue for sort and null controls for the Ind

[Akshay Joshi]

Fixed an issue for sort and null controls for the Index node. Fixes #6791

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15ecf5d8210d0819d5757ca0bb609ce80bceb03a
Author: Rahul Shirsat 

Modified Files
--
.../schemas/tables/indexes/static/js/index.ui.js   | 37 --
1 file changed, 21 insertions(+), 16 deletions(-)

Re: [pgAdmin][RM6799]: [React] User can not Add parameter for PG procedures and Functions

[Akshay Joshi]

Thanks, the patch applied.

On Tue, Sep 28, 2021 at 9:01 AM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for following issue:
>
>1. Not able to add Parameters for Functions and Procedures
>2. For procedure, Volatility option should be disabled in some cases.
>
> This patch also includes the fix for RM6793:  [React] Syntax error
> displayed If table is not available and user try to use blank option
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [patch][pgAdmin] RM6791 Index Node - [Create]> Controls for Sort & Nulls should be changed, [Edit]> Definition>Columns sections are editable

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Sep 27, 2021 at 8:32 PM Rahul Shirsat <
rahul.shir...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the issues of sort & nulls
> in index.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][patch] UI Improvements

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Sep 27, 2021 at 5:57 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the updated patch with one more improvement - Use server_type
> instead of type from the server info.
>
> On Mon, Sep 27, 2021 at 4:57 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached patch incorporates:
>> 1. Switch control and CodeMirror control UI improvements for readonly and
>> disabled state.
>> 2. If a form input value changes to null, pass it as an empty string in
>> URL params.
>>
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> 
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

Re: [pgAdmin][RM-6813]: SQL is not getting generated for Foreign table >> option

[Akshay Joshi]

Thanks, the patch applied.

On Mon, Sep 27, 2021 at 5:17 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for
> RM-6813:
> [React] SQL is not getting
> generated for Foreign table >> option
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* 
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*

pgAdmin 4 commit: Handler and Validator should not allow selecting the

[Akshay Joshi]

Handler and Validator should not allow selecting the empty options. Fixes #6810

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2265ffc0a710882cad53f39e3335596e4ca866b6

Modified Files
--
.../server_groups/servers/databases/foreign_data_wrappers/__init__.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)