pgAdmin 4 commit: Fixed Dark theme UI related issues. Fixes #6846

2021-10-04 Thread Akshay Joshi
Fixed Dark theme UI related issues. Fixes #6846

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=038fd6ce214a5b88093c22c00a01c0f828f40b51
Author: Aditya Toshniwal 

Modified Files
--
.../schemas/tables/columns/static/js/column.ui.js  | 14 --
.../schemas/tables/static/js/partition.utils.ui.js |  2 +-
web/pgadmin/static/js/Theme/dark.js|  2 +-
web/pgadmin/static/js/Theme/index.jsx  | 10 ++
web/pgadmin/static/js/components/FormComponents.jsx|  1 +
5 files changed, 25 insertions(+), 4 deletions(-)



pgAdmin 4 commit: Fixed an issue where the label is not visible when ho

2021-10-04 Thread Akshay Joshi
Fixed an issue where the label is not visible when hovering on any tree node in 
the High Contrast theme. Fixes #6847

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=65af8bcc5a0e21a66417b74ed87c6de4e78bba2a
Author: Khushboo Vashi 

Modified Files
--
.../static/scss/_pgadmin4-tree.overrides.scss  | 189 +++--
1 file changed, 96 insertions(+), 93 deletions(-)



Re: [pgAdmin4][Patch] - RM #6847 - High Contrast theme hover issue

2021-10-04 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the hover issue.

Thanks,
Khushboo

On Mon, Oct 4, 2021 at 11:36 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #6847 - [UI-Tree view][High
> Contrast theme]: Hover on any node its label is not visible.
>
> Thanks,
> Khushboo
>


RM_6847_v1.patch
Description: Binary data


Re: [pgAdmin][RM6846] Dark theme UI related fixes

2021-10-04 Thread Akshay Joshi
Thanks, the patch applied.

On Mon, Oct 4, 2021 at 11:57 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch fixes some visibility issues in the dark UI theme.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Fixed an issue where label is not visible on hover, w

2021-10-04 Thread Akshay Joshi
Fixed an issue where label is not visible on hover, while hover on icon or 
expand arrow. refs #6847

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ec1db1ecbcf005256cf2c2f8b3ad4d394713917
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/static/scss/_pgadmin4-tree.overrides.scss | 5 +
1 file changed, 5 insertions(+)



Re: [pgAdmin4][Patch] - RM #6847 - High Contrast theme hover issue

2021-10-04 Thread Akshay Joshi
Thanks, the patch applied.

On Mon, Oct 4, 2021 at 1:10 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the hover issue.
>
> Thanks,
> Khushboo
>
> On Mon, Oct 4, 2021 at 11:36 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the RM #6847 - [UI-Tree view][High
>> Contrast theme]: Hover on any node its label is not visible.
>>
>> Thanks,
>> Khushboo
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[pgAdmin][RM6835]: Unable to edit publication in properties dialog.

2021-10-04 Thread Pradip Parkale
Hi Hackers,

Please find the attached patch for 1st part of #6835.

   - Unable to edit publication in the subscription dialog.


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


RM6835.patch
Description: Binary data


[pgAdmin][RM6837] Foreign key issues in edit mode

2021-10-04 Thread Aditya Toshniwal
Hi Hackers,

Attached patch fixes:
1. Couple of foreign key issues in edit mode. Fixes #6837
2. Table "Of type" related issues. Fixes #6825

Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM6837_6825.patch
Description: Binary data


pgAdmin 4 commit: Ensure that the user should be able to edit the publi

2021-10-04 Thread Akshay Joshi
Ensure that the user should be able to edit the publication in the subscription 
dialog. Fixes #6835

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=69109a19dba6131d3da7fe177804c85c5be6340b
Author: Pradip Parkale 

Modified Files
--
.../browser/server_groups/servers/databases/subscriptions/__init__.py | 4 
1 file changed, 4 deletions(-)



pgAdmin 4 commit: Foreign key issues in edit mode:

2021-10-04 Thread Akshay Joshi
Foreign key issues in edit mode:
1. Couple of foreign key issues in edit mode. Fixes #6837
2. Table "Of type" related issues. Fixes #6825

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e77f933fe7a4069900657974027ed0e286e7bdb6
Author: Aditya Toshniwal 

Modified Files
--
.../check_constraint/static/js/check_constraint.ui.js|  2 +-
.../static/js/exclusion_constraint.ui.js |  2 +-
.../constraints/foreign_key/static/js/foreign_key.ui.js  | 16 +---
.../index_constraint/static/js/primary_key.ui.js |  2 +-
.../index_constraint/static/js/unique_constraint.ui.js   |  2 +-
.../databases/schemas/tables/static/js/table.ui.js   |  7 ++-
.../javascript/schema_ui_files/foreign_key.ui.spec.js|  4 ++--
.../javascript/schema_ui_files/table.ui.spec.js  | 10 ++
8 files changed, 31 insertions(+), 14 deletions(-)



Re: [pgAdmin][RM6837] Foreign key issues in edit mode

2021-10-04 Thread Akshay Joshi
Thanks, the patch applied.

On Mon, Oct 4, 2021 at 2:08 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch fixes:
> 1. Couple of foreign key issues in edit mode. Fixes #6837
> 2. Table "Of type" related issues. Fixes #6825
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [pgAdmin][RM6835]: Unable to edit publication in properties dialog.

2021-10-04 Thread Akshay Joshi
Thanks, the patch applied.

On Mon, Oct 4, 2021 at 1:33 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for 1st part of #6835.
>
>- Unable to edit publication in the subscription dialog.
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


[pgAdmin4][Patch] - RM #6844 - Partitions collection node loading issue.

2021-10-04 Thread Khushboo Vashi
Hi,

Please find the attached patch to fix the RM #6844 - [Table node]:
Partitions collection node loading issue.

Thanks,
Khushboo


RM_6844.patch
Description: Binary data


pgAdmin 4 commit: Fixed loading issue of Partitions collection node. Fi

2021-10-04 Thread Akshay Joshi
Fixed loading issue of Partitions collection node. Fixes #6844

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8faec3e0e9d48a05ff5d4eea4f151fff2751425f
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/static/js/tree/tree_nodes.ts| 10 +-
web/pgadmin/static/scss/_pgadmin.style.scss |  1 -
2 files changed, 9 insertions(+), 2 deletions(-)



pgAdmin 4 commit: Updated PostgreSQL version from 13 to 14, to get the

2021-10-04 Thread Akshay Joshi
Updated PostgreSQL version from 13 to 14, to get the latest utility files.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7d5668141dab5f35751f725c5e179070857af181

Modified Files
--
Dockerfile  | 13 +
docs/en_US/container_deployment.rst | 12 +++-
pkg/debian/build.sh |  2 +-
pkg/docker/entrypoint.sh|  3 ++-
pkg/redhat/build.sh |  4 ++--
pkg/redhat/setup.sh |  4 ++--
6 files changed, 23 insertions(+), 15 deletions(-)



Re: [pgAdmin4][Patch] - RM #6844 - Partitions collection node loading issue.

2021-10-04 Thread Akshay Joshi
Thanks, the patch applied.

On Mon, Oct 4, 2021 at 3:39 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the RM #6844 - [Table node]:
> Partitions collection node loading issue.
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAgent commit: Tag REL-4_2_2 has been created.

2021-10-04 Thread Dave Page
Tag REL-4_2_2 has been created.
View: 
https://git.postgresql.org/gitweb?p=pgagent.git;a=tag;h=refs/tags/REL-4_2_2

Log Message
---
Tag 4.2.2

Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS

2021-10-04 Thread Dave Page
Hi

I've tagged 4.2.2.

On Fri, Oct 1, 2021 at 11:22 AM Semab Tariq 
wrote:

> (Adding Ashesh, Sandeep)
>
> Hi Team
>
> Do we have any possible date for the pgAgent-4.2.2 release?
> I am interested in 4.2.2 because 4.2.1 doesn't have support to build
> universal binaries on macOS but 4.2.2 will have this support because this
> 
> commit is already pushed to the master branch
> Also, we plan to release pgAgent for PG-14.0, and for this, we need
> pgAgent-4.2.2(Due to its universal binaries support)
>
> Thanks & Regards,
> Semab
>
> On Mon, Aug 2, 2021 at 1:27 PM Semab Tariq 
> wrote:
>
>> Great, thanks for letting me know.
>>
>> On Mon, Aug 2, 2021 at 1:12 PM Dave Page  wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq 
>>> wrote:
>>>
 Hi Team

 In my previous email, I attached a link to the JIRA ticket and I was
 hoping that you can access that ticket and see the details about my patch
 but I was unaware that JIRA is not accessible to the community so now I am
 attaching the details here

 *Details about my patch*

 While trying to generate *pgAgent-4.2.1* universal binaries on *macOS
 BigSur x86_64* architecture via following command
 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake.
 app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent -
 DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" -
 DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D
 CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/
 MacOSX11.1.sdk CMakeLists.txt

 I got this error in configure log
 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT"
 "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5--
 Configuring incomplete, errors occurred!

 After some debugging, I found out that the
 *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double
 quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition
 so I added that, and now I am able to build pgAgent universal binaries
 successfully. If you don't have any concerns with my patch can someone
 please push the changes to the source? Thanks & Regards,
 Semab

 On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <
 semab.ta...@enterprisedb.com> wrote:

> Hi Team
>
> Can someone please push this patch to the *master* branch of *pgAgent*
> repo?
> For more details Please refer to JIRA PPS-310
> 
>
> --
> Thanks & Regards,
> Semab
>


 --

>>>
>>>
>>> --
>>> Dave Page
>>> Blog: https://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: https://www.enterprisedb.com
>>>
>>>
>>
>> --
>> Thanks & Regards,
>> Semab
>>
>
>
> --
>
>

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com


pgAdmin 4 commit: Fix Python version

2021-10-04 Thread Dave Page
Fix Python version

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17ad46fe9d73370688af347063e7af34f56ff39d

Modified Files
--
Dockerfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Fixed theme related issues after react porting.

2021-10-04 Thread Akshay Joshi
Fixed theme related issues after react porting.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=40b8da8223d779074f603030706f7d7180ab1c98
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/static/js/Theme/dark.js|  5 +
web/pgadmin/static/js/Theme/high_contrast.js   |  7 ++-
web/pgadmin/static/js/Theme/index.jsx  | 24 ++
web/pgadmin/static/js/Theme/standard.js|  5 +
web/pgadmin/static/js/helpers/wizard/Wizard.jsx|  7 ---
web/pgadmin/static/scss/_codemirror.overrides.scss |  2 +-
6 files changed, 45 insertions(+), 5 deletions(-)



[pgAdmin][RM6857] Unique Constraint dialogue > Index dropdown does not have options loaded

2021-10-04 Thread Aditya Toshniwal
Hi Hackers,

Please review the attached patch for the fix.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


RM6857.patch
Description: Binary data


Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-10-04 Thread Rahul Shirsat
Hi Hackers,

Please find the attached patch which resolves one more additional issue
reported by Aditya.

On Thu, Sep 30, 2021 at 3:32 PM Akshay Joshi 
wrote:

> Thanks, the patch applied.
>
> On Thu, Sep 30, 2021 at 1:46 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for fixing some additional issues.
>>
>> On Mon, Sep 20, 2021 at 1:13 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat <
>>> rahul.shir...@enterprisedb.com> wrote:
>>>
 Hi Akshay,

 Please find the updated patch.

 On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Rahul
>
> Patch not applied, rebase and send the patch again.
>
> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat <
> rahul.shir...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which resolves the below issue:
>>
>> 1. Enum Type - Unable to delete rows for Enum type in Create Type
>> dialogue.
>> 2. Range Type - Loading icons are shown in different drop down tabs.
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


 --
 *Rahul Shirsat*
 Senior Software Engineer | EnterpriseDB Corporation.

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres *
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres *
>
> *Mobile: +91 976-788-8246*
>


-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


RM6744_v4.patch
Description: Binary data


pgAdmin 4 commit: Fixed an issue where the index is not loaded in the U

2021-10-04 Thread Akshay Joshi
Fixed an issue where the index is not loaded in the Unique Constraint dialog. 
Fixes #6857

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7eaa3179ad866efd7990dff0c70f09183d7b1ad5
Author: Aditya Toshniwal 

Modified Files
--
.../static/js/exclusion_constraint.ui.js   |  5 +++--
.../foreign_key/static/js/foreign_key.ui.js| 18 --
.../index_constraint/static/js/primary_key.ui.js   |  7 ---
.../index_constraint/static/js/unique_constraint.ui.js |  7 ---
.../databases/schemas/tables/static/js/table.ui.js | 12 ++--
.../schema_ui_files/exclusion_constraint.ui.spec.js|  2 ++
.../javascript/schema_ui_files/foreign_key.ui.spec.js  |  4 ++--
.../javascript/schema_ui_files/primary_key.ui.spec.js  |  2 ++
.../schema_ui_files/unique_constraint.ui.spec.js   |  2 ++
9 files changed, 33 insertions(+), 26 deletions(-)



pgAdmin 4 commit: Fixed an issue where adding security privileges and c

2021-10-04 Thread Akshay Joshi
Fixed an issue where adding security privileges and change type to shell crash 
the dialog. Fixes #6744

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2932ef770db49fbb216364856135767ab00ba9d5
Author: Rahul Shirsat 

Modified Files
--
.../server_groups/servers/databases/schemas/types/static/js/type.ui.js  | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgAdmin 4 commit: Update version for release.

2021-10-04 Thread Akshay Joshi
Update version for release.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=02edea9bd72d2f8f60d3d30ac6bd6c4beca5b0a6

Modified Files
--
web/config.py | 8 
1 file changed, 4 insertions(+), 4 deletions(-)



Re: [pgAdmin][RM6857] Unique Constraint dialogue > Index dropdown does not have options loaded

2021-10-04 Thread Akshay Joshi
Thanks, the patch applied.

On Mon, Oct 4, 2021 at 6:26 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please review the attached patch for the fix.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> 
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue

2021-10-04 Thread Akshay Joshi
Thanks, the patch applied.

On Mon, Oct 4, 2021 at 6:34 PM Rahul Shirsat 
wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves one more additional issue
> reported by Aditya.
>
> On Thu, Sep 30, 2021 at 3:32 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Thu, Sep 30, 2021 at 1:46 PM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for fixing some additional issues.
>>>
>>> On Mon, Sep 20, 2021 at 1:13 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, the patch applied.

 On Mon, Sep 20, 2021 at 1:06 PM Rahul Shirsat <
 rahul.shir...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find the updated patch.
>
> On Fri, Sep 17, 2021 at 8:55 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Rahul
>>
>> Patch not applied, rebase and send the patch again.
>>
>> On Thu, Sep 16, 2021 at 6:39 PM Rahul Shirsat <
>> rahul.shir...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch which resolves the below issue:
>>>
>>> 1. Enum Type - Unable to delete rows for Enum type in Create Type
>>> dialogue.
>>> 2. Range Type - Loading icons are shown in different drop down tabs.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


 --
 *Thanks & Regards*
 *Akshay Joshi*
 *pgAdmin Hacker | Principal Software Architect*
 *EDB Postgres *

 *Mobile: +91 976-788-8246*

>>>
>>>
>>> --
>>> *Rahul Shirsat*
>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres *
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


pgAdmin4 v6.0 candidate builds

2021-10-04 Thread Akshay Joshi
Hi All,

pgAdmin4 v6.0 candidate builds and source can be found at
https://developer.pgadmin.org/builds/2021-10-04-1/

Fahar, can you please verify it for release on Thursday.

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS

2021-10-04 Thread Semab Tariq
Awesome, thanks!

Thanks & Regards,
Semab

On Mon, Oct 4, 2021 at 4:00 PM Dave Page  wrote:

> Hi
>
> I've tagged 4.2.2.
>
> On Fri, Oct 1, 2021 at 11:22 AM Semab Tariq 
> wrote:
>
>> (Adding Ashesh, Sandeep)
>>
>> Hi Team
>>
>> Do we have any possible date for the pgAgent-4.2.2 release?
>> I am interested in 4.2.2 because 4.2.1 doesn't have support to build
>> universal binaries on macOS but 4.2.2 will have this support because this
>> 
>> commit is already pushed to the master branch
>> Also, we plan to release pgAgent for PG-14.0, and for this, we need
>> pgAgent-4.2.2(Due to its universal binaries support)
>>
>> Thanks & Regards,
>> Semab
>>
>> On Mon, Aug 2, 2021 at 1:27 PM Semab Tariq 
>> wrote:
>>
>>> Great, thanks for letting me know.
>>>
>>> On Mon, Aug 2, 2021 at 1:12 PM Dave Page  wrote:
>>>
 Thanks, patch applied.

 On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq <
 semab.ta...@enterprisedb.com> wrote:

> Hi Team
>
> In my previous email, I attached a link to the JIRA ticket and I was
> hoping that you can access that ticket and see the details about my patch
> but I was unaware that JIRA is not accessible to the community so now I am
> attaching the details here
>
> *Details about my patch*
>
> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS
> BigSur x86_64* architecture via following command
> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake.
> app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent -
> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" -
> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D
> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/
> MacOSX11.1.sdk CMakeLists.txt
>
> I got this error in configure log
> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT"
> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5--
> Configuring incomplete, errors occurred!
>
> After some debugging, I found out that the
> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double
> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if*
> condition so I added that, and now I am able to build pgAgent universal
> binaries successfully. If you don't have any concerns with my patch can
> someone please push the changes to the source? Thanks & Regards,
> Semab
>
> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <
> semab.ta...@enterprisedb.com> wrote:
>
>> Hi Team
>>
>> Can someone please push this patch to the *master* branch of
>> *pgAgent* repo?
>> For more details Please refer to JIRA PPS-310
>> 
>>
>> --
>> Thanks & Regards,
>> Semab
>>
>
>
> --
>


 --
 Dave Page
 Blog: https://pgsnake.blogspot.com
 Twitter: @pgsnake

 EDB: https://www.enterprisedb.com


>>>
>>> --
>>> Thanks & Regards,
>>> Semab
>>>
>>
>>
>> --
>>
>>
>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>
>

--