[pgAdmin4][Patch] - Cloud Deployment Fixes

2022-02-18 Thread Khushboo Vashi
Hi,

Please find the fixes related to the cloud deployment module.
Below issues are fixed:


   - No options are shown in the instance type. - Only reproducible if you
   click immediately after selecting Instance class
   - No options for last 2 types.- Intermittent
   - Unable to change Storage config - size and iops
   - Unable to create instance when pgAdmin is installed using installer in
   Desktop mode
   - Can not create cloud instance with temporary credential
   - Mapped region display name (hardcoded) with region code

Thanks,
Khushboo


cloud_fixes.patch
Description: Binary data


pgAdmin 4 commit: Fixed following issues related to cloud deployment:

2022-02-18 Thread Akshay Joshi
Fixed following issues related to cloud deployment:
  1) No options are shown in the instance type.
  2) No options for the last 2 types.
  3) Unable to change Storage config - size and iops
  4) Unable to create an instance when pgAdmin is installed using the installer 
in Desktop mode
  5) Can not create cloud instance with the temporary credentials.
  6) Mapped region display name (hardcoded) with region code.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=448ede53c6a1822c27af5807910c559c091868ae
Author: Khushboo Vashi 

Modified Files
--
web/pgacloud/providers/rds.py  |  4 +--
web/pgadmin/misc/bgprocess/processes.py| 36 +-
web/pgadmin/misc/cloud/static/js/CloudWizard.jsx   |  2 +-
.../cloud/static/js/cloud_db_details_schema.ui.js  | 36 +-
web/pgadmin/misc/cloud/utils/aws_regions.py| 36 ++
web/pgadmin/misc/cloud/utils/rds.py| 11 ---
6 files changed, 89 insertions(+), 36 deletions(-)



Re: [pgAdmin4][Patch] - Cloud Deployment Fixes

2022-02-18 Thread Akshay Joshi
Thanks, the patch applied.

On Fri, Feb 18, 2022 at 2:23 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the fixes related to the cloud deployment module.
> Below issues are fixed:
>
>
>- No options are shown in the instance type. - Only reproducible if
>you click immediately after selecting Instance class
>- No options for last 2 types.- Intermittent
>- Unable to change Storage config - size and iops
>- Unable to create instance when pgAdmin is installed using installer
>in Desktop mode
>- Can not create cloud instance with temporary credential
>- Mapped region display name (hardcoded) with region code
>
> Thanks,
> Khushboo
>
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres *

*Mobile: +91 976-788-8246*


Re: [PATCH] Change slash to backslash in make.bat

2022-02-18 Thread Aditya Toshniwal
Hi Zhang,

Thank you for the contribution.
Backslashes can have different meanings sometimes and changing the build
scripts which are working since long are not needed.
So we can skip this patch.

On Wed, Feb 16, 2022 at 9:01 AM zhangj...@fujitsu.com 
wrote:

> Hi, all
>
> In windows, backslash should be used in the path.
> In Linux, slash should be used in path.
> But in pgadmin4\make.bat, slash is used in the path.
>
> 
> FOR /f "tokens=1 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c
> "print('%APP_NAME%'.lower().replace(' ', ''))"') DO SET APP_SHORTNAME=%%G
>
> FOR /f "tokens=1 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c
> "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_MAJOR=%%G
> FOR /f "tokens=2 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c
> "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_MINOR=%%G
> FOR /f "tokens=3 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c
> "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_REVISION=%%G
>
> --
> Although the slash does not affect the compilation, I think it is better
> to modify it.
>
> Here is a patch for make.bat.
> Please review.
>
> Best Regards!
> Zhang Jie
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*

"Don't Complain about Heat, Plant a TREE"


pgAdmin 4 commit: Update the release date in the release notes. Fixes #

2022-02-18 Thread Akshay Joshi
Update the release date in the release notes. Fixes #7191

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0cd67b15cbc706c849697c85dca7abeb42026093

Modified Files
--
docs/en_US/release_notes_6_4.rst | 2 +-
docs/en_US/release_notes_6_5.rst | 2 +-
docs/en_US/release_notes_6_6.rst | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)