Re: Pgadmin4 System Stats Extension Design
Hi, This email is regarding the recent patch I shared with you. Have you encountered any issues or identified areas for improvement? Additionally, could you assist me in resolving the challenges I'm currently facing and provide suggestions for chart titles? Thanks, Sahil On Thu, 10 Aug 2023 at 00:37, Sahil Harpal wrote: > Hi all, > > I have attached the updated patch with recent changes. > > New changes: > >1. Displayed the appropriate message If the System Stat extension does >not exist. >2. Provided option to configure refresh rates for the API calls >(Preferences settings > Dashboards > Refresh rates). >3. Added I/O analysis of block devices under the storage tab. >4. Fixed PEP-8 errors. >5. Fixed the linter errors. >6. Moved all the system stats related .jsx files under a >seperate folder "dashboard/static/js/SystemStats". >7. Added formatter to convert disk sizes (in bytes) to human readable >format. > > Pending Work: > >1. Process information - > - Issue: The pg_sys_process_info() query takes much longer (more > than 2 mins) to execute and prevents the updation of other graphs and > tables. >2. Disk information - > - Issue: The pg_sys_disk_info() query returns NULL value for some > of the drive letters. >3. StreamingChart - > - Issue: Graph shifting glitch. For the first time, graphs start > from the opposite side, and after the following API call or a few > seconds > later, those get adjusted. > > I need suggestions for labels for different tables and charts. Also, could > you please clarify the use of the counterData variable, which is used for > some of the charts (tps_stats, ti_stats, to_stats, and bio_stats)? > > Thank you, > Sahil > >
Re: Pgadmin4 System Stats Extension Design
Can you please rebase the patch and send it again? On Thu, Aug 10, 2023 at 12:37 AM Sahil Harpal wrote: > Hi all, > > I have attached the updated patch with recent changes. > > New changes: > >1. Displayed the appropriate message If the System Stat extension does >not exist. >2. Provided option to configure refresh rates for the API calls >(Preferences settings > Dashboards > Refresh rates). >3. Added I/O analysis of block devices under the storage tab. >4. Fixed PEP-8 errors. >5. Fixed the linter errors. >6. Moved all the system stats related .jsx files under a >seperate folder "dashboard/static/js/SystemStats". >7. Added formatter to convert disk sizes (in bytes) to human readable >format. > > Pending Work: > >1. Process information - > - Issue: The pg_sys_process_info() query takes much longer (more > than 2 mins) to execute and prevents the updation of other graphs and > tables. >2. Disk information - > - Issue: The pg_sys_disk_info() query returns NULL value for some > of the drive letters. >3. StreamingChart - > - Issue: Graph shifting glitch. For the first time, graphs start > from the opposite side, and after the following API call or a few > seconds > later, those get adjusted. > > I need suggestions for labels for different tables and charts. Also, could > you please clarify the use of the counterData variable, which is used for > some of the charts (tps_stats, ti_stats, to_stats, and bio_stats)? > > Thank you, > Sahil > >
Re: Pgadmin4 System Stats Extension Design
Could you please try this attached patch. SS_WIP.patch Description: Binary data
Re: Pgadmin4 System Stats Extension Design
I've noticed something here. I cleared all the errors using 'yarn run bundle:dev,' except for the unused 'counterData' variable, which I'll correct soon. But when I attempted to apply this patch on a freshly cloned repository, it displayed the following warnings. However, it didn't fail, and all the files and folders were created successfully. [image: image.png] I removed all the whitespaces before creating the patch, and I have also checked all these lines where it is showing the trailing whitespace, but there are no trailing whitespaces. The 'yarn run bundle:dev' command also does not give any prompt for this. Could you please suggest what to do? On Wed, 16 Aug 2023 at 11:08, Sahil Harpal wrote: > Could you please try this attached patch. >
