Re: [pgadmin-hackers] Change: l10n patch
2009/8/1 Marek Černocký ma...@manet.cz: Oops! I now see there is prepared function for translanted object types names. I send new patch instead previous. Marek Černocký píše v So 01. 08. 2009 v 17:58 +0200: Hi, I send patch. It solves translation for object type names in dialog Grand Wizard. Hi, Should there be some formatting in there to allow for languages where the ordering of the type name and the object name may differ from English? Guillaume? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Second l10n patch
2009/8/1 Marek Černocký ma...@manet.cz: Hi, I send patch. It solves translation for object type names in reports. Should code like this use wxPLURAL? int section = report-XmlCreateSection(wxString::Format(_(%s dependents), object-GetTranslatedTypeName().c_str())); -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Second l10n patch
Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit : Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit : 2009/8/1 Marek Černocký ma...@manet.cz: Hi, I send patch. It solves translation for object type names in reports. Should code like this use wxPLURAL? int section = report-XmlCreateSection(wxString::Format(_(%s dependents), object-GetTranslatedTypeName().c_str())); No. We need wxPLURAL when we have a variable that tells us if it is plural or not. In this code, there's nothing that gives us a hint about it. Note that I didn't actually try this patch. Only read it. Just tried it, and it works the way I think it should. I can commit it if you want. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Second l10n patch
2009/8/3 Guillaume Lelarge guilla...@lelarge.info: Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit : Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit : 2009/8/1 Marek Černocký ma...@manet.cz: Hi, I send patch. It solves translation for object type names in reports. Should code like this use wxPLURAL? int section = report-XmlCreateSection(wxString::Format(_(%s dependents), object-GetTranslatedTypeName().c_str())); No. We need wxPLURAL when we have a variable that tells us if it is plural or not. In this code, there's nothing that gives us a hint about it. Note that I didn't actually try this patch. Only read it. Just tried it, and it works the way I think it should. I can commit it if you want. Sure - thanks. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Change: l10n patch
Le lundi 3 août 2009 à 11:21:44, Dave Page a écrit : 2009/8/1 Marek Černocký ma...@manet.cz: Oops! I now see there is prepared function for translanted object types names. I send new patch instead previous. Marek Černocký píše v So 01. 08. 2009 v 17:58 +0200: Hi, I send patch. It solves translation for object type names in dialog Grand Wizard. Hi, Should there be some formatting in there to allow for languages where the ordering of the type name and the object name may differ from English? Guillaume? I tried this too, and it works AFAICT. Not sure why, in some place we use the _ and in other places, we use wxGetTranslation. Apart from that, the code Marek wrote is looking good. I'll work on the ordering in some time. Or perhaps Marek can work on this, if he agrees. I don't know enough right know to have a good answer for you. Anyways, there are other codes in pgadmin that looks like what Marek wrote, so I think we would better apply his patch, and work on the ordering in a separate patch. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by guillaume: r7998 - trunk/pgadmin3/pgadmin/frm
Author: guillaume Date: 2009-08-03 12:18:04 +0100 (Mon, 03 Aug 2009) New Revision: 7998 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7998view=rev Log: Better l10n support on the generated reports, per a patch from Marek Cernocky. Modified: trunk/pgadmin3/pgadmin/frm/frmReport.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Second l10n patch
Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit : 2009/8/1 Marek Černocký ma...@manet.cz: Hi, I send patch. It solves translation for object type names in reports. Should code like this use wxPLURAL? int section = report-XmlCreateSection(wxString::Format(_(%s dependents), object-GetTranslatedTypeName().c_str())); No. We need wxPLURAL when we have a variable that tells us if it is plural or not. In this code, there's nothing that gives us a hint about it. Note that I didn't actually try this patch. Only read it. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by guillaume: r7999 - trunk/pgadmin3
Author: guillaume Date: 2009-08-03 12:18:33 +0100 (Mon, 03 Aug 2009) New Revision: 7999 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7999view=rev Log: Sorry, forgot to commit the CHANGELOG file. Modified: trunk/pgadmin3/CHANGELOG -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Second l10n patch
Le lundi 3 août 2009 à 13:04:34, Dave Page a écrit : 2009/8/3 Guillaume Lelarge guilla...@lelarge.info: Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit : Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit : 2009/8/1 Marek Černocký ma...@manet.cz: Hi, I send patch. It solves translation for object type names in reports. Should code like this use wxPLURAL? int section = report-XmlCreateSection(wxString::Format(_(%s dependents), object-GetTranslatedTypeName().c_str())); No. We need wxPLURAL when we have a variable that tells us if it is plural or not. In this code, there's nothing that gives us a hint about it. Note that I didn't actually try this patch. Only read it. Just tried it, and it works the way I think it should. I can commit it if you want. Sure - thanks. Done. Sorry for the two commits, I forgot the CHANGELOG file. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Change: l10n patch
On Mon, Aug 3, 2009 at 12:10 PM, Guillaume Lelargeguilla...@lelarge.info wrote: I tried this too, and it works AFAICT. Not sure why, in some place we use the _ and in other places, we use wxGetTranslation. iirc, there is a reason, but I'm darned if I can remember what it it. Of course, wxGetTranslation won't work well with the stringextract scripts. Apart from that, the code Marek wrote is looking good. I'll work on the ordering in some time. Or perhaps Marek can work on this, if he agrees. I don't know enough right know to have a good answer for you. Anyways, there are other codes in pgadmin that looks like what Marek wrote, so I think we would better apply his patch, and work on the ordering in a separate patch. OK - I'll leave this stuff in your capable hands then :-) Thanks! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] SVN Commit by guillaume: r8000 - in trunk/pgadmin3: . pgadmin/frm
Author: guillaume Date: 2009-08-03 12:51:10 +0100 (Mon, 03 Aug 2009) New Revision: 8000 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8000view=rev Log: Better l10n support on the Grant Wizard, per a patch from Marek Cernocky. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/pgadmin/frm/frmGrantWizard.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Change: l10n patch
Dave Page píše v Po 03. 08. 2009 v 10:21 +0100: 2009/8/1 Marek Černocký ma...@manet.cz: Oops! I now see there is prepared function for translanted object types names. I send new patch instead previous. Marek Černocký píše v So 01. 08. 2009 v 17:58 +0200: Hi, I send patch. It solves translation for object type names in dialog Grand Wizard. Hi, Should there be some formatting in there to allow for languages where the ordering of the type name and the object name may differ from English? You are right. For some languages may be better use some like: wxString::Printf( _(%s %s), (wxString)wxGetTranslation(obj-GetTypeName()), obj-GetFullIdentifier() ) But it solves only little part of more bigger problem which reported here: http://code.pgadmin.org/trac/ticket/4 It has two solutions (Let's have real example Cannot drop system %s % s): --- 1. To leave it in translators Right czech translation is Nelze odstranit systémovou tabulku XXX (accusative case tabulkU). But it is substituted Nelze odstranit systemovou tabulka XXX (Nominative case tabulkA). I circumvent problem by other formulation in translation: Nelze odstranit systémový objekt: tabulka XXX (= Cannot drop system object: %s %s). Negative: It isn't universal solution. It's differnt laguage by language. --- 2. To split it to individual objekts Cannot drop system table %s Cannot drop system function %s Cannot drop system sequence %s ... Negative: There is much combinations which would increase quantities of code. Marek -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Change: l10n patch
Dave Page píše v Po 03. 08. 2009 v 12:26 +0100: On Mon, Aug 3, 2009 at 12:10 PM, Guillaume Lelargeguilla...@lelarge.info wrote: I tried this too, and it works AFAICT. Not sure why, in some place we use the _ and in other places, we use wxGetTranslation. wxGetTranslation isn't passed by argument -k to xgettext in stringextract script. Macro _(s) do automatic cast with macro _T(s) before call wxGetTranslation. So _(s) is useful for constant strings, which should be extracted to POT. And wxGetTranslation is useful for wxString variables (expressions are extracted elsewher, e.g by N_(s) in structure). iirc, there is a reason, but I'm darned if I can remember what it it. Of course, wxGetTranslation won't work well with the stringextract scripts. Apart from that, the code Marek wrote is looking good. I'll work on the ordering in some time. Or perhaps Marek can work on this, if he agrees. I don't know enough right know to have a good answer for you. Anyways, there are other codes in pgadmin that looks like what Marek wrote, so I think we would better apply his patch, and work on the ordering in a separate patch. OK - I'll leave this stuff in your capable hands then :-) Thanks! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Chinese translation fix
Hi, It's been suggested to me by a colleague that we should update the Chinese translation, as the current one is a literal translation with no context: Screen: Schema--Grant Wizard--Selection String/Label: Check All UnCheck All Current Translation: “检查所有 未检查所有 Suggested Translation: 全选 全不选 全选 全不选 mean Select All Select None in Chinese. Should we make that change? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Chinese translation fix
Thanks. It is good suggested. Please to changed it. 全選 全不選 zh_CN Chinese simplified Best Regards, 朝益(ChaoYi) 2009/8/4 Dave Page dp...@pgadmin.org Hi, It's been suggested to me by a colleague that we should update the Chinese translation, as the current one is a literal translation with no context: Screen: Schema--Grant Wizard--Selection String/Label: Check All UnCheck All Current Translation: 「檢查所有 未檢查所有 Suggested Translation: 全選 全不選 全選 全不選 mean Select All Select None in Chinese. Should we make that change? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Re: [pgadmin-hackers] Chinese translation fix
Sorry, I understood it wrong. That was my suggested for CN, please don't chang to TW . Best Regards, 朝益(ChaoYi) My Blog: http://oss-tw.blogspot.com - My MSN IM GTalk IM: kuo.cha...@gmail.com Skype: kuo.chaoyi - Admin by http://postgresql-chinese.blogspot.com http://postgresql.oss.tw http://www.lifetv.org.tw - On Tue, Aug 4, 2009 at 12:35 AM, 郭朝益(ChaoYi, Kuo) kuo.cha...@gmail.comwrote: Thanks. It is good suggested. Please to changed it. 全選 全不選 zh_CN Chinese simplified Best Regards, 朝益(ChaoYi) 2009/8/4 Dave Page dp...@pgadmin.org Hi, It's been suggested to me by a colleague that we should update the Chinese translation, as the current one is a literal translation with no context: Screen: Schema--Grant Wizard--Selection String/Label: Check All UnCheck All Current Translation: 「檢查所有 未檢查所有 Suggested Translation: 全選 全不選 全選 全不選 mean Select All Select None in Chinese. Should we make that change? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Re: [pgadmin-hackers] Chinese translation fix
Sorry, I understood it wrong. That was my suggested for CN, please don't chang to TW . I will, thanks --- Quan Zongliang quanzongli...@gmail.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
