[pgadmin-hackers] SVN Commit by dpage: r8468 - in trunk/pgadmin3: . pgadmin/frm
Author: dpage Date: 2010-07-15 12:57:32 +0100 (Thu, 15 Jul 2010) New Revision: 8468 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8468view=rev Log: Fix a crash that occurred when pressing a key on a text cell in the Edit Grid, when not in Edit mode. Ticket number 213. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/pgadmin/frm/frmEditGrid.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin III] #213: Crash when entering text in Table grid
#213: Crash when entering text in Table grid ---+ Reporter: brsa | Owner: dpage Type: bug | Status: closed Priority: critical | Milestone: 1.12 Component: pgadmin | Version: trunk Resolution: fixed |Keywords: Platform: windows | ---+ Changes (by dpage): * status: new = closed * resolution: = fixed Comment: Fixed in rev 8468 -- Ticket URL: http://code.pgadmin.org/trac/ticket/213#comment:1 pgAdmin III http://code.pgadmin.org/trac/ pgAdmin III -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Looking for table design interface advice for pgAdmin Database Designer
On Wed, Jul 14, 2010 at 5:46 PM, Guillaume Lelarge guilla...@lelarge.infowrote: Le 14/07/2010 17:56, Thom Brown a écrit : On 14 July 2010 16:38, Luis Ochoa ziul1...@gmail.com wrote: ... Regards, Luis. Thanks for working on this. I'm wondering if it might be better if there wasn't a type selected automatically for a column so that the user doesn't accidently leave it and forget to change it. Yeah, I also think so. And there's a good chance people won't be happy with our default choice for the datatype. So, it's better not to have one. That's a good point, and will be fixed soon. Also, could the data types line up so it's easier to read? I know I'm not sure about line up data types you can see other modeller like this: http://www.fabforce.net/dbdesigner4/images/ss/dbd4_ss_simplemodel.png and in fact they align at left table's columns. Probably line up datatypes won't get a better reading, because columns sizes differences, for example: id : integer cmpy_emp_first_name_id : integer id2 : integer id 3 : integer cmpy_emp_last_name_of_external_boss_id: integer id 5 : integer it's still under development, but clickable elements should probably be bigger and clearer to reduce the chance of clicking on the wrong thing. I'm not sure if clickable elements should be bigger that their current size (8x8), at first time I defined then like 16x16 but the look weird, but well this can be tested changed if needed later :) but as a comment: when you past over handles elements like the +, - and join, the mouse over action, can change the mouse pointer, right now I don't do that but later I'm going to do that. And anything the user has to squint at to see (like the F for foreign key and U for unique constraint) would be a problem. Right F and U where only temporary solutions, but I think that Guillaume comment about using standard icons of pgAdmin is the best way of create consistency at user interface between database designer and others parts of pgAdmin. And tooltips for everything? Many of those icons could be seen as cryptic. Yes I think about tooltips, and I'm going to add them in a future Regarding the joins, will there be a clear indicator as to which column is linking to which? my idea for joins is this: When you select a join, columns from source table (always primary of that table) will change their color to the same color of the join when is selected, and then destination table column (foreign keys to that primary keys) will change too theri color. Would tables be renamable? Yes *1. ;) *1 Some restrictions apply, if table is just in modeler (not implemented yet) it can be done, or if table accomplish with all requirements to be rename, it can be done too. Just remember if a table name is changed, is changed at modeler level, when you commit changes, modeler try to rename it, if not possible some kind of warning is raised and table name remains as started. +1 for the four comments. And what's your Twitter handle? I don't see it above. :) Sorry for that :$ but it was fixed yet by Guillaume (thanks) http://twitter.com/xiul/ Thanks for your comments. Regards, Luis.
Re: [pgadmin-hackers] Looking for table design interface advice for pgAdmin Database Designer
On 15 July 2010 16:10, Luis Ochoa ziul1...@gmail.com wrote: On Wed, Jul 14, 2010 at 5:46 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 14/07/2010 17:56, Thom Brown a écrit : On 14 July 2010 16:38, Luis Ochoa ziul1...@gmail.com wrote: ... Regards, Luis. Thanks for working on this. I'm wondering if it might be better if there wasn't a type selected automatically for a column so that the user doesn't accidently leave it and forget to change it. Yeah, I also think so. And there's a good chance people won't be happy with our default choice for the datatype. So, it's better not to have one. That's a good point, and will be fixed soon. Also, could the data types line up so it's easier to read? I know I'm not sure about line up data types you can see other modeller like this: http://www.fabforce.net/dbdesigner4/images/ss/dbd4_ss_simplemodel.png and in fact they align at left table's columns. Probably line up datatypes won't get a better reading, because columns sizes differences, for example: id : integer cmpy_emp_first_name_id : integer id2 : integer id 3 : integer cmpy_emp_last_name_of_external_boss_id : integer id 5 : integer In that case, could they be bold and a different colour too, just to improve scanability? it's still under development, but clickable elements should probably be bigger and clearer to reduce the chance of clicking on the wrong thing. I'm not sure if clickable elements should be bigger that their current size (8x8), at first time I defined then like 16x16 but the look weird, but well this can be tested changed if needed later :) but as a comment: when you past over handles elements like the +, - and join, the mouse over action, can change the mouse pointer, right now I don't do that but later I'm going to do that. And anything the user has to squint at to see (like the F for foreign key and U for unique constraint) would be a problem. Right F and U where only temporary solutions, but I think that Guillaume comment about using standard icons of pgAdmin is the best way of create consistency at user interface between database designer and others parts of pgAdmin. And tooltips for everything? Many of those icons could be seen as cryptic. Yes I think about tooltips, and I'm going to add them in a future Regarding the joins, will there be a clear indicator as to which column is linking to which? my idea for joins is this: When you select a join, columns from source table (always primary of that table) will change their color to the same color of the join when is selected, and then destination table column (foreign keys to that primary keys) will change too theri color. I like that idea, although it would also be worth thinking about people who are colour-blind when designing this if you can too. Would tables be renamable? Yes *1. ;) *1 Some restrictions apply, if table is just in modeler (not implemented yet) it can be done, or if table accomplish with all requirements to be rename, it can be done too. Just remember if a table name is changed, is changed at modeler level, when you commit changes, modeler try to rename it, if not possible some kind of warning is raised and table name remains as started. +1 for the four comments. And what's your Twitter handle? I don't see it above. :) Sorry for that :$ but it was fixed yet by Guillaume (thanks) http://twitter.com/xiul/ Thanks for your comments. Regards, Luis. Thanks Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin III] #209: Connect to Server dialog buggy
#209: Connect to Server dialog buggy --+- Reporter: brsa | Owner: ashesh Type: bug | Status: closed Priority: major| Milestone: 1.12 Component: pgadmin | Version: Resolution: fixed|Keywords: querytool Platform: windows | --+- Changes (by gleu): * status: assigned = closed * resolution: = fixed Comment: Fixed in r8467. -- Ticket URL: http://code.pgadmin.org/trac/ticket/209#comment:3 pgAdmin III http://code.pgadmin.org/trac/ pgAdmin III -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] First SVN module moved to GIT
As part of our move to GIT, I finally got the scripts to split the SVN repo up properly, and have now moved the pgagent repository over to git.postgresql.org. It can be accessed here: http://git.postgresql.org/gitweb?p=pgagent.git;a=summary If you are a pgAdmin committer, in order to commit to this repository you will need to ensure you have an SSH key configured in your community account profile. You can add this here: http://wwwmaster.postgresql.org/login?p=community/profile. Once you have a key, please let me know what your community login user ID is. Oh - and please ensure all commits to pgAgent go to the GIT repo from now on! Thanks! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] First SVN module moved to GIT
I've now moved pgadmin1 and pgadmin2 as well. Don't expect anyone to touch those though :-p On Thu, Jul 15, 2010 at 9:11 PM, Dave Page dp...@pgadmin.org wrote: As part of our move to GIT, I finally got the scripts to split the SVN repo up properly, and have now moved the pgagent repository over to git.postgresql.org. It can be accessed here: http://git.postgresql.org/gitweb?p=pgagent.git;a=summary If you are a pgAdmin committer, in order to commit to this repository you will need to ensure you have an SSH key configured in your community account profile. You can add this here: http://wwwmaster.postgresql.org/login?p=community/profile. Once you have a key, please let me know what your community login user ID is. Oh - and please ensure all commits to pgAgent go to the GIT repo from now on! Thanks! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postgres Company -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] First SVN module moved to GIT
It would be well respectively to update the informations on the web. Regards Marek Černocký Dave Page píše v Čt 15. 07. 2010 v 21:11 +0100: As part of our move to GIT, I finally got the scripts to split the SVN repo up properly, and have now moved the pgagent repository over to git.postgresql.org. It can be accessed here: http://git.postgresql.org/gitweb?p=pgagent.git;a=summary If you are a pgAdmin committer, in order to commit to this repository you will need to ensure you have an SSH key configured in your community account profile. You can add this here: http://wwwmaster.postgresql.org/login?p=community/profile. Once you have a key, please let me know what your community login user ID is. Oh - and please ensure all commits to pgAgent go to the GIT repo from now on! Thanks! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] First SVN module moved to GIT
2010/7/15 Marek Černocký ma...@manet.cz: It would be well respectively to update the informations on the web. I will, but that code is being moved as well. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] First SVN module moved to GIT
Le 15/07/2010 22:26, Dave Page a écrit : I've now moved pgadmin1 and pgadmin2 as well. Don't expect anyone to touch those though :-p You're right... But I'm really looking forward to get the pgadmin3 GIT repo :) -- Guillaume http://www.postgresql.fr http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] First SVN module moved to GIT
On Thu, Jul 15, 2010 at 9:55 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 15/07/2010 22:26, Dave Page a écrit : I've now moved pgadmin1 and pgadmin2 as well. Don't expect anyone to touch those though :-p You're right... But I'm really looking forward to get the pgadmin3 GIT repo :) Yeah - me too. Do you think we should do that now? We have a couple of weeks until the next beta As an aside, I've also moved the www module now (and given you access). However, whilst the backup website on developer.pgadmin.org should now be pulling it's code from GIT, the primary site on romulus.postgresql.org is still using SVN due to an unrelated error. I'll try to sort that in the morning, but in the meantime, please don't update the website code!! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] First SVN module moved to GIT
Le 15/07/2010 23:18, Dave Page a écrit : On Thu, Jul 15, 2010 at 9:55 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 15/07/2010 22:26, Dave Page a écrit : I've now moved pgadmin1 and pgadmin2 as well. Don't expect anyone to touch those though :-p You're right... But I'm really looking forward to get the pgadmin3 GIT repo :) Yeah - me too. Do you think we should do that now? We have a couple of weeks until the next beta No. I don't need it right now. It could make things easier if I had some stuff to commit on a new dev branch, but I don't have that right now (2 patches ready, working on two others). Still trying to work on that SQL/Med patch of mine. I could have something interesting next sunday. Anyway, I don't think we need it before end of the month. As an aside, I've also moved the www module now (and given you access). However, whilst the backup website on developer.pgadmin.org should now be pulling it's code from GIT, the primary site on romulus.postgresql.org is still using SVN due to an unrelated error. I'll try to sort that in the morning, but in the meantime, please don't update the website code!! Well, I don't intend to update it tonight too. Don't really know why I'm online tonight if I don't commit anything at all :) -- Guillaume http://www.postgresql.fr http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
