Re: [pgadmin-hackers] A question about database designer first deliverable

2011-05-16 Thread Guillaume Lelarge
Le 05/13/2011 12:05 AM, Luis Ochoa a écrit :
 Hi, Guillaume, I have found my first issue, I wrote at my schedule that for
 my first deliverable I won't create code any new features for database
 designer class commitable status, but when I try to do all DD-TODO labels,
 I have found some things that I need to write new code to accomplish the
 goal of delete it, I have not problem with coding it, except when that label
 have a big change to code, in that case can I postpone it, don't delete that
 label and accomplish it later (when marked at my schedule if apply)?
 

You'll need to be more precise if you want that I can give you an
interesting answer. Which feature is it?


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin III] #316: SQL Editor fail

2011-05-16 Thread pgAdmin Trac
#316: SQL Editor fail
-+--
 Reporter:  Aleksey Chirkin  |   Owner:  dpage   
 Type:  bug  |  Status:  new 
 Priority:  minor|   Milestone:  
Component:  pgadmin  | Version:  trunk   
 Keywords:  querytool|Platform:  mac os x
-+--
 I'm finding a bug in pgAdmin 1.14.0 Beta 1.
 To make sure that the problem is still there I'm pulled from latest git
 today.

 To reproduce it, enter in SQL Editor, write symbol ( and then press
 enter for go to new line. It crashing pgAdmin.

 I'm testing it on MacOS 10.6.7.

-- 
Ticket URL: http://code.pgadmin.org/trac/ticket/316
pgAdmin III http://code.pgadmin.org/trac/
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin III] #316: SQL Editor fail

2011-05-16 Thread pgAdmin Trac
#316: SQL Editor fail
-+--
 Reporter:  Aleksey Chirkin  |   Owner:  dpage   
 Type:  bug  |  Status:  new 
 Priority:  minor|   Milestone:  
Component:  pgadmin  | Version:  trunk   
 Keywords:  querytool|Platform:  mac os x
-+--

Comment(by gleu):

 Works fine on Linux, but Dave reproduced the bug on Mac OS X.

 From Dave's email:


 The
 stack trace (which contains 56977 frames!!) indicates the crash happens
 deep in Apples rendering code, which in turn is called from wxWidgets
 painting code which is called by the main event loop. As far as I can see,
 there is no pgAdmin code in the stack at all.

 It seems to occur any time you hit return when there's an unmatched
 bracket of any type on the line. I don't think the block folding is the
 issue, as the crash doesn't occur with text like BEGIN which will also
 start a new code block.

-- 
Ticket URL: http://code.pgadmin.org/trac/ticket/316#comment:1
pgAdmin III http://code.pgadmin.org/trac/
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] Plural forms

2011-05-16 Thread Marek Černocký
Function frmQuery::OnPositionStc should use wxPLURAL for %d char
message. Patch is attached.

Regards
Marek Černocký
diff --git a/pgadmin/frm/frmQuery.cpp b/pgadmin/frm/frmQuery.cpp
index 07f126a..d3d0097 100644
--- a/pgadmin/frm/frmQuery.cpp
+++ b/pgadmin/frm/frmQuery.cpp
@@ -1634,18 +1634,17 @@ void frmQuery::OnChangeStc(wxStyledTextEvent event)
 
 void frmQuery::OnPositionStc(wxStyledTextEvent event)
 {
-   int selFrom, selTo;
+   int selFrom, selTo, selCount;
sqlQuery-GetSelection(selFrom, selTo);
+   selCount = selTo - selFrom;
 
wxString pos;
pos.Printf(_(Ln %d, Col %d, Ch %d), sqlQuery-LineFromPosition(sqlQuery-GetCurrentPos()) + 1, sqlQuery-GetColumn(sqlQuery-GetCurrentPos()) + 1, s
SetStatusText(pos, STATUSPOS_POS);
-   if (selTo - selFrom == 1)
-   pos.Printf(_(%d char), selTo - selFrom);
-   else if (selTo - selFrom  1)
-   pos.Printf(_(%d chars), selTo - selFrom);
-   else
+   if (selCount  1)
pos = wxEmptyString;
+   else
+   pos.Printf(wxPLURAL(%d char, %d chars, selCount), selCount);
SetStatusText(pos, STATUSPOS_SEL);
 
 }
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers