[pgadmin-hackers] pgAdmin III commit: Automatic merge using stringmerge script.
Automatic merge using stringmerge script. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=93f5220d6547cb779af8e9bf2d0f17f51069e665 Modified Files -- i18n/af_ZA/pgadmin3.po | 131 +- i18n/ar_SA/pgadmin3.po | 131 +- i18n/bg_BG/pgadmin3.po | 131 +- i18n/ca_ES/pgadmin3.po | 131 +- i18n/cs_CZ/pgadmin3.po | 131 +- i18n/da_DK/pgadmin3.po | 131 +- i18n/de_CH/pgadmin3.po | 131 +- i18n/de_DE/pgadmin3.po | 131 +- i18n/el_GR/pgadmin3.po | 131 +- i18n/es_ES/pgadmin3.po | 131 +- i18n/fa_IR/pgadmin3.po | 131 +- i18n/fi_FI/pgadmin3.po | 131 +- i18n/fr_FR/pgadmin3.po |22991 i18n/gl_ES/pgadmin3.po | 131 +- i18n/gu_IN/pgadmin3.po | 129 +- i18n/hi_IN/pgadmin3.po | 129 +- i18n/hr_HR/pgadmin3.po | 131 +- i18n/hu_HU/pgadmin3.po | 131 +- i18n/id_ID/pgadmin3.po | 131 +- i18n/is_IS/pgadmin3.po | 129 +- i18n/it_IT/pgadmin3.po | 131 +- i18n/ja_JP/pgadmin3.po | 131 +- i18n/ko_KR/pgadmin3.po | 131 +- i18n/lt_LT/pgadmin3.po | 131 +- i18n/lv_LV/pgadmin3.po | 131 +- i18n/mk_MK/pgadmin3.po | 129 +- i18n/nb_NO/pgadmin3.po | 131 +- i18n/nl_NL/pgadmin3.po | 131 +- i18n/pl_PL/pgadmin3.po | 131 +- i18n/pt_BR/pgadmin3.po | 131 +- i18n/pt_PT/pgadmin3.po | 131 +- i18n/ro_RO/pgadmin3.po | 131 +- i18n/ru_RU/pgadmin3.po | 131 +- i18n/sk_SK/pgadmin3.po | 131 +- i18n/sl_SI/pgadmin3.po | 131 +- i18n/sr_RS/pgadmin3.po | 131 +- i18n/sv_SE/pgadmin3.po | 131 +- i18n/te_IN/pgadmin3.po | 129 +- i18n/tl_PH/pgadmin3.po | 136 +- i18n/tr_TR/pgadmin3.po | 131 +- i18n/uk_UA/pgadmin3.po | 129 +- i18n/ur_PK/pgadmin3.po | 131 +- i18n/vi_VN/pgadmin3.po | 129 +- i18n/zh_CN/pgadmin3.po | 131 +- i18n/zh_TW/pgadmin3.po | 131 +- 45 files changed, 10972 insertions(+), 17774 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Update .pot file.
Update .pot file. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e83548785f8c75dbebb5fcf5a3fd70b3c7abc932 Modified Files -- pgadmin3.pot | 129 - 1 files changed, 72 insertions(+), 57 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Update french translation.
Update french translation. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b832710a34d77fec62115a0723e52f17e65f4e3e Modified Files -- i18n/fr_FR/pgadmin3.mo | Bin 317675 - 317918 bytes i18n/fr_FR/pgadmin3.po |22943 2 files changed, 15251 insertions(+), 7692 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Rename Replication to Slony Replication
On Mon, 2011-06-27 at 11:03 +0600, Timon wrote: and now you should update pgadmin3.pot file :) cause translator are preparing translation for new release :) This is done. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
Database Designer (milestone 1 of GSoC 2011) This patch adds the database designer. This new tool helps users to create their databases' schema. Lots of things still need to be implemented, but the raw features are in. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a8c26ad9f988e1948ffd8d6d3032560ceb437aaa Author: Luis Ochoa ziul1...@gmail.com Modified Files -- pgadmin/Makefile.am|1 + pgadmin/dd/dditems/figures/ddColumnFigure.cpp | 458 + pgadmin/dd/dditems/figures/ddColumnKindIcon.cpp| 418 + pgadmin/dd/dditems/figures/ddColumnOptionIcon.cpp | 127 ++ .../dd/dditems/figures/ddRelationshipFigure.cpp| 822 + pgadmin/dd/dditems/figures/ddRelationshipItem.cpp | 112 ++ .../dd/dditems/figures/ddRelationshipTerminal.cpp | 154 ++ pgadmin/dd/dditems/figures/ddTableFigure.cpp | 1030 +++ .../dd/dditems/figures/ddTextTableItemFigure.cpp | 529 ++ pgadmin/dd/dditems/figures/module.mk | 23 + .../dd/dditems/handles/ddAddColButtonHandle.cpp| 78 + pgadmin/dd/dditems/handles/ddAddFkButtonHandle.cpp | 71 + .../dditems/handles/ddMinMaxTableButtonHandle.cpp | 68 + .../dditems/handles/ddRemoveTableButtonHandle.cpp | 75 + pgadmin/dd/dditems/handles/ddScrollBarHandle.cpp | 127 ++ .../dd/dditems/handles/ddSouthTableSizeHandle.cpp | 92 + pgadmin/dd/dditems/handles/module.mk | 21 + pgadmin/dd/dditems/locators/ddAddColLocator.cpp| 41 + pgadmin/dd/dditems/locators/ddAddFkLocator.cpp | 41 + .../dd/dditems/locators/ddMinMaxTableLocator.cpp | 44 + .../dd/dditems/locators/ddRemoveTableLocator.cpp | 44 + .../dditems/locators/ddScrollBarTableLocator.cpp | 45 + .../dd/dditems/locators/ddTableBottomLocator.cpp | 45 + pgadmin/dd/dditems/locators/module.mk | 21 + pgadmin/dd/dditems/module.mk | 19 + pgadmin/dd/dditems/tools/ddColumnFigureTool.cpp| 130 ++ pgadmin/dd/dditems/tools/ddColumnTextTool.cpp | 84 + pgadmin/dd/dditems/tools/module.mk | 17 + .../dditems/utilities/ddPrecisionScaleDialog.cpp | 204 +++ .../dd/dditems/utilities/ddSelectKindFksDialog.cpp | 299 pgadmin/dd/dditems/utilities/ddTableNameDialog.cpp | 229 +++ pgadmin/dd/dditems/utilities/module.mk | 17 + pgadmin/dd/ddmodel/ddDatabaseDesign.cpp| 197 +++ pgadmin/dd/ddmodel/ddDrawingEditor.cpp | 78 + pgadmin/dd/ddmodel/ddDrawingView.cpp | 131 ++ pgadmin/dd/ddmodel/ddTextEditor.cpp| 64 + pgadmin/dd/ddmodel/module.mk | 19 + pgadmin/dd/module.mk | 18 + pgadmin/dd/wxhotdraw/connectors/module.mk | 19 + .../wxhotdraw/connectors/wxhdChopBoxConnector.cpp | 81 + pgadmin/dd/wxhotdraw/connectors/wxhdIConnector.cpp | 66 + .../wxhotdraw/connectors/wxhdLocatorConnector.cpp | 60 + .../connectors/wxhdStickyRectangleConnector.cpp| 72 + .../wxhotdraw/figures/defaultAttributes/module.mk | 19 + .../defaultAttributes/wxhdFillAttribute.cpp| 45 + .../defaultAttributes/wxhdFontAttribute.cpp| 43 + .../defaultAttributes/wxhdFontColorAttribute.cpp | 38 + .../defaultAttributes/wxhdLineAttribute.cpp| 43 + pgadmin/dd/wxhotdraw/figures/module.mk | 30 + .../dd/wxhotdraw/figures/wxhdAbstractFigure.cpp| 134 ++ .../wxhotdraw/figures/wxhdAbstractMenuFigure.cpp | 59 + pgadmin/dd/wxhotdraw/figures/wxhdAttribute.cpp | 34 + .../dd/wxhotdraw/figures/wxhdAttributeFigure.cpp | 95 + pgadmin/dd/wxhotdraw/figures/wxhdBitmapFigure.cpp | 61 + .../dd/wxhotdraw/figures/wxhdCompositeFigure.cpp | 229 +++ .../dd/wxhotdraw/figures/wxhdIConnectionFigure.cpp | 23 + pgadmin/dd/wxhotdraw/figures/wxhdIFigure.cpp | 171 ++ .../dd/wxhotdraw/figures/wxhdLineConnection.cpp| 270 +++ pgadmin/dd/wxhotdraw/figures/wxhdLineTerminal.cpp | 59 + .../dd/wxhotdraw/figures/wxhdPolyLineFigure.cpp| 355 .../dd/wxhotdraw/figures/wxhdRectangleFigure.cpp | 52 + .../dd/wxhotdraw/figures/wxhdSimpleTextFigure.cpp | 138 ++ pgadmin/dd/wxhotdraw/handles/module.mk | 23 + pgadmin/dd/wxhotdraw/handles/wxhdButtonHandle.cpp | 72 + .../handles/wxhdChangeConnectionEndHandle.cpp | 65 + .../handles/wxhdChangeConnectionHandle.cpp | 111 ++ .../handles/wxhdChangeConnectionStartHandle.cpp| 65 + pgadmin/dd/wxhotdraw/handles/wxhdIHandle.cpp | 47 + .../wxhotdraw/handles/wxhdLineConnectionHandle.cpp | 45 + pgadmin/dd/wxhotdraw/handles/wxhdLocatorHandle.cpp | 53 + .../dd/wxhotdraw/handles/wxhdPolyLineHandle.cpp| 77 + pgadmin/dd/wxhotdraw/locators/module.mk| 17 + pgadmin/dd/wxhotdraw/locators/wxhdILocator.cpp | 27 + .../dd/wxhotdraw/locators/wxhdPolyLineLocator.cpp | 49 + pgadmin/dd/wxhotdraw/main/module.mk| 18 +
Re: [pgadmin-hackers] First test of the Database Designer
On Sun, 2011-06-26 at 20:29 +0100, Dave Page wrote: On Sat, Jun 25, 2011 at 3:50 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-06-25 at 15:51 +0200, Guillaume Lelarge wrote: On Sat, 2011-06-25 at 12:18 +0200, Guillaume Lelarge wrote: [...] Dave, any objection on applying the current work of Luis? I'll work this afternoon on the xpm files, I should be able to send a patch after that. Branch available here: https://github.com/gleu/pgadmin3/tree/gsoc2011 Patches attached (they will be applied as one). And here are the changes on the VC++ project file. Waiting for comments before applying :) Hi, Sorry - in the late stages of my current project, so I'm swamped with testing/QA/docs/you name it! I won't be able to review, but trust you to do so Guillaume. OK, thanks. The one comment I would make from the thread is that I don't think the code should be committed without the XRC changes you mention. If that's not done before it's committed, I doubt it ever will be. I don't want that Luis lost some time working on the XRC files. And I don't want him to get stuck before I do it. So, I commited the patch, and pushed it, so that he could work from the new master. And I'll work on the XRC files tonight. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
Did this patch randomly update a couple of copyright years to 2011, or were those files that were somehow forgotten in a previous run? EIther way it looked unrelated so I figured I'd ask :-) (e.g .pgForeignServer.cpp and pgUserMapping.cpp) There also seem to be some unrealated changes in the visual studio project? Changing the default from debug win32 to release x64, was that intentional? (at least I think it did that - unfortunately VS appears to have reordered the file pretty bad so the diff is hard to read) Other than that - yay! Now I just have to pull this down and test it... //Magnus On Mon, Jun 27, 2011 at 09:07, Guillaume Lelarge guilla...@lelarge.info wrote: Database Designer (milestone 1 of GSoC 2011) This patch adds the database designer. This new tool helps users to create their databases' schema. Lots of things still need to be implemented, but the raw features are in. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a8c26ad9f988e1948ffd8d6d3032560ceb437aaa Author: Luis Ochoa ziul1...@gmail.com Modified Files -- pgadmin/Makefile.am | 1 + pgadmin/dd/dditems/figures/ddColumnFigure.cpp | 458 + pgadmin/dd/dditems/figures/ddColumnKindIcon.cpp | 418 + pgadmin/dd/dditems/figures/ddColumnOptionIcon.cpp | 127 ++ .../dd/dditems/figures/ddRelationshipFigure.cpp | 822 + pgadmin/dd/dditems/figures/ddRelationshipItem.cpp | 112 ++ .../dd/dditems/figures/ddRelationshipTerminal.cpp | 154 ++ pgadmin/dd/dditems/figures/ddTableFigure.cpp | 1030 +++ .../dd/dditems/figures/ddTextTableItemFigure.cpp | 529 ++ pgadmin/dd/dditems/figures/module.mk | 23 + .../dd/dditems/handles/ddAddColButtonHandle.cpp | 78 + pgadmin/dd/dditems/handles/ddAddFkButtonHandle.cpp | 71 + .../dditems/handles/ddMinMaxTableButtonHandle.cpp | 68 + .../dditems/handles/ddRemoveTableButtonHandle.cpp | 75 + pgadmin/dd/dditems/handles/ddScrollBarHandle.cpp | 127 ++ .../dd/dditems/handles/ddSouthTableSizeHandle.cpp | 92 + pgadmin/dd/dditems/handles/module.mk | 21 + pgadmin/dd/dditems/locators/ddAddColLocator.cpp | 41 + pgadmin/dd/dditems/locators/ddAddFkLocator.cpp | 41 + .../dd/dditems/locators/ddMinMaxTableLocator.cpp | 44 + .../dd/dditems/locators/ddRemoveTableLocator.cpp | 44 + .../dditems/locators/ddScrollBarTableLocator.cpp | 45 + .../dd/dditems/locators/ddTableBottomLocator.cpp | 45 + pgadmin/dd/dditems/locators/module.mk | 21 + pgadmin/dd/dditems/module.mk | 19 + pgadmin/dd/dditems/tools/ddColumnFigureTool.cpp | 130 ++ pgadmin/dd/dditems/tools/ddColumnTextTool.cpp | 84 + pgadmin/dd/dditems/tools/module.mk | 17 + .../dditems/utilities/ddPrecisionScaleDialog.cpp | 204 +++ .../dd/dditems/utilities/ddSelectKindFksDialog.cpp | 299 pgadmin/dd/dditems/utilities/ddTableNameDialog.cpp | 229 +++ pgadmin/dd/dditems/utilities/module.mk | 17 + pgadmin/dd/ddmodel/ddDatabaseDesign.cpp | 197 +++ pgadmin/dd/ddmodel/ddDrawingEditor.cpp | 78 + pgadmin/dd/ddmodel/ddDrawingView.cpp | 131 ++ pgadmin/dd/ddmodel/ddTextEditor.cpp | 64 + pgadmin/dd/ddmodel/module.mk | 19 + pgadmin/dd/module.mk | 18 + pgadmin/dd/wxhotdraw/connectors/module.mk | 19 + .../wxhotdraw/connectors/wxhdChopBoxConnector.cpp | 81 + pgadmin/dd/wxhotdraw/connectors/wxhdIConnector.cpp | 66 + .../wxhotdraw/connectors/wxhdLocatorConnector.cpp | 60 + .../connectors/wxhdStickyRectangleConnector.cpp | 72 + .../wxhotdraw/figures/defaultAttributes/module.mk | 19 + .../defaultAttributes/wxhdFillAttribute.cpp | 45 + .../defaultAttributes/wxhdFontAttribute.cpp | 43 + .../defaultAttributes/wxhdFontColorAttribute.cpp | 38 + .../defaultAttributes/wxhdLineAttribute.cpp | 43 + pgadmin/dd/wxhotdraw/figures/module.mk | 30 + .../dd/wxhotdraw/figures/wxhdAbstractFigure.cpp | 134 ++ .../wxhotdraw/figures/wxhdAbstractMenuFigure.cpp | 59 + pgadmin/dd/wxhotdraw/figures/wxhdAttribute.cpp | 34 + .../dd/wxhotdraw/figures/wxhdAttributeFigure.cpp | 95 + pgadmin/dd/wxhotdraw/figures/wxhdBitmapFigure.cpp | 61 + .../dd/wxhotdraw/figures/wxhdCompositeFigure.cpp | 229 +++ .../dd/wxhotdraw/figures/wxhdIConnectionFigure.cpp | 23 + pgadmin/dd/wxhotdraw/figures/wxhdIFigure.cpp | 171 ++ .../dd/wxhotdraw/figures/wxhdLineConnection.cpp | 270 +++ pgadmin/dd/wxhotdraw/figures/wxhdLineTerminal.cpp | 59 + .../dd/wxhotdraw/figures/wxhdPolyLineFigure.cpp | 355 .../dd/wxhotdraw/figures/wxhdRectangleFigure.cpp | 52 + .../dd/wxhotdraw/figures/wxhdSimpleTextFigure.cpp | 138 ++
[pgadmin-hackers] pgAdmin III commit: Fix slony capitalization
Fix slony capitalization As usual, per Thom Brown Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=990e3f0c98a68d3af682736055227fcae6747038 Modified Files -- pgadmin/ui/dlgAggregate.xrc |2 +- pgadmin/ui/xrcDialogs.cpp | 100 +- 2 files changed, 51 insertions(+), 51 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Fix slony capitalization
Fix slony capitalization As usual, per Thom Brown Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ffe86550d0e2392d80091e84647d4079eb639a73 Modified Files -- pgadmin/ui/dlgAggregate.xrc |2 +- pgadmin/ui/xrcDialogs.cpp | 100 +- 2 files changed, 51 insertions(+), 51 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Rename Replication to Slony Replication
On Sun, Jun 26, 2011 at 20:29, Thom Brown t...@linux.com wrote: On 26 June 2011 18:59, Magnus Hagander mag...@hagander.net wrote: Rename Replication to Slony Replication Also change Use Replication to Use Slony in dialogs, to make it more clear that it's about Slony and not the builtin replication. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bd9fd9b20284b28e5090fd78e3d283ab046c0bc4 Modified Files -- CHANGELOG | 3 + docs/en_US/pgadmin3.hhp.cached | Bin 2453 - 2567 bytes docs/en_US/slony-example.html | 4 +- pgadmin/frm/frmMain.cpp | 2 +- pgadmin/slony/slCluster.cpp | 2 +- pgadmin/ui/dlgAggregate.xrc | 2 +- pgadmin/ui/dlgCast.xrc | 2 +- pgadmin/ui/dlgCheck.xrc | 2 +- pgadmin/ui/dlgCollation.xrc | 2 +- pgadmin/ui/dlgColumn.xrc | 2 +- pgadmin/ui/dlgConversion.xrc | 2 +- pgadmin/ui/dlgDomain.xrc | 2 +- pgadmin/ui/dlgExtTable.xrc | 2 +- pgadmin/ui/dlgExtension.xrc | 2 +- pgadmin/ui/dlgForeignDataWrapper.xrc | 2 +- pgadmin/ui/dlgForeignKey.xrc | 2 +- pgadmin/ui/dlgForeignServer.xrc | 2 +- pgadmin/ui/dlgForeignTable.xrc | 2 +- pgadmin/ui/dlgFunction.xrc | 2 +- pgadmin/ui/dlgGroup.xrc | 2 +- pgadmin/ui/dlgIndex.xrc | 2 +- pgadmin/ui/dlgIndexConstraint.xrc | 2 +- pgadmin/ui/dlgLanguage.xrc | 2 +- pgadmin/ui/dlgOperator.xrc | 2 +- pgadmin/ui/dlgPackage.xrc | 2 +- pgadmin/ui/dlgRole.xrc | 2 +- pgadmin/ui/dlgRule.xrc | 2 +- pgadmin/ui/dlgSchema.xrc | 2 +- pgadmin/ui/dlgSequence.xrc | 2 +- pgadmin/ui/dlgSynonym.xrc | 2 +- pgadmin/ui/dlgTable.xrc | 2 +- pgadmin/ui/dlgTextSearchConfiguration.xrc | 2 +- pgadmin/ui/dlgTextSearchDictionary.xrc | 2 +- pgadmin/ui/dlgTextSearchParser.xrc | 2 +- pgadmin/ui/dlgTextSearchTemplate.xrc | 2 +- pgadmin/ui/dlgTrigger.xrc | 2 +- pgadmin/ui/dlgType.xrc | 2 +- pgadmin/ui/dlgUser.xrc | 2 +- pgadmin/ui/dlgUserMapping.xrc | 2 +- pgadmin/ui/dlgView.xrc | 2 +- pgadmin/ui/xrcDialogs.cpp |68529 ++--- 41 files changed, 34304 insertions(+), 34306 deletions(-) Minor point but in pgadmin/ui/dlgAggregate.xrc, Slony doesn't have an uppercase 'S', but does everywhere else. Argh. Fixed, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
On Mon, 2011-06-27 at 09:21 +0200, Magnus Hagander wrote: Did this patch randomly update a couple of copyright years to 2011, or were those files that were somehow forgotten in a previous run? EIther way it looked unrelated so I figured I'd ask :-) (e.g .pgForeignServer.cpp and pgUserMapping.cpp) I had to replace all 2010 with 2011 from Luis's files. I found that other files needed the update too, and did it in the same run. Probably not a great idea. There also seem to be some unrealated changes in the visual studio project? Changing the default from debug win32 to release x64, was that intentional? (at least I think it did that - unfortunately VS appears to have reordered the file pretty bad so the diff is hard to read) I added all Luis's files to the visual studio project. Other things may have been changed by this. I have not much knowledge on this. All I did was making sure that one could compile pgAdmin with Visual Studio, but I didn't check every changes on this file. If I did something wrong, can you tell me what? I'll try to remember about the default compile option. Other than that - yay! Now I just have to pull this down and test it... :) -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
On Mon, Jun 27, 2011 at 09:29, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-06-27 at 09:21 +0200, Magnus Hagander wrote: Did this patch randomly update a couple of copyright years to 2011, or were those files that were somehow forgotten in a previous run? EIther way it looked unrelated so I figured I'd ask :-) (e.g .pgForeignServer.cpp and pgUserMapping.cpp) I had to replace all 2010 with 2011 from Luis's files. I found that other files needed the update too, and did it in the same run. Probably not a great idea. There also seem to be some unrealated changes in the visual studio project? Changing the default from debug win32 to release x64, was that intentional? (at least I think it did that - unfortunately VS appears to have reordered the file pretty bad so the diff is hard to read) I added all Luis's files to the visual studio project. Other things may have been changed by this. I have not much knowledge on this. All I did was making sure that one could compile pgAdmin with Visual Studio, but I didn't check every changes on this file. If I did something wrong, can you tell me what? I'll try to remember about the default compile option. I just noticed a bunch of chunks in the patch that changed Debug|Win32 to Release|x64. That just seems like an unrelated change... I'm not sure how that change happened, it oculd've been something Visual Studio did behind your back... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] configure stuff
On Sun, 2011-06-26 at 20:35 +0100, Dave Page wrote:
On Sat, Jun 25, 2011 at 7:26 PM, Guillaume Lelarge
guilla...@lelarge.info wrote:
Hi,
I received an email a few days ago (humm, weeks) about issues with
compiling pgAdmin.
== extract ==
The file pgadmin/db/keywords.c has this statement in it:
#include server/parser/kwlist.h
Now it comes that pg_config does spit out either
/usr/include/postgresql for the --includedir switch (for client things)
and /usr/include/postgresql/9.0/server for --includedir-server. Given
that both seems to work well for other stuff I'm unsure whether there is
a problem here and it should rather be #include parser/kwlist.h (or
the file be moved out of server context).
== end of extract ==
I took a quick look at it, and it seems we forgot something. If I'm not
wrong, we don't use the --includedir-server switch for our includes in
the configure script (actually, in the acinclude.m4 file). And it breaks
the compilation on Debian when a user uses the PostgreSQL package on
Debian or any other .deb linux distributions. We already do this for the
package include dir (--pkgincludedir), I don't see any reason why we
shouldn't do it for the server one.
Hmm, that would explain it - until now it's worked for some people and
not for others and we've assumed it was a broken -dev package. I
assume something like this does the trick:
diff --git a/acinclude.m4 b/acinclude.m4
index e379c62..f5eeaa4 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -548,8 +548,9 @@ AC_DEFUN([SETUP_POSTGRESQL],
AC_LANG_RESTORE
PG_INCLUDE=`${PG_CONFIG} --includedir`
+ PG_SVRINCLUDE=`${PG_CONFIG} --includedir-server`
PG_PKGINCLUDE=`${PG_CONFIG} --pkgincludedir`
- CPPFLAGS=$CPPFLAGS -I${PG_INCLUDE} -I${PG_PKGINCLUDE}
+ CPPFLAGS=$CPPFLAGS -I${PG_INCLUDE} -I${PG_SVRINCLUDE}
-I${PG_PKGINCLUDE}
PG_VERSION=`${PG_CONFIG} --version`
Yes, that's pretty much what I was thinking. There is also another file
that needs to be updated:
diff --git a/pgadmin/db/keywords.c b/pgadmin/db/keywords.c
index 9370a9e..0362a71 100644
--- a/pgadmin/db/keywords.c
+++ b/pgadmin/db/keywords.c
@@ -30,7 +30,7 @@
*/
#define PG_KEYWORD(a,b,c) {a,c},
const ScanKeyword ScanKeywords[] = {
-#include server/parser/kwlist.h
+#include parser/kwlist.h
};
const int NumScanKeywords = lengthof(ScanKeywords);
Can I commit both changes?
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
On Mon, 2011-06-27 at 09:31 +0200, Magnus Hagander wrote: On Mon, Jun 27, 2011 at 09:29, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-06-27 at 09:21 +0200, Magnus Hagander wrote: Did this patch randomly update a couple of copyright years to 2011, or were those files that were somehow forgotten in a previous run? EIther way it looked unrelated so I figured I'd ask :-) (e.g .pgForeignServer.cpp and pgUserMapping.cpp) I had to replace all 2010 with 2011 from Luis's files. I found that other files needed the update too, and did it in the same run. Probably not a great idea. There also seem to be some unrealated changes in the visual studio project? Changing the default from debug win32 to release x64, was that intentional? (at least I think it did that - unfortunately VS appears to have reordered the file pretty bad so the diff is hard to read) I added all Luis's files to the visual studio project. Other things may have been changed by this. I have not much knowledge on this. All I did was making sure that one could compile pgAdmin with Visual Studio, but I didn't check every changes on this file. If I did something wrong, can you tell me what? I'll try to remember about the default compile option. I just noticed a bunch of chunks in the patch that changed Debug|Win32 to Release|x64. That just seems like an unrelated change... I'm not sure how that change happened, it oculd've been something Visual Studio did behind your back... That's the mode I'm using when I debug pgAdmin on Windows. I don't think I can set it back to x64. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] configure stuff
Does this take of windows-build too? (Just question out of mind...)
On Mon, Jun 27, 2011 at 1:02 PM, Guillaume Lelarge
guilla...@lelarge.infowrote:
On Sun, 2011-06-26 at 20:35 +0100, Dave Page wrote:
On Sat, Jun 25, 2011 at 7:26 PM, Guillaume Lelarge
guilla...@lelarge.info wrote:
Hi,
I received an email a few days ago (humm, weeks) about issues with
compiling pgAdmin.
== extract ==
The file pgadmin/db/keywords.c has this statement in it:
#include server/parser/kwlist.h
Now it comes that pg_config does spit out either
/usr/include/postgresql for the --includedir switch (for client things)
and /usr/include/postgresql/9.0/server for --includedir-server. Given
that both seems to work well for other stuff I'm unsure whether there
is
a problem here and it should rather be #include parser/kwlist.h (or
the file be moved out of server context).
== end of extract ==
I took a quick look at it, and it seems we forgot something. If I'm not
wrong, we don't use the --includedir-server switch for our includes in
the configure script (actually, in the acinclude.m4 file). And it
breaks
the compilation on Debian when a user uses the PostgreSQL package on
Debian or any other .deb linux distributions. We already do this for
the
package include dir (--pkgincludedir), I don't see any reason why we
shouldn't do it for the server one.
Hmm, that would explain it - until now it's worked for some people and
not for others and we've assumed it was a broken -dev package. I
assume something like this does the trick:
diff --git a/acinclude.m4 b/acinclude.m4
index e379c62..f5eeaa4 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -548,8 +548,9 @@ AC_DEFUN([SETUP_POSTGRESQL],
AC_LANG_RESTORE
PG_INCLUDE=`${PG_CONFIG} --includedir`
+ PG_SVRINCLUDE=`${PG_CONFIG} --includedir-server`
PG_PKGINCLUDE=`${PG_CONFIG} --pkgincludedir`
- CPPFLAGS=$CPPFLAGS -I${PG_INCLUDE} -I${PG_PKGINCLUDE}
+ CPPFLAGS=$CPPFLAGS -I${PG_INCLUDE} -I${PG_SVRINCLUDE}
-I${PG_PKGINCLUDE}
PG_VERSION=`${PG_CONFIG} --version`
Yes, that's pretty much what I was thinking. There is also another file
that needs to be updated:
diff --git a/pgadmin/db/keywords.c b/pgadmin/db/keywords.c
index 9370a9e..0362a71 100644
--- a/pgadmin/db/keywords.c
+++ b/pgadmin/db/keywords.c
@@ -30,7 +30,7 @@
*/
#define PG_KEYWORD(a,b,c) {a,c},
const ScanKeyword ScanKeywords[] = {
-#include server/parser/kwlist.h
+#include parser/kwlist.h
};
const int NumScanKeywords = lengthof(ScanKeywords);
Can I commit both changes?
--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
--
--
Thanks Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.enterprisedb.com
*http://www.linkedin.com/in/asheshvashi*http://www.linkedin.com/in/asheshvashi
[pgadmin-hackers] pgAdmin III commit: Automatic merge using stringmerge script.
Automatic merge using stringmerge script. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=dbfd99a3732eebe9c397df63edd68e3aa4ea7bed Modified Files -- i18n/af_ZA/pgadmin3.po | 33 +- i18n/ar_SA/pgadmin3.po | 33 +- i18n/bg_BG/pgadmin3.po | 33 +- i18n/ca_ES/pgadmin3.po | 33 +- i18n/cs_CZ/pgadmin3.po | 33 +- i18n/da_DK/pgadmin3.po | 33 +- i18n/de_CH/pgadmin3.po | 33 +- i18n/de_DE/pgadmin3.po | 33 +- i18n/el_GR/pgadmin3.po | 33 +- i18n/es_ES/pgadmin3.po | 33 +- i18n/fa_IR/pgadmin3.po | 33 +- i18n/fi_FI/pgadmin3.po | 33 +- i18n/fr_FR/pgadmin3.po |22943 i18n/gl_ES/pgadmin3.po | 33 +- i18n/gu_IN/pgadmin3.po | 33 +- i18n/hi_IN/pgadmin3.po | 33 +- i18n/hr_HR/pgadmin3.po | 33 +- i18n/hu_HU/pgadmin3.po | 33 +- i18n/id_ID/pgadmin3.po | 33 +- i18n/is_IS/pgadmin3.po | 33 +- i18n/it_IT/pgadmin3.po | 33 +- i18n/ja_JP/pgadmin3.po | 33 +- i18n/ko_KR/pgadmin3.po | 33 +- i18n/lt_LT/pgadmin3.po | 33 +- i18n/lv_LV/pgadmin3.po | 33 +- i18n/mk_MK/pgadmin3.po | 33 +- i18n/nb_NO/pgadmin3.po | 33 +- i18n/nl_NL/pgadmin3.po | 33 +- i18n/pl_PL/pgadmin3.po | 33 +- i18n/pt_BR/pgadmin3.po | 33 +- i18n/pt_PT/pgadmin3.po | 33 +- i18n/ro_RO/pgadmin3.po | 33 +- i18n/ru_RU/pgadmin3.po | 33 +- i18n/sk_SK/pgadmin3.po | 33 +- i18n/sl_SI/pgadmin3.po | 33 +- i18n/sr_RS/pgadmin3.po | 33 +- i18n/sv_SE/pgadmin3.po | 33 +- i18n/te_IN/pgadmin3.po | 33 +- i18n/tl_PH/pgadmin3.po | 33 +- i18n/tr_TR/pgadmin3.po | 33 +- i18n/uk_UA/pgadmin3.po | 33 +- i18n/ur_PK/pgadmin3.po | 33 +- i18n/vi_VN/pgadmin3.po | 33 +- i18n/zh_CN/pgadmin3.po | 33 +- i18n/zh_TW/pgadmin3.po | 33 +- 45 files changed, 8351 insertions(+), 16044 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Update .pot file.
Update .pot file. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=0f143802e80286186985d1adf54dbc67d34f7714 Modified Files -- pgadmin3.pot | 33 +++-- 1 files changed, 15 insertions(+), 18 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] configure stuff
On Mon, 2011-06-27 at 13:04 +0530, Ashesh Vashi wrote: Does this take of windows-build too? (Just question out of mind...) Yes, I didn't think of that, but the changes on pgadmin/db/keywords.c may need some changes on the Visual Studio project. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] configure stuff
On Mon, Jun 27, 2011 at 8:32 AM, Guillaume Lelarge
guilla...@lelarge.info wrote:
diff --git a/pgadmin/db/keywords.c b/pgadmin/db/keywords.c
index 9370a9e..0362a71 100644
--- a/pgadmin/db/keywords.c
+++ b/pgadmin/db/keywords.c
@@ -30,7 +30,7 @@
*/
#define PG_KEYWORD(a,b,c) {a,c},
const ScanKeyword ScanKeywords[] = {
-#include server/parser/kwlist.h
+#include parser/kwlist.h
};
const int NumScanKeywords = lengthof(ScanKeywords);
Can I commit both changes?
Along with an update for windows, yes.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
On Mon, Jun 27, 2011 at 8:07 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Database Designer (milestone 1 of GSoC 2011) This patch adds the database designer. This new tool helps users to create their databases' schema. Lots of things still need to be implemented, but the raw features are in. What's wxhotdraw, and what licence is it under? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
On Mon, 2011-06-27 at 08:52 +0100, Dave Page wrote: On Mon, Jun 27, 2011 at 8:07 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Database Designer (milestone 1 of GSoC 2011) This patch adds the database designer. This new tool helps users to create their databases' schema. Lots of things still need to be implemented, but the raw features are in. What's wxhotdraw, and what licence is it under? It's Luis's work, part of this GSoC project. It's not an external one. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
On Mon, Jun 27, 2011 at 9:09 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-06-27 at 08:52 +0100, Dave Page wrote: On Mon, Jun 27, 2011 at 8:07 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Database Designer (milestone 1 of GSoC 2011) This patch adds the database designer. This new tool helps users to create their databases' schema. Lots of things still need to be implemented, but the raw features are in. What's wxhotdraw, and what licence is it under? It's Luis's work, part of this GSoC project. It's not an external one. Oh. In that case it shouldn't have a 'wx' prefix, if it's not part of wxWidgets. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Copy/Paste table(s) functions
Hi, I don't know who and why keeps source code for copy/paste of schema/table that I have sent. That works correctly at my company since April this year. Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Update russian translation.
Update russian translation. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b001a4d546a95cb303123b1718895e2f8c7d9357 Author: Timon timo...@gmail.com Modified Files -- i18n/ru_RU/pgadmin3.mo | Bin 329741 - 383268 bytes i18n/ru_RU/pgadmin3.po |24734 +++- 2 files changed, 16104 insertions(+), 8630 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Russian translation for 1.14
On Mon, 2011-06-27 at 20:06 +0600, Timon wrote: Hello. There is PO file for pgadmin 1.14. Tested with latest REL-1_14_0_PATCHES branch, but suits master branch well too. Big thank to Alexander LAW for his work. Yeah. I only commit it to the 1.14 branch. I'll commit it to the master branch when 1.14 final will be available. We have little Russian translation team and repository on google code http://code.google.com/p/pgadmin-locale-rus/ . And we have plans to translate pgadmin website in Russian. That would be great, thanks. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)
On Mon, 2011-06-27 at 09:12 +0100, Dave Page wrote: On Mon, Jun 27, 2011 at 9:09 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-06-27 at 08:52 +0100, Dave Page wrote: On Mon, Jun 27, 2011 at 8:07 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Database Designer (milestone 1 of GSoC 2011) This patch adds the database designer. This new tool helps users to create their databases' schema. Lots of things still need to be implemented, but the raw features are in. What's wxhotdraw, and what licence is it under? It's Luis's work, part of this GSoC project. It's not an external one. Oh. In that case it shouldn't have a 'wx' prefix, if it's not part of wxWidgets. Luis, any comments on that? -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Copy/Paste table(s) functions
On Mon, 2011-06-27 at 17:25 +0200, Vladimir Kokovic wrote: Hi, I don't know who and why keeps source code for copy/paste of schema/table that I have sent. Probably because I didn't have time when you sent your patch, and that you sent another mail in the same thread about a bug you found. The thread continued on how to solve the bug, which makes the patch completely invisible once the bug was fixed. We need to get back on it. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch
On Mon, 2011-06-27 at 20:11 +0200, Vladimir Kokovic wrote: Hi, Again, patch for Copy/Paste table(s) functions. I tried it, there are some improvements, but, still, here are my comments. I already asked this, but had no answer. I'll ask again :) Why should the schema be different? you should better ask the name of the new object. Moreover, if I try to paste on another database, we shouldn't care that the schema is the same. IMNSHO, you should get rid of this check. And if it happens that the table you copy has the same name than another table in the same schema, then ask the user to type the new name. If a user tries to copy a big table (I tried with a 138MB one), pgAdmin seems to freeze while doing the copy. A better UI, that shows that work is going on, would be great. When a user copies a schema, pgAdmin launches a query to get all tables. It would be better if you walk the treeview to get that information. I know I forget this many times, but it doesn't mean you shouldn't do it right :) Why is there two times the same code? lines 1020 to 1023, and lines 1025 to 1028. On the sequence code, why do you need it at all? -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Replication references
Certainly works for me, so something is wrong for you. Did you rebuild? Could be a dependency miss o rsomething.. //magnus On Sun, Jun 26, 2011 at 21:25, Jasmin Dizdarevic jasmin.dizdare...@gmail.com wrote: Hi, I thought it should be Slony Replication in the tree, but the latest master-build show's: Replication? Am I doing wrong, or is this wanted? 2011/6/26 Magnus Hagander mag...@hagander.net On Sun, Jun 26, 2011 at 19:52, Dave Page dp...@pgadmin.org wrote: On Sunday, June 26, 2011, Magnus Hagander mag...@hagander.net wrote: On Fri, Jun 24, 2011 at 19:10, Guillaume Lelarge guilla...@lelarge.info wrote: On Thu, 2011-06-23 at 11:41 +0200, Magnus Hagander wrote: On Thu, Jun 23, 2011 at 00:07, Guillaume Lelarge guilla...@lelarge.info wrote: On Wed, 2011-06-22 at 18:10 +0200, Magnus Hagander wrote: On Wed, Jun 22, 2011 at 18:03, Dave Page dp...@pgadmin.org wrote: On Wed, Jun 22, 2011 at 4:53 PM, Magnus Hagander mag...@hagander.net wrote: On Mon, Jun 20, 2011 at 23:45, Peter Geoghegan pe...@2ndquadrant.com wrote: On 20 June 2011 21:40, Magnus Hagander mag...@hagander.net wrote: Hi! I know we've had some discussions around what to do with the Slony support.. But it's there now, and IIRC the deal was we keep it. That was the deal. FWIW, I consider our Slony support to be less than useless, in that it is basically a GUI analogue to writing a long Slonik script full of apparently redundant entries. I would, however, suggest that we rename it to actually be slony replication rather than replication. Or Use slony rather than Use replication. Calling it replication without qualifying it causes confusion to many users (came across it with a client just today, and it's not the first time). I realize we're fairly close to release - is this doable for 1.14, or will that fsck things up for translators? +1 It isn't that hard to translate a few strings into all supported languages. If a translator isn't available to translate those few strings (and they'd have to not be answering any e-mail for that to be the case, and it will take them less than 5 minutes), that's likely to be in a language that isn't so widely spoken - it certainly won't be French or German. I'd be willing to live with a poor machine translation for a little while for those languages. If someone complains, the complaint is likely to be all we need to fix the problem ourselves. So, something like this. I went with calling the field inthe dialogs Use Slony rather than Use Slony replication, simply because the second option is very long - much much longer than anything else there, leading to a lot of wasted space. Comments? It should be Slony Replication for the menu and the collection factory name, not Slony replication. Otherwise it seems OK. Agreed. Actually I thought I had fixed that already :D I would like to hear from Guillaume before breaking the translations though. Yeah, I was planning to wait for his comment before committing anything. No problem with me. We have no updates to the translation yet, so that's not an issue. Ok, applied. I wasn't planning to - do we really want to change the name of a node in a minor release? No, but weren't you trying to get it into 1.14? Oh. Crap. Yes. I need to pay more attention :O -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
