Re: [pgadmin-hackers] Qt runtime issue on python 3 + patch

[Surinder Kumar]

On Wed, Jun 15, 2016 at 10:46 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> Hi Surinder,
>
> On Sat, Jun 11, 2016 at 11:08 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Sat, Jun 11, 2016 at 2:17 PM, Asser Schrøder Femø
>>  wrote:
>> > Hello pgadmin hackers,
>> >
>> > I checked out the newly released beta and wanted to see how easy it
>> would be
>> > to package for Arch Linux, but ran into this error with the Qt runtime:
>> >
>> > Python path:
>> >
>> "/home/asser/.virtualenvs/pgadmin4-python34/lib/python3.4/site-packages;/home/asser/src/pgadmin4-beta1/web"
>> > Webapp path:  "/home/asser/projects/pgadmin4/web/pgAdmin4.py"
>> > Traceback (most recent call last):
>> >   File "/home/asser/projects/pgadmin4/web/pgAdmin4.py", line 23, in
>> 
>> > import config
>> >   File "/home/asser/projects/pgadmin4/web/config.py", line 255, in
>> 
>> > from config_local import *
>> >   File "", line 2237, in _find_and_load
>> >   File "", line , in
>> > _find_and_load_unlocked
>> >   File "", line 2164, in _find_spec
>> >   File "", line 1940, in find_spec
>> >   File "", line 1914, in _get_spec
>> >   File "", line 2049, in find_spec
>> >   File "", line 53, in _path_join
>> >   File "", line 53, in 
>> > TypeError: 'str' does not support the buffer interface
>> > "Failed to launch the application server, server thread exiting."
>> >
>> > According to Stackoverflow, exchanging PyBytes_FromString with
>> > PyUnicode_DecodeFSDefault when building the pythonpath makes it work
>> again
>> > (see attached diff). I don't know why though, perhaps somebody will be
>> able
>> > to enlighten me :-)
>> >
>> > Same issue and fix on Python 3.4 and 3.5 on Arch Linux. I don't know if
>> the
>> > patch has any complications on other platforms.
>>
>> If I'm reading the docs right, PyUnicode_DecodeFSDefault was added in
>> Python 3.3, so I've tweaked the patch a little (see attached). I know
>> the current code has worked on some 3.x versions but I don't know
>> which exactly as I don't currently have them here, but I'll bet it was
>> 3.2 or below. Ashesh - can you have the most appropriate person from
>> the team check this works on 3.0 through 3.5 please?
>>
> Can you please take a look at it?
>
Sure.

>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> > Thanks for building the successor to pgAdmin3! It already looks good
>> and I'm
>> > looking forward to further refinement. Hopefully I'll be able to
>> contribute
>> > a bit along the way.
>>
>> Cool - many thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

Re: [pgadmin-hackers] Qt runtime issue on python 3 + patch

[Ashesh Vashi]

Hi Surinder,

On Sat, Jun 11, 2016 at 11:08 PM, Dave Page  wrote:

> Hi
>
> On Sat, Jun 11, 2016 at 2:17 PM, Asser Schrøder Femø
>  wrote:
> > Hello pgadmin hackers,
> >
> > I checked out the newly released beta and wanted to see how easy it
> would be
> > to package for Arch Linux, but ran into this error with the Qt runtime:
> >
> > Python path:
> >
> "/home/asser/.virtualenvs/pgadmin4-python34/lib/python3.4/site-packages;/home/asser/src/pgadmin4-beta1/web"
> > Webapp path:  "/home/asser/projects/pgadmin4/web/pgAdmin4.py"
> > Traceback (most recent call last):
> >   File "/home/asser/projects/pgadmin4/web/pgAdmin4.py", line 23, in
> 
> > import config
> >   File "/home/asser/projects/pgadmin4/web/config.py", line 255, in
> 
> > from config_local import *
> >   File "", line 2237, in _find_and_load
> >   File "", line , in
> > _find_and_load_unlocked
> >   File "", line 2164, in _find_spec
> >   File "", line 1940, in find_spec
> >   File "", line 1914, in _get_spec
> >   File "", line 2049, in find_spec
> >   File "", line 53, in _path_join
> >   File "", line 53, in 
> > TypeError: 'str' does not support the buffer interface
> > "Failed to launch the application server, server thread exiting."
> >
> > According to Stackoverflow, exchanging PyBytes_FromString with
> > PyUnicode_DecodeFSDefault when building the pythonpath makes it work
> again
> > (see attached diff). I don't know why though, perhaps somebody will be
> able
> > to enlighten me :-)
> >
> > Same issue and fix on Python 3.4 and 3.5 on Arch Linux. I don't know if
> the
> > patch has any complications on other platforms.
>
> If I'm reading the docs right, PyUnicode_DecodeFSDefault was added in
> Python 3.3, so I've tweaked the patch a little (see attached). I know
> the current code has worked on some 3.x versions but I don't know
> which exactly as I don't currently have them here, but I'll bet it was
> 3.2 or below. Ashesh - can you have the most appropriate person from
> the team check this works on 3.0 through 3.5 please?
>
Can you please take a look at it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> > Thanks for building the successor to pgAdmin3! It already looks good and
> I'm
> > looking forward to further refinement. Hopefully I'll be able to
> contribute
> > a bit along the way.
>
> Cool - many thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

Re: [pgadmin-hackers] pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

[Surinder Kumar]

OK, I will fix it.

On Wed, Jun 15, 2016 at 10:41 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Tue, Jun 14, 2016 at 8:21 PM, Dave Page  wrote:
>
>> Fix query tool horizontal scrolling of results. Fixes #1362
>>
>> The backgrid-sizeable's css property 'overflow: hidden' was overriding
>> backgrid table css property and It was reproducible only in runtime.
>> Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>>
>> http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e881695050b8ba4cf99b365ff2c0f4e02d03ced6
>> Author: Surinder Kumar 
>>
>> Modified Files
>> --
>> web/pgadmin/static/css/backgrid/backgrid-sizeable-columns.css | 1 -
>>
> This is not correct place to handle the issue.
>
> We should not change third party CSS.
> We should handle this issue in override.css.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>
>> web/pgadmin/static/js/backform.pgadmin.js | 5 +
>> 2 files changed, 1 insertion(+), 5 deletions(-)
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>

Re: [pgadmin-hackers] pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

[Ashesh Vashi]

On Tue, Jun 14, 2016 at 8:21 PM, Dave Page  wrote:

> Fix query tool horizontal scrolling of results. Fixes #1362
>
> The backgrid-sizeable's css property 'overflow: hidden' was overriding
> backgrid table css property and It was reproducible only in runtime.
> Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css
>
> Branch
> --
> master
>
> Details
> ---
>
> http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e881695050b8ba4cf99b365ff2c0f4e02d03ced6
> Author: Surinder Kumar 
>
> Modified Files
> --
> web/pgadmin/static/css/backgrid/backgrid-sizeable-columns.css | 1 -
>
This is not correct place to handle the issue.

We should not change third party CSS.
We should handle this issue in override.css.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*



> web/pgadmin/static/js/backform.pgadmin.js | 5 +
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Re: [pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

[Dave Page]

On Tue, Jun 14, 2016 at 5:28 PM, Dave Page  wrote:
> Thanks - committed with some minor changes:
>
> - Move the password field under the user name.
>
> - Remove the password requirement. The user might be using "trust" auth.
>
> - Adjust the vertical positioning of the checkbox.

Hmm, this is actually broken:

1) I've left the password check in the Python code.

2) It seems like it saves the server info on the first connection
attempt. That means that if the connection fails, but the password is
not the issue (mis-typed address or username perhaps), correcting that
info doesn't allow the connection to proceed.

Because of 2, I haven't fixed 1 (you'll probably need to move it
around anyway). Essentially, we need to support password-less
connections, and if the connection fails, the user should be able to
immediately try again having changed any of the connection options.

Please take a look - and while you're in that code, please take a look
at #1363. It's probably a very simple fix.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

[Dave Page]

Thanks - committed with some minor changes:

- Move the password field under the user name.

- Remove the password requirement. The user might be using "trust" auth.

- Adjust the vertical positioning of the checkbox.

On Tue, Jun 14, 2016 at 2:18 PM, Harshal Dhumal
 wrote:
> Hi,
>
>
> PFA patch for issue RM 1313.
>
> Changes: Added connect now option in server create dialog.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Added connect now option in server create dialog. Fix

[Dave Page]

Added connect now option in server create dialog. Fixes #1313

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b95d6ac75449a1c2f9877a48bc4003ad1ac5dfc
Author: Harshal Dhumal 

Modified Files
--
.../browser/server_groups/servers/__init__.py  | 44 --
.../servers/templates/servers/servers.js   | 14 ++-
web/pgadmin/static/css/overrides.css   |  5 +++
3 files changed, 58 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1352 - Problem displaying intervals and timestamps with pgAdmin 4

[Dave Page]

Thanks, patch applied.

On Tue, Jun 14, 2016 at 8:55 AM, Surinder Kumar
 wrote:
> Hi,
>
> Please find the patch with issues fixed:
>
> 1) No handling for INTERVAL type datetime.
> For example: executing query
> SELECT INTERVAL '15 minutes';
> throws json serialization error, because it returns time in timedelta format
> which is not handled.
>
> Added support to handle timedelta datetime format in DataTypeJSONEncoder
> class
>
> 2) When we try to get BC dates from database raises ValueError: year is out
> of range
> For eg:
> SELECT TIMESTAMP '0044-03-15 10:00:00 BC',
> It is because pyscopg2 doesn't handle BC datetime format.
>
> So we have defined our method which type cast the datetime value to string
> in pyscopg2 overriding default behaviour.
>
> Reference:
> http://initd.org/psycopg/docs/advanced.html#type-casting-from-sql-to-python
> https://github.com/dbcli/pgcli/blob/ccf3693be62dd8a79ced19ed9d69f0708d2b3d6f/pgcli/pgexecute.py
>
> Issue left:
> Pyscopg2 not handling representation of BC dates. It is currently
> representing time in following query
> SELECT TIMESTAMPTZ '2016-03-15 10:00:00+02 AD';
> as
> 2016-03-15T00:00:00Z
> which is wrong.
> I will send patch for it when gets fixed.
>
> Please review.
>
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Resolve problem displaying intervals and timestamps.

[Dave Page]

Resolve problem displaying intervals and timestamps. Fixes #1352

1) No handling for INTERVAL type datetime.
For example: executing query
SELECT INTERVAL '15 minutes';
throws json serialization error, because it returns time in timedelta format 
which is not handled.

Added support to handle timedelta datetime format in DataTypeJSONEncoder class

2) When we try to get BC dates from database raises ValueError: year is out of 
range
For eg:
SELECT TIMESTAMP '0044-03-15 10:00:00 BC',
It is because pyscopg2 doesn't handle BC datetime format.

So we have defined our method which type cast the datetime value to string in 
pyscopg2 overriding default behaviour.

Reference:
http://initd.org/psycopg/docs/advanced.html#type-casting-from-sql-to-python
https://github.com/dbcli/pgcli/blob/ccf3693be62dd8a79ced19ed9d69f0708d2b3d6f/pgcli/pgexecute.py

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5dbbd8e638a6c4c4d1df4203cd70a6bd92350ab6
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/utils/ajax.py |  2 ++
web/pgadmin/utils/driver/psycopg2/__init__.py | 20 
2 files changed, 22 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To have validation messages on status panel only (pgAdmin4)

[Dave Page]

This seems to have been committed inadvertently as part of another patch.

Thanks though :-)

On Tue, Jun 14, 2016 at 8:53 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue mentioned in RM#1281, We have removed error
> messages from standard Backform control rather display validation error
> messages only on status panel.
>
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1362 - Query Tool: Can't View All Columns

[Dave Page]

Thanks, applied.

On Tue, Jun 14, 2016 at 11:50 AM, Surinder Kumar
 wrote:
> Hi,
>
> Please find attached patch for RM#1362:
> The backgrid-sizeable's css property 'overflow: hidden' was overriding
> backgrid table css property and It was reproducible only in runtime.
> Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css
>
> Thanks Neel & Akshay for sorting it out.
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

[Dave Page]

Fix query tool horizontal scrolling of results. Fixes #1362

The backgrid-sizeable's css property 'overflow: hidden' was overriding backgrid 
table css property and It was reproducible only in runtime.
Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e881695050b8ba4cf99b365ff2c0f4e02d03ced6
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/static/css/backgrid/backgrid-sizeable-columns.css | 1 -
web/pgadmin/static/js/backform.pgadmin.js | 5 +
2 files changed, 1 insertion(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Fix for issue RM1348 [pgadmin4]

[Dave Page]

Thanks, applied.

On Mon, Jun 13, 2016 at 7:37 PM, Harshal Dhumal
 wrote:
> Hi,
>
> PFA patch for issue RM1348.
>
> Issue fixed: Not to show multiple 'Reset Layout' options under file menu.
> Also restructured code related to reset layout functionality.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Avoid showing multiple 'Reset Layout' options under f

[Dave Page]

Avoid showing multiple 'Reset Layout' options under file menu. Fixes #1348

Also restructured code related to reset layout functionality.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b0b21fd46c08ce01cf3859aaa8908b5f7f73d3ad
Author: Harshal Dhumal 

Modified Files
--
.../browser/templates/browser/js/browser.js| 65 -
web/pgadmin/settings/__init__.py   | 61 +++-
.../settings/templates/settings/settings.js| 66 ++
3 files changed, 110 insertions(+), 82 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)

[Dave Page]

Hi

On Mon, Jun 13, 2016 at 9:38 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to add "Move objects..” functionality in tablespace node.
> (RM#1286)
>
> Additionally I have removed pre_9.1 sql's & align SQL line indentation as
> well.

Committed with some minor wording tweaks. Please take care of the following:

- Add an SQL tab to the dialogue, showing the SQL that will be
executed (like a properties dialogue).

- Make it non-modal.

- Add Help buttons, and let Susan know what page you need her to write.

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add "Move objects..” functionality to tablespace no

[Dave Page]

Add "Move objects..” functionality to tablespace node. Fixes #1286

Additionally I have removed pre_9.1 sql's & align SQL line indentation as well.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62c136993870e987df21ee14b7cffc9db0f07751
Author: Murtuza Zabuawala 

Modified Files
--
.../server_groups/servers/tablespaces/__init__.py  |  46 -
.../templates/tablespaces/js/tablespaces.js| 185 +
.../tablespaces/sql/9.1_plus/move_objects.sql  |  21 +++
.../tablespaces/sql/9.2_plus/move_objects.sql  |  21 +++
.../templates/tablespaces/sql/pre_9.1/acl.sql  |  28 
.../templates/tablespaces/sql/pre_9.1/alter.sql|  41 -
.../templates/tablespaces/sql/pre_9.1/create.sql   |   9 -
.../templates/tablespaces/sql/pre_9.1/delete.sql   |   2 -
.../tablespaces/sql/pre_9.1/dependents.sql |  20 ---
.../templates/tablespaces/sql/pre_9.1/nodes.sql|   8 -
.../tablespaces/sql/pre_9.1/properties.sql |  12 --
.../templates/tablespaces/sql/pre_9.1/stats.sql|   6 -
.../templates/tablespaces/sql/pre_9.1/update.sql   |  58 ---
.../tablespaces/sql/pre_9.1/variables.sql  |   4 -
14 files changed, 267 insertions(+), 194 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] integration of minimap in graphical explain feature

[Sanket Mehta]

Hi,

PFA the patch for integration of minimap in graphical explain.
It will show minimap on left top corner of graphical explain.


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/misc/__init__.py b/web/pgadmin/misc/__init__.py
index 2081822..6b307e3 100644
--- a/web/pgadmin/misc/__init__.py
+++ b/web/pgadmin/misc/__init__.py
@@ -33,6 +33,14 @@ class MiscModule(PgAdminModule):
 'snap.svg' if config.DEBUG else 'snap.svg-min'
 )),
 'preloaded': False
+}, {
+'name': 'imageviewer',
+'path': url_for(
+'misc.static', filename='explain/js/' + (
+'imageviewer.pgadmin' if config.DEBUG else 'imageviewer-min'
+)),
+'exports': 'ImageViewer',
+'preloaded': False
 }]
 
 def get_own_stylesheets(self):
@@ -40,6 +48,9 @@ class MiscModule(PgAdminModule):
 stylesheets.append(
 url_for('misc.static', filename='explain/css/explain.css')
 )
+stylesheets.append(
+url_for('misc.static', filename='explain/css/imageviewer.css')
+)
 return stylesheets
 
 
diff --git a/web/pgadmin/misc/static/explain/css/imageviewer.css b/web/pgadmin/misc/static/explain/css/imageviewer.css
new file mode 100644
index 000..8fc6c0f
--- /dev/null
+++ b/web/pgadmin/misc/static/explain/css/imageviewer.css
@@ -0,0 +1,226 @@
+/*
+ImageViewer v 1.1.0
+Author: Sudhanshu Yadav
+Copyright (c) 2015 to Sudhanshu Yadav - ignitersworld.com , released under the MIT license.
+Demo on: http://ignitersworld.com/lab/imageViewer.html
+*/
+
+/* image viewer css */
+#iv-container {
+  position: fixed;
+  background: #0d0d0d;
+  width: 100%;
+  height: 100%;
+  top: 0;
+  left: 0;
+  display: none;
+  z-index: 1000;
+}
+
+.iv-container {
+  overflow: auto;
+}
+
+.iv-close {
+  width: 32px;
+  height: 32px;
+  position: absolute;
+  right: 20px;
+  top: 20px;
+  cursor: pointer;
+  text-align: center;
+  overflow: hidden;
+  text-shadow: 0px 0px 3px #6d6d6d;
+  -webkit-transition: all ease 200ms;
+  -moz-transition: all ease 200ms;
+  -o-transition: all ease 200ms;
+  transition: all ease 200ms;
+}
+.iv-close:after,
+.iv-close:before {
+  content: "";
+  height: 4px;
+  width: 32px;
+  background: #FFF;
+  position: absolute;
+  left: 0;
+  top: 50%;
+  margin-top: -2px;
+}
+.iv-close:before {
+  -webkit-transform: rotate(45deg);
+  -moz-transform: rotate(45deg);
+  -ms-transform: rotate(45deg);
+  -o-transform: rotate(45deg);
+  transform: rotate(45deg);
+}
+.iv-close:after {
+  -webkit-transform: rotate(-45deg);
+  -moz-transform: rotate(-45deg);
+  -ms-transform: rotate(-45deg);
+  -o-transform: rotate(-45deg);
+  transform: rotate(-45deg);
+}
+.iv-close:hover {
+  -webkit-transform: rotate(90deg);
+  -moz-transform: rotate(90deg);
+  -ms-transform: rotate(90deg);
+  -o-transform: rotate(90deg);
+  transform: rotate(90deg);
+}
+/* snap view css */
+.iv-snap-view {
+  width: 150px;
+  height: 150px;
+  position: absolute;
+  top: 20px;
+  left: 20px;
+  border: 1px solid #666;
+  background: black;
+  z-index: 100;
+  -webkit-box-sizing: content-box;
+  -moz-box-sizing: content-box;
+  box-sizing: content-box;
+  -webkit-transition: all ease 400ms;
+  -moz-transition: all ease 400ms;
+  -o-transition: all ease 400ms;
+  transition: all ease 400ms;
+  opacity: 0;
+}
+
+.iv-snap-image-wrap {
+  display: inline-block;
+  position: absolute;
+  max-width: 150px;
+  max-height: 150px;
+  top: 50%;
+  left: 50%;
+  -webkit-transform: translate(-50%, -50%);
+  -moz-transform: translate(-50%, -50%);
+  -ms-transform: translate(-50%, -50%);
+  -o-transform: translate(-50%, -50%);
+  transform: translate(-50%, -50%);
+  overflow: hidden;
+}
+
+.iv-snap-image {
+  position: relative;
+}
+
+.iv-snap-handle {
+  position: absolute;
+  border: 1px solid #ccc;
+  -webkit-transform: translate3d(0, 0, 0);
+  -moz-transform: translate3d(0, 0, 0);
+  -ms-transform: translate3d(0, 0, 0);
+  -o-transform: translate3d(0, 0, 0);
+  transform: translate3d(0, 0, 0);
+  -webkit-box-shadow: 0px 0px 0px 200px rgba(0, 0, 0, 0.5);
+  -moz-box-shadow: 0px 0px 0px 200px rgba(0, 0, 0, 0.5);
+  box-shadow: 0px 0px 0px 200px rgba(0, 0, 0, 0.5);
+}
+
+/*** zoom slider ***/
+.iv-zoom-slider {
+  width: 100%;
+  -webkit-box-sizing: content-box;
+  -moz-box-sizing: content-box;
+  box-sizing: content-box;
+  border: 1px solid #666;
+  border-top: 0;
+  background: rgba(204, 204, 204, 0.1);
+  height: 15px;
+  position: absolute;
+  top: 150px;
+  left: -1px;
+}
+
+.iv-zoom-handle {
+  width: 20px;
+  height: 15px;
+  background: #ccc;
+  position: absolute;
+}
+
+/ snap view css end */
+.iv-image-view {
+  position: absolute;
+  height: 100%;
+  width: 100%;
+}
+
+.iv-image-wrap {
+  display: inline-block;
+}
+
+.iv-image-wrap:active {
+  cursor: move;
+}
+
+.iv-large-image {
+  max-width: 100%;
+  

[pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

[Harshal Dhumal]

Hi,


PFA patch for issue RM 1313.

Changes: Added connect now option in server create dialog.


-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py
index 6f3453b..8f4a0dd 100644
--- a/web/pgadmin/browser/server_groups/servers/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/__init__.py
@@ -576,14 +576,50 @@ class ServerNode(PGChildNodeView):
 db.session.add(server)
 db.session.commit()
 
+connected = False
+icon = "icon-server-not-connected"
+user = None
+
+if 'connect_now' in data and data['connect_now']:
+if 'password' not in data or data["password"] == '':
+db.session.delete(server)
+db.session.commit()
+raise Exception("No password provided.")
+
+password = data['password']
+password = encrypt(password, current_user.password)
+
+from pgadmin.utils.driver import get_driver
+manager = get_driver(PG_DEFAULT_DRIVER).connection_manager(server.id)
+conn = manager.connection()
+
+status, errmsg = conn.connect(
+password=password,
+server_types=ServerType.types()
+)
+
+if not status:
+db.session.delete(server)
+db.session.commit()
+return make_json_response(
+status=401,
+success=0,
+errormsg=gettext("Unable to connect to server.")
+)
+else:
+user = manager.user_info
+connected = True
+icon = "icon-pg"
+
 return jsonify(
 node=self.blueprint.generate_browser_node(
-"%d" % (server.id), server.servergroup_id,
+"%d" % server.id, server.servergroup_id,
 server.name,
-"icon-server-not-connected",
+icon,
 True,
 self.node_type,
-connected=False,
+user=user,
+connected=connected,
 server_type='pg'  # Default server type
 )
 )
@@ -593,7 +629,7 @@ class ServerNode(PGChildNodeView):
 return make_json_response(
 status=410,
 success=0,
-errormsg=e.message
+errormsg=str(e)
 )
 
 def sql(self, gid, sid):
diff --git a/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js b/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
index d1c1cd3..8c0d01f 100644
--- a/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
+++ b/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
@@ -586,7 +586,9 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
   port: 5432,
   db: 'postgres',
   username: '{{ username }}',
-  role: null
+  role: null,
+  connect_now: true,
+  password: undefined
 },
 // Default values!
 initialize: function(attrs, args) {
@@ -623,6 +625,15 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
   id: 'version', label:'{{ _('Version') }}', type: 'text', group: null,
   mode: ['properties'], visible: 'isConnected'
 },{
+  id: 'connect_now', controlLabel:'{{ _('Connect now?') }}', type: 'checkbox',
+  group: null, mode: ['create']
+},{
+  id: 'password', label:'{{ _('Password') }}', type: 'password',
+  group: null, control: 'input', mode: ['create'], deps: ['connect_now'],
+  visible: function(m) {
+return m.get('connect_now') && m.isNew();
+  }
+},{
   id: 'comment', label:'{{ _('Comments') }}', type: 'multiline', group: null,
   mode: ['properties', 'edit', 'create']
 },{
@@ -676,6 +687,15 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
 self.errorModel.unset('id');
   }
   check_for_empty('name', '{{ _('Name must be specified.') }}');
+
+  if(self.get('connect_now')) {
+check_for_empty(
+  'password', '{{ _('Password must be specified.') }}'
+);
+  } else {
+self.errorModel.unset('password');
+  }
+
   check_for_empty(
 'host', '{{ _('Hostname or address must be specified.') }}'
   );
diff --git a/web/pgadmin/static/css/overrides.css 

Re: [pgadmin-hackers] Fix for RM1318 [pgadmin4]

[Dave Page]

Thanks, applied.

On Mon, Jun 13, 2016 at 7:20 PM, Harshal Dhumal
 wrote:
> Hi,
>
> PFA patch for issue RM1318 with remaining bug fixes.
>
>
> On Mon, Jun 13, 2016 at 8:49 PM, Dave Page  wrote:
>>
>> On Mon, Jun 13, 2016 at 7:25 AM, Harshal Dhumal
>>  wrote:
>> > Hi,
>> >
>> > PFA attached patch for issue RM1318.
>> >
>> >
>> > Issue fixed: Added help buttons on backup, restore, maintenance, user
>> > management dialogs.
>>
>> Thanks - I've committed this as-is, however the following issues
>> should also be fixed:
>>
>> - The help for the User Manager dialogue cannot be used because the
>> dialogue is modal.
>
>
> Changed user dialog to non modal from modal dialog.
>
>>
>>
>> - There's no help button on the Preferences dialogue. It should also
>> be made non-modal so the user can actually use the help once it's
>> displayed.
>
> Added missing help button and also changed dialog to non modal.
>
>
>>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Preferences and user management help button fixes. Fi

[Dave Page]

Preferences and user management help button fixes. Fixes #1318

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93706ee40b6fe260c1dca36033faffd93a3c176d
Author: Harshal Dhumal 

Modified Files
--
.../templates/preferences/preferences.js   | 29 ++
.../user_management/js/user_management.js  |  2 +-
2 files changed, 20 insertions(+), 11 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fixed the issue in server node (pgAdmin4)

[Dave Page]

Thanks, applied.

On Mon, Jun 13, 2016 at 11:29 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA minor patch to fix the issue for RM#1144.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix SSL mode selection. Fixes #1144

[Dave Page]

Fix SSL mode selection. Fixes #1144

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe1c86cbbe74ff9d4742568b816365e89373e78c
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/browser/server_groups/servers/__init__.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Tell the user where the app server is running.

[Dave Page]

Tell the user where the app server is running.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0f12defd2043684128ffa28f982031e2f449da30

Modified Files
--
web/pgAdmin4.py | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1362 - Query Tool: Can't View All Columns

[Surinder Kumar]

Hi,

Please find attached patch for *RM#1362*:
The *backgrid-sizeable's* css property '*overflow: hidden*' was overriding
backgrid table css property and It was reproducible only in runtime.
Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css

Thanks Neel & Akshay for sorting it out.

Please review.

Thanks,
Surinder Kumar


RM#1362.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgAdmin 4 docs

[Dave Page]

Hi

On Tue, Jun 14, 2016 at 10:16 AM, Susan Douglas
 wrote:
> Hi All,
>
> I think this patch should complete the first pass through the project - 
> please let me know if you find dialogs that are missing documentation, and 
> share any feedback on the docs.

Thanks, applied - with some EDBisms removed from the debugger page.

I think the following issues/thoughts need to be looked at:

- user_management_dialog is missing. This functionality is only
available in server mode, and appears under the top-right icon next to
the user avatar.

- Self-service password resets should be documented. Again, this is
only available in server mode, from the login screen.

- Re-consider the titles - "The XXX dialog" (time 40 or so!) seems
clumsy. What do you think?

Thanks, Dave.

-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: More doc updates.

[Dave Page]

More doc updates.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d87a6a15ac93a713c716017477d82a047a84cc0f
Author: Susan Douglas 

Modified Files
--
docs/en_US/debugger.rst| 102 +++--
docs/en_US/images/debug_error_message.png  | Bin 0 -> 39810 bytes
docs/en_US/images/debug_ic_step_in.png | Bin 0 -> 139266 bytes
docs/en_US/images/debug_main.png   | Bin 0 -> 81469 bytes
docs/en_US/images/debug_params.png | Bin 0 -> 33593 bytes
docs/en_US/images/debug_set_breakpoint.png | Bin 0 -> 27621 bytes
docs/en_US/images/debug_stack.png  | Bin 0 -> 20776 bytes
docs/en_US/images/debug_step_in.png| Bin 0 -> 146841 bytes
docs/en_US/images/debug_toolbar.png| Bin 0 -> 3306 bytes
docs/en_US/images/debug_variables.png  | Bin 0 -> 41657 bytes
10 files changed, 98 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgadmin4 slow with large tables compared to pgadmin3

[Dave Page]

Hi

2016-06-14 8:17 GMT+01:00 Akshay Joshi :
> Hi  Dave
>
> 2016-06-13 21:47 GMT+05:30 Dave Page :
>>
>> On Mon, Jun 13, 2016 at 5:01 PM, Colin Beckingham 
>> wrote:
>> > I have the latest fully patched pgadmin4. Runs fine on openSUSE Leap
>> > 42.1
>> > using browser Firefox.
>> > When I load a full large table such as the words table (140K records)
>> > from
>> > wordnet, pgadmin3 takes about 2 seconds to display.
>> > On pgadmin4 I wait about 30+ seconds and click through about 5 reminders
>> > that "a script has stopped working, do you want to continue."
>> > Eventually the table loads so this is not a bug report, more a question
>> > about how to streamline access to large tables. I am quite aware that it
>> > would run much faster by running a query with criteria asking for a
>> > subset
>> > of the table records, but just wondering if this is to be standard in
>> > pgadmin4. I can also disable the warnings, but this will prevent me from
>> > seeing issues with other scripts.
>>
>> Hmm, I tested this with a simple query, and got the crash below :-o.
>> Akshay, can you investigate please?
>
>
>I have tested the same query (SELECT * FROM pg_description a,
> pg_description b ) and it is crash with below error message:
>
> RuntimeError: maximum recursion depth exceeded
> Fatal Python error: Cannot recover from stack overflow.

Yeah, same as me.

>According to our logic we poll psycopg2 connection and check the status
> if it is busy(read/write) then call the same function recursively. So for
> the long running query Python throws an error. I have googled to increase
> the limit and found one function "sys.setrecursionlimit()"  but we don't
> know what limit to set and also it is not recommended to increase the limit.

Calling anything recursively like that is doomed to failure.

>Then I have tried it with blocking call and I faced below error message:
> Error Message:out of memory for query result
>
>We need to change our logic of recursion, and for out of memory issue
> I'll have to figure out the solution.

Agreed. Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

[Murtuza Zabuawala]

Hi Dave,

I copied pgAdmin3 behaviour, I’ll implement it in pgAdmin4 :)

Thanks,
Murtuza

> On 13-Jun-2016, at 5:51 pm, Dave Page  wrote:
> 
> On Mon, Jun 13, 2016 at 12:29 PM, Murtuza Zabuawala
>  wrote:
>> The strange effects that leads to.
>> 
>> 
>>> On 13-Jun-2016, at 4:55 pm, Dave Page  wrote:
>>> 
>>> Hi
>>> 
>>> On Mon, Jun 13, 2016 at 12:18 PM, Murtuza Zabuawala
>>>  wrote:
 Hi Dave,
 
 I tried with fresh install of 9.4 version but still not able to re-produce 
 the issue, I also tried switching python version 2.7/3.5 but still no luck.
 I also checked with Neel & Surinder on their system but still not able to 
 re-produce the issue.
>>> 
>>> What can't you reproduce - the queries returning zero rows, or the
>>> strange effects that leads to?
> 
> Hmm, neither can I now. I wonder if something didn't refresh correctly...
> 
> I do notice that we don't return stats for the Sequences, Trigger
> functions or Functions nodes though.
> 
> 
> -- 
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
> 
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1352 - Problem displaying intervals and timestamps with pgAdmin 4

[Surinder Kumar]

Hi,

Please find the patch with issues fixed:

1) No handling for INTERVAL type datetime.
For example: executing query
*SELECT INTERVAL '15 minutes';*
throws json serialization error, because it returns time in timedelta
format which is not handled.

Added support to handle *timedelta* datetime format in *DataTypeJSONEncoder*
class

2) When we try to get BC dates from database raises ValueError: year is out
of range
For eg:
*SELECT TIMESTAMP '0044-03-15 10:00:00 BC',*
It is because pyscopg2 doesn't handle BC datetime format.

So we have defined our method which type cast the datetime value to string
in pyscopg2 overriding default behaviour.

*Reference:*
http://initd.org/psycopg/docs/advanced.html#type-casting-from-sql-to-python
https://github.com/dbcli/pgcli/blob/ccf3693be62dd8a79ced19ed9d69f0708d2b3d6f/pgcli/pgexecute.py

*Issue left:*
Pyscopg2 not handling representation of BC dates. It is currently
representing time in following query
*SELECT TIMESTAMPTZ '2016-03-15 10:00:00+02 AD';*
as
2016-03-15T00:00:00Z
which is wrong.
I will send patch for it when gets fixed.

Please review.


Thanks,
Surinder Kumar


RM#1352.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To have validation messages on status panel only (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA patch to fix the issue mentioned in RM#1281, We have removed error
messages from standard Backform control rather display validation error
messages only on status panel.

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1281.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers