Re: [pgadmin-hackers] Runtime broken on Mac

[Ashesh Vashi]

Sorry.
Unfortunately - we did not have access to the community build at that time.

We can test the one click installer without setting PYTHON_HOME, if that
works - we can unset it only for Mac.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Thu, Sep 1, 2016 at 10:35 PM, Dave Page  wrote:

> It should have fixed 1392, but it broke the community mac package (just
> after beta 4)
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK:http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On 1 Sep 2016, at 17:42, Ashesh Vashi 
> wrote:
>
> Also - during beta 4 release the runtime issue was fixed only by setting
> PYTHON_HOME.
>
> On Sep 1, 2016 22:10, "Ashesh Vashi" 
> wrote:
>
>> This might explain.
>> https://redmine.postgresql.org/issues/1392
>>
>> On Sep 1, 2016 21:52, "Dave Page"  wrote:
>>
>>> Neel, Ashesh,
>>>
>>> re: https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdi
>>> ff;h=a3e8ba93ae6968f13b331d9218d51b8e2d39f344
>>>
>>> it seems that setting PYTHON_HOME breaks the runtime on Mac OSX. Doing
>>> so means that the system installed Python libraries cannot be found, a
>>> (large) number of which do not get installed into the virtualenv.
>>>
>>> Now I could modify the package build scripts to copy or symlink all
>>> those extra files and directories into the virtual env (I would
>>> probably symlink, as that's what happens with the rest of the venv),
>>> but before I do - can you remind me why we needed to explicitly set it
>>> anyway?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>

Re: [pgadmin-hackers] Runtime broken on Mac

[Dave Page]

It should have fixed 1392, but it broke the community mac package (just after 
beta 4)

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

> On 1 Sep 2016, at 17:42, Ashesh Vashi  wrote:
> 
> Also - during beta 4 release the runtime issue was fixed only by setting 
> PYTHON_HOME.
> 
> 
>> On Sep 1, 2016 22:10, "Ashesh Vashi"  wrote:
>> This might explain.
>> https://redmine.postgresql.org/issues/1392
>> 
>> 
>>> On Sep 1, 2016 21:52, "Dave Page"  wrote:
>>> Neel, Ashesh,
>>> 
>>> re: 
>>> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=a3e8ba93ae6968f13b331d9218d51b8e2d39f344
>>> 
>>> it seems that setting PYTHON_HOME breaks the runtime on Mac OSX. Doing
>>> so means that the system installed Python libraries cannot be found, a
>>> (large) number of which do not get installed into the virtualenv.
>>> 
>>> Now I could modify the package build scripts to copy or symlink all
>>> those extra files and directories into the virtual env (I would
>>> probably symlink, as that's what happens with the rest of the venv),
>>> but before I do - can you remind me why we needed to explicitly set it
>>> anyway?
>>> 
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>> 
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Runtime broken on Mac

[Ashesh Vashi]

Also - during beta 4 release the runtime issue was fixed only by setting
PYTHON_HOME.

On Sep 1, 2016 22:10, "Ashesh Vashi"  wrote:

> This might explain.
> https://redmine.postgresql.org/issues/1392
>
> On Sep 1, 2016 21:52, "Dave Page"  wrote:
>
>> Neel, Ashesh,
>>
>> re: https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdi
>> ff;h=a3e8ba93ae6968f13b331d9218d51b8e2d39f344
>>
>> it seems that setting PYTHON_HOME breaks the runtime on Mac OSX. Doing
>> so means that the system installed Python libraries cannot be found, a
>> (large) number of which do not get installed into the virtualenv.
>>
>> Now I could modify the package build scripts to copy or symlink all
>> those extra files and directories into the virtual env (I would
>> probably symlink, as that's what happens with the rest of the venv),
>> but before I do - can you remind me why we needed to explicitly set it
>> anyway?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

Re: [pgadmin-hackers] Runtime broken on Mac

[Ashesh Vashi]

This might explain.
https://redmine.postgresql.org/issues/1392

On Sep 1, 2016 21:52, "Dave Page"  wrote:

> Neel, Ashesh,
>
> re: https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=
> a3e8ba93ae6968f13b331d9218d51b8e2d39f344
>
> it seems that setting PYTHON_HOME breaks the runtime on Mac OSX. Doing
> so means that the system installed Python libraries cannot be found, a
> (large) number of which do not get installed into the virtualenv.
>
> Now I could modify the package build scripts to copy or symlink all
> those extra files and directories into the virtual env (I would
> probably symlink, as that's what happens with the rest of the venv),
> but before I do - can you remind me why we needed to explicitly set it
> anyway?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] Runtime broken on Mac

[Dave Page]

Neel, Ashesh,

re: 
https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=a3e8ba93ae6968f13b331d9218d51b8e2d39f344

it seems that setting PYTHON_HOME breaks the runtime on Mac OSX. Doing
so means that the system installed Python libraries cannot be found, a
(large) number of which do not get installed into the virtualenv.

Now I could modify the package build scripts to copy or symlink all
those extra files and directories into the virtual env (I would
probably symlink, as that's what happens with the rest of the venv),
but before I do - can you remind me why we needed to explicitly set it
anyway?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

[Navnath Gadakh]

Sure.

On Thu, Sep 1, 2016 at 4:44 PM, Dave Page 
wrote:

> Hi
>
> Please separate the cleanup from the new tests. Each patch should have
> just one feature/focus/fix.
>
> Thanks.
>
> On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh <
> navnath.gad...@enterprisedb.com> wrote:
>
>> Hello Dave,
>> Object cleanup work is completed in above patch. I am working on enhanced
>> summary work, once that's complete I will send the revised patch.
>>
>> Thanks!
>>
>> On Thu, Sep 1, 2016 at 3:57 PM, Dave Page 
>> wrote:
>>
>>> Per my earlier email to Priyanka, I'm not going to commit any more test
>>> cases until the existing issues are resolved and the enhanced summary and
>>> object cleanup work is complete, otherwise it's just taking too much time
>>> unnecessarily.
>>>
>>> Please re-test and resubmit this patch once that work is complete.
>>>
>>> Thanks.
>>>
>>> On Tue, Aug 30, 2016 at 1:02 PM, Navnath Gadakh <
>>> navnath.gad...@enterprisedb.com> wrote:
>>>
 Hi Dave,
Please find the patch API unit test cases for Domain & Tables
 Nodes.

 This patch also includes code to drop the all objects(like database,
 roles, tablespace & server) created during the test suite run.

 *To run the test suite for domain node:*
  python regression/runtests.py --pkg browser.server_groups.servers.
 databases.schemas.domains


 *To run the test suite for tables node:*
   python regression/runtests.py --pkg browser.server_groups.
 servers.databases.schemas.tables

 *To run the test suite for all nodes *(Comment the all test code in
 'synonyms' node i.e. Code under 'tests' directory as its partially
 completed):
   python regression/runtests.py


 --
 Thanks,
 Navnath Gadakh
 Software Engineer
 EnterpriseDB Corporation
 Mobile: +91 9975389878



>>>
>>>
>>> --
>>> Dave Page
>>> VP, Chief Architect, Tools & Installers
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>
>>
>>
>> --
>> Thanks,
>> Navnath Gadakh
>> Software Engineer
>> EnterpriseDB Corporation
>> Mobile: +91 9975389878
>>
>>
>>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>



-- 
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

[Dave Page]

Hi

Please separate the cleanup from the new tests. Each patch should have just
one feature/focus/fix.

Thanks.

On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hello Dave,
> Object cleanup work is completed in above patch. I am working on enhanced
> summary work, once that's complete I will send the revised patch.
>
> Thanks!
>
> On Thu, Sep 1, 2016 at 3:57 PM, Dave Page 
> wrote:
>
>> Per my earlier email to Priyanka, I'm not going to commit any more test
>> cases until the existing issues are resolved and the enhanced summary and
>> object cleanup work is complete, otherwise it's just taking too much time
>> unnecessarily.
>>
>> Please re-test and resubmit this patch once that work is complete.
>>
>> Thanks.
>>
>> On Tue, Aug 30, 2016 at 1:02 PM, Navnath Gadakh <
>> navnath.gad...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>Please find the patch API unit test cases for Domain & Tables
>>> Nodes.
>>>
>>> This patch also includes code to drop the all objects(like database,
>>> roles, tablespace & server) created during the test suite run.
>>>
>>> *To run the test suite for domain node:*
>>>  python regression/runtests.py --pkg browser.server_groups.servers.
>>> databases.schemas.domains
>>>
>>>
>>> *To run the test suite for tables node:*
>>>   python regression/runtests.py --pkg browser.server_groups.
>>> servers.databases.schemas.tables
>>>
>>> *To run the test suite for all nodes *(Comment the all test code in
>>> 'synonyms' node i.e. Code under 'tests' directory as its partially
>>> completed):
>>>   python regression/runtests.py
>>>
>>>
>>> --
>>> Thanks,
>>> Navnath Gadakh
>>> Software Engineer
>>> EnterpriseDB Corporation
>>> Mobile: +91 9975389878
>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

[Navnath Gadakh]

Hello Dave,
Object cleanup work is completed in above patch. I am working on enhanced
summary work, once that's complete I will send the revised patch.

Thanks!

On Thu, Sep 1, 2016 at 3:57 PM, Dave Page 
wrote:

> Per my earlier email to Priyanka, I'm not going to commit any more test
> cases until the existing issues are resolved and the enhanced summary and
> object cleanup work is complete, otherwise it's just taking too much time
> unnecessarily.
>
> Please re-test and resubmit this patch once that work is complete.
>
> Thanks.
>
> On Tue, Aug 30, 2016 at 1:02 PM, Navnath Gadakh <
> navnath.gad...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>Please find the patch API unit test cases for Domain & Tables
>> Nodes.
>>
>> This patch also includes code to drop the all objects(like database,
>> roles, tablespace & server) created during the test suite run.
>>
>> *To run the test suite for domain node:*
>>  python regression/runtests.py --pkg browser.server_groups.servers.
>> databases.schemas.domains
>>
>>
>> *To run the test suite for tables node:*
>>   python regression/runtests.py --pkg browser.server_groups.
>> servers.databases.schemas.tables
>>
>> *To run the test suite for all nodes *(Comment the all test code in
>> 'synonyms' node i.e. Code under 'tests' directory as its partially
>> completed):
>>   python regression/runtests.py
>>
>>
>> --
>> Thanks,
>> Navnath Gadakh
>> Software Engineer
>> EnterpriseDB Corporation
>> Mobile: +91 9975389878
>>
>>
>>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>



-- 
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878

[pgadmin-hackers] pgAdmin 4 commit: Fix the boolean editor, and warn the user if there ar

[Dave Page]

Fix the boolean editor, and warn the user if there are unsaved changed in the 
edit grid before refreshing.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=087332f32e93434546ef174787522d0060568522
Author: Murtuza Zabuawala 

Modified Files
--
.../js/slickgrid/slick.pgadmin.formatters.js   |  7 +++-
.../tools/sqleditor/static/css/sqleditor.css   |  8 
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 49 ++
3 files changed, 56 insertions(+), 8 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: Schema child node: FTS nodes (Configuration, Dictionaries, Parser, Templates)

[Priyanka Shendge]

Sure, i'll re-submit a patch once clean up work and summary output in place.

Thank you.

On 1 September 2016 at 15:55, Dave Page  wrote:

> Hi
>
> I'm currently seeing numerous failures in the test suite, including ERROR
> tags being output from tests in this patch without any other output (does
> that mean they're negative tests and the error is expected)?
>
> In any case, I'm not going to commit any more test cases until the
> existing issues are resolved and the enhanced summary and object cleanup
> work is complete, otherwise it's just taking too much time unnecessarily.
>
> Please resubmit this patch once that work is complete.
>
> Thanks.
>
> On Mon, Aug 29, 2016 at 12:55 PM, Priyanka Shendge  enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> PFA patch for FTS Configuration, Dictionaries, Parser, Templates nodes.
>>
>> Currently,  Cast update (test_cast_put.py) test case is failing. Issue
>> (Bug #1614)
>> has been reported for same and synonyms cases are not working as those
>> needs to complete.
>>
>> Please review FTS nodes patch and let me know for any changes.
>>
>> Thank you.
>>
>> --
>> Best,
>> Priyanka
>>
>> EnterpriseDB Corporation
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>



-- 
Best,
Priyanka

EnterpriseDB Corporation
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Tag REL-1_0-RC1 has been created.

[Dave Page]

Tag REL-1_0-RC1 has been created.
View: 
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_0-RC1

Log Message
---
Tag 1.0 RC1
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] RC1 did not hit website

[Dave Page]

On Thu, Sep 1, 2016 at 11:35 AM, Devrim Gündüz  wrote:

>
> Hi Dave,
>
> On Thu, 2016-09-01 at 11:33 +0100, Dave Page wrote:
> > > pgadmin.org still mentions about beta 4, it needs an update for RC1.
> > >
> >
> > Yes. We always 'officially' release after PostgreSQL.
>
> For a moment I thought it was Friday. Sorry :)


Wishful thinking my friend!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] RC1 did not hit website

[Devrim Gündüz]

Hi Dave,

On Thu, 2016-09-01 at 11:33 +0100, Dave Page wrote:
> > pgadmin.org still mentions about beta 4, it needs an update for RC1.
> >
> 
> Yes. We always 'officially' release after PostgreSQL.

For a moment I thought it was Friday. Sorry :)

Regards,
-- 
Devrim GÜNDÜZ
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

Re: [pgadmin-hackers] Package node test cases [pgadmin4]

[Harshal Dhumal]

Ok, I'll do that once that work is completed.

-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Sep 1, 2016 at 3:57 PM, Dave Page  wrote:

> Per my earlier email to Priyanka, I'm not going to commit any more test
> cases until the existing issues are resolved and the enhanced summary and
> object cleanup work is complete, otherwise it's just taking too much time
> unnecessarily.
>
> Please re-test and resubmit this patch once that work is complete.
>
> Thanks.
>
> On Tue, Aug 30, 2016 at 12:05 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch for package node test cases.
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] RC1 did not hit website

[Dave Page]

2016-09-01 11:31 GMT+01:00 Devrim Gündüz :

>
> Hi,
>
> pgadmin.org still mentions about beta 4, it needs an update for RC1.
>

Yes. We always 'officially' release after PostgreSQL.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] RC1 did not hit website

[Devrim Gündüz]

Hi,

pgadmin.org still mentions about beta 4, it needs an update for RC1.

Regards,
-- 
Devrim GÜNDÜZ
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

[Dave Page]

Per my earlier email to Priyanka, I'm not going to commit any more test
cases until the existing issues are resolved and the enhanced summary and
object cleanup work is complete, otherwise it's just taking too much time
unnecessarily.

Please re-test and resubmit this patch once that work is complete.

Thanks.

On Tue, Aug 30, 2016 at 1:02 PM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hi Dave,
>Please find the patch API unit test cases for Domain & Tables Nodes.
>
> This patch also includes code to drop the all objects(like database,
> roles, tablespace & server) created during the test suite run.
>
> *To run the test suite for domain node:*
>  python regression/runtests.py --pkg browser.server_groups.servers.
> databases.schemas.domains
>
>
> *To run the test suite for tables node:*
>   python regression/runtests.py --pkg browser.server_
> groups.servers.databases.schemas.tables
>
> *To run the test suite for all nodes *(Comment the all test code in
> 'synonyms' node i.e. Code under 'tests' directory as its partially
> completed):
>   python regression/runtests.py
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Re: [pgadmin-hackers] Package node test cases [pgadmin4]

[Dave Page]

Per my earlier email to Priyanka, I'm not going to commit any more test
cases until the existing issues are resolved and the enhanced summary and
object cleanup work is complete, otherwise it's just taking too much time
unnecessarily.

Please re-test and resubmit this patch once that work is complete.

Thanks.

On Tue, Aug 30, 2016 at 12:05 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch for package node test cases.
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: Schema child node: FTS nodes (Configuration, Dictionaries, Parser, Templates)

[Dave Page]

Hi

I'm currently seeing numerous failures in the test suite, including ERROR
tags being output from tests in this patch without any other output (does
that mean they're negative tests and the error is expected)?

In any case, I'm not going to commit any more test cases until the existing
issues are resolved and the enhanced summary and object cleanup work is
complete, otherwise it's just taking too much time unnecessarily.

Please resubmit this patch once that work is complete.

Thanks.

On Mon, Aug 29, 2016 at 12:55 PM, Priyanka Shendge <
priyanka.shen...@enterprisedb.com> wrote:

> Hi Dave,
>
> PFA patch for FTS Configuration, Dictionaries, Parser, Templates nodes.
>
> Currently,  Cast update (test_cast_put.py) test case is failing. Issue
> (Bug #1614)
> has been reported for same and synonyms cases are not working as those
> needs to complete.
>
> Please review FTS nodes patch and let me know for any changes.
>
> Thank you.
>
> --
> Best,
> Priyanka
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake