Re: [pgadmin-hackers] PATCH: RM#1735

[Ashesh Vashi]

Hi Team,


On Sat, Sep 24, 2016 at 3:23 AM, Ashesh Vashi  wrote:

> Hi Dave/Team,
>
> I've fixed the issue "No default schema when creating some schema objects".
>
> For package, allowing to change the schema at the create time only, as the
> logic required to change schema of an existing package required a lot of
> changes. And, I am reluctant to do it at this phase of the project.
>
I also find out that - when we refresh the schema node, it was returning an
array of node data instead of an individual node data.

Please find the fix for it as part # 2.

NOTE: First patch is still applicable.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



 *http://www.linkedin.com/in/asheshvashi*


>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>


RM1735_part2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: RM#1733

[Ashesh Vashi]

Hi Dave/Team,

Please find the patch for the issue - 'Filter option taking too much time
to load'.
Actually - it wasn't taking any time, but - we did not hide the loading div
properly.

Please find the patch, which also takes care of other similar possible
issue along with the above issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*



RM1733.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: RM#1736

[Ashesh Vashi]

Hi Dave/Team,

Please find the patch for the "Cannot create a view".
When we do not select the schema name, this error comes at backend-side.

The client-side issue has been taken care by the patch for RM#1735.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*



RM1736.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: RM#1735

[Ashesh Vashi]

Hi Dave/Team,

I've fixed the issue "No default schema when creating some schema objects".

For package, allowing to change the schema at the create time only, as the
logic required to change schema of an existing package required a lot of
changes. And, I am reluctant to do it at this phase of the project.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*



RM1735.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

[Dave Page]

Umm, no it wasn't - sorry.

I see the same issue with Types. Can you fix that, and check all other
nodes as well please?

Thanks.

On Fri, Sep 23, 2016 at 1:29 PM, Dave Page  wrote:
> Thanks, applied.
>
> On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar
>  wrote:
>> Hi,
>>
>> Please find updated patch with changes:
>> 1) On debugging through JS files, the issue was in synonym update method
>> which wasn't returning node object.
>> 2) retrieving schema name in node.sql for creating node object in update
>> method.
>>
>> Please review and let me know for comments.
>>
>> On Fri, Sep 23, 2016 at 2:44 PM, Dave Page  wrote:
>>>
>>> Hi
>>>
>>> On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar
>>>  wrote:
>>> > Hi
>>> >
>>> > Issue:
>>> > on updating node, we deselect and then again select the node updated to
>>> > refresh the panel. but it needs some delay of few milliseconds between
>>> > deselect and select to fix this issue.
>>> >
>>> > Please find attached patch and review.
>>>
>>> This does not resolve the issue for me. I tested using a synonym to a
>>> package on EPAS 9.5, by changing the target package name.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the '/logout' redirects to '/' (pgAdmin4)

[Dave Page]

Thanks, applied.

On Fri, Sep 23, 2016 at 11:38 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue where '/logout' redirects to '/', which cause
> issue if pgAdmin4 is running in virtual root environment.
> RM#1691
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure we go back to the login page after logging out

[Dave Page]

Ensure we go back to the login page after logging out, when installed at a 
virtual root. Fixes #1691

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c855234f865d61e034196830f9afd7bdd391607
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/browser/templates/browser/index.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

[Surinder Kumar]

Hi,

Please find updated patch with changes:
1) On debugging through JS files, the issue was in synonym update method
which wasn't returning node object.
2) retrieving schema name in node.sql for creating node object in update
method.

Please review and let me know for comments.

On Fri, Sep 23, 2016 at 2:44 PM, Dave Page  wrote:

> Hi
>
> On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar
>  wrote:
> > Hi
> >
> > Issue:
> > on updating node, we deselect and then again select the node updated to
> > refresh the panel. but it needs some delay of few milliseconds between
> > deselect and select to fix this issue.
> >
> > Please find attached patch and review.
>
> This does not resolve the issue for me. I tested using a synonym to a
> package on EPAS 9.5, by changing the target package name.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM1728_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the '/logout' redirects to '/' (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA patch to fix the issue where '/logout' redirects to '/', which cause
issue if pgAdmin4 is running in virtual root environment.
RM#1691

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/templates/browser/index.html b/web/pgadmin/browser/templates/browser/index.html
index a914c00..5bd054a 100644
--- a/web/pgadmin/browser/templates/browser/index.html
+++ b/web/pgadmin/browser/templates/browser/index.html
@@ -156,7 +156,7 @@ require.onResourceLoad = function (context, map, depMaps) {
 {{ _('Users') }}
 
 {% endif %}
-{{ _('Logout') }}
+{{ _('Logout') }}
 
 
 

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

[Dave Page]

Hi

On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar
 wrote:
> Hi
>
> Issue:
> on updating node, we deselect and then again select the node updated to
> refresh the panel. but it needs some delay of few milliseconds between
> deselect and select to fix this issue.
>
> Please find attached patch and review.

This does not resolve the issue for me. I tested using a synonym to a
package on EPAS 9.5, by changing the target package name.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: pgAgent support

[Ashesh Vashi]

Thanks - working on the rest of the comments.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Fri, Sep 23, 2016 at 2:40 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Fri, Sep 23, 2016 at 7:33 AM, Ashesh Vashi
>  wrote:
> > Hi Dave,
> >
> >
> > On Thu, Sep 22, 2016 at 8:01 PM, Dave Page  wrote:
> >>
> >> Hi
> >>
> >> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi
> >>  wrote:
> >>>
> >>> Hi Dave,
> >>>
> >>> Please find the patch for support for paAgent in pgAdmin 4.
> >>
> >>
> >> Did you forget the binary switch?
> >>
> >> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch
> >> error: cannot apply binary patch to
> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/
> schedules/static/img/coll-pga_schedule.png'
> >> without full index line
> >> error:
> >> web/pgadmin/browser/server_groups/servers/pgAgent/
> schedules/static/img/coll-pga_schedule.png:
> >> patch does not apply
> >> error: cannot apply binary patch to
> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/
> schedules/static/img/pga_schedule.png'
> >> without full index line
> >> error:
> >> web/pgadmin/browser/server_groups/servers/pgAgent/
> schedules/static/img/pga_schedule.png:
> >> patch does not apply
> >> error: cannot apply binary patch to
> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/
> img/coll-pga_job.png'
> >> without full index line
> >> error:
> >> web/pgadmin/browser/server_groups/servers/pgAgent/static/
> img/coll-pga_job.png:
> >> patch does not apply
> >> error: cannot apply binary patch to
> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/
> img/pga_job-disabled.png'
> >> without full index line
> >> error:
> >> web/pgadmin/browser/server_groups/servers/pgAgent/static/
> img/pga_job-disabled.png:
> >> patch does not apply
> >> error: cannot apply binary patch to
> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/
> img/pga_job.png'
> >> without full index line
> >> error:
> >> web/pgadmin/browser/server_groups/servers/pgAgent/static/
> img/pga_job.png:
> >> patch does not apply
> >> error: cannot apply binary patch to
> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/
> static/img/coll-pga_jobstep.png'
> >> without full index line
> >> error:
> >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/
> static/img/coll-pga_jobstep.png:
> >> patch does not apply
> >> error: cannot apply binary patch to
> >> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/
> static/img/pga_jobstep.png'
> >> without full index line
> >> error:
> >> web/pgadmin/browser/server_groups/servers/pgAgent/steps/
> static/img/pga_jobstep.png:
> >> patch does not apply
> >>>
> >>>
> >>> I have also attached another patch for miscellaneous fixes, and adding
> >>> new controls.
> >>> It includes:
> >>> - Added DatetimepickerControl, MomentCell (using moment.js)
> >>> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue,
> >>> when unset the datetime for 'Valid Until'.)
> >>> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent
> >>> nodes.
> >>> - Fixed an issue with SubNodeCollectionControl, which was not starting
> >>> the modification session of the child model, when created default
> value for
> >>> collection is not null/undefined. And, hence - validation on the child
> model
> >>> was not working.
> >>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which
> was
> >>> not releasing the CodeMirror properly.
> >>
> >>
> >> Urgh, that's big.
> >
> > I know.
> > That's reason - I was reluctant to send earlier.
> >>
> >> Applied - but can you look at the following please?
> >>
> >> - Account expires has a hint of 'MMM D  HH:mm:ss.SSS Z". Are
> >> milliseconds really needed? I also get 00 as a fractional timezone
> offset.
> >> Perhaps we should hide that, when it's 00?
> >
> > Changed to '-MM-DD HH:mm:ss Z'.
> >>
> >>
> >> - The date format differs from the ISO format displayed by the query
> tool.
> >> They should be consistent - and really should be either based on the
> >> client's locale settings, or ISO format.
> >
> > Done
> >
> > --
> > Thanks & Regards,
> >
> > Ashesh Vashi
> >>
> >>
> >> Thanks.
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] pgAdmin 4 commit: Change rolvaliduntil format to "YYYY-MM-DD HH:mm:ss Z

[Dave Page]

Change rolvaliduntil format to "-MM-DD HH:mm:ss Z" for consistency with the 
rest of the app.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8797b3f3bf39832129f49cfaa535d2eb3c64b51c
Author: Ashesh Vashi 

Modified Files
--
.../browser/server_groups/servers/roles/templates/role/js/role.js   | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: pgAgent support

[Dave Page]

Thanks, applied.

On Fri, Sep 23, 2016 at 7:33 AM, Ashesh Vashi
 wrote:
> Hi Dave,
>
>
> On Thu, Sep 22, 2016 at 8:01 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi
>>  wrote:
>>>
>>> Hi Dave,
>>>
>>> Please find the patch for support for paAgent in pgAdmin 4.
>>
>>
>> Did you forget the binary switch?
>>
>> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/schedules/static/img/pga_schedule.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png:
>> patch does not apply
>> error: cannot apply binary patch to
>> 'web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png'
>> without full index line
>> error:
>> web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png:
>> patch does not apply
>>>
>>>
>>> I have also attached another patch for miscellaneous fixes, and adding
>>> new controls.
>>> It includes:
>>> - Added DatetimepickerControl, MomentCell (using moment.js)
>>> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue,
>>> when unset the datetime for 'Valid Until'.)
>>> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent
>>> nodes.
>>> - Fixed an issue with SubNodeCollectionControl, which was not starting
>>> the modification session of the child model, when created default value for
>>> collection is not null/undefined. And, hence - validation on the child model
>>> was not working.
>>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was
>>> not releasing the CodeMirror properly.
>>
>>
>> Urgh, that's big.
>
> I know.
> That's reason - I was reluctant to send earlier.
>>
>> Applied - but can you look at the following please?
>>
>> - Account expires has a hint of 'MMM D  HH:mm:ss.SSS Z". Are
>> milliseconds really needed? I also get 00 as a fractional timezone offset.
>> Perhaps we should hide that, when it's 00?
>
> Changed to '-MM-DD HH:mm:ss Z'.
>>
>>
>> - The date format differs from the ISO format displayed by the query tool.
>> They should be consistent - and really should be either based on the
>> client's locale settings, or ISO format.
>
> Done
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
>>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Do not display 'CREATE Script' on Server-group & Server node (pgAdmin4)

[Dave Page]

Thanks, applied.

On Fri, Sep 23, 2016 at 7:27 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA minor patch to fix the issue where we were displaying 'CREATE Script' on
> Server-group & Server node.
> RM#1578
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Don't offer CREATE Script options on servers or serve

[Dave Page]

Don't offer CREATE Script options on servers or server groups. Fixes #1578

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f18c4554113dd05d9318ba1f36557ca15eef4a5b
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/browser/templates/browser/js/node.js | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

[Surinder Kumar]

On Fri, Sep 23, 2016 at 1:45 PM, Dave Page  wrote:

> On Fri, Sep 23, 2016 at 7:32 AM, Surinder Kumar
>  wrote:
> >
> >
> > On Wed, Sep 21, 2016 at 8:40 PM, Dave Page  wrote:
> >>
> >> Hi
> >>
> >> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar
> >>  wrote:
> >> > Hi Dave/Ashesh
> >> >
> >> > The thing we can do is:
> >> > 1) We can display loading message same as other panels if returned
> >> > response
> >> > is taking longer than 2 seconds, otherwise we won't display any
> >> > message(to
> >> > avoid fluctuations).
> >> > Screenshot - demo_message.png
> >>
> >> There's a typo there (laoded)..
> >>
> >> > 2) Display a loading spinner along with panel title while data is
> being
> >> > loaded.
> >> > Screenshot - spinner.png
> >>
> >> I don't see a spinner there at all.
> >
> > sorry its not spinner, its reload spinning icon in place of properties
> icon.
>
> Oh, I see. I like it, but wonder if it would be too subtle.
>
> Can we do both? Show the panel, and spin a loading icon on the tab?
>
​I will try to implement both.​

>
> >>
> >>
> >> What about the other places I mentioned?
> >
> >
> >>
> >> - On dialogue open and OK
> >
> > D
> > isplay loading message
> > in dialog till the data loads and on OK we can set mouse pointer to
> > 'progress' till the data is not processed.
>
> Yes, they are essentially panels too, so we can do the same as for
> Properties and Statistics etc.
>
> > - On Wizard steps
> >D
> > isplay loading message
> > also in wizard pages till it doesn't loads data.
>
> Yes.
>
> >
> > - Possibly in the debugger, when stepping?
> >
> > In case of debugger's step into, step out & resume, we can set mouse
> pointer
> > to 'progress'
>
> OK.
>
> Can you work up a patch ASAP please?
>
​Ok.​

>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

[Ashesh Vashi]

On Fri, Sep 23, 2016 at 1:54 PM, Dave Page  wrote:

>
>
> On Fri, Sep 23, 2016 at 9:18 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Fri, Sep 23, 2016 at 1:47 PM, Dave Page  wrote:
>>
>>> On Fri, Sep 23, 2016 at 5:59 AM, Surinder Kumar
>>>  wrote:
>>> > Actually It doesn't broke anywhere, instead It runs successfully. On
>>> > debugging I found that it runs the subprocess.Popen() utility but it
>>> doesn't
>>> > run internally the pg_dump utitliy. On running the same command on
>>> windows
>>> > cmd prompt it works.
>>> > Then on setting parameters close_fds=False and cmd_shell=True, It
>>> works.
>>> > I ran backup in Google Chrome.
>>>
>>> It certainly runs pg_dump for me - I see the output in the monitoring
>>> dialogue, and I get a dump file at the end.
>>>
>>> I also use Chrome.
>>>
>> It may differ for different version of python.
>>
>
> Maybe. I'm using 2.7.
>
> Either way, I don't want a command window flashing up unnecessarily.
>
If we set the PYTHON INTERPRETER to run the background process.
i.e. BG_PYTHON_INTERPRETER=c:\Python27\pythonw.exe

We can avoid showing the flashing command window.
I came to this conclusion, because - I tried to hide them using certain
flags, but - it wasn't working well.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

[Dave Page]

On Fri, Sep 23, 2016 at 9:18 AM, Ashesh Vashi  wrote:

> On Fri, Sep 23, 2016 at 1:47 PM, Dave Page  wrote:
>
>> On Fri, Sep 23, 2016 at 5:59 AM, Surinder Kumar
>>  wrote:
>> > Actually It doesn't broke anywhere, instead It runs successfully. On
>> > debugging I found that it runs the subprocess.Popen() utility but it
>> doesn't
>> > run internally the pg_dump utitliy. On running the same command on
>> windows
>> > cmd prompt it works.
>> > Then on setting parameters close_fds=False and cmd_shell=True, It works.
>> > I ran backup in Google Chrome.
>>
>> It certainly runs pg_dump for me - I see the output in the monitoring
>> dialogue, and I get a dump file at the end.
>>
>> I also use Chrome.
>>
> It may differ for different version of python.
>

Maybe. I'm using 2.7.

Either way, I don't want a command window flashing up unnecessarily.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

[Ashesh Vashi]

On Fri, Sep 23, 2016 at 1:47 PM, Dave Page  wrote:

> On Fri, Sep 23, 2016 at 5:59 AM, Surinder Kumar
>  wrote:
> > Actually It doesn't broke anywhere, instead It runs successfully. On
> > debugging I found that it runs the subprocess.Popen() utility but it
> doesn't
> > run internally the pg_dump utitliy. On running the same command on
> windows
> > cmd prompt it works.
> > Then on setting parameters close_fds=False and cmd_shell=True, It works.
> > I ran backup in Google Chrome.
>
> It certainly runs pg_dump for me - I see the output in the monitoring
> dialogue, and I get a dump file at the end.
>
> I also use Chrome.
>
It may differ for different version of python.


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

[Dave Page]

On Fri, Sep 23, 2016 at 5:59 AM, Surinder Kumar
 wrote:
> Actually It doesn't broke anywhere, instead It runs successfully. On
> debugging I found that it runs the subprocess.Popen() utility but it doesn't
> run internally the pg_dump utitliy. On running the same command on windows
> cmd prompt it works.
> Then on setting parameters close_fds=False and cmd_shell=True, It works.
> I ran backup in Google Chrome.

It certainly runs pg_dump for me - I see the output in the monitoring
dialogue, and I get a dump file at the end.

I also use Chrome.



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

[Dave Page]

On Fri, Sep 23, 2016 at 7:32 AM, Surinder Kumar
 wrote:
>
>
> On Wed, Sep 21, 2016 at 8:40 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar
>>  wrote:
>> > Hi Dave/Ashesh
>> >
>> > The thing we can do is:
>> > 1) We can display loading message same as other panels if returned
>> > response
>> > is taking longer than 2 seconds, otherwise we won't display any
>> > message(to
>> > avoid fluctuations).
>> > Screenshot - demo_message.png
>>
>> There's a typo there (laoded)..
>>
>> > 2) Display a loading spinner along with panel title while data is being
>> > loaded.
>> > Screenshot - spinner.png
>>
>> I don't see a spinner there at all.
>
> sorry its not spinner, its reload spinning icon in place of properties icon.

Oh, I see. I like it, but wonder if it would be too subtle.

Can we do both? Show the panel, and spin a loading icon on the tab?

>>
>>
>> What about the other places I mentioned?
>
>
>>
>> - On dialogue open and OK
>
> D
> isplay loading message
> in dialog till the data loads and on OK we can set mouse pointer to
> 'progress' till the data is not processed.

Yes, they are essentially panels too, so we can do the same as for
Properties and Statistics etc.

> - On Wizard steps
>D
> isplay loading message
> also in wizard pages till it doesn't loads data.

Yes.

>
> - Possibly in the debugger, when stepping?
>
> In case of debugger's step into, step out & resume, we can set mouse pointer
> to 'progress'

OK.

Can you work up a patch ASAP please?

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

[Surinder Kumar]

Hi

*Issue:*
on updating node, we deselect and then again select the node updated to
refresh the panel. but it needs some delay of few milliseconds between
deselect and select to fix this issue.

Please find attached patch and review.

Thanks,
Surinder Kumar


RM1728.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

[Surinder Kumar]

On Wed, Sep 21, 2016 at 8:40 PM, Dave Page  wrote:

> Hi
>
> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar
>  wrote:
> > Hi Dave/Ashesh
> >
> > The thing we can do is:
> > 1) We can display loading message same as other panels if returned
> response
> > is taking longer than 2 seconds, otherwise we won't display any
> message(to
> > avoid fluctuations).
> > Screenshot - demo_message.png
>
> There's a typo there (laoded)..
>
> > 2) Display a loading spinner along with panel title while data is being
> > loaded.
> > Screenshot - spinner.png
>
> I don't see a spinner there at all.

​sorry its not spinner, its reload spinning icon in place of properties
icon.​

>
> What about the other places I mentioned?



> - On dialogue open and OK

D​
isplay *loading message*
​in dialog till the data loads and on OK we can set mouse pointer to
'progress' till the data is not processed.

​​
- On Wizard steps
​
​D​
isplay *loading message*
​also in wizard pages till it doesn't loads data.


​​
- Possibly in the debugger, when stepping?
​
​​
In case of debugger's step into, step out & resume, we can set mouse
pointer to 'progress'​
​. ​

>
> > On Wed, Sep 21, 2016 at 5:53 PM, Dave Page  wrote:
> >>
> >> Ashesh, Murtuza, Surinder,
> >>
> >> Some feedback or preferably a patch please? Release is next week!
> >>
> >> On Fri, Sep 16, 2016 at 3:36 PM, Magnus Hagander 
> >> wrote:
> >> > On Fri, Sep 16, 2016 at 3:35 AM, Dave Page  wrote:
> >> >>
> >> >> Ashesh, Murtuza, Surinder,
> >> >>
> >> >> Any thoughts on how we can achieve this easily, and where we're
> >> >> lacking notifications? We did have activity notification in the
> >> >> treeview, but that never worked overly well and now I come to think
> of
> >> >> it, I don't recall seeing it recently. I'm thinking we need
> something:
> >> >>
> >> >> - On treeview node click
> >> >>
> >> >> - On dialogue open and OK
> >> >>
> >> >> - On Wizard steps
> >> >>
> >> >> - Possibly in the debugger, when stepping?
> >> >>
> >> >> I would think all that we need is to set the mouse cursor to
> >> >> 'progress'.
> >> >>
> >> >
> >> > Actually, the treeview spinner worked most of them time.  I'm not sure
> >> > if it
> >> > worked all the time - I didn't check that carefully - but it did work
> >> > most
> >> > of the mtime.
> >> >
> >> > But basically whatever *else* I clicked was the problem. In particular
> >> > clicking the tabs out right, with the "Properties" and "SQL" tabs
> being
> >> > the
> >> > ones I used and they were extremely slow over the high latency
> >> > connection (I
> >> > measured almost 4 minutes as the worst time to load a SQL pane for a
> >> > table
> >> > with 11 columns and a couple of indexes and triggers) with lack of
> >> > feedback.
> >> >
> >> > --
> >> >  Magnus Hagander
> >> >  Me: http://www.hagander.net/
> >> >  Work: http://www.redpill-linpro.com/
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] PATCH: pgAgent support

[Ashesh Vashi]

Hi Dave,


On Thu, Sep 22, 2016 at 8:01 PM, Dave Page  wrote:

> Hi
>
> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find the patch for support for paAgent in pgAdmin 4.
>>
>
> Did you forget the binary switch?
>
> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png'
> without full index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/
> schedules/static/img/coll-pga_schedule.png: patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/schedules/static/img/pga_schedule.png' without
> full index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/
> schedules/static/img/pga_schedule.png: patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/static/img/coll-pga_job.png' without full index
> line
> error: 
> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png:
> patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/static/img/pga_job-disabled.png' without full
> index line
> error: 
> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png:
> patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/static/img/pga_job.png' without full index line
> error: 
> web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png:
> patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png' without
> full index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/
> static/img/coll-pga_jobstep.png: patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/steps/static/img/pga_jobstep.png' without full
> index line
> error: 
> web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png:
> patch does not apply
>
>>
>> I have also attached another patch for miscellaneous fixes, and adding
>> new controls.
>> It includes:
>> - Added DatetimepickerControl, MomentCell (using moment.js)
>> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue,
>> when unset the datetime for 'Valid Until'.)
>> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent
>> nodes.
>> - Fixed an issue with SubNodeCollectionControl, which was not starting
>> the modification session of the child model, when created default value for
>> collection is not null/undefined. And, hence - validation on the child
>> model was not working.
>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was
>> not releasing the CodeMirror properly.
>>
>
> Urgh, that's big.
>
I know.
That's reason - I was reluctant to send earlier.

> Applied - but can you look at the following please?
>
> - Account expires has a hint of 'MMM D  HH:mm:ss.SSS Z". Are
> milliseconds really needed? I also get 00 as a fractional timezone offset.
> Perhaps we should hide that, when it's 00?
>
Changed to '-MM-DD HH:mm:ss Z'.

>
> - The date format differs from the ISO format displayed by the query tool.
> They should be consistent - and really should be either based on the
> client's locale settings, or ISO format.
>
Done

--
Thanks & Regards,

Ashesh Vashi

>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


rolvaliduntil_format.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: Do not display 'CREATE Script' on Server-group & Server node (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA minor patch to fix the issue where we were displaying 'CREATE Script'
on Server-group & Server node.
RM#1578


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1578.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers