[pgadmin-hackers] pgAdmin 4 commit: Don't munge the windows installer filename if there's

[Dave Page]

Don't munge the windows installer filename if there's no app suffix.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30397476da45e419a409710e7447bf0f10fcbcd9

Modified Files
--
Make.bat | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure that the directory paths are as they should be

[Dave Page]

Ensure that the directory paths are as they should be under the runtime. Note 
that this change requires (for now) the regression tests to be run from the 
web/regression directory.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7175929cab984e070d15eb13625ab50459edf9ca

Modified Files
--
web/regression/README | 11 +++
web/setup.py  |  2 +-
2 files changed, 8 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Bump version for release

[Dave Page]

Bump version for release

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e06fd21f3cbe7fafb308c77ef040b71ac1c47325

Modified Files
--
web/config.py | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix button label and colour

[Dave Page]

Fix button label and colour

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6790f14c6c4c6f461c4daaf236d3f02f21a37801

Modified Files
--
web/pgadmin/static/js/slickgrid/slick.pgadmin.editors.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Update message catalogs

[Dave Page]

Update message catalogs

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ba2f46092afabd5ff1ddb6d0132e62774ff49bf

Modified Files
--
web/pgadmin/messages.pot   | 3846 ++
.../translations/fr/LC_MESSAGES/messages.po| 7614 +++-
2 files changed, 10084 insertions(+), 1376 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Prevent bigints getting rounded. Fixes #1547

[Dave Page]

Prevent bigints getting rounded. Fixes #1547

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=09c2d605c9dfedf3f0ed06192d43d7842fb3bb3f
Author: Ashesh Vashi 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

[Dave Page]

Thanks, applied with some changes to wording, and reduction of the
delay from 2 secs to 1.

On Mon, Sep 26, 2016 at 2:41 PM, Surinder Kumar
 wrote:
> Please find attached patch. Added activity indicator for:
> 1) Panels.
> 2) Dialog open and on click OK.(set cursor to progress)
> 3) Debugger. (Set cursor to progress).
>
> Not done: Activity indicator is not implemented for wizard pages. send
> another patch once completed.
>
> On Fri, Sep 23, 2016 at 2:19 PM, Surinder Kumar
>  wrote:
>>
>> On Fri, Sep 23, 2016 at 1:45 PM, Dave Page  wrote:
>>>
>>> On Fri, Sep 23, 2016 at 7:32 AM, Surinder Kumar
>>>  wrote:
>>> >
>>> >
>>> > On Wed, Sep 21, 2016 at 8:40 PM, Dave Page  wrote:
>>> >>
>>> >> Hi
>>> >>
>>> >> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar
>>> >>  wrote:
>>> >> > Hi Dave/Ashesh
>>> >> >
>>> >> > The thing we can do is:
>>> >> > 1) We can display loading message same as other panels if returned
>>> >> > response
>>> >> > is taking longer than 2 seconds, otherwise we won't display any
>>> >> > message(to
>>> >> > avoid fluctuations).
>>> >> > Screenshot - demo_message.png
>>> >>
>>> >> There's a typo there (laoded)..
>>> >>
>>> >> > 2) Display a loading spinner along with panel title while data is
>>> >> > being
>>> >> > loaded.
>>> >> > Screenshot - spinner.png
>>> >>
>>> >> I don't see a spinner there at all.
>>> >
>>> > sorry its not spinner, its reload spinning icon in place of properties
>>> > icon.
>>>
>>> Oh, I see. I like it, but wonder if it would be too subtle.
>>>
>>> Can we do both? Show the panel, and spin a loading icon on the tab?
>>
>> I will try to implement both.
>>>
>>>
>>> >>
>>> >>
>>> >> What about the other places I mentioned?
>>> >
>>> >
>>> >>
>>> >> - On dialogue open and OK
>>> >
>>> > D
>>> > isplay loading message
>>> > in dialog till the data loads and on OK we can set mouse pointer to
>>> > 'progress' till the data is not processed.
>>>
>>> Yes, they are essentially panels too, so we can do the same as for
>>> Properties and Statistics etc.
>>>
>>> > - On Wizard steps
>>> >D
>>> > isplay loading message
>>> > also in wizard pages till it doesn't loads data.
>>>
>>> Yes.
>>>
>>> >
>>> > - Possibly in the debugger, when stepping?
>>> >
>>> > In case of debugger's step into, step out & resume, we can set mouse
>>> > pointer
>>> > to 'progress'
>>>
>>> OK.
>>>
>>> Can you work up a patch ASAP please?
>>
>> Ok.
>>>
>>>
>>> Thanks!
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Improve network/server activity feedback for the user

[Dave Page]

Improve network/server activity feedback for the user. Fixes #1751

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b4776ab5f15eff67a3d3a975fd9c2b32903d342
Author: Surinder Kumar 

Modified Files
--
.../browser/templates/browser/js/messages.js   |  6 ++--
web/pgadmin/browser/templates/browser/js/node.js   | 32 --
web/pgadmin/misc/depends/static/js/depends.js  | 24 ++--
web/pgadmin/misc/sql/static/js/sql.js  | 14 --
.../misc/statistics/static/js/statistics.js| 25 +
web/pgadmin/static/css/pgadmin.css |  6 
.../tools/debugger/templates/debugger/js/direct.js |  6 
7 files changed, 99 insertions(+), 14 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix label cpaitalisation

[Dave Page]

Fix label cpaitalisation

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f9dacc52374a29024ea5436cddedc6b80a322e2f

Modified Files
--
.../servers/databases/schemas/templates/schema/js/schema.js   | 8 
.../servers/databases/templates/databases/js/databases.js | 8 
2 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Error while expanding server group node.

[Ashesh Vashi]

On Mon, Sep 26, 2016 at 6:54 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> *Issue:*
> Getting following error while expanding server group node.
> File "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/
> browser/server_groups/servers/__init__.py", line 86, in get_nodes
> in_recovery = result['rows'][0]['inrecovery'];
> TypeError: string indices must be integers
>
> Not a proper scenario to reproduce it.
>
> *Solution:*
> Add proper check to fix it.
>

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*



>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: Do not try to set in_recovery, is_replay_paused prope

[Ashesh Vashi]

Do not try to set in_recovery, is_replay_paused properties in the server
object, when data is not available.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ae719dae00324c49ea777d8194ca2860f4af471
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/browser/server_groups/servers/__init__.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Lack of activity indicator over slow connections (pgadmin4)

[Surinder Kumar]

Please find attached patch. Added activity indicator for:
1) Panels.
2) Dialog open and on click OK.(set cursor to progress)
3) Debugger. (Set cursor to progress).

Not done: Activity indicator is not implemented for wizard pages. send
another patch once completed.

On Fri, Sep 23, 2016 at 2:19 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> On Fri, Sep 23, 2016 at 1:45 PM, Dave Page  wrote:
>
>> On Fri, Sep 23, 2016 at 7:32 AM, Surinder Kumar
>>  wrote:
>> >
>> >
>> > On Wed, Sep 21, 2016 at 8:40 PM, Dave Page  wrote:
>> >>
>> >> Hi
>> >>
>> >> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar
>> >>  wrote:
>> >> > Hi Dave/Ashesh
>> >> >
>> >> > The thing we can do is:
>> >> > 1) We can display loading message same as other panels if returned
>> >> > response
>> >> > is taking longer than 2 seconds, otherwise we won't display any
>> >> > message(to
>> >> > avoid fluctuations).
>> >> > Screenshot - demo_message.png
>> >>
>> >> There's a typo there (laoded)..
>> >>
>> >> > 2) Display a loading spinner along with panel title while data is
>> being
>> >> > loaded.
>> >> > Screenshot - spinner.png
>> >>
>> >> I don't see a spinner there at all.
>> >
>> > sorry its not spinner, its reload spinning icon in place of properties
>> icon.
>>
>> Oh, I see. I like it, but wonder if it would be too subtle.
>>
>> Can we do both? Show the panel, and spin a loading icon on the tab?
>>
> ​I will try to implement both.​
>
>>
>> >>
>> >>
>> >> What about the other places I mentioned?
>> >
>> >
>> >>
>> >> - On dialogue open and OK
>> >
>> > D
>> > isplay loading message
>> > in dialog till the data loads and on OK we can set mouse pointer to
>> > 'progress' till the data is not processed.
>>
>> Yes, they are essentially panels too, so we can do the same as for
>> Properties and Statistics etc.
>>
>> > - On Wizard steps
>> >D
>> > isplay loading message
>> > also in wizard pages till it doesn't loads data.
>>
>> Yes.
>>
>> >
>> > - Possibly in the debugger, when stepping?
>> >
>> > In case of debugger's step into, step out & resume, we can set mouse
>> pointer
>> > to 'progress'
>>
>> OK.
>>
>> Can you work up a patch ASAP please?
>>
> ​Ok.​
>
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


activity_indicator.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: Error while expanding server group node.

[Surinder Kumar]

Hi

*Issue:*
Getting following error while expanding server group node.
File
"/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
line 86, in get_nodes
in_recovery = result['rows'][0]['inrecovery'];
TypeError: string indices must be integers

Not a proper scenario to reproduce it.

*Solution:*
Add proper check to fix it.


server_expand_issue.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin IV: Code changes in roles and tablespaces test cases

[Dave Page]

Thanks, applied.

On Mon, Sep 26, 2016 at 1:44 PM, Navnath Gadakh
 wrote:
> Hi Dave,
>   Please find the attached patch for the role and table spaces(Changes
> required due to drop objects functionality).
> Also, I have added the code in test result summary to show skipped test
> cases for tablespace if path not mentioned.
>
> To run testsuite:
>
> python regression/runtests.py --pkg
> browser.server_groups.servers.tablespaces
>
> python regression/runtests.py --pkg browser.server_groups.servers.roles
>
>
>
>
> --
> Regards,
> Navnath
>
>



-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Update role and tablespace tests to cleanup properly

[Dave Page]

Update role and tablespace tests to cleanup properly following a failure.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4aae4c24587d2b477dcaafe5e6c2f463da3b8c2
Author: Navnath Gadakh 

Modified Files
--
.../servers/roles/tests/test_role_add.py   |  58 ++---
.../servers/roles/tests/test_role_delete.py|  55 ++---
.../servers/roles/tests/test_role_get.py   |  63 ++---
.../servers/roles/tests/test_role_put.py   |  85 +++
.../server_groups/servers/roles/tests/utils.py | 194 +++
.../servers/tablespaces/tests/test_tbspc_add.py|  76 +++---
.../servers/tablespaces/tests/test_tbspc_delete.py |  70 +++---
.../servers/tablespaces/tests/test_tbspc_get.py|  87 +++
.../servers/tablespaces/tests/test_tbspc_put.py|  99 +++-
.../servers/tablespaces/tests/utils.py | 269 -
web/regression/__init__.py |  41 ++--
web/regression/runtests.py |  37 +--
web/regression/test_utils.py   |  88 +++
13 files changed, 518 insertions(+), 704 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] REL9_6_STABLE configure does not fail when bison or flex not on the system

[Dave Cramer]

building on a clean ubuntu system

configure runs fine.

make fails with

bison not found and or flex not found

I understand this might be intentional, but the warning is useless as it
flys by with the other couple hundred lines output


Dave Cramer

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Dave Page]

On Mon, Sep 26, 2016 at 1:28 PM, Murtuza Zabuawala
 wrote:
> Hi Dave,
>
> PFA updated patch to fix `` tag display.
> Please clear cache & try again with this updated patch.

OK, that fixes the display issue. Regarding the error message, on this
execution I noticed the following exception:

2016-09-26 13:52:48,181: INFO werkzeug: 127.0.0.1 - - [26/Sep/2016
13:52:48] "GET /debugger/poll_end_execution_result/3629301/ HTTP/1.1"
500 -
Traceback (most recent call last):
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 2000, in __call__
return self.wsgi_app(environ, start_response)
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1988, in wsgi_app
response = self.full_dispatch_request()
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1639, in full_dispatch_request
rv = self.dispatch_request()
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask_login.py",
line 792, in decorated_view
return func(*args, **kwargs)
  File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/debugger/__init__.py",
line 1365, in poll_end_execution_result
statusmsg = "".join(additional_msgs) + "" + statusmsg
TypeError: cannot concatenate 'str' and 'NoneType' objects


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure compatibility with newer sqlparse modules. Fix

[Dave Page]

Ensure compatibility with newer sqlparse modules. Fixes #1725

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0a6428e866a9a796167c9122872e1c75b19638f
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/utils/sqlautocomplete/autocomplete.py | 5 +
web/pgadmin/utils/sqlautocomplete/parseutils.py   | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To support new version of sqlparse (pgAdmin4)

[Dave Page]

Thanks - applied!

On Mon, Sep 26, 2016 at 12:44 PM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to address the issue where if user upgrades sqlparse module to
>>0.1.19, it breaks sqleditor auto-complete feature.
> RM#1725
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin IV: Code changes in roles and tablespaces test cases

[Navnath Gadakh]

Hi Dave,
  Please find the attached patch for the role and table spaces(Changes
required due to drop objects functionality).
Also, I have added the code in test result summary to show skipped test
cases for tablespace if path not mentioned.

To run testsuite:

python regression/runtests.py --pkg
browser.server_groups.servers.tablespaces

python regression/runtests.py --pkg browser.server_groups.servers.roles



-- 
Regards,
Navnath


tablespaces_roles.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: pgAgent misc fixes:

[Dave Page]

pgAgent misc fixes:

1. When an existing schedule updated, or a new schedule is added from a pgAgent 
job dialog, it was not able to generate the proper update SQL Query.
2. The SubNodeCollectionControl was not removing the grid, when it is being 
getting removed.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e591c6b5c0fe59d157f6bc611cd0bbce61f8847c
Author: Ashesh Vashi 

Modified Files
--
.../servers/pgagent/templates/pga_job/sql/pre3.4/update.sql | 4 ++--
web/pgadmin/static/js/backform.pgadmin.js   | 6 ++
2 files changed, 8 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Murtuza Zabuawala]

Hi Dave,

PFA updated patch to fix `` tag display.
Please clear cache & try again with this updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Sep 26, 2016 at 5:44 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

>
>
> On Mon, Sep 26, 2016 at 5:08 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala
>>  wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue where it was not disabling buttons after
>> > execution gets finished.
>> > RM#1227
>> >
>> > Issue:
>> > If user clicks on buttons after execution is complete then it was
>> throwing
>> > error, expected behaviour was all button should gets disabled except
>> execute
>> > button.
>>
>> This is an improvement I think, but not complete:
>>
>> - The info messages are now shown, but:
>>   - Not until execution ends, which limits their usefulness for
>> additional debugging. Not sure if that's easily changeable though.
>
>   - The line breaks in messages are displaying like this: "INFO:
>> Employee 1 not found SELECT 1"
>>
> It's showing properly on my side, Please clear browser cache & try again.
>
>> - The first execution of the function worked OK, but following the
>> second execution, I again saw: "Debugger: Step into execution error"
>> as I stepped out of the RETURN statement on line 18.
>>
> This is transient issue, so need more debugging.
>
>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


RM_1227_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Murtuza Zabuawala]

On Mon, Sep 26, 2016 at 5:08 PM, Dave Page  wrote:

> Hi
>
> On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala
>  wrote:
> > Hi,
> >
> > PFA patch to fix the issue where it was not disabling buttons after
> > execution gets finished.
> > RM#1227
> >
> > Issue:
> > If user clicks on buttons after execution is complete then it was
> throwing
> > error, expected behaviour was all button should gets disabled except
> execute
> > button.
>
> This is an improvement I think, but not complete:
>
> - The info messages are now shown, but:
>   - Not until execution ends, which limits their usefulness for
> additional debugging. Not sure if that's easily changeable though.

  - The line breaks in messages are displaying like this: "INFO:
> Employee 1 not found SELECT 1"
>
It's showing properly on my side, Please clear browser cache & try again.

> - The first execution of the function worked OK, but following the
> second execution, I again saw: "Debugger: Step into execution error"
> as I stepped out of the RETURN statement on line 18.
>
This is transient issue, so need more debugging.


>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] PATCH: To support new version of sqlparse (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA patch to address the issue where if user upgrades sqlparse module to
>0.1.19, it breaks sqleditor auto-complete feature.
RM#1725

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1725.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Dave Page]

Hi

On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue where it was not disabling buttons after
> execution gets finished.
> RM#1227
>
> Issue:
> If user clicks on buttons after execution is complete then it was throwing
> error, expected behaviour was all button should gets disabled except execute
> button.

This is an improvement I think, but not complete:

- The info messages are now shown, but:
  - Not until execution ends, which limits their usefulness for
additional debugging. Not sure if that's easily changeable though.
  - The line breaks in messages are displaying like this: "INFO:
Employee 1 not found SELECT 1"

- The first execution of the function worked OK, but following the
second execution, I again saw: "Debugger: Step into execution error"
as I stepped out of the RETURN statement on line 18.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: pgAgent - add modules for jobs, steps and schedules.

[Dave Page]

pgAgent - add modules for jobs, steps and schedules. Fixes #1341

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=237bfd48821ecd2a71e54b6044a8b340c854991a
Author: Ashesh Vashi 

Modified Files
--
.../server_groups/servers/pgagent/__init__.py  | 527 
.../servers/pgagent/schedules/__init__.py  | 441 +
.../schedules/static/img/coll-pga_schedule.png | Bin 0 -> 650 bytes
.../pgagent/schedules/static/img/pga_schedule.png  | Bin 0 -> 683 bytes
.../templates/pga_schedule/css/pga_schedule.css|   7 +
.../templates/pga_schedule/js/pga_schedule.js  | 475 ++
.../servers/pgagent/static/img/coll-pga_job.png| Bin 0 -> 521 bytes
.../pgagent/static/img/pga_job-disabled.png| Bin 0 -> 601 bytes
.../servers/pgagent/static/img/pga_job.png | Bin 0 -> 678 bytes
.../servers/pgagent/steps/__init__.py  | 536 +
.../pgagent/steps/static/img/coll-pga_jobstep.png  | Bin 0 -> 505 bytes
.../pgagent/steps/static/img/pga_jobstep.png   | Bin 0 -> 430 bytes
.../steps/templates/pga_jobstep/css/pga_step.css   |   7 +
.../steps/templates/pga_jobstep/js/pga_jobstep.js  | 275 +++
.../pgagent/templates/macros/pga_exception.macros  |  24 +
.../pgagent/templates/macros/pga_jobstep.macros|  51 ++
.../pgagent/templates/macros/pga_schedule.macros   | 107 
.../pgagent/templates/pga_job/css/pga_job.css  |  28 ++
.../pgagent/templates/pga_job/js/pga_job.js| 161 +++
.../templates/pga_job/sql/pre3.4/create.sql|  31 ++
.../templates/pga_job/sql/pre3.4/delete.sql|   1 +
.../templates/pga_job/sql/pre3.4/job_classes.sql   |   1 +
.../pgagent/templates/pga_job/sql/pre3.4/nodes.sql |   8 +
.../templates/pga_job/sql/pre3.4/properties.sql|  21 +
.../templates/pga_job/sql/pre3.4/run_now.sql   |   3 +
.../templates/pga_job/sql/pre3.4/schedules.sql |   2 +
.../pgagent/templates/pga_job/sql/pre3.4/stats.sql |  11 +
.../pgagent/templates/pga_job/sql/pre3.4/steps.sql |   2 +
.../templates/pga_job/sql/pre3.4/update.sql|  20 +
.../templates/pga_jobstep/sql/pre3.4/create.sql|   2 +
.../templates/pga_jobstep/sql/pre3.4/delete.sql|   2 +
.../templates/pga_jobstep/sql/pre3.4/nodes.sql |  10 +
.../pga_jobstep/sql/pre3.4/properties.sql  |   2 +
.../templates/pga_jobstep/sql/pre3.4/stats.sql |  13 +
.../templates/pga_jobstep/sql/pre3.4/update.sql|   2 +
.../templates/pga_schedule/sql/pre3.4/create.sql   |  10 +
.../templates/pga_schedule/sql/pre3.4/delete.sql   |   2 +
.../templates/pga_schedule/sql/pre3.4/nodes.sql|  11 +
.../pga_schedule/sql/pre3.4/properties.sql |   2 +
.../templates/pga_schedule/sql/pre3.4/update.sql   |   2 +
40 files changed, 2797 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix SQL box sizing.

[Dave Page]

Fix SQL box sizing.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f3ca548cd6dfee75fd558b509bdded45444e576

Modified Files
--
web/pgadmin/static/css/overrides.css | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA patch to fix the issue where it was not disabling buttons after
execution gets finished.
RM#1227

*Issue:*
If user clicks on buttons after execution is complete then it was throwing
error, expected behaviour was all button should gets disabled except
execute button.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1227.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: RM#1736

[Dave Page]

Thanks, applied.

On Fri, Sep 23, 2016 at 11:19 PM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> Hi Dave/Team,
>
> Please find the patch for the "Cannot create a view".
> When we do not select the schema name, this error comes at backend-side.
>
> The client-side issue has been taken care by the patch for RM#1735.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Fix view creation. Fixes #1736

[Dave Page]

Fix view creation. Fixes #1736

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=912eebb583fe4386774e50fc6514407947d4baef
Author: Ashesh Vashi 

Modified Files
--
.../servers/databases/schemas/views/__init__.py| 41 --
1 file changed, 31 insertions(+), 10 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix validation message

[Dave Page]

Fix validation message

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f51d8c72efa277eaded9b5571d0f65235b43ba78

Modified Files
--
.../servers/databases/schemas/views/templates/mview/js/mview.js | 2 +-
.../servers/databases/schemas/views/templates/view/js/view.js   | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: RM#1733

[Dave Page]

Thanks, applied.

On Fri, Sep 23, 2016 at 11:41 PM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> Hi Dave/Team,
>
> Please find the patch for the issue - 'Filter option taking too much time
> to load'.
> Actually - it wasn't taking any time, but - we did not hide the loading
> div properly.
>
> Please find the patch, which also takes care of other similar possible
> issue along with the above issue.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Ensure the view data filter box is usable. Fixes #173

[Dave Page]

Ensure the view data filter box is usable. Fixes #1733

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bf48d06fb137ae2de3d4201948f428c9f5abc69
Author: Ashesh Vashi 

Modified Files
--
.../tools/sqleditor/templates/sqleditor/js/sqleditor.js | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix layout of the filter box.

[Dave Page]

Fix layout of the filter box.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d222067b99312f95b80f79970169646969e1ab7

Modified Files
--
web/pgadmin/tools/sqleditor/static/css/sqleditor.css | 1 -
1 file changed, 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgadmin4 rc1

[steve hermes]

Everything looks good and seems good

But any queries never return on localhost DB PG 9.5.
No errors in the browser.
$ uname -a
Linux lubuntu-vm 4.4.0-38-generic #57-Ubuntu SMP Tue Sep 6 15:42:33 UTC
2016 x86_64 x86_64 x86_64 GNU/Linux

Anyone else seeing this ?

Thanks
Steve




-- 
The pessimist complains about the wind
The optimist expects it to change
The realist adjusts the sails
William A Ward

Re: [pgadmin-hackers] PATCH: RM#1735

[Dave Page]

Thanks, applied.

On Sat, Sep 24, 2016 at 12:04 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> Hi Team,
>
>
> On Sat, Sep 24, 2016 at 3:23 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Dave/Team,
>>
>> I've fixed the issue "No default schema when creating some schema
>> objects".
>>
>> For package, allowing to change the schema at the create time only, as
>> the logic required to change schema of an existing package required a lot
>> of changes. And, I am reluctant to do it at this phase of the project.
>>
> I also find out that - when we refresh the schema node, it was returning
> an array of node data instead of an individual node data.
>
> Please find the fix for it as part # 2.
>
> NOTE: First patch is still applicable.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
>  *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] PATCH: RM#1735

[Dave Page]

Thanks, applied.

On Fri, Sep 23, 2016 at 10:53 PM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> Hi Dave/Team,
>
> I've fixed the issue "No default schema when creating some schema objects".
>
> For package, allowing to change the schema at the create time only, as the
> logic required to change schema of an existing package required a lot of
> changes. And, I am reluctant to do it at this phase of the project.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Ensure the default schema is set when creating object

[Dave Page]

Ensure the default schema is set when creating objects. Fixes #1735

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6999249dcdc6274131e810155786c7a307d2589d
Author: Ashesh Vashi 

Modified Files
--
.../servers/databases/schemas/__init__.py  | 16 +--
.../collations/templates/collation/js/collation.js | 15 ++
.../domains/templates/domains/js/domains.js| 11 --
.../templates/foreign_tables/js/foreign_tables.js  | 12 +--
.../fts_configuration/js/fts_configuration.js  |  3 ++-
.../templates/fts_parser/js/fts_parser.js  |  3 ++-
.../templates/fts_template/js/fts_templates.js |  3 ++-
.../servers/databases/schemas/packages/__init__.py |  5 ++---
.../packages/templates/package/js/package.js   | 22 
.../sequences/templates/sequence/js/sequence.js|  2 +-
.../synonyms/templates/synonym/js/synonym.js   |  7 ---
.../schemas/tables/templates/table/js/table.js | 16 +++
.../schemas/types/templates/type/js/type.js| 15 +++---
.../schemas/views/templates/mview/js/mview.js  | 23 -
.../schemas/views/templates/view/js/view.js| 24 +-
15 files changed, 100 insertions(+), 77 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: pgAgent support

[Dave Page]

Hi

I've applied the misc changes patch, but it looks like you forgot the
--binary option for the pgAgent patch. Can you recreate it please?

Thanks.

On Fri, Sep 23, 2016 at 9:34 PM, Ashesh Vashi  wrote:

> Hi Dave,
>
>
> On Thu, Sep 22, 2016 at 8:27 PM, Dave Page  wrote:
>
>> Thanks. From the pgAgent patch:
>>
>> - The date/time format is different again. Should be locale or ISO
>> (consistent across the app)
>>
> Using ISO now.
>
>>
>> - I think we need to add hints under the less obvious options - e.g.
>> Job class and host agent
>>
> I added few string.
> Will need your feedback on that.
>
>>
>> - On the job step subnode control, lets move the Script to it's own
>> tab (called Code). We should alter the label based on the Kind option
>> - either "SQL query" or "Script"
>>
> Done
>
>>
>> - Why can't we use the Date/time picker for Exceptions? I assume we
>> just need to either disable Date or Time selection?
>>
> Done.
>
> I was avoiding to show date time picker for multiple reasons:
> 1. It needed a special effort to show datetime picker in the backgrid cell.
> 2. The datetime picker did not fit in the subnode control.
>
> A special DatetimePickerCell was needed to be created the cell with
> datetime picker.
> And, I had to specify the min-height in the exceptions tab as a hack.
>
>>
>> - The SQL tab doesn't use the available space. See screenshot.
>>
> Fixed.
>
> This was a general issue for the properties dialog having more than 550px.
> We have hardcoded the height to 500px of CodeMirror in the SQL tab.
>
>>
>> - The SQL should have blank lines between sections, e.g. before --
>> Steps and -- Schedules
>>
> Done.
>
> Also - fixed an issue of setting the helpMessage in SwitchControl.
>
> Again - attaching two patches.
> 1. Misc changes
> - Setting the CodeMirror height when panel is resized, which you had
> mentioned.
> - Added a new CellEditor (DatetimePickerEditor) for datetime picker.
> 2. pgAgent support (updated)
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Misc changes

[Dave Page]

Misc changes
- Setting the CodeMirror height when panel is resized, which you had mentioned.
- Added a new CellEditor (DatetimePickerEditor) for datetime picker.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b80cd43ae6a24eef89cb3ece5bbfb12a0b69ce89
Author: Ashesh Vashi 

Modified Files
--
web/pgadmin/browser/templates/browser/js/node.js   | 19 +-
web/pgadmin/static/css/overrides.css   |  6 +-
web/pgadmin/static/js/backform.pgadmin.js  | 39 +--
web/pgadmin/static/js/backgrid/backgrid.pgadmin.js | 78 +-
4 files changed, 128 insertions(+), 14 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers