[pgadmin-hackers] pgAdmin 4 in the two bugs

2016-09-18 Thread Seçkin Alan
Hello,

I install pgadmin4 on MacOSX El Capitan with dmg files.

1-)Control V (Paste) Doesn't work in query tool.

2-) I do horizontal scrolling, coming on top of the scroll bar, function menu.

I added screen shot in attachments.
-- 
Seçkin ALAN
http://sckn.org

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

2016-09-16 Thread Seçkin Alan
Hi Devrim,

https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/9.6/pgadmin4/F-24/pgadmin4.desktop.in;h=362c0368fe54bd9b83fa55f57458af150d7d0942;hb=ad00835b6bb3615eebde2f253ebef438d3c27d48

Could you look this file ?

this variable is incorrect
Name=pgAdmin III

Its should be
Name=pgAdmin 4
or
Name=pgAdmin IV

Thanks.

On Fri, Sep 16, 2016 at 11:17 AM, Devrim Gündüz <dev...@gunduz.org> wrote:
>
> Hi,
>
> On Mon, 2016-09-12 at 11:46 +0100, Dave Page wrote:
>>
>> Awesome - thanks Devrim! I owe you a nice cool glass of spring water :-)
>
> \o/ Can't wait ;)
>
>> Let me know when packages available and ready to use, and I'll add a
>> page to the website to point people at them.
>
> They are currently available for 9.6 only, on yum.postgresql.org. All testing
> has been good so far. Feel free to add info to pgadmin website. I am planning
> to write a short blog post about that soon, about installation instructions,
> running, etc.
>
> Cheers,
> --
> Devrim GÜNDÜZ
> EnterpriseDB: http://www.enterprisedb.com
> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR



-- 
Seçkin ALAN
http://sckn.org


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin4] Server Groups Delete patch

2016-04-15 Thread Seçkin Alan
Drop server groups.

-- 
Seçkin ALAN
http://sckn.org
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 0b52519..890c3dc 100644
--- a/web/pgadmin/browser/templates/browser/js/node.js
+++ b/web/pgadmin/browser/templates/browser/js/node.js
@@ -408,8 +408,9 @@ function($, _, S, pgAdmin, Menu, Backbone, Alertify, pgBrowser, Backform) {
   },
   // Delete the selected object
   delete_obj: function(args, item) {
-var input = args || {};
+  var input = args || {'url':'drop'};
   obj = this,
+  obj.canDrop = true
   t = pgBrowser.tree,
   i = input.item || item || t.selected(),
   d = i && i.length == 1 ? t.itemData(i) : undefined;

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin4] Query Tools result paginate control labels

2016-04-15 Thread Seçkin Alan
Hi,

Backgrid js default control label is 《,
it looks bad.
now it looks like this
<< < 1 > >>
​

-- 
Seçkin ALAN
http://sckn.org
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 463ee45..f0fed4d 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -450,6 +450,13 @@ define(
   }),
   paginator = self.paginator = new Backgrid.Extension.Paginator({
 goBackFirstOnSort: false,
+
+   fastForwardHandleLabels: {
+   first: "<<",
+   prev: "<",
+   next: ">",
+   last: ">>"
+   },
 collection: collection
   }),
   clientSideFilter = self.clientSideFilter = new Backgrid.Extension.ClientSideFilter({

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] pgadmin4 new server host rule is missing

2016-04-14 Thread Seçkin Alan
++
change node js

full patch is attached

On Thu, Apr 14, 2016 at 11:18 PM, Seçkin Alan <seckina...@gmail.com> wrote:
> Hi,
> In model Server.host field is nullable=False but, UI Hostname/address
> field can accept null value.
> So,
> When I click save button, in that time throw error like NOT NULL
> constraint failed: server.host .
>
> --
> Seçkin ALAN
> http://sckn.org



-- 
Seçkin ALAN
http://sckn.org
diff --git a/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js b/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
index 32e9399..ed9b7dc 100644
--- a/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
+++ b/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
@@ -215,6 +215,11 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
 err['name'] = '{{ _('Name can be empty!') }}';
 errmsg = errmsg || err['name'];
   }
+  if (_.isUndefined(this.get('host')) ||this.get('host') == null || String(this.get('host')).replace(/^\s+|\s+$/g, '') == '') {
+err['host'] = '{{ _('Host can be empty!') }}';
+errmsg = errmsg || err['host'];
+  }
+
   this.errorModel.set(err);
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 98f774b..a0e071a 100644
--- a/web/pgadmin/browser/templates/browser/js/node.js
+++ b/web/pgadmin/browser/templates/browser/js/node.js
@@ -851,7 +851,7 @@ function($, _, S, pgAdmin, Menu, Backbone, Alertify, pgBrowser, Backform) {
   if (d && !_.isEmpty(d)) {
 m.save({}, {
   attrs: d,
-  validate: true,
+  validate: false,
   cache: false,
   success: function() {
 onSaveFunc.call();

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgadmin4 new server host rule is missing

2016-04-14 Thread Seçkin Alan
Hi,
In model Server.host field is nullable=False but, UI Hostname/address
field can accept null value.
So,
When I click save button, in that time throw error like NOT NULL
constraint failed: server.host .

-- 
Seçkin ALAN
http://sckn.org
diff --git a/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js b/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
index 32e9399..ed9b7dc 100644
--- a/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
+++ b/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js
@@ -215,6 +215,11 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
 err['name'] = '{{ _('Name can be empty!') }}';
 errmsg = errmsg || err['name'];
   }
+  if (_.isUndefined(this.get('host')) ||this.get('host') == null || String(this.get('host')).replace(/^\s+|\s+$/g, '') == '') {
+err['host'] = '{{ _('Host can be empty!') }}';
+errmsg = errmsg || err['host'];
+  }
+
   this.errorModel.set(err);

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin4 python3 some issues

2016-04-14 Thread Seçkin Alan
Hi,
In Python 2.7
>>>NameError('seckin').message
'seckin'

In Python3
>>> NameError('seckin').message
Traceback (most recent call last):
  File "", line 1, in 
AttributeError: 'NameError' object has no attribute 'message'

So
In python3 some exceptions doesnt showing

For example:
pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py
523: errormsg=e.message

If we use __str__() method, not problem in both versions

what measures can be taken?


-- 
Seçkin ALAN
http://sckn.org


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] grant_wizard py3 bug

2016-04-13 Thread Seçkin Alan
Hi,
I want the run pgadmin4 on python3, throw unquote module not found.

In python3 unquote method moved root to parse class

https://docs.python.org/3.4/library/urllib.parse.html#urllib.parse.unquote


Maybe isn't clear patch.


-- 
Seçkin ALAN
http://sckn.org
diff --git a/web/pgadmin/tools/grant_wizard/__init__.py b/web/pgadmin/tools/grant_wizard/__init__.py
index f53b979..4002e4e 100644
--- a/web/pgadmin/tools/grant_wizard/__init__.py
+++ b/web/pgadmin/tools/grant_wizard/__init__.py
@@ -20,7 +20,10 @@ from pgadmin.browser.server_groups.servers.utils import parse_priv_to_db
 from pgadmin.utils import PgAdminModule
 from flask import Response, url_for
 from flask.ext.security import login_required
-from urllib import unquote
+try:
+from urllib import unquote
+except:
+from urllib.parse import unquote
 from pgadmin.utils.ajax import precondition_required
 from functools import wraps
 from pgadmin.utils.preferences import Preferences


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] Top Menu Link cursor change text to pointer [pgadmin4]

2016-04-12 Thread Seçkin Alan
Hi,
Top Menu Link cursor change text to pointer.

because is does not give the feeling of link.

-- 
Seçkin ALAN
http://sckn.org
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 16f7f0a..6206422 100755
--- a/web/pgadmin/static/css/overrides.css
+++ b/web/pgadmin/static/css/overrides.css
@@ -158,6 +158,7 @@ iframe {
 
 .dropdown-menu > li > a > span {
 padding-left: 3px;
+cursor:pointer;
 }
 
 .dropdown-menu > li > a > .has-icon {

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin4 Bug fix or my Fault ?

2015-05-15 Thread Seçkin Alan
Hi,
I am using Debian Jessie and install pgAdmin4 Required modules.
after I clone pgAdmin4 from
http://git.postgresql.org/gitweb/?p=pgadmin4.git;a=summary ,

First of, ıf I want run setup.py, I must fix bug .
after I want run pgadmin4.py, I must fix gravatar import line.

In this case,
There are really bugs?
or
is it my fault ?
 Thank you.


diff --git a/web/pgadmin/browser/views.py b/web/pgadmin/browser/views.py
index 07637be..f336f31 100644
--- a/web/pgadmin/browser/views.py
+++ b/web/pgadmin/browser/views.py
@@ -11,7 +11,7 @@
 MODULE_NAME = 'browser'

 from flask import Blueprint, Response, current_app, render_template, url_for
-from flaskext.gravatar import Gravatar
+from flask_gravatar import Gravatar
 from flask.ext.security import login_required
 from flask.ext.login import current_user
 from inspect import getmoduleinfo, getmembers
@@ -223,4 +223,4 @@ def get_nodes():
 return resp


-
\ No newline at end of file
+
diff --git a/web/setup.py b/web/setup.py
index c7398f5..da6652e 100644
--- a/web/setup.py
+++ b/web/setup.py
@@ -59,7 +59,9 @@ def do_setup():
 db.create_all()
 user_datastore.create_role(
name='Administrators',
description='pgAdmin Administrators Role')
 user_datastore.create_user(
email=email, password=password)
+db.session.commit()
 user_datastore.add_role_to_user(email, 'Administrators')
+

 # Get the user's ID and create the default server group
 user = User.query.filter_by(email=email).first()
@@ -138,4 +140,5 @@ if os.path.isfile(config.SQLITE_PATH):
 do_upgrade()
 else:
 print The configuration database %s does not exist.\nEntering
initial setup mode...\n % config.SQLITE_PATH
-do_setup()
\ No newline at end of file
+do_setup()

-- 
Seçkin ALAN
http://sckn.org


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers