from:"Timon"

[pgadmin-hackers] interesting bug gcc 6 and pgadmin3

2016-06-16 Thread Timon

with some investigation
https://bugzilla.redhat.com/show_bug.cgi?id=1344917

-- 
All bugs reserved

Re: [pgadmin-hackers] 1.20.0 build error on Fedora 23

2016-01-22 Thread Timon

for others who try to build pgadmin3 in fedora 23

./configure CXXFLAGS="-Wno-deprecated-declarations -Wl,-z,lazy -fPIC -pie"
CFLAGS="-fPIC -pie"
make

2015-11-10 15:18 GMT+03:00 Devrim GÜNDÜZ <dev...@gunduz.org>:

>
> Hi,
>
> On Tue, 2015-11-10 at 14:07 +0300, Timon wrote:
> > it happened after "harden" all packages
> > https://fedoraproject.org/wiki/Changes/Harden_All_Packages
>
> Right. Thanks for the link, I know the hardening thing, but it seems I
> forgot to add -pie to CFLAGS and CXXFLAGS.
>
> Now I can build it.
>
> Regards,
>
>
> --
> Devrim GÜNDÜZ
> Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>
>
>


-- 
All bugs reserved

Re: [pgadmin-hackers] ]GTK 3

2015-12-18 Thread Timon

I've tried to build under fedora 23

./configure CXXFLAGS="-W./configure --with-wx-version=3.0
CXXFLAGS="-Wno-deprecated-declarations -Wl,-z,lazy -fPIC -pie"
CFLAGS="-fPIC -pie"
make -j 10

but it failed on linking stage with errors like

pgAdmin3.o: In function `wxCreateApp()':
pgAdmin3.cpp:(.text+0x16): undefined reference to
`wxAppConsole::CheckBuildOptions(char const*, char const*)'
pgAdmin3.o: In function `frmDlgTest::frmDlgTest()':
pgAdmin3.cpp:(.text+0x381): undefined reference to `wxDir::~wxDir()'
pgAdmin3.cpp:(.text+0x423): undefined reference to `wxDir::~wxDir()'
pgAdmin3.o: In function `pgAdmin3::OnInit()':
.

2015-12-18 14:35 GMT+03:00 Björn Harrtell :

> Hi devs,
>
> Have anyone investigated compiling pgadmin using wxWidgets > 2.9.4 and
> GTK+ 3 which can be enabled with configure option --with-gtk=3?
>
> I'm putting an effort into it now and will share results here, but will
> appreciate information from anyone with existing experience.
>
> /Björn
>



-- 
All bugs reserved

Re: [pgadmin-hackers] pgAdmin III commit: A manual merge of few last commits from libssh2 res

2015-12-09 Thread Timon

forget ; at end of line

diff --git a/pgadmin/libssh2/hostkey.c b/pgadmin/libssh2/hostkey.c
index 3b72782..09955d7 100644
--- a/pgadmin/libssh2/hostkey.c
+++ b/pgadmin/libssh2/hostkey.c
@@ -94,7 +94,7 @@ hostkey_method_ssh_rsa_init(LIBSSH2_SESSION * session,
 n = s;

 ret = _libssh2_rsa_new(, e, e_len, n, n_len, NULL, 0,
- NULL, 0, NULL, 0, NULL, 0, NULL, 0, NULL, 0)
+ NULL, 0, NULL, 0, NULL, 0, NULL, 0, NULL, 0);
 if (ret) {
 return -1;
 }


2015-12-09 10:23 GMT+03:00 Ashesh Vashi :

> A manual merge of few last commits from libssh2 resulted into an critical
> issue.
>
> Branch
> --
> master
>
> Details
> ---
>
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5b2f89173e0da9c27afe4aa686e43dd46c9666ae
> Author: Dmitriy Olshevskiy 
>
> Modified Files
> --
> pgadmin/libssh2/hostkey.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
All bugs reserved

Re: [pgadmin-hackers] 1.20.0 build error on Fedora 23

2015-11-10 Thread Timon

it happened after "harden" all packages
https://fedoraproject.org/wiki/Changes/Harden_All_Packages

2015-11-09 18:07 GMT+03:00 Devrim GÜNDÜZ :

>
> Hi,
>
> I'm getting the error below while trying to build pgadmin3 1.20.0 on
> Fedora 23. All is
>
> I am not a gcc expert, but adding -fPIC to CFLAGS did not help.
>
> Any comments?
>
> gcc -DHAVE_CONFIG_H -I. -I..
> -I../pgadmin/include/libssh2  -DDATA_DIR=\"/usr/pgsql-9.5/share/pgadmin3/\"
> -I../pgadmin/include
> -I../pgadmin/include/libssh2   -I/usr/pgsql-9.5/include
> -I/usr/pgsql-9.5/include/server -I/usr/pgsql-9.5/include -DPG_SSL
> -DHAVE_CONNINFO_PARSE -I/usr/lib64/wx/include/gtk2-unicode-release-2.8
> -I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__
> -DEMBED_XRC -I/usr/include/libxml2 -I/usr/include/libxml2
> -DHAVE_OPENSSL_CRYPTO  -O2 -pipe -Wall -Werror=format-security
> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
> --param=ssp-buffer-size=4 -grecord-gcc-switches
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -fPIC -c
> -o libssh2/version.o libssh2/version.c
> g++  -O2  -L/usr/pgsql-9.5/lib -lkrb5 -Wl,-as-needed -L/usr/lib -o
> pgadmin3 pgAdmin3.o agent/dlgJob.o agent/dlgSchedule.o agent/dlgStep.o
> agent/pgaJob.o agent/pgaSchedule.o agent/pgaStep.o ctl/calbox.o
> ctl/ctlAuiNotebook.o ctl/ctlCheckTreeView.o ctl/ctlColourPicker.o
> ctl/ctlComboBox.o ctl/ctlListView.o ctl/ctlMenuToolbar.o ctl/ctlSQLBox.o
> ctl/ctlSQLGrid.o ctl/ctlSQLResult.o ctl/ctlDefaultSecurityPanel.o
> ctl/ctlSeclabelPanel.o ctl/ctlSecurityPanel.o ctl/ctlTree.o
> ctl/ctlProgressStatusBar.o ctl/explainCanvas.o ctl/explainShape.o
> ctl/timespin.o ctl/xh_calb.o ctl/xh_ctlcolourpicker.o ctl/xh_ctlcombo.o
> ctl/xh_ctlchecktreeview.o ctl/xh_ctltree.o ctl/xh_sqlbox.o
> ctl/xh_timespin.o db/keywords.o db/pgConn.o db/pgSet.o db/pgQueryThread.o
> dd/dditems/figures/ddColumnFigure.o dd/dditems/figures/ddColumnKindIcon.o
> dd/dditems/figures/ddColumnOptionIcon.o
> dd/dditems/figures/ddRelationshipFigure.o
> dd/dditems/figures/ddRelationshipItem.o
> dd/dditems/figures/ddRelationshipTerminal.o
> dd/dditems/figures/ddTableFigure.o
> dd/dditems/figures/ddTextTableItemFigure.o
> dd/dditems/figures/xml/ddXmlStorage.o
> dd/dditems/handles/ddAddColButtonHandle.o
> dd/dditems/handles/ddAddFkButtonHandle.o
> dd/dditems/handles/ddMinMaxTableButtonHandle.o
> dd/dditems/handles/ddRemoveTableButtonHandle.o
> dd/dditems/handles/ddScrollBarHandle.o
> dd/dditems/handles/ddSouthTableSizeHandle.o
> dd/dditems/locators/ddAddColLocator.o dd/dditems/locators/ddAddFkLocator.o
> dd/dditems/locators/ddMinMaxTableLocator.o
> dd/dditems/locators/ddRemoveTableLocator.o
> dd/dditems/locators/ddScrollBarTableLocator.o
> dd/dditems/locators/ddTableBottomLocator.o
> dd/dditems/tools/ddColumnFigureTool.o dd/dditems/tools/ddColumnTextTool.o
> dd/dditems/utilities/ddPrecisionScaleDialog.o
> dd/dditems/utilities/ddSelectKindFksDialog.o
> dd/dditems/utilities/ddTableNameDialog.o dd/ddmodel/ddDatabaseDesign.o
> dd/ddmodel/ddDrawingEditor.o dd/ddmodel/ddDBReverseEnginering.o
> dd/ddmodel/ddModelBrowser.o dd/ddmodel/ddGenerationWizard.o
> dd/ddmodel/ddDrawingView.o dd/ddmodel/ddBrowserDataContainer.o
> debugger/ctlMessageWindow.o debugger/ctlResultGrid.o
> debugger/ctlStackWindow.o debugger/ctlTabWindow.o debugger/ctlVarWindow.o
> debugger/dbgBreakPoint.o debugger/dbgController.o debugger/dbgEvents.o
> debugger/dbgModel.o debugger/dbgTargetInfo.o debugger/debugger.o
> debugger/dlgDirectDbg.o debugger/frmDebugger.o dlg/dlgAddFavourite.o
> dlg/dlgAggregate.o dlg/dlgCast.o dlg/dlgClasses.o dlg/dlgCheck.o
> dlg/dlgCollation.o dlg/dlgColumn.o dlg/dlgConnect.o dlg/dlgConversion.o
> dlg/dlgDatabase.o dlg/dlgDomain.o dlg/dlgEventTrigger.o dlg/dlgExtension.o
> dlg/dlgEditGridOptions.o dlg/dlgFindReplace.o dlg/dlgForeignDataWrapper.o
> dlg/dlgForeignKey.o dlg/dlgForeignServer.o dlg/dlgForeignTable.o
> dlg/dlgFunction.o dlg/dlgGroup.o dlg/dlgHbaConfig.o dlg/dlgIndex.o
> dlg/dlgIndexConstraint.o dlg/dlgLanguage.o dlg/dlgMainConfig.o
> dlg/dlgManageFavourites.o dlg/dlgMoveTablespace.o dlg/dlgOperator.o
> dlg/dlgPackage.o dlg/dlgPgpassConfig.o dlg/dlgProperty.o
> dlg/dlgReassignDropOwned.o dlg/dlgRole.o dlg/dlgRule.o dlg/dlgSchema.o
> dlg/dlgSearchObject.o dlg/dlgSelectConnection.o dlg/dlgSequence.o
> dlg/dlgServer.o dlg/dlgSynonym.o dlg/dlgTable.o dlg/dlgTablespace.o
> dlg/dlgTextSearchConfiguration.o dlg/dlgTextSearchDictionary.o
> dlg/dlgTextSearchParser.o dlg/dlgTextSearchTemplate.o dlg/dlgTrigger.o
> dlg/dlgType.o dlg/dlgUser.o dlg/dlgUserMapping.o dlg/dlgView.o
> dlg/dlgManageMacros.o dlg/dlgExtTable.o dlg/dlgSelectDatabase.o
> dlg/dlgResourceGroup.o frm/events.o frm/frmAbout.o frm/frmBackup.o
> frm/frmBackupGlobals.o frm/frmBackupServer.o frm/frmConfig.o
> frm/frmDatabaseDesigner.o frm/frmEditGrid.o frm/frmExport.o
> frm/frmGrantWizard.o frm/frmHbaConfig.o frm/frmHint.o frm/frmImport.o
> frm/frmMain.o frm/frmMainConfig.o frm/frmMaintenance.o

Re: [pgadmin-hackers] pgAdmin III commit: wxGetTranslation(...) is not supported within wxPLU

2015-09-14 Thread Timon

can't build after this changes
frm/frmQuery.cpp:2891:70: error: 'LwxGetTranslation' was not declared in
this scope
frm/frmQuery.cpp:2926:53: error: 'LwxGetTranslation' was not declared in
this scope
frm/frmQuery.cpp: In member function 'void
frmQuery::OnScriptComplete(wxCommandEvent&)':
frm/frmQuery.cpp:3016:79: error: invalid conversion from 'const char*' to
'wxChar {aka wchar_t}' [-fpermissive]

fedora 22 x64_86

2015-09-14 11:16 GMT+03:00 Ashesh Vashi :

> wxGetTranslation(...) is not supported within wxPLURAL
>
> Branch
> --
> master
>
> Details
> ---
>
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=52345dd957f836c8bd86c7091a68a23c02b9e71b
>
> Modified Files
> --
> pgadmin/frm/frmQuery.cpp |   12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
All bugs reserved

Re: [pgadmin-hackers] pgAdmin III commit: Modify the GNU build system so that it always rebui

2014-06-17 Thread Timon

but after run make git shows pgadmin/ui/xrcDialogs.cpp as modified
and we must run git chekcout pgadmin/ui/xrcDialogs.cpp before each
rebase/commit/etc :(

2014-06-16 13:45 GMT+06:00 Dave Page dp...@pgadmin.org:
 No, because these changes only apply to *nix. We still need the file
 in source control for Windows.

 On Mon, Jun 16, 2014 at 6:52 AM, Timon timo...@gmail.com wrote:
 if xrcDialogs.cpp now rebuilds it should be remove from source and gitignored


 2014-06-11 2:11 GMT+06:00 Dave Page dp...@pgadmin.org:
 Modify the GNU build system so that it always rebuilds xrcdialogs.cpp if
 needed during a make all. This also adds a make xrc target, and as
 a side effect, allows use to call pgadmin/ui/embed-xrc from directories
 other than pgadmin/ui.

 Branch
 --
 master

 Details
 ---
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5cbe791efec2d00a27d0a7ec90f2f41f25368dd8

 Modified Files
 --
 Makefile.am  |5 -
 pgadmin/ui/embed-xrc |   12 +++-
 2 files changed, 15 insertions(+), 2 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers



 --
 All bugs reserved



 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company



-- 
All bugs reserved


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [PATCH] enable OK button when change type name

2013-12-04 Thread Timon

---
 pgadmin/dlg/dlgType.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pgadmin/dlg/dlgType.cpp b/pgadmin/dlg/dlgType.cpp
index 4235a1f..123cada 100644
--- a/pgadmin/dlg/dlgType.cpp
+++ b/pgadmin/dlg/dlgType.cpp
@@ -688,6 +688,7 @@ void dlgType::OnNameChange(wxCommandEvent ev)
cbCanonical-SetSelection(0);
}
}
+   CheckChange();
 }


@@ -798,7 +799,7 @@ void dlgType::CheckChange()

if (type)
{
-   enable = enable  (txtName-GetValue() != type-GetName()
+   enable = enable  (GetName() != type-GetName()
|| txtComment-GetValue() !=
type-GetComment()
|| cbSchema-GetValue() !=
type-GetSchema()-GetName()
|| cbOwner-GetValue() != type-GetOwner()
-- 
1.8.3.1


-- 
All bugs reserved
From 70111dfc6fa76dc06e97c496e01db8019482afa7 Mon Sep 17 00:00:00 2001
From: Timon timo...@gmail.com
Date: Wed, 4 Dec 2013 16:59:49 +0600
Subject: [PATCH] enable OK button when change type name

---
 pgadmin/dlg/dlgType.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pgadmin/dlg/dlgType.cpp b/pgadmin/dlg/dlgType.cpp
index 4235a1f..123cada 100644
--- a/pgadmin/dlg/dlgType.cpp
+++ b/pgadmin/dlg/dlgType.cpp
@@ -688,6 +688,7 @@ void dlgType::OnNameChange(wxCommandEvent ev)
 			cbCanonical-SetSelection(0);
 		}
 	}
+	CheckChange();
 }
 
 
@@ -798,7 +799,7 @@ void dlgType::CheckChange()
 
 	if (type)
 	{
-		enable = enable  (txtName-GetValue() != type-GetName()
+		enable = enable  (GetName() != type-GetName()
 		|| txtComment-GetValue() != type-GetComment()
 		|| cbSchema-GetValue() != type-GetSchema()-GetName()
 		|| cbOwner-GetValue() != type-GetOwner()
-- 
1.8.3.1


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Russian translation

2013-08-30 Thread Timon

cool, I'm lucky guy. :)

2013/8/30 Dave Page dp...@pgadmin.org:
 Looks like you're in luck - I found an issue I'm going to have to
 rewrap for, so I'll commit this too. :-)

 On Fri, Aug 30, 2013 at 11:42 AM, Dave Page dp...@pgadmin.org wrote:
 Sorry - I've just wrapped and tagged :-(. We'll get it updated for the
 next update though.

 Thanks.

 On Fri, Aug 30, 2013 at 11:40 AM, Timon timo...@gmail.com wrote:
 I hope it is not too late...

 --
 All bugs reserved


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers




 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company



 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company



-- 
All bugs reserved


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgadmin-support] bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane

2013-06-20 Thread Timon

i have tested it already, and it works great. Both problems are solved.
Thank you for your work :)

2013/6/20 Ashesh Vashi ashesh.va...@enterprisedb.com

Hi Timon,

I've sent patch to Dave (and, pgadmin-hackers) and he already checked-in.

Can you please confirm both the behavior with the latest code?
(1. Repeated messages and 2. Cancellation on Query Execution)

If you can spend some time, that will be very helpful.

On Tue, Jun 18, 2013 at 2:16 PM, Ashesh Vashi
ashesh.va...@enterprisedb.com wrote:

Thanks Timon for point out.
I already know about this - I've made that mistake and will resolve it
very soon.
Made some changes in pgQueryThread class, which leads to this bug.

Actually - I was busy with some other stuff, and couldn't spend time on
pgadmin3.

On Tue, Jun 18, 2013 at 2:05 PM, Timon timo...@gmail.com wrote:

seems that commit 140e8aee4cb5d423bb76ad81874e442d3e17b5c1 (Rewrite
the debugger to resolve numerous known issues and instabilities mostly
due to the threading code.) also broke ability to cancel query by
pressing stop button in query editor

2013/5/16 Dave Page dp...@pgadmin.org:
Ashesh - this appears to be related to the debugger changes. Can you
take a look please?

Thanks.

On Thu, May 16, 2013 at 2:07 PM, Gabriele Franch fra...@fbk.eu
wrote:
Hello,
I'm using pgadmin 1.18.0 Alpha 1 (compiled from

http://ftp.postgresql.org/pub/pgadmin3/release/v1.18.0-alpha1/src/pgadmin3-1.18.0-alpha1.tar.gz
).

Messages are repeated multiple times in messages pane. Version 1.16.1
does not expose this behavior.

Example SQL:

DROP FUNCTION IF EXISTS raise_something () CASCADE;
CREATE OR REPLACE FUNCTION raise_something ()
RETURNS VOID AS
$BODY$
BEGIN
RAISE WARNING 'Something';
RAISE NOTICE 'Something else';
END
$BODY$
LANGUAGE plpgsql;

select * from raise_something();

Gabriele Franch

--
Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org
)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

--
All bugs reserved

Thanks Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL
Companyhttp://www.enterprisedb.com

*http://www.linkedin.com/in/asheshvashi*

Thanks Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.enterprisedb.com

*http://www.linkedin.com/in/asheshvashi*

--
All bugs reserved

[pgadmin-hackers] Re: [pgadmin-support] bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane

2013-06-18 Thread Timon

seems that commit 140e8aee4cb5d423bb76ad81874e442d3e17b5c1 (Rewrite
the debugger to resolve numerous known issues and instabilities mostly
due to the threading code.) also broke ability to cancel query by
pressing stop button in query editor

2013/5/16 Dave Page dp...@pgadmin.org:
 Ashesh - this appears to be related to the debugger changes. Can you
 take a look please?

 Thanks.

 On Thu, May 16, 2013 at 2:07 PM, Gabriele Franch fra...@fbk.eu wrote:
 Hello,
 I'm using pgadmin 1.18.0 Alpha 1 (compiled from
 http://ftp.postgresql.org/pub/pgadmin3/release/v1.18.0-alpha1/src/pgadmin3-1.18.0-alpha1.tar.gz).

 Messages are repeated multiple times in messages pane. Version 1.16.1
 does not expose this behavior.

 Example SQL:

 DROP FUNCTION IF EXISTS raise_something () CASCADE;
 CREATE OR REPLACE FUNCTION raise_something ()
 RETURNS VOID AS
 $BODY$
 BEGIN
  RAISE WARNING 'Something';
  RAISE NOTICE 'Something else';
 END
 $BODY$
 LANGUAGE plpgsql;

 select * from raise_something();

 Gabriele Franch

 --
 Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-support



 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 --
 Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-support



-- 
All bugs reserved


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Prevent Cmd+S adding characters to the Query Tool w

2013-01-29 Thread Timon

little patch which prevents a crash when opens query editor

2013/1/24 Dave Page dp...@pgadmin.org:
 Prevent Cmd+S adding characters to the Query Tool when the Save button is 
 disabled.

 Branch
 --
 master

 Details
 ---
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=43fe3ac8d0c75dc87945dbd8321f5771e6674988

 Modified Files
 --
 CHANGELOG|2 ++
 pgadmin/frm/frmQuery.cpp |   21 +++--
 2 files changed, 13 insertions(+), 10 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers



-- 
All bugs reserved


0001-fix-crash.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] wrong spelling?

2012-12-03 Thread Timon

I'm not good at English, but seem that there is a mistake.

diff --git a/pgadmin/frm/frmQuery.cpp b/pgadmin/frm/frmQuery.cpp
index 7c4d1e2..1145147 100644
--- a/pgadmin/frm/frmQuery.cpp
+++ b/pgadmin/frm/frmQuery.cpp
@@ -2478,7 +2478,7 @@ void frmQuery::OnQueryComplete(wxCommandEvent ev)
}
else if (sqlResult-RunStatus() == PGRES_EMPTY_QUERY)
{
-   showMessage(_(Empty query, not results.));
+   showMessage(_(Empty query, no results.));
}
else
{

-- 
All bugs reserved

Re: [pgadmin-hackers] pgAdmin III commit: Fix dropping of constraints

2012-11-07 Thread Timon

crash after index rename

stacktrace
Thread 1 (Thread 0x77faea00 (LWP 13198)):
#0  0x00576d51 in dlgIndex::GetSql() ()
No symbol table info available.
#1  0x00590e56 in dlgProperty::OnOK(wxCommandEvent) ()
No symbol table info available.
#2  0x003f0b8e6796 in ProcessEventIfMatches (event=...,
handler=optimized out, entry=...) at src/common/event.cpp:1239
No locals.
#3  wxEvtHandler::ProcessEventIfMatches (entry=..., handler=optimized
out, event=...) at src/common/event.cpp:1214
No locals.



2012/11/1 Dave Page dp...@pgadmin.org

 Fix dropping of constraints

 Branch
 --
 master

 Details
 ---

 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e92f6be2c2872e85049a54f4b06613f9dd242b3b
 Author: Akshay Joshi akshay.jo...@enterprisedb.com

 Modified Files
 --
 CHANGELOG   |1 +
 pgadmin/schema/pgCheck.cpp  |2 +-
 pgadmin/schema/pgDomain.cpp |2 +-
 pgadmin/schema/pgForeignKey.cpp |2 +-
 pgadmin/schema/pgIndex.cpp  |8 
 5 files changed, 8 insertions(+), 7 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers




-- 
All bugs reserved

Re: [pgadmin-hackers] [pgadmin-support] pgadmin crash - editing function body

2012-09-21 Thread Timon

yup, it chrashes. I can reproduce it on my Fedora linux box with
postgresql-9.1.5-2.fc17.x86_64
wxGTK-2.8.12-4.fc17.x86_64
gcc-4.7.0-5.fc17.x86_64
glibc-2.15-57.fc17.x86_64

pgadmin compiled from git 1_16 branch

here is stack trace

Thread 1 (Thread 0x77fafa00 (LWP 5492)):
#0  0x0058c2f5 in dlgProperty::GetName() ()
No symbol table info available.
#1  0x00564e9d in dlgFunction::CheckChange() ()
No symbol table info available.
#2  0x0036ccee6796 in ProcessEventIfMatches (event=...,
handler=optimized out, entry=...) at src/common/event.cpp:1239
No locals.
#3  wxEvtHandler::ProcessEventIfMatches (entry=..., handler=optimized
out, event=...) at src/common/event.cpp:1214
No locals.
#4  0x0036ccee6904 in wxEventHashTable::HandleEvent
(this=optimized out, event=..., self=self@entry=0x23c3820) at
src/common/event.cpp:906
n = optimized out
eventEntryTable = @0x2495468: {wxBaseArrayPtrVoid = {m_nSize
= 1, m_nCount = 1, m_pItems = 0x2495340}, No data fields}
count = 1
eventType = optimized out
eTTnode = 0x2495460
#5  0x0036ccee6c27 in ProcessEvent (event=..., this=0x23c3820) at
src/common/event.cpp:1301
No locals.
#6  wxEvtHandler::ProcessEvent (this=0x23c3820, event=...) at
src/common/event.cpp:1272
No locals.

full stacktrace in attachment


2012/9/21 Guillaume Lelarge guilla...@lelarge.info:
 On Thu, 2012-09-20 at 17:14 +0400, Vjacheslav A. wrote:
 I have the same bug in editor,
 I open function body (Apply and Ok button are always active),
 if I click to Apply and then do copy/paste operation - pgAdmin crashes.


 Well, if anyone finds a way to reproduce this, I'm interested to know
 how.


 --
 Guillaume
 http://blog.guillaume.lelarge.info
 http://www.dalibo.com



 --
 Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-support



-- 
All bugs reserved


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgadmin-support] pgadmin crash - editing function body

2012-09-21 Thread Timon

and attach :)
Thread 1 (Thread 0x77fafa00 (LWP 5492)):
#0  0x0058c2f5 in dlgProperty::GetName() ()
No symbol table info available.
#1  0x00564e9d in dlgFunction::CheckChange() ()
No symbol table info available.
#2  0x0036ccee6796 in ProcessEventIfMatches (event=..., handler=optimized 
out, entry=...) at src/common/event.cpp:1239
No locals.
#3  wxEvtHandler::ProcessEventIfMatches (entry=..., handler=optimized out, 
event=...) at src/common/event.cpp:1214
No locals.
#4  0x0036ccee6904 in wxEventHashTable::HandleEvent (this=optimized out, 
event=..., self=self@entry=0x23c3820) at src/common/event.cpp:906
n = optimized out
eventEntryTable = @0x2495468: {wxBaseArrayPtrVoid = {m_nSize = 1, 
m_nCount = 1, m_pItems = 0x2495340}, No data fields}
count = 1
eventType = optimized out
eTTnode = 0x2495460
#5  0x0036ccee6c27 in ProcessEvent (event=..., this=0x23c3820) at 
src/common/event.cpp:1301
No locals.
#6  wxEvtHandler::ProcessEvent (this=0x23c3820, event=...) at 
src/common/event.cpp:1272
No locals.
#7  0x0036d82d3519 in wxWindowBase::TryParent (this=optimized out, 
event=...) at src/common/wincmn.cpp:2661
propagateOnce = {m_event = @0x7fffc690}
parent = optimized out
#8  0x0036d82d3519 in wxWindowBase::TryParent (this=optimized out, 
event=...) at src/common/wincmn.cpp:2661
propagateOnce = {m_event = @0x7fffc690}
parent = optimized out
#9  0x0036d82d3519 in wxWindowBase::TryParent (this=optimized out, 
event=...) at src/common/wincmn.cpp:2661
propagateOnce = {m_event = @0x7fffc690}
parent = optimized out
#10 0x0036cba48590 in wxStyledTextCtrl::NotifyParent (this=0x23df450, 
_scn=optimized out) at ./stc.cpp:3348
scn = optimized out
evt = {wxCommandEvent = {wxEvent = {wxObject = {_vptr.wxObject = 
0x36cbd09570, static ms_classInfo = {m_className = 0x0, 
  m_objectSize = 0, m_objectConstructor = 0, m_baseInfo1 = 0x0, 
m_baseInfo2 = 0x0, static sm_first = 0x0, m_next = 0x0, 
  static sm_classTable = 0xe388b0}, m_refData = 0x0}, 
m_eventObject = 0x23df450, m_eventType = 10284, m_timeStamp = 0, m_id = 
217, m_callbackUserData = 0x0, m_propagationLevel = 2147483644, m_skipped = 
false, m_isCommandEvent = true, static ms_classInfo = {
m_className = 0x36ccf0c768 LwxEvent, m_objectSize = 64, 
m_objectConstructor = 0, m_baseInfo1 = 0xdedbc0, m_baseInfo2 = 0x0, 
static sm_first = 0x0, m_next = 0x36cd157500, static 
sm_classTable = 0xe388b0}}, m_commandString = {m_evt = 0x7fffc690}, 
m_cmdString = {wxStringBase = {static npos = 
18446744073709551615, m_pchData = 0x36ccf07998 L}, No data fields}, 
m_commandInt = 
0, m_extraLong = 0, m_clientData = 0x0, m_clientObject = 0x0, static 
ms_classInfo = {m_className = 0x36d8310ab0 LwxCommandEvent, 
  m_objectSize = 112, m_objectConstructor = 0x36d81d88a0 
wxCommandEvent::wxCreateObject(), m_baseInfo1 = 0x36cd1574c0, 
  m_baseInfo2 = 0x0, static sm_first = 0x0, m_next = 0x36d85f2400, 
static sm_classTable = 0xe388b0}}, static ms_classInfo = {
   0x36cba489f0 wxStyledTextEvent::wxCreateObject(), m_baseInfo1 = 
0x36d85f23c0, m_baseInfo2 = 0x0, static sm_first = 0x0, m_next = 0xde47e0, 
static sm_classTable = 0xe388b0}, m_position = 152, m_key = 0, 
m_modifiers = 0, m_modificationType = 1040, m_text = {wxStringBase = 
{static npos = 18446744073709551615, m_pchData = 0x2422c88 L\n}, No data 
fields}, m_length = 168, m_linesAdded = 0, m_line = 0, 
  m_foldLevelNow = 0, m_foldLevelPrev = 0, m_margin = 0, m_message = 0, 
m_wParam = 0, m_lParam = 0, m_listType = 0, m_x = 0, m_y = 0, 
  m_dragText = {wxStringBase = {static npos = 18446744073709551615, 
m_pchData = 0x36ccf07998 L}, No data fields}, m_dragAllowMove = 
false, m_dragResult = wxDragNone}
#11 0x0036cba3f295 in ScintillaWX::NotifyParent (this=optimized out, 
scn=...) at ./ScintillaWX.cpp:477
No locals.
#12 0x0036cba5d30c in Editor::NotifyModified (this=0x253e800, mh=...) at 
scintilla/src/Editor.cxx:3863
scn = {nmhdr = {hwndFrom = 0x0, idFrom = 0, code = 2008}, position = 
152, ch = 0, modifiers = 0, modificationType = 1040, text = 
0x2376910 \n, length = 168, linesAdded = 0, message = 0, wParam = 0, 
lParam = 0, line = 0, foldLevelNow = 0, foldLevelPrev = 0, margin = 0, 
  listType = 0, x = 0, y = 0}
#13 0x0036cba4fcd2 in Document::NotifyModified (this=this@entry=0x25438e0, 
mh=...) at scintilla/src/Document.cxx:1412
i = optimized out
#14 0x0036cba505ca in Document::InsertStyledString 
(this=this@entry=0x25438e0, position=position@entry=304, s=s@entry=0x2376910 
\n, 
insertLength=336) at scintilla/src/Document.cxx:415
prevLinesTotal = optimized out
startSavePoint = optimized out
text = optimized out
#15 0x0036cba50753 in InsertString

[pgadmin-hackers] [PATCH] Fix column SQL

2012-08-23 Thread Timon

attached patch fixes SQL of column in SQL pane.
sql should be like
ALTER TABLE table ADD COLUMN tms timestamp without time zone NOT NULL
DEFAULT now();
and not
ALTER TABLE table ADD COLUMN tms timestamp without time zone;
ALTER TABLE table ALTER COLUMN tms SET NOT NULL;
ALTER TABLE table ALTER COLUMN tms SET DEFAULT now();

it avoids not null constraint problem when you add column to existing
table with some data

-- 
All bugs reserved


0001-Fix-column-SQL.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-support] [pgadmin-hackers] [PATCH] Fix column SQL

2012-08-23 Thread Timon

maybe we should show this script as comment in sql pane? like DROP column sql

2012/8/23 Dave Page dp...@pgadmin.org:
 On Thu, Aug 23, 2012 at 9:33 AM, Timon timo...@gmail.com wrote:
 I found it
 http://archives.postgresql.org/pgadmin-support/2012-07/msg7.php

 Yeah, that was the most recent one (though, that was really about the
 generate script options), but I'm sure there was something
 previously.

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company



-- 
All bugs reserved


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Lots of work on domains, and check constraints

2012-08-16 Thread Timon

I tested this patch. It fixes my problem.
Also it fixes one annoying crash when you click on indexes list.
thanks for you work :)

2012/7/21 Guillaume Lelarge guilla...@lelarge.info:
 On Wed, 2012-06-06 at 10:50 +0600, Timon wrote:
 seems that this commit broke reindexing of selected index. steps to 
 reproduce:
 1) create table
 2) create index
 3) select index in object inspector
 4) try to reindex it via maintenance menu item
 5) got error : ERROR:  schema table_name does not exist

 and one more crash here
 .. same steps as before
 4) try to CLUSTER index
 5) pgadmin simply crashed


 OK, I finally got some time to work on this. As Timon said, these bugs
 come from the patch Lots of work on domains, and check constraints. In
 this patch, I changed some objects parent class from pgTableObject to
 pgSchemaObject. Due to this change, the GetTable() method returns NULL,
 which segfaults all statements that try to use the return value without
 checking. The two examples above from Timon are exactly this.

 I don't see many ways to get out of this issue.

 We could use GetSchema() instead of GetTable(). It works, it's an easy
 and small patch. But it'll certainly be a maintenance nightmare (at
 least without any comments)

 We could also revert my patch. It's simple, we loose the feature of
 adding as many check constraints as we want to a domain, we loose the
 feature of renaming and validating constraints, and we gain a few bugs.

 I don't see any other options. My own personal choice would be the first
 one (see attached patch). But it's a tough call.

 Comments?


 --
 Guillaume
 http://blog.guillaume.lelarge.info
 http://www.dalibo.com



-- 
All bugs reserved


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Lots of work on domains, and check constraints

2012-08-16 Thread Timon

and, one more little bug
altering index fillfactor produces wrong sql code
steps to reproduce:

1. create table
2. add index
3. chage fillfactor on created index
4. got error like scheme name table name doesn't exists
example of sql: ALTER INDEX gallery.idx_gallery_regionid_itemiddesc
  SET (FILLFACTOR=80);
gallery is the table name

2012/8/17 Timon timo...@gmail.com:
 I tested this patch. It fixes my problem.
 Also it fixes one annoying crash when you click on indexes list.
 thanks for you work :)

 2012/7/21 Guillaume Lelarge guilla...@lelarge.info:
 On Wed, 2012-06-06 at 10:50 +0600, Timon wrote:
 seems that this commit broke reindexing of selected index. steps to 
 reproduce:
 1) create table
 2) create index
 3) select index in object inspector
 4) try to reindex it via maintenance menu item
 5) got error : ERROR:  schema table_name does not exist

 and one more crash here
 .. same steps as before
 4) try to CLUSTER index
 5) pgadmin simply crashed


 OK, I finally got some time to work on this. As Timon said, these bugs
 come from the patch Lots of work on domains, and check constraints. In
 this patch, I changed some objects parent class from pgTableObject to
 pgSchemaObject. Due to this change, the GetTable() method returns NULL,
 which segfaults all statements that try to use the return value without
 checking. The two examples above from Timon are exactly this.

 I don't see many ways to get out of this issue.

 We could use GetSchema() instead of GetTable(). It works, it's an easy
 and small patch. But it'll certainly be a maintenance nightmare (at
 least without any comments)

 We could also revert my patch. It's simple, we loose the feature of
 adding as many check constraints as we want to a domain, we loose the
 feature of renaming and validating constraints, and we gain a few bugs.

 I don't see any other options. My own personal choice would be the first
 one (see attached patch). But it's a tough call.

 Comments?


 --
 Guillaume
 http://blog.guillaume.lelarge.info
 http://www.dalibo.com



 --
 All bugs reserved



-- 
All bugs reserved


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] typo?

2012-07-25 Thread Timon

is this type mistake?

pgadmin/dlg/dlgSearchObject.cpp
81: aMap[_(FTS Dictionarie)] = wxT(FTS Dictionaries);


patch

--- pgadmin/dlg/dlgSearchObject.cpp.orig2012-07-25 14:53:23.212893488 
+0600
+++ pgadmin/dlg/dlgSearchObject.cpp 2012-07-25 14:53:32.134771027 +0600
@@ -78,7 +78,7 @@
aMap[_(Login Roles)] = wxT(Login Roles);
aMap[_(Group Roles)] = wxT(Group Roles);
aMap[_(FTS Configurations)] = wxT(FTS Configurations);
-   aMap[_(FTS Dictionarie)] = wxT(FTS Dictionaries);
+   aMap[_(FTS Dictionaries)] = wxT(FTS Dictionaries);
aMap[_(FTS Parsers)] = wxT(FTS Parsers);
aMap[_(FTS Templates)] = wxT(FTS Templates);
aMap[_(Foreign Data Wrappers)] = wxT(Foreign Data Wrappers);


-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Lots of work on domains, and check constraints

2012-06-05 Thread Timon

seems that this commit broke reindexing of selected index. steps to reproduce:
1) create table
2) create index
3) select index in object inspector
4) try to reindex it via maintenance menu item
5) got error : ERROR:  schema table_name does not exist

and one more crash here
.. same steps as before
4) try to CLUSTER index
5) pgadmin simply crashed

2012/5/1 Guillaume Lelarge guilla...@lelarge.info:
 Lots of work on domains, and check constraints

 Check constraints on domains are now sub-nodes. A user can add as many check
 constraints as he wants. He can rename and validate them on 9.2. He can add
 a not-yet-valid check constraint. He can also add a NO INHERIT check 
 constraint
 on a new table.

 Branch
 --
 master

 Details
 ---
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=02b60e5a8b4f6c3cfafca1b93eff4833ddc7ae4f

 Modified Files
 --
 pgadmin/dlg/dlgCheck.cpp                   |   44 --
 pgadmin/dlg/dlgDomain.cpp                  |  214 ++--
 pgadmin/dlg/dlgProperty.cpp                |   13 +-
 pgadmin/frm/events.cpp                     |    8 +-
 pgadmin/include/dlg/dlgCheck.h             |    6 +-
 pgadmin/include/dlg/dlgDomain.h            |    6 +
 pgadmin/include/schema/pgCheck.h           |   42 --
 pgadmin/include/schema/pgConstraints.h     |   10 +-
 pgadmin/include/schema/pgDomain.h          |    1 +
 pgadmin/include/schema/pgForeignKey.h      |    6 +-
 pgadmin/include/schema/pgIndex.h           |   14 +-
 pgadmin/include/schema/pgIndexConstraint.h |   16 +-
 pgadmin/include/utils/misc.h               |    1 +
 pgadmin/schema/pgCheck.cpp                 |   80 +++
 pgadmin/schema/pgConstraints.cpp           |   51 +---
 pgadmin/schema/pgDomain.cpp                |   95 -
 pgadmin/schema/pgForeignKey.cpp            |   15 ++-
 pgadmin/schema/pgIndex.cpp                 |   28 ++--
 pgadmin/schema/pgTable.cpp                 |    2 +
 pgadmin/ui/dlgCheck.xrc                    |   14 ++
 pgadmin/ui/dlgDomain.xrc                   |   95 -
 21 files changed, 517 insertions(+), 244 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers



-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Support for security labels on global objects

2011-08-02 Thread Timon

pgadmin crashes after createing second table.
steps to reproduce:
1) run pgadmin
2) create table (empty table t1, for example)
3) create one more table (empty table t2, etc...)
4) catch the crash

git bisect points to this commit

gcc-4.6.0-10.fc15.x86_64
postgresql 9.0.4


2011/7/25 Guillaume Lelarge guilla...@lelarge.info:
 Support for security labels on global objects

 This is to support a 9.2 feature of PostgreSQL. It adds a new tab to
 databases, roles, and tablespaces dialogs, that allows one to add security
 label for each provider they want. I suppose most users will have only one
 provider, but the patch supports multi providers.

 Branch
 --
 master

 Details
 ---
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=76b9514bf29ad3b8f5a23197155014147fb839ea

 Modified Files
 --
 pgadmin/dlg/dlgDatabase.cpp         |   24 
 pgadmin/dlg/dlgRole.cpp             |   29 +
 pgadmin/dlg/dlgTablespace.cpp       |   31 ++-
 pgadmin/include/dlg/dlgDatabase.h   |    4 
 pgadmin/include/dlg/dlgRole.h       |    4 
 pgadmin/include/dlg/dlgTablespace.h |    4 
 pgadmin/schema/pgDatabase.cpp       |   30 --
 pgadmin/schema/pgRole.cpp           |   25 +
 pgadmin/schema/pgTablespace.cpp     |   30 +-
 9 files changed, 169 insertions(+), 12 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Rename Replication to Slony Replication

2011-06-26 Thread Timon

and now you should update pgadmin3.pot file :) cause translator are
preparing translation for new release :)

2011/6/26 Magnus Hagander mag...@hagander.net:
 Rename Replication to Slony Replication

 Also change Use Replication to Use Slony in dialogs, to make
 it more clear that it's about Slony and not the builtin replication.

 Branch
 --
 REL-1_14_0_PATCHES

 Details
 ---
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bd9fd9b20284b28e5090fd78e3d283ab046c0bc4

 Modified Files
 --
 CHANGELOG                                 |    3 +
 docs/en_US/pgadmin3.hhp.cached            |  Bin 2453 - 2567 bytes
 docs/en_US/slony-example.html             |    4 +-
 pgadmin/frm/frmMain.cpp                   |    2 +-
 pgadmin/slony/slCluster.cpp               |    2 +-
 pgadmin/ui/dlgAggregate.xrc               |    2 +-
 pgadmin/ui/dlgCast.xrc                    |    2 +-
 pgadmin/ui/dlgCheck.xrc                   |    2 +-
 pgadmin/ui/dlgCollation.xrc               |    2 +-
 pgadmin/ui/dlgColumn.xrc                  |    2 +-
 pgadmin/ui/dlgConversion.xrc              |    2 +-
 pgadmin/ui/dlgDomain.xrc                  |    2 +-
 pgadmin/ui/dlgExtTable.xrc                |    2 +-
 pgadmin/ui/dlgExtension.xrc               |    2 +-
 pgadmin/ui/dlgForeignDataWrapper.xrc      |    2 +-
 pgadmin/ui/dlgForeignKey.xrc              |    2 +-
 pgadmin/ui/dlgForeignServer.xrc           |    2 +-
 pgadmin/ui/dlgForeignTable.xrc            |    2 +-
 pgadmin/ui/dlgFunction.xrc                |    2 +-
 pgadmin/ui/dlgGroup.xrc                   |    2 +-
 pgadmin/ui/dlgIndex.xrc                   |    2 +-
 pgadmin/ui/dlgIndexConstraint.xrc         |    2 +-
 pgadmin/ui/dlgLanguage.xrc                |    2 +-
 pgadmin/ui/dlgOperator.xrc                |    2 +-
 pgadmin/ui/dlgPackage.xrc                 |    2 +-
 pgadmin/ui/dlgRole.xrc                    |    2 +-
 pgadmin/ui/dlgRule.xrc                    |    2 +-
 pgadmin/ui/dlgSchema.xrc                  |    2 +-
 pgadmin/ui/dlgSequence.xrc                |    2 +-
 pgadmin/ui/dlgSynonym.xrc                 |    2 +-
 pgadmin/ui/dlgTable.xrc                   |    2 +-
 pgadmin/ui/dlgTextSearchConfiguration.xrc |    2 +-
 pgadmin/ui/dlgTextSearchDictionary.xrc    |    2 +-
 pgadmin/ui/dlgTextSearchParser.xrc        |    2 +-
 pgadmin/ui/dlgTextSearchTemplate.xrc      |    2 +-
 pgadmin/ui/dlgTrigger.xrc                 |    2 +-
 pgadmin/ui/dlgType.xrc                    |    2 +-
 pgadmin/ui/dlgUser.xrc                    |    2 +-
 pgadmin/ui/dlgUserMapping.xrc             |    2 +-
 pgadmin/ui/dlgView.xrc                    |    2 +-
 pgadmin/ui/xrcDialogs.cpp                 |68529 ++---
 41 files changed, 34304 insertions(+), 34306 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] wrong sql code for fk covering index

2011-06-16 Thread Timon

When trying to create covering index for existing fk constrain by
checking checkbox in dialog, pgadmin 1.14 (latest git) generates wrong
code for postgresql 9.0.

ALTER TABLE hotels VALIDATE CONSTRAINT hotels_city_id_fkey;
CREATE INDEX fki_hotels_cityid ON hotels(city_id);

postgresql 9.0 doesn't know about VALIDATE keyword.
-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Ask to reset connection in the query tool

2011-05-04 Thread Timon

hmm, seem that it asks about reconnection even when query has syntax error

from messages tab:
ERROR:  syntax error at or near to
СТРОКА 3:  substring(sender from 1 to 11),
   ^
** Ошибка **
ERROR: syntax error at or near to
SQL state: 42601
Символ: 52

2011/5/4 Guillaume Lelarge guilla...@lelarge.info

 Ask to reset connection in the query tool

 If a query fails because of a bad connection, the query tool will ask the
 user
 if he wants an automatic reset. If yes, it'll try to reset the connection.

 Branch
 --
 master

 Details
 ---

 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7cbb6b50b7a9524b6a19323fcee79be4af29a479

 Modified Files
 --
 CHANGELOG   |1 +
 pgadmin/db/pgConn.cpp   |6 ++
 pgadmin/frm/frmQuery.cpp|   24 +++-
 pgadmin/include/db/pgConn.h |2 ++
 4 files changed, 28 insertions(+), 5 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers




-- 
All bugs reserved

Re: [pgadmin-hackers] Segfault on property dialog for the index.

2011-04-29 Thread Timon

 I did. And you're completely right. Your patch fixed the issue. I
 suppose Timon had the same issue. Too bad it won't be in beta 1.
 Anyways, thanks for your patch.
Yup, it solves my problem. Thanks.

-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Add the support for per-column collation feature

2011-04-27 Thread Timon

tested with latest git version. still crashes :(
gcc-4.6.0-5.fc15.x86_64
wxGTK-2.8.12-1.fc15.x86_64

2011/4/27 Guillaume Lelarge guilla...@lelarge.info:
 Le 26/04/2011 16:57, Timon a écrit :
 this commit broke index properties dialog. pgadmin simply crashes.
 steps to reproduce:
 1. create index or use existing index
 2. open index properties dialog
 3. catch a crash


 I have no crash while doing this. I can create and edit indexes with
 PostgreSQL 9.1 and 9.0. When was the last time you did a git pull?


 --
 Guillaume
  http://www.postgresql.fr
  http://dalibo.com




--
All bugs reserved



-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Add the support for per-column collation feature

2011-04-26 Thread Timon

this commit broke index properties dialog. pgadmin simply crashes.
steps to reproduce:
1. create index or use existing index
2. open index properties dialog
3. catch a crash

stacktrace:

#0  wxStringBase::operator= (this=0x7fffc0d8, stringSrc=...) at
src/common/string.cpp:778
No locals.
#1  0x76e6e246 in operator= (this=0x7fffc0d8) at
include/wx/string.h:659
No locals.
#2  wxGenericListCtrl::SetItem (this=0x18fa1d0, index=0, col=4,
label=optimized out, imageId=-1)
at src/generic/listctrl.cpp:5237
info = warning: can't find linker symbol for virtual table for
`wxListItem' value
{wxObject = {_vptr.wxObject = 0xce07d0, static ms_classInfo =
{m_className = 0x0, m_objectSize = 0,
  m_objectConstructor = 0, m_baseInfo1 = 0x0, m_baseInfo2
= 0x0, static sm_first = 0x0, m_next = 0x0,
  static sm_classTable = 0xd2b010}, m_refData = 0x0},
m_mask = 0, m_itemId = 0, m_col = 0, m_state = 0,
  m_stateMask = 0, m_text = {wxStringBase = {static npos =
18446744073709551615, m_pchData =
0x3e87d07cd8 L}, No data fields}, m_image = -1, m_data = 0,
m_format = 2, m_width = 0, m_attr = 0x0,
  static ms_classInfo = {m_className = 0x76f691d8
LwxListItem, m_objectSize = 96, m_objectConstructor =
0x76e60c40 wxListItem::wxCreateObject(), m_baseInfo1 =
0xce5de0, m_baseInfo2 = 0x0, static sm_first = 0x0,
m_next = 0x77245ae0, static sm_classTable = 0xd2b010}}
#3  0x0051741a in dlgIndex::Go(bool) ()
No symbol table info available.
#4  0x005315ef in dlgProperty::EditObjectDialog(frmMain*,
ctlSQLBox*, pgObject*) ()
No symbol table info available.
#5  0x005317e3 in propertyFactory::StartDialog(frmMain*, pgObject*) ()
No symbol table info available.
#6  0x00597550 in frmMain::OnAction(wxCommandEvent) ()
No symbol table info available.
#7  0x003e87ce6b15 in wxEvtHandler::ProcessEventIfMatches
(entry=optimized out, handler=optimized out, event=
...) at src/common/event.cpp:1239
tableId1 = optimized out
tableId2 = optimized out
#8  0x003e87ce6edf in wxEvtHandler::SearchDynamicEventTable
(this=0x1733000, event=...)
handler = optimized out
entry = optimized out
node = {m_ptr = 0x18812d0}
#9  0x003e87ce6f92 in ProcessEvent (event=..., this=0x1733000) at
src/common/event.cpp:1297
No locals.
#10 wxEvtHandler::ProcessEvent (this=0x1733000, event=...) at
src/common/event.cpp:1272
No locals.
#11 0x003e87ce6f50 in ProcessEvent (event=..., this=0x17333b0) at
src/common/event.cpp:1308
No locals.
#12 wxEvtHandler::ProcessEvent (this=0x17333b0, event=...) at
src/common/event.cpp:1272
No locals.
#13 0x76f22b49 in wxWindowBase::TryParent (this=optimized
out, event=...) at src/common/wincmn.cpp:2661
propagateOnce = {m_event = @0x7fffc580}
parent = optimized out
#14 0x003e87ce6f50 in ProcessEvent (event=..., this=0x17f2530) at
src/common/event.cpp:1308
No locals.
#15 wxEvtHandler::ProcessEvent (this=0x17f2530, event=...) at
src/common/event.cpp:1272
No locals.
#16 0x76f4c6b5 in wxScrollHelperEvtHandler::ProcessEvent
(this=0x17f2530, event=optimized out)
at src/generic/scrlwing.cpp:208
evType = 10010
processed = optimized out
#17 0x76f0334d in wxMenuBase::SendEvent (this=optimized out,
id=optimized out, checked=optimized out)
at src/common/menucmn.cpp:792
win = optimized out
menu = optimized out
event = warning: can't find linker symbol for virtual table
for `wxCommandEvent' value
{wxEvent = {wxObject = {_vptr.wxObject = 0xceadf0, static
ms_classInfo = {m_className = 0x0,
m_objectSize = 0, m_objectConstructor = 0, m_baseInfo1
= 0x0, m_baseInfo2 = 0x0, static sm_first =
 0x0, m_next = 0x0, static sm_classTable = 0xd2b010}, m_refData =
0x0}, m_eventObject = 0x1a1b890, m_eventType =
10010, m_timeStamp = 0, m_id = 1278, m_callbackUserData = 0x0,
m_propagationLevel = 2147483646, m_skipped =
false, m_isCommandEvent = true, static ms_classInfo = {m_className
= 0x3e87d0caa8 LwxEvent, m_objectSize = 64,
  m_objectConstructor = 0, m_baseInfo1 = 0xce5de0,
m_baseInfo2 = 0x0, static sm_first = 0x0, m_next =
0x3e87f57580, static sm_classTable = 0xd2b010}}, m_commandString =
{m_evt = 0x7fffc580}, m_cmdString =
{wxStringBase = {static npos = 18446744073709551615, m_pchData =
0x3e87d07cd8 L}, No data fields},
  m_commandInt = -1, m_extraLong = 0, m_clientData = 0x0,
m_clientObject = 0x0, static ms_classInfo = {
m_className = 0x76f63a70 LwxCommandEvent,
m_objectSize = 112, m_objectConstructor =
0x76e1e9b0 wxCommandEvent::wxCreateObject(), m_baseInfo1 =
0x3e87f57540, m_baseInfo2 = 0x0,
static sm_first = 0x0, m_next = 0x772446a0, static
sm_classTable = 0xd2b010}}
processed = optimized out
#18 0x76e9f2e4 in gtk_menu_clicked_callback (widget=optimized
out, menu=0x1a1b890) at

Re: [pgadmin-hackers] strings fixes

2011-04-12 Thread Timon

Just one more little fix in attachment :)
keyrs - keys

2011/4/7 Dave Page dp...@pgadmin.org:
 Thanks, patch applied.

 On Thu, Apr 7, 2011 at 11:03 AM, Timon timo...@gmail.com wrote:
 In some files I found strings like this:
 Are you sure you wish to drop column \%s?\
 but they should be like this
 Are you sure you wish to drop column \%s\?

 Patch in attachment fixes all such occurrences.
 Or you can just run little script:
 find -name *.cpp -exec sed -i 's/\\%s?\\/\\%s\\?/' {} \;

 --
 All bugs reserved


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers





 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company




-- 
All bugs reserved
From f9bbc8b128d8b3947cbb815f697b3eb184cb2ffb Mon Sep 17 00:00:00 2001
From: Timon timo...@gmail.com
Date: Tue, 12 Apr 2011 14:04:29 +0600
Subject: [PATCH] Fix string

---
 pgadmin/schema/pgForeignKey.cpp |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pgadmin/schema/pgForeignKey.cpp b/pgadmin/schema/pgForeignKey.cpp
index f9f9976..f53f8c0 100644
--- a/pgadmin/schema/pgForeignKey.cpp
+++ b/pgadmin/schema/pgForeignKey.cpp
@@ -366,7 +366,7 @@ wxString pgForeignKeyCollection::GetTranslatedMessage(int kindOfMessage) const
 	switch (kindOfMessage)
 	{
 		case RETRIEVINGDETAILS:
-			message = _(Retrieving details on foreign keyrs);
+			message = _(Retrieving details on foreign keys);
 			break;
 		case REFRESHINGDETAILS:
 			message = _(Refreshing foreign keys);
-- 
1.7.4.2


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] strings fixes

2011-04-07 Thread Timon

In some files I found strings like this:
Are you sure you wish to drop column \%s?\
but they should be like this
Are you sure you wish to drop column \%s\?

Patch in attachment fixes all such occurrences.
Or you can just run little script:
find -name *.cpp -exec sed -i 's/\\%s?\\/\\%s\\?/' {} \;

-- 
All bugs reserved
From ee8f0f7667a5137df71594c8f601b42e8397cdf7 Mon Sep 17 00:00:00 2001
From: Timon timo...@gmail.com
Date: Thu, 7 Apr 2011 15:46:12 +0600
Subject: [PATCH] fix typpos

---
 pgadmin/schema/edbPackage.cpp|2 +-
 pgadmin/schema/edbSynonym.cpp|2 +-
 pgadmin/schema/gpExtTable.cpp|2 +-
 pgadmin/schema/gpResQueue.cpp|2 +-
 pgadmin/schema/pgAggregate.cpp   |2 +-
 pgadmin/schema/pgCast.cpp|2 +-
 pgadmin/schema/pgColumn.cpp  |2 +-
 pgadmin/schema/pgConversion.cpp  |2 +-
 pgadmin/schema/pgDatabase.cpp|2 +-
 pgadmin/schema/pgDomain.cpp  |2 +-
 pgadmin/schema/pgExtension.cpp   |2 +-
 pgadmin/schema/pgForeignDataWrapper.cpp  |2 +-
 pgadmin/schema/pgForeignServer.cpp   |2 +-
 pgadmin/schema/pgForeignTable.cpp|2 +-
 pgadmin/schema/pgFunction.cpp|6 +++---
 pgadmin/schema/pgGroup.cpp   |2 +-
 pgadmin/schema/pgIndex.cpp   |2 +-
 pgadmin/schema/pgLanguage.cpp|2 +-
 pgadmin/schema/pgOperator.cpp|2 +-
 pgadmin/schema/pgOperatorClass.cpp   |2 +-
 pgadmin/schema/pgOperatorFamily.cpp  |2 +-
 pgadmin/schema/pgRole.cpp|4 ++--
 pgadmin/schema/pgRule.cpp|2 +-
 pgadmin/schema/pgSchema.cpp  |2 +-
 pgadmin/schema/pgSequence.cpp|2 +-
 pgadmin/schema/pgTablespace.cpp  |2 +-
 pgadmin/schema/pgTextSearchConfiguration.cpp |2 +-
 pgadmin/schema/pgTextSearchDictionary.cpp|2 +-
 pgadmin/schema/pgTextSearchParser.cpp|2 +-
 pgadmin/schema/pgTextSearchTemplate.cpp  |2 +-
 pgadmin/schema/pgTrigger.cpp |2 +-
 pgadmin/schema/pgType.cpp|2 +-
 pgadmin/schema/pgUser.cpp|2 +-
 pgadmin/schema/pgUserMapping.cpp |2 +-
 pgadmin/schema/pgView.cpp|2 +-
 35 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/pgadmin/schema/edbPackage.cpp b/pgadmin/schema/edbPackage.cpp
index 76bb6bf..19ab2d4 100644
--- a/pgadmin/schema/edbPackage.cpp
+++ b/pgadmin/schema/edbPackage.cpp
@@ -43,7 +43,7 @@ wxString edbPackage::GetTranslatedMessage(int kindOfMessage) const
 			   GetFullIdentifier().c_str());
 			break;
 		case DROPEXCLUDINGDEPS:
-			message = wxString::Format(_(Are you sure you wish to drop package \%s?\),
+			message = wxString::Format(_(Are you sure you wish to drop package \%s\?),
 			   GetFullIdentifier().c_str());
 			break;
 		case DROPCASCADETITLE:
diff --git a/pgadmin/schema/edbSynonym.cpp b/pgadmin/schema/edbSynonym.cpp
index 1adf219..471b3a4 100644
--- a/pgadmin/schema/edbSynonym.cpp
+++ b/pgadmin/schema/edbSynonym.cpp
@@ -41,7 +41,7 @@ wxString edbSynonym::GetTranslatedMessage(int kindOfMessage) const
 			   GetFullIdentifier().c_str());
 			break;
 		case DROPEXCLUDINGDEPS:
-			message = wxString::Format(_(Are you sure you wish to drop synonym \%s?\),
+			message = wxString::Format(_(Are you sure you wish to drop synonym \%s\?),
 			   GetFullIdentifier().c_str());
 			break;
 		case DROPCASCADETITLE:
diff --git a/pgadmin/schema/gpExtTable.cpp b/pgadmin/schema/gpExtTable.cpp
index 5b9a85a..ffbc1bf 100644
--- a/pgadmin/schema/gpExtTable.cpp
+++ b/pgadmin/schema/gpExtTable.cpp
@@ -48,7 +48,7 @@ wxString gpExtTable::GetTranslatedMessage(int kindOfMessage) const
 			   GetFullIdentifier().c_str());
 			break;
 		case DROPEXCLUDINGDEPS:
-			message = wxString::Format(_(Are you sure you wish to drop external table \%s?\),
+			message = wxString::Format(_(Are you sure you wish to drop external table \%s\?),
 			   GetFullIdentifier().c_str());
 			break;
 		case DROPCASCADETITLE:
diff --git a/pgadmin/schema/gpResQueue.cpp b/pgadmin/schema/gpResQueue.cpp
index f9bc6d5..c68b346 100644
--- a/pgadmin/schema/gpResQueue.cpp
+++ b/pgadmin/schema/gpResQueue.cpp
@@ -51,7 +51,7 @@ wxString gpResQueue::GetTranslatedMessage(int kindOfMessage) const
 			   GetFullIdentifier().c_str());
 			break;
 		case DROPEXCLUDINGDEPS:
-			message = wxString::Format(_(Are you sure you wish to drop resource queue \%s?\),
+			message = wxString::Format(_(Are you sure you wish to drop resource queue \%s\?),
 			   GetFullIdentifier().c_str());
 			break;
 		case

[pgadmin-hackers] error

2011-03-31 Thread Timon

ERROR:  relation pg_extension does not exist
СТРОКА 1:..., x.extrelocatable, x.extversion, e.comment  FROM pg_extensi...

latest git, connecting to postgresql 9.0

-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Debugger crashes when setting a value with quotes

2011-03-28 Thread Timon

commit  6fe0f783fc6a9e85a00df211b25195eb3f3ac29e

g++ -DHAVE_CONFIG_H -I. -I..
-DDATA_DIR=\/usr/local/pgadmin3/share/pgadmin3/\
-I../pgadmin/include   -I/usr/include -I/usr/include/pgsql
-DHAVE_CONNINFO_PARSE -I/usr/lib64/wx/include/gtk2-unicode-release-2.8
-I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES
-D__WXGTK__ -DEMBED_XRC -I/usr/include/libxml2 -I/usr/include/libxml2
-O2 -MT ctlCodeWindow.o -MD -MP -MF .deps/ctlCodeWindow.Tpo -c -o
ctlCodeWindow.o `test -f './debugger/ctlCodeWindow.cpp' || echo
'./'`./debugger/ctlCodeWindow.cpp
./debugger/ctlCodeWindow.cpp: In member function 'void
ctlCodeWindow::OnVarChange(wxGridEvent)':
./debugger/ctlCodeWindow.cpp:1306:176: error: cannot pass objects of
non-trivially-copyable type 'class wxString' through '...'
./debugger/ctlCodeWindow.cpp:1306:176: error: cannot pass objects of
non-trivially-copyable type 'class wxString' through '...'
make[3]: *** [ctlCodeWindow.o] Error 1

gcc-4.5.1-4.fc14.x86_64

2011/3/24 Dave Page dp...@pgadmin.org:
 On Thu, Mar 24, 2011 at 2:54 PM, Heikki Linnakangas
 heikki.linnakan...@enterprisedb.com wrote:
 Steps to reproduce:

 1. Create a function:

 CREATE OR REPLACE FUNCTION barfunc()
  RETURNS integer AS
 $BODY$
  DECLARE
   var int4;
  BEGIN
   var := 1;
   IF 1=2 THEN NULL; END IF;
   RETURN var;
  END
 $BODY$
  LANGUAGE plpgsql;

 2. Start debugging on the function.

 3. Change the value of variable 'var' in the debugger GUI to something with
 a single quote. Like '123.

 4. Move focus from the cell, pgAdmin3 crashes

 Looking at the code in ctlCodeWindow.cpp, it seems that the new value is not
 quoted properly in the call to pldbg_deposit_value() server function.

 I've committed a fix for this - thanks.

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] gin/gist indexes show twice

2011-03-28 Thread Timon

yup, seem that problem is not with git/gist indexes.
I have found the query for this grid in file
pgadmin/schema/pgIndex.cpp line 670.

I run this query in Sql Query tool and get same results:
SELECT
indexrelname,
idx_scan, idx_tup_read, idx_tup_fetch,
pg_size_pretty(pg_relation_size(indexrelid)),
refclassid, refobjid, deptype,
refclassid::regclass, refobjid::regclass
FROM pg_stat_all_indexes stat
JOIN pg_class cls ON cls.oid=indexrelid
LEFT JOIN pg_depend dep ON (dep.classid = cls.tableoid AND dep.objid
= cls.oid AND dep.refobjsubid = '0')
--  LEFT OUTER JOIN pg_constraint con ON (con.tableoid = dep.refclassid
AND con.oid = dep.refobjid)
WHERE schemaname = 'public'
AND
stat.relname = 'user_attr_text'
--AND con.contype IS NULL
ORDER BY indexrelname

idx_fts;0;0;0;28 MB;3602;11335;n;pg_ts_config;11335
idx_fts;0;0;0;28 MB;1259;159262085;a;pg_class;user_attr_text
idx_length;0;0;0;4528 kB;1259;159262085;a;pg_class;user_attr_text
trgm_idx;0;0;0;126 MB;2616;24936297;n;pg_opclass;24936297
trgm_idx;0;0;0;126 MB;1259;159262085;a;pg_class;user_attr_text
user_attr_text_pkey;16;16;16;39 MB;2606;159262089;i;pg_constraint;159262089

my indexes:
CREATE INDEX idx_fts
  ON user_attr_text
  USING gin
  (strip(to_tsvector('russian'::regconfig, about::text)))
  WHERE about IS NOT NULL;

CREATE INDEX trgm_idx
  ON user_attr_text
  USING gin
  (lower(about::text) gin_trgm_ops)
  WHERE about IS NOT NULL;

this is on latest working version from git repo.

2011/3/28 Guillaume Lelarge guilla...@lelarge.info:
 Le 24/03/2011 07:21, Timon a écrit :
 gin and gist indexes show twice in indexes list grid of table.
 Watch attachment


 Just tried, didn't reproduce it.

 Care to share more info? like pgAdmin's release number. This issue
 reminds me something, but I don't find what.
 --
 Guillaume
  http://www.postgresql.fr
  http://dalibo.com




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] gin/gist indexes show twice

2011-03-28 Thread Timon

2011/3/28 Guillaume Lelarge guilla...@lelarge.info:
 Le 28/03/2011 10:57, Timon a écrit :
 yup, seem that problem is not with git/gist indexes.
 I have found the query for this grid in file
 pgadmin/schema/pgIndex.cpp line 670.

 I run this query in Sql Query tool and get same results:
 SELECT
       indexrelname,
       idx_scan, idx_tup_read, idx_tup_fetch,
       pg_size_pretty(pg_relation_size(indexrelid)),
       refclassid, refobjid, deptype,
       refclassid::regclass, refobjid::regclass
 FROM pg_stat_all_indexes stat
       JOIN pg_class cls ON cls.oid=indexrelid
       LEFT JOIN pg_depend dep ON (dep.classid = cls.tableoid AND dep.objid
 = cls.oid AND dep.refobjsubid = '0')
 --    LEFT OUTER JOIN pg_constraint con ON (con.tableoid = dep.refclassid
 AND con.oid = dep.refobjid)
 WHERE schemaname = 'public'
       AND
       stat.relname = 'user_attr_text'
       --AND con.contype IS NULL
 ORDER BY indexrelname


 I'm wondering why you commented the left join on pg_constraint. It could
 be your issue.
 pgAdmin doesn't have these lines commented, and, AFAICT, it works. See
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=blob;f=pgadmin/schema/pgIndex.cpp;h=4f270eedc03fd9e8fd3033ec627ca304462ff7bd;hb=HEAD#l670.

I know it. I just want to pay attention on pg_depend. idx_fts has 2
dependencies - pg_ts_config;11335, pg_class;user_attr_text, and no
constraint dependencies. That's why it shows twitce.

my quick ugly patch:
diff --git a/pgadmin/schema/pgIndex.cpp b/pgadmin/schema/pgIndex.cpp
index 4f270ee..29abcfd 100644
--- a/pgadmin/schema/pgIndex.cpp
+++ b/pgadmin/schema/pgIndex.cpp
@@ -676,7 +676,7 @@ void pgIndexBaseCollection::ShowStatistics(frmMain
*form, ctlListView *statistic
sql += wxT(\n)
   wxT(  FROM pg_stat_all_indexes stat\n)
   wxT(  JOIN pg_class cls ON cls.oid=indexrelid\n)
-  wxT(  LEFT JOIN pg_depend dep ON (dep.classid =
cls.tableoid AND dep.objid = cls.oid AND dep.refobjsubid = '0')\n)
+  wxT(  LEFT JOIN pg_depend dep ON (dep.classid =
cls.tableoid AND dep.objid = cls.oid AND dep.refobjsubid = '0' AND
refclassid::regclass::varchar = 'pg_constraint')\n)
   wxT(  LEFT OUTER JOIN pg_constraint con ON
(con.tableoid = dep.refclassid AND con.oid = dep.refobjid)\n)
   wxT(  WHERE schemaname = ) +
qtDbString(GetTable()-GetSchema()-GetName())
   + wxT( AND stat.relname = ) + qtDbString(GetTable()-GetName())




 --
 Guillaume
  http://www.postgresql.fr
  http://dalibo.com




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: New menu to add a restore point

2011-03-16 Thread Timon

I have error at compilation

g++ -DHAVE_CONFIG_H -I. -I..
-DDATA_DIR=\/usr/local/pgadmin3/share/pgadmin3/\
-I../pgadmin/include   -I/usr/include -I/usr/include/pgsql
-DHAVE_CONNINFO_PARSE -I/usr/lib64/wx/include/gtk2-unicode-release-2.8
-I/usr/include/wx-2.8 -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES
-D__WXGTK__ -DEMBED_XRC -I/usr/include/libxml2 -I/usr/include/libxml2
-O2 -MT pgServer.o -MD -MP -MF .deps/pgServer.Tpo -c -o pgServer.o
`test -f './schema/pgServer.cpp' || echo './'`./schema/pgServer.cpp

./schema/pgServer.cpp: In member function 'virtual bool
addnamedrestorepointServiceFactory::CheckEnable(pgObject*)':
./schema/pgServer.cpp:1952:10: error: 'server' was not declared in this scope
make[3]: *** [pgServer.o] Error 1

gcc-4.5.1-4.fc14.x86_64

2011/3/16 Guillaume Lelarge guilla...@lelarge.info:
 New menu to add a restore point

 Adds a new item in the contextual menu of a server node. When selected, it
 asks for a name and call the 9.1 pg_create_restore_point() function.

 Branch
 --
 master

 Details
 ---
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bd362e7b2f7b44a3636a2ebcbf7a130673461982

 Modified Files
 --
 pgadmin/frm/frmMain.cpp           |    1 +
 pgadmin/include/schema/pgServer.h |    9 +
 pgadmin/schema/pgServer.cpp       |   35 +++
 3 files changed, 45 insertions(+), 0 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgadmin-support] Copy paste - git

2011-03-15 Thread Timon

it was already discussed. I have same bug, but Guillaume Lelarge
guilla...@lelarge.info unable to reproduce it.
Using git bisect I found commit which broke this feature. This is
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c4a350002d8e7bdb77bf5d8eb1c5eb4efade6aff

2011/3/15 Claudio Freire klaussfre...@gmail.com:
 Hey, I just did a git pull and built from source (on debian squeeze),
 and I cannot copy  paste from the SQL results panel.

 Copy  paste there is pretty useful ;-)

 Any chance to get it back?

 --
 Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-support




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Fwd: [pgadmin-support] Copy paste - git

2011-03-15 Thread Timon

-- Forwarded message --
From: Timon timo...@gmail.com
Date: 2011/3/15
Subject: Re: [pgadmin-support] Copy  paste - git
To: Guillaume Lelarge guilla...@lelarge.info

This patch didn't help :(
Copy/paste works everywhere fine, but not with sqlResult control.
Also when I move cursor to scratchPad after sqlQuery control,
copy/paste works fine. But when I move cursor to scratchPad after
sqlResult control, copy/past doesn't work in scratchPad control too.

2011/3/15 Guillaume Lelarge guilla...@lelarge.info:
 Le 15/03/2011 07:52, Timon a écrit :
 it was already discussed. I have same bug, but Guillaume Lelarge
 guilla...@lelarge.info unable to reproduce it.
 Using git bisect I found commit which broke this feature. This is
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c4a350002d8e7bdb77bf5d8eb1c5eb4efade6aff

 2011/3/15 Claudio Freire klaussfre...@gmail.com:
 Hey, I just did a git pull and built from source (on debian squeeze),
 and I cannot copy  paste from the SQL results panel.

 Copy  paste there is pretty useful ;-)

 Any chance to get it back?

 Could you try this patch?

 --
 Guillaume
  http://www.postgresql.fr
  http://dalibo.com

--
All bugs reserved

-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Quick fix for a registry datatype issue on Windows,

2011-02-15 Thread Timon

This commit 8f9c483868c587cc2ac6332a927338426ae9836c broke an ability
to suppress different guru hints.

reproduce steps.
1. remove [Hints] from .pgadmin3
2. run pgadmin3
3. open connection to server
4. The windows Guru Hint - Server instrumentation not installed should appear
5. check Do not show this hint again
6. press ok button
7. close pgadmin3
8. run pgadmin3 again and connect to server

On my system I see  Guru Hint - Server instrumentation not installed
window again, but I checked  Do not show this hint again in step 4.

before this commit in [Hints] section in .pgadmin3:

[Hints]
instrumentation=Suppress

but after this commit

[Hints]
instrumentation=true

2011/2/1 Dave Page dp...@pgadmin.org:
 Quick fix for a registry datatype issue on Windows, introduced by
 the wx 2.9 patch.

 Branch
 --
 master

 Details
 ---
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8f9c483868c587cc2ac6332a927338426ae9836c

 Modified Files
 --
 pgadmin/frm/frmHint.cpp             |    2 +-
 pgadmin/include/utils/sysSettings.h |    1 +
 pgadmin/utils/sysSettings.cpp       |    6 ++
 3 files changed, 8 insertions(+), 1 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Fix copy bug in the edit grid

2011-01-28 Thread Timon

just tested again with latest git version, same problem
reproduce steps:
1. open query tool
2. select something
3. try to copy results from result grid using ctrl+c or main menu
for me step 3 does nothing. watch attachment

may be this is a problem of wxWidgets, I don't know, but before
267c594ae6663becb29de3955f94d37d7705fcfb commit everything was fine.

my system
fedora 14:
wxGTK-2.8.11-3.fc14.x86_64

2011/1/28 Guillaume Lelarge guilla...@lelarge.info:
 Le 21/01/2011 15:41, Timon a écrit :
 seem that this commit broke ability to copy whole query result from
 result grid in query tool.


 Sorry for not answering sooner. I just tried and it seems to work right
 to me. I don't see any issue with copy and paste in the query tool.


 --
 Guillaume
  http://www.postgresql.fr
  http://dalibo.com




-- 
All bugs reserved
attachment: pgadmin.png
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix copy bug in the edit grid

2011-01-21 Thread Timon

seem that this commit broke ability to copy whole query result from
result grid in query tool.


result of git bisect:
267c594ae6663becb29de3955f94d37d7705fcfb is the first bad commit
commit 267c594ae6663becb29de3955f94d37d7705fcfb
Author: Guillaume Lelarge guilla...@lelarge.info
Date:   Wed Dec 22 00:04:54 2010 +0100

   Fix copy bug in the edit grid

   If you select only a part of the text in a cell, and try to copy
it, it really
   copies all the cell. This patch makes sure that only the selected text is
   copied.

   Report from Mauro Bertoli.

:100644 100644 f0cbd7e9923010078a30a82e9d51a5147fb28c34
c37af2b9f58c3cfd12f57365e5e7045d46b517c2 M      CHANGELOG
:04 04 e4d8821d61d19f34e152e9e743f6d1ffbcc3ce43
118f5b08516ca7837cf5748e6d1071f31d7e1da1 M      pgadmin


2010/12/22 Guillaume Lelarge guilla...@lelarge.info:
 Fix copy bug in the edit grid

 If you select only a part of the text in a cell, and try to copy it, it really
 copies all the cell. This patch makes sure that only the selected text is
 copied.

 Report from Mauro Bertoli.

 Branch
 --
 master

 Details
 ---
 http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=267c594ae6663becb29de3955f94d37d7705fcfb

 Modified Files
 --
 CHANGELOG                   |    2 ++
 pgadmin/frm/frmEditGrid.cpp |   13 -
 2 files changed, 14 insertions(+), 1 deletions(-)


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wrong indexes sizes on index page

2010-10-12 Thread Timon

2010/10/12 Guillaume Lelarge guilla...@lelarge.info:
 Le 12/10/2010 11:47, Thom Brown a écrit :
 On 12 October 2010 10:29, Timon timo...@gmail.com wrote:
 see attachment.
 Last column on table shows index size, but 227MB - is table size.

 postgresql 8.4.4

 pgadmin 1.13 last dev build from git


 I can confirm this using pgAdmin ... weird special version Dave gave
 me last week ... against PostgreSQL 8.3.1, and PostgreSQL 9.0.0.


 I don't think we changed anything in this area. So you should have the
 same issue with 1.12.
yes, I have this issue with 1.12.


-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] ru_translate fixes

2010-10-12 Thread Timon

please check
http://github.com/postgres/pgadmin3/pull/1

-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Error Column not found in pgSet: size in pgAdmin 1.12

2010-09-28 Thread Timon

please don't forget to add this patch in pgAdmin 1.12.1 :)

2010/9/17 Dave Page dp...@pgadmin.org:
 On Fri, Sep 17, 2010 at 11:36 AM, Timon timo...@gmail.com wrote:
 2010/9/17 Dave Page dp...@pgadmin.org:
 On Fri, Sep 17, 2010 at 10:10 AM, Timon timo...@gmail.com wrote:
 when selects indexes node in object browser error appears (see screenshot)
 Postgresql server version postgresql-8.4.4

 I think this is caused by translation of a string that shouldn't be
 translated. Can you try the attached patch please?
 It seems to be true, because in EN_en every thing is fine.
 With patch works fine.
 Should I fix translation? Or is there any words list that translator
 shouldn't translate?

 No, the patch is the correct fix. Thanks for testing.

 Unfortunately though, this will not make it into 1.12.0, but I'll
 commit for 1.12.1.


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise Postgres Company




-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] automake-1.11

2009-08-21 Thread Timon

can't run bootstrap with automake-1.11-2.fc11.noarch, which allready in
updates-testing repo.
I use this line:
aclocal  autoheader  automake --foreign --add-missing --copy  autoconf

-- 
All bugs reserved

[pgadmin-hackers] can't build pgadmin from SVN

2009-02-26 Thread Timon

I can't build pgadmin from SVN with error:

./gqb/gqbBrowser.cpp: In constructor
'gqbBrowser::gqbBrowser(wxWindow*, wxWindowID, const wxPoint, const
wxSize, long int, gqbController*)':
./gqb/gqbBrowser.cpp:45: error: conversion from 'int' to 'const
wxTreeItemId' is ambiguous
/usr/include/wx-2.8/wx/treebase.h:75: note: candidates are:
wxTreeItemId::wxTreeItemId(long int)
/usr/include/wx-2.8/wx/treebase.h:59: note:
wxTreeItemId::wxTreeItemId(void*)

but after deleting line 45 in gqbBrowser.cpp project builds fine, and
works fine too :)
Is this my problem?

Fedora 10
-- 
All bugs reserved

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

46 matches

Mail list logo