Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

[Dave Page]

Thanks, that got it. Applied!

On Tue, Jun 13, 2017 at 4:51 PM, Joao Pedro De Almeida Pereira
 wrote:
> Hi Hackers,
>
> Good catch Dave.
>
> You can find attached the new diff with the correction of the problem above.
>
> Thanks
> Shruti & Joao
>
> On Tue, Jun 13, 2017 at 10:35 AM, Dave Page  wrote:
>>
>> Hi
>>
>> On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
>>  wrote:
>> > Hi Hackers,
>> >
>> > Attached you can find the patch that corrects that Bundle tests that was
>> > polluting the os and subprocess modules.
>> >
>> > This patch reverts the commit that skipped the test.
>>
>> This is almost exactly what Ashesh and I came up with (along with a
>> few other variations). Unfortunately, whilst all the other tests now
>> pass, the second execution of the bundler test fails with:
>>
>> ==
>> FAIL: runTest
>> (pgadmin.utils.javascript.tests.test_javascript_bundler.JavascriptBundlerTestCase)
>> scenario name: JavascriptBundlerTestCase
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
>> line 44, in runTest
>> self._bundling_succeeds()
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
>> line 70, in _bundling_succeeds
>> self.mockSubprocess.call.assert_called_once_with(['yarn', 'run',
>> 'bundle:dev'])
>>   File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/mock/mock.py",
>> line 947, in assert_called_once_with
>> raise AssertionError(msg)
>> AssertionError: Expected 'call' to be called once. Called 0 times.
>>
>> --
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

[Joao Pedro De Almeida Pereira]

Hi Hackers,

Good catch Dave.

You can find attached the new diff with the correction of the problem above.

Thanks
Shruti & Joao

On Tue, Jun 13, 2017 at 10:35 AM, Dave Page  wrote:

> Hi
>
> On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
>  wrote:
> > Hi Hackers,
> >
> > Attached you can find the patch that corrects that Bundle tests that was
> > polluting the os and subprocess modules.
> >
> > This patch reverts the commit that skipped the test.
>
> This is almost exactly what Ashesh and I came up with (along with a
> few other variations). Unfortunately, whilst all the other tests now
> pass, the second execution of the bundler test fails with:
>
> ==
> FAIL: runTest (pgadmin.utils.javascript.tests.test_javascript_bundler.
> JavascriptBundlerTestCase)
> scenario name: JavascriptBundlerTestCase
> --
> Traceback (most recent call last):
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/
> tests/test_javascript_bundler.py",
> line 44, in runTest
> self._bundling_succeeds()
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/
> tests/test_javascript_bundler.py",
> line 70, in _bundling_succeeds
> self.mockSubprocess.call.assert_called_once_with(['yarn', 'run',
> 'bundle:dev'])
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/mock/mock.py",
> line 947, in assert_called_once_with
> raise AssertionError(msg)
> AssertionError: Expected 'call' to be called once. Called 0 times.
>
> --
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


correct-bundle-test.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

[Dave Page]

Hi

On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
 wrote:
> Hi Hackers,
>
> Attached you can find the patch that corrects that Bundle tests that was
> polluting the os and subprocess modules.
>
> This patch reverts the commit that skipped the test.

This is almost exactly what Ashesh and I came up with (along with a
few other variations). Unfortunately, whilst all the other tests now
pass, the second execution of the bundler test fails with:

==
FAIL: runTest 
(pgadmin.utils.javascript.tests.test_javascript_bundler.JavascriptBundlerTestCase)
scenario name: JavascriptBundlerTestCase
--
Traceback (most recent call last):
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
line 44, in runTest
self._bundling_succeeds()
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
line 70, in _bundling_succeeds
self.mockSubprocess.call.assert_called_once_with(['yarn', 'run',
'bundle:dev'])
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/mock/mock.py",
line 947, in assert_called_once_with
raise AssertionError(msg)
AssertionError: Expected 'call' to be called once. Called 0 times.

--

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers][patch] Correct bundle test that polluted Python modules

[Joao Pedro De Almeida Pereira]

Hi Hackers,

Attached you can find the patch that corrects that Bundle tests that was
polluting the os and subprocess modules.

This patch reverts the commit that skipped the test.


Thanks
Shruti & Joao


correct-bundle-test.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers