Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

[Dave Page]

Thanks - I committed some styling tweaks, then a much-simplified
version of this patch.

On Fri, Jun 24, 2016 at 6:21 AM, Surinder Kumar
 wrote:
> Hi
>
> Please find attached patch with following changes:
> 1) Given a title to browser panel.
> 2) Add an icon and did styling to match with other panels.(please change
> icon it it doesn't look good).
> 3) Added new class to title div to override css style.
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Fwd: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

[Surinder Kumar]

Hi

Please find attached patch with following changes:
1) Given a title to browser panel.
2) Add an icon and did styling to match with other panels.(please change
icon it it doesn't look good).
3) Added new class to title div to override css style.

Please review.

Thanks,
Surinder Kumar


RM#1184_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

[Surinder Kumar]

On Tue, Jun 7, 2016 at 1:46 PM, Ashesh Vashi 
wrote:

> On Sat, Jun 4, 2016 at 3:44 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch for mentioned issue:
>> *Issue*: Re-docking on the main tabset is broken
>> *Explanation*:
>> We were missing 'moveable' property. It should be set to false while
>> creating new Browser panel. By default it is true for all registered panels.
>> I think both browser and dashboard panels were moveable. that is why
>> dockable tab couldn't determine where to re-dock.
>>
>
> That has fixed the original issue, but - now it does not allow me to dock
> any of the panel beneath the 'Browser' panel.
>
Yes I have observed this issue after applying patch, but If we ignore the
fix in patch, then the core issue is that
we have set *showTitle* of browser panel to false. because of which It
removes the title bar completely from the browser panel and
hence re-docking the panel doesn't work. If I set *showTitle* to true, it
works.

This may be the behaviour or issue with wcDocker. From my perspective it
should only hide panel title instead of removing panel title bar completely.

>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> I have also added support for moveable property in Panel class.
>>
>> Please review.
>>
>> Thanks,
>> Surinder Kumar
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

[Ashesh Vashi]

On Sat, Jun 4, 2016 at 3:44 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch for mentioned issue:
> *Issue*: Re-docking on the main tabset is broken
> *Explanation*:
> We were missing 'moveable' property. It should be set to false while
> creating new Browser panel. By default it is true for all registered panels.
> I think both browser and dashboard panels were moveable. that is why
> dockable tab couldn't determine where to re-dock.
>

That has fixed the original issue, but - now it does not allow me to dock
any of the panel beneath the 'Browser' panel.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> I have also added support for moveable property in Panel class.
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

[Surinder Kumar]

Hi,

Please find attached patch for mentioned issue:
*Issue*: Re-docking on the main tabset is broken
*Explanation*:
We were missing 'moveable' property. It should be set to false while
creating new Browser panel. By default it is true for all registered panels.
I think both browser and dashboard panels were moveable. that is why
dockable tab couldn't determine where to re-dock.

I have also added support for moveable property in Panel class.

Please review.

Thanks,
Surinder Kumar


RM#1184.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers