Re: [pgadmin-hackers] Patches

[Sandeep Thakkar]

On Thu, Jun 16, 2016 at 7:04 PM, Dave Page  wrote:

> On Thu, Jun 16, 2016 at 11:40 AM, Sandeep Thakkar
>  wrote:
> >
> >
> >> > I have attached the patch (pgadminpro.patch) to fix this.
> >>
> >> Configuration and build fails for me with this:
> >>
> > yeah, the 'contains' function is trying to match the whole string.
> Replacing
> > that line in the patch with "contains( LIBS, -lpython2.* )" should work
> > fine.
>
> Nope - it looks like it's messing up the detection of python-config
> vs. python3-config. I'm beginning to think it only worked before
> because of the -lpython2.7 line you (quite rightly) removed. With the
> attached version of the patch, I get this output:
>
> Project MESSAGE: Building for QT5+...
> Project MESSAGE: Configure pgAdmin4 to run in debug mode...
> Project MESSAGE: Building for Linux/Mac...
> Project MESSAGE: Using python3-config
> /bin/sh: python3-config: command not found
> /bin/sh: python3-config: command not found
> /bin/sh: python3-config: command not found
> Project MESSAGE: Python3 detected.
>
> Interesting. It seems the system command in the pro file "*!system(which
python3-config > /dev/null 2>&1)** {*" is itself not working at your end. As
you mentioned earlier python3-config does not exist in your path and so
`which python3-config` should not return anything. But as per the above
output, it seems it is trying to execute python3-config and hence we can
see command not found error. and therefore it goes in else and printing
message(Using python3-config).. I'm not sure what is wrong.


> >> This second patch breaks builds for me:
> >>
> > This is strange because I just added a new option "--always-copy" to
> > virtualenv. What is your path to virtualenv? Could you please try running
> > 'virtualenv -v  --always-copy -p
> > /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
> > /tmp/venv'
>
> Hmm.. so, the virtualenv on your mac is not working with "--always-copy"
option. I will check again if we still need it (for Python3).


> (pgadmin4)piranha:pgAdmin4 dpage$ virtualenv -v  --always-copy -p
> /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
> /tmp/venv
> Running virtualenv with interpreter
> /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
> Creating /tmp/venv/lib/python2.7
> Symlinking Python bootstrap modules
>   Copying to /tmp/venv/lib/python2.7/config
> Traceback (most recent call last):
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 2311, in
> 
> main()
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 703, in main
> symlink=options.symlink)
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 916, in
> create_environment
> site_packages=site_packages, clear=clear, symlink=symlink))
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line ,
> in install_python
> copyfile(join(stdlib_dir, fn), join(lib_dir, fn), symlink)
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 352, in
> copyfile
> copyfileordir(src, dest, symlink)
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 324, in
> copyfileordir
> shutil.copytree(src, dest, symlink)
>   File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py",
> line 208, in copytree
> raise Error, errors
> shutil.Error:
> [('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/config.c',
> '/tmp/venv/lib/python2.7/config/config.c', "[Errno 1] Operation not
> permitted: '/tmp/venv/lib/python2.7/config/config.c'"),
>
> ('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/
> config.c.in',
> '/tmp/venv/lib/python2.7/config/config.c.in', "[Errno 1] Operation not
> permitted: '/tmp/venv/lib/python2.7/config/config.c.in'"),
>
> ('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/install-sh',
> '/tmp/venv/lib/python2.7/config/install-sh', "[Errno 1] Operation not
> permitted: '/tmp/venv/lib/python2.7/config/install-sh'"),
>
> ('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/libpython2.7.a',
> '/tmp/venv/lib/python2.7/config/libpython2.7.a', "[Errno 1] Operation
> not permitted: '/tmp/venv/lib/python2.7/config/libpython2.7.a'"),
>
> ('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/libpython2.7.dylib',
> '/tmp/venv/lib/python2.7/config/libpython2.7.dylib', "[Errno 1]
> Operation not permitted:
> '/tmp/venv/lib/python2.7/config/libpython2.7.dylib'"),
>
> ('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/Makefile',
> '/tmp/venv/lib/python2.7/config/Makefile', "[Errno 1] Operation not
> permitted: '/tmp/venv/lib/python2.7/config/Makefile'"),
>
> ('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/makesetup',
> '/tmp/venv/lib/python2.7/config/makesetup', "[Errno 1] Operation not
> 

Re: [pgadmin-hackers] Patches

[Dave Page]

On Thu, Jun 16, 2016 at 11:40 AM, Sandeep Thakkar
 wrote:
>
>
>> > I have attached the patch (pgadminpro.patch) to fix this.
>>
>> Configuration and build fails for me with this:
>>
> yeah, the 'contains' function is trying to match the whole string. Replacing
> that line in the patch with "contains( LIBS, -lpython2.* )" should work
> fine.

Nope - it looks like it's messing up the detection of python-config
vs. python3-config. I'm beginning to think it only worked before
because of the -lpython2.7 line you (quite rightly) removed. With the
attached version of the patch, I get this output:

Project MESSAGE: Building for QT5+...
Project MESSAGE: Configure pgAdmin4 to run in debug mode...
Project MESSAGE: Building for Linux/Mac...
Project MESSAGE: Using python3-config
/bin/sh: python3-config: command not found
/bin/sh: python3-config: command not found
/bin/sh: python3-config: command not found
Project MESSAGE: Python3 detected.


>> This second patch breaks builds for me:
>>
> This is strange because I just added a new option "--always-copy" to
> virtualenv. What is your path to virtualenv? Could you please try running
> 'virtualenv -v  --always-copy -p
> /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
> /tmp/venv'

(pgadmin4)piranha:pgAdmin4 dpage$ virtualenv -v  --always-copy -p
/System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
/tmp/venv
Running virtualenv with interpreter
/System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
Creating /tmp/venv/lib/python2.7
Symlinking Python bootstrap modules
  Copying to /tmp/venv/lib/python2.7/config
Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 2311, in 
main()
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 703, in main
symlink=options.symlink)
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 916, in
create_environment
site_packages=site_packages, clear=clear, symlink=symlink))
  File "/Library/Python/2.7/site-packages/virtualenv.py", line ,
in install_python
copyfile(join(stdlib_dir, fn), join(lib_dir, fn), symlink)
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 352, in copyfile
copyfileordir(src, dest, symlink)
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 324, in
copyfileordir
shutil.copytree(src, dest, symlink)
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py",
line 208, in copytree
raise Error, errors
shutil.Error: 
[('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/config.c',
'/tmp/venv/lib/python2.7/config/config.c', "[Errno 1] Operation not
permitted: '/tmp/venv/lib/python2.7/config/config.c'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/config.c.in',
'/tmp/venv/lib/python2.7/config/config.c.in', "[Errno 1] Operation not
permitted: '/tmp/venv/lib/python2.7/config/config.c.in'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/install-sh',
'/tmp/venv/lib/python2.7/config/install-sh', "[Errno 1] Operation not
permitted: '/tmp/venv/lib/python2.7/config/install-sh'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/libpython2.7.a',
'/tmp/venv/lib/python2.7/config/libpython2.7.a', "[Errno 1] Operation
not permitted: '/tmp/venv/lib/python2.7/config/libpython2.7.a'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/libpython2.7.dylib',
'/tmp/venv/lib/python2.7/config/libpython2.7.dylib', "[Errno 1]
Operation not permitted:
'/tmp/venv/lib/python2.7/config/libpython2.7.dylib'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/Makefile',
'/tmp/venv/lib/python2.7/config/Makefile', "[Errno 1] Operation not
permitted: '/tmp/venv/lib/python2.7/config/Makefile'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/makesetup',
'/tmp/venv/lib/python2.7/config/makesetup', "[Errno 1] Operation not
permitted: '/tmp/venv/lib/python2.7/config/makesetup'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/python.o',
'/tmp/venv/lib/python2.7/config/python.o', "[Errno 1] Operation not
permitted: '/tmp/venv/lib/python2.7/config/python.o'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/Setup',
'/tmp/venv/lib/python2.7/config/Setup', "[Errno 1] Operation not
permitted: '/tmp/venv/lib/python2.7/config/Setup'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/Setup.config',
'/tmp/venv/lib/python2.7/config/Setup.config', "[Errno 1] Operation
not permitted: '/tmp/venv/lib/python2.7/config/Setup.config'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/Setup.local',
'/tmp/venv/lib/python2.7/config/Setup.local', "[Errno 1] Operation not
permitted: 

Re: [pgadmin-hackers] Patches

[Sandeep Thakkar]

On Thu, Jun 16, 2016 at 3:19 PM, Dave Page  wrote:

> On Thu, Jun 16, 2016 at 8:51 AM, Sandeep Thakkar
>  wrote:
> > Hi,
> >
> > I created virtual environment and tried building pgadmin on my Mac with
> > Python 3.3 and QT 5.5. I observed that in venv, the python3-config is
> copied
> > as python-config. Therefore, it's required to change pgAdmin4.pro to
> handle
> > this. With the existing .pro, it does not find the python3-config and
> > assumes it is Python2 and throws the following build error:
> > --
> > Server.cpp:36:5: error: no matching function for call to
> 'Py_SetProgramName'
> > Py_SetProgramName(PGA_APP_NAME.toUtf8().data());
> >
> >
> /mnt/hgfs/pginstaller.pune/server/source/pgadmin.osx/mac-build/venv/include/python3.3m/pythonrun.h:25:18:
> > note: candidate function not viable: no known conversion from 'char *' to
> > 'wchar_t *' for 1st
> >
> >   argument
> >
> > PyAPI_FUNC(void) Py_SetProgramName(wchar_t *);
> > --
> >
> > I have attached the patch (pgadminpro.patch) to fix this.
>
> Configuration and build fails for me with this:
>
> yeah, the 'contains' function is trying to match the whole string.
Replacing that line in the patch with "contains( LIBS, -lpython2.* )"
should work fine.


> Project MESSAGE: Building for QT5+...
> Project MESSAGE: Configure pgAdmin4 to run in debug mode...
> Project MESSAGE: Building for Linux/Mac...
> /bin/sh: python3-config: command not found
> /bin/sh: python3-config: command not found
> /bin/sh: python3-config: command not found
> Project MESSAGE: Python3 detected.
>
> (pgadmin4)piranha:pgAdmin4 dpage$ which python-config
> /usr/bin/python-config
> (pgadmin4)piranha:pgAdmin4 dpage$ which python3-config
> (pgadmin4)piranha:pgAdmin4 dpage$ locate python3-config
> (pgadmin4)piranha:pgAdmin4 dpage$ python-config --libs
> -lpython2.7 -ldl -framework CoreFoundation
>
> Though - I also get some funky output without the patch (but, the
> build succeeds):
>
> Project MESSAGE: Building for QT5+...
> Project MESSAGE: Configure pgAdmin4 to run in debug mode...
> Project MESSAGE: Building for Linux/Mac...
> /bin/sh: python3-config: command not found
> /bin/sh: python3-config: command not found
> /bin/sh: python3-config: command not found
>
>
> > Another thing i observed is that in venv, the encodings directory in sym
> > linked to the actual one on the system and hence the build fails with the
> > following error:
> > --
> > Could not find platform independent libraries 
> > Could not find platform dependent libraries 
> > Consider setting $PYTHONHOME to [:]
> > Fatal Python error: Py_Initialize: unable to load the file system codec
> > ImportError: No module named 'encodings'
> > --
> >
> > I have attached the patch (pgadmin-macbuild.patch) to make sure the
> > virtualenv for macbuild copies the required files instead of linking. In
> the
> > same patch, I also modified the build script to not rename the actual
> > directory of python in venv (as python libs may refer the actual
> directory)
> > and instead create a sym link. There might be other way to fix this, but
> I
> > found this to be easy. :)
>
> This second patch breaks builds for me:
>
> This is strange because I just added a new option "--always-copy" to
virtualenv. What is your path to virtualenv? Could you please try running
'virtualenv -v  --always-copy -p
/System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
/tmp/venv'


> PYTHON_HOME not set. Setting it to default
> QTDIR not set. Setting it to default
> PGDIR not set. Setting it to default
> Cleaning up the old environment and app bundle
> Running virtualenv with interpreter
> /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
> Traceback (most recent call last):
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 2311, in
> 
> main()
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 703, in main
> symlink=options.symlink)
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 916, in
> create_environment
> site_packages=site_packages, clear=clear, symlink=symlink))
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line ,
> in install_python
> copyfile(join(stdlib_dir, fn), join(lib_dir, fn), symlink)
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 352, in
> copyfile
> copyfileordir(src, dest, symlink)
>   File "/Library/Python/2.7/site-packages/virtualenv.py", line 324, in
> copyfileordir
> shutil.copytree(src, dest, symlink)
>   File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py",
> line 208, in copytree
> raise Error, errors
> shutil.Error:
> [('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/config.c',
> '/Users/dpage/git/pgadmin4/mac-build/venv/lib/python2.7/config/config.c',
> "[Errno 1] Operation not permitted:
> '/Users/dpage/git/pgadmin4/mac-build/venv/lib/python2.7/config/config.c'"),
>

Re: [pgadmin-hackers] Patches

[Dave Page]

On Thu, Jun 16, 2016 at 8:51 AM, Sandeep Thakkar
 wrote:
> Hi,
>
> I created virtual environment and tried building pgadmin on my Mac with
> Python 3.3 and QT 5.5. I observed that in venv, the python3-config is copied
> as python-config. Therefore, it's required to change pgAdmin4.pro to handle
> this. With the existing .pro, it does not find the python3-config and
> assumes it is Python2 and throws the following build error:
> --
> Server.cpp:36:5: error: no matching function for call to 'Py_SetProgramName'
> Py_SetProgramName(PGA_APP_NAME.toUtf8().data());
>
> /mnt/hgfs/pginstaller.pune/server/source/pgadmin.osx/mac-build/venv/include/python3.3m/pythonrun.h:25:18:
> note: candidate function not viable: no known conversion from 'char *' to
> 'wchar_t *' for 1st
>
>   argument
>
> PyAPI_FUNC(void) Py_SetProgramName(wchar_t *);
> --
>
> I have attached the patch (pgadminpro.patch) to fix this.

Configuration and build fails for me with this:

Project MESSAGE: Building for QT5+...
Project MESSAGE: Configure pgAdmin4 to run in debug mode...
Project MESSAGE: Building for Linux/Mac...
/bin/sh: python3-config: command not found
/bin/sh: python3-config: command not found
/bin/sh: python3-config: command not found
Project MESSAGE: Python3 detected.

(pgadmin4)piranha:pgAdmin4 dpage$ which python-config
/usr/bin/python-config
(pgadmin4)piranha:pgAdmin4 dpage$ which python3-config
(pgadmin4)piranha:pgAdmin4 dpage$ locate python3-config
(pgadmin4)piranha:pgAdmin4 dpage$ python-config --libs
-lpython2.7 -ldl -framework CoreFoundation

Though - I also get some funky output without the patch (but, the
build succeeds):

Project MESSAGE: Building for QT5+...
Project MESSAGE: Configure pgAdmin4 to run in debug mode...
Project MESSAGE: Building for Linux/Mac...
/bin/sh: python3-config: command not found
/bin/sh: python3-config: command not found
/bin/sh: python3-config: command not found


> Another thing i observed is that in venv, the encodings directory in sym
> linked to the actual one on the system and hence the build fails with the
> following error:
> --
> Could not find platform independent libraries 
> Could not find platform dependent libraries 
> Consider setting $PYTHONHOME to [:]
> Fatal Python error: Py_Initialize: unable to load the file system codec
> ImportError: No module named 'encodings'
> --
>
> I have attached the patch (pgadmin-macbuild.patch) to make sure the
> virtualenv for macbuild copies the required files instead of linking. In the
> same patch, I also modified the build script to not rename the actual
> directory of python in venv (as python libs may refer the actual directory)
> and instead create a sym link. There might be other way to fix this, but I
> found this to be easy. :)

This second patch breaks builds for me:

PYTHON_HOME not set. Setting it to default
QTDIR not set. Setting it to default
PGDIR not set. Setting it to default
Cleaning up the old environment and app bundle
Running virtualenv with interpreter
/System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2
Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 2311, in 
main()
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 703, in main
symlink=options.symlink)
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 916, in
create_environment
site_packages=site_packages, clear=clear, symlink=symlink))
  File "/Library/Python/2.7/site-packages/virtualenv.py", line ,
in install_python
copyfile(join(stdlib_dir, fn), join(lib_dir, fn), symlink)
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 352, in copyfile
copyfileordir(src, dest, symlink)
  File "/Library/Python/2.7/site-packages/virtualenv.py", line 324, in
copyfileordir
shutil.copytree(src, dest, symlink)
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py",
line 208, in copytree
raise Error, errors
shutil.Error: 
[('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/config.c',
'/Users/dpage/git/pgadmin4/mac-build/venv/lib/python2.7/config/config.c',
"[Errno 1] Operation not permitted:
'/Users/dpage/git/pgadmin4/mac-build/venv/lib/python2.7/config/config.c'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/config.c.in',
'/Users/dpage/git/pgadmin4/mac-build/venv/lib/python2.7/config/config.c.in',
"[Errno 1] Operation not permitted:
'/Users/dpage/git/pgadmin4/mac-build/venv/lib/python2.7/config/config.c.in'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/install-sh',
'/Users/dpage/git/pgadmin4/mac-build/venv/lib/python2.7/config/install-sh',
"[Errno 1] Operation not permitted:
'/Users/dpage/git/pgadmin4/mac-build/venv/lib/python2.7/config/install-sh'"),
('/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config/libpython2.7.a',

Re: [pgadmin-hackers] Patches

[Dave Page]

Hi

On Thu, Jun 16, 2016 at 8:51 AM, Sandeep Thakkar
 wrote:
> Hi,
>
> I created virtual environment and tried building pgadmin on my Mac with
> Python 3.3 and QT 5.5. I observed that in venv, the python3-config is copied
> as python-config. Therefore, it's required to change pgAdmin4.pro to handle
> this. With the existing .pro, it does not find the python3-config and
> assumes it is Python2 and throws the following build error:

My Mac is a fully patched El Capitan installation, and has Python
2.7.10. Why do you need Python 3 support for this build?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Patches

[Sandeep Thakkar]

Hi,

I created virtual environment and tried building pgadmin on my Mac with
Python 3.3 and QT 5.5. I observed that in venv, the python3-config is
copied as python-config. Therefore, it's required to change pgAdmin4.pro to
handle this. With the existing .pro, it does not find the python3-config
and assumes it is Python2 and throws the following build error:
--






*Server.cpp:36:5: error: no matching function for call to
'Py_SetProgramName'
Py_SetProgramName(PGA_APP_NAME.toUtf8().data());/mnt/hgfs/pginstaller.pune/server/source/pgadmin.osx/mac-build/venv/include/python3.3m/pythonrun.h:25:18:
note: candidate function not viable: no known conversion from 'char *' to
'wchar_t *' for 1st  argumentPyAPI_FUNC(void) Py_SetProgramName(wchar_t
*);*
--

I have attached the patch (pgadminpro.patch) to fix this.

Another thing i observed is that in venv, the encodings directory in sym
linked to the actual one on the system and hence the build fails with the
following error:
--




*Could not find platform independent libraries Could not find
platform dependent libraries Consider setting $PYTHONHOME to
[:]Fatal Python error: Py_Initialize: unable to load
the file system codecImportError: No module named 'encodings'*
--

I have attached the patch (pgadmin-macbuild.patch) to make sure the
virtualenv for macbuild copies the required files instead of linking. In
the same patch, I also modified the build script to not rename the actual
directory of python in venv (as python libs may refer the actual directory)
and instead create a sym link. There might be other way to fix this, but I
found this to be easy. :)

Thanks!


--
Sandeep Thakkar


pgadmin-macbuild.patch
Description: Binary data


pgadminpro.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patches that rename .rst and .png files in pgadmin4 repository

[Dave Page]

Hi

On Fri, May 20, 2016 at 8:06 AM, Susan Douglas
 wrote:
> Hi All,
>
> I've attached patches that rename the .rst files and .png files in the 
> pgadmin4 repository (removing the create_ prefix from the names).  There are 
> no changes to the file content in these patches; I'll submit separate patches 
> for the content change after you've applied these changes.

The image update patch won't apply:

snake:pgadmin4 dpage$ git apply ~/Downloads/rename-image-files.patch
fatal: git diff header lacks filename information when removing 1
leading pathname component (line 4)
snake:pgadmin4 dpage$ patch -p1 < ~/Downloads/rename-image-files.patch
patch:  Only garbage was found in the patch input.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patches

[Guillaume Lelarge]

Le 22/01/2010 09:42, Dave Page a écrit :
 On Thu, Jan 21, 2010 at 9:46 PM, Guillaume Lelarge
 guilla...@lelarge.info wrote:
 Hi,

 I intend to work next on ticket 99 (Default ACLs). I'll need to change
 the role dialog that my previous patch already changed. Actually, I have
 quite some patches in the pipe. git makes it so easy to work on multiple
 patches, it is just marvellous. So I'll have to apply some of my patches
 to the SVN if I want to continue to work without too much fuss. At
 least, I'll need to commit the last one (ticket 102) ASAP.
 
 Yeah, you're really pumping them out at the moment :-). I'm afraid to
 say that once again I've got *really* busy - this time putting
 together a new build server for the 9.0 installers, which is somewhat
 more complex than one might expect (new versions of the 4 base OSs,
 each with their own quirks etc), build environments to setup for 30+
 bits of software on each platform...
 

No problem. I'll check each of my patches on Windows and Mac OS X
tomorrow, and apply the good one.

 I'm happy that pgAdmin is getting such attention from such capable
 hands for this release :-)
 

Thanks :)

I'm not sure I share your opinion. I hope I'm not adding too many bugs..


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patches and a .po file

[Dave Page]

Thanks, updates applied.

Regards Dave 

 -Original Message-
 From: Guillaume Lelarge [mailto:[EMAIL PROTECTED] 
 Sent: 27 September 2006 23:39
 To: Dave Page
 Cc: pgadmin-hackers@postgresql.org
 Subject: Re: [pgadmin-hackers] Patches and a .po file
 
 Dave Page a écrit :
  [...]
   - frmReport : the object type is now translated on the 
 report and I
  added a dash before the report's type because it was not 
  translatable in
  french as is, but it is now... and it is still good english 
  (at least, I
  hope so).
  
  It doesn't look great actually. I think the correct fix is something
  more like:
  
  title.Printf(_(%s DDL Report - ), object-GetTypeName());
  title += object-GetIdentifier();
  report-SetReportTitle(title);
  
  Then you can translate 
  
  _(%s DDL Report - )
  
  To
  
  _(DDL Report %s - )
  
  Or whatever is actually right in French. Can you update you 
 patch if you
  agree please?
  
 
 You'll find a new patch attached.
 
  BTW, I *haven't* committed your translation update yet in case it
  contains strings you're about to remove.
  
 
 The .po is also attached. It contains the new strings.
 
 Regards.
 
 PS : I checked your fix, it works great. Thanks.
 
 
 -- 
 Guillaume.
 !-- http://abs.traduc.org/
  http://lfs.traduc.org/
  http://traduc.postgresqlfr.org/ --
 

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org

Re: [pgadmin-hackers] Patches and a .po file

[Dave Page]

 

 -Original Message-
 From: Guillaume Lelarge [mailto:[EMAIL PROTECTED] 
 Sent: 27 September 2006 08:17
 To: pgadmin-hackers@postgresql.org
 Cc: Dave Page
 Subject: Patches and a .po file
 
 Hi all,
 
 Here is a new french .po file.
 
 I also attached one patch.
  - frmEditGrid : it allows translators to translate the no limit/1000
 rows/500 rows/100 rows combo of the edit grid window but I 
 don't think
 I updated the pot file...

Hmm, OK thought I'd done that but obviously not.

  - frmReport : the object type is now translated on the report and I
 added a dash before the report's type because it was not 
 translatable in
 french as is, but it is now... and it is still good english 
 (at least, I
 hope so).

It doesn't look great actually. I think the correct fix is something
more like:

title.Printf(_(%s DDL Report - ), object-GetTypeName());
title += object-GetIdentifier();
report-SetReportTitle(title);

Then you can translate 

_(%s DDL Report - )

To

_(DDL Report %s - )

Or whatever is actually right in French. Can you update you patch if you
agree please?

BTW, I *haven't* committed your translation update yet in case it
contains strings you're about to remove.

 BTW, did someone test pgAdmin on Linux ? because I have really lots of
 crashes in the query tool that makes this tool totaly 
 unusable. I really
 think this is my fault because the windows official build 
 works great...
 and my linux build doesn't. I certainely have done something 
 wrong but I
 don't know what. I compiled wxWidget 2.7 and pgAdmin latest svn... I
 still have many problems. So, did someone test the query tool 
 on linux ?

I have briefly, and I'd be surpised if others haven't as well. What are
the exact issues you are seeing?

Regards, Dave.

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match

Re: [pgadmin-hackers] Patches and a .po file

[Guillaume Lelarge]

Dave Page a ecrit le 27/09/2006 09:55:

I also attached one patch.
 - frmEditGrid : it allows translators to translate the no limit/1000
rows/500 rows/100 rows combo of the edit grid window but I 
don't think

I updated the pot file...


Hmm, OK thought I'd done that but obviously not.


 - frmReport : the object type is now translated on the report and I
added a dash before the report's type because it was not 
translatable in
french as is, but it is now... and it is still good english 
(at least, I

hope so).


It doesn't look great actually. I think the correct fix is something
more like:

title.Printf(_(%s DDL Report - ), object-GetTypeName());
title += object-GetIdentifier();
report-SetReportTitle(title);


Oh, great. I don't know why I didn't think about this kind of fix.

Then you can translate 


_(%s DDL Report - )

To

_(DDL Report %s - )

Or whatever is actually right in French. Can you update you patch if you
agree please?



I completely and I'll update my patch tonight.


BTW, I *haven't* committed your translation update yet in case it
contains strings you're about to remove.



Yes, I'll update the pot file and update my po file too... so, don't 
commit this one.



BTW, did someone test pgAdmin on Linux ? because I have really lots of
crashes in the query tool that makes this tool totaly 
unusable. I really
think this is my fault because the windows official build 
works great...
and my linux build doesn't. I certainely have done something 
wrong but I

don't know what. I compiled wxWidget 2.7 and pgAdmin latest svn... I
still have many problems. So, did someone test the query tool 
on linux ?


I have briefly, and I'd be surpised if others haven't as well. What are
the exact issues you are seeing?



When I'm on the query tool, it crashes at random in less than 30s. It 
can crash when I write a query. It can crash when I go in the View menu. 
It crashes on so many places that I really think this is my fault... 
badly compiled wxwidget ? I also can't resize panels.


Doing some checks on the windows release, I found something weird. My 
current setting for user's language is french. I go in the View menu, 
choose Default view... and all panels' titles are now in english. If I 
hide a panel or if I hide and show the complete window, all panels' 
titles change to french. Weird, isn't it ? :)


Regards.


--
Guillaume.

---(end of broadcast)---
TIP 4: Have you searched our list archives?

  http://archives.postgresql.org

Re: [pgadmin-hackers] Patches and a .po file

[Dave Page]

 

 -Original Message-
 From: Guillaume Lelarge [mailto:[EMAIL PROTECTED] 
 Sent: 27 September 2006 09:44
 To: Dave Page
 Cc: pgadmin-hackers@postgresql.org
 Subject: Re: [pgadmin-hackers] Patches and a .po file
 
 When I'm on the query tool, it crashes at random in less than 30s. It 
 can crash when I write a query. It can crash when I go in the 
 View menu. 
 It crashes on so many places that I really think this is my fault... 
 badly compiled wxwidget ? I also can't resize panels.

I've just been playing with it in Slackware and couldn't make it crash
at all. What OS are you on? I know at one point there was an issue with
Ubuntu that made the styled text controls unstable.

It might be worth resetting to the default view for that form, either by
selecting the option from the view menu if you can, or by removing the
frmQuery/Perspective setting form your settings file.

 Doing some checks on the windows release, I found something weird. My 
 current setting for user's language is french. I go in the View menu, 
 choose Default view... and all panels' titles are now in 
 english. If I 
 hide a panel or if I hide and show the complete window, all panels' 
 titles change to french. Weird, isn't it ? :)

This should be fixed in SVN now.

Thanks, Dave.

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org

Re: [pgadmin-hackers] Patches and a .po file

[Guillaume Lelarge]

Dave Page a ecrit le 27/09/2006 13:13:
When I'm on the query tool, it crashes at random in less than 30s. It 
can crash when I write a query. It can crash when I go in the 
View menu. 
It crashes on so many places that I really think this is my fault... 
badly compiled wxwidget ? I also can't resize panels.


I've just been playing with it in Slackware and couldn't make it crash
at all. What OS are you on? I know at one point there was an issue with
Ubuntu that made the styled text controls unstable.



Yes, I forgot to give you this information. It is a Kubuntu 6.06, 
updated as much as possible.


I don't understand the issue you talk about. The styled text controls 
are wxWidgets ones ? and wxWidgets is a package I had to compile... so, 
how could these controls become unstable on a specific distro ?



It might be worth resetting to the default view for that form, either by
selecting the option from the view menu if you can, or by removing the
frmQuery/Perspective setting form your settings file.



I'll try this tonight.

Doing some checks on the windows release, I found something weird. My 
current setting for user's language is french. I go in the View menu, 
choose Default view... and all panels' titles are now in 
english. If I 
hide a panel or if I hide and show the complete window, all panels' 
titles change to french. Weird, isn't it ? :)


This should be fixed in SVN now.



Great.

Regards.


--
Guillaume.

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [pgadmin-hackers] Patches and a .po file

[Dave Page]

 

 -Original Message-
 From: Guillaume Lelarge [mailto:[EMAIL PROTECTED] 
 Sent: 27 September 2006 12:47
 To: Dave Page
 Cc: pgadmin-hackers@postgresql.org
 Subject: Re: [pgadmin-hackers] Patches and a .po file
 
 Dave Page a ecrit le 27/09/2006 13:13:
  When I'm on the query tool, it crashes at random in less 
 than 30s. It 
  can crash when I write a query. It can crash when I go in the 
  View menu. 
  It crashes on so many places that I really think this is 
 my fault... 
  badly compiled wxwidget ? I also can't resize panels.
  
  I've just been playing with it in Slackware and couldn't 
 make it crash
  at all. What OS are you on? I know at one point there was 
 an issue with
  Ubuntu that made the styled text controls unstable.
  
 
 Yes, I forgot to give you this information. It is a Kubuntu 6.06, 
 updated as much as possible.
 
 I don't understand the issue you talk about. The styled text controls 
 are wxWidgets ones ? and wxWidgets is a package I had to 
 compile... so, 
 how could these controls become unstable on a specific distro ?

A bug in a version of one of the libraries that the control depends on.
We saw an issue a few months ago on Ubuntu where people where
complaining about instability on some quite specific versions iirc.
Upgrading to the latest release of Ubuntu seemed to resolve the issue in
all case.

Florian spent some time working on it from what I recall - he might
remember more details.

Regards, Dave.

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq

Re: [pgadmin-hackers] Patches and a .po file

[Dave Page]

-Original Message-
From: Guillaume Lelarge [EMAIL PROTECTED]
To: Dave Page dpage@vale-housing.co.uk
Cc: pgadmin-hackers@postgresql.org pgadmin-hackers@postgresql.org
Sent: 27/09/06 19:22
Subject: Re: [pgadmin-hackers] Patches and a .po file


 Well, removing the frmQuery/Perspective setting in .pgadmin3 wasn't
 enough. I had to delete the complete file to get a functionnal query tool.

Did you keep a copy? I'd like to know what borked your installation so badly.

 Thanks a lot, now I can write this article and work on the patch.

:-)

/D
---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings

Re: [pgadmin-hackers] [PATCHES] Adminpack contrib module

[Bruce Momjian]

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---


Dave Page wrote:
 A few weeks ago following a discussion on pgsql-general it was proposed that
 the pgAdmin 'adminpack' contrib module be added to /contrib in the server's
 source tree to make it easier for users to find and install.
 
 There were no objections, so attached is an updated version of the
 adminpack, with non-version specific naming for addition to the source tree.
 The entire directory in the archive should be added to /contrib, and an
 appropriate entry added to contrib/Makefile.
 
 Regards, Dave
 

[ Attachment, skipping... ]

 
 ---(end of broadcast)---
 TIP 2: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings

Re: [pgadmin-hackers] [PATCHES] libpq endless loop if client_min_messages=debug1

[Tom Lane]

Andreas Pflug [EMAIL PROTECTED] writes:
 The attached patch fixes this. I wonder if there are additional message 
 types that might be longer?

We should allow error messages to be long too, I guess, and I also added
NOTIFY messages since there's no telling what people might try to do
with the data payload string once we implement that.

I also fixed the underlying infinite-loop problem.

regards, tom lane

---(end of broadcast)---
TIP 8: explain analyze is your friend

Re: [pgadmin-hackers] [PATCHES] libpq endless loop if client_min_messages=debug1

[Tom Lane]

Andreas Pflug [EMAIL PROTECTED] writes:
 I reproduced this problem with 7.5 head backend and libpq under win32 
 and Linux, and found that the problem is pqParseInput3 expecting a 
 message length = 3 only for message types 'T', 'D' and 'd', but not 
 'N'.

Oops.  Good catch.

regards, tom lane

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings