[pgadmin-hackers] SVN Commit by dpage: r6251 - in trunk/pgadmin3: . pgadmin pgadmin/frm pgadmin/include pgadmin/include/images pgadmin/include/schema pkg/win32

2007-05-01 Thread svn 
Author: dpage

Date: 2007-05-01 08:04:06 + (Tue, 01 May 2007)

New Revision: 6251

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6251&view=rev

Log:
Don't install XRC files with non-debug builds. After hacking at this for some 
time, I'm still not entirely sure how it works as it seems it should omit them 
during 'make dist' as well, but it doesn't, and seems to behave exactly as it 
needs to. Perhaps someone with more automake/make foo than I can explain!

While we're at it, initialise a variable to silence a GCC warning.



Modified:
   trunk/pgadmin3/configure.ac.in
   trunk/pgadmin3/pgadmin/Makefile.am
   trunk/pgadmin3/pgadmin/frm/frmExport.cpp
   trunk/pgadmin3/pgadmin/include/images/module.mk
   trunk/pgadmin3/pgadmin/include/module.mk
   trunk/pgadmin3/pgadmin/include/schema/module.mk
   trunk/pgadmin3/pkg/win32/Makefile.am

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match

[pgadmin-hackers] SVN Commit by dpage: r6252 - trunk/www/development

2007-05-01 Thread svn 
Author: dpage

Date: 2007-05-01 08:05:13 + (Tue, 01 May 2007)

New Revision: 6252

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6252&view=rev

Log:
Roadmap item complete - Yay!! Last one!!



Modified:
   trunk/www/development/roadmap.php

---(end of broadcast)---
TIP 6: explain analyze is your friend

Re: [pgadmin-hackers] compile problems

2007-05-01 Thread Florian G. Pflug 

Giuseppe Sacco wrote:

if gcc -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/include/postgresql -DSSL
-I/usr/local/wxWidgets-2.8.2/lib/wx/include/gtk2-unicode-release-2.8
-I/usr/local/wxWidgets-2.8.2/include/wx-2.8 -D_FILE_OFFSET_BITS=64
-D_LARGE_FILES -D_LARGEFILE_SOURCE=1 -D__WXGTK__ -O2
-I/usr/include/libxml2 -I/usr/include/libxml2 -DDATA_DIR=
\"/usr/local/pgadmin3-1.8.2/share/pgadmin3/\" -Wall -I../pgadmin/include
-MT keywords.o -MD -MP -MF ".deps/keywords.Tpo" -c -o keywords.o `test
-f './db/keywords.c' || echo './'`./db/keywords.c; \
then mv -f ".deps/keywords.Tpo" ".deps/keywords.Po"; else rm -f
".deps/keywords.Tpo"; exit 1; fi
In file included from ./db/keywords.c:22:
gram.y:122: error: expected specifier-qualifier-list before ‘JoinType’
make[2]: *** [keywords.o] Error 1

I checked the source and I believe there is something missing: JoinType
is never defined. Could you please tell me in what source it is defined?

Hm, the files
pgadmin/include/keywords.h,
pgadmin/include/parse.h,
pgadmin/db/keywords.c
are periodically copied from the postgresql sources, where parse.h is
actually generated by bison from gram.y

JoinType is some postgresql-internal datastructure, that is neither needed
nor used inside pgAdmin3 - it just happens to be mentioned in parse.h, because
this file originates from postgresql.

I think that the only parts of parse.h that pgAdmin3 is interested in are
the defines at the top, and maybe the enum yytokentype.

misc.cpp does the following before including parse.h to suppress the typedef:
#define YYSTYPE_IS_DECLARED
#define DECIMAL DECIMAL_P
  typedef int YYSTYPE;

while postgres.h (which is included in keywords.c before parse.h) does the
following:
#define YYTOKENTYPE
#define YYSTYPE int

I think that for some reason, the former does what it's supposed to on your
system, but that latter doesn't. Could you try replacing
#define YYTOKENTYPE
#define YYSTYPE int
in postgres.h with
#define YYSTYPE_IS_DECLARED
  typedef int YYSTYPE;
and see if that helps? If no, please also try adding the
#define YYTOKENTYPE back to postgres.h (but keep the other changes)

@dave: I think that the "#define DECIMAL DECIMAP_P" isn't needed anymore -
or at least "find ./ -name "*.h" | xargs grep DECIMAL" and
"find ./ -name "*.c" | xargs grep DECIMAL" seem to indicate that...

greetings, Florian Pflug



---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings

[pgadmin-hackers] SVN Commit by dpage: r6253 - trunk/pgadmin3/pgadmin/utils

2007-05-01 Thread svn 
Author: dpage

Date: 2007-05-01 15:55:01 + (Tue, 01 May 2007)

New Revision: 6253

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6253&view=rev

Log:
Remove an obsolete macro, per Florian.


Modified:
   trunk/pgadmin3/pgadmin/utils/misc.cpp

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org

Re: [pgadmin-hackers] compile problems

2007-05-01 Thread Dave Page 

Florian G. Pflug wrote:

@dave: I think that the "#define DECIMAL DECIMAP_P" isn't needed anymore -
or at least "find ./ -name "*.h" | xargs grep DECIMAL" and
"find ./ -name "*.c" | xargs grep DECIMAL" seem to indicate that...


Yeah, seems to be surplus. Removed, thanks.

/D

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [pgadmin-hackers] compile problems

2007-05-01 Thread Guillaume Lelarge 

Dave Page a écrit :

Florian G. Pflug wrote:
@dave: I think that the "#define DECIMAL DECIMAP_P" isn't needed 
anymore -

or at least "find ./ -name "*.h" | xargs grep DECIMAL" and
"find ./ -name "*.c" | xargs grep DECIMAL" seem to indicate that...


Yeah, seems to be surplus. Removed, thanks.



I don't think so. Or you need this patch :)

Regards.


--
Guillaume.
http://www.postgresqlfr.org
http://docs.postgresqlfr.org
Index: pgadmin/utils/misc.cpp
===
--- pgadmin/utils/misc.cpp	(révision 6253)
+++ pgadmin/utils/misc.cpp	(copie de travail)
@@ -356,7 +356,7 @@
 case BOOLEAN_P:
 case CHAR_P:
 case CHARACTER:
-case DECIMAL:
+case DECIMAL_P:
 case DOUBLE_P:
 case FLOAT_P:
 case INT_P:

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org