Re: [pgadmin-hackers] SSH Tunneling implementation
On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge wrote: > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: >> >> Not for me - and I'd be the first to complain if I saw it doing that. >> What do you see? >> > > These: > > ./ogl/drawn.cpp: In member function ‘virtual void wxOpSetGDI::Do(wxDC&, > double, double)’: > ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] > ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] > ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] > ./ogl/drawn.cpp: In member function ‘virtual void > wxPseudoMetaFile::SetPen(wxPen*, bool)’: > ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] > ./ogl/drawn.cpp: In member function ‘virtual void > wxPseudoMetaFile::SetBrush(wxBrush*, bool)’: > ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] What platform/GCC version? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] More information about the selected objects
On Mon, Jul 16, 2012 at 10:22 PM, Guillaume Lelarge wrote: > On Sat, 2012-07-14 at 20:48 +0100, Dave Page wrote: >> >> >> On Saturday, July 14, 2012, Guillaume Lelarge wrote: >> On Sat, 2012-07-14 at 18:57 +0100, Dave Page wrote: >> > >> > >> > On Saturday, July 14, 2012, Guillaume Lelarge wrote: >> > On Sat, 2012-07-14 at 11:28 -0300, Vinicius Santos >> wrote: >> > > >> > > Not sure I like the point either. We don't >> have that >> > notation >> > > on >> > > PostgreSQL. I think I would prefer >> something like >> > "Retrieving >> > > details on >> > > table schema.table" and not say the >> database. >> > Because if you >> > > add the >> > > database, someone will probably want also >> the >> > server. It may >> > > not be >> > > usefull to you, but it'll come at some >> point. And >> > that's quite >> > > a lot of >> > > informations. >> > > >> > > I agree. >> > > >> > > >> > > >> > > Probably we could add some status boxes in >> the >> > status bar. For >> > > exemple, >> > > a box with a "user@database >> (server)" (with a lock >> > icon if you >> > > use SSL >> > > for example. Just a thought. >> > > >> > > >> > > >> > > I liked the idea! >> > > >> > > We could add status boxes in front of the >> information >> > "Retrieving >> > > details ...". >> > > >> > > For example, suppose that is the status bar: >> > > >> > > With 3 status boxes: >> > > >> > > || "Retrieving details on schema.table" || >> user@database || >> > server || >> > > >> > > or with 2 status boxes: >> > > >> > > || "Retrieving details on schema.table" || >> user@database >> > ( server ) >> > > || >> > > >> > > >> > >> > I think I like the second one better, but this is >> just my >> > opinion. >> > >> > >> > Aside from it being a needless amount of information to >> clutter the >> > display with, I can pretty much guarantee you won't be able >> to figure >> > out a clean way of sizing the panels to accomodate all that >> data >> > without truncating one or more of them for some selected >> objects. >> > >> >> Are we talking about the same thing? I'm not suggesting to add >> a panel. >> I'm suggesting to add another box in the status bar >> (wxStatusBar >> object). It won't take any more space than before. >> >> >> The bar won't, but the text in it will. >> > > Yes, and? I don't see how that could be much of a problem. You'll end up with a bunch of truncated text labels making the status bar look busy, overly complex and distracting, and not necessarily conveying the information it's trying to. Resizing won't help as you can only have one "sprung" pane on some (all?) platforms and that needs to be the one displaying the status messages (which we do not want to be truncated either). -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] SSH Tunneling implementation
On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: > On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge > wrote: > > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: > >> > >> Not for me - and I'd be the first to complain if I saw it doing that. > >> What do you see? > >> > > > > These: > > > > ./ogl/drawn.cpp: In member function ‘virtual void wxOpSetGDI::Do(wxDC&, > > double, double)’: > > ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of > > different size [-Wint-to-pointer-cast] > > ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of > > different size [-Wint-to-pointer-cast] > > ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of > > different size [-Wint-to-pointer-cast] > > ./ogl/drawn.cpp: In member function ‘virtual void > > wxPseudoMetaFile::SetPen(wxPen*, bool)’: > > ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of > > different size [-Wint-to-pointer-cast] > > ./ogl/drawn.cpp: In member function ‘virtual void > > wxPseudoMetaFile::SetBrush(wxBrush*, bool)’: > > ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of > > different size [-Wint-to-pointer-cast] > > What platform/GCC version? > Fedora 17, gcc 4.7 (gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)). With full updates on every possible RPM. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] SSH Tunneling implementation
On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge wrote: > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: >> On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge >> wrote: >> > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: >> >> >> >> Not for me - and I'd be the first to complain if I saw it doing that. >> >> What do you see? >> >> >> > >> > These: >> > >> > ./ogl/drawn.cpp: In member function ‘virtual void wxOpSetGDI::Do(wxDC&, >> > double, double)’: >> > ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of >> > different size [-Wint-to-pointer-cast] >> > ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of >> > different size [-Wint-to-pointer-cast] >> > ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of >> > different size [-Wint-to-pointer-cast] >> > ./ogl/drawn.cpp: In member function ‘virtual void >> > wxPseudoMetaFile::SetPen(wxPen*, bool)’: >> > ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of >> > different size [-Wint-to-pointer-cast] >> > ./ogl/drawn.cpp: In member function ‘virtual void >> > wxPseudoMetaFile::SetBrush(wxBrush*, bool)’: >> > ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of >> > different size [-Wint-to-pointer-cast] >> >> What platform/GCC version? >> > > Fedora 17, gcc 4.7 (gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)). With > full updates on every possible RPM. 32 or 64 bit? Intel I assume? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] SSH Tunneling implementation
On Tue, 2012-07-17 at 08:30 +0100, Dave Page wrote: > On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge > wrote: > > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: > >> On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge > >> wrote: > >> > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: > >> >> > >> >> Not for me - and I'd be the first to complain if I saw it doing that. > >> >> What do you see? > >> >> > >> > > >> > These: > >> > > >> > ./ogl/drawn.cpp: In member function ‘virtual void wxOpSetGDI::Do(wxDC&, > >> > double, double)’: > >> > ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of > >> > different size [-Wint-to-pointer-cast] > >> > ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of > >> > different size [-Wint-to-pointer-cast] > >> > ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of > >> > different size [-Wint-to-pointer-cast] > >> > ./ogl/drawn.cpp: In member function ‘virtual void > >> > wxPseudoMetaFile::SetPen(wxPen*, bool)’: > >> > ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of > >> > different size [-Wint-to-pointer-cast] > >> > ./ogl/drawn.cpp: In member function ‘virtual void > >> > wxPseudoMetaFile::SetBrush(wxBrush*, bool)’: > >> > ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of > >> > different size [-Wint-to-pointer-cast] > >> > >> What platform/GCC version? > >> > > > > Fedora 17, gcc 4.7 (gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)). With > > full updates on every possible RPM. > > 32 or 64 bit? Intel I assume? > Intel 64 bit. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] SSH Tunneling implementation
On Tue, Jul 17, 2012 at 8:56 AM, Guillaume Lelarge wrote: > On Tue, 2012-07-17 at 08:30 +0100, Dave Page wrote: >> On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge >> wrote: >> > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: >> >> On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge >> >> wrote: >> >> > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: >> >> >> >> >> >> Not for me - and I'd be the first to complain if I saw it doing that. >> >> >> What do you see? >> >> >> >> >> > >> >> > These: >> >> > >> >> > ./ogl/drawn.cpp: In member function ‘virtual void wxOpSetGDI::Do(wxDC&, >> >> > double, double)’: >> >> > ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of >> >> > different size [-Wint-to-pointer-cast] >> >> > ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of >> >> > different size [-Wint-to-pointer-cast] >> >> > ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of >> >> > different size [-Wint-to-pointer-cast] >> >> > ./ogl/drawn.cpp: In member function ‘virtual void >> >> > wxPseudoMetaFile::SetPen(wxPen*, bool)’: >> >> > ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of >> >> > different size [-Wint-to-pointer-cast] >> >> > ./ogl/drawn.cpp: In member function ‘virtual void >> >> > wxPseudoMetaFile::SetBrush(wxBrush*, bool)’: >> >> > ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of >> >> > different size [-Wint-to-pointer-cast] >> >> >> >> What platform/GCC version? >> >> >> > >> > Fedora 17, gcc 4.7 (gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)). With >> > full updates on every possible RPM. >> >> 32 or 64 bit? Intel I assume? >> > > Intel 64 bit. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent reports failure upon success - For Review
Hi
This still seems to be malformed - I'm getting:
raptor:pgagent dpage$ patch -p1 < ~/Downloads/pgagent.patch
(Stripping trailing CRs from patch.)
patching file connection.cpp
patch: malformed patch at line 6: if (result)
Looking at the patch itself, it looks like the indentation is missing
from the first hunk for connection.cpp:
diff --git a/connection.cpp b/connection.cpp
index 5e10078..6103c00 100644
--- a/connection.cpp
+++ b/connection.cpp
@@ -336,6 +336,7 @@ DBresult::DBresult(DBconn *conn, const wxString &query)
if (result)
{
int rc = PQresultStatus(result);
+ conn->SetLastResult(rc);
if (rc == PGRES_TUPLES_OK)
maxRows = PQntuples(result);
else if (rc != PGRES_COMMAND_OK)
If I look at the source file, it's more like this (he says, hoping
Gmail doesn't mangle it):
if (result)
{
int rc = PQresultStatus(result);
if (rc == PGRES_TUPLES_OK)
maxRows = PQntuples(result);
else if (rc != PGRES_COMMAND_OK)
How are you generating the patch? Has your unmodified version been
inadvertently modified?
On Tue, Jul 17, 2012 at 7:22 AM, Martin French
wrote:
> (See attached file: pgAgent.patch)
>
> Hi
>
> pgadmin-hackers-ow...@postgresql.org wrote on 16/07/2012 15:52:45:
>
>> From: Dave Page
>> To: Martin French ,
>> Cc: pgadmin-hackers@postgresql.org
>> Date: 16/07/2012 18:55
>> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent
>> reports failure upon success - For Review
>> Sent by: pgadmin-hackers-ow...@postgresql.org
>
>
>>
>> Hi
>>
>> Can you resend the patch as an attachment please? It's getting
>> corrupted inline in email.
>>
>> Thanks.
>>
>> On Mon, Jul 16, 2012 at 2:46 PM, Martin French
>> wrote:
>> > Hi,
>> >
>> > I have attempted a patch for an issue where pgAgent incorrectly reports
>> > failure on a plain SQL job. Please see below.
>> >
>> > Feedback/comments welcome.
>> >
>> > Thanks
>> >
>> > Martin French.
>> >
>> >
>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
> Patch attached. Apologies for that. :)
>
> Cheers
>
> Martin French= Romax Technology
> Limited Rutherford House Nottingham Science & Technology Park Nottingham,
> NG7 2PZ England Telephone numbers: +44 (0)115 951 88 00 (main) For other
> office locations see: http://www.romaxtech.com/Contact
> = === E-mail: i...@romaxtech.com
> Website: www.romaxtech.com =
> Confidentiality Statement This transmission is for the
> addressee only and contains information that is confidential and privileged.
> Unless you are the named addressee, or authorised to receive it on behalf of
> the addressee you may not copy or use it, or disclose it to anyone else. If
> you have received this transmission in error please delete from your system
> and contact the sender. Thank you for your cooperation.
> =
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent reports failure upon success - For Review
Hi Dave.Dave Page wrote on 17/07/2012 10:45:28:> From: Dave Page > To: Martin French , > Cc: pgadmin-hackers@postgresql.org, pgadmin-hackers-ow...@postgresql.org> Date: 17/07/2012 10:45> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent > reports failure upon success - For Review> > Hi> > This still seems to be malformed - I'm getting:> > raptor:pgagent dpage$ patch -p1 < ~/Downloads/pgagent.patch> (Stripping trailing CRs from patch.)> patching file connection.cpp> patch: malformed patch at line 6: if (result)> > Looking at the patch itself, it looks like the indentation is missing> from the first hunk for connection.cpp:> > diff --git a/connection.cpp b/connection.cpp> index 5e10078..6103c00 100644> --- a/connection.cpp> +++ b/connection.cpp> @@ -336,6 +336,7 @@ DBresult::DBresult(DBconn *conn, const wxString &query)> if (result)> {> int rc = PQresultStatus(result);> + conn->SetLastResult(rc);> if (rc == PGRES_TUPLES_OK)> maxRows = PQntuples(result);> else if (rc != PGRES_COMMAND_OK)> > If I look at the source file, it's more like this (he says, hoping> Gmail doesn't mangle it):> > if (result)> {> int rc = PQresultStatus(result);> if (rc == PGRES_TUPLES_OK)> maxRows = PQntuples(result);> else if (rc != PGRES_COMMAND_OK)> > How are you generating the patch? Has your unmodified version been> inadvertently modified?> > On Tue, Jul 17, 2012 at 7:22 AM, Martin French> wrote:> > (See attached file: pgAgent.patch)> >> > Hi> >> > pgadmin-hackers-ow...@postgresql.org wrote on 16/07/2012 15:52:45:> >> >> From: Dave Page > >> To: Martin French ,> >> Cc: pgadmin-hackers@postgresql.org> >> Date: 16/07/2012 18:55> >> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent> >> reports failure upon success - For Review> >> Sent by: pgadmin-hackers-ow...@postgresql.org> >> >> >>> >> Hi> >>> >> Can you resend the patch as an attachment please? It's getting> >> corrupted inline in email.> >>> >> Thanks.> >>> >> On Mon, Jul 16, 2012 at 2:46 PM, Martin French> >> wrote:> >> > Hi,> >> >> >> > I have attempted a patch for an issue where pgAgent incorrectly reports> >> > failure on a plain SQL job. Please see below.> >> >> >> > Feedback/comments welcome.> >> >> >> > Thanks> >> >> >> > Martin French.> >> >> >> >> >> >>> >>> >>> >> --> >> Dave Page> >> Blog: http://pgsnake.blogspot.com> >> Twitter: @pgsnake> >>> >> EnterpriseDB UK: http://www.enterprisedb.com> >> The Enterprise PostgreSQL Company> >>> >> --> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)> >> To make changes to your subscription:> >> http://www.postgresql.org/mailpref/pgadmin-hackers> >>> >> > Patch attached. Apologies for that. :)> >> > Cheers> >> > Martin French> > > > -- > Dave Page> Blog: http://pgsnake.blogspot.com> Twitter: @pgsnake> > EnterpriseDB UK: http://www.enterprisedb.com> The Enterprise PostgreSQL Company> The patch was generated with git diff. I've just picked up the file off the box with WinSCP directly and emailed it...I've FTP'd to my local machine this time...cheers(See attached file: pgagent.patch)=
Romax Technology Limited
Rutherford House
Nottingham Science & Technology Park
Nottingham,
NG7 2PZ
England
Telephone numbers:
+44 (0)115 951 88 00 (main)
For other office locations see:
http://www.romaxtech.com/Contact
=
===
E-mail: i...@romaxtech.com
Website: www.romaxtech.com
=
Confidentiality Statement
This transmission is for the addressee only and contains information that is confidential and privileged.
Unless you are the named addressee, or authorised to receive it on behalf of the addressee
you may not copy or use it, or disclose it to anyone else.
If you have received this transmission in error please delete from your system and contact the sender. Thank you for your cooperation.
=
pgagent.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Fix the visual studio filters.
Fix the visual studio filters. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=df1cd78ab6cae42c25577ef765a3d051f8787f66 Author: Akshay Joshi Modified Files -- pgadmin/pgAdmin3.vcxproj.filters | 850 +- 1 files changed, 476 insertions(+), 374 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin III commit: Fix the visual studio filters.
Fix the visual studio filters. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=73dba99ca3f4088ae69b7b1b546e63b0c673a52b Author: Akshay Joshi Modified Files -- pgadmin/pgAdmin3.vcxproj.filters | 850 +- 1 files changed, 476 insertions(+), 374 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Fixed pgAdmin3 folder hierarchy
Thanks, patch applied. On Mon, Jul 16, 2012 at 11:03 AM, Akshay Joshi wrote: > Hi Dave > > Attached is the patch that fix the folder hierarchy of pgAdmin3. I have > found some .cpp files are lying under the include folder hierarchy. > If it looks OK then can you please apply the patch. > -- > Akshay Joshi > Senior Software Engineer > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > Phone: +91 20-3058-9522 > Mobile: +91 976-788-8246 > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAgent commit: Ensure that SQL steps have their success or failure rep
Ensure that SQL steps have their success or failure reported correctly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=bee4e427c145def3694876304193873ec7747283 Author: Martin French Modified Files -- connection.cpp |1 + include/connection.h | 33 - job.cpp | 10 -- 3 files changed, 41 insertions(+), 3 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent reports failure upon success - For Review
Great, that got it :-).
Thanks Martin - patch applied and push to the main repo. It'll be
included in the next release.
On Tue, Jul 17, 2012 at 10:52 AM, Martin French
wrote:
> Hi Dave.
>
> Dave Page wrote on 17/07/2012 10:45:28:
>
>> From: Dave Page
>
>
>> To: Martin French ,
>> Cc: pgadmin-hackers@postgresql.org, pgadmin-hackers-ow...@postgresql.org
>> Date: 17/07/2012 10:45
>
>> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent
>> reports failure upon success - For Review
>>
>> Hi
>>
>> This still seems to be malformed - I'm getting:
>>
>> raptor:pgagent dpage$ patch -p1 < ~/Downloads/pgagent.patch
>> (Stripping trailing CRs from patch.)
>> patching file connection.cpp
>> patch: malformed patch at line 6: if (result)
>>
>> Looking at the patch itself, it looks like the indentation is missing
>> from the first hunk for connection.cpp:
>>
>> diff --git a/connection.cpp b/connection.cpp
>> index 5e10078..6103c00 100644
>> --- a/connection.cpp
>> +++ b/connection.cpp
>> @@ -336,6 +336,7 @@ DBresult::DBresult(DBconn *conn, const wxString
>> &query)
>> if (result)
>> {
>> int rc = PQresultStatus(result);
>> + conn->SetLastResult(rc);
>> if (rc == PGRES_TUPLES_OK)
>> maxRows = PQntuples(result);
>> else if (rc != PGRES_COMMAND_OK)
>>
>> If I look at the source file, it's more like this (he says, hoping
>> Gmail doesn't mangle it):
>>
>> if (result)
>> {
>> int rc = PQresultStatus(result);
>> if (rc == PGRES_TUPLES_OK)
>> maxRows = PQntuples(result);
>> else if (rc != PGRES_COMMAND_OK)
>>
>> How are you generating the patch? Has your unmodified version been
>> inadvertently modified?
>>
>> On Tue, Jul 17, 2012 at 7:22 AM, Martin French
>> wrote:
>> > (See attached file: pgAgent.patch)
>> >
>> > Hi
>> >
>> > pgadmin-hackers-ow...@postgresql.org wrote on 16/07/2012 15:52:45:
>> >
>> >> From: Dave Page
>> >> To: Martin French ,
>> >> Cc: pgadmin-hackers@postgresql.org
>> >> Date: 16/07/2012 18:55
>> >> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent
>> >> reports failure upon success - For Review
>> >> Sent by: pgadmin-hackers-ow...@postgresql.org
>> >
>> >
>> >>
>> >> Hi
>> >>
>> >> Can you resend the patch as an attachment please? It's getting
>> >> corrupted inline in email.
>> >>
>> >> Thanks.
>> >>
>> >> On Mon, Jul 16, 2012 at 2:46 PM, Martin French
>> >> wrote:
>> >> > Hi,
>> >> >
>> >> > I have attempted a patch for an issue where pgAgent incorrectly
>> >> > reports
>> >> > failure on a plain SQL job. Please see below.
>> >> >
>> >> > Feedback/comments welcome.
>> >> >
>> >> > Thanks
>> >> >
>> >> > Martin French.
>> >> >
>> >> >
>> >
>> >>
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> --
>> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> >> To make changes to your subscription:
>> >> http://www.postgresql.org/mailpref/pgadmin-hackers
>> >>
>> >
>> > Patch attached. Apologies for that. :)
>> >
>> > Cheers
>> >
>> > Martin French
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
> The patch was generated with git diff. I've just picked up the file off the
> box with WinSCP directly and emailed it...
>
> I've FTP'd to my local machine this time...
>
> cheers
>
> (See attached file: pgagent.patch)
>
> = Romax Technology Limited
> Rutherford House Nottingham Science & Technology Park Nottingham, NG7 2PZ
> England Telephone numbers: +44 (0)115 951 88 00 (main) For other office
> locations see: http://www.romaxtech.com/Contact
> = === E-mail: i...@romaxtech.com
> Website: www.romaxtech.com =
> Confidentiality Statement This transmission is for the
> addressee only and contains information that is confidential and privileged.
> Unless you are the named addressee, or authorised to receive it on behalf of
> the addressee you may not copy or use it, or disclose it to anyone else. If
> you have received this transmission in error please delete from your system
> and contact the sender. Thank you for your cooperation.
> =
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent reports failure upon success - For Review
HiDave Page wrote on 17/07/2012 12:04:40:> From: Dave Page > To: Martin French , > Cc: pgadmin-hackers@postgresql.org, pgadmin-hackers-ow...@postgresql.org> Date: 17/07/2012 12:04> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent > reports failure upon success - For Review> > Great, that got it :-).> > Thanks Martin - patch applied and push to the main repo. It'll be> included in the next release.> > On Tue, Jul 17, 2012 at 10:52 AM, Martin French> wrote:> > Hi Dave.> >> > Dave Page wrote on 17/07/2012 10:45:28:> >> >> From: Dave Page > >> >> >> To: Martin French ,> >> Cc: pgadmin-hackers@postgresql.org, pgadmin-hackers-ow...@postgresql.org> >> Date: 17/07/2012 10:45> >> >> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent> >> reports failure upon success - For Review> >>> >> Hi> >>> >> This still seems to be malformed - I'm getting:> >>> >> raptor:pgagent dpage$ patch -p1 < ~/Downloads/pgagent.patch> >> (Stripping trailing CRs from patch.)> >> patching file connection.cpp> >> patch: malformed patch at line 6: if (result)> >>> >> Looking at the patch itself, it looks like the indentation is missing> >> from the first hunk for connection.cpp:> >>> >> diff --git a/connection.cpp b/connection.cpp> >> index 5e10078..6103c00 100644> >> --- a/connection.cpp> >> +++ b/connection.cpp> >> @@ -336,6 +336,7 @@ DBresult::DBresult(DBconn *conn, const wxString> >> &query)> >> if (result)> >> {> >> int rc = PQresultStatus(result);> >> + conn->SetLastResult(rc);> >> if (rc == PGRES_TUPLES_OK)> >> maxRows = PQntuples(result);> >> else if (rc != PGRES_COMMAND_OK)> >>> >> If I look at the source file, it's more like this (he says, hoping> >> Gmail doesn't mangle it):> >>> >> if (result)> >> {> >> int rc = PQresultStatus(result);> >> if (rc == PGRES_TUPLES_OK)> >> maxRows = PQntuples(result);> >> else if (rc != PGRES_COMMAND_OK)> >>> >> How are you generating the patch? Has your unmodified version been> >> inadvertently modified?> >>> >> On Tue, Jul 17, 2012 at 7:22 AM, Martin French> >> wrote:> >> > (See attached file: pgAgent.patch)> >> >> >> > Hi> >> >> >> > pgadmin-hackers-ow...@postgresql.org wrote on 16/07/2012 15:52:45:> >> >> >> >> From: Dave Page > >> >> To: Martin French ,> >> >> Cc: pgadmin-hackers@postgresql.org> >> >> Date: 16/07/2012 18:55> >> >> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent> >> >> reports failure upon success - For Review> >> >> Sent by: pgadmin-hackers-ow...@postgresql.org> >> >> >> >> >> >>> >> >> Hi> >> >>> >> >> Can you resend the patch as an attachment please? It's getting> >> >> corrupted inline in email.> >> >>> >> >> Thanks.> >> >>> >> >> On Mon, Jul 16, 2012 at 2:46 PM, Martin French> >> >> wrote:> >> >> > Hi,> >> >> >> >> >> > I have attempted a patch for an issue where pgAgent incorrectly> >> >> > reports> >> >> > failure on a plain SQL job. Please see below.> >> >> >> >> >> > Feedback/comments welcome.> >> >> >> >> >> > Thanks> >> >> >> >> >> > Martin French.> >> >> >> >> >> >> >> >> >> >>> >> >>> >> >> >> > Patch attached. Apologies for that. :)> >> >> >> > Cheers> >> >> >> > Martin French> >>> >>> >>> >>> >> > The patch was generated with git diff. I've just picked up the file off the> > box with WinSCP directly and emailed it...> >> > I've FTP'd to my local machine this time...> >> > cheers> >> > (See attached file: pgagent.patch)> > Great Stuff. Thanks for the assistance Dave. Cheers=
Romax Technology Limited
Rutherford House
Nottingham Science & Technology Park
Nottingham,
NG7 2PZ
England
Telephone numbers:
+44 (0)115 951 88 00 (main)
For other office locations see:
http://www.romaxtech.com/Contact
=
===
E-mail: i...@romaxtech.com
Website: www.romaxtech.com
=
Confidentiality Statement
This transmission is for the addressee only and contains information that is confidential and privileged.
Unless you are the named addressee, or authorised to receive it on behalf of the addressee
you may not copy or use it, or disclose it to anyone else.
If you have received this transmission in error please delete from your system and contact the sender. Thank you for your cooperation.
=
Re: [pgadmin-hackers] SSH Tunneling implementation
On Tue, Jul 17, 2012 at 9:20 AM, Dave Page wrote: > On Tue, Jul 17, 2012 at 8:56 AM, Guillaume Lelarge > wrote: >> On Tue, 2012-07-17 at 08:30 +0100, Dave Page wrote: >>> On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge >>> wrote: >>> > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: >>> >> On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge >>> >> wrote: >>> >> > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: >>> >> >> >>> >> >> Not for me - and I'd be the first to complain if I saw it doing that. >>> >> >> What do you see? >>> >> >> >>> >> > >>> >> > These: >>> >> > >>> >> > ./ogl/drawn.cpp: In member function ‘virtual void wxOpSetGDI::Do(wxDC&, >>> >> > double, double)’: >>> >> > ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of >>> >> > different size [-Wint-to-pointer-cast] >>> >> > ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of >>> >> > different size [-Wint-to-pointer-cast] >>> >> > ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of >>> >> > different size [-Wint-to-pointer-cast] >>> >> > ./ogl/drawn.cpp: In member function ‘virtual void >>> >> > wxPseudoMetaFile::SetPen(wxPen*, bool)’: >>> >> > ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of >>> >> > different size [-Wint-to-pointer-cast] >>> >> > ./ogl/drawn.cpp: In member function ‘virtual void >>> >> > wxPseudoMetaFile::SetBrush(wxBrush*, bool)’: >>> >> > ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of >>> >> > different size [-Wint-to-pointer-cast] >>> >> >>> >> What platform/GCC version? >>> >> >>> > >>> > Fedora 17, gcc 4.7 (gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)). With >>> > full updates on every possible RPM. >>> >>> 32 or 64 bit? Intel I assume? >>> >> >> Intel 64 bit. > > Thanks. OK, I'm going to have to download Fedora 17. I don't get any warnings on CentOS 6 with GCC 4.4.6. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] SSH Tunneling implementation
On Tue, Jul 17, 2012 at 2:16 PM, Akshay Joshi wrote: > Hi > > I am facing one problem while adding libssh2 source code in pgAdmin3. As > there are two file with same name "misc.c" and "misc.cpp", so compiler is > unable to create object file. On Windows I have changed the path of the > object file, but not found any solution on Linux. Meanwhile I have changed > the name of libssh2's "misc.c" to "libssh2_misc.c" and start compilation. > > Suggestions? Comments? Yeah, that's because of the way we have a single makefile and a bunch of module.mk files in pgAdmin. We really need to refactor that in some way such that the object files are created alongside the source files. In the meantime, I think yours is the appropriate solution. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] SSH Tunneling implementation
Hi I am facing one problem while adding libssh2 source code in pgAdmin3. As there are two file with same name "misc.c" and "misc.cpp", so compiler is unable to create object file. On Windows I have changed the path of the object file, but not found any solution on Linux. Meanwhile I have changed the name of libssh2's "misc.c" to "libssh2_misc.c" and start compilation. Suggestions? Comments? On Tue, Jul 17, 2012 at 6:22 PM, Dave Page wrote: > On Tue, Jul 17, 2012 at 9:20 AM, Dave Page wrote: > > On Tue, Jul 17, 2012 at 8:56 AM, Guillaume Lelarge > > wrote: > >> On Tue, 2012-07-17 at 08:30 +0100, Dave Page wrote: > >>> On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge > >>> wrote: > >>> > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: > >>> >> On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge > >>> >> wrote: > >>> >> > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: > >>> >> >> > >>> >> >> Not for me - and I'd be the first to complain if I saw it doing > that. > >>> >> >> What do you see? > >>> >> >> > >>> >> > > >>> >> > These: > >>> >> > > >>> >> > ./ogl/drawn.cpp: In member function ‘virtual void > wxOpSetGDI::Do(wxDC&, > >>> >> > double, double)’: > >>> >> > ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of > >>> >> > different size [-Wint-to-pointer-cast] > >>> >> > ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of > >>> >> > different size [-Wint-to-pointer-cast] > >>> >> > ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of > >>> >> > different size [-Wint-to-pointer-cast] > >>> >> > ./ogl/drawn.cpp: In member function ‘virtual void > >>> >> > wxPseudoMetaFile::SetPen(wxPen*, bool)’: > >>> >> > ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of > >>> >> > different size [-Wint-to-pointer-cast] > >>> >> > ./ogl/drawn.cpp: In member function ‘virtual void > >>> >> > wxPseudoMetaFile::SetBrush(wxBrush*, bool)’: > >>> >> > ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of > >>> >> > different size [-Wint-to-pointer-cast] > >>> >> > >>> >> What platform/GCC version? > >>> >> > >>> > > >>> > Fedora 17, gcc 4.7 (gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)). With > >>> > full updates on every possible RPM. > >>> > >>> 32 or 64 bit? Intel I assume? > >>> > >> > >> Intel 64 bit. > > > > Thanks. > > OK, I'm going to have to download Fedora 17. I don't get any warnings > on CentOS 6 with GCC 4.4.6. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi Senior Software Engineer EnterpriseDB Corporation The Enterprise PostgreSQL Company Phone: +91 20-3058-9522 Mobile: +91 976-788-8246*
Re: [pgadmin-hackers] More information about the selected objects
Attached. I think the information "user@database ( server )" is important. I tested on Windows 7. I'll test on Ubuntu tonight. 0001-More-information-about-the-selected-objects.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] More information about the selected objects
On Tue, Jul 17, 2012 at 5:24 PM, Vinicius Santos wrote: > Attached. > > I think the information "user@database ( server )" is important. > > I tested on Windows 7. > I'll test on Ubuntu tonight. I have no idea how you managed to get that to compile on Windows: ./schema/edbSynonym.cpp: In member function ‘virtual wxString edbSynonym::GetTranslatedMessage(int) const’: ./schema/edbSynonym.cpp:33: error: invalid use of incomplete type ‘struct pgSchema’ ../pgadmin/include/utils/factory.h:31: error: forward declaration of ‘struct pgSchema’ ./schema/edbSynonym.cpp:37: error: invalid use of incomplete type ‘struct pgSchema’ ../pgadmin/include/utils/factory.h:31: error: forward declaration of ‘struct pgSchema’ make[3]: *** [edbSynonym.o] Error 1 make[3]: *** Waiting for unfinished jobs ./schema/pgCast.cpp: In member function ‘virtual wxString pgCast::GetTranslatedMessage(int) const’: ./schema/pgCast.cpp:38: error: invalid use of incomplete type ‘struct pgSchema’ ../pgadmin/include/utils/factory.h:31: error: forward declaration of ‘struct pgSchema’ ./schema/pgCast.cpp:42: error: invalid use of incomplete type ‘struct pgSchema’ ../pgadmin/include/utils/factory.h:31: error: forward declaration of ‘struct pgSchema’ make[3]: *** [pgCast.o] Error 1 Which is entirely expected as both public synonyms and casts are database level objects and thus don't have pgSchema as a parent class. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] More information about the selected objects
> > Which is entirely expected as both public synonyms and casts are > database level objects and thus don't have pgSchema as a parent class. > > I forgot to check the pgCast. Sorry I'll fix it and resubmit.
Re: [pgadmin-hackers] More information about the selected objects
I fixed the problems. I removed the implementation on EnterpriseDB items, because I don't have how to test it. Can you help to test it? I tested on Windows 7 and Ubuntu. 0001-More-information-about-the-selected-objects.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
