Re: [pgadmin-hackers] pgAdmin III commit: Lots of work on domains, and check constraints
On Sat, Jul 21, 2012 at 1:40 PM, Guillaume Lelarge wrote: > On Wed, 2012-06-06 at 10:50 +0600, Timon wrote: >> seems that this commit broke reindexing of selected index. steps to >> reproduce: >> 1) create table >> 2) create index >> 3) select index in object inspector >> 4) try to reindex it via maintenance menu item >> 5) got error : ERROR: schema "table_name" does not exist >> >> and one more crash here >> .. same steps as before >> 4) try to CLUSTER index >> 5) pgadmin simply crashed >> > > OK, I finally got some time to work on this. As Timon said, these bugs > come from the patch "Lots of work on domains, and check constraints". In > this patch, I changed some objects parent class from pgTableObject to > pgSchemaObject. Due to this change, the GetTable() method returns NULL, > which segfaults all statements that try to use the return value without > checking. The two examples above from Timon are exactly this. > > I don't see many ways to get out of this issue. > > We could use GetSchema() instead of GetTable(). It works, it's an easy > and small patch. But it'll certainly be a maintenance nightmare (at > least without any comments) > > We could also revert my patch. It's simple, we loose the feature of > adding as many check constraints as we want to a domain, we loose the > feature of renaming and validating constraints, and we gain a few bugs. > > I don't see any other options. My own personal choice would be the first > one (see attached patch). But it's a tough call. We've run into problems in the past every time we've tried to share a sub-class between two parents. I think we should stop trying to do that, and just resign ourselves to having to duplicate the class - I guess pgCheckConstraint and pgDomainCheckConstraint is the way to go. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin 1.16 Visual Tour
Hi On Sun, Jul 22, 2012 at 9:58 AM, Guillaume Lelarge wrote: > Hi, > > Here is the new visual tour, this time for 1.16: > > http://developer.pgadmin.org/~guillaume/visualtour/visualtour_1_16.html > > I made this quickly in HTML, and will put it back in the usual .php file > once we're happy on the contents. > > So I need help, mostly on english fixes, and design. Once again, I > probably forgot some new features, you can add them if you want. There's > more chance that I did the opposite (adding too many stuff, boring > ones). If so, you can delete them. > > Anyway, feel free to edit it. But tell me when you're done so that I can > push it on the main website. Cool, thanks. I've made a few minor tweaks. Your English is near perfect now :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin 1.16 Visual Tour
On Mon, 2012-07-23 at 10:05 +0100, Dave Page wrote: > Hi > > On Sun, Jul 22, 2012 at 9:58 AM, Guillaume Lelarge > wrote: > > Hi, > > > > Here is the new visual tour, this time for 1.16: > > > > http://developer.pgadmin.org/~guillaume/visualtour/visualtour_1_16.html > > > > I made this quickly in HTML, and will put it back in the usual .php file > > once we're happy on the contents. > > > > So I need help, mostly on english fixes, and design. Once again, I > > probably forgot some new features, you can add them if you want. There's > > more chance that I did the opposite (adding too many stuff, boring > > ones). If so, you can delete them. > > > > Anyway, feel free to edit it. But tell me when you're done so that I can > > push it on the main website. > > Cool, thanks. I've made a few minor tweaks. Your English is near perfect now > :-) > Thanks a lot :) Now, I'll format it the usual way, and push it on the git repository. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] More information about the selected objects
We can also do so. On caption. <> -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
