date:20160509

Re: [pgadmin-hackers] pgAdmin4 - Session file name too large

2016-05-09 Thread eMerzh

Hi guys,

i was just updating my working copy of git, and got the same issue again.

it seems that the issue happend every time (or at least really often) when
i pull new changes.
so it might still be some issues with the session management.

to hel you understand my workflow, here are the step that i did:
a couple of days ago i've tested pgAdmin...
so today i did a git pull
...
Updating 07e0de5..c8406a5
...
then activate my venv,
then python web/pgAdmin4.py
and then i got the error :
OSError: [Errno 63] File name too long: ...
web/pgadmin/utils/session.py", line 60, in __init__
sess_db = os.open(self.path, os.O_CREAT, int("600", 8))


hope this helps :)
Regards,

Brice

2016-04-17 13:02 GMT+02:00 Dave Page :

> Ok, good. Please let us know if it reoccurs.
>
> Sent from my iPad
>
> On 17 Apr 2016, at 08:26, eMerzh  wrote:
>
> Ok guys I think  I found a way to pass the error.
> It seems that it was caused by a previous session cookie that was too long
> or smth.
> Deleting my cookies make the app work again :-)
> Le 17 avr. 2016 12:55 AM, "Dave Page"  a écrit :
>
> Hi
>
> Ashesh, can you look at this please? I cannot reproduce it.
>
>
> On Friday, April 15, 2016, eMerzh  wrote:
>
>> Hi,
>>
>> I was testing pgAdmin4 rev e210d2b5809355a334508436d9f128b78338dfd3
>> on osx python python 2.7,
>> but when i tried to log in, i got a error :
>>
>>
>>> 2016-04-15 13:31:47,820: ERROR werkzeug: Error on request:
>>> Traceback (most recent call last):
>>> File
>>> "/Users/myuser/pgadmin4/venv/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 177, in run_wsgi
>>> execute(self.server.app)
>>> File
>>> "/Users/myuser/pgadmin4/venv/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 165, in execute
>>> application_iter = app(environ, start_response)
>>> File
>>> "/Users/myuser/pgadmin4/venv/lib/python2.7/site-packages/flask/app.py",
>>> line 1836, in __call__
>>> return self.wsgi_app(environ, start_response)
>>> File
>>> "/Users/myuser/pgadmin4/venv/lib/python2.7/site-packages/flask/app.py",
>>> line 1813, in wsgi_app
>>> ctx.push()
>>> File
>>> "/Users/myuser/pgadmin4/venv/lib/python2.7/site-packages/flask/ctx.py",
>>> line 321, in push
>>> self.session = self.app.open_session(self.request)
>>> File
>>> "/Users/myuser/pgadmin4/venv/lib/python2.7/site-packages/flask/app.py",
>>> line 825, in open_session
>>> return self.session_interface.open_session(self, request)
>>> File "/Users/myuser/pgadmin4/web/pgadmin/utils/session.py", line 209, in
>>> open_session
>>> return SqliteSessionStorage(self.directory, sid)
>>> File "/Users/myuser/pgadmin4/web/pgadmin/utils/session.py", line 60, in
>>> __init__
>>> sess_db = os.open(self.path, os.O_CREAT, int("600", 8))
>>> OSError: [Errno 63] File name too long:
>>> '/Users/myuser/.pgadmin/sessions/.eJxNkUtvozAUhf_KyOto'
>>
>>
>> let me know if i can provide you more informations.
>>
>> Regards,
>>
>> Brice
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

2016-05-09 Thread Murtuza Zabuawala


Hi Khushboo,

Please find comments as below,
(Tested with Python3)

1) Default string value is not quoted properly which causing SQL to break, here 
default string should be 'my test string' for myCol2.

CREATE FOREIGN TABLE "Test123"."test1_Server"
("myCol" bigint NOT NULL DEFAULT 213 COLLATE pg_catalog."C",
"myCol2" character varying(50) NOT NULL DEFAULT my test string COLLATE 
pg_catalog."C.UTF-8")
INHERITS ("Test123".abc, pem.chart)
SERVER test_fw_server;

2) When Length & Precision, does not clear when user selects another data type
- First select Numeric provide Length & Precision and then choose abstime 
  data type which have neither Length & Precision 
- It will not clear/ not allow user to clear old values & generates wrong SQL

ALTER FOREIGN TABLE "Test123"."test1_TT1"
ADD COLUMN col1 abstime(50 , 2) NOT NULL COLLATE pg_catalog."C";

3) I am allowed to select self table as inherited table

ALTER FOREIGN TABLE pem."test1_TT1" INHERIT pem."test1_TT1";

4) Wrong SQL generated for array like data types

ALTER FOREIGN TABLE pem."test1_TT1"
ADD COLUMN name character[](50 ) NOT NULL COLLATE pg_catalog."POSIX";

Correct SQL:
   
ALTER FOREIGN TABLE pem."test1_TT1"
   ADD COLUMN name character(50)[] NOT NULL COLLATE pg_catalog."POSIX";

5) I am allowed to enter duplicate options but as per postgres documentation 
   we should not allow duplicate options 

ALTER FOREIGN TABLE pem."test1_TT1"
OPTIONS (ADD op1 'val1');

ALTER FOREIGN TABLE pem."test1_TT1"
OPTIONS (ADD op1 'val1');

ALTER FOREIGN TABLE pem."test1_TT1"
OPTIONS (ADD op1 'val2');

6) Created table with Special name (eg: table name => "@Test#" ) & it breaks 
when we clicks on it.

  File 
"/home/murtuza/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py",
 line 414, in properties
data = self._fetch_properties(gid, sid, did, scid, foid)
  File 
"/home/murtuza/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py",
 line 982, in _fetch_properties
c['typlen'] = int(typlen)
TypeError: int() argument must be a string, a bytes-like object or a number, 
not 'list'

7) While dropping any foreign table gives this error but table gets deleted 
from browser tree.

s/databases/schemas/foreign_tables/__init__.py", line 414, in properties
data = self._fetch_properties(gid, sid, did, scid, foid)
  File 
"/home/murtuza/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py",
 line 982, in _fetch_properties
c['typlen'] = int(typlen)
TypeError: int() argument must be a string, a bytes-like object or a number, 
not 'list'


Can be added into TODO:
=

1) We should not allowed user to Inherits from catalog tables like 
pg_catalog.pg_type;

2) Minor SQL alignment when only server & table name was given 

CREATE FOREIGN TABLE "Test123"."test1_Server"
()
SERVER test_fw_server;

Expected:
-
CREATE FOREIGN TABLE "Test123"."test1_Server" ()
SERVER test_fw_server;

3) Collation client side validation missing for columns, not every data type 
support Collations,
   For other data types it should be disable just like Length & Precision.


Regards,
Murtuza



> On 09-May-2016, at 10:43 am, Murtuza Zabuawala 
>  wrote:
> 
> Hi Khushboo,
> 
> No I did not. let me apply it and try again.
> 
> Thanks,
> Murtuza
> 
> 
>> On 06-May-2016, at 10:15 pm, Khushboo Vashi > > wrote:
>> 
>> Hi Murtuza,
>> 
>> Have you applied Dependent Cell patch on this? As the Foreign table is 
>> dependent on that.
>> 
>> Thanks,
>> Khushboo
>> 
>> On 6 May 2016 20:39, "Murtuza Zabuawala" > > wrote:
>> Hi Khushboo,
>> 
>> Please find comments as below,
>> 
>> I pulled latest version of code and then I applied v2 patch.
>> 
>> 
>> 1) Once applying patch, When I re-started pgAdmin4 server again, I got below 
>> error (Screenshot is also attached),
>>( FYI, I was not able to re-produce it again second time. )
>> 
>>   File "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/utils/__init__.py", line 
>> 37, in create_module_preference
>> self.preference = Preferences(self.name , None)
>>   File "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/utils/preferences.py", 
>> line 261, in __init__
>> db.session.commit()
>> …..
>> …..
>> cursor.execute(statement, parameters)
>> sqlalchemy.exc.OperationalError: (OperationalError) database is locked 
>> 'INSERT INTO module_preference (name) VALUES (?)' ('NODE-foreign-table’,)
>> 
>> 
>> 2) I am not able to create/open Foreign table node as I am getting errors 
>> from JS side  (when I expand the schema node & do not get Create context 
>> menu as well)
>> Please find screenshots for both scenario.
>> 
>> 
>> > 07-59-45.png>
>> 
>> 
>>> On 06-May-2016, at 3:55 pm, Khushboo Vashi >> >

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

2016-05-09 Thread Ashesh Vashi

On Mon, May 9, 2016 at 5:50 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached updated patch for the Foreign Tables module.
>
> Thanks,
> Khushboo
>
> On Mon, May 9, 2016 at 1:46 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>>
>> Hi Khushboo,
>>
>> Please find comments as below,
>> (Tested with Python3)
>>
>> *1)* Default string value is not quoted properly which causing SQL to
>> break, here default string should be 'my test string' for myCol2.
>>
>> CREATE FOREIGN TABLE "Test123"."test1_Server"
>> ("myCol" bigint NOT NULL DEFAULT 213 COLLATE pg_catalog."C",
>> "myCol2" character varying(50) NOT NULL DEFAULT my test string COLLATE
>> pg_catalog."C.UTF-8")
>> INHERITS ("Test123".abc, pem.chart)
>> SERVER test_fw_server;
>>
>> I think this behavior is perfect as we can't add single quotes for all
> the data-types. User should have to add himself if required.
>
This is correct behaviour as of now.

Default value can be an expression too.
Hence - we need to rely on the user to provide correct value here.

We may improve this in the future.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
>> *2)* When Length & Precision, does not clear when user selects another
>> data type
>> - First select Numeric provide Length & Precision and then choose abstime
>>   data type which have neither Length & Precision
>> - It will not clear/ not allow user to clear old values & generates wrong
>> SQL
>>
>> ALTER FOREIGN TABLE "Test123"."test1_TT1"
>> ADD COLUMN col1 abstime(50 , 2) NOT NULL COLLATE pg_catalog."C";
>>
> Done
>
>> *3)* I am allowed to select self table as inherited table
>>
>> ALTER FOREIGN TABLE pem."test1_TT1" INHERIT pem."test1_TT1";
>>
>> Done
>
>> *4)* Wrong SQL generated for array like data types
>>
>> ALTER FOREIGN TABLE pem."test1_TT1"
>> ADD COLUMN name character[](50 ) NOT NULL COLLATE pg_catalog."POSIX";
>>
>> Correct SQL:
>>
>> ALTER FOREIGN TABLE pem."test1_TT1"
>>ADD COLUMN name character(50)[] NOT NULL COLLATE
>> pg_catalog."POSIX";
>>
>> Done
>
>> *5)* I am allowed to enter duplicate options but as per postgres
>> documentation
>>we should not allow duplicate options
>>
>> ALTER FOREIGN TABLE pem."test1_TT1"
>> OPTIONS (ADD op1 'val1');
>>
>> ALTER FOREIGN TABLE pem."test1_TT1"
>> OPTIONS (ADD op1 'val1');
>>
>> ALTER FOREIGN TABLE pem."test1_TT1"
>> OPTIONS (ADD op1 'val2');
>>
>> Done
>
>> *6)* Created table with Special name (eg: table name => "@Test#" ) & it
>> breaks when we clicks on it.
>>
>>   File
>> "/home/murtuza/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py",
>> line 414, in properties
>> data = self._fetch_properties(gid, sid, did, scid, foid)
>>   File
>> "/home/murtuza/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py",
>> line 982, in _fetch_properties
>> c['typlen'] = int(typlen)
>> TypeError: int() argument must be a string, a bytes-like object or a
>> number, not 'list'
>>
>
>>
> Couldn't reproduce but I think while fixing above issues it is resolved.
>
>> *7) *While dropping any foreign table gives this error but table gets
>> deleted from browser tree.
>>
>> s/databases/schemas/foreign_tables/__init__.py", line 414, in properties
>> data = self._fetch_properties(gid, sid, did, scid, foid)
>>   File
>> "/home/murtuza/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py",
>> line 982, in _fetch_properties
>> c['typlen'] = int(typlen)
>> TypeError: int() argument must be a string, a bytes-like object or a
>> number, not 'list'
>>
>  Couldn't reproduce but I think while fixing above issues it is resolved.
>
>>
>> *Can be added into TODO:*
>> *=*
>>
>> *1)* We should not allowed user to Inherits from catalog tables like
>> pg_catalog.pg_type;
>>
>> *2)* Minor SQL alignment when only server & table name was given
>>
>> CREATE FOREIGN TABLE "Test123"."test1_Server"
>> ()
>> SERVER test_fw_server;
>>
>> Expected:
>> -
>> CREATE FOREIGN TABLE "Test123"."test1_Server" ()
>> SERVER test_fw_server;
>>
>> *3)* Collation client side validation missing for columns, not every
>> data type support Collations,
>>For other data types it should be disable just like Length & Precision.
>>
>>
>> Regards,
>> Murtuza
>>
>>
>>
>> On 09-May-2016, at 10:43 am, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>> Hi Khushboo,
>>
>> No I did not. let me apply it and try again.
>>
>> Thanks,
>> Murtuza
>>
>>
>> On 06-May-2016, at 10:15 pm, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>> Hi Murtuza,
>>
>> Have you applied Dependent Cell patch on this? As the Foreign table is
>> dependent

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

2016-05-09 Thread Dave Page

Hi

On Fri, Apr 15, 2016 at 4:31 PM, Paresh More 
wrote:

> Hello Dave,
>
> I have made changes according which you mentioned.
>
> Binary is located @ location
>
> https://uploads.enterprisedb.com/download.php?file=1f92c5abbaf7014d9aa8fb0711d53f6d
>
> Patch is attached in the Email.
>
> - Please move Make.bat to the root directory of the source tree.
> *DONE* - Make.bat is moved to root directory
>

OK.

>
> - The built installer should be created in dist/ in the root directory of
> the source tree (as the PIP package is)
> *DONE - *dist would be created in the root directory of the source tree.
>

OK

>
> - The version number should be extracted from config.py, and used to
> create the installer filename, i.e. pgadmin4-APP_VERSION.exe, which would
> currently make "pgadmin4-1.0.0-dev.exe"
> *DONE* - Now it reads from config.py and accordingly create installer
> filename.
>

OK

>
>
> - Please add a README.rst file to pkg/win32 that describes the required
> packages to setup a build environment, and (where non-obvious, e.g. setting
> up the compiler for PIP) including instructions on how to setup everything.
> *DONE*
>

I've edited (and renamed for consistency) this file. Please find the update
attached.

I notice that it does not mention anything about setting up a compiler for
PIP etc. Is that needed?

>
> - The user should never need to edit Make.bat, so any paths that might
> change should come from the environment (with instructions telling the user
> what to set where required). e.g. use vars like PYTHON_VERSION,
> PYTHON_PATH, QTDIR. These should override any hard-coded defaults in the
> script. Of course, where possible we should use variables standard to, or
> set by the other products.
> *DONE* - It would check environment variables and override if it is set,
> else default values would be used and a check is put which would ensure all
> the prerequisite requirement is installed or abort.
>

This doesn't appear to work at all. I set QTDIR in my environment, but the
script complains that the default paths don't exist. I removed the default
for QTDIR, and then get output like the following:

C:\Users\dpage\Documents\pgadmin4>make
'Files' is not recognized as an internal or external command,
operable program or batch file.
'Files' is not recognized as an internal or external command,
operable program or batch file.
'Files' is not recognized as an internal or external command,
operable program or batch file.
'Files' is not recognized as an internal or external command,
operable program or batch file.
C:\Qt\5.5\msvc2013_64 does not exist.
"C:\Qt\5.5\msvc2013_64\bin\qmake.exe"s does not exist.
Please Install QT SDK and set the QTDIR enviroment Variable.

Clearly there are quoting issues here.

>
> - Any script errors should cause an exit. For example, my QT is a
> different version than you used, but the build script just ignored the fact
> that qmake couldn't be found and built an installer anyway.
> *DONE* - Pre check is put which would ensure prerequisite requirement is
> installed
>

OK

>
>
> - Side-by-side installations of major versions of pgAdmin should be
> allowed, so an installation directory of "C:\Program Files (x86)\pgAdmin
> 4\" should actually install into C:\Program Files (x86)\pgAdmin
> 4\., e.g. "C:\Program Files (x86)\pgAdmin 4\1.0\"
> *DONE-*Side-by-side installation depending on Major and minor number is
> handled.
> Ex: All 1.0.0, 1.0.1,1.0.2,etc. would go in C:\Program Files
> (x86)\pgAdmin 4\1.0
> All 1.1.0, 1.1.1,1.1.2,etc. would go in C:\Program Files
> (x86)\pgAdmin 4\1.1
> and so on
>

OK.

>
> - Revision version updates should update the installed version, not
> install side-by-side.  Care should be taken to ensure the Add/Remove
> Programs entries support both side-by-side installations and upgrades (e.g.
> 1.0.0 -> 1.0.1)
> *DONE* - Revision version update would update the installed version
> A extra check is also put which insure older version would not be allowed
> to install if higher version is already installed.
>

OK.

>
> - The first screen of the installer shows the version of pgAdmin as 1.0.
> It should be APP_VERSION from config.py.
> *DONE*- Screen shows APP_Version from config.py
>

OK.

>
> - To aid with error handling, the script should check to ensure it can
> find required executables (e.g. qmake.exe, ISCC.exe) as a pre-flight check.
> *DONE*- Pre check is set, which will ensure all prerequisite is already
> set and installed.
>

OK. Please adjust the error reporting, e.g.

:setInnoDetails
echo %INNOTOOL% does not exist
echo Please Install Innotool and set the INNOTOOL enviroment variable.
goto EXIT

:setVCDetails
echo %VCDIR% does not exist.
echo %VCVAR% does not exist.
echo %VCNMAKE% does not exist.
echo Please Install Microsoft Visual Studio and set the VCDIR environment
variable.
goto EXIT

:setPythonDetails
echo %PYTHON_HOME% does not exist.
echo %PYTHON_VERSION% not set.
echo %PYTHON_DLL% does not exist.
echo Please Install Python a

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-05-09 Thread Dave Page

Hi

Initial eyeball review comments below...

On Fri, Apr 22, 2016 at 11:57 AM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:

> Hi Team, Dave,
>
> Attached herewith are two patches.
>
> *pgadmin4-rpm.patch* - This is the main patch that includes scripts,
> makefiles and spec to create RPMs for RHEL6/RHEL7/F-22/F-23/F-24.
>

Can we keep the directory names in lower case?


> It will create two RPMs i.e pgadmin4 and pgadmin4-web. The  pgadmin4 tpm
> depends on web and the web rpm depends on the python packages. I have
> commented the list of packages which are not available on some systems so
> that Devrim can build them.
>
> The installation path for pgadmin4 is "/usr/pgadmin4-." and
> pgadmin4-web is the site-packages/pgadmin4-web
>
Shouldn't the -web package also have the major.minor version number in the
path, to allow side-by-side installation?

> *pgadmin4-server-ini.patch* - This is the patch for runtime/Server.cpp.
> As said pgadmin4-web and runtime installation directories are different and
> that means web does not exists in parallel to runtime like in sources.
>
> I observed that the location of application settings was not defined in
> Server.cpp. As per QSettings doc, the default location on Unix is the
> $HOME/.config//.conf. Here, $HOME depends on the user
> that runs the application. So, I thought why not to define the application
> settings in application directory itself. RPM then knows where to define
> the ApplicationPath. I tested it and it worked fine with me. I haven't done
> this change for platform dependent.
>
Doesn't that prevent non-root users from changing the settings? Or (if you
widen the permissions on the ini file), allow one user to mis-configure the
app for others? I think what is needed here is a search path change, much
like you added for the Mac app bundle.

Other thoughts:

- Please rename the README to README.txt

- The code to build the RPMs should be entirely confined to pkg/rpm. A
Makefile target should be added to /Makefile to build/clean the targets
(this mistake was made with the Mac package too, but was one of the
original requirements).

Please resolve these issues and I'll take another look.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] PATCH: pgAdmin4 debian installer

2016-05-09 Thread Dave Page

Hi

Please see my earlier comments regarding the RPM packages - many of them
apply to this patch as well:
http://www.postgresql.org/message-id/ca+ocxoxbdt82p75q4cy4fbkznkpbw3yjwpz+wfarbbbsoi3...@mail.gmail.com

By way of additional comment, why does pkg/deb/README include a bunch of
boiler-plate text that I wrote long ago for the top-level README? It's out
of date now, and shouldn't be in a packaging README anyway.

Thanks.

On Tue, Apr 26, 2016 at 4:20 PM, Paresh More 
wrote:

> Hi Team, Dave,
>
> debian package is located @ location
>
> pgadmin4-web
>
> https://uploads.enterprisedb.com/download.php?file=0196f693811b57088da5ed7396cec284
>
> pgadmin4-runtime
>
> https://uploads.enterprisedb.com/download.php?file=958528f7c619efa7b483a6d2e0c23cd5
>
> Attached herewith are two patches.
>
> pgadmin4_debian.patch - This is the main patch that includes
> Makefile,README,debian scripts
>
> It will create two .deb i.e pgadmin4-runtime and pgadmin4-web.
> The  pgadmin4-runtime depends on web and the web debian depends on the
> python packages.
> I have listed some packages which are not available on some systems so
> that Devrim can build them.
>
> The installation path for pgadmin4 is "/usr/pgadmin4/." and
> pgadmin4-web is the site-packages/pgadmin4-web
>
> As per rpm patch (*sandeep mentioned*) below is the comment which applies
> same for debian.
>
> *pgadmin4-server-ini.patch* - This is the patch for runtime/Server.cpp.
> As said pgadmin4-web and runtime installation directories are different and
> that means web does not exists in parallel to runtime like in sources.
>
> *Sandeep comments*
>
> *“I observed that the location of application settings was not defined in*
> *Server.cpp. As per QSettings doc, the default location on Unix is the*
> *$HOME/.config//.conf. Here, $HOME depends on the
> user*
> *that runs the application. So, I thought why not to define the
> application*
> *settings in application directory itself. RPM then knows where to define*
> *the ApplicationPath. I tested it and it worked fine with me. I haven't
> done*
> *this change for platform dependent*
>
> *Another change that I did in this file is that, I observed that
> canonicalPath()*
> *was not giving the absolute path (by removing the sym link and the*
> *redundant ".." as per doc). Hence, I used absolutePath() for the paths[i]*
> *that are relative (../web, etc) and not for the already absolute path
> (ex.*
> *ApplicationPath like /usr/lib/python2.7/site-packages/pgadmin4-web)”*
>
> What the patch will create ?
> - It would create deb folder in pkg
> - It would create Makefile, README and debian scripts
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> Cell :  +919922000564 |  www.enterprisedb.com
>



-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

[pgadmin-hackers] Improved password error message ui on password change page [pgadmin4]

2016-05-09 Thread Harshal Dhumal

Hi,

PFA minor patch for password change page.


-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 2531863..00a9829 100755
--- a/web/pgadmin/static/css/overrides.css
+++ b/web/pgadmin/static/css/overrides.css
@@ -1101,3 +1101,7 @@ button.pg-alertify-button {
 div.backform_control_notes label.control-label {
   min-width: 0px;
 }
+
+form[name="change_password_form"] .help-block {
+color: #A94442 !important;
+}
\ No newline at end of file

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: minor typo in fts dictionary node

2016-05-09 Thread Sanket Mehta

Hi,

PFA the patch for minor typo issue in fts dictionary node.
Please do review it and commit if found proper.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/nodes.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/nodes.sql
index 78abd0b..272c23c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/nodes.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/nodes.sql
@@ -1,4 +1,4 @@
-{# FETCH FTS DICTIONARY name statement #}
+{# FETCH FTS DICTIONARY NAME statement #}
 SELECT
 oid, dictname as name
 FROM
@@ -7,7 +7,7 @@ WHERE
 {% if scid %}
 dict.dictnamespace = {{scid}}::OID
 {% elif dcid %}
-dict.oid = {{pid}}::OID
+dict.oid = {{dcid}}::OID
 {% endif %}
 
 ORDER BY name
\ No newline at end of file
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/sql.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/sql.sql
index 42537f6..6a36829 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/sql.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/sql.sql
@@ -16,7 +16,7 @@ FROM
 E'\n);' ||
 CASE
 WHEN description IS NOT NULL THEN
-E'\n\nCOMMENT ON TEXT SEARCH TEMPLATE ' || nspname || E'.' || dict.dictname ||
+E'\n\nCOMMENT ON TEXT SEARCH DICTIONARY ' || nspname || E'.' || dict.dictname ||
 E' IS ' || pg_catalog.quote_literal(description) || E';'
 ELSE ''  END as sql
 FROM

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin4 - Session file name too large

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Re: [pgadmin-hackers] PATCH: pgAdmin4 debian installer

[pgadmin-hackers] Improved password error message ui on password change page [pgadmin4]

[pgadmin-hackers] PATCH: minor typo in fts dictionary node

8 matches

Site Navigation

Mail list logo

Footer information