date:20160809

[pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Murtuza Zabuawala

Hi,

PFA patch to fix the issue where message panel was showing incomplete info.
We may still miss some messages from Psycopg2 driver due to limited size of
notices queue.
(RM#1523)


Regards,
Murtuza
diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py
index bb5c26b..2389217 100644
--- a/web/pgadmin/tools/sqleditor/__init__.py
+++ b/web/pgadmin/tools/sqleditor/__init__.py
@@ -406,8 +406,10 @@ def poll(trans_id):
 trans_id: unique transaction id
 """
 col_info = None
+result = None
 primary_keys = None
 rows_affected = 0
+additional_result = []
 
 # Check the transaction and connection status
 status, error_msg, conn, trans_obj, session_obj = check_transaction_status(trans_id)
@@ -450,20 +452,25 @@ def poll(trans_id):
 # restore it and update the session variable.
 session_obj['columns_info'] = columns
 update_session_grid_transaction(trans_id, session_obj)
-else:
-if result is None:
-result = conn.status_message()
-additional_result = conn.messages()
-"""
-Procedure/Function output may comes in the form of Notices from the
-database server, so we need to append those outputs with the
-original result.
-"""
-if isinstance(additional_result, list) \
-and len(additional_result) > 0:
-result = "{0} {1}".format(additional_result[-1], result)
-
-rows_affected = conn.rows_affected()
+
+"""
+Procedure/Function output may comes in the form of Notices from the
+database server, so we need to append those outputs with the
+original result.
+"""
+if status == 'Success' and result is None:
+result = conn.status_message()
+messages = conn.messages()
+if messages:
+additional_result = ''.join(messages)
+else:
+additional_result = ''
+if result != 'SELECT 1' and result is not None:
+result = additional_result + result
+else:
+result = additional_result
+
+rows_affected = conn.rows_affected()
 
 return make_json_response(
 data={
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 2be2b49..ce421e5 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -1282,7 +1282,9 @@ define(
 else {
   // Show message in message and history tab in case of query tool
   self.total_time = self.get_query_run_time(self.query_start_time, self.query_end_time);
-  self.update_msg_history(true, res.data.result);
+  self.update_msg_history(true, res.data.result, false);
+  var msg = S('{{ _('Total query runtime: %s.') }}').sprintf(self.total_time).value();
+  alertify.success(msg, self.info_notifier_timeout);
 }
 
 // Enable/Disable query tool button only if is_query_tool is true.
@@ -1292,6 +1294,9 @@ define(
 }
   }
   else if (res.data.status === 'Busy') {
+if (res.data.result) {
+  self.update_msg_history(true, res.data.result, false);
+}
 // If status is Busy then poll the result by recursive call to the poll function
 self._poll();
   }
@@ -1302,10 +1307,10 @@ define(
   self.disable_tool_buttons(false);
   $("#btn-cancel-query").prop('disabled', true);
 }
-self.update_msg_history(false, res.data.result);
+self.update_msg_history(false, res.data.result, true);
   }
   else if (res.data.status === 'Cancel') {
-self.update_msg_history(false, "Execution Cancelled!")
+self.update_msg_history(false, "Execution Cancelled!", true)
   }
 },
 error: function(e) {
@@ -1681,29 +1686,33 @@ define(
 clear_grid = true;
 
   self.trigger('pgadmin-sqleditor:loading-icon:hide');
-  $("#btn-flash").prop('disabled', false);
 
-  $('.sql-editor-message').text(msg);
+  $("#btn-flash").prop('disabled', false);
   self.gridView.messages_panel.focus();
 
-  if (self.is_query_tool && clear_grid) {
-// Delete grid and paginator
-if (self.gridView.grid) {
-  self.gridView.grid.remove();
+  if (self.is_query_tool) {
+if (clear_grid) {
+  // Delete grid and paginator
+  if (self

Re: [pgadmin-hackers] RM #1250 Collection node counts

2016-08-09 Thread Akshay Joshi

Hi Dave

I have implemented the logic as per your suggestion. When user will expand
the collection node label will get updated with collection count. Attached
is the new patch file, please review it and let me know the review
comments.

On Mon, Aug 8, 2016 at 5:50 PM, Dave Page  wrote:

>
>
> On Mon, Aug 8, 2016 at 1:18 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Mon, Aug 8, 2016 at 5:33 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Mon, Aug 8, 2016 at 11:39 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi All

 I have fixed the RM#1250 "Collection node counts". To fix this RM I
 need to do following changes

- Move "check_precondition" function from module's view class to
global level within that python file itself, so that module class will 
 use
it.
- Modified "get_nodes" function of each module's class, run the sql
query to count the number of objects and pass the count to
"generate_browser_collection_node" function to display the
collection count.
- Reuse SQL queries which is used to fetch nodes. Make that query
as inner query like "SELECT count(*) FROM(  query  ) AS
collection_count". For that I'll have to remove semicolon's from some of
the SQL queries.

 One case is not handled with this patch and that is on "Refresh" of
 collection node, count is not updated. If user refresh the parent node then
 it will be updated. I'll create a separate RM for that.

>>>
>>> Sorry Akshay, but I really don't like the way you've done this. It seems
>>> like an unnecessarily large patch, and if I'm reading the patch correctly,
>>> it doubles the amount of SQL queries run against the database when
>>> navigating the tree, and introduces race conditions where the count
>>> displayed could be different from the actual number of nodes.
>>>
>>> I was expecting to see this implemented by watching for tree events
>>> (e.g. 'added' and 'removed') and using those events to update the label on
>>> the parent node, if that node is a collection. That should just be a few
>>> lines, and should be correct at all times right?
>>>
>>
>>With current implementation children's of any collection node will be
>> fetched/added when user will expand that collection node, in that case we
>> will update the label once the node gets expanded. For example initially we
>> will show "Databases"  and when it gets expanded then we will update it to
>> "Databases (5)".
>>
>
> Right, but you also need to allow for removal and addition of children
> when the node is already expanded, and refreshes. Plus my other comments
> are still valid I believe - race condition, double the SQL and a very large
> change late in the beta cycle which isn't ideal.
>
>
>>
>>>

 Attached is the patch file. Please review it and let me know the review
 comments.

 --
 *Akshay Joshi*
 *Principal Software Engineer *



 *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


RM_1250.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add missing collection node child counts. Fixes #1250

2016-08-09 Thread Dave Page

Add missing collection node child counts. Fixes #1250

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9dfc7bff3511d09c881be84047567a3cbfaba1e3
Author: Akshay Joshi 

Modified Files
--
.../browser/templates/browser/js/collection.js |  1 +
web/pgadmin/browser/templates/browser/js/node.js   | 48 +-
2 files changed, 48 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] RM #1250 Collection node counts

2016-08-09 Thread Dave Page

Awesome - just what I was expecting, and it works nicely :-).

Thanks, committed.

On Tue, Aug 9, 2016 at 12:00 PM, Akshay Joshi  wrote:

> Hi Dave
>
> I have implemented the logic as per your suggestion. When user will expand
> the collection node label will get updated with collection count. Attached
> is the new patch file, please review it and let me know the review
> comments.
>
> On Mon, Aug 8, 2016 at 5:50 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Aug 8, 2016 at 1:18 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Mon, Aug 8, 2016 at 5:33 PM, Dave Page  wrote:
>>>
 Hi

 On Mon, Aug 8, 2016 at 11:39 AM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi All
>
> I have fixed the RM#1250 "Collection node counts". To fix this RM I
> need to do following changes
>
>- Move "check_precondition" function from module's view class to
>global level within that python file itself, so that module class will 
> use
>it.
>- Modified "get_nodes" function of each module's class, run the sql
>query to count the number of objects and pass the count to
>"generate_browser_collection_node" function to display the
>collection count.
>- Reuse SQL queries which is used to fetch nodes. Make that query
>as inner query like "SELECT count(*) FROM(  query  ) AS
>collection_count". For that I'll have to remove semicolon's from some 
> of
>the SQL queries.
>
> One case is not handled with this patch and that is on "Refresh" of
> collection node, count is not updated. If user refresh the parent node 
> then
> it will be updated. I'll create a separate RM for that.
>

 Sorry Akshay, but I really don't like the way you've done this. It
 seems like an unnecessarily large patch, and if I'm reading the patch
 correctly, it doubles the amount of SQL queries run against the database
 when navigating the tree, and introduces race conditions where the count
 displayed could be different from the actual number of nodes.

 I was expecting to see this implemented by watching for tree events
 (e.g. 'added' and 'removed') and using those events to update the label on
 the parent node, if that node is a collection. That should just be a few
 lines, and should be correct at all times right?

>>>
>>>With current implementation children's of any collection node will be
>>> fetched/added when user will expand that collection node, in that case we
>>> will update the label once the node gets expanded. For example initially we
>>> will show "Databases"  and when it gets expanded then we will update it to
>>> "Databases (5)".
>>>
>>
>> Right, but you also need to allow for removal and addition of children
>> when the node is already expanded, and refreshes. Plus my other comments
>> are still valid I believe - race condition, double the SQL and a very large
>> change late in the beta cycle which isn't ideal.
>>
>>
>>>

>
> Attached is the patch file. Please review it and let me know the
> review comments.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91
> 976-788-8246*
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Add missing updates from the previous commit.

2016-08-09 Thread Dave Page

Add missing updates from the previous commit.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b13d5501635aa4dc439ef47c2c4142c6bafdb9b

Modified Files
--
web/pgadmin/browser/server_groups/servers/templates/servers/servers.js  | 2 ++
.../browser/server_groups/templates/server_groups/server_groups.js  | 1 +
2 files changed, 3 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin 4 as Web application

2016-08-09 Thread Albe Laurenz

Neel Patel wrote:
>>  WebViewWindow.h:20:20: error: QWebView: No such file or directory

> From the logs, it looks like - Qt webkit component is missing in Qt4 
> installation.
> Are you building Qt from source, If yes then there will be option in 
> configure script to build Qt4
> with webkit.
> If you are not using source code, try installing webkit with yum (e.g. yum 
> install libqt4-webkit).

I found an appropriate RPM somewhere, now I have a different problem.

I am building with Qt 4.6.2 from RHEL 6, which should be OK according to the 
README,
but I am failing with

g++ -c -m64 -pipe -I/usr/include/python2.6 -I/usr/include/python2.6 -O2 -g 
-pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 
-m64 -mtune=generic -Wall -W -D_REENTRANT -DPYTHON2 -DQT_NO_DEBUG 
-DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB 
-I/usr/lib64/qt4/mkspecs/linux-g++-64 -I. -I/usr/include/QtCore 
-I/usr/include/QtNetwork -I/usr/include/QtGui -I/usr/include/QtWebKit 
-I/usr/include -I. -I. -o BrowserWindow.o BrowserWindow.cpp
BrowserWindow.cpp: In member function ‘void 
BrowserWindow::unsupportedContent(QNetworkReply*)’:
BrowserWindow.cpp:446: error: ‘QUrlQuery’ was not declared in this scope
BrowserWindow.cpp:446: error: expected ‘;’ before ‘query_data’
BrowserWindow.cpp:447: error: ‘query_data’ was not declared in this scope
BrowserWindow.cpp: In member function ‘bool 
BrowserWindow::checkClientDownload(const QUrl&, const QNetworkRequest&)’:
BrowserWindow.cpp:681: error: ‘QUrlQuery’ was not declared in this scope
BrowserWindow.cpp:681: error: expected ‘;’ before ‘downloadData’
BrowserWindow.cpp:683: error: ‘downloadData’ was not declared in this scope
make: *** [BrowserWindow.o] Error 1

The code uses QUrlQuery, but according to http://doc.qt.io/qt-5/qurlquery.html
this class has existed only since 5.0.

Seems to be either a documentation bug (Qt 5 required) or a code bug.
Can you help?

Yours,
Laurenz Albe

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Dave Page

Hi

On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue where message panel was showing incomplete info.
> We may still miss some messages from Psycopg2 driver due to limited size of
> notices queue.
> (RM#1523)

A few thoughts on this (mostly based on my discussions with Ashesh):

1) You seem to have removed the poll delay. I assume that is to try to
avoid missing messages? Can we re-introduce the delay (to avoid
excessive network requests), but collect messages while we're waiting?

2) If I run VACUUM, whilst I see messages as I should now, there is no
query time summary as there is for a query that returns data.

3) Can we incrementally display messages? e.g. each time we poll, we
add the new messages to the messages div, and scroll to the end
automatically?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Ashesh Vashi

On Tue, Aug 9, 2016 at 6:28 PM, Dave Page  wrote:

> Hi
>
> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
>  wrote:
> > Hi,
> >
> > PFA patch to fix the issue where message panel was showing incomplete
> info.
> > We may still miss some messages from Psycopg2 driver due to limited size
> of
> > notices queue.
> > (RM#1523)
>
> A few thoughts on this (mostly based on my discussions with Ashesh):
>
> 1) You seem to have removed the poll delay. I assume that is to try to
> avoid missing messages? Can we re-introduce the delay (to avoid
> excessive network requests), but collect messages while we're waiting?
>
Using thread?
Start a thread during the timeout?

>
> 2) If I run VACUUM, whilst I see messages as I should now, there is no
> query time summary as there is for a query that returns data.
>

> 3) Can we incrementally display messages? e.g. each time we poll, we
> add the new messages to the messages div, and scroll to the end
> automatically?

Yeah - that's a good idea.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>




> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Dave Page

On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi 
wrote:

> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
>>  wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue where message panel was showing incomplete
>> info.
>> > We may still miss some messages from Psycopg2 driver due to limited
>> size of
>> > notices queue.
>> > (RM#1523)
>>
>> A few thoughts on this (mostly based on my discussions with Ashesh):
>>
>> 1) You seem to have removed the poll delay. I assume that is to try to
>> avoid missing messages? Can we re-introduce the delay (to avoid
>> excessive network requests), but collect messages while we're waiting?
>>
> Using thread?
> Start a thread during the timeout?
>

Not necessarily. If we want a 2 second polling delay, we could just sleep
for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages,
 return to client.


>
>> 2) If I run VACUUM, whilst I see messages as I should now, there is no
>> query time summary as there is for a query that returns data.
>>
>
>> 3) Can we incrementally display messages? e.g. each time we poll, we
>> add the new messages to the messages div, and scroll to the end
>> automatically?
>
> Yeah - that's a good idea.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>
>
>
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin 4 as Web application

2016-08-09 Thread Neel Patel

Hi,

We already have condition for QUrlQuery class as below. It will be used
only if Qt version is >= 5.0.

#if QT_VERSION >= 0x05
// Extract filename and query from encoded URL
QUrlQuery query_data(reply->url());
QString file_name = query_data.queryItemValue("filename");
QString query = query_data.queryItemValue("query");
#else
QUrl url(reply->url());
QString file_name = url.queryItemValue("filename");
QString query = url.queryItemValue("query");
#endif


In your case, it may possible that during qmake - Qt version is detected as
5 but you are compiling against Qt 4 so application is not able to find the
QUrlQuery class.

Can you please share console log and Makefile when you run the qmake
command with project file ?

Thanks,
Neel Patel

On Tue, Aug 9, 2016 at 6:09 PM, Albe Laurenz 
wrote:

> Neel Patel wrote:
> >>  WebViewWindow.h:20:20: error: QWebView: No such file or directory
>
> > From the logs, it looks like - Qt webkit component is missing in Qt4
> installation.
> > Are you building Qt from source, If yes then there will be option in
> configure script to build Qt4
> > with webkit.
> > If you are not using source code, try installing webkit with yum (e.g.
> yum install libqt4-webkit).
>
> I found an appropriate RPM somewhere, now I have a different problem.
>
> I am building with Qt 4.6.2 from RHEL 6, which should be OK according to
> the README,
> but I am failing with
>
> g++ -c -m64 -pipe -I/usr/include/python2.6 -I/usr/include/python2.6 -O2 -g
> -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector
> --param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -W -D_REENTRANT
> -DPYTHON2 -DQT_NO_DEBUG -DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB
> -DQT_CORE_LIB -I/usr/lib64/qt4/mkspecs/linux-g++-64 -I.
> -I/usr/include/QtCore -I/usr/include/QtNetwork -I/usr/include/QtGui
> -I/usr/include/QtWebKit -I/usr/include -I. -I. -o BrowserWindow.o
> BrowserWindow.cpp
> BrowserWindow.cpp: In member function ‘void BrowserWindow::
> unsupportedContent(QNetworkReply*)’:
> BrowserWindow.cpp:446: error: ‘QUrlQuery’ was not declared in this scope
> BrowserWindow.cpp:446: error: expected ‘;’ before ‘query_data’
> BrowserWindow.cpp:447: error: ‘query_data’ was not declared in this scope
> BrowserWindow.cpp: In member function ‘bool 
> BrowserWindow::checkClientDownload(const
> QUrl&, const QNetworkRequest&)’:
> BrowserWindow.cpp:681: error: ‘QUrlQuery’ was not declared in this scope
> BrowserWindow.cpp:681: error: expected ‘;’ before ‘downloadData’
> BrowserWindow.cpp:683: error: ‘downloadData’ was not declared in this scope
> make: *** [BrowserWindow.o] Error 1
>
> The code uses QUrlQuery, but according to http://doc.qt.io/qt-5/
> qurlquery.html
> this class has existed only since 5.0.
>
> Seems to be either a documentation bug (Qt 5 required) or a code bug.
> Can you help?
>
> Yours,
> Laurenz Albe
>

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Ashesh Vashi

On Tue, Aug 9, 2016 at 6:34 PM, Dave Page  wrote:

>
>
> On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
>>>  wrote:
>>> > Hi,
>>> >
>>> > PFA patch to fix the issue where message panel was showing incomplete
>>> info.
>>> > We may still miss some messages from Psycopg2 driver due to limited
>>> size of
>>> > notices queue.
>>> > (RM#1523)
>>>
>>> A few thoughts on this (mostly based on my discussions with Ashesh):
>>>
>>> 1) You seem to have removed the poll delay. I assume that is to try to
>>> avoid missing messages? Can we re-introduce the delay (to avoid
>>> excessive network requests), but collect messages while we're waiting?
>>>
>> Using thread?
>> Start a thread during the timeout?
>>
>
> Not necessarily. If we want a 2 second polling delay, we could just sleep
> for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages,
>  return to client.
>
That's a very huge delay in practical.
We were hardly waiting for during poll (that was in milliseconds), but -
still we were loosing a lot of the messages. (a lot more from the current
implementation).

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
>>
>>> 2) If I run VACUUM, whilst I see messages as I should now, there is no
>>> query time summary as there is for a query that returns data.
>>>
>>
>>> 3) Can we incrementally display messages? e.g. each time we poll, we
>>> add the new messages to the messages div, and scroll to the end
>>> automatically?
>>
>> Yeah - that's a good idea.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
>>
>>
>>
>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Ashesh Vashi

On Tue, Aug 9, 2016 at 6:47 PM, Dave Page  wrote:

>
>
> On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Tue, Aug 9, 2016 at 6:34 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 On Tue, Aug 9, 2016 at 6:28 PM, Dave Page  wrote:

> Hi
>
> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
>  wrote:
> > Hi,
> >
> > PFA patch to fix the issue where message panel was showing
> incomplete info.
> > We may still miss some messages from Psycopg2 driver due to limited
> size of
> > notices queue.
> > (RM#1523)
>
> A few thoughts on this (mostly based on my discussions with Ashesh):
>
> 1) You seem to have removed the poll delay. I assume that is to try to
> avoid missing messages? Can we re-introduce the delay (to avoid
> excessive network requests), but collect messages while we're waiting?
>
 Using thread?
 Start a thread during the timeout?

>>>
>>> Not necessarily. If we want a 2 second polling delay, we could just
>>> sleep for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages,
>>>  return to client.
>>>
>> That's a very huge delay in practical.
>> We were hardly waiting for during poll (that was in milliseconds), but -
>> still we were loosing a lot of the messages. (a lot more from the current
>> implementation).
>>
>
> What was the original delay? Now there appears to be none at all.
>
That was 10 milliseconds.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
>>>

> 2) If I run VACUUM, whilst I see messages as I should now, there is no
> query time summary as there is for a query that returns data.
>

> 3) Can we incrementally display messages? e.g. each time we poll, we
> add the new messages to the messages div, and scroll to the end
> automatically?

 Yeah - that's a good idea.

 --

 Thanks & Regards,

 Ashesh Vashi
 EnterpriseDB INDIA: Enterprise PostgreSQL Company
 


 *http://www.linkedin.com/in/asheshvashi*
 

>




> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Dave Page

On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi 
wrote:

> On Tue, Aug 9, 2016 at 6:34 PM, Dave Page  wrote:
>
>>
>>
>> On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page  wrote:
>>>
 Hi

 On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
  wrote:
 > Hi,
 >
 > PFA patch to fix the issue where message panel was showing incomplete
 info.
 > We may still miss some messages from Psycopg2 driver due to limited
 size of
 > notices queue.
 > (RM#1523)

 A few thoughts on this (mostly based on my discussions with Ashesh):

 1) You seem to have removed the poll delay. I assume that is to try to
 avoid missing messages? Can we re-introduce the delay (to avoid
 excessive network requests), but collect messages while we're waiting?

>>> Using thread?
>>> Start a thread during the timeout?
>>>
>>
>> Not necessarily. If we want a 2 second polling delay, we could just sleep
>> for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages,
>>  return to client.
>>
> That's a very huge delay in practical.
> We were hardly waiting for during poll (that was in milliseconds), but -
> still we were loosing a lot of the messages. (a lot more from the current
> implementation).
>

What was the original delay? Now there appears to be none at all.


>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>>
>>>
 2) If I run VACUUM, whilst I see messages as I should now, there is no
 query time summary as there is for a query that returns data.

>>>
 3) Can we incrementally display messages? e.g. each time we poll, we
 add the new messages to the messages div, and scroll to the end
 automatically?
>>>
>>> Yeah - that's a good idea.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> 
>>>

>>>
>>>
>>>
>>>
 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 --
 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
 To make changes to your subscription:
 http://www.postgresql.org/mailpref/pgadmin-hackers

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Dave Page

On Tue, Aug 9, 2016 at 2:21 PM, Ashesh Vashi 
wrote:

> On Tue, Aug 9, 2016 at 6:47 PM, Dave Page  wrote:
>
>>
>>
>> On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Tue, Aug 9, 2016 at 6:34 PM, Dave Page  wrote:
>>>


 On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
>>  wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue where message panel was showing
>> incomplete info.
>> > We may still miss some messages from Psycopg2 driver due to limited
>> size of
>> > notices queue.
>> > (RM#1523)
>>
>> A few thoughts on this (mostly based on my discussions with Ashesh):
>>
>> 1) You seem to have removed the poll delay. I assume that is to try to
>> avoid missing messages? Can we re-introduce the delay (to avoid
>> excessive network requests), but collect messages while we're waiting?
>>
> Using thread?
> Start a thread during the timeout?
>

 Not necessarily. If we want a 2 second polling delay, we could just
 sleep for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages,
  return to client.

>>> That's a very huge delay in practical.
>>> We were hardly waiting for during poll (that was in milliseconds), but -
>>> still we were loosing a lot of the messages. (a lot more from the current
>>> implementation).
>>>
>>
>> What was the original delay? Now there appears to be none at all.
>>
> That was 10 milliseconds
>

Hmm, Ok - for some reason I thought it was much longer. Ignore that point
then :-)

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin 4 as Web application

2016-08-09 Thread Albe Laurenz

Neel Patel wrote:
> We already have condition for QUrlQuery class as below. It will be used only 
> if Qt version is >= 5.0.
> 
> #if QT_VERSION >= 0x05
> // Extract filename and query from encoded URL
> QUrlQuery query_data(reply->url());
> QString file_name = query_data.queryItemValue("filename");
> QString query = query_data.queryItemValue("query");
> #else
> QUrl url(reply->url());
> QString file_name = url.queryItemValue("filename");
> QString query = url.queryItemValue("query");
> #endif

Oh, I see now, thank you for the help.
I was missing commit dcf5bfc495bea1d5b28c389335cbd89e73468aaa (I downloaded
the pgadmin4-1.0-beta3 source).

After editing the file, I can build it, but when starting "pgadmin4" I get

Full Python path:  ""
User Python path:  ""
Webapp path:  "/MYSQL/mysqldata/fs1/rpmbuild/pgadmin4-1.0-beta3/web/pgAdmin4.py"
Traceback (most recent call last):
  File "/MYSQL/mysqldata/fs1/rpmbuild/pgadmin4-1.0-beta3/web/pgAdmin4.py", line 
24, in 
from pgadmin import create_app
  File 
"/MYSQL/mysqldata/fs1/rpmbuild/pgadmin4-1.0-beta3/web/pgadmin/__init__.py", 
line 281
arch_keys = {0}
  ^
SyntaxError: invalid syntax

The same happens when I try to start it as web application.

My system has
Python 2.6.6
Qt 4.6.2
Apache httpd 2.2.15

What could be the problem?

Yours,
Laurenz Albe

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] RM #1461 Query tool button/menu inconsistencies

2016-08-09 Thread Akshay Joshi

Hi All

Attached is the patch to fix RM #1461 Query tool button/menu
inconsistencies. Please review it and let me know the review comments.

-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


RM_1461.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Test suite enhancements:

2016-08-09 Thread Dave Page

Test suite enhancements:

1. The user will specify the tablespace path in test_config.json.in
2.  If tablespace path not found, skip the test cases for that server(Only 
tablespace test cases)
3.  Add the skipped test summary in the test result. (Now it's showing on 
console + in log file, but need to update in a final enhanced test summary 
report. Which is research point we will work on that after finishing all nodes 
API test cases)
4.  Removed the test_ prefix from the values in the config files.
5. Add tablespace and roles tests

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=81e2bc1e80388474256080bcd4226e3a0356ffe2
Author: Navnath Gadakh 

Modified Files
--
.../servers/databases/tests/test_db_add.py |  38 ++-
.../servers/databases/tests/test_db_delete.py  |  49 ++--
.../servers/databases/tests/test_db_get.py |  37 ++-
.../servers/databases/tests/test_db_put.py |  43 ++-
.../server_groups/servers/databases/tests/utils.py | 176 
.../server_groups/servers/roles/tests/__init__.py  |  16 ++
.../servers/roles/tests/test_role_add.py   |  55 
.../servers/roles/tests/test_role_delete.py|  58 
.../servers/roles/tests/test_role_get.py   |  67 +
.../servers/roles/tests/test_role_put.py   |  84 ++
.../server_groups/servers/roles/tests/utils.py | 187 +
.../servers/tablespaces/tests/__init__.py  |  16 ++
.../servers/tablespaces/tests/test_tbspc_add.py|  55 
.../servers/tablespaces/tests/test_tbspc_delete.py |  58 
.../servers/tablespaces/tests/test_tbspc_get.py|  78 ++
.../servers/tablespaces/tests/test_tbspc_put.py|  90 ++
.../servers/tablespaces/tests/utils.py | 195 +
.../server_groups/servers/tests/test_server_add.py |  22 +-
.../servers/tests/test_server_delete.py|  28 +-
.../server_groups/servers/tests/test_server_get.py |  22 +-
.../server_groups/servers/tests/test_server_put.py |  27 +-
.../browser/server_groups/servers/tests/utils.py   | 160 +++
.../browser/server_groups/tests/test_sg_get.py |   2 +-
web/pgadmin/browser/tests/test_change_password.py  | 102 ---
web/pgadmin/browser/tests/test_login.py|  24 +-
web/pgadmin/browser/tests/test_logout.py   |   8 +-
web/pgadmin/browser/tests/test_reset_password.py   |  12 +-
web/pgadmin/browser/tests/utils.py |  21 ++
web/pgadmin/utils/route.py |   5 +-
web/regression/README  |  39 +--
web/regression/test_advanced_config.json.in| 172 
web/regression/test_config.json.in |  48 ++--
web/regression/test_setup.py   |  22 +-
web/regression/test_utils.py   | 302 ++---
34 files changed, 1689 insertions(+), 629 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-08-09 Thread Dave Page

Thanks - applied with some minor wording and README tweaks.

On Tue, Aug 9, 2016 at 10:19 AM, Navnath Gadakh
 wrote:
> Hi Dave,
>
> On Mon, Aug 8, 2016 at 9:15 PM, Dave Page 
> wrote:
>>
>> Hi
>>
>> I guess you need to test if tablespace_path is omitted, not just empty?
>
> Yes, thats right.. Please find the updated patch.
>>
>>
>> This function test the add tablespace scenario (Check Tablespace Node) ...
>> ERROR
>>
>> ==
>> ERROR: setUpClass
>>
>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_put.py",
>> line 48, in setUpClass
>> cls.server_group, cls.server_ids)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 122, in add_table_space
>> data = get_tablespace_data(server_connect)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 41, in get_tablespace_data
>> config_test_data['spc_location'] = server_config['tablespace_path']
>> KeyError: 'tablespace_path'
>>
>> ==
>> ERROR: setUpClass
>>
>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_delete.py",
>> line 46, in setUpClass
>> cls.server_group, cls.server_ids)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 122, in add_table_space
>> data = get_tablespace_data(server_connect)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 41, in get_tablespace_data
>> config_test_data['spc_location'] = server_config['tablespace_path']
>> KeyError: 'tablespace_path'
>>
>> ==
>> ERROR: setUpClass
>>
>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_get.py",
>> line 45, in setUpClass
>> cls.server_group, cls.server_ids)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 122, in add_table_space
>> data = get_tablespace_data(server_connect)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 41, in get_tablespace_data
>> config_test_data['spc_location'] = server_config['tablespace_path']
>> KeyError: 'tablespace_path'
>>
>> ==
>> ERROR: runTest
>> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
>> This function test the add tablespace scenario (Check Tablespace Node)
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/test_tbspc_add.py",
>> line 47, in runTest
>> self.server_ids)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 122, in add_table_space
>> data = get_tablespace_data(server_connect)
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tablespaces/tests/utils.py",
>> line 41, in get_tablespace_data
>> config_test_data['spc_location'] = server_config['tablespace_path']
>> KeyError: 'tablespace_path'
>>
>> --
>> Ran 14 tests in 9.326s
>>
>> FAILED (errors=4)
>>
>> On Mon, Aug 8, 2016 at 3:07 PM, Navnath Gadakh
>>  wrote:
>> > Hi Dave,
>> > Please find the updated patch for API unit test cases for Roles and
>> > Tablespaces nodes
>> > As we finalized
>> > Now,
>> >1. The user will specify the tablespace path in test_config.json.in
>> >2.  If tablespace path not found, skip the test cases for that
>> > server(Only tablespace test cases)
>> >3.  Add the skipped test summary in the test result. (Now it's
>> > showing on
>> > console + in log file, but need to update in a final enhanced test
>> > summary
>> > report. Which is research point we will work

Re: [pgadmin-hackers] RM #1461 Query tool button/menu inconsistencies

2016-08-09 Thread Dave Page

Thanks, committed with a couple of minor tweaks.

On Tue, Aug 9, 2016 at 3:07 PM, Akshay Joshi 
wrote:

> Hi All
>
> Attached is the patch to fix RM #1461 Query tool button/menu
> inconsistencies. Please review it and let me know the review comments.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Fix query tool button/menu inconsistencies. Fixes #14

2016-08-09 Thread Dave Page

Fix query tool button/menu inconsistencies. Fixes #1461

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=035066bd41941879ca73dfa26fb6d82261b4d8c8
Author: Akshay Joshi 

Modified Files
--
.../tools/datagrid/templates/datagrid/index.html | 20 +---
.../sqleditor/templates/sqleditor/js/sqleditor.js|  3 +++
2 files changed, 16 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [Patch][pgAdmin4]: RM1532 - Query Tool can get stuck waiting for query result

2016-08-09 Thread Surinder Kumar

Hi

When a query is running in query tool, the keyboard shortcuts should not
respond untill it finished execution.
Also, remove the string ** Error ** from generated error
message.

Please find attached patch and review.

Thanks,
Surinder Kumar


RM1532.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Re: [pgadmin-hackers] RM #1250 Collection node counts

[pgadmin-hackers] pgAdmin 4 commit: Add missing collection node child counts. Fixes #1250

Re: [pgadmin-hackers] RM #1250 Collection node counts

[pgadmin-hackers] pgAdmin 4 commit: Add missing updates from the previous commit.

Re: [pgadmin-hackers] pgAdmin 4 as Web application

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Re: [pgadmin-hackers] pgAdmin 4 as Web application

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

Re: [pgadmin-hackers] pgAdmin 4 as Web application

[pgadmin-hackers] RM #1461 Query tool button/menu inconsistencies

[pgadmin-hackers] pgAdmin 4 commit: Test suite enhancements:

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Re: [pgadmin-hackers] RM #1461 Query tool button/menu inconsistencies

[pgadmin-hackers] pgAdmin 4 commit: Fix query tool button/menu inconsistencies. Fixes #14

[pgadmin-hackers] [Patch][pgAdmin4]: RM1532 - Query Tool can get stuck waiting for query result

21 matches

Site Navigation

Mail list logo

Footer information