Re: [pgadmin-hackers] Database child node: Cast node patch

2016-10-05 Thread Dave Page
On Wed, Oct 5, 2016 at 7:31 AM, Priyanka Shendge
 wrote:
>
> On 4 October 2016 at 19:36, Dave Page  wrote:
>>
>> Hi
>>
>> On Tue, Oct 4, 2016 at 9:01 AM, Priyanka Shendge
>>  wrote:
>> > I applied this patch on clean machine and executed testsuite only for
>> > "cast"
>> > node, i did not face any issue.
>> > When i tried to execute testsuite for all nodes, i get same output as
>> > you
>> > mentioned above e-mail. (As few variable name
>> > have changed later on in test_utils.py file and those are yet to change
>> > in
>> > server and database API cases. So while importing
>> > those variables its throwing import error.)  Also, me and Navnath have
>> > verified that this output is not related to setup.py changes.
>> > (7175929cab984e070d15eb13625ab50459edf9ca)
>> >
>> > Could you please try running testsuite only for cast node (python
>> > regression/runtests.py --pkg
>> > browser.server_groups.servers.databases.casts)
>> > and let me know if there are any issues.
>>
>> No, I don't see the issue if I only run the cast tests.
>
>
> Correct.
>>
>>
>> I'm not sure how this helps though - I still see the problem if I run
>> all tests with the patch applied. If I revert the patch, it goes away.
>> Therefore it's definitely being triggered by the cast patch, if not,
>> caused by it.
>
>
> Yes, the import errors you are getting its because "Cast" patch, as i
> have changed the variables name from ../regression/__init__.py and
> test_setup.py file.
> In code cleanup we have removed variables(like picke_path,
> advanced_config_path) from test_setup.py.
> Those variables have reference to all API cases, which are need to change
> (except cast).
> We are integrating these changes along with new code to other API cases. For
> now you can you please
> ignore these errors? Once all API cases are in place there wont be any
> issues seen.

No, sorry. We don't commit changes that introduce known errors into GA code.

-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] PATCH: To fix issue in synonym node (pgAdmin4)

2016-10-05 Thread Murtuza Zabuawala
Hi,

PFA patch to fix the issue in synonym node, where it was not horning parent
node while creating in different node, issue was that we were not sending
node properly.
RM#1611

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1611.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin4 as web application on CentOS

2016-10-05 Thread Olav Peeters
Hi,
I installed pgAdmin4 as follows on CentOS 7:
yum install
https://download.postgresql.org/pub/repos/yum/9.6/redhat/rhel-7-x86_64/pgdg-redhat96-9.6-3.noarch.rpm

yum install pgadmin4 httpd mod_wsgi
(on CentOS 7 this means httpd 2.4.6, mod_wsgi 3.4-12 and pgadmin4 1.0-1)

This does not install pgAdmin4.wsgi to the location as specified in:
https://www.pgadmin.org/docs4/dev/server_deployment.html#apache-httpd-configuration-linux-unix

pgAdmin4.wsgi can be found here:
/usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.wsgi

Hence I changed the httpd configuration to:


ServerName our.server.com

WSGIDaemonProcess pgadmin processes=1 threads=25
WSGIScriptAlias /
/usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.wsgi


WSGIProcessGroup pgadmin
WSGIApplicationGroup %{GLOBAL}
Require all granted



After restarting the httpd there is an error in /var/log/httpd/error_log
concerning write access to /usr/share/httpd/.pgadmin. Hence I did:
chown -R apache:apache /usr/share/httpd since all was root:root before.
So far so good, but when I restart httpd and try to access pgadmin via
our.server.com I get the following in /var/log/httpd/error_log:

[Wed Oct 05 11:59:44.815735 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] mod_wsgi (pid=3771): Target WSGI script
'/usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.wsgi' cannot be
loaded as Python module.
[Wed Oct 05 11:59:44.815797 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] mod_wsgi (pid=3771): Exception occurred processing
WSGI script '/usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.wsgi'.
[Wed Oct 05 11:59:44.815821 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] Traceback (most recent call last):
[Wed Oct 05 11:59:44.815839 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.wsgi", line 8, in

[Wed Oct 05 11:59:44.815906 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] from pgAdmin4 import app as application
[Wed Oct 05 11:59:44.815916 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.py", line 58, in

[Wed Oct 05 11:59:44.815965 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] app = create_app()
[Wed Oct 05 11:59:44.815974 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib/python2.7/site-packages/pgadmin4-web/pgadmin/__init__.py", line
213, in create_app
[Wed Oct 05 11:59:44.816083 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] version =
Version.query.filter_by(name='ConfigDB').first()
[Wed Oct 05 11:59:44.816093 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py", line 2659, in
first
[Wed Oct 05 11:59:44.816768 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] ret = list(self[0:1])
[Wed Oct 05 11:59:44.816783 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py", line 2457, in
__getitem__
[Wed Oct 05 11:59:44.816799 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] return list(res)
[Wed Oct 05 11:59:44.816805 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py", line 2761, in
__iter__
[Wed Oct 05 11:59:44.816813 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] return self._execute_and_instances(context)
[Wed Oct 05 11:59:44.816819 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib64/python2.7/site-packages/sqlalchemy/orm/query.py", line 2776, in
_execute_and_instances
[Wed Oct 05 11:59:44.816827 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] result = conn.execute(querycontext.statement,
self._params)
[Wed Oct 05 11:59:44.816832 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 914, in
execute
[Wed Oct 05 11:59:44.817478 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] return meth(self, multiparams, params)
[Wed Oct 05 11:59:44.817497 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib64/python2.7/site-packages/sqlalchemy/sql/elements.py", line 323,
in _execute_on_connection
[Wed Oct 05 11:59:44.818162 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] return connection._execute_clauseelement(self,
multiparams, params)
[Wed Oct 05 11:59:44.818174 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 1010,
in _execute_clauseelement
[Wed Oct 05 11:59:44.818214 2016] [:error] [pid 3771] [remote
ip-of-our-server:188] compiled_sql, distilled_params
[Wed Oct 05 11:59:44.818225 2016] [:error] [pid 3771] [remote
ip-of-our-server:188]   File
"/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 1146,
in _e

[pgadmin-hackers] pgAdmin 4 commit: Fix SSL setup. Fixes #1817

2016-10-05 Thread Dave Page
Fix SSL setup. Fixes #1817

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bde3dd845b1128d598da0f633b73520aa628a110
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] PATCH: To fix the issue where pgAdmin4 was not honouring ssl mode options (pgAdmin4)

2016-10-05 Thread Dave Page
Thanks, applied.

On Wed, Oct 5, 2016 at 7:23 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA minor patch to fix the issue where pgAdmin4 was not honouring ssl mode
> options.
> RM#1817
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] PATCH: To fix issue in synonym node (pgAdmin4)

2016-10-05 Thread Dave Page
Hi

On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue in synonym node, where it was not horning parent
> node while creating in different node, issue was that we were not sending
> node properly.
> RM#1611

That doesn't seem like a reliable way to get the correct parent ID -
what if there are multiple synonyms in different schemas but with the
same name?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-05 Thread Murtuza Zabuawala
Hi Dave,

PFA updated patch for the same.
RM#1227

Please review.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Oct 3, 2016 at 6:05 PM, Dave Page  wrote:

> Hi
>
> On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala
>  wrote:
> > Hi Dave,
> >
> > PFA updated patch to fix mentioned issue as well as incremental msgs
> updates
> > in Messages Tab.
>
> This doesn't seem to work well. In pgAdmin 4 I get the following:
>
> 
> SELECT 1
> INFO: EMPNO ENAME
>
>
> INFO: - ---
>
>
> SELECT 1
> SELECT 1
> SELECT 1
> INFO: 7369 SMITH
>
>
> SELECT 1
> SELECT 1
> INFO: 7499 ALLEN
>
>
> SELECT 1
> SELECT 1
> INFO: 7521 WARD
>
>
> SELECT 1
> SELECT 1
> INFO: 7566 JONES
>
>
> SELECT 1
> SELECT 1
> INFO: 7654 MARTIN
>
>
> SELECT 1
> INFO: 7698 BLAKE
>
>
> SELECT 1
> SELECT 1
> SELECT 1
> INFO: 7782 CLARK
>
>
> SELECT 1
> SELECT 1
> INFO: 7788 SCOTT
>
>
> SELECT 1
> SELECT 1
> INFO: 7839 KING
>
>
> SELECT 1
> SELECT 1
> INFO: 7844 TURNER
>
>
> SELECT 1
> SELECT 1
> INFO: 7876 ADAMS
>
>
> SELECT 1
> INFO: 7900 JAMES
>
>
> SELECT 1
> SELECT 1
> INFO: 7902 FORD
>
>
> SELECT 1
> SELECT 1
> SELECT 1
> INFO: 7934 MILLER
>
>
> SELECT 1
> SELECT 1
> SELECT 1
> SELECT 1
> 
>
> Whilst in pgAdmin III I get:
>
> 
> INFO:  EMPNOENAME
> INFO:  ----
> INFO:  7369 SMITH
> INFO:  7499 ALLEN
> INFO:  7521 WARD
> INFO:  7566 JONES
> INFO:  7654 MARTIN
> INFO:  7698 BLAKE
> INFO:  7782 CLARK
> INFO:  7788 SCOTT
> INFO:  7839 KING
> INFO:  7844 TURNER
> INFO:  7876 ADAMS
> INFO:  7900 JAMES
> INFO:  7902 FORD
> INFO:  7934 MILLER
> SELECT 1
> 
>
> Sidenote: pgAdmin III uses a fixed-width font for this output which
> works far better than pgAdmin 4's variable width font.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_1227_v3.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] PATCH: To fix issue in synonym node (pgAdmin4)

2016-10-05 Thread Murtuza Zabuawala
Hi Dave,

PFA updated patch, Added schema filter in sql.
Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Oct 5, 2016 at 5:38 PM, Dave Page  wrote:

> Hi
>
> On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala
>  wrote:
> > Hi,
> >
> > PFA patch to fix the issue in synonym node, where it was not horning
> parent
> > node while creating in different node, issue was that we were not sending
> > node properly.
> > RM#1611
>
> That doesn't seem like a reliable way to get the correct parent ID -
> what if there are multiple synonyms in different schemas but with the
> same name?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_1611_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] pgadmin4 RPMs need some testing!

2016-10-05 Thread Olav Peeters
Hi,
I posted an issue related to installing pgadmin4 on CentOS 7 via yum this
morning (see:
http://postgresql.nabble.com/pgAdmin4-as-web-application-on-CentOS-td5924512.html).
Can you have a look at it? I'll gladly help with testing.
Cheers,
Olav



--
View this message in context: 
http://postgresql.nabble.com/pgadmin4-RPMs-need-some-testing-tp5921120p5924544.html
Sent from the PostgreSQL - pgadmin hackers mailing list archive at Nabble.com.


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] PATCH: To fix issue in synonym node (pgAdmin4)

2016-10-05 Thread Dave Page
Hi

I created a synonym from within the "dave" schema, but selected
"public" (which wasn't expanded), and it placed the synonym as a
direct child of "public". See the attached screenshot.

On Wed, Oct 5, 2016 at 1:28 PM, Murtuza Zabuawala
 wrote:
> Hi Dave,
>
> PFA updated patch, Added schema filter in sql.
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Oct 5, 2016 at 5:38 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala
>>  wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue in synonym node, where it was not horning
>> > parent
>> > node while creating in different node, issue was that we were not
>> > sending
>> > node properly.
>> > RM#1611
>>
>> That doesn't seem like a reliable way to get the correct parent ID -
>> what if there are multiple synonyms in different schemas but with the
>> same name?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-05 Thread Dave Page
OK, that's much better. I think I've figured out what's causing the
remaining execution error as well - we're not disabling the buttons
until we get a response from the server, so if you click too quickly,
you make multiple requests at once. I tested this by adding a "SELECT
pg_sleep(2);" to a loop in a function.

If you can fix that as well, then I think we can call this issue fixed.

Thanks!

On Wed, Oct 5, 2016 at 1:09 PM, Murtuza Zabuawala
 wrote:
> Hi Dave,
>
> PFA updated patch for the same.
> RM#1227
>
> Please review.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Oct 3, 2016 at 6:05 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala
>>  wrote:
>> > Hi Dave,
>> >
>> > PFA updated patch to fix mentioned issue as well as incremental msgs
>> > updates
>> > in Messages Tab.
>>
>> This doesn't seem to work well. In pgAdmin 4 I get the following:
>>
>> 
>> SELECT 1
>> INFO: EMPNO ENAME
>>
>>
>> INFO: - ---
>>
>>
>> SELECT 1
>> SELECT 1
>> SELECT 1
>> INFO: 7369 SMITH
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7499 ALLEN
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7521 WARD
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7566 JONES
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7654 MARTIN
>>
>>
>> SELECT 1
>> INFO: 7698 BLAKE
>>
>>
>> SELECT 1
>> SELECT 1
>> SELECT 1
>> INFO: 7782 CLARK
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7788 SCOTT
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7839 KING
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7844 TURNER
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7876 ADAMS
>>
>>
>> SELECT 1
>> INFO: 7900 JAMES
>>
>>
>> SELECT 1
>> SELECT 1
>> INFO: 7902 FORD
>>
>>
>> SELECT 1
>> SELECT 1
>> SELECT 1
>> INFO: 7934 MILLER
>>
>>
>> SELECT 1
>> SELECT 1
>> SELECT 1
>> SELECT 1
>> 
>>
>> Whilst in pgAdmin III I get:
>>
>> 
>> INFO:  EMPNOENAME
>> INFO:  ----
>> INFO:  7369 SMITH
>> INFO:  7499 ALLEN
>> INFO:  7521 WARD
>> INFO:  7566 JONES
>> INFO:  7654 MARTIN
>> INFO:  7698 BLAKE
>> INFO:  7782 CLARK
>> INFO:  7788 SCOTT
>> INFO:  7839 KING
>> INFO:  7844 TURNER
>> INFO:  7876 ADAMS
>> INFO:  7900 JAMES
>> INFO:  7902 FORD
>> INFO:  7934 MILLER
>> SELECT 1
>> 
>>
>> Sidenote: pgAdmin III uses a fixed-width font for this output which
>> works far better than pgAdmin 4's variable width font.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers